From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 11 07:55:28 2024 Received: (at submit) by debbugs.gnu.org; 11 Dec 2024 12:55:28 +0000 Received: from localhost ([127.0.0.1]:33382 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tLMFU-0005ib-3O for submit@debbugs.gnu.org; Wed, 11 Dec 2024 07:55:28 -0500 Received: from lists.gnu.org ([209.51.188.17]:40644) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tLMFN-0005eD-Uj for submit@debbugs.gnu.org; Wed, 11 Dec 2024 07:55:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tLMFN-0005Vf-FQ for bug-guix@gnu.org; Wed, 11 Dec 2024 07:55:21 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tLMFK-0002QN-QM for bug-guix@gnu.org; Wed, 11 Dec 2024 07:55:21 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 2067E240101 for ; Wed, 11 Dec 2024 13:55:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1733921715; bh=ivbZb6hOoIe11uva2vrHx9QCpB36NSUNspU2Wvp2FPE=; h=Message-ID:Date:MIME-Version:From:Subject:To:Content-Type: Content-Transfer-Encoding:From; b=hWHEmNfhanWJCzG+wf/HeflW3vsnK/cdXTz7lsOxMigHbi25UM2O56oDZ1H8mP0Av Vgb/HFM6WSPupZP+OdUzoaSt/n9ZYp12PTnN6ycdztYDbno2g7Rxs95eHL1E8/n/A9 rwW7Bzl8/sTcij9h1PJ2suvp01nElF/DZFL3ScA2m7lgnRYnetwsvSrihLiP79Tx13 /Wf7dckGBJQsAkdC3l6RIuzJZve5Mkt4gFzgMOUmt9h8/8YE2mOaLng1ZFuGD5YkxX pdxwLtUBYIskTGfXwUrFwWzEUqqEb4X86ifVLnWPd9fYlOigo09xGH9pB64Oh5Bw7i zElFyPEJtW//w== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Y7bDL3vySz6twM for ; Wed, 11 Dec 2024 13:55:14 +0100 (CET) Message-ID: <2a5dd1c0-6548-46f6-9e31-9bc21811d252@posteo.net> Date: Wed, 11 Dec 2024 12:55:10 +0000 MIME-Version: 1.0 From: Dariqq Subject: guile-ssh@0.18 breaks offloading To: bug-guix@gnu.org Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=185.67.36.66; envelope-from=dariqq@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hello, Today I reconfigured my system and after a reboot offloading no longer works. When i try to build something that could be offloaded it instead tries to build it locally instead and fails with unsupported-platform while setting up the build environment: a `*' is required to build `*', but I am a `*' However 'guix offload test' is still succeeding --8<---------------cut here---------------start------------->8--- sudo guix offload test guix offload: testing 1 build machines defined in '/etc/guix/machines.scm'... guix offload: Guix is usable on '*' (test returned "/gnu/store/*-test") guix offload: '*' is running GNU Guile 3.0.9 guix offload: sending 1 store item (0 MiB) to '*'... exporting path `/gnu/store/*-export-test' guix offload: '*' successfully imported '/gnu/store/*-export-test' retrieving 1 store item from '*'... guix offload: successfully imported '/gnu/store/*-import-test' from '*' --8<---------------cut here---------------end--------------->8--- I tracked this down to the guile-ssh update in da3c8a963f83c044568d99921480259eaa26a923 Reverting that restores offloading for me. This might also be the cause for the 'guix deploy' error described in https://logs.guix.gnu.org/guix/2024-12-11.log#033439 From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 11 11:29:31 2024 Received: (at 74787) by debbugs.gnu.org; 11 Dec 2024 16:29:31 +0000 Received: from localhost ([127.0.0.1]:35903 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tLPac-00037Q-Kv for submit@debbugs.gnu.org; Wed, 11 Dec 2024 11:29:30 -0500 Received: from wolfsden.cz ([37.205.8.62]:33218) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <~@wolfsden.cz>) id 1tLPaa-00037D-Ke for 74787@debbugs.gnu.org; Wed, 11 Dec 2024 11:29:30 -0500 Received: by wolfsden.cz (Postfix, from userid 104) id 3B54D3506A7; Wed, 11 Dec 2024 16:29:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1733934567; bh=juVAUPIlGrC5hCvs4lnZ+eSzRMzNa+M4JYXvbS2cKPc=; h=From:To:Cc:Subject:Date; b=UpNJEBlIz4Ei1Sz+84aDxPeUWh4JkGwdij1QTxENyfg2bJaFwQpbKGYxZ9dS5pyZL BkxBjsQNfNZ6K0MDOocps57H4RXKuaJRbHjzoKKae0v0WXaGAfeEHwRYB0soa1pAF1 HEq5rcmhRHR9D5fF5L/OysfmImsX90MEjHMar9TnFyCLzCHSU6a5If0EXecpKRzNSr 1UROm2vQL60L0GhETmj1vehMawDrOHGw18L/0vrQOylw/tQzQluaGAASwBn0a3nR7e 56Lmzh7ckoaVIgqeKodD3kicMcGPtiZrSbVG2IwNUYkMn5Z68H+2N4OhNj0rqVkVLL qoJ9HoCxOLRiySo+i8dU2z5l52TEO031X6R7iisD2FwAsb9MCuhAJQDJO8+bYX1E3e Q8NekpxC+kB4Y54uCCiDS61Vor/kN9tV3gacSdVPsjNLNrM48ChmxL3AgS/qamx7ki foxb6P2/OznbDlqauiaVR7mmzU6qFExAdu9isTb+ppOSYatKlF6MV0kzXrY0rmzdy2 46WDM6tPWO1/z9/ab5S9+olndzGsC+scK9Su1Se1h0ROv7L/1CP1LvfzeWaaULQLiq siGeyz2fZMIDkEyqA7gkg0+Fl5jRPHJUV6VlfDi7itkOddNRNchgDkr8HtfibmQjsC 29MaTpbShkskLZ4C8OcTtFlI= X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on wolfsden X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (unknown [128.0.188.242]) by wolfsden.cz (Postfix) with ESMTPSA id D1B46350E09; Wed, 11 Dec 2024 16:29:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1733934566; bh=juVAUPIlGrC5hCvs4lnZ+eSzRMzNa+M4JYXvbS2cKPc=; h=From:To:Cc:Subject:Date; b=ZMUwWkfl28yV9lI6VzUoyI6pM+njKt4IdsB9BvqcdrF+R8pmMHiyT1Eqr187kwkIF LuG8fK57RGeXgYHK7XKkuRW9Jihif52m6UAzpFU5eqPLEHYZXMMx15gNE1QVLf7aif cCDhBYhqbQ6pe1D1fbWatba8rKfbm1w1abA0VdCHi3MjGbgtghkTHWepqqx+gHRIRh L++5AG4Vrp711o9zE2J1I9z1pegUmSCbFdLBgJ/xcGjm8+JBcSWFBZJzKE3ydh2p8X ZXrJeT2HLo9WfRGRvueGmDPuvbwovEX74IR6UY+SvPjzcCEN8M8HeQiCsu52tkd7hH AzbhfvSSUT08eAPQ66D/XDafcl//aLVU2ANlrch/ZlR9iYJlUvnr6v9m2lqoJR+wh/ +8R09Eb6puikySpvttaeXV1YNdhI/t2T9onoV5w6r5Z4OhRYLojiUJCj5WOFzx+yls hzyKz75Km5S0yyqd/PlQ3ASlUJ/81SfEjgYfVOXOPZcz8ckmSx1z4fnC/1H/dQzOwY 3hMTczS+LgtV2HWABZM6C/DgmXiZH4RNhy86PfjfzSRerIiyom8ALJ3ZSOELZmc4oI DKF52OdSeq8uotXNhi3utBsvkuQmw9RlqTJxGLq2W28dpuyfN6qNgDfKPPhiqKU9+7 8OnW+mjRdMjLAmK+s0v5Sld4= From: Tomas Volf <~@wolfsden.cz> To: 74787@debbugs.gnu.org, guix-patches@gnu.org Subject: [PATCH] remote: Do not double-quote the repl-command. Date: Wed, 11 Dec 2024 17:27:55 +0100 Message-ID: X-Mailer: git-send-email 2.46.0 MIME-Version: 1.0 X-Debbugs-Cc: Christopher Baines , Josselin Poiret , Ludovic Courtès , Mathieu Othacehe , Simon Tournier , Tobias Geerinckx-Rice Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74787 Cc: Tomas Volf <~@wolfsden.cz> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) In 0.18.0, the `open-remote-pipe*' now correctly quotes the arguments, so the double quoting that was done by `shell-quote' is not harmful and breaks at least offloading and deploy. * guix/remote.scm (remote-pipe-for-gexp): Call object->string just once. Change-Id: Id922d26d318bfdd4714e267687c1b27461196d90 --- I checked all places where the changed procedures are used and those look correct. Nothing else in the NEWS file for 0.18.0 jumps out as a potential issue. guix/remote.scm | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/guix/remote.scm b/guix/remote.scm index a58ec2103c..9423f9af12 100644 --- a/guix/remote.scm +++ b/guix/remote.scm @@ -48,9 +48,6 @@ (define-module (guix remote) (define* (remote-pipe-for-gexp lowered session #:optional become-command) "Return a remote pipe for the given SESSION to evaluate LOWERED. If BECOME-COMMAND is given, use that to invoke the remote Guile REPL." - (define shell-quote - (compose object->string object->string)) - (define repl-command (append (or become-command '()) (list @@ -65,7 +62,7 @@ (define* (remote-pipe-for-gexp lowered session #:optional become-command) `("-C" ,directory)) (lowered-gexp-load-path lowered)) `("-c" - ,(shell-quote (lowered-gexp-sexp lowered))))) + ,(object->string (lowered-gexp-sexp lowered))))) (let ((pipe (apply open-remote-pipe* session OPEN_READ repl-command))) (when (eof-object? (peek-char pipe)) -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 11 15:58:02 2024 Received: (at 74787) by debbugs.gnu.org; 11 Dec 2024 20:58:03 +0000 Received: from localhost ([127.0.0.1]:36458 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tLTmU-0006ru-5i for submit@debbugs.gnu.org; Wed, 11 Dec 2024 15:58:02 -0500 Received: from mout01.posteo.de ([185.67.36.65]:53197) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tLTmP-0006r1-MC for 74787@debbugs.gnu.org; Wed, 11 Dec 2024 15:58:00 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id B4A92240028 for <74787@debbugs.gnu.org>; Wed, 11 Dec 2024 21:57:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1733950671; bh=9Ms0Vg5kM9d9I+U4Ksck838ClmcCNuwLpVZP1poA9NQ=; h=Message-ID:Date:MIME-Version:Subject:From:To:Content-Type: Content-Transfer-Encoding:From; b=QLscU+OpM70JWhWsN7gc6oqvQtqHU3t0uB2LeqSCDtLaY+1T9UpwI/RN9k/zhPn5C U0JY8dzoPtl2IXeC4SRRoqV5Y0BMGHeMMlYWhLFRem1ZMMQIql3gdwpqv9a3fQ7O2v oR4nTCZkJC2tCzQNgfHld1lQ8zvAuEKGloCZWyxu8UinQrlHHFKEuc2myqQSGBk3KB noNq+eqk5dBV415tnljjl7NLmS3pmr15s2whdZTAPf2GnPo2X9qpEOgyBFX1cVP2Bf 73Xm+zdOxHl3Aqfc+TZ9WeIuDN+tPTk1rNpAF0YzUPwOlolSEruVrUnF++JJ23+9Ug vQDNuOMY+GmhQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Y7nxB0sjmz6tsb for <74787@debbugs.gnu.org>; Wed, 11 Dec 2024 21:57:49 +0100 (CET) Message-ID: <27ad57f4-efab-4b23-8322-d1d8d5c7a584@posteo.net> Date: Wed, 11 Dec 2024 20:57:46 +0000 MIME-Version: 1.0 Subject: Re: guile-ssh@0.18 breaks offloading From: Dariqq To: 74787@debbugs.gnu.org References: <2a5dd1c0-6548-46f6-9e31-9bc21811d252@posteo.net> Content-Language: en-US In-Reply-To: <2a5dd1c0-6548-46f6-9e31-9bc21811d252@posteo.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74787 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Another problem (other than the open-input-pipe* change) related to the guile-ssh update is that the GUIX_CHECK_GUILE_SSH macro now fails resulting in the guix-daemon not having offload support. I openend https://issues.guix.gnu.org/74800 for this From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 12 06:46:12 2024 Received: (at submit) by debbugs.gnu.org; 12 Dec 2024 11:46:12 +0000 Received: from localhost ([127.0.0.1]:37973 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tLhe0-000353-4J for submit@debbugs.gnu.org; Thu, 12 Dec 2024 06:46:12 -0500 Received: from lists.gnu.org ([209.51.188.17]:48546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tLhdu-00034Z-5L for submit@debbugs.gnu.org; Thu, 12 Dec 2024 06:46:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tLhdr-0006nA-M0 for guix-patches@gnu.org; Thu, 12 Dec 2024 06:46:04 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tLhdo-00076J-Nd; Thu, 12 Dec 2024 06:46:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=3927UCsTG9CFdJc5lWkOrA960Myb1DshXq2jFxej76M=; b=kphYv/KmiY1Ed/91od3a faA82XbmGsym9pbuHKo3IdZSSpEKl5ztVGZSki10jncmZkH4ghQljkYuk+N6B9nDFxdTWTUVziAbl FDnQjJ4nIDiI5BjVoofJ2345AO+0V+LrmmTbvJ7ZjHXoud6RE0Mfd7Ql2bJJL/obPo85Kcoh65n2t kSb/jyN87E360MOE8GZI6k7SULmcb9Pk7kki7i+NHTfJtTyfI1+ZzG24x7KUo1pInHfuMelQ68+6J R6AdO59xlJOmFvGoULItAbW2//9VGatQKxmpSLXZq8tFx4a/4ewtu4CQjfGbsz77dkSqJTx2+SCUf /KfPIwaX634y+w==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Tomas Volf <~@wolfsden.cz> Subject: Re: bug#74787: guile-ssh@0.18 breaks offloading In-Reply-To: (Tomas Volf's message of "Wed, 11 Dec 2024 17:27:55 +0100") References: <2a5dd1c0-6548-46f6-9e31-9bc21811d252@posteo.net> Date: Thu, 12 Dec 2024 12:45:56 +0100 Message-ID: <87y10l9laj.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: Josselin Poiret , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , Dariqq , Christopher Baines , 74787-done@debbugs.gnu.org, guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Tomas and Dariqq, Tomas Volf <~@wolfsden.cz> skribis: > In 0.18.0, the `open-remote-pipe*' now correctly quotes the arguments, so= the > double quoting that was done by `shell-quote' is not harmful and breaks at > least offloading and deploy. > > * guix/remote.scm (remote-pipe-for-gexp): Call object->string just once. > > Change-Id: Id922d26d318bfdd4714e267687c1b27461196d90 Added the =E2=80=9CFixes=E2=80=9D and =E2=80=9CReported-by=E2=80=9D lines t= o the log and committed. Thanks! Ludo=E2=80=99. From unknown Sat Jun 21 12:32:26 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 09 Jan 2025 12:24:13 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator