GNU bug report logs - #74781
[PATCH] Add `browse-url-qutebrowser'

Previous Next

Full log

Message #17 received at 74781 <at> debbugs.gnu.org (full text, mbox):

From: Daniel Mendler <mail <at> daniel-mendler.de>
To: Robert Pluim <rpluim <at> gmail.com>
Cc: 74781 <at> debbugs.gnu.org
Subject: Re: bug#74781: [PATCH] Add `browse-url-qutebrowser'
Date: Wed, 11 Dec 2024 11:45:38 +0100

[Message part 1 (text/plain, inline)]

Robert Pluim <rpluim <at> gmail.com> writes:

>>>>>> On Wed, 11 Dec 2024 10:07:08 +0100, Daniel Mendler <mail <at> daniel-mendler.de> said:
> The emacs help system applies heuristics which are not always
> accurate, and donʼt always return an answer, hence the version tags.

Thanks, I added the version tags. See the updated patch.

>     >> We have `xdg-runtime-dir' in xdg.el
>
>     Daniel> The goal was to avoid loading `xdg.el' unnecessarily for this trivial
>     Daniel> function, which is just a wrapper around `getenv'. Do you suggest to use
>     Daniel> `declare-function' and require xdg inside `browse-url-qutebrowser-send'?
>
> That would work.

I would be pragmatic and keep the (getenv "XDG_RUNTIME_DIR"), instead of
replacing it by this:

(declare-function xdg-runtime-dir "xdg")
(require 'xdg)
(xdg-runtime-dir)

Daniel

[0001-Add-browse-url-qutebrowser.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.