GNU bug report logs - #74755
etc/git/pre-push: Run guix git authenticate before check-channel-news

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Vagrant Cascadian <vagrant <at> debian.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#74755: closed (etc/git/pre-push: Run guix git authenticate
 before check-channel-news)
Date: Sun, 05 Jan 2025 21:26:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 05 Jan 2025 13:25:32 -0800
with message-id <877c79hs1f.fsf <at> wireframe>
and subject line Re: bug#74755: etc/git/pre-push: Run guix git authenticate before check-channel-news
has caused the debbugs.gnu.org bug report #74755,
regarding etc/git/pre-push: Run guix git authenticate before check-channel-news
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
74755: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=74755
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Vagrant Cascadian <vagrant <at> debian.org>
To: guix-patches <at> gnu.org
Cc: vagrant <at> debian.org
Subject: etc/git/pre-push: Run guix git authenticate before check-channel-news
Date: Mon, 09 Dec 2024 12:25:34 -0800

[Message part 3 (text/plain, inline)]

Running check-channel-news before authenticating the repository could
result in running unauthenticated code; the attached patch switches the
order they are run in.

live well,
  vagrant

[0001-etc-git-pre-push-Run-guix-git-authenticate-before-ch.patch (text/x-diff, inline)]

From 42bd8ceceada3ad764a450c040bc2a9a1e3f7842 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant <at> debian.org>
Date: Mon, 9 Dec 2024 12:21:30 -0800
Subject: [PATCH] etc: git: pre-push: Run guix git authenticate before
 check-channel-news.

Running check-channel-news first could potentially be untrusted code, so
authenticate first.

* etc/git/pre-push: Run guix git authenticate before check-channel-news.
---
 etc/git/pre-push | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/etc/git/pre-push b/etc/git/pre-push
index 325b23854b..752310d854 100755
--- a/etc/git/pre-push
+++ b/etc/git/pre-push
@@ -33,8 +33,8 @@ do
 		case "$2" in
 		    *.gnu.org*)
 			set -e
-			make check-channel-news
 			exec guix git authenticate
+			make check-channel-news
 			exit 127
 			;;
 		    *)

base-commit: da3c8a963f83c044568d99921480259eaa26a923
-- 
2.39.5

[signature.asc (application/pgp-signature, inline)]

[Message part 6 (message/rfc822, inline)]

From: Vagrant Cascadian <vagrant <at> debian.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 74755-done <at> debbugs.gnu.org
Subject: Re: bug#74755: etc/git/pre-push: Run guix git authenticate before
 check-channel-news
Date: Sun, 05 Jan 2025 13:25:32 -0800

[Message part 7 (text/plain, inline)]

On 2024-12-24, Ludovic Courtès wrote:
> Vagrant Cascadian <vagrant <at> debian.org> skribis:
>> From 42bd8ceceada3ad764a450c040bc2a9a1e3f7842 Mon Sep 17 00:00:00 2001
>> From: Vagrant Cascadian <vagrant <at> debian.org>
>> Date: Mon, 9 Dec 2024 12:21:30 -0800
>> Subject: [PATCH] etc: git: pre-push: Run guix git authenticate before
>>  check-channel-news.
>>
>> Running check-channel-news first could potentially be untrusted code, so
>> authenticate first.
>>
>> * etc/git/pre-push: Run guix git authenticate before check-channel-news.
>
> LGTM, thanks!

Pushed as:

ab9cda9ebd00073d5a0783919809f2e564f141e9 etc: git: pre-push: Run guix git authenticate before check-channel-news.

live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.