From unknown Sun Aug 17 01:23:23 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#74755] etc/git/pre-push: Run guix git authenticate before check-channel-news Resent-From: Vagrant Cascadian Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 09 Dec 2024 20:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 74755 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 74755@debbugs.gnu.org Cc: vagrant@debian.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.173377594817247 (code B ref -1); Mon, 09 Dec 2024 20:26:01 +0000 Received: (at submit) by debbugs.gnu.org; 9 Dec 2024 20:25:48 +0000 Received: from localhost ([127.0.0.1]:55836 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tKkKB-0004U7-Ko for submit@debbugs.gnu.org; Mon, 09 Dec 2024 15:25:47 -0500 Received: from lists.gnu.org ([209.51.188.17]:40568) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tKkK9-0004Tx-Oo for submit@debbugs.gnu.org; Mon, 09 Dec 2024 15:25:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tKkK8-0004RW-VQ for guix-patches@gnu.org; Mon, 09 Dec 2024 15:25:45 -0500 Received: from cascadia.aikidev.net ([2600:3c01:e000:267:0:a171:de7:c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tKkK7-0001x7-43 for guix-patches@gnu.org; Mon, 09 Dec 2024 15:25:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=debian.org; s=1.vagrant.user; t=1733775940; bh=GNmXlJy+TVwPiT2sQI0By2naaWg/O+BzLGqATDaD+9U=; h=From:To:Cc:Subject:Date:From; b=de5Plw0lA32Xw7ADqmGFTrrDi9Ytm9WGjYETWp3XHiDWeiYxONm1lNG4VwuwTe4MR ivWnGsCEqHIfnOoftVmU/a6CY6C4J9cXiI2xaCzlkuamblMFuMlmn3PP8lbm9DUfYm X2Qe/GdQqVlEjYyNxMt74uHAW8WaIZADeZplOt2Ubcgcld2zY5fodPKGeEIf+V0BCn cw6DdmbgLGna+M3lc9NkCerEcEbGkbFqLcE3Jj1MaubrPRZGxpATBjLIBBxq2UfI0j IKXYgVAMpejm5kRzhH2xRh+i3Ssu4YGouqwKqgdDaAjVNZpvkmn6gvs4BKcVomOXly 7F36X7jPmvBEg== Received: from localhost (unknown [IPv6:2600:3c01:e000:21:7:77:0:50]) by cascadia.aikidev.net (Postfix) with ESMTPSA id D497E2705; Mon, 9 Dec 2024 12:25:40 -0800 (PST) From: Vagrant Cascadian Date: Mon, 09 Dec 2024 12:25:34 -0800 Message-ID: <878qsovc1t.fsf@wireframe> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: none client-ip=2600:3c01:e000:267:0:a171:de7:c; envelope-from=vagrant@debian.org; helo=cascadia.aikidev.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.489, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Running check-channel-news before authenticating the repository could result in running unauthenticated code; the attached patch switches the order they are run in. live well, vagrant --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-etc-git-pre-push-Run-guix-git-authenticate-before-ch.patch Content-Transfer-Encoding: quoted-printable From=2042bd8ceceada3ad764a450c040bc2a9a1e3f7842 Mon Sep 17 00:00:00 2001 From: Vagrant Cascadian Date: Mon, 9 Dec 2024 12:21:30 -0800 Subject: [PATCH] etc: git: pre-push: Run guix git authenticate before check-channel-news. Running check-channel-news first could potentially be untrusted code, so authenticate first. * etc/git/pre-push: Run guix git authenticate before check-channel-news. =2D-- etc/git/pre-push | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/etc/git/pre-push b/etc/git/pre-push index 325b23854b..752310d854 100755 =2D-- a/etc/git/pre-push +++ b/etc/git/pre-push @@ -33,8 +33,8 @@ do case "$2" in *.gnu.org*) set -e =2D make check-channel-news exec guix git authenticate + make check-channel-news exit 127 ;; *) base-commit: da3c8a963f83c044568d99921480259eaa26a923 =2D-=20 2.39.5 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCZ1dSPwAKCRDcUY/If5cW qgyiAQCy7Qa8WrtiSZmrry3SIsRLARS2YCw/Fn18E9GvUlWP0QEA1h1o+QhF706H A+HJSSHoiee0JGPuvjTJ8qyTZetwSws= =yXMR -----END PGP SIGNATURE----- --==-=-=-- From unknown Sun Aug 17 01:23:23 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#74755] etc/git/pre-push: Run guix git authenticate before check-channel-news Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 24 Dec 2024 14:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74755 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Vagrant Cascadian Cc: 74755@debbugs.gnu.org Received: via spool by 74755-submit@debbugs.gnu.org id=B74755.173505131217058 (code B ref 74755); Tue, 24 Dec 2024 14:42:02 +0000 Received: (at 74755) by debbugs.gnu.org; 24 Dec 2024 14:41:52 +0000 Received: from localhost ([127.0.0.1]:60078 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQ66Z-0004R4-KW for submit@debbugs.gnu.org; Tue, 24 Dec 2024 09:41:51 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39510) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQ66Y-0004Qr-5S for 74755@debbugs.gnu.org; Tue, 24 Dec 2024 09:41:50 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQ66S-0008KV-Bj; Tue, 24 Dec 2024 09:41:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=3s4LNSametuJ0z4P4SIYihkzXHTvyG5TAeU/wDH9cIY=; b=fPSsRUK/2n2mjrR8nwLR u1ogJ7Ve2wVvrm7vXAMwuRmbpMZ7u6WknByOYdtTQYeB+/7hZIinr6q8geW1M3kULRgyztmkOHwdp 2+ANHpytgTu/2xsKoz3pNIQykkoVWtu0Kc9Le3kEgvmbXjoK+JwT3ZHy4P8eJf/fRqpTancpKbijw TIjhAiaSzDq/ibRUSyeKaJD+55y6DNTqs40rwPD9b/+/wIdt3vno0esHevH9RijcYnCmoaJ+52Suh gq0669DCDwLD+syZEfWCZeNn7TdydD6q7VCpWMGehV09q7hNjF/150pJIfYxtDjt6Hw0wc9OcCgKT 8nbU57fqMoVtRA==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <878qsovc1t.fsf@wireframe> (Vagrant Cascadian's message of "Mon, 09 Dec 2024 12:25:34 -0800") References: <878qsovc1t.fsf@wireframe> Date: Tue, 24 Dec 2024 15:41:42 +0100 Message-ID: <878qs55ejd.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Vagrant Cascadian skribis: > From 42bd8ceceada3ad764a450c040bc2a9a1e3f7842 Mon Sep 17 00:00:00 2001 > From: Vagrant Cascadian > Date: Mon, 9 Dec 2024 12:21:30 -0800 > Subject: [PATCH] etc: git: pre-push: Run guix git authenticate before > check-channel-news. > > Running check-channel-news first could potentially be untrusted code, so > authenticate first. > > * etc/git/pre-push: Run guix git authenticate before check-channel-news. LGTM, thanks! Ludo=E2=80=99. From unknown Sun Aug 17 01:23:23 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Vagrant Cascadian Subject: bug#74755: closed (Re: bug#74755: etc/git/pre-push: Run guix git authenticate before check-channel-news) Message-ID: References: <877c79hs1f.fsf@wireframe> <878qsovc1t.fsf@wireframe> X-Gnu-PR-Message: they-closed 74755 X-Gnu-PR-Package: guix-patches Reply-To: 74755@debbugs.gnu.org Date: Sun, 05 Jan 2025 21:26:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1736112362-13090-1" This is a multi-part message in MIME format... ------------=_1736112362-13090-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #74755: etc/git/pre-push: Run guix git authenticate before check-channel-ne= ws which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 74755@debbugs.gnu.org. --=20 74755: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D74755 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1736112362-13090-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 74755-done) by debbugs.gnu.org; 5 Jan 2025 21:25:46 +0000 Received: from localhost ([127.0.0.1]:35556 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tUY82-0003Og-7G for submit@debbugs.gnu.org; Sun, 05 Jan 2025 16:25:46 -0500 Received: from cascadia.aikidev.net ([173.255.214.101]:44686) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tUY7z-0003OM-J5 for 74755-done@debbugs.gnu.org; Sun, 05 Jan 2025 16:25:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=debian.org; s=1.vagrant.user; t=1736112337; bh=yyGEZ2VN2q0vfPIEH+u017wV/7ZXEpxaGTRSdZVRyQI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ob1Rfrd8OKDNP4gRTU3iPYQGqNnkO4O1mhAcyK8cOh1WkeQf4YSrMhnukwJyzzHEO NFod69J2F1Aw+MML9mCjDVEVACPTDjFKdIg6mKb+cqHISkNruP4m46RzPChdRwlHMg kkMcA7v8k25+l6ppj1iCv0DU2D1buPGR5SeIy8pPQ3QF2IkRW24Qn/bvhLuj8mXGxl h5+nuEkW8dG7CtdP1bmG72MpmKerQl5DIHi8wOLG4w1KPFthN7P0Mb8fNwhYJ3DQAY 3XNeCChlJpSslvO+Q/HTh0AqIy6FzPBdd04y8ilzl20i95uNRdeCOsXgvuUvcZuxi5 Qde9ysINNg0pw== Received: from localhost (unknown [IPv6:2600:3c01:e000:21:7:77:0:50]) by cascadia.aikidev.net (Postfix) with ESMTPSA id 7B5174928; Sun, 5 Jan 2025 13:25:37 -0800 (PST) From: Vagrant Cascadian To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#74755: etc/git/pre-push: Run guix git authenticate before check-channel-news In-Reply-To: <878qs55ejd.fsf@gnu.org> References: <878qsovc1t.fsf@wireframe> <878qs55ejd.fsf@gnu.org> Date: Sun, 05 Jan 2025 13:25:32 -0800 Message-ID: <877c79hs1f.fsf@wireframe> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74755-done Cc: 74755-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2024-12-24, Ludovic Court=C3=A8s wrote: > Vagrant Cascadian skribis: >> From 42bd8ceceada3ad764a450c040bc2a9a1e3f7842 Mon Sep 17 00:00:00 2001 >> From: Vagrant Cascadian >> Date: Mon, 9 Dec 2024 12:21:30 -0800 >> Subject: [PATCH] etc: git: pre-push: Run guix git authenticate before >> check-channel-news. >> >> Running check-channel-news first could potentially be untrusted code, so >> authenticate first. >> >> * etc/git/pre-push: Run guix git authenticate before check-channel-news. > > LGTM, thanks! Pushed as: ab9cda9ebd00073d5a0783919809f2e564f141e9 etc: git: pre-push: Run guix git a= uthenticate before check-channel-news. live well, vagrant --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCZ3r4zAAKCRDcUY/If5cW qtjgAQC2udNpGpEfJYwyip+q17QEvgxq2UbO35M97XUCuo5WTAD/XJz1UzYSXQlZ UVW1YB84pml+UNvNEEDwKi3cFQaBdgA= =Ndcw -----END PGP SIGNATURE----- --=-=-=-- ------------=_1736112362-13090-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 9 Dec 2024 20:25:48 +0000 Received: from localhost ([127.0.0.1]:55836 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tKkKB-0004U7-Ko for submit@debbugs.gnu.org; Mon, 09 Dec 2024 15:25:47 -0500 Received: from lists.gnu.org ([209.51.188.17]:40568) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tKkK9-0004Tx-Oo for submit@debbugs.gnu.org; Mon, 09 Dec 2024 15:25:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tKkK8-0004RW-VQ for guix-patches@gnu.org; Mon, 09 Dec 2024 15:25:45 -0500 Received: from cascadia.aikidev.net ([2600:3c01:e000:267:0:a171:de7:c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tKkK7-0001x7-43 for guix-patches@gnu.org; Mon, 09 Dec 2024 15:25:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=debian.org; s=1.vagrant.user; t=1733775940; bh=GNmXlJy+TVwPiT2sQI0By2naaWg/O+BzLGqATDaD+9U=; h=From:To:Cc:Subject:Date:From; b=de5Plw0lA32Xw7ADqmGFTrrDi9Ytm9WGjYETWp3XHiDWeiYxONm1lNG4VwuwTe4MR ivWnGsCEqHIfnOoftVmU/a6CY6C4J9cXiI2xaCzlkuamblMFuMlmn3PP8lbm9DUfYm X2Qe/GdQqVlEjYyNxMt74uHAW8WaIZADeZplOt2Ubcgcld2zY5fodPKGeEIf+V0BCn cw6DdmbgLGna+M3lc9NkCerEcEbGkbFqLcE3Jj1MaubrPRZGxpATBjLIBBxq2UfI0j IKXYgVAMpejm5kRzhH2xRh+i3Ssu4YGouqwKqgdDaAjVNZpvkmn6gvs4BKcVomOXly 7F36X7jPmvBEg== Received: from localhost (unknown [IPv6:2600:3c01:e000:21:7:77:0:50]) by cascadia.aikidev.net (Postfix) with ESMTPSA id D497E2705; Mon, 9 Dec 2024 12:25:40 -0800 (PST) From: Vagrant Cascadian To: guix-patches@gnu.org Subject: etc/git/pre-push: Run guix git authenticate before check-channel-news Date: Mon, 09 Dec 2024 12:25:34 -0800 Message-ID: <878qsovc1t.fsf@wireframe> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: none client-ip=2600:3c01:e000:267:0:a171:de7:c; envelope-from=vagrant@debian.org; helo=cascadia.aikidev.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.489, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: vagrant@debian.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Running check-channel-news before authenticating the repository could result in running unauthenticated code; the attached patch switches the order they are run in. live well, vagrant --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-etc-git-pre-push-Run-guix-git-authenticate-before-ch.patch Content-Transfer-Encoding: quoted-printable From=2042bd8ceceada3ad764a450c040bc2a9a1e3f7842 Mon Sep 17 00:00:00 2001 From: Vagrant Cascadian Date: Mon, 9 Dec 2024 12:21:30 -0800 Subject: [PATCH] etc: git: pre-push: Run guix git authenticate before check-channel-news. Running check-channel-news first could potentially be untrusted code, so authenticate first. * etc/git/pre-push: Run guix git authenticate before check-channel-news. =2D-- etc/git/pre-push | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/etc/git/pre-push b/etc/git/pre-push index 325b23854b..752310d854 100755 =2D-- a/etc/git/pre-push +++ b/etc/git/pre-push @@ -33,8 +33,8 @@ do case "$2" in *.gnu.org*) set -e =2D make check-channel-news exec guix git authenticate + make check-channel-news exit 127 ;; *) base-commit: da3c8a963f83c044568d99921480259eaa26a923 =2D-=20 2.39.5 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCZ1dSPwAKCRDcUY/If5cW qgyiAQCy7Qa8WrtiSZmrry3SIsRLARS2YCw/Fn18E9GvUlWP0QEA1h1o+QhF706H A+HJSSHoiee0JGPuvjTJ8qyTZetwSws= =yXMR -----END PGP SIGNATURE----- --==-=-=-- ------------=_1736112362-13090-1--