GNU bug report logs - #74740
31.0.50; tty menus not displaying separators

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 74740 in the body.
You can then email your comments to 74740 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gerd Möllmann <gerd.moellmann <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 31.0.50; tty menus not displaying separators
Date: Sun, 08 Dec 2024 18:34:33 +0100

To see this, emacs -nw -q and open a menu from the menubar. Simple
separators there are displayed as "--".

More generally, all separator types are displayed as they appear in the
menu item definition, '--double-line' as "--double-line" and so on.

In GNU Emacs 31.0.50 (build 1, aarch64-apple-darwin24.1.0) of 2024-12-08
 built on pro2
Repository revision: 9a0e26b88616946d2512680859166caa2675b30a
Repository branch: master
System Description:  macOS 15.1.1

Message #8 received at 74740 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Gerd Möllmann <gerd.moellmann <at> gmail.com>
Cc: 74740 <at> debbugs.gnu.org
Subject: Re: bug#74740: 31.0.50; tty menus not displaying separators
Date: Sun, 08 Dec 2024 20:33:41 +0200

> From: Gerd Möllmann <gerd.moellmann <at> gmail.com>
> Date: Sun, 08 Dec 2024 18:34:33 +0100
> 
> To see this, emacs -nw -q and open a menu from the menubar. Simple
> separators there are displayed as "--".

What did you expect instead?  I think this always worked like that on
TTY frames.

> More generally, all separator types are displayed as they appear in the
> menu item definition, '--double-line' as "--double-line" and so on.

What do you mean by that? where do we have such separators, and how do
you display the menus which show them?  I don't think I see them in
the default menu bar.

Message #11 received at 74740 <at> debbugs.gnu.org (full text, mbox):

From: Gerd Möllmann <gerd.moellmann <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 74740 <at> debbugs.gnu.org
Subject: Re: bug#74740: 31.0.50; tty menus not displaying separators
Date: Sun, 08 Dec 2024 19:46:35 +0100

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Gerd Möllmann <gerd.moellmann <at> gmail.com>
>> Date: Sun, 08 Dec 2024 18:34:33 +0100
>> 
>> To see this, emacs -nw -q and open a menu from the menubar. Simple
>> separators there are displayed as "--".
>
> What did you expect instead?  I think this always worked like that on
> TTY frames.
>
>> More generally, all separator types are displayed as they appear in the
>> menu item definition, '--double-line' as "--double-line" and so on.

I expected a horizontal line for "--".

> What do you mean by that? where do we have such separators, and how do
> you display the menus which show them?  I don't think I see them in
> the default menu bar.

Concerning the separator types, Elisp Info says

  23.18.1.3 Menu Separators
  .........................

  A menu separator is a kind of menu item that doesn't display any
  text--instead, it divides the menu into subparts with a horizontal line.
  A separator looks like this in the menu keymap:

       (menu-item SEPARATOR-TYPE)

  where SEPARATOR-TYPE is a string starting with two or more dashes.

followed by a list of separator types, among them the --double-line I
mentioned.

One can get these from 3rd-party packages. Minion is an example, where
--double-line appears in a popup menu on the mode line.

Message #14 received at 74740 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Gerd Möllmann <gerd.moellmann <at> gmail.com>
Cc: 74740 <at> debbugs.gnu.org
Subject: Re: bug#74740: 31.0.50; tty menus not displaying separators
Date: Sun, 08 Dec 2024 21:04:56 +0200

> From: Gerd Möllmann <gerd.moellmann <at> gmail.com>
> Cc: 74740 <at> debbugs.gnu.org
> Date: Sun, 08 Dec 2024 19:46:35 +0100
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> >> From: Gerd Möllmann <gerd.moellmann <at> gmail.com>
> >> Date: Sun, 08 Dec 2024 18:34:33 +0100
> >> 
> >> To see this, emacs -nw -q and open a menu from the menubar. Simple
> >> separators there are displayed as "--".
> >
> > What did you expect instead?  I think this always worked like that on
> > TTY frames.
> >
> >> More generally, all separator types are displayed as they appear in the
> >> menu item definition, '--double-line' as "--double-line" and so on.
> 
> I expected a horizontal line for "--".
> 
> > What do you mean by that? where do we have such separators, and how do
> > you display the menus which show them?  I don't think I see them in
> > the default menu bar.
> 
> Concerning the separator types, Elisp Info says
> 
>   23.18.1.3 Menu Separators
>   .........................
> 
>   A menu separator is a kind of menu item that doesn't display any
>   text--instead, it divides the menu into subparts with a horizontal line.
>   A separator looks like this in the menu keymap:
> 
>        (menu-item SEPARATOR-TYPE)
> 
>   where SEPARATOR-TYPE is a string starting with two or more dashes.
> 
> followed by a list of separator types, among them the --double-line I
> mentioned.
> 
> One can get these from 3rd-party packages. Minion is an example, where
> --double-line appears in a popup menu on the mode line.

This was never supported in TTY menus (I think I was completely
unaware of this feature when I wrote the code).  Patches to support it
will be most welcome.

Message #17 received at 74740 <at> debbugs.gnu.org (full text, mbox):

From: Gerd Möllmann <gerd.moellmann <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 74740 <at> debbugs.gnu.org
Subject: Re: bug#74740: 31.0.50; tty menus not displaying separators
Date: Mon, 09 Dec 2024 05:29:43 +0100

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Gerd Möllmann <gerd.moellmann <at> gmail.com>
>> Cc: 74740 <at> debbugs.gnu.org
>> Date: Sun, 08 Dec 2024 19:46:35 +0100
>> 
>> Eli Zaretskii <eliz <at> gnu.org> writes:
>> 
>> >> From: Gerd Möllmann <gerd.moellmann <at> gmail.com>
>> >> Date: Sun, 08 Dec 2024 18:34:33 +0100
>> >> 
>> >> To see this, emacs -nw -q and open a menu from the menubar. Simple
>> >> separators there are displayed as "--".
>> >
>> > What did you expect instead?  I think this always worked like that on
>> > TTY frames.
>> >
>> >> More generally, all separator types are displayed as they appear in the
>> >> menu item definition, '--double-line' as "--double-line" and so on.
>> 
>> I expected a horizontal line for "--".
>> 
>> > What do you mean by that? where do we have such separators, and how do
>> > you display the menus which show them?  I don't think I see them in
>> > the default menu bar.
>> 
>> Concerning the separator types, Elisp Info says
>> 
>>   23.18.1.3 Menu Separators
>>   .........................
>> 
>>   A menu separator is a kind of menu item that doesn't display any
>>   text--instead, it divides the menu into subparts with a horizontal line.
>>   A separator looks like this in the menu keymap:
>> 
>>        (menu-item SEPARATOR-TYPE)
>> 
>>   where SEPARATOR-TYPE is a string starting with two or more dashes.
>> 
>> followed by a list of separator types, among them the --double-line I
>> mentioned.
>> 
>> One can get these from 3rd-party packages. Minion is an example, where
>> --double-line appears in a popup menu on the mode line.
>
> This was never supported in TTY menus (I think I was completely
> unaware of this feature when I wrote the code).  Patches to support it
> will be most welcome.

The following patch displays "--" for all separator types. I'd say
that's good enough, WDYT?

[0001-Support-menu-separator-types-in-tty-menus-bug-74740.patch (text/x-patch, attachment)]

Message #20 received at 74740 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Gerd Möllmann <gerd.moellmann <at> gmail.com>
Cc: 74740 <at> debbugs.gnu.org
Subject: Re: bug#74740: 31.0.50; tty menus not displaying separators
Date: Mon, 09 Dec 2024 15:54:17 +0200

> From: Gerd Möllmann <gerd.moellmann <at> gmail.com>
> Cc: 74740 <at> debbugs.gnu.org
> Date: Mon, 09 Dec 2024 05:29:43 +0100
> 
> >>   23.18.1.3 Menu Separators
> >>   .........................
> >> 
> >>   A menu separator is a kind of menu item that doesn't display any
> >>   text--instead, it divides the menu into subparts with a horizontal line.
> >>   A separator looks like this in the menu keymap:
> >> 
> >>        (menu-item SEPARATOR-TYPE)
> >> 
> >>   where SEPARATOR-TYPE is a string starting with two or more dashes.
> >> 
> >> followed by a list of separator types, among them the --double-line I
> >> mentioned.
> >> 
> >> One can get these from 3rd-party packages. Minion is an example, where
> >> --double-line appears in a popup menu on the mode line.
> >
> > This was never supported in TTY menus (I think I was completely
> > unaware of this feature when I wrote the code).  Patches to support it
> > will be most welcome.
> 
> The following patch displays "--" for all separator types. I'd say
> that's good enough, WDYT?

Yes, LGTM, please install.  But please add a FIXME comment there
mentioning the feature and inviting its implementation.

Message #23 received at 74740 <at> debbugs.gnu.org (full text, mbox):

From: Gerd Möllmann <gerd.moellmann <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 74740 <at> debbugs.gnu.org
Subject: Re: bug#74740: 31.0.50; tty menus not displaying separators
Date: Mon, 09 Dec 2024 15:20:21 +0100

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Gerd Möllmann <gerd.moellmann <at> gmail.com>
>> Cc: 74740 <at> debbugs.gnu.org
>> Date: Mon, 09 Dec 2024 05:29:43 +0100
>> 
>> >>   23.18.1.3 Menu Separators
>> >>   .........................
>> >> 
>> >>   A menu separator is a kind of menu item that doesn't display any
>> >>   text--instead, it divides the menu into subparts with a horizontal line.
>> >>   A separator looks like this in the menu keymap:
>> >> 
>> >>        (menu-item SEPARATOR-TYPE)
>> >> 
>> >>   where SEPARATOR-TYPE is a string starting with two or more dashes.
>> >> 
>> >> followed by a list of separator types, among them the --double-line I
>> >> mentioned.
>> >> 
>> >> One can get these from 3rd-party packages. Minion is an example, where
>> >> --double-line appears in a popup menu on the mode line.
>> >
>> > This was never supported in TTY menus (I think I was completely
>> > unaware of this feature when I wrote the code).  Patches to support it
>> > will be most welcome.
>> 
>> The following patch displays "--" for all separator types. I'd say
>> that's good enough, WDYT?
>
> Yes, LGTM, please install.  But please add a FIXME comment there
> mentioning the feature and inviting its implementation.

Thanks, pushed to master, and closing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.