GNU bug report logs - #74734
[PATCH] gnu: Add inferno

Previous Next

Full log

Message #14 received at 74734 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Homo <gay <at> disroot.org>
Cc: 74734 <at> debbugs.gnu.org
Subject: Re: [bug#74734] [PATCH v3] gnu: Add inferno.
Date: Sat, 04 Jan 2025 22:59:17 +0100

Hi,

Homo <gay <at> disroot.org> skribis:

> Based on earlier work rejected for licensing reasons, code has been relicensed from LPL to Expat.
>
> Just in case remove all fonts from distribution, instead fonts from plan9port are used.
>
> * gnu/packages/inferno.scm: New file.
> * gnu/packages/patches/inferno-fix-crash.patch: New file.
> * gnu/local.mk (GNU_SYSTEM_MODULES, dist_patch_DATA): Register new files.
>
> Change-Id: Ie655f97fec5e249b8bbc92c66c5f13afabbc0552

[...]

> +(define-public inferno
> +  (let ((commit "67e70befb2ad0058fd7894be34c492ddb6d09988")
> +        (revision "0"))
> +    (package
> +      (name "inferno")
> +      (version (git-version "4" revision commit))

If there’s no release that can be used, please add a short comment
explaining why we’re picking a snapshot.

> +         ;; Remove bundled non-free and potentially non-free fonts.
> +         (snippet '(begin
> +                     (delete-file-recursively "fonts") #t))))

Just: (snippet '(delete-file-recursively "fonts")).

> +      (build-system gnu-build-system)
> +      (inputs (list libx11 libxext plan9port xorgproto))
> +      (arguments

Usually ‘arguments’ goes right after ‘build-system’.

> +       (list
> +        #:phases
> +        #~(let*
> +            ((bash (assoc-ref %build-inputs "bash"))
> +             (bindir (string-append #$output "/bin"))
> +             (emu-script (string-append bindir "/emu"))

This is quite unusual.  I would suggest instead moving these definitions
in the procedure where they’re used.

Also, prefer ‘search-input-file’ & co. instead of (assoc-ref
%build-inputs …).

Otherwise LGTM.

Could you send an updated patch?

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.