GNU bug report logs - #74730
[PATCH] 30.0.92; eww-browse-with-external-browser and eww-follow-link should use browse-url-with-browser-kind

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#74730: closed ([PATCH] 30.0.92; eww-browse-with-external-browser
 and eww-follow-link should use browse-url-with-browser-kind)
Date: Thu, 12 Dec 2024 10:43:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 12 Dec 2024 12:42:12 +0200
with message-id <861pyd18u3.fsf <at> gnu.org>
and subject line Re: bug#74730: [PATCH] 30.0.92; eww-browse-with-external-browser and eww-follow-link should use browse-url-with-browser-kind
has caused the debbugs.gnu.org bug report #74730,
regarding [PATCH] 30.0.92; eww-browse-with-external-browser and eww-follow-link should use browse-url-with-browser-kind
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
74730: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=74730
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Daniel Mendler <mail <at> daniel-mendler.de>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] 30.0.92; eww-browse-with-external-browser and
 eww-follow-link should use browse-url-with-browser-kind
Date: Sat, 07 Dec 2024 23:02:09 +0100

[Message part 3 (text/plain, inline)]

Tags: patch

The command `eww-browse-with-external-browser' uses
`browse-url-secondary-browser-function'. This makes the command
ineffective in the common setup where
`browse-url-secondary-browser-function' is set to `eww-browse-url' and
`browse-url-browser-function' is set to an external browser.

Fortunately we can use `browse-url-with-browser-kind' instead, which
guarantees that an external browser is launched.

Furthermore `eww-follow-link' should use `browse-url-with-browser-kind'
if the EXTERNAL prefix argument is non-nil.

I've looked at all other uses of `browse-url-browser-function' and
`browse-url-secondary-browser-function' in the Emacs code base and I
have not found other problems. Most commands use a prefix argument to
switch to the secondary browser, relying on the primary browser by
default. The problem is limited to `eww-browse-with-external-browser'
and `eww-follow-link'.

In GNU Emacs 30.0.92 (build 2, x86_64-pc-linux-gnu, X toolkit, cairo
 version 1.18.2, Xaw scroll bars) of 2024-11-20

[0001-eww-Use-browse-url-browser-kind-for-external-browsin.patch (text/patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Daniel Mendler <mail <at> daniel-mendler.de>
Cc: 74730-done <at> debbugs.gnu.org
Subject: Re: bug#74730: [PATCH] 30.0.92; eww-browse-with-external-browser
 and eww-follow-link should use browse-url-with-browser-kind
Date: Thu, 12 Dec 2024 12:42:12 +0200

> From: Daniel Mendler <mail <at> daniel-mendler.de>
> Cc: 74730 <at> debbugs.gnu.org
> Date: Sun, 08 Dec 2024 18:39:28 +0100
> 
> Updated patch attached.

Thanks, installed on the master branch, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.