Subject: Re: bug#74728: closed ([PATCH] gnu: python-asyncssh: Disable flaky connection tests.)

From: Roman Scherer <[email-masked]>
Date: Sun, 08 Dec 2024 15:18:14 +0100

References: <[email-masked]>
	<[email-masked]>
	<[email-masked]>
User-Agent: mu4e 1.12.7; emacs 29.4
Hi Oleg,

thanks for applying my patch. I now tried to build python-asyncssh from the
Guix master branch, but unfortunatly now other tests started to fail, which
didn't fail before for some reason.

I guess you don't see those issues, so maybe it is specific to my aarch64 system?

I sent a new mail and added a new patch that disables more tests. Could you
take a look at them?

Thanks, Roman.

Date: Sun, 08 Dec 2024 15:18:14 +0100

[email-masked] (GNU bug Tracking System) writes:

> Your bug report
>
> #74728: [PATCH] gnu: python-asyncssh: Disable flaky connection tests.
>
> which was filed against the guix-patches package, has been closed.
>
> The explanation is attached below, along with your original report.
> If you require more details, please reply to [email-masked].
>
> --
> 74728: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=74728
> GNU Bug Tracking System
> Contact [email-masked] with problems
>
> From: Sharlatan Hellseher <[email-masked]>
> Subject: [PATCH] gnu: python-asyncssh: Disable flaky connection tests.
> To: [email-masked]
> Date: Sun, 08 Dec 2024 12:33:22 +0000 (1 hour, 42 minutes, 21 seconds ago)
>
>
>
> Hi,
>
> Pushed as f2ad73507b9a313024893e837aa11774f61b273f to master.
>
> --
> Thanks,
> Oleg
>
> ----------
>
> From: Roman Scherer <[email-masked]>
> Subject: [PATCH] gnu: python-asyncssh: Disable flaky connection tests.
> To: [email-masked]
> Cc: Roman Scherer <[email-masked]>
> Date: Sat,  7 Dec 2024 19:00:20 +0100
> Date: Sat,  7 Dec 2024 19:00:20 +0100 (20 hours, 15 minutes, 23 seconds ago)
>
> * gnu/packages/ssh.scm (python-asyncssh): Disable flaky connection tests.
>
> Change-Id: If99cc686679fd2c731f3d66a85abe23eff6f1234
> ---
>  gnu/packages/ssh.scm | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/ssh.scm b/gnu/packages/ssh.scm
> index 1f33259246..a44976b598 100644
> --- a/gnu/packages/ssh.scm
> +++ b/gnu/packages/ssh.scm
> @@ -833,7 +833,15 @@ (define-public python-asyncssh
>                 ;; TODO Test fails for unknown reason
>                 (("(.+)async def test_confirm" all indent)
>                  (string-append indent "@unittest.skip('disabled by guix')\n"
> -                               indent "async def test_confirm")))))
> +                               indent "async def test_confirm")))
> +             (substitute* "tests/test_connection.py"
> +               ;; Tests fail with: asyncssh.misc.ConnectionLost: Connection lost
> +               (("(.+)async def test_get_server_host_key_proxy" all indent)
> +                (string-append indent "@unittest.skip('disabled by guix')\n"
> +                               indent "async def test_get_server_host_key_proxy"))
> +               (("(.+)async def test_connect_reverse_proxy" all indent)
> +                (string-append indent "@unittest.skip('disabled by guix')\n"
> +                               indent "async def test_connect_reverse_proxy")))))
>           (replace 'check
>             (lambda* (#:key tests? inputs outputs #:allow-other-keys)
>               (when tests?
>
> base-commit: bc630c5ebed27edd821ec363706f8b9cf1ee05cc