GNU bug report logs - #74728
[PATCH] gnu: python-asyncssh: Disable flaky connection tests.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 74728 in the body.
You can then email your comments to 74728 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Roman Scherer <roman <at> burningswell.com>
To: guix-patches <at> gnu.org
Cc: Roman Scherer <roman <at> burningswell.com>
Subject: [PATCH] gnu: python-asyncssh: Disable flaky connection tests.
Date: Sat,  7 Dec 2024 19:00:20 +0100

* gnu/packages/ssh.scm (python-asyncssh): Disable flaky connection tests.

Change-Id: If99cc686679fd2c731f3d66a85abe23eff6f1234
---
 gnu/packages/ssh.scm | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/ssh.scm b/gnu/packages/ssh.scm
index 1f33259246..a44976b598 100644
--- a/gnu/packages/ssh.scm
+++ b/gnu/packages/ssh.scm
@@ -833,7 +833,15 @@ (define-public python-asyncssh
                ;; TODO Test fails for unknown reason
                (("(.+)async def test_confirm" all indent)
                 (string-append indent "@unittest.skip('disabled by guix')\n"
-                               indent "async def test_confirm")))))
+                               indent "async def test_confirm")))
+             (substitute* "tests/test_connection.py"
+               ;; Tests fail with: asyncssh.misc.ConnectionLost: Connection lost
+               (("(.+)async def test_get_server_host_key_proxy" all indent)
+                (string-append indent "@unittest.skip('disabled by guix')\n"
+                               indent "async def test_get_server_host_key_proxy"))
+               (("(.+)async def test_connect_reverse_proxy" all indent)
+                (string-append indent "@unittest.skip('disabled by guix')\n"
+                               indent "async def test_connect_reverse_proxy")))))
          (replace 'check
            (lambda* (#:key tests? inputs outputs #:allow-other-keys)
              (when tests?

base-commit: bc630c5ebed27edd821ec363706f8b9cf1ee05cc
-- 
2.46.0

Message #8 received at 74728 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 74728 <at> debbugs.gnu.org
Subject: [PATCH] gnu: python-asyncssh: Disable flaky connection tests.
Date: Sat, 7 Dec 2024 22:40:45 +0000

[Message part 1 (text/plain, inline)]

Hi,

Thanks for the patch.

Give it a try to refactor it by using pyproject-build-system,
contsing much simpler test excluding mechanics.

Oleg

[Message part 2 (text/html, inline)]

Message #13 received at 74728-done <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 74728-done <at> debbugs.gnu.org
Subject: [PATCH] gnu: python-asyncssh: Disable flaky connection tests.
Date: Sun, 08 Dec 2024 12:33:22 +0000

[Message part 1 (text/plain, inline)]

Hi,

Pushed as f2ad73507b9a313024893e837aa11774f61b273f to master.

--
Thanks,
Oleg

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 74728 <at> debbugs.gnu.org (full text, mbox):

From: Roman Scherer <roman <at> burningswell.com>
To: 74728 <at> debbugs.gnu.org
Cc: Roman Scherer <roman <at> burningswell.com>, sharlatanus <at> gmail.com
Subject: [PATCH] gnu: python-asyncssh: Disable more tests.
Date: Sun,  8 Dec 2024 15:15:23 +0100

* gnu/packages/ssh.scm (python-asyncssh): Disable more tests.

Change-Id: I9f3a746bdf820c1d357fd655f1ed1ff197327856
---
 gnu/packages/ssh.scm | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/ssh.scm b/gnu/packages/ssh.scm
index 95ad38a642..dc344b850f 100644
--- a/gnu/packages/ssh.scm
+++ b/gnu/packages/ssh.scm
@@ -824,8 +824,11 @@ (define-public python-asyncssh
                     (list "not test_confirm"
                           ;; Tests fail with: asyncssh.misc.ConnectionLost:
                           ;; Connection lost
-                          "test_get_server_host_key_proxy"
-                          "test_connect_reverse_proxy")
+                          "test_connect_non_tcp_sock"
+                          "test_connect_reverse_proxy"
+                          "test_get_server_auth_methods_no_sockn"
+                          "test_get_server_auth_methods_no_sockname"
+                          "test_get_server_host_key_proxy")
                     " and not " ))
       #:phases
       #~(modify-phases %standard-phases

base-commit: eafd91c26232f039a3170b73e40b0a2d5983c474
--
2.46.0

Message #19 received at 74728 <at> debbugs.gnu.org (full text, mbox):

From: Roman Scherer <roman <at> burningswell.com>
To: help-debbugs <at> gnu.org (GNU bug Tracking System)
Cc: Roman Scherer <roman <at> burningswell.com>,
 Sharlatan Hellseher <sharlatanus <at> gmail.com>, 74728 <at> debbugs.gnu.org
Subject: Re: bug#74728: closed ([PATCH] gnu: python-asyncssh: Disable flaky
 connection tests.)
Date: Sun, 08 Dec 2024 15:18:14 +0100

[Message part 1 (text/plain, inline)]

References: <87y10q73sd.fsf <at> gmail.com>
	<8403c5159deb34bf4dac119d55c57c9dba530a20.1733594283.git.roman <at> burningswell.com>
	<handler.74728.D74728.173366126726317.notifdone <at> debbugs.gnu.org>
User-Agent: mu4e 1.12.7; emacs 29.4
Hi Oleg,

thanks for applying my patch. I now tried to build python-asyncssh from the
Guix master branch, but unfortunatly now other tests started to fail, which
didn't fail before for some reason.

I guess you don't see those issues, so maybe it is specific to my aarch64 system?

I sent a new mail and added a new patch that disables more tests. Could you
take a look at them?

Thanks, Roman.

Date: Sun, 08 Dec 2024 15:18:14 +0100

help-debbugs <at> gnu.org (GNU bug Tracking System) writes:

> Your bug report
>
> #74728: [PATCH] gnu: python-asyncssh: Disable flaky connection tests.
>
> which was filed against the guix-patches package, has been closed.
>
> The explanation is attached below, along with your original report.
> If you require more details, please reply to 74728 <at> debbugs.gnu.org.
>
> --
> 74728: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=74728
> GNU Bug Tracking System
> Contact help-debbugs <at> gnu.org with problems
>
> From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
> Subject: [PATCH] gnu: python-asyncssh: Disable flaky connection tests.
> To: 74728-done <at> debbugs.gnu.org
> Date: Sun, 08 Dec 2024 12:33:22 +0000 (1 hour, 42 minutes, 21 seconds ago)
>
>
>
> Hi,
>
> Pushed as f2ad73507b9a313024893e837aa11774f61b273f to master.
>
> --
> Thanks,
> Oleg
>
> ----------
>
> From: Roman Scherer <roman <at> burningswell.com>
> Subject: [PATCH] gnu: python-asyncssh: Disable flaky connection tests.
> To: guix-patches <at> gnu.org
> Cc: Roman Scherer <roman <at> burningswell.com>
> Date: Sat,  7 Dec 2024 19:00:20 +0100
> Date: Sat,  7 Dec 2024 19:00:20 +0100 (20 hours, 15 minutes, 23 seconds ago)
>
> * gnu/packages/ssh.scm (python-asyncssh): Disable flaky connection tests.
>
> Change-Id: If99cc686679fd2c731f3d66a85abe23eff6f1234
> ---
>  gnu/packages/ssh.scm | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/ssh.scm b/gnu/packages/ssh.scm
> index 1f33259246..a44976b598 100644
> --- a/gnu/packages/ssh.scm
> +++ b/gnu/packages/ssh.scm
> @@ -833,7 +833,15 @@ (define-public python-asyncssh
>                 ;; TODO Test fails for unknown reason
>                 (("(.+)async def test_confirm" all indent)
>                  (string-append indent "@unittest.skip('disabled by guix')\n"
> -                               indent "async def test_confirm")))))
> +                               indent "async def test_confirm")))
> +             (substitute* "tests/test_connection.py"
> +               ;; Tests fail with: asyncssh.misc.ConnectionLost: Connection lost
> +               (("(.+)async def test_get_server_host_key_proxy" all indent)
> +                (string-append indent "@unittest.skip('disabled by guix')\n"
> +                               indent "async def test_get_server_host_key_proxy"))
> +               (("(.+)async def test_connect_reverse_proxy" all indent)
> +                (string-append indent "@unittest.skip('disabled by guix')\n"
> +                               indent "async def test_connect_reverse_proxy")))))
>           (replace 'check
>             (lambda* (#:key tests? inputs outputs #:allow-other-keys)
>               (when tests?
>
> base-commit: bc630c5ebed27edd821ec363706f8b9cf1ee05cc

[signature.asc (application/pgp-signature, inline)]

Message #22 received at 74728 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: Roman Scherer <roman <at> burningswell.com>
Cc: 74728 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: python-asyncssh: Disable more tests.
Date: Sun, 8 Dec 2024 16:43:39 +0000

[Message part 1 (text/plain, inline)]

Hi,


CI for x86_64 just finished without issues, note I've refunded the

version.

Maybe we may make flakey test architecture specific, WDYT?


Oleg

[Message part 2 (text/html, inline)]

Message #25 received at 74728 <at> debbugs.gnu.org (full text, mbox):

From: Roman Scherer <roman <at> burningswell.com>
To: 74728 <at> debbugs.gnu.org
Cc: Roman Scherer <roman <at> burningswell.com>, sharlatanus <at> gmail.com
Subject: [PATCH] gnu: python-asyncssh: Disable failing tests on aarch64.
Date: Sun,  8 Dec 2024 18:31:42 +0100

* gnu/packages/ssh.scm (python-asyncssh): Disable failing tests on aarch64.

Change-Id: I9f3a746bdf820c1d357fd655f1ed1ff197327856
---
 gnu/packages/ssh.scm | 19 +++++++++++++------
 1 file changed, 13 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/ssh.scm b/gnu/packages/ssh.scm
index 95ad38a642..bf4e04d55b 100644
--- a/gnu/packages/ssh.scm
+++ b/gnu/packages/ssh.scm
@@ -820,12 +820,19 @@ (define-public python-asyncssh
      (list
       #:test-flags
       #~(list "-k" (string-join
-                    ;; TODO Test fails for unknown reason
-                    (list "not test_confirm"
-                          ;; Tests fail with: asyncssh.misc.ConnectionLost:
-                          ;; Connection lost
-                          "test_get_server_host_key_proxy"
-                          "test_connect_reverse_proxy")
+                    (list
+                     ;; TODO Test fails for unknown reason
+                     "not test_confirm"
+                     #$@(if (target-aarch64?)
+                            (list
+                             ;; Tests fail with: asyncssh.misc.ConnectionLost:
+                             ;; Connection lost
+                             "test_connect_non_tcp_sock"
+                             "test_connect_reverse_proxy"
+                             "test_get_server_auth_methods_no_sockn"
+                             "test_get_server_auth_methods_no_sockname"
+                             "test_get_server_host_key_proxy")
+                            '()))
                     " and not " ))
       #:phases
       #~(modify-phases %standard-phases

base-commit: 17d86ac9df841deca4f2f5e173f50bd2461fe680
-- 
2.46.0

Message #28 received at 74728 <at> debbugs.gnu.org (full text, mbox):

From: Roman Scherer <roman <at> burningswell.com>
To: Sharlatan Hellseher <sharlatanus <at> gmail.com>
Cc: Roman Scherer <roman <at> burningswell.com>, 74728 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: python-asyncssh: Disable more tests.
Date: Sun, 08 Dec 2024 18:32:50 +0100

[Message part 1 (text/plain, inline)]

Sharlatan Hellseher <sharlatanus <at> gmail.com> writes:

Hi Oleg,

yes, maybe better. I sent a version of the previous patch that only
disables those tests on aarch64.

Wdyt?

Thanks, Roman.

> Hi,
>
> CI for x86_64 just finished without issues, note I've refunded the
>
> version.
>
> Maybe we may make flakey test architecture specific, WDYT?
>
> Oleg

[signature.asc (application/pgp-signature, inline)]

Message #31 received at 74728 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 74728 <at> debbugs.gnu.org
Cc: roman <at> burningswell.com
Subject: [PATCH] gnu: python-asyncssh: Disable flaky connection tests.
Date: Mon, 09 Dec 2024 21:27:01 +0000

[Message part 1 (text/plain, inline)]

Hi,

[PATCH] gnu: python-asyncssh: Disable failing tests on aarch64.
Pushed as ec1a67d4ff7435fdf50de35c3f57d2f60a9cccf9 to master.

It was built successfully both on x86_68 and aarch64 in Qemu.

Pleas, open other issue if you find something else ;-).

--
Thanks,
Oleg

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.