From unknown Sat Aug 16 16:08:55 2025 X-Loop: help-debbugs@gnu.org Subject: bug#74727: [PATCH] ; * lisp/apropos.el (apropos-library): Fix typo. Resent-From: Eshel Yaron Original-Sender: "Debbugs-submit" Resent-CC: dmitry@gutov.dev, bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Dec 2024 13:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 74727 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 74727@debbugs.gnu.org Cc: Dmitry Gutov X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: Dmitry Gutov Received: via spool by submit@debbugs.gnu.org id=B.173357832120885 (code B ref -1); Sat, 07 Dec 2024 13:32:02 +0000 Received: (at submit) by debbugs.gnu.org; 7 Dec 2024 13:32:01 +0000 Received: from localhost ([127.0.0.1]:45982 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJuue-0005Qn-Qa for submit@debbugs.gnu.org; Sat, 07 Dec 2024 08:32:01 -0500 Received: from lists.gnu.org ([209.51.188.17]:40648) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJuuc-0005Qa-Tt for submit@debbugs.gnu.org; Sat, 07 Dec 2024 08:31:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tJuuc-0001SZ-MH for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2024 08:31:58 -0500 Received: from mail.eshelyaron.com ([107.175.124.16] helo=eshelyaron.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tJuub-0003cv-7v for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2024 08:31:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1733578315; bh=wmOjPsgfgHkMGIroppsAVOU+L8PAZUsgIVI9JL3D6F4=; h=From:To:Subject:Date:From; b=seMuBdflGZus8QGwp8mxa0aDnXQjyObWTXLkc3UM0/u5HinROd+qbm07hI4oKqNHv z1Z0ABGmcUVq6hLTmZRKYOuzZGBb5i6E3YgAmBRMhzmKMNGGqjo+Wyeszhg33R1dC5 WenGorgy0SHXv8jdV8n3S+EWSyDEnTBBajpSW9NrL+rPVg7HERgZMVfoX2FORDGaqa 1PtpzDoWpBlbm42xCaSo815e6XbzWE2mrN/X/EtmpXSEW9KBRoY1NF8EuLVGtXKSuB QEEAD5S2N4cCO/6mfpCqdCnTEa4OaIYffK0OWUvrLUFaIdz1alfvtIGPpjbRlPkjP3 3CTM/gJS2liog== From: Eshel Yaron Date: Sat, 07 Dec 2024 14:31:53 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=107.175.124.16; envelope-from=me@eshelyaron.com; helo=eshelyaron.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain Tags: patch This patch fixes the issue described below, which IIUC originates in a mere typo in commit 671862f6b3089c3a503c1b6936a821ad54429359 1. emacs -Q 2. M-x apropos-library elisp-mode RET 3. The *Apropos* buffer incorrectly lists methods that elisp-mode.el defines as if they were _features_ provided by the library. Accordingly, clicking on one of those references yields an error such as "Unknown library `xref-backend-definitions'" --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-lisp-apropos.el-apropos-library-Fix-typo.patch >From 40af45daf1ff41ddb1ba624a99a249b36f724bd0 Mon Sep 17 00:00:00 2001 From: Eshel Yaron Date: Sat, 7 Dec 2024 14:13:12 +0100 Subject: [PATCH] ; * lisp/apropos.el (apropos-library): Fix typo. --- lisp/apropos.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/apropos.el b/lisp/apropos.el index 0655fecd0e8..eb2c36f673e 100644 --- a/lisp/apropos.el +++ b/lisp/apropos.el @@ -733,7 +733,7 @@ apropos-library ('t nil) ; Skip "was an autoload" entries. ;; FIXME: Print information about each individual method: both ;; its docstring and specializers (bug#21422). - ('cl-defmethod (push (cadr x) provides)) + ('cl-defmethod (push (cadr x) symbols)) ;; FIXME: Add extension point (bug#72616). (_ (let ((sym (or (cdr-safe x) x))) (and sym (symbolp sym) -- 2.46.2 --=-=-=-- From unknown Sat Aug 16 16:08:55 2025 X-Loop: help-debbugs@gnu.org Subject: bug#74727: [PATCH] ; * lisp/apropos.el (apropos-library): Fix typo. Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Dec 2024 01:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74727 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eshel Yaron , 74727@debbugs.gnu.org Received: via spool by 74727-submit@debbugs.gnu.org id=B74727.17336228781746 (code B ref 74727); Sun, 08 Dec 2024 01:55:02 +0000 Received: (at 74727) by debbugs.gnu.org; 8 Dec 2024 01:54:38 +0000 Received: from localhost ([127.0.0.1]:49099 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tK6VJ-0000S3-F2 for submit@debbugs.gnu.org; Sat, 07 Dec 2024 20:54:37 -0500 Received: from fout-b6-smtp.messagingengine.com ([202.12.124.149]:36167) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tK6VB-0000Rc-Ps for 74727@debbugs.gnu.org; Sat, 07 Dec 2024 20:54:34 -0500 Received: from phl-compute-03.internal (phl-compute-03.phl.internal [10.202.2.43]) by mailfout.stl.internal (Postfix) with ESMTP id 33138114011A; Sat, 7 Dec 2024 20:54:23 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-03.internal (MEProxy); Sat, 07 Dec 2024 20:54:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1733622863; x=1733709263; bh=AL/Fh3sEqiJjOFEQI25J231I8JIYL7bUU84/dXdHU1Y=; b= W85j5WaZ0a0lVLSTi3dBSo2qJe7QUHB4vmM3DCdqiVDohilaoYC78X0+hieAH3W2 le49UX3/QkdUZ2GvRekjK72EbxUohX03O7sZcDVFB5keoaTfAOFlJeSCywYUKp1Z PAU3BHTgyjFrCDpx54EML51M0GCBsZfbz4EngbZLVIEex5p69x7Lg2IgX9jD5XD+ FvDgRRHn1/XhWHNwikdpySaxjVPCrQ7YKwaWV9xZK7LJ30VjZRvLmRBGrc4YzcXT aBMbRXIU9JpBO9MHOtUTr+u9fMrRAH39rpwcgjVEqblVbTUcPUhX2Q1Wxt8PDrKP 0AK1LeFqlh+QYCYpNGcnrQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; t=1733622863; x=1733709263; bh=A L/Fh3sEqiJjOFEQI25J231I8JIYL7bUU84/dXdHU1Y=; b=zPtSwUjCjd7AOXK5J jp/dX3c4PLiMryXGACkNY6hV2JjhUsPTE5jl92lAN8gi5qUP2ISJy54+coD4efQ2 VoyBBTqrFqRg6ssBcMXJufu46raIpfBXnpGKDNDM+gJiAJ95FU22yLiVVbOBSXw5 Nsp2arfYO+reLZCKwRbdf7ZbQkLGdFIppDnYvLgPJh4ts7nHSNJas0fza4U32CQh 8lHZjpujJ2acqaG6Ow4l9xIoB6Jg1jq3QnLVzehXpf/JWWja+ku/llIVpc1/GHe0 4mR4r43M22tn0ku2dp7mQh7UtEuHFcDXbs8nW+2gyujefHkoEKQZ3VI5z0uwWoue wW4wg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrjedvgdefkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecunecujfgurhepkfffgggfuf fvfhfhjggtgfesthejredttddvjeenucfhrhhomhepffhmihhtrhihucfiuhhtohhvuceo ughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtthgvrhhnpeejjeejjeeigf eiffelteehheejveefieevgfejveehhefgjeefffetvdeiledvffenucffohhmrghinhep ghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpegumhhithhrhiesghhuthhovhdruggvvhdpnhgspghrtghpthhtohepvddpmhho uggvpehsmhhtphhouhhtpdhrtghpthhtohepmhgvsegvshhhvghlhigrrhhonhdrtghomh dprhgtphhtthhopeejgeejvdejseguvggssghughhsrdhgnhhurdhorhhg X-ME-Proxy: Feedback-ID: i07de48aa:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 7 Dec 2024 20:54:21 -0500 (EST) Message-ID: Date: Sun, 8 Dec 2024 03:54:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird References: Content-Language: en-US From: Dmitry Gutov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Eshel, On 07/12/2024 15:31, Eshel Yaron wrote: > This patch fixes the issue described below, which IIUC originates in a > mere typo in commit 671862f6b3089c3a503c1b6936a821ad54429359 > > 1. emacs -Q > 2. M-x apropos-library elisp-mode RET > 3. The*Apropos* buffer incorrectly lists methods that elisp-mode.el > defines as if they were_features_ provided by the library. > Accordingly, clicking on one of those references yields an error such > as "Unknown library `xref-backend-definitions'" Thanks! That's a good suggestion. If you've started testing this area, though, do you know of a case when dropping this case - like: diff --git a/lisp/apropos.el b/lisp/apropos.el index 0655fecd0e8..9af8a7269ae 100644 --- a/lisp/apropos.el +++ b/lisp/apropos.el @@ -733,7 +733,7 @@ apropos-library ('t nil) ; Skip "was an autoload" entries. ;; FIXME: Print information about each individual method: both ;; its docstring and specializers (bug#21422). - ('cl-defmethod (push (cadr x) provides)) + ;; ('cl-defmethod (push (cadr x) provides)) ;; FIXME: Add extension point (bug#72616). (_ (let ((sym (or (cdr-safe x) x))) (and sym (symbolp sym) ...does not work just as well? From what I see now, any 'cl-defmethod' entry in load-history is accompanied by a 'defun' entry anyway. And the original report (https://debbugs.gnu.org/21422) was about an error being raised, but I can't reproduce it now after commenting this line out. From unknown Sat Aug 16 16:08:55 2025 X-Loop: help-debbugs@gnu.org Subject: bug#74727: [PATCH] ; * lisp/apropos.el (apropos-library): Fix typo. Resent-From: Eshel Yaron Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Dec 2024 16:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74727 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Dmitry Gutov Cc: 74727@debbugs.gnu.org Received: via spool by 74727-submit@debbugs.gnu.org id=B74727.17336758449109 (code B ref 74727); Sun, 08 Dec 2024 16:38:02 +0000 Received: (at 74727) by debbugs.gnu.org; 8 Dec 2024 16:37:24 +0000 Received: from localhost ([127.0.0.1]:51497 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tKKHc-0002Mr-AJ for submit@debbugs.gnu.org; Sun, 08 Dec 2024 11:37:24 -0500 Received: from mail.eshelyaron.com ([107.175.124.16]:48504 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tKKHZ-0002Mh-7M for 74727@debbugs.gnu.org; Sun, 08 Dec 2024 11:37:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1733675840; bh=fblmA7DVIGJDamH2uP4iWozHcsW4he2fAMzS1vMT/EM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=N0KSCA3xiYzH6tOqP8TuJAbzJCmeZmkFsBr3ng5ZnyfVdH5qKE5Vuh4WXcWHWma8Q +q/RnhYL58HEcC5bHGO9xLf01H0DFiNGwZKfK2i496RHG6W733lyGHG3rUp9I3h0Qx CuTaEacIYrrUkymBEk8NVLAp+2wWGSvRi6J33ZeLZ5Grxvq/8fGDpd+g47NeG/on0B qAN4Ja4xatdXtxwtOUYN7XJlMyM0QeGD8sItKtZHurZ7y+1cNmmHQY0l0R31xoLul3 Q6kEuJXDhlTChqmmnMPApqLplH9Uy0oDwaYn/kMyh/DJ1QjN935C3tKBAqkGrNEI7D rPSaER9KpiHUg== From: Eshel Yaron In-Reply-To: (Dmitry Gutov's message of "Sun, 8 Dec 2024 03:54:19 +0200") References: Date: Sun, 08 Dec 2024 17:37:14 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) Dmitry Gutov writes: > Hi Eshel, > > On 07/12/2024 15:31, Eshel Yaron wrote: >> This patch fixes the issue described below, which IIUC originates in a >> mere typo in commit 671862f6b3089c3a503c1b6936a821ad54429359 >> >> 1. emacs -Q >> 2. M-x apropos-library elisp-mode RET >> 3. The*Apropos* buffer incorrectly lists methods that elisp-mode.el >> defines as if they were_features_ provided by the library. >> Accordingly, clicking on one of those references yields an error such >> as "Unknown library `xref-backend-definitions'" > > Thanks! That's a good suggestion. > > If you've started testing this area, though, do you know of a case when > dropping this case - like: > > diff --git a/lisp/apropos.el b/lisp/apropos.el > index 0655fecd0e8..9af8a7269ae 100644 > --- a/lisp/apropos.el > +++ b/lisp/apropos.el > @@ -733,7 +733,7 @@ apropos-library > ('t nil) ; Skip "was an autoload" entries. > ;; FIXME: Print information about each individual method: both > ;; its docstring and specializers (bug#21422). > - ('cl-defmethod (push (cadr x) provides)) > + ;; ('cl-defmethod (push (cadr x) provides)) > ;; FIXME: Add extension point (bug#72616). > (_ (let ((sym (or (cdr-safe x) x))) > (and sym (symbolp sym) > > ...does not work just as well? Yes, that seems to work too, and it doesn't produce duplicate entries for these definitions, so that's even better :) > From what I see now, any 'cl-defmethod' entry in load-history is > accompanied by a 'defun' entry anyway. And the original report > (https://debbugs.gnu.org/21422) was about an error being raised, but I > can't reproduce it now after commenting this line out. Same here. Eshel From unknown Sat Aug 16 16:08:55 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Eshel Yaron Subject: bug#74727: closed (Re: bug#74727: [PATCH] ; * lisp/apropos.el (apropos-library): Fix typo.) Message-ID: References: X-Gnu-PR-Message: they-closed 74727 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 74727@debbugs.gnu.org Date: Tue, 10 Dec 2024 01:42:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1733794922-9864-1" This is a multi-part message in MIME format... ------------=_1733794922-9864-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #74727: [PATCH] ; * lisp/apropos.el (apropos-library): Fix typo. which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 74727@debbugs.gnu.org. --=20 74727: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D74727 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1733794922-9864-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 74727-done) by debbugs.gnu.org; 10 Dec 2024 01:41:58 +0000 Received: from localhost ([127.0.0.1]:56313 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tKpG9-0002Ya-NB for submit@debbugs.gnu.org; Mon, 09 Dec 2024 20:41:58 -0500 Received: from fout-a7-smtp.messagingengine.com ([103.168.172.150]:49367) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tKpG4-0002Xw-36 for 74727-done@debbugs.gnu.org; Mon, 09 Dec 2024 20:41:56 -0500 Received: from phl-compute-11.internal (phl-compute-11.phl.internal [10.202.2.51]) by mailfout.phl.internal (Postfix) with ESMTP id 1FAA01383F77; Mon, 9 Dec 2024 20:41:46 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-11.internal (MEProxy); Mon, 09 Dec 2024 20:41:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1733794906; x=1733881306; bh=+gdvYLfY+JdxmA8Qbly8AeZZ8ZUnNOaThg5C9s/dRxE=; b= lTbG69P9TVvCgDepPaQ0wjTI8RNtA4di6g3MXUGYC0z+hXWB177iQp+qCTeidIYv Pv8gLaznhISQOzMYq+DyZJBUGve332m3CaWNXg3SE9eRQ5GaQNSAClO8YWNlO416 hqF4goyN/PsHJ99wZ82WPGfDwHGkXR+0Iizm0uPyGfK64U+dAqLMbd0W4+sI8jUd uxsdP+D87/pnUbxZsh1y9nX2rDiUhYIgKiTXqwGhJdEVxVkDf6csqQmBPzxVo2Rn r+dDQle+wVDw0OuTjmdvUh6NVnpMCbQWW8yGrtXQy64Pa0dbxGVO6yk22/yFm1Zb ltVxRjlwdzpuB0TDy+fPtg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1733794906; x= 1733881306; bh=+gdvYLfY+JdxmA8Qbly8AeZZ8ZUnNOaThg5C9s/dRxE=; b=U k7W/OIwgmZ5jixGvSgqzz9+/lM8sE3Xo+pXSXtwq1FvHIRiug1/5Tr5hoYgLj2j/ AJOqWOhl6Ap7RGzTiNq4AYMnvSX9/kigU0DkZHSgrbxltob6BZ3vOPWWiPEcHdQ8 G9cEB1FGuhhwFwc8Vpv4KWKVcyX0lBfSMI3K5eiM7Rf0plOpmVjo9LTaSM3IOisp +UJklQcrjM/Dd2+ETG9yy4ovaIZuJ1iZ4B1PSh2jQ6I0KZJlNcsf/dwjCIkTy2E+ +oiWhLfpEdsru8u84I45+j36YHOlQa/xN0FGyR9cq110MclpvtHihh4S2eUxHfGC MIdx0yHdSYtN0uoqB8x4Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrjeejgdefjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecunecujfgurhepkfffgggfuf fvvehfhfgjtgfgsehtkeertddtvdejnecuhfhrohhmpeffmhhithhrhicuifhuthhovhcu oegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrthhtvghrnhepueetudfhie dtjeekuefffeehgfffveevteejtdfhteetgeethfevueejkeejgfevnecuffhomhgrihhn pehgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepughmihhtrhihsehguhhtohhvrdguvghvpdhnsggprhgtphhtthhopedvpdhm ohguvgepshhmthhpohhuthdprhgtphhtthhopehmvgesvghshhgvlhihrghrohhnrdgtoh hmpdhrtghpthhtohepjeegjedvjedqughonhgvseguvggssghughhsrdhgnhhurdhorhhg X-ME-Proxy: Feedback-ID: i07de48aa:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 9 Dec 2024 20:41:44 -0500 (EST) Message-ID: Date: Tue, 10 Dec 2024 03:41:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#74727: [PATCH] ; * lisp/apropos.el (apropos-library): Fix typo. To: Eshel Yaron References: Content-Language: en-US From: Dmitry Gutov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 74727-done Cc: 74727-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Version: 31.1 On 08/12/2024 18:37, Eshel Yaron wrote: > Yes, that seems to work too, and it doesn't produce duplicate entries > for these definitions, so that's even better 🙂 > >> From what I see now, any 'cl-defmethod' entry in load-history is >> accompanied by a 'defun' entry anyway. And the original report >> (https://debbugs.gnu.org/21422) was about an error being raised, but I >> can't reproduce it now after commenting this line out. > Same here. Thanks for verifying! Pushed to master and closing. ------------=_1733794922-9864-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 7 Dec 2024 13:32:01 +0000 Received: from localhost ([127.0.0.1]:45982 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJuue-0005Qn-Qa for submit@debbugs.gnu.org; Sat, 07 Dec 2024 08:32:01 -0500 Received: from lists.gnu.org ([209.51.188.17]:40648) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJuuc-0005Qa-Tt for submit@debbugs.gnu.org; Sat, 07 Dec 2024 08:31:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tJuuc-0001SZ-MH for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2024 08:31:58 -0500 Received: from mail.eshelyaron.com ([107.175.124.16] helo=eshelyaron.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tJuub-0003cv-7v for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2024 08:31:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1733578315; bh=wmOjPsgfgHkMGIroppsAVOU+L8PAZUsgIVI9JL3D6F4=; h=From:To:Subject:Date:From; b=seMuBdflGZus8QGwp8mxa0aDnXQjyObWTXLkc3UM0/u5HinROd+qbm07hI4oKqNHv z1Z0ABGmcUVq6hLTmZRKYOuzZGBb5i6E3YgAmBRMhzmKMNGGqjo+Wyeszhg33R1dC5 WenGorgy0SHXv8jdV8n3S+EWSyDEnTBBajpSW9NrL+rPVg7HERgZMVfoX2FORDGaqa 1PtpzDoWpBlbm42xCaSo815e6XbzWE2mrN/X/EtmpXSEW9KBRoY1NF8EuLVGtXKSuB QEEAD5S2N4cCO/6mfpCqdCnTEa4OaIYffK0OWUvrLUFaIdz1alfvtIGPpjbRlPkjP3 3CTM/gJS2liog== From: Eshel Yaron To: bug-gnu-emacs@gnu.org Subject: [PATCH] ; * lisp/apropos.el (apropos-library): Fix typo. X-Debbugs-CC: Dmitry Gutov Date: Sat, 07 Dec 2024 14:31:53 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=107.175.124.16; envelope-from=me@eshelyaron.com; helo=eshelyaron.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain Tags: patch This patch fixes the issue described below, which IIUC originates in a mere typo in commit 671862f6b3089c3a503c1b6936a821ad54429359 1. emacs -Q 2. M-x apropos-library elisp-mode RET 3. The *Apropos* buffer incorrectly lists methods that elisp-mode.el defines as if they were _features_ provided by the library. Accordingly, clicking on one of those references yields an error such as "Unknown library `xref-backend-definitions'" --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-lisp-apropos.el-apropos-library-Fix-typo.patch >From 40af45daf1ff41ddb1ba624a99a249b36f724bd0 Mon Sep 17 00:00:00 2001 From: Eshel Yaron Date: Sat, 7 Dec 2024 14:13:12 +0100 Subject: [PATCH] ; * lisp/apropos.el (apropos-library): Fix typo. --- lisp/apropos.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/apropos.el b/lisp/apropos.el index 0655fecd0e8..eb2c36f673e 100644 --- a/lisp/apropos.el +++ b/lisp/apropos.el @@ -733,7 +733,7 @@ apropos-library ('t nil) ; Skip "was an autoload" entries. ;; FIXME: Print information about each individual method: both ;; its docstring and specializers (bug#21422). - ('cl-defmethod (push (cadr x) provides)) + ('cl-defmethod (push (cadr x) symbols)) ;; FIXME: Add extension point (bug#72616). (_ (let ((sym (or (cdr-safe x) x))) (and sym (symbolp sym) -- 2.46.2 --=-=-=-- ------------=_1733794922-9864-1--