GNU bug report logs - #74725
31.0.50; image-scaling-factor is ignored by create-image

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Alan Third <alan <at> idiocy.org>
Cc: luangruo <at> yahoo.com, 74725 <at> debbugs.gnu.org, da_vid <at> orange.fr
Subject: bug#74725: 31.0.50; image-scaling-factor is ignored by create-image
Date: Sat, 28 Dec 2024 14:26:47 +0200

> Date: Fri, 27 Dec 2024 12:11:33 +0000
> From: Alan Third <alan <at> idiocy.org>
> Cc: Po Lu <luangruo <at> yahoo.com>, 74725 <at> debbugs.gnu.org, da_vid <at> orange.fr
> 
> > Alan, could you please prepare a patch (for the master branch) that
> > records the scaling factor in the image cache and rejects a cache hit
> > with a different scaling factor?
> 
> Hi Eli, patch attached.

Thanks, LGTM.

> I named a new function image_compute_scale because most of the other
> functions in that file start image_, however I wasn't sure if I should
> name it compute_image_scale to mirror compute_image_size. Let me know
> if you think I should change it.

Static functions can have any names we see fit, so feel free to rename
if you think compute_image_scale would be better.

Feel free to install on master, when you are satisfied with the code.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.