GNU bug report logs - #74725
31.0.50; image-scaling-factor is ignored by create-image

Previous Next

Full log

Message #53 received at 74725 <at> debbugs.gnu.org (full text, mbox):

From: David Ponce <da_vid <at> orange.fr>
To: Alan Third <alan <at> idiocy.org>, Eli Zaretskii <eliz <at> gnu.org>,
 Po Lu <luangruo <at> yahoo.com>, 74725 <at> debbugs.gnu.org
Subject: Re: bug#74725: 31.0.50; image-scaling-factor is ignored by
 create-image
Date: Fri, 27 Dec 2024 17:11:30 +0100

On 2024-12-27 13:11, Alan Third wrote:
> On Sun, Dec 22, 2024 at 08:48:04AM +0200, Eli Zaretskii wrote:
>> Alan, could you please prepare a patch (for the master branch) that
>> records the scaling factor in the image cache and rejects a cache hit
>> with a different scaling factor?
> 
> Hi Eli, patch attached.
> 
> I named a new function image_compute_scale because most of the other
> functions in that file start image_, however I wasn't sure if I should
> name it compute_image_scale to mirror compute_image_size. Let me know
> if you think I should change it.

Hi Alan,

FYI, I applied your patch and it fixes the issue for me with the initial
examples I provided.

Many thanks Alan, and to all of you!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.