GNU bug report logs - #74700
[PATCH] Revert Dired buffer when clicking on last segment of directory name

Previous Next

Package: emacs;

Reported by: Visuwesh <visuweshm <at> gmail.com>

Date: Thu, 5 Dec 2024 06:13:01 UTC

Severity: normal

Tags: patch

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


Message #52 received at 74700 <at> debbugs.gnu.org (full text, mbox):

From: Visuwesh <visuweshm <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: michael_heerdegen <at> web.de, 74700 <at> debbugs.gnu.org
Subject: Re: bug#74700: [PATCH] Revert Dired buffer when clicking on last
 segment of directory name
Date: Thu, 26 Dec 2024 17:21:15 +0530
[Message part 1 (text/plain, inline)]
[வியாழன் டிசம்பர் 26, 2024] Eli Zaretskii wrote:

>> [...]
>> >> +++ #<buffer dired.el>
>> >> @@ -2089,8 +2089,10 @@
>> >>             `( mouse-face highlight
>> >>                help-echo "mouse-1: revert this buffer"
>> >>                keymap ,(define-keymap
>> >> -                        "<mouse-2>" #'revert-buffer
>> >> -                        "<follow-link>" 'follow-link
>> >> +                        "<mouse-2>" (lambda (_)
>> >> +                                      (interactive "@e")
>> >> +                                      (revert-buffer))
>> >> +                        "<follow-link>" 'mouse-face
>> >
>> > I don't know how to fix the mouse-1 problem in a sensible way either.
>> > Does anyone?
>> >
>> > (And I think in this version the "e" code in `interactive' isn't
>> > significant - but let's first see if we can improve the behavior even
>> > more.)
>> 
>> Indeed, I thought @ had to go with e _always_.
>
> Thanks, so please post a proper patch with a commit log message, so I
> could install it.

Thanks, patch attached.

[0001-Ensure-Dired-window-is-selected-when-reverting-buffe.patch (text/x-diff, attachment)]

This bug report was last modified 147 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.