GNU bug report logs - #74680
[PATCH] gnu: Add python-scikit-surprise.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Antero Mejr <mail <at> antr.me>
Subject: bug#74680: closed ([PATCH] gnu: Add python-scikit-surprise.)
Date: Wed, 04 Dec 2024 14:39:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#74680: [PATCH] gnu: Add python-scikit-surprise.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 74680 <at> debbugs.gnu.org.

-- 
74680: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=74680
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 74680-done <at> debbugs.gnu.org
Subject: [PATCH] gnu: Add python-scikit-surprise.
Date: Wed, 04 Dec 2024 14:37:30 +0000

[Message part 3 (text/plain, inline)]

Hi,

Thank you for the patch!

I've checked the license, built it on the latest master HEAD and applied some
styling modifications:

--8<---------------cut here---------------start------------->8---
@@ -604,31 +604,41 @@ (define-public python-scikit-surprise
   (package
     (name "python-scikit-surprise")
     (version "1.1.4")
-    (source (origin
-              (method git-fetch)
-              (uri (git-reference
-                    (url "https://github.com/NicolasHug/Surprise")
-                    (commit (string-append "v" version))))
-              (file-name (git-file-name name version))
-              (sha256
-               (base32
-                "15ckx2i41vs21sa3yqyj12zr0h4zrcdf3lrwcy2c1cq2bjq7mnvz"))))
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/NicolasHug/Surprise")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "15ckx2i41vs21sa3yqyj12zr0h4zrcdf3lrwcy2c1cq2bjq7mnvz"))))
     (build-system pyproject-build-system)
     (arguments
      (list
-      #:phases #~(modify-phases %standard-phases
-                   (add-before 'check 'change-home-dir
-                     (lambda _
-                       ;; Change from /homeless-shelter to /tmp for write
-                       ;; permission.
-                       (setenv "HOME" "/tmp"))))))
-    (native-inputs (list python-cython python-pandas python-pytest))
-    (propagated-inputs (list python-joblib python-numpy python-scikit-learn))
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-before 'check 'set-home
+            (lambda _
+              ;; Change from /homeless-shelter to /tmp for write
+              ;; permission.
+              (setenv "HOME" "/tmp"))))))
+    (native-inputs
+     (list python-cython-3
+           python-pandas
+           python-pytest
+           python-setuptools
+           python-wheel))
+    (propagated-inputs
+     (list python-joblib
+           python-numpy
+           python-scikit-learn))
     (home-page "https://surpriselib.com/")
     (synopsis "Recommender system library for Scikit-learn")
-    (description "This package provides a Python library for building and
-analyzing recommender systems that deal with explicit rating data.  It was
-designed with the following purposes in mind:
+    (description
+     "This package provides a Python library for building and analyzing
+recommender systems that deal with explicit rating data.  It was designed with
+the following purposes in mind:
 @itemize
 @item Provide tools to handle downloaded or user-provided datasets.
 @item Provide ready-to-use prediction algorithms and similarity measures.e
--8<---------------cut here---------------end--------------->8---

Pusshed as
--8<---------------cut here---------------start------------->8---
master local/20241204095328-issue-74680 16c71b7fe328a159f6e6d13b42ee23b448465905
Author:     Antero Mejr <mail <at> antr.me>
AuthorDate: Tue Dec 3 18:56:45 2024 -0500
Commit:     Sharlatan Hellseher <sharlatanus <at> gmail.com>
CommitDate: Wed Dec 4 14:28:10 2024 +0000
--8<---------------cut here---------------end--------------->8---

--
Oleg

[signature.asc (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: Antero Mejr <mail <at> antr.me>
To: guix-patches <at> gnu.org
Cc: sharlatanus <at> gmail.com, me <at> bonfacemunyoki.com, lars <at> 6xq.net,
 jgart <at> dismail.de, marius <at> gnu.org, tanguy <at> bioneland.org
Subject: [PATCH] gnu: Add python-scikit-surprise.
Date: Tue, 03 Dec 2024 18:56:45 -0500

* gnu/packages/python-science.scm (python-scikit-surprise): New variable.

Change-Id: I9b5e13f0c985f34bb0bd759e76ebd27221a340a4
---
 gnu/packages/python-science.scm | 38 +++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/gnu/packages/python-science.scm b/gnu/packages/python-science.scm
index ef6d529ffd..10bc4a249f 100644
--- a/gnu/packages/python-science.scm
+++ b/gnu/packages/python-science.scm
@@ -600,6 +600,44 @@ (define-public python-scikit-optimize
 @code{skopt} aims to be accessible and easy to use in many contexts.")
     (license license:bsd-3)))
 
+(define-public python-scikit-surprise
+  (package
+    (name "python-scikit-surprise")
+    (version "1.1.4")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/NicolasHug/Surprise")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "15ckx2i41vs21sa3yqyj12zr0h4zrcdf3lrwcy2c1cq2bjq7mnvz"))))
+    (build-system pyproject-build-system)
+    (arguments
+     (list
+      #:phases #~(modify-phases %standard-phases
+                   (add-before 'check 'change-home-dir
+                     (lambda _
+                       ;; Change from /homeless-shelter to /tmp for write
+                       ;; permission.
+                       (setenv "HOME" "/tmp"))))))
+    (native-inputs (list python-cython python-pandas python-pytest))
+    (propagated-inputs (list python-joblib python-numpy python-scikit-learn))
+    (home-page "https://surpriselib.com/")
+    (synopsis "Recommender system library for Scikit-learn")
+    (description "This package provides a Python library for building and
+analyzing recommender systems that deal with explicit rating data.  It was
+designed with the following purposes in mind:
+@itemize
+@item Provide tools to handle downloaded or user-provided datasets.
+@item Provide ready-to-use prediction algorithms and similarity measures.
+@item Provide a base for creating custom algorithims.
+@item Provide tools to evaluate, analyse and compare algorithm performance.
+@item Provide documentation with precise details regarding library algorithms.
+@end itemize")
+    (license license:bsd-3)))
+
 (define-public python-scikit-survival
   (let ((revision "1")
         ;; We need a later commit for support of a more recent sklearn and

base-commit: 9001514e242ad15c190588439930b0fa4f6782e3
-- 
2.43.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.