GNU bug report logs - #74680
[PATCH] gnu: Add python-scikit-surprise.

Previous Next

Package: guix-patches;

Reported by: Antero Mejr <mail <at> antr.me>

Date: Tue, 3 Dec 2024 23:58:02 UTC

Severity: normal

Tags: patch

Done: Sharlatan Hellseher <sharlatanus <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


Message #10 received at 74680-done <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 74680-done <at> debbugs.gnu.org
Subject: [PATCH] gnu: Add python-scikit-surprise.
Date: Wed, 04 Dec 2024 14:37:30 +0000
[Message part 1 (text/plain, inline)]
Hi,

Thank you for the patch!

I've checked the license, built it on the latest master HEAD and applied some
styling modifications:

--8<---------------cut here---------------start------------->8---
@@ -604,31 +604,41 @@ (define-public python-scikit-surprise
   (package
     (name "python-scikit-surprise")
     (version "1.1.4")
-    (source (origin
-              (method git-fetch)
-              (uri (git-reference
-                    (url "https://github.com/NicolasHug/Surprise")
-                    (commit (string-append "v" version))))
-              (file-name (git-file-name name version))
-              (sha256
-               (base32
-                "15ckx2i41vs21sa3yqyj12zr0h4zrcdf3lrwcy2c1cq2bjq7mnvz"))))
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/NicolasHug/Surprise")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "15ckx2i41vs21sa3yqyj12zr0h4zrcdf3lrwcy2c1cq2bjq7mnvz"))))
     (build-system pyproject-build-system)
     (arguments
      (list
-      #:phases #~(modify-phases %standard-phases
-                   (add-before 'check 'change-home-dir
-                     (lambda _
-                       ;; Change from /homeless-shelter to /tmp for write
-                       ;; permission.
-                       (setenv "HOME" "/tmp"))))))
-    (native-inputs (list python-cython python-pandas python-pytest))
-    (propagated-inputs (list python-joblib python-numpy python-scikit-learn))
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-before 'check 'set-home
+            (lambda _
+              ;; Change from /homeless-shelter to /tmp for write
+              ;; permission.
+              (setenv "HOME" "/tmp"))))))
+    (native-inputs
+     (list python-cython-3
+           python-pandas
+           python-pytest
+           python-setuptools
+           python-wheel))
+    (propagated-inputs
+     (list python-joblib
+           python-numpy
+           python-scikit-learn))
     (home-page "https://surpriselib.com/")
     (synopsis "Recommender system library for Scikit-learn")
-    (description "This package provides a Python library for building and
-analyzing recommender systems that deal with explicit rating data.  It was
-designed with the following purposes in mind:
+    (description
+     "This package provides a Python library for building and analyzing
+recommender systems that deal with explicit rating data.  It was designed with
+the following purposes in mind:
 @itemize
 @item Provide tools to handle downloaded or user-provided datasets.
 @item Provide ready-to-use prediction algorithms and similarity measures.e
--8<---------------cut here---------------end--------------->8---

Pusshed as
--8<---------------cut here---------------start------------->8---
master local/20241204095328-issue-74680 16c71b7fe328a159f6e6d13b42ee23b448465905
Author:     Antero Mejr <mail <at> antr.me>
AuthorDate: Tue Dec 3 18:56:45 2024 -0500
Commit:     Sharlatan Hellseher <sharlatanus <at> gmail.com>
CommitDate: Wed Dec 4 14:28:10 2024 +0000
--8<---------------cut here---------------end--------------->8---

--
Oleg
[signature.asc (application/pgp-signature, inline)]

This bug report was last modified 170 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.