From unknown Wed Jun 18 23:12:31 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#74677 <74677@debbugs.gnu.org> To: bug#74677 <74677@debbugs.gnu.org> Subject: Status: [PATCH] nix/local.mk: fix -lgcrypt link on --as-needed toolchains Reply-To: bug#74677 <74677@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:12:31 +0000 retitle 74677 [PATCH] nix/local.mk: fix -lgcrypt link on --as-needed toolch= ains reassign 74677 guix-patches submitter 74677 Sergei Trofimovich severity 74677 normal tag 74677 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 03 16:15:30 2024 Received: (at submit) by debbugs.gnu.org; 3 Dec 2024 21:15:30 +0000 Received: from localhost ([127.0.0.1]:33158 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tIaEz-0004M8-HZ for submit@debbugs.gnu.org; Tue, 03 Dec 2024 16:15:29 -0500 Received: from lists.gnu.org ([209.51.188.17]:44506) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tIaEx-0004Ly-5s for submit@debbugs.gnu.org; Tue, 03 Dec 2024 16:15:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tIaEw-0007j9-P9 for guix-patches@gnu.org; Tue, 03 Dec 2024 16:15:26 -0500 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tIaEv-0003Za-4J for guix-patches@gnu.org; Tue, 03 Dec 2024 16:15:26 -0500 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-434a1fe2b43so54354765e9.2 for ; Tue, 03 Dec 2024 13:15:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733260523; x=1733865323; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=fsdlE9qyKxn9B/BaABVCkiIYlO6aYRIZuPYamIp4Jn0=; b=bzNg8GzQwYIxw2BXHsSr+UBTvqSgc3JzyegPJ6TIPpRso+7liWCRDqThVzv5yDYu9y 3U1b0tAHfp/bDYtoQ0bPq2Q3kTzdz28z4NBGIpOxr1WW6hzBG2CcDaMvrEbKuKLTP5tS BsP62Nk5QoiDrN1CvbtpTOv5/OreTKaVROs80aa4wA1ZBK55Mn+tV9Y7gZnLmA2TfD0d TZaaPO5QaxUahcAM4NVXw448Un67KYebRcq5RPrXqwIG/IuxqQr/sAjWCNuW3L+Uo69w 80QWqkqI/8Dx3I5Xsu18f5eTiN7xRYS/JMUy2pLvSPuF+ODReVEmYBEEeUcAWramwWMI U+pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733260523; x=1733865323; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fsdlE9qyKxn9B/BaABVCkiIYlO6aYRIZuPYamIp4Jn0=; b=cfG47cxnO3dj1G9QClWWDOo74YrTYTCaYvizD0N8mss1xM8J0FoWGthmmEBTUCYWBu Nf3f9U4PBAjHtW33LmwVq/xPJVLATnuIxg6p2ES8R37tO1wvmyb3A7nfSCFamo7wltz8 K0nVwb2FiczveuNbPxSq9t+KU+A2YoTK1uhLq0N1U0FNLtixL/0ym4KVCb71uA2FDeWe BKrIQn0tUww+n22j+cDXEoV0wO6DInYhdI25GVU0FJ0PaLXCNRmclS5Pb1RwnOyKJ6ns 250VmN6gMdb19idgPVHebOqnu09kC23adWYco8wcUBCiCJ9UzWgO4YzfqRj+vBDzp2P8 jyqg== X-Gm-Message-State: AOJu0Ywv/FFoIaKuuns53LHxSFXrL89XC57pAj844QqzyXOddaDswdpO 3yTEqvVmHKLinyXdPcaKek046MGS7DwyT0YQRXyVjXKusNosx3qd X-Gm-Gg: ASbGncvBWiBPbHy2JtiuNBEhHs0xXWWRRvQwbDxvIoC1qbhigfsEUPg+valw+4+UpJV ttPEIa/ivO1ZgotZz7JFXA6ivyiCkg535ZO4rg6xsxfz4qmeS6hU6UQ8Um+8G68PhxslJtlWhq1 L23CyhM5U+dcRpbxA5NucRbRJSDRyjsVw2336CgnHp9Ox6yNJMAwU4BEJNZFj9my57eQ2XrOsvR bP0URiYpW7kB9zxQiTuKj7ceMyENiXSSYh139tTXg== X-Google-Smtp-Source: AGHT+IG0Im/y1b/QfKJVnt/14tQ+x/7WETaMNtCmRMzgJevuYhPncB+NmWjq4uJTivwye8JxupBFpg== X-Received: by 2002:a05:6000:2aa:b0:385:e8b0:df11 with SMTP id ffacd0b85a97d-385fd423e36mr3697249f8f.37.1733260523132; Tue, 03 Dec 2024 13:15:23 -0800 (PST) Received: from nz.home ([2a00:23c8:a613:101:8a9d:d969:1999:c879]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-385ccd3a4bbsm16697184f8f.48.2024.12.03.13.15.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Dec 2024 13:15:22 -0800 (PST) Received: by nz.home (Postfix, from userid 1000) id 05977255A8141D; Tue, 03 Dec 2024 21:15:22 +0000 (GMT) From: Sergei Trofimovich To: guix-patches@gnu.org Subject: [PATCH] nix/local.mk: fix -lgcrypt link on --as-needed toolchains Date: Tue, 3 Dec 2024 21:15:15 +0000 Message-ID: <20241203211515.1620700-1-slyich@gmail.com> X-Mailer: git-send-email 2.47.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=slyich@gmail.com; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Sergei Trofimovich X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) https://git.savannah.gnu.org/cgit/guix.git/commit/?id=8a7bd211d21f06c1234fbb82bb905d202d58f598 introduced a build regression on Gentoo as: x86_64-pc-linux-gnu-g++ -Wall -std=c++11 -O2 -pipe -Wl,-O1 -Wl,--as-needed -Wl,-z,pack-relative-relocs -Wl,--hash-style=gnu -lgcrypt -o guix-daemon nix/nix-daemon/guix_daemon-nix-daemon.o nix/nix-daemon/guix_daemon-guix-daemon.o libstore.a libutil.a libformat.a -lz -lsqlite3 -lbz2 /usr/lib/gcc/x86_64-pc-linux-gnu/14/../../../../x86_64-pc-linux-gnu/bin/ld: nix/nix-daemon/guix_daemon-guix-daemon.o: in function `main': guix-daemon.cc:(.text.startup+0x62): undefined reference to `gcry_check_version' This happens because: - Gentoo linker is using --Wl,-as-needed by default - -lgcrypt is passed before actual use of it's symbols in `guix-daemon.cc` The change uses `LIBGCRYPT_LDFLAGS` as if it was `LIBGCRYPT_LIBS`. * nix/local.mk (guix_daemon_LDADD): Use LIBGCRYPT_LDFLAGS instead of unset LIBGCRYPT_LIBS. --- nix/local.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nix/local.mk b/nix/local.mk index 8a2b2b88e8..50368457dd 100644 --- a/nix/local.mk +++ b/nix/local.mk @@ -124,7 +124,7 @@ guix_daemon_CPPFLAGS = \ guix_daemon_LDADD = \ libstore.a libutil.a libformat.a -lz \ - $(SQLITE3_LIBS) $(LIBGCRYPT_LIBS) + $(SQLITE3_LIBS) $(LIBGCRYPT_LDFLAGS) guix_daemon_headers = \ %D%/nix-daemon/shared.hh -- 2.47.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 09 17:17:42 2024 Received: (at 74677-done) by debbugs.gnu.org; 9 Dec 2024 22:17:42 +0000 Received: from localhost ([127.0.0.1]:56062 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tKm4U-0004m9-1v for submit@debbugs.gnu.org; Mon, 09 Dec 2024 17:17:42 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55412) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tKm4S-0004lo-Te for 74677-done@debbugs.gnu.org; Mon, 09 Dec 2024 17:17:41 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tKm4N-0006tW-Ed; Mon, 09 Dec 2024 17:17:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=wtoVUOb4zdudL7R/88ybrwA+8PS4bAPMxZ6vjqDOlQc=; b=Dy3sbXyhIBHYUjfS4Fn1 RDXHSMkRdHqM5hC/5whReFxn7809AxAshx2Ql35MQ4lEDwNeUlNtsVmJ3r/qUGqIBKQfwh4GzgJm3 l1/nJcJUa/Rzf3rzoO1R1/ety+nuoBE6uVMzwBhNM5XUrYJQ7QM8S8MlTrDvJpKtErwNNLP4n7CVn PB3HqeWX0oQ+nbIYhr53xPIfoMAOE7scohUWys7HGnKa9OIJHPuM4mNp5m1YIE70YbfSJrsyXQRB5 cheq+3jbtKrwhT0s2GWKa10N//u7ASRJg2MwfM5NLeyLh5UcxXUg7whPKnkCygeGMO+7EgotKPmVA pLX56Hs1CJRMbQ==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Sergei Trofimovich Subject: Re: [bug#74677] [PATCH] nix/local.mk: fix -lgcrypt link on --as-needed toolchains In-Reply-To: <20241203211515.1620700-1-slyich@gmail.com> (Sergei Trofimovich's message of "Tue, 3 Dec 2024 21:15:15 +0000") References: <20241203211515.1620700-1-slyich@gmail.com> Date: Mon, 09 Dec 2024 23:17:31 +0100 Message-ID: <871pyglcw4.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74677-done Cc: 74677-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Sergei, Sergei Trofimovich skribis: > https://git.savannah.gnu.org/cgit/guix.git/commit/?id=3D8a7bd211d21f06c12= 34fbb82bb905d202d58f598 > introduced a build regression on Gentoo as: > > x86_64-pc-linux-gnu-g++ -Wall -std=3Dc++11 -O2 -pipe -Wl,-O1 -Wl,--= as-needed -Wl,-z,pack-relative-relocs -Wl,--hash-style=3Dgnu -lgcrypt -o gu= ix-daemon nix/nix-daemon/guix_daemon-nix-daemon.o nix/nix-daemon/guix_daemo= n-guix-daemon.o libstore.a libutil.a libformat.a -lz -lsqlite3 -lbz2 > /usr/lib/gcc/x86_64-pc-linux-gnu/14/../../../../x86_64-pc-linux-gnu/b= in/ld: nix/nix-daemon/guix_daemon-guix-daemon.o: in function `main': > guix-daemon.cc:(.text.startup+0x62): undefined reference to `gcry_check_v= ersion' > > This happens because: > - Gentoo linker is using --Wl,-as-needed by default > - -lgcrypt is passed before actual use of it's symbols in `guix-daemon.cc` I pushed as dcaccc8b722cee279c00bb321baa48ae73563931 the patch Do=C4=9Fan =C3=87e=C3=A7en submitted to fix this regression and more: https://issues.guix.gnu.org/74686 Thanks, Ludo=E2=80=99. From unknown Wed Jun 18 23:12:31 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 07 Jan 2025 12:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator