Subject: bug#74677: closed (Re: [bug#74677] [PATCH] nix/local.mk: fix -lgcrypt link on --as-needed toolchains)

From: [email-masked] (GNU bug Tracking System)
Date: Mon, 09 Dec 2024 22:18:02 +0000

Your bug report

#74677: [PATCH] nix/local.mk: fix -lgcrypt link on --as-needed toolchains

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
74677: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=74677
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#74677] [PATCH] nix/local.mk: fix -lgcrypt link on --as-needed toolchains
From: Ludovic Courtès <[email-masked]>
To: Sergei Trofimovich <[email-masked]>
Cc: [email-masked]
Date: Mon, 09 Dec 2024 23:17:31 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi Sergei,

Sergei Trofimovich <[email-masked]> skribis:

> https://git.savannah.gnu.org/cgit/guix.git/commit/?id=8a7bd211d21f06c1234fbb82bb905d202d58f598
> introduced a build regression on Gentoo as:
>
>     x86_64-pc-linux-gnu-g++ -Wall -std=c++11 -O2 -pipe   -Wl,-O1 -Wl,--as-needed -Wl,-z,pack-relative-relocs -Wl,--hash-style=gnu -lgcrypt -o guix-daemon nix/nix-daemon/guix_daemon-nix-daemon.o nix/nix-daemon/guix_daemon-guix-daemon.o libstore.a libutil.a libformat.a -lz -lsqlite3  -lbz2
>     /usr/lib/gcc/x86_64-pc-linux-gnu/14/../../../../x86_64-pc-linux-gnu/bin/ld: nix/nix-daemon/guix_daemon-guix-daemon.o: in function `main':
> guix-daemon.cc:(.text.startup+0x62): undefined reference to `gcry_check_version'
>
> This happens because:
> - Gentoo linker is using --Wl,-as-needed by default
> - -lgcrypt is passed before actual use of it's symbols in `guix-daemon.cc`

I pushed as dcaccc8b722cee279c00bb321baa48ae73563931 the patch
Doğan Çeçen submitted to fix this regression and more:

  https://issues.guix.gnu.org/74686

Thanks,
Ludo’.

Subject: [PATCH] nix/local.mk: fix -lgcrypt link on --as-needed toolchains
From: Sergei Trofimovich <[email-masked]>
To: [email-masked]
Cc: Sergei Trofimovich <[email-masked]>
Date: Tue, 3 Dec 2024 21:15:15 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

https://git.savannah.gnu.org/cgit/guix.git/commit/?id=8a7bd211d21f06c1234fbb82bb905d202d58f598
introduced a build regression on Gentoo as:

    x86_64-pc-linux-gnu-g++ -Wall -std=c++11 -O2 -pipe   -Wl,-O1 -Wl,--as-needed -Wl,-z,pack-relative-relocs -Wl,--hash-style=gnu -lgcrypt -o guix-daemon nix/nix-daemon/guix_daemon-nix-daemon.o nix/nix-daemon/guix_daemon-guix-daemon.o libstore.a libutil.a libformat.a -lz -lsqlite3  -lbz2
    /usr/lib/gcc/x86_64-pc-linux-gnu/14/../../../../x86_64-pc-linux-gnu/bin/ld: nix/nix-daemon/guix_daemon-guix-daemon.o: in function `main':
guix-daemon.cc:(.text.startup+0x62): undefined reference to `gcry_check_version'

This happens because:
- Gentoo linker is using --Wl,-as-needed by default
- -lgcrypt is passed before actual use of it's symbols in `guix-daemon.cc`

The change uses `LIBGCRYPT_LDFLAGS` as if it was `LIBGCRYPT_LIBS`.

* nix/local.mk (guix_daemon_LDADD): Use LIBGCRYPT_LDFLAGS instead of
  unset LIBGCRYPT_LIBS.
---
 nix/local.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/nix/local.mk b/nix/local.mk
index 8a2b2b88e8..50368457dd 100644
--- a/nix/local.mk
+++ b/nix/local.mk
@@ -124,7 +124,7 @@ guix_daemon_CPPFLAGS =				\
 
 guix_daemon_LDADD =				\
   libstore.a libutil.a libformat.a -lz		\
-  $(SQLITE3_LIBS) $(LIBGCRYPT_LIBS)
+  $(SQLITE3_LIBS) $(LIBGCRYPT_LDFLAGS)
 
 guix_daemon_headers =				\
   %D%/nix-daemon/shared.hh
-- 
2.47.0