GNU bug report logs - #74658
Remove the Mail-Followup-To header when empty

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 74658 in the body.
You can then email your comments to 74658 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tomas Volf <~@wolfsden.cz>
To: bug-gnu-emacs <at> gnu.org
Subject: Remove the Mail-Followup-To header when empty
Date: Tue, 03 Dec 2024 00:17:10 +0100

[Message part 1 (text/plain, inline)]

Tags: patch

According to the info manual (message)Mailing Lists, the
Mail-Followup-To header should be removed when it is empty:

> If there is one, it is left alone.  (Except if it’s empty; in that
> case, the field is removed and is not replaced with an automatically
> generated one.  This lets you disable MFT generation on a per-message
> basis.)

While the code attempted to do that, the call to `message-remove-header'
passed wrong arguments.  Since the IS-REGEXP argument was not passed,
the HEADER was considered a full header name (if I read the code right)
and therefore failed to match (since the code passed in a regexp instead
of a fixed string).

The fix is simple, remove the leading ^ and trailing :.

Change log entry as requested:

Actually remove the Mail-Followup-To header iff empty in
message-send-mail.

* lisp/gnus/message.el (message-send-mail)
[(equal "" (mail-fetch-field "mail-followup-to")]: Pass a fixed string
instead of regexp to `message-remove-header'.



In GNU Emacs 29.4 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.41,
cairo version 1.18.0)
Windowing system distributor 'The X.Org Foundation', version 11.0.12101012
System Description: Guix System

Configured using:
 'configure
 CONFIG_SHELL=/gnu/store/3jhfhxdf6v5ms10x5zmnl166dh3yhbr1-bash-minimal-5.1.16/bin/bash
 SHELL=/gnu/store/3jhfhxdf6v5ms10x5zmnl166dh3yhbr1-bash-minimal-5.1.16/bin/bash
 --prefix=/gnu/store/s8757iarmns4dpklil8pgdikmb68v7bf-emacs-29.4
 --enable-fast-install --with-cairo --with-modules
 --with-native-compilation=aot --disable-build-details'

[mail-followup-to.patch (text/patch, attachment)]

Message #8 received at 74658 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: Tomas Volf <~@wolfsden.cz>
Cc: 74658 <at> debbugs.gnu.org
Subject: Re: bug#74658: Remove the Mail-Followup-To header when empty
Date: Tue, 03 Dec 2024 15:02:58 +0100

>>>>> On Tue, 03 Dec 2024 00:17:10 +0100, Tomas Volf <~@wolfsden.cz> said:

    Tomas> Tags: patch
    Tomas> According to the info manual (message)Mailing Lists, the
    Tomas> Mail-Followup-To header should be removed when it is empty:

    >> If there is one, it is left alone.  (Except if it’s empty; in that
    >> case, the field is removed and is not replaced with an automatically
    >> generated one.  This lets you disable MFT generation on a per-message
    >> basis.)

    Tomas> While the code attempted to do that, the call to `message-remove-header'
    Tomas> passed wrong arguments.  Since the IS-REGEXP argument was not passed,
    Tomas> the HEADER was considered a full header name (if I read the code right)
    Tomas> and therefore failed to match (since the code passed in a regexp instead
    Tomas> of a fixed string).

    Tomas> The fix is simple, remove the leading ^ and trailing :.

Yep. I can apply this to master. Maintainers, is adding
Copyright-paperwork-exempt: yes enough here? Or do we need a copyright
assignment from Tomas?

Robert
-- 

Message #11 received at 74658 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Robert Pluim <rpluim <at> gmail.com>
Cc: 74658 <at> debbugs.gnu.org, ~@wolfsden.cz
Subject: Re: bug#74658: Remove the Mail-Followup-To header when empty
Date: Tue, 03 Dec 2024 16:18:06 +0200

> Cc: 74658 <at> debbugs.gnu.org
> From: Robert Pluim <rpluim <at> gmail.com>
> Date: Tue, 03 Dec 2024 15:02:58 +0100
> 
> >>>>> On Tue, 03 Dec 2024 00:17:10 +0100, Tomas Volf <~@wolfsden.cz> said:
> 
>     Tomas> Tags: patch
>     Tomas> According to the info manual (message)Mailing Lists, the
>     Tomas> Mail-Followup-To header should be removed when it is empty:
> 
>     >> If there is one, it is left alone.  (Except if it’s empty; in that
>     >> case, the field is removed and is not replaced with an automatically
>     >> generated one.  This lets you disable MFT generation on a per-message
>     >> basis.)
> 
>     Tomas> While the code attempted to do that, the call to `message-remove-header'
>     Tomas> passed wrong arguments.  Since the IS-REGEXP argument was not passed,
>     Tomas> the HEADER was considered a full header name (if I read the code right)
>     Tomas> and therefore failed to match (since the code passed in a regexp instead
>     Tomas> of a fixed string).
> 
>     Tomas> The fix is simple, remove the leading ^ and trailing :.
> 
> Yep. I can apply this to master. Maintainers, is adding
> Copyright-paperwork-exempt: yes enough here? Or do we need a copyright
> assignment from Tomas?

"Copyright-paperwork-exempt: yes" is enough.

Thanks.

Message #14 received at 74658 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 74658 <at> debbugs.gnu.org, ~@wolfsden.cz
Subject: Re: bug#74658: Remove the Mail-Followup-To header when empty
Date: Tue, 03 Dec 2024 16:22:32 +0100

tags 74658 fixed
close 74658 31.1
quit

>>>>> On Tue, 03 Dec 2024 16:18:06 +0200, Eli Zaretskii <eliz <at> gnu.org> said:

    Eli> "Copyright-paperwork-exempt: yes" is enough.

Thanks.

Closing.
Committed as 0033ce9ef8e

(with a slightly amended log message, mainly mentioning the bug
number).

Robert
-- 

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.