Subject: Re: [bug#74654] [PATCH 2/5] packages: Optimize‘all-packages’.

From: Ludovic Courtès <[email-masked]>
Date: Wed, 04 Dec 2024 17:34:01 +0100

Hello,

David Elsing <[email-masked]> skribis:

> Ludovic Courtès <[email-masked]> writes:
>
>> On my laptop, wall-clock time for (all-packages) goes from 27s to 1s.
>>
>> * gnu/packages.scm (all-packages): Use a hash table to remember visited
>> packages instead of calling ‘delete-duplicates’ on the final list.
>
> Thanks for fixing this, commit 4b5dae8 also made
> `guix graph -t reverse-package` much slower, because `delete-duplicates`
> had not been used in the old `all-packages` procedure before. I wanted
> to make a patch, but then saw your series already. :)

Yes, my bad!  I tried to take the common denominator of all the
‘all-packages’ procedures, and here’s what happens.  :-)

Ludo’.