Subject: Re: [PATCH 2/5] packages: Optimize ‘all-packages’.

From: David Elsing <[email-masked]>
Date: Mon, 02 Dec 2024 23:47:48 +0000

Hi,

Ludovic Courtès <[email-masked]> writes:

> On my laptop, wall-clock time for (all-packages) goes from 27s to 1s.
>
> * gnu/packages.scm (all-packages): Use a hash table to remember visited
> packages instead of calling ‘delete-duplicates’ on the final list.

Thanks for fixing this, commit 4b5dae8 also made
`guix graph -t reverse-package` much slower, because `delete-duplicates`
had not been used in the old `all-packages` procedure before. I wanted
to make a patch, but then saw your series already. :)

Cheers,
David