From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 02 11:52:17 2024 Received: (at submit) by debbugs.gnu.org; 2 Dec 2024 16:52:17 +0000 Received: from localhost ([127.0.0.1]:56333 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tI9ei-0002x6-PE for submit@debbugs.gnu.org; Mon, 02 Dec 2024 11:52:17 -0500 Received: from lists.gnu.org ([209.51.188.17]:55182) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tI9ef-0002ww-Ea for submit@debbugs.gnu.org; Mon, 02 Dec 2024 11:52:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tI9ef-0002H2-8e for guix-patches@gnu.org; Mon, 02 Dec 2024 11:52:13 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tI9ee-0006qP-Bn; Mon, 02 Dec 2024 11:52:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to: references; bh=VkxKdTIfxvuwqQxEStss9nF8CwjrzJJF0W0Mex55+VY=; b=ZSI4M61ZjGa/vN BlferNxRYluYyXNu/MQF/1hRwHXAG3+FtW72/eFsNSkibSAnvBRaQ2ybSdM9LfhWXxp4/j117+NlQ gDRG9qECsKgRLud82BR6EsE0p4IBWjRcbkJMLBOWUExkvPHtZVLRnH0v88tIuovDmcYyk3fG+6Eq8 x0vFCAlqWpGf7ml2LaYYOgOXwI9paD14TiCDdHoQvn+bvBKDVO5yyNFHE56uAxeWAdYk95F6zDN4j ODvBapgLC+ZTQ370g5c/ZOHJTmBpZh6yGHdxZsBiCqVoRK7MAYbmEB9B/nqHS0nG8J9Up1rGzimps Hwv1aauX6yYKAtSOiUbQ==; From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: guix-patches@gnu.org Subject: [PATCH 0/5] Optimize 'all-packages'; add ungrafting manifest Date: Mon, 2 Dec 2024 17:51:53 +0100 Message-ID: X-Mailer: git-send-email 2.46.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello Guix! This is a followup to : • Optimizing ‘all-packages’ significantly (speeds up ‘guix build -P’ and ‘guix refresh -l’); • Moving manifests to ‘etc/manifests’ (we’ll have to update Cuirass specs that refer to these files); • Adding an “ungrafting” package that rebuilds everything without grafts, just like what we’d do manually. The goal is to have that ungrafting manifest under CI, such that anytime the corresponding jobset is green, we can ungraft everything with the guarantee that binaries are available. Thoughts? Ludo’. Ludovic Courtès (5): etc: Move manifests to a separate directory. packages: Optimize ‘all-packages’. build-system/cargo: Simplify ‘crate-closure’. guix build: Last argument of ‘dependents’ is optional. maint: Add ungrafting manifest. Makefile.am | 21 ++++---- .../disarchive.scm} | 2 +- etc/{hurd-manifest.scm => manifests/hurd.scm} | 0 .../kernels.scm} | 0 .../release.scm} | 0 .../source.scm} | 0 etc/{ => manifests}/system-tests.scm | 0 .../time-travel.scm} | 0 etc/manifests/ungraft.scm | 49 +++++++++++++++++++ .../upgrade.scm} | 0 gnu/packages.scm | 30 +++++++----- guix/build-system/cargo.scm | 12 ++--- guix/scripts/build.scm | 4 +- 13 files changed, 87 insertions(+), 31 deletions(-) rename etc/{disarchive-manifest.scm => manifests/disarchive.scm} (99%) rename etc/{hurd-manifest.scm => manifests/hurd.scm} (100%) rename etc/{kernels-manifest.scm => manifests/kernels.scm} (100%) rename etc/{release-manifest.scm => manifests/release.scm} (100%) rename etc/{source-manifest.scm => manifests/source.scm} (100%) rename etc/{ => manifests}/system-tests.scm (100%) rename etc/{time-travel-manifest.scm => manifests/time-travel.scm} (100%) create mode 100644 etc/manifests/ungraft.scm rename etc/{upgrade-manifest.scm => manifests/upgrade.scm} (100%) base-commit: 522732d5c15e44fc9e061f36a41f7129edfee66f -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 02 11:53:55 2024 Received: (at 74654) by debbugs.gnu.org; 2 Dec 2024 16:53:55 +0000 Received: from localhost ([127.0.0.1]:56345 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tI9gI-000328-5n for submit@debbugs.gnu.org; Mon, 02 Dec 2024 11:53:54 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49076) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tI9gE-00031b-RL for 74654@debbugs.gnu.org; Mon, 02 Dec 2024 11:53:51 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tI9g9-0007Ik-L6; Mon, 02 Dec 2024 11:53:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=72H0MEOIOZV3ywbvcvlFNa7uFIJ6RNCLLfYC1cm7UAI=; b=mVjoToqfS8Fy3B4MDS5W +ltlofOI0tSjCuifWuU3hrPf9hCd57KbcazenIP9+gTIabMpkaUyHzOx4svnJsP8JSuIyLonw75Am K+oumWRTj1wFkBGqqLbH+JtwN+ysCK7tted2AHG7TM3EkFHKwFSxyjo13Yq9rJkFlrNuew/ANKMCi OQvbftUIjQdgf/8URCTsY2Z0Xny5xPpBao/QZEHwtsmxXyYSw6/B9uHuO1RDEC7alPmoIz80UKvMd Da3GccVfOSKjm1bUxZ8MwIh9S5ziDZyhFOYAKyS31iwab6klhEK7CG8LSTSX+Ly4GK23NbgKHyhLB +bOg82dkRFlclg==; From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 74654@debbugs.gnu.org Subject: [PATCH 1/5] etc: Move manifests to a separate directory. Date: Mon, 2 Dec 2024 17:53:26 +0100 Message-ID: X-Mailer: git-send-email 2.46.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74654 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * etc/disarchive-manifest.scm, etc/hurd-manifest.scm, etc/kernels-manifest.scm, etc/release-manifest.scm, etc/source-manifest.scm, etc/system-tests.scm, etc/time-travel-manifest.scm, etc/upgrade-manifest.scm: Move to… * etc/manifests: … here, and drop “-manifest” from file name. * Makefile.am (EXTRA_DIST, assert-binaries-available, check-system): Adjust accordingly. Change-Id: Iedee3d0cdd42e72ef8bbf654ea5d3b47dca95874 --- Makefile.am | 20 +++++++++---------- .../disarchive.scm} | 2 +- etc/{hurd-manifest.scm => manifests/hurd.scm} | 0 .../kernels.scm} | 0 .../release.scm} | 0 .../source.scm} | 0 etc/{ => manifests}/system-tests.scm | 0 .../time-travel.scm} | 0 .../upgrade.scm} | 0 9 files changed, 11 insertions(+), 11 deletions(-) rename etc/{disarchive-manifest.scm => manifests/disarchive.scm} (99%) rename etc/{hurd-manifest.scm => manifests/hurd.scm} (100%) rename etc/{kernels-manifest.scm => manifests/kernels.scm} (100%) rename etc/{release-manifest.scm => manifests/release.scm} (100%) rename etc/{source-manifest.scm => manifests/source.scm} (100%) rename etc/{ => manifests}/system-tests.scm (100%) rename etc/{time-travel-manifest.scm => manifests/time-travel.scm} (100%) rename etc/{upgrade-manifest.scm => manifests/upgrade.scm} (100%) diff --git a/Makefile.am b/Makefile.am index 0cff32c607..8c763c68aa 100644 --- a/Makefile.am +++ b/Makefile.am @@ -686,7 +686,7 @@ endif !CAN_RUN_TESTS check-system: $(GOBJECTS) $(AM_V_at)$(top_builddir)/pre-inst-env \ - guix build -m $(top_srcdir)/etc/system-tests.scm -K + guix build -m $(top_srcdir)/etc/manifests/system-tests.scm -K # Public keys used to sign substitutes. dist_pkgdata_DATA = \ @@ -733,17 +733,17 @@ EXTRA_DIST += \ build-aux/update-guix-package.scm \ build-aux/xgettext.scm \ doc/build.scm \ - etc/disarchive-manifest.scm \ etc/guix-install.sh \ etc/historical-authorizations \ etc/news.scm \ - etc/hurd-manifest.scm \ - etc/kernels-manifest.scm \ - etc/release-manifest.scm \ - etc/source-manifest.scm \ - etc/system-tests.scm \ - etc/time-travel-manifest.scm \ - etc/upgrade-manifest.scm \ + etc/manifests/disarchive.scm \ + etc/manifests/hurd.scm \ + etc/manifests/kernels.scm \ + etc/manifests/release.scm \ + etc/manifests/source.scm \ + etc/manifests/system-tests.scm \ + etc/manifests/time-travel.scm \ + etc/manifests/upgrade.scm \ scripts/guix.in \ tests/cve-sample.json \ tests/keys/civodul.pub \ @@ -1194,7 +1194,7 @@ assert-no-store-file-names: # server so that '--display-missing' doesn't print two lists. assert-binaries-available: $(GOBJECTS) $(AM_V_at)$(top_builddir)/pre-inst-env \ - guix weather -m "$(top_srcdir)/etc/release-manifest.scm" \ + guix weather -m "$(top_srcdir)/etc/manifests/release.scm" \ --substitute-urls="https://ci.guix.gnu.org" \ --display-missing diff --git a/etc/disarchive-manifest.scm b/etc/manifests/disarchive.scm similarity index 99% rename from etc/disarchive-manifest.scm rename to etc/manifests/disarchive.scm index 3dbfa356df..a7f71414b6 100644 --- a/etc/disarchive-manifest.scm +++ b/etc/manifests/disarchive.scm @@ -24,7 +24,7 @@ (guix base16) (gnu packages)) -(include "source-manifest.scm") +(include "source.scm") (define (tarball-origin? origin) (match (origin-actual-file-name origin) diff --git a/etc/hurd-manifest.scm b/etc/manifests/hurd.scm similarity index 100% rename from etc/hurd-manifest.scm rename to etc/manifests/hurd.scm diff --git a/etc/kernels-manifest.scm b/etc/manifests/kernels.scm similarity index 100% rename from etc/kernels-manifest.scm rename to etc/manifests/kernels.scm diff --git a/etc/release-manifest.scm b/etc/manifests/release.scm similarity index 100% rename from etc/release-manifest.scm rename to etc/manifests/release.scm diff --git a/etc/source-manifest.scm b/etc/manifests/source.scm similarity index 100% rename from etc/source-manifest.scm rename to etc/manifests/source.scm diff --git a/etc/system-tests.scm b/etc/manifests/system-tests.scm similarity index 100% rename from etc/system-tests.scm rename to etc/manifests/system-tests.scm diff --git a/etc/time-travel-manifest.scm b/etc/manifests/time-travel.scm similarity index 100% rename from etc/time-travel-manifest.scm rename to etc/manifests/time-travel.scm diff --git a/etc/upgrade-manifest.scm b/etc/manifests/upgrade.scm similarity index 100% rename from etc/upgrade-manifest.scm rename to etc/manifests/upgrade.scm -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 02 11:54:14 2024 Received: (at 74654) by debbugs.gnu.org; 2 Dec 2024 16:54:14 +0000 Received: from localhost ([127.0.0.1]:56354 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tI9gZ-00033Q-3w for submit@debbugs.gnu.org; Mon, 02 Dec 2024 11:54:14 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49914) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tI9gW-00032n-R6 for 74654@debbugs.gnu.org; Mon, 02 Dec 2024 11:54:09 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tI9gP-0007MG-E5; Mon, 02 Dec 2024 11:54:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=rucvIXxZb70NbuOfSW/40lmBSTo34tbHlGOz0LCeoaY=; b=OBmfmDuQgJV3+3cf7ccR +pe2Z7iTDrUH3hoXHsYT1wx2hrHbNOQGZTVDCKsn8NP/j9Ut6PLNdCaylneFtIbuV2YDWCTC/WK6l 3KGC5Rrq0HawiE840EWi20fI5YvRO557TuUpVg5JKD3IVJZnkiO9zA8dGxno0lnhcpQtBJresZoRI GukXjH+YVU1Qnoy2F0OB/3DCl2tivCvC4CK3T3w7S8suooFliv5d1cnB/7gXuKeqJzkLYQPfNYPaz 9aJQWGg3qAxBGdESsh7Tv6dzY0QgTKSMD20uPhHl2sHdBAtDewESFufowWN7+uSMtx7cBCPg5WX/l IOwgCoWT3PxyyQ==; From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 74654@debbugs.gnu.org Subject: [PATCH 2/5] =?UTF-8?q?packages:=20Optimize=20=E2=80=98all-package?= =?UTF-8?q?s=E2=80=99.?= Date: Mon, 2 Dec 2024 17:53:27 +0100 Message-ID: <642880c208f4445f1d63dba5618a315671d558e2.1733158049.git.ludo@gnu.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74654 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On my laptop, wall-clock time for (all-packages) goes from 27s to 1s. * gnu/packages.scm (all-packages): Use a hash table to remember visited packages instead of calling ‘delete-duplicates’ on the final list. Change-Id: I4aae804656b56ef2095993e91f0572a5891f419f --- gnu/packages.scm | 30 +++++++++++++++++++----------- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git a/gnu/packages.scm b/gnu/packages.scm index 1af3b8d440..bdd5d21940 100644 --- a/gnu/packages.scm +++ b/gnu/packages.scm @@ -258,18 +258,26 @@ (define all-packages (mlambda () "Return the list of all public packages, including replacements and hidden packages, excluding superseded packages." - (delete-duplicates - (fold-packages (lambda (package result) - (match (package-replacement package) - ((? package? replacement) - (cons* replacement package result)) - (#f - (cons package result)))) - '() + ;; Note: 'fold-packages' never traverses the same package twice but + ;; replacements break that (they may or may not be visible to + ;; 'fold-packages'), hence this hash table to track visited packages. + (define visited (make-hash-table)) - ;; Dismiss deprecated packages but keep hidden packages. - #:select? (negate package-superseded)) - eq?))) + (fold-packages (lambda (package result) + (if (hashq-ref visited package) + result + (begin + (hashq-set! visited package #t) + (match (package-replacement package) + ((? package? replacement) + (hashq-set! visited replacement #t) + (cons* replacement package result)) + (#f + (cons package result)))))) + '() + + ;; Dismiss deprecated packages but keep hidden packages. + #:select? (negate package-superseded)))) (define %package-cache-file ;; Location of the package cache. -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 02 11:54:16 2024 Received: (at 74654) by debbugs.gnu.org; 2 Dec 2024 16:54:16 +0000 Received: from localhost ([127.0.0.1]:56360 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tI9gc-00033j-7Z for submit@debbugs.gnu.org; Mon, 02 Dec 2024 11:54:16 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49916) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tI9gX-00032z-Tb for 74654@debbugs.gnu.org; Mon, 02 Dec 2024 11:54:10 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tI9gS-0007Mq-7h; Mon, 02 Dec 2024 11:54:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=r2ivJS6nZrVmPSTJnpfzcn2cGH/gAsCMTGifmiQG4/E=; b=Ut69OFcTxximwad4t+Il JIivHHSX6IwpW3dmpy2ssCl6gCpcZaRrTt7MOwF+qnV3hT5IidWZuAZAJdXkPC5CIx9KYJ3HakNQd AcQF4M2RxsBlGsvot6WeDzZp/3ewulARUYztYJ9FBYD7YHjm38RWCJZpicwlltugOKJwR0lKY2dOM s8tmrCLHyCoelPwrvEZXlto1/iOO5vQwbcjFEs6ntGltPzLwnB8xN9T9YagUlR8eWJu3hNh4pu+pW LmgBw2XTBqDCYb6LzF3o2lzhRk91qtxakSMKjwqxnP5jVvPxawUo66uSmuzaTE981/uEvHXzSHXFd dvGPtX4+cPrF/A==; From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 74654@debbugs.gnu.org Subject: [PATCH 3/5] =?UTF-8?q?build-system/cargo:=20Simplify=20=E2=80=98c?= =?UTF-8?q?rate-closure=E2=80=99.?= Date: Mon, 2 Dec 2024 17:53:28 +0100 Message-ID: X-Mailer: git-send-email 2.46.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Debbugs-Cc: Efraim Flashner Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74654 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * guix/build-system/cargo.scm (crate-closure): Remove ‘first?’. Change-Id: Ica1a661eb422a882ae3a1a54819b2dd7d68449de --- guix/build-system/cargo.scm | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/guix/build-system/cargo.scm b/guix/build-system/cargo.scm index 658a2e525e..0e9a4b1d23 100644 --- a/guix/build-system/cargo.scm +++ b/guix/build-system/cargo.scm @@ -1,5 +1,5 @@ ;;; GNU Guix --- Functional package management for GNU -;;; Copyright © 2013, 2014, 2015, 2016, 2019, 2021 Ludovic Courtès +;;; Copyright © 2013-2016, 2019, 2021, 2024 Ludovic Courtès ;;; Copyright © 2013 Andreas Enge ;;; Copyright © 2013 Nikita Karetnikov ;;; Copyright © 2016 David Craven @@ -227,24 +227,22 @@ (define (crate-closure inputs) (let loop ((inputs inputs) (result '()) (propagated '()) - (first? #t) (seen vlist-null)) (match inputs (() (if (null? propagated) (reverse result) - (loop (reverse (concatenate propagated)) result '() #f seen))) + (loop (reverse (concatenate propagated)) result '() seen))) (((and input (label (? package? package))) rest ...) - (if (and (not first?) (seen? seen package)) - (loop rest result propagated first? seen) + (if (seen? seen package) + (loop rest result propagated seen) (loop rest (cons input result) (cons (package-cargo-inputs package) propagated) - first? (vhash-consq package package seen)))) ((input rest ...) - (loop rest (cons input result) propagated first? seen))))) + (loop rest (cons input result) propagated seen))))) (define (expand-crate-sources cargo-inputs cargo-development-inputs) "Extract all transitive sources for CARGO-INPUTS and CARGO-DEVELOPMENT-INPUTS -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 02 11:54:19 2024 Received: (at 74654) by debbugs.gnu.org; 2 Dec 2024 16:54:19 +0000 Received: from localhost ([127.0.0.1]:56364 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tI9gh-000348-0g for submit@debbugs.gnu.org; Mon, 02 Dec 2024 11:54:19 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49920) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tI9gZ-000335-JC for 74654@debbugs.gnu.org; Mon, 02 Dec 2024 11:54:13 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tI9gU-0007NJ-23; Mon, 02 Dec 2024 11:54:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=M9jWdqsreBRQBBqezMNHrFrDZkT0WUxU/f2rISO9ELE=; b=IIhSTfUcBq0h16lFyV+I gAzJ4DPWRN/msQfZHmVZrnUrRWvxC5virWMEEklSkd9fSFV1idJH5B8nO8XKvedSQYp1IcWAuddxT mKF0wLesR1WjZPDjHGCeWD65GNrRrhvh6R9/5iPYkQvQOOgwmLJadY0mnOpm5T/tOXDwtt0xT7vsV Ano+maZ6/Oz8RERt+NP3VoZNv8uB7Wh72k7wgv92k90ahVsLxlwkB6rzfF40qlYuuOAFv4dJjioya wSbcyicmVkZzndK66mJtCQUqlI8cIgj3hXllJmnMNvlJvCU1Nhy2RbVR+8emIXzPDjditXyugGFxW lfUYC1Eve9YPfQ==; From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 74654@debbugs.gnu.org Subject: [PATCH 4/5] =?UTF-8?q?guix=20build:=20Last=20argument=20of=20?= =?UTF-8?q?=E2=80=98dependents=E2=80=99=20is=20optional.?= Date: Mon, 2 Dec 2024 17:53:29 +0100 Message-ID: X-Mailer: git-send-email 2.46.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Debbugs-Cc: Christopher Baines , Josselin Poiret , Ludovic Courtès , Mathieu Othacehe , Simon Tournier , Tobias Geerinckx-Rice Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74654 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * guix/scripts/build.scm (dependents): Make ‘max-depth’ optional. Improve docstring. Change-Id: Ibeffcf15297ecba3d4000b3adb4e3bc7853f6957 --- guix/scripts/build.scm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/guix/scripts/build.scm b/guix/scripts/build.scm index 0080f1fe58..f0a637a2ef 100644 --- a/guix/scripts/build.scm +++ b/guix/scripts/build.scm @@ -564,8 +564,8 @@ (define %options %standard-cross-build-options %standard-native-build-options))) -(define (dependents store packages max-depth) - "List all the things that would need to be rebuilt if PACKAGES are changed." +(define* (dependents store packages #:optional (max-depth +inf.0)) + "Return the list of dependents of all of PACKAGES up to distance MAX-DEPTH." ;; Using %BAG-NODE-TYPE is more accurate than using %PACKAGE-NODE-TYPE ;; because it includes implicit dependencies. (define (get-dependents packages edges) -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 02 11:54:20 2024 Received: (at 74654) by debbugs.gnu.org; 2 Dec 2024 16:54:20 +0000 Received: from localhost ([127.0.0.1]:56366 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tI9gh-00034K-GA for submit@debbugs.gnu.org; Mon, 02 Dec 2024 11:54:19 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49934) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tI9ga-000339-9G for 74654@debbugs.gnu.org; Mon, 02 Dec 2024 11:54:16 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tI9gU-0007Nb-U7; Mon, 02 Dec 2024 11:54:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=lpCa3tcqAJtntBzbdeO9B+/kfT7V3XFKEmyygId6RXA=; b=KvAyHWvtAHxLrKWf+Qzz hXH7L9L1N+VnDqLLKJl4vZnxL+6JjsZuOS0ysuVc6jh+Sb6nDYmAQnIzU4amJNTeSfOCijXS9R5fd dC1ZAFfieubmBQt8SScQG/NzsE14wosoG4Y0/ivvJJe2O7vxHHW+ZQ750r/7dBxLsCG1qAmb6dnH9 tPlsiqwqp/JI9ucS+X3WBioF8e1xempOzmwWRPKPPduoIfF3yRzAs0aaCE9mQ9gAhGH4tdZiVdT55 EpyE9s2aUJHPt3RuSAgwmvlkY+G7KvkHVyybBdyFJo92OGtp4hdsnrml4yFZQp5v8QmzeMMTqaPW/ SfZXMQoqQRsapw==; From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 74654@debbugs.gnu.org Subject: [PATCH 5/5] maint: Add ungrafting manifest. Date: Mon, 2 Dec 2024 17:53:30 +0100 Message-ID: <72da72b50dbd8e0afd848c80582925f31dfe5cec.1733158049.git.ludo@gnu.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74654 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * etc/manifests/ungraft.scm: New file. * Makefile.am (EXTRA_DIST): Add it. Change-Id: If4aa7649721b93d3297ecd967d5db4a6b71ec6eb --- Makefile.am | 1 + etc/manifests/ungraft.scm | 49 +++++++++++++++++++++++++++++++++++++++ 2 files changed, 50 insertions(+) create mode 100644 etc/manifests/ungraft.scm diff --git a/Makefile.am b/Makefile.am index 8c763c68aa..d0d195636b 100644 --- a/Makefile.am +++ b/Makefile.am @@ -743,6 +743,7 @@ EXTRA_DIST += \ etc/manifests/source.scm \ etc/manifests/system-tests.scm \ etc/manifests/time-travel.scm \ + etc/manifests/ungraft.scm \ etc/manifests/upgrade.scm \ scripts/guix.in \ tests/cve-sample.json \ diff --git a/etc/manifests/ungraft.scm b/etc/manifests/ungraft.scm new file mode 100644 index 0000000000..3e42b98ece --- /dev/null +++ b/etc/manifests/ungraft.scm @@ -0,0 +1,49 @@ +;;; GNU Guix --- Functional package management for GNU +;;; Copyright © 2024 Ludovic Courtès +;;; +;;; This file is part of GNU Guix. +;;; +;;; GNU Guix is free software; you can redistribute it and/or modify it +;;; under the terms of the GNU General Public License as published by +;;; the Free Software Foundation; either version 3 of the License, or (at +;;; your option) any later version. +;;; +;;; GNU Guix is distributed in the hope that it will be useful, but +;;; WITHOUT ANY WARRANTY; without even the implied warranty of +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;;; GNU General Public License for more details. +;;; +;;; You should have received a copy of the GNU General Public License +;;; along with GNU Guix. If not, see . + +;; This manifest "ungrafts" all the currently grafted packages and returns +;; said packages and all their dependents. + +(use-modules (guix diagnostics) + (guix i18n) + (guix packages) + (guix profiles) + (guix store) + ((guix scripts build) #:select (dependents)) + ((gnu packages) #:select (all-packages)) + (srfi srfi-1)) + +(define (grafted-packages) + (info (G_ "enumerating grafted packages...~%")) + (let ((result (filter package-replacement (all-packages)))) + (info (G_ "found ~d grafted packages:~{ ~a~}~%") + (length result) (map package-full-name result)) + result)) + +(manifest + (with-store store + (let* ((grafted (grafted-packages)) + (ungraft-all (package-input-rewriting + (map (lambda (package) + `(,package . ,(package-replacement package))) + grafted)))) + (map (lambda (package) + (manifest-entry + (inherit (package->manifest-entry (ungraft-all package))) + (name (string-append (package-name package) "-ungrafted")))) + (dependents store grafted))))) -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 02 14:13:03 2024 Received: (at 74654) by debbugs.gnu.org; 2 Dec 2024 19:13:03 +0000 Received: from localhost ([127.0.0.1]:56596 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tIBqw-00025V-Vu for submit@debbugs.gnu.org; Mon, 02 Dec 2024 14:13:03 -0500 Received: from mail-wr1-f49.google.com ([209.85.221.49]:43443) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tIBqu-000253-6A for 74654@debbugs.gnu.org; Mon, 02 Dec 2024 14:13:01 -0500 Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-385dbf79881so2231774f8f.1 for <74654@debbugs.gnu.org>; Mon, 02 Dec 2024 11:13:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733166719; x=1733771519; darn=debbugs.gnu.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender:from:to :cc:subject:date:message-id:reply-to; bh=/jKFV0J4G8tK/wN7zabK+Lg373yz2m4E4dq3Nu3zdFI=; b=XDaeutlqlwK+nYg2YXydhblDwPyAoWzMQE+1V3tBjlAshKWupcFjM+46Dhs1B6PRgp x4fKkckyrWb+DtRD0lr6Q+Ss/7ji6ahYIx86Af+fxXjpAvi7rJmJ7Jt+n9o8WaKzkqJP QKc8hhVqgkUq1q50NP+eHHwOC/Ql6PLJBl3sluIN3njFpxCXxlRGCidhrl2vDzU4F1mE Mfae8R7yeQbWf8wwgu2aytihXitUit+foHPBRVI2XyUgbg6sUG2uQDBllF95mSTWGhv8 2de4aU6sP+EfvU0gKDTPjf1+SP1EzIWVCnPndFtxTJlHFA1vQoYrZFstOJg8tXjBEMkp po3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733166719; x=1733771519; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/jKFV0J4G8tK/wN7zabK+Lg373yz2m4E4dq3Nu3zdFI=; b=uMq5xJrAMENYzZGW5xNjtaSC/EQt7DA1kur2fIBl6iLNiZmxO4syNaRgEhMEZJ2Dxt wHTc6BoWrBUH34FXbPFN/OD8qM5zC9rlpElMEDnEm6/OfkBC+2HCCfjAo4kwAuOFxRRX mPlZJd1mbtZPr4BZp+GPLCeNVR1eqYqjYmt2j3/b+iBJQtbNpsXgsxAAFVJ1NkMQrgE7 /EME7K1atSy3lauRETzOQFe7Belsx0s5UJ8JdfrUiBcf9JcBd/14bRuFgwXpdqEM9+AF u9xrDdoThShgKce23y1O2TLcM2ioa1Vp+v+mSRN/bPBtbiWCWPU7LuF34BHAHDCqdJeP YEcw== X-Gm-Message-State: AOJu0YzEGYRyZUtSQH+awYoUpnBz/LREK4PE+hwLM8up2LXHQWp64R1t 4BaEokMgDpl936qmKWvvgUuWZEoiz2btu48BQd89SwH2w0I75YnAWjdiMxMU X-Gm-Gg: ASbGncvygrq8jJe/mnVh9QxCU4VGxbsVkA5/uEDbf1dYT37RSMGikYHaty1/f2nkwtQ QkdxyRLfFUs9hlGbeDfkmQePfmrXvLonvKFIG7K30aYMFJeHp1Pq0v8UwlqxdB48fFu9lTVsQIT ca73+msQZH+lbgndDvkIcRzdWHPcvnooa6RNHcK2gI21i1Pf+tP8dB8DR4DjdobSBtWTRt9cOPB 4pe5eW33EB1CIsHjj7wqUVc4meA3aVUisWL0QN5XkQzN9Y= X-Google-Smtp-Source: AGHT+IHIFteXYm/E/J21dxFkw1SXioxx4IJI0pB5F0pT6P+6nnkYifEoRf4vj3N/vSKlSFhZ8YXVZw== X-Received: by 2002:a05:6000:1f81:b0:385:faf5:ebb8 with SMTP id ffacd0b85a97d-385faf5efd9mr1420351f8f.7.1733166718913; Mon, 02 Dec 2024 11:11:58 -0800 (PST) Received: from localhost ([141.226.9.46]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-385ccd3a4bbsm13475018f8f.48.2024.12.02.11.11.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Dec 2024 11:11:58 -0800 (PST) Date: Mon, 2 Dec 2024 21:11:56 +0200 From: Efraim Flashner To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#74654] [PATCH 3/5] =?utf-8?Q?buil?= =?utf-8?B?ZC1zeXN0ZW0vY2FyZ286IFNpbXBsaWZ5IOKAmGNyYXRlLWNsb3N1cmXigJku?= Message-ID: Mail-Followup-To: Efraim Flashner , Ludovic =?utf-8?Q?Court=C3=A8s?= , 74654@debbugs.gnu.org References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="V4ezjDDxlqmO/zRC" Content-Disposition: inline In-Reply-To: X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 74654 Cc: 74654@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --V4ezjDDxlqmO/zRC Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable I test applied this on master and then went to build my rusty-packages manifest. The time on './pre-inst-env guix build -m ... -n' went from 35 seconds to 20 seconds and the derivations didn't change. On Mon, Dec 02, 2024 at 05:53:28PM +0100, Ludovic Court=C3=A8s wrote: > * guix/build-system/cargo.scm (crate-closure): Remove =E2=80=98first?=E2= =80=99. >=20 > Change-Id: Ica1a661eb422a882ae3a1a54819b2dd7d68449de > --- > guix/build-system/cargo.scm | 12 +++++------- > 1 file changed, 5 insertions(+), 7 deletions(-) >=20 > diff --git a/guix/build-system/cargo.scm b/guix/build-system/cargo.scm > index 658a2e525e..0e9a4b1d23 100644 > --- a/guix/build-system/cargo.scm > +++ b/guix/build-system/cargo.scm > @@ -1,5 +1,5 @@ > ;;; GNU Guix --- Functional package management for GNU > -;;; Copyright =C2=A9 2013, 2014, 2015, 2016, 2019, 2021 Ludovic Court=C3= =A8s > +;;; Copyright =C2=A9 2013-2016, 2019, 2021, 2024 Ludovic Court=C3=A8s > ;;; Copyright =C2=A9 2013 Andreas Enge > ;;; Copyright =C2=A9 2013 Nikita Karetnikov > ;;; Copyright =C2=A9 2016 David Craven > @@ -227,24 +227,22 @@ (define (crate-closure inputs) > (let loop ((inputs inputs) > (result '()) > (propagated '()) > - (first? #t) > (seen vlist-null)) > (match inputs > (() > (if (null? propagated) > (reverse result) > - (loop (reverse (concatenate propagated)) result '() #f seen))) > + (loop (reverse (concatenate propagated)) result '() seen))) > (((and input (label (? package? package))) rest ...) > - (if (and (not first?) (seen? seen package)) > - (loop rest result propagated first? seen) > + (if (seen? seen package) > + (loop rest result propagated seen) > (loop rest > (cons input result) > (cons (package-cargo-inputs package) > propagated) > - first? > (vhash-consq package package seen)))) > ((input rest ...) > - (loop rest (cons input result) propagated first? seen))))) > + (loop rest (cons input result) propagated seen))))) > =20 > (define (expand-crate-sources cargo-inputs cargo-development-inputs) > "Extract all transitive sources for CARGO-INPUTS and CARGO-DEVELOPMENT= -INPUTS > --=20 > 2.46.0 >=20 >=20 >=20 --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --V4ezjDDxlqmO/zRC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmdOBnwACgkQQarn3Mo9 g1FesQ//W9xNfHPV8BL2Fd7FfEghh8j/8HF7ex2+r3cTwvlqI7LqioeGJKDolGVv zISZmsm8MDLns9yZzfERjV0fskKIy/Q3JkahXkMIAGjjhu8J5nnPumbuckJZRcqo IZnMH4ht63I/F8+CRPjfhOHQKjvNTtOhXVucuUzQ3HtwwGVy3PPJ6hXcLeFkp+ut akvDhqFPnBr80Wuw9EsT5sNhFcvPDlQBAKEKNsEDH676bQ/5C+EFwxUBCBJGQ3lj EokKb3b80T5+jqQ0DOy01N/u18NhkXpeGr/KpKfDnG2Sh94a1xpaJawq1oCMDbVY zjrJ+P3Q4A+WDGQLK8fkF/szD/0EVvyn2c2Ivg0fXAwLLzNccLy1wjo7988p5bvy BDrHJ6+ErQrvIhJgc8UROB3zTnrHK2TPFHnGnuTbBdPxL3JqcWYCWNgwyG/RNcaL xkyvkKZVb8QQ5pRrHp7H3zZOCsRlRuPjcA649EAhFg2yUIn+Lppo3BK00pMmE0X0 FPl5LF19W8GQ6f2AIXEWsWtyJiFe4ZUIOHmXMpYQGKS9QAk1AEUNktj9AuSaKiP7 cLiQ707r5+bw61pvPSRG8BUulvbG49PJCu5vIzyg50/BRIa6SJMRaK6lZmxc766e Qg/1SQgqaNhBbSCHbEXAzf6bZ87aQfpFM6LGGYuRyjfzZq//b2A= =LVo0 -----END PGP SIGNATURE----- --V4ezjDDxlqmO/zRC-- From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 02 17:25:13 2024 Received: (at 74654) by debbugs.gnu.org; 2 Dec 2024 22:25:13 +0000 Received: from localhost ([127.0.0.1]:56847 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tIEqu-0003PI-LR for submit@debbugs.gnu.org; Mon, 02 Dec 2024 17:25:12 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33878) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tIEqr-0003O3-Vl for 74654@debbugs.gnu.org; Mon, 02 Dec 2024 17:25:10 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tIEqj-0002OX-5n; Mon, 02 Dec 2024 17:25:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=xfqEwhVcQJUcz5WKzH9w1n32/m0yq2sFlV++rWS01Ck=; b=ZLZZCgXUOmMCfXSA9wTN GaI2vcgNJNHCRS0nXTEBQgtMBEiACw40dM2Sjnb1hdTql+PsofQTJdUDVOBiQBM4OOD/M3WgqAmYh UUMQt5MsX58Lc59kIcEEvl4nWX9zbgltAb2k4RQfpehlNh/t5yRv2hxENv/8Cayf3+YxDNQ/gp4Ef 1/yVlCF8DtrRHLlfncuq6APJnYPe8WGhjWxgB3/O7LfJ6T0CK+Y+wZX6hd4XTvpQD4i15H1J13wWb LwBrQ7799mttkMxMGt0Mi/1aK3GI6CkbwtTzDrssv6TDh24rR6PF5IFY1t/kK51IkF5KpOOrj1qKv hEATVoDMUYsQCw==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Efraim Flashner Subject: Re: [bug#74654] [PATCH 3/5] build-system/cargo: Simplify =?utf-8?Q?=E2=80=98crate-closure=E2=80=99=2E?= In-Reply-To: (Efraim Flashner's message of "Mon, 2 Dec 2024 21:11:56 +0200") References: Date: Mon, 02 Dec 2024 23:24:58 +0100 Message-ID: <87ttbl3epx.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74654 Cc: 74654@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Efraim Flashner skribis: > I test applied this on master and then went to build my rusty-packages > manifest. The time on './pre-inst-env guix build -m ... -n' went from 35 > seconds to 20 seconds and the derivations didn't change. Thanks for testing! I didn=E2=80=99t expect this to have an impact on performance, interesting. Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 02 18:48:00 2024 Received: (at 74654) by debbugs.gnu.org; 2 Dec 2024 23:48:00 +0000 Received: from localhost ([127.0.0.1]:57003 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tIG92-0007Xv-04 for submit@debbugs.gnu.org; Mon, 02 Dec 2024 18:48:00 -0500 Received: from mout01.posteo.de ([185.67.36.65]:43269) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tIG90-0007Xa-1H for 74654@debbugs.gnu.org; Mon, 02 Dec 2024 18:47:58 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id CA790240027 for <74654@debbugs.gnu.org>; Tue, 3 Dec 2024 00:47:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1733183270; bh=LVARH1XehY7v35r+bPaWH0SMqDwyM5Ho+6HKJjxccRw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: Content-Transfer-Encoding:From; b=p9P8oV+uJ4KDz4+LXZOFqnRvhnpiO3bSqBIl3/gUAtJfr77qUdWTFstg764Xw0TN+ POswOO8/Th9qVPw6giYZ9Y2miI+M6hhh9vgBwIhueNuxL2mMdVqwq/U8OtSzSxiL7K QwY1t7mh5dUyTgVGM0cffl9j/APGq3egjWYbueysk+fUUACX8Jl2czzZ8eu5aBBk91 SnT9i+B2y3PFoo07uGYm/O1G3lnTqZ9q9RiDJVTzME3pQNVHLWGhHl4f1H2Eh4lC4X ccuWszwgA6LqtBIAoeFHEkHgrAEsYM1K4TqC2DiD4BvBozWp1z5ss2BA30ceQa4sAG Cw+OXpMLTjqGw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Y2L7T3sCyz6twQ; Tue, 3 Dec 2024 00:47:49 +0100 (CET) From: David Elsing To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [PATCH 2/5] packages: Optimize =?utf-8?Q?=E2=80=98all-package?= =?utf-8?Q?s=E2=80=99=2E?= In-Reply-To: <642880c208f4445f1d63dba5618a315671d558e2.1733158049.git.ludo@gnu.org> References: <642880c208f4445f1d63dba5618a315671d558e2.1733158049.git.ludo@gnu.org> Date: Mon, 02 Dec 2024 23:47:48 +0000 Message-ID: <7ywmghr6jf.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74654 Cc: 74654@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Ludovic Court=C3=A8s writes: > On my laptop, wall-clock time for (all-packages) goes from 27s to 1s. > > * gnu/packages.scm (all-packages): Use a hash table to remember visited > packages instead of calling =E2=80=98delete-duplicates=E2=80=99 on the fi= nal list. Thanks for fixing this, commit 4b5dae8 also made `guix graph -t reverse-package` much slower, because `delete-duplicates` had not been used in the old `all-packages` procedure before. I wanted to make a patch, but then saw your series already. :) Cheers, David From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 02 22:05:44 2024 Received: (at 74654) by debbugs.gnu.org; 3 Dec 2024 03:05:44 +0000 Received: from localhost ([127.0.0.1]:57383 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tIJEN-0000eV-91 for submit@debbugs.gnu.org; Mon, 02 Dec 2024 22:05:44 -0500 Received: from smtp81.cstnet.cn ([159.226.251.81]:33810 helo=cstnet.cn) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tIJEJ-0000dw-60 for 74654@debbugs.gnu.org; Mon, 02 Dec 2024 22:05:41 -0500 Received: from m (unknown [107.174.64.25]) by APP-03 (Coremail) with SMTP id rQCowAD3l+1ydU5nIVBXBw--.12468S2; Tue, 03 Dec 2024 11:05:26 +0800 (CST) From: Z572 To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#74654] [PATCH 1/5] etc: Move manifests to a separate directory. In-Reply-To: ("Ludovic =?utf-8?Q?Court=C3=A8s=22's?= message of "Mon, 2 Dec 2024 17:53:26 +0100") References: User-Agent: mu4e 1.12.7; emacs 30.0.92 Date: Tue, 03 Dec 2024 11:05:15 +0800 Message-ID: <874j3l5uvo.fsf@iscas.ac.cn> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-CM-TRANSID: rQCowAD3l+1ydU5nIVBXBw--.12468S2 X-Coremail-Antispam: 1UD129KBjvJXoW3AFW7Gw4rZFyDGF18XFW8JFb_yoW7XF17pw sakFWxtwn3CF1jqanxCFnxuF4Iyr15KF98Jr4qyr10yF1YvF4UXws3Kry3tF1Iqr1xX3s0 v3yktry5Jwn8uFUanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvCb7Iv0xC_Kw4lb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I2 0VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rw A2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xII jxv20xvEc7CjxVAFwI0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwV C2z280aVCY1x0267AKxVW8Jr0_Cr1UM2vj62AExVA0xI801c8C04v26x02cVCv0xWle2I2 62IYc4CY6c8Ij28IcVAaY2xG8wASzI0EjI02j7AqF2xKxwAqx4xG64xvF2IEw4CE5I8CrV C2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE 7xkEbVWUJVW8JwACjcxG0xvEwIxGrwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbV WUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF 67kF1VAFwI0_Jrv_JF1lIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42 IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF 0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Jr0_GrUvcSsGvfC2Kf nxnUUI43ZEXa7IUeAHUPUUUUU== X-Originating-IP: [107.174.64.25] X-CM-SenderInfo: x2kh0wxmxqyx3h6l2u1dvotugofq/ X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74654 Cc: 74654@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > * etc/disarchive-manifest.scm, etc/hurd-manifest.scm, > etc/kernels-manifest.scm, etc/release-manifest.scm, > etc/source-manifest.scm, etc/system-tests.scm, > etc/time-travel-manifest.scm, etc/upgrade-manifest.scm: Move to=E2=80=A6 > * etc/manifests: =E2=80=A6 here, and drop =E2=80=9C-manifest=E2=80=9D fro= m file name. > * Makefile.am (EXTRA_DIST, assert-binaries-available, check-system): > Adjust accordingly. Once these files are moved, it may be necessary to mention them in etc/news.scm to inform others that they need to update their cuirass specs. > > Change-Id: Iedee3d0cdd42e72ef8bbf654ea5d3b47dca95874 > --- > Makefile.am | 20 +++++++++---------- > .../disarchive.scm} | 2 +- > etc/{hurd-manifest.scm =3D> manifests/hurd.scm} | 0 > .../kernels.scm} | 0 > .../release.scm} | 0 > .../source.scm} | 0 > etc/{ =3D> manifests}/system-tests.scm | 0 > .../time-travel.scm} | 0 > .../upgrade.scm} | 0 > 9 files changed, 11 insertions(+), 11 deletions(-) > rename etc/{disarchive-manifest.scm =3D> manifests/disarchive.scm} (99%) > rename etc/{hurd-manifest.scm =3D> manifests/hurd.scm} (100%) > rename etc/{kernels-manifest.scm =3D> manifests/kernels.scm} (100%) > rename etc/{release-manifest.scm =3D> manifests/release.scm} (100%) > rename etc/{source-manifest.scm =3D> manifests/source.scm} (100%) > rename etc/{ =3D> manifests}/system-tests.scm (100%) > rename etc/{time-travel-manifest.scm =3D> manifests/time-travel.scm} (10= 0%) > rename etc/{upgrade-manifest.scm =3D> manifests/upgrade.scm} (100%) > > diff --git a/Makefile.am b/Makefile.am > index 0cff32c607..8c763c68aa 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -686,7 +686,7 @@ endif !CAN_RUN_TESTS >=20=20 > check-system: $(GOBJECTS) > $(AM_V_at)$(top_builddir)/pre-inst-env \ > - guix build -m $(top_srcdir)/etc/system-tests.scm -K > + guix build -m $(top_srcdir)/etc/manifests/system-tests.scm -K >=20=20 > # Public keys used to sign substitutes. > dist_pkgdata_DATA =3D \ > @@ -733,17 +733,17 @@ EXTRA_DIST +=3D \ > build-aux/update-guix-package.scm \ > build-aux/xgettext.scm \ > doc/build.scm \ > - etc/disarchive-manifest.scm \ > etc/guix-install.sh \ > etc/historical-authorizations \ > etc/news.scm \ > - etc/hurd-manifest.scm \ > - etc/kernels-manifest.scm \ > - etc/release-manifest.scm \ > - etc/source-manifest.scm \ > - etc/system-tests.scm \ > - etc/time-travel-manifest.scm \ > - etc/upgrade-manifest.scm \ > + etc/manifests/disarchive.scm \ > + etc/manifests/hurd.scm \ > + etc/manifests/kernels.scm \ > + etc/manifests/release.scm \ > + etc/manifests/source.scm \ > + etc/manifests/system-tests.scm \ > + etc/manifests/time-travel.scm \ > + etc/manifests/upgrade.scm \ > scripts/guix.in \ > tests/cve-sample.json \ > tests/keys/civodul.pub \ > @@ -1194,7 +1194,7 @@ assert-no-store-file-names: > # server so that '--display-missing' doesn't print two lists. > assert-binaries-available: $(GOBJECTS) > $(AM_V_at)$(top_builddir)/pre-inst-env \ > - guix weather -m "$(top_srcdir)/etc/release-manifest.scm" \ > + guix weather -m "$(top_srcdir)/etc/manifests/release.scm" \ > --substitute-urls=3D"https://ci.guix.gnu.org" \ > --display-missing >=20=20 > diff --git a/etc/disarchive-manifest.scm b/etc/manifests/disarchive.scm > similarity index 99% > rename from etc/disarchive-manifest.scm > rename to etc/manifests/disarchive.scm > index 3dbfa356df..a7f71414b6 100644 > --- a/etc/disarchive-manifest.scm > +++ b/etc/manifests/disarchive.scm > @@ -24,7 +24,7 @@ > (guix base16) > (gnu packages)) >=20=20 > -(include "source-manifest.scm") > +(include "source.scm") >=20=20 > (define (tarball-origin? origin) > (match (origin-actual-file-name origin) > diff --git a/etc/hurd-manifest.scm b/etc/manifests/hurd.scm > similarity index 100% > rename from etc/hurd-manifest.scm > rename to etc/manifests/hurd.scm > diff --git a/etc/kernels-manifest.scm b/etc/manifests/kernels.scm > similarity index 100% > rename from etc/kernels-manifest.scm > rename to etc/manifests/kernels.scm > diff --git a/etc/release-manifest.scm b/etc/manifests/release.scm > similarity index 100% > rename from etc/release-manifest.scm > rename to etc/manifests/release.scm > diff --git a/etc/source-manifest.scm b/etc/manifests/source.scm > similarity index 100% > rename from etc/source-manifest.scm > rename to etc/manifests/source.scm > diff --git a/etc/system-tests.scm b/etc/manifests/system-tests.scm > similarity index 100% > rename from etc/system-tests.scm > rename to etc/manifests/system-tests.scm > diff --git a/etc/time-travel-manifest.scm b/etc/manifests/time-travel.scm > similarity index 100% > rename from etc/time-travel-manifest.scm > rename to etc/manifests/time-travel.scm > diff --git a/etc/upgrade-manifest.scm b/etc/manifests/upgrade.scm > similarity index 100% > rename from etc/upgrade-manifest.scm > rename to etc/manifests/upgrade.scm --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEfr6klGDOXiwIdX/bO1qpk+Gi3/AFAmdOdWsACgkQO1qpk+Gi 3/Cvig//bfDkGs8fN8fvXsIq7+UheB/sGhE6m+kO0L6JfzDG8M77v3t2K3JS6ok7 OJxF9IAArEy5Zgfk6t4R3vl93ELnt+eclO9+0GGkoJmhK7poHWl/ptYdNGoqX1f5 N19k0od8oMG3wRNAGbAddyjpRb+zS97VqVF/QROEkAK/jnQZakze2e4vNba/rK09 lYFJ2DjD6R9PS2RIuSN+VWWy4o0jc90fbn/gXqEF3XDi3DV1cAKV1FHBfI9o5NeL FeZnbve5Ry66M/AmH2iIkh881LQYsy2njAx7srKIkBUqzf1eM069Mgrt/6/cvO3+ WXPphIHN4lMb+L9IRDu402/DMhWWXDSrEh9IgH1PAVaB7UCEd+AUAOFFiAU73FoS kQBE+DO1RhDV3D3V8HC6oWBGYvrdHCXfVlgb/0ASSHNTHTtT0SmRjVUvA/yP4Dke G3JL5QNKVoRwNJ2hP7NGJeCOBPsCjAF4CNUcPxcpIJZlf+WrwijwjqUmUhEpQ7q2 57XMBBhGQubwVkWrieyx5RLfydL2wppGv4sKGsntVbPbXQ29RTLT/8hLZNeBE52q P3c7R1WYsJzJin/wqYd+3lCoDMAECvLZtUbgde1O9z1wY8LNNY69jsA7oKJfQcwW jJ5hWnezPUQh+HcnV3Z/KLVm/qnEMEZ4W26yPrWqW5NZ91zkhPU= =5HE1 -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 04 11:32:49 2024 Received: (at 74654) by debbugs.gnu.org; 4 Dec 2024 16:32:49 +0000 Received: from localhost ([127.0.0.1]:36496 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tIsIy-0002MH-SJ for submit@debbugs.gnu.org; Wed, 04 Dec 2024 11:32:49 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56178) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tIsIx-0002M2-8T for 74654@debbugs.gnu.org; Wed, 04 Dec 2024 11:32:48 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tIsIr-0006dA-If; Wed, 04 Dec 2024 11:32:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=f4hZKKbJ6jxGHEK96uepEftrM+BLCAnYfCcITxRnZkc=; b=eRXcTAXlDkKVp1eU1ANH Lvx1KduxA/WyjaunwTAmEvU1Mm1YojgDPpdMXc3Qq2PRchPa9ceD+jcDZcJOHjGRcI0WMbkViwkiy +as+h7+07d0/vXLHKb8MmbA//sJJRTgw2emNY8O+d7NUJPIqOxGqeqnyazu9cttXjvRDpRVmo9BBr pqI+fFwvoyDarZ6JkLRHG4eiKyoclR3Aa0UGjUAoXpDXTkpJfF+fqnshC3RYDWXxsGISZbYiNXt5y 60GGyQfmu6E1bwwr6S4ezkIhONaMkEFiqwsAHOW2sONuLPu/rKXnw8S7BNslqbkF7USqDd22x+eRp b2a4wf+caKaulA==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Z572 Subject: Re: [bug#74654] [PATCH 1/5] etc: Move manifests to a separate directory. In-Reply-To: <874j3l5uvo.fsf@iscas.ac.cn> (zhengjunjie@iscas.ac.cn's message of "Tue, 03 Dec 2024 11:05:15 +0800") References: <874j3l5uvo.fsf@iscas.ac.cn> Date: Wed, 04 Dec 2024 17:32:36 +0100 Message-ID: <871pynxvbv.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74654 Cc: 74654@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Z572 skribis: > Ludovic Court=C3=A8s writes: > >> * etc/disarchive-manifest.scm, etc/hurd-manifest.scm, >> etc/kernels-manifest.scm, etc/release-manifest.scm, >> etc/source-manifest.scm, etc/system-tests.scm, >> etc/time-travel-manifest.scm, etc/upgrade-manifest.scm: Move to=E2=80=A6 >> * etc/manifests: =E2=80=A6 here, and drop =E2=80=9C-manifest=E2=80=9D fr= om file name. >> * Makefile.am (EXTRA_DIST, assert-binaries-available, check-system): >> Adjust accordingly. > > Once these files are moved, it may be necessary to mention them in > etc/news.scm to inform others that they need to update their cuirass > specs. Do you think they are used outside the Guix project? They=E2=80=99re not documented and not meant for general consumption. Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 04 11:34:13 2024 Received: (at 74654) by debbugs.gnu.org; 4 Dec 2024 16:34:13 +0000 Received: from localhost ([127.0.0.1]:36506 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tIsKK-0002Q7-SX for submit@debbugs.gnu.org; Wed, 04 Dec 2024 11:34:13 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56092) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tIsKH-0002Pf-BX for 74654@debbugs.gnu.org; Wed, 04 Dec 2024 11:34:10 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tIsKB-0007SE-2b; Wed, 04 Dec 2024 11:34:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=svpcnAQYuDSjWjaMlt56LkDuJG8xGyH/WLicuaS0K4E=; b=IgXaCwnBFm7XaidrJYGf mJczWf8DxEGGgkyq5OMsY/kOlIoJ7vDiUpTVAORufg4MPDB1ILmql0To44Hd5CLvnnq/cm6OX1b5t lhOKCfHMKSX0Vs5yULdGl5AIpSWmNWhD5Vepahi9gzCzpQA4iU5mFbWzpi7/grQECWPtSh+nffqo4 Pjj20MR+Ur3EVhY7NWgct+Z4aZu81ToTscDpeXqfX8bW+3+2PujiXHT34Gy7/qBDdIeeKNfFTYIQM X7dws7ubn2S9QLcjcCAXvaoS5uNdkjgadVxPxryTfPxvhBI2DG4u+2jzEDW8d/6B+UQnKQY1CtyPT K0dU8eEZzHmo/g==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: David Elsing Subject: Re: [bug#74654] [PATCH 2/5] packages: Optimize =?utf-8?Q?=E2=80=98all-packages=E2=80=99=2E?= In-Reply-To: <7ywmghr6jf.fsf@posteo.net> (David Elsing's message of "Mon, 02 Dec 2024 23:47:48 +0000") References: <642880c208f4445f1d63dba5618a315671d558e2.1733158049.git.ludo@gnu.org> <7ywmghr6jf.fsf@posteo.net> Date: Wed, 04 Dec 2024 17:34:01 +0100 Message-ID: <87wmgfwgp2.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74654 Cc: 74654@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello, David Elsing skribis: > Ludovic Court=C3=A8s writes: > >> On my laptop, wall-clock time for (all-packages) goes from 27s to 1s. >> >> * gnu/packages.scm (all-packages): Use a hash table to remember visited >> packages instead of calling =E2=80=98delete-duplicates=E2=80=99 on the f= inal list. > > Thanks for fixing this, commit 4b5dae8 also made > `guix graph -t reverse-package` much slower, because `delete-duplicates` > had not been used in the old `all-packages` procedure before. I wanted > to make a patch, but then saw your series already. :) Yes, my bad! I tried to take the common denominator of all the =E2=80=98all-packages=E2=80=99 procedures, and here=E2=80=99s what happens.= :-) Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 10 11:50:04 2024 Received: (at 74654) by debbugs.gnu.org; 10 Dec 2024 16:50:05 +0000 Received: from localhost ([127.0.0.1]:59304 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tL3Qx-0005iK-GD for submit@debbugs.gnu.org; Tue, 10 Dec 2024 11:50:04 -0500 Received: from mail-wr1-f42.google.com ([209.85.221.42]:52318) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tL3Qv-0005hH-JZ for 74654@debbugs.gnu.org; Tue, 10 Dec 2024 11:50:02 -0500 Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-3862ca8e0bbso3404616f8f.0 for <74654@debbugs.gnu.org>; Tue, 10 Dec 2024 08:50:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733849336; x=1734454136; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=IoZm+PSI8M4gdV9Ej6aaYiGVKT96odwvpKCzXqs6SrI=; b=haOdTCE5aqCMd5EXWYDiXRuAvRslNhFDEYc9f0nHxJwiEAaztZ1vIiw7Qnxr/W7v46 M5Ha8TztWjnNANW30lUvivpp+unEygigxR/4m5OtJJeh6YdQjbzdrG/wIJaET5Z/vAjV qni8oYQv1SmhzDWsx6lPV0s8+/H+Sw8qfazFI+iqbLY2rvqLf+c279/eUMPZqs9rbD01 G5iT14lPL+eeQG/tvQ+4oHBk2Ij7ejF9dXazAfXX8DNSFtWMPH21D98wsKvECf1jX6DZ FWSxrJcMSl3HRNUkB2hmEvZ7REaEQSJEFVjdcEzbWpCYlnVuyP6nec+bwEMSAccAG01n 7U0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733849336; x=1734454136; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IoZm+PSI8M4gdV9Ej6aaYiGVKT96odwvpKCzXqs6SrI=; b=mSOtmp5Tiv5B1AozCMI6JhlOvNe4b40FKxKHWdGA1O0EDNgfGpwiVThmvy7WGoDdTx gapb48zF5TBnMmzwUCRcJDNkUglLDsYIs3QtA2inw/HiVlchQUBokwszabA08njTB9z0 tvNjfHyN6ED2c/KO53B27AYwaIlYi+ya8KsB88QsmdIfklEb1g43JA3BmULJt0x2bVSL gsDSOfiTImHnt0oluLi6zWq/nRtd/qRszi8snyHeiB9FsBtmdBDrksvOQOFNbPWYMdRh G7VkBvXPMLaY18We++HAkAiibIFfaBF8PfyMU2KG9+dNXBFnvEQ5zDdlKG44CZk5jiiM rRVQ== X-Forwarded-Encrypted: i=1; AJvYcCXv9NvfZ5ykmtjiSK05FCtZlpvX4XgAhu1wgwx2gSK+2cKjB9E81sjrJXyhPVNiAn5TS9pncA==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yyvs18joieZiMQAcLDdN1bPLJfNyLUSo+I4jS0e+PzGp1Wo/SXF DDH7qfxEOmHveC/LPIXWdYbswKR+Mz6d6Mk5eNGiKRwxzCIjnN6VBzn3Ng== X-Gm-Gg: ASbGnct1+E08rwJMShlIo+CoKuAR4L/MzC/EDAHUbSSfY1GZm9TfZVhuB22cAZ4/d3y m7bfBrnujbnXMCM1AzkdHXBhIVzZCkMJZz374tMCTOOeIVCLHTsR2p4VObUz8HoduXxMbfTtrx8 Peiz32VSI6aktOx7SiwpukDT857Vl99ODdeqy9AzLbcI69wKx64xDop2S+UKTP9GpgNFDRg5yrx o77mKcLuVGOsAbzz6tUW4JidFWC4DxC7/HoPFZ9pPYWEPGJ8g== X-Google-Smtp-Source: AGHT+IHVOiO3Eq+eirp35tZ20CnMCsPI2Epck72oGvPqzuLt1CQqMY32Tkxp4fKAtn+qtfldfizgIw== X-Received: by 2002:a05:6000:42c5:b0:385:ef8e:a652 with SMTP id ffacd0b85a97d-386453fd87bmr3808247f8f.56.1733849335564; Tue, 10 Dec 2024 08:48:55 -0800 (PST) Received: from lili ([148.60.59.223]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3863e655c1dsm6421922f8f.1.2024.12.10.08.48.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 08:48:55 -0800 (PST) From: Simon Tournier To: Ludovic =?utf-8?Q?Court=C3=A8s?= , 74654@debbugs.gnu.org Subject: Re: [bug#74654] [PATCH 2/5] packages: Optimize =?utf-8?Q?=E2=80=98all-packages=E2=80=99=2E?= In-Reply-To: <642880c208f4445f1d63dba5618a315671d558e2.1733158049.git.ludo@gnu.org> References: <642880c208f4445f1d63dba5618a315671d558e2.1733158049.git.ludo@gnu.org> Date: Tue, 10 Dec 2024 15:05:57 +0100 Message-ID: <878qsn1vlm.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74654 Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, On Mon, 02 Dec 2024 at 17:53, Ludovic Court=C3=A8s wrote: > - (delete-duplicates > - (fold-packages (lambda (package result) > - (match (package-replacement package) > - ((? package? replacement) > - (cons* replacement package result)) > - (#f > - (cons package result)))) > - '() > + ;; Note: 'fold-packages' never traverses the same package twice but > + ;; replacements break that (they may or may not be visible to > + ;; 'fold-packages'), hence this hash table to track visited packages. > + (define visited (make-hash-table)) >=20=20 > - ;; Dismiss deprecated packages but keep hidden packa= ges. > - #:select? (negate package-superseded)) > - eq?))) > + (fold-packages (lambda (package result) > + (if (hashq-ref visited package) > + result > + (begin > + (hashq-set! visited package #t) > + (match (package-replacement package) > + ((? package? replacement) > + (hashq-set! visited replacement #t) > + (cons* replacement package result)) > + (#f > + (cons package result)))))) > + '() > + > + ;; Dismiss deprecated packages but keep hidden packag= es. > + #:select? (negate package-superseded)))) Oh! This is a better implementation, indeed. :-) LGTM. Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 12 18:07:01 2024 Received: (at 74654) by debbugs.gnu.org; 12 Dec 2024 23:07:01 +0000 Received: from localhost ([127.0.0.1]:40807 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tLsGk-000769-Gm for submit@debbugs.gnu.org; Thu, 12 Dec 2024 18:07:01 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38466) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tLsGd-000753-Ig for 74654@debbugs.gnu.org; Thu, 12 Dec 2024 18:06:52 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tLsGX-0002rB-Nr for 74654@debbugs.gnu.org; Thu, 12 Dec 2024 18:06:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=wUknAIAuWPWTj20UEw4gAQHpFX58QWSNue4566cv8GU=; b=OFFWoI8qalvFX/NOcW3X asWLgeOdb4r0M1tjyo7jK0QSqjx0W0f8Vkf63bbLLruJI8/jHFQ7QhrXzQgHUGl7J420DQwej0/SP b+IazSaHRYrmmRav1FMeSiJzb71Czmxl8zlxR4D/7OSyk/xzWoRn7QD23rlt/ZOeqnvE6gtJoEafm PA5qhlg6dkvQS7vTYyX2rRYCQs6/0+wvQECdfN297zLyvymvIYf9YV86jqm7YbGHkKUuI4poA1LTk PoN6x4KIbZnVWGj30tZa3h3+hdUaH1p978X8DwArmzSvuaC1OfxW2rf6zEPyLeYPDu8K5NpMob9dz HKo1TVaIgtM4lw==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: 74654@debbugs.gnu.org Subject: Re: [bug#74654] [PATCH 0/5] Optimize 'all-packages'; add ungrafting manifest In-Reply-To: ("Ludovic =?utf-8?Q?Court?= =?utf-8?Q?=C3=A8s=22's?= message of "Mon, 2 Dec 2024 17:51:53 +0100") References: Date: Fri, 13 Dec 2024 00:06:36 +0100 Message-ID: <8734is5wn7.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74654 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Ludovic Court=C3=A8s skribis: > etc: Move manifests to a separate directory. > packages: Optimize =E2=80=98all-packages=E2=80=99. > build-system/cargo: Simplify =E2=80=98crate-closure=E2=80=99. > guix build: Last argument of =E2=80=98dependents=E2=80=99 is optional. > maint: Add ungrafting manifest. Pushed as 5e2daf4b10cdbb7b5b3a7b1a49b0dfdba4346748. Ludo'. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 12 18:08:30 2024 Received: (at 74654) by debbugs.gnu.org; 12 Dec 2024 23:08:30 +0000 Received: from localhost ([127.0.0.1]:40812 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tLsIH-0007AH-Iy for submit@debbugs.gnu.org; Thu, 12 Dec 2024 18:08:30 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51912) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tLsIF-0007A4-I7 for 74654@debbugs.gnu.org; Thu, 12 Dec 2024 18:08:27 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tLsIA-0002ye-Bz for 74654@debbugs.gnu.org; Thu, 12 Dec 2024 18:08:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=yS415XEYFq8Zb/qE7N4Lc8PCaONakuptZpX9LZcKTLA=; b=owlit9f1rGQCstQrTpm1 LUbHoBszlq6kF4L/EPJt1WTzdB6gTr4nvgfNCsu0b9iPU0ySLVdUN/Nl1udhyn3XtzxWVJsLHrg3I VeOE2X1lAwGuy3A989vt2+DYSxHQBaO19UliI2ugBAB3K1/SdKbY2otV2l4U5zYiDRHadvGWGkOOA 1+d+rAZ2mKzSlx/SfyBbV7HaI4OfKq4LIqZxriu28woiLTsKQC2JLSVdwPYaAiBozFI0EQgPziLNI EsMOsSPctUD9kB0Bk7Yo+MbfiFoivNiLsKiXCdmo3qBcZT6Rqp9wP40+fTb5akv9UlVbQrav3+lE8 9v7WIkyCY6vlDA==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: 74654@debbugs.gnu.org Subject: Re: [bug#74654] [PATCH 0/5] Optimize 'all-packages'; add ungrafting manifest In-Reply-To: ("Ludovic =?utf-8?Q?Court?= =?utf-8?Q?=C3=A8s=22's?= message of "Mon, 2 Dec 2024 17:51:53 +0100") References: Date: Fri, 13 Dec 2024 00:08:20 +0100 Message-ID: <87y10k4hzv.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74654 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Ludovic Court=C3=A8s skribis: > =E2=80=A2 Adding an =E2=80=9Cungrafting=E2=80=9D package that rebuilds = everything > without grafts, just like what we=E2=80=99d do manually. > > The goal is to have that ungrafting manifest under CI, such > that anytime the corresponding jobset is green, we can ungraft > everything with the guarantee that binaries are available. I=E2=80=99ve set up a jobset, currently building for i686-linux and x86_64-= linux only: https://ci.guix.gnu.org/jobset/ungrafting Evaluation is still in progress right now. There are no pending builds for these architectures (but 100k builds for aarch64-linux=E2=80=A6). Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 13 18:24:29 2024 Received: (at 74654) by debbugs.gnu.org; 13 Dec 2024 23:24:29 +0000 Received: from localhost ([127.0.0.1]:44683 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tMF1J-0002h5-At for submit@debbugs.gnu.org; Fri, 13 Dec 2024 18:24:29 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54058) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tMF1H-0002gl-LC for 74654@debbugs.gnu.org; Fri, 13 Dec 2024 18:24:28 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tMF1C-00010l-F1 for 74654@debbugs.gnu.org; Fri, 13 Dec 2024 18:24:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=F0XDf675o5BOwcAz7gVYYn0mq0URGoPFLUdp77C/Lq4=; b=a1jnNgotJ5Axu5lRgh/8 DIyTeKGCH2uU3aDUtyknDRoLr9cPOJ3FKjf08x/x7gtC5rv1VT3mnr6R8HlzuodFozD8Cj90Yiqyh 2TUuQD1NOyYmkJ/gzza96VKYXsjmVI/VnGRxFJlzs+79jwmR1K8pQm02jYXJsbxNU/BZFeQOfCYZC tczCv6vX6yenGORkDYQixt3Q6b8fI2UmOoGDtlfJ6KPt4Cp8fHeykCbKNF+BsPJj7PRDg3/TRnbCB r1xG8+KeNYgb4Io/2/O/VOgzjJT3vompmBgmbtXRFgrfb0tvITY1/CXS6+AvuFXuIqKi4Fys4nMAD j7ZhK+orTD9gLA==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: 74654@debbugs.gnu.org Subject: Re: [bug#74654] [PATCH 0/5] Optimize 'all-packages'; add ungrafting manifest In-Reply-To: <87y10k4hzv.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Fri, 13 Dec 2024 00:08:20 +0100") References: <87y10k4hzv.fsf@gnu.org> Date: Sat, 14 Dec 2024 00:24:20 +0100 Message-ID: <878qsjp3ob.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74654 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Ludovic Court=C3=A8s skribis: > I=E2=80=99ve set up a jobset, currently building for i686-linux and x86_6= 4-linux > only: > > https://ci.guix.gnu.org/jobset/ungrafting > > Evaluation is still in progress right now. There are no pending builds > for these architectures (but 100k builds for aarch64-linux=E2=80=A6). So far it=E2=80=99s a failure, first because of a mistake in how =E2=80=9Ct= otal ungrafting=E2=80=9D is computed in the manifest (I=E2=80=99ll propose a fix= soon), but more importantly because of references to grafted packages in places other than package inputs, specifically in =E2=80=98rust-ring-0.16-sources= =E2=80=99 & co.: these references escape package rewriting, and thus the computational ungrafting process doesn=E2=80=99t yield the same result as manually ungrafting the source. To be continued=E2=80=A6 (I=E2=80=99ve disabled the jobset for now.) Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 15 11:27:08 2024 Received: (at control) by debbugs.gnu.org; 15 Dec 2024 16:27:08 +0000 Received: from localhost ([127.0.0.1]:51736 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tMrSV-0006Si-5U for submit@debbugs.gnu.org; Sun, 15 Dec 2024 11:27:07 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45996) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tMrSS-0006Ri-W3 for control@debbugs.gnu.org; Sun, 15 Dec 2024 11:27:05 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tMrSN-0006Zq-Q0 for control@debbugs.gnu.org; Sun, 15 Dec 2024 11:26:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:Subject:From:To:Date:in-reply-to: references; bh=9/eXE9OcUoli6duF8i4o0mipGMbIuUkNYverQJh5vzs=; b=TQebTPJe7rjsu1 FZkC1pqgBfZ0oF31M6llQSQt0IkN4wS4V+OfuYIvIxhRiRSVtoUi3uY9sq9SGiGqistj9gSPzZL+q qt9S3eBB89QlFKA98w7MMkL8juSeSqjx0lisL9Pl/oHby2Spe1Fae7E7THLIR0Xa6p6GNOXOzGGrx r45SSGxfIDOeeCo4Jg415UxoxGnMfKHV+6nPZy+MOfkumUDGS+pZJxd8ft/Jply6JCwI+GV2rCE+K PcM2L+K/t/VTKaaYOQFM6exrYqcenaKFxcFr+zSadBqcna+i5m/6wAgCgQRdmeHw6KXEQc53nwJDM JC3n4ilTuRRqaWJvE2SQ==; Date: Sun, 15 Dec 2024 17:26:58 +0100 Message-Id: <87r068j4j1.fsf@gnu.org> To: control@debbugs.gnu.org From: =?utf-8?Q?Ludovic_Court=C3=A8s?= Subject: control message for bug #74654 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 74654 quit From unknown Fri Jun 20 07:26:56 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 13 Jan 2025 12:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator