GNU bug report logs - #74639
[PATCH v2] gnu: make-gitolite: Fix inputs references

Previous Next

Full log

Message #8 received at 74639 <at> debbugs.gnu.org (full text, mbox):

From: Hilton Chain <hako <at> ultrarare.space>
To: Ashish SHUKLA <ashish.is <at> lostca.se>
Cc: 74639 <at> debbugs.gnu.org
Subject: Re: [bug#74639] [PATCH] gnu: make-gitolite: Fix inputs references
Date: Mon, 02 Dec 2024 08:31:10 +0800

Hi Ashish,

On Mon, 02 Dec 2024 07:15:07 +0800,
ashish.is--- via Guix-patches via wrote:
>
> From: Ashish SHUKLA <ashish.is <at> lostca.se>
>
> * gnu/packages/version-control.scm (make-gitolite)[arguments]<phases>
> {patch-scripts,patch-source,wrap-scripts}: Update functions to reference
> inputs from the inputs alist, instead of hardcoding.

The commit message format we use doesn't have this ("{...}") level I think?  You
can use "[#:phases]<...>" here instead.

> Change-Id: Ia2468235b43c257ee1816d19325671d373ed2870
> ---
> Hi,
>
> When trying to override inputs of "gitolite", I noticed it's hardcoding them
> instead of referencing the "inputs" alist parameter which is passed to the
> phases, which makes overriding the inputs useless. This patches fixes that
> behaviour.
>
> Thanks!
>
>  gnu/packages/version-control.scm | 28 ++++++++++++++--------------
>  1 file changed, 14 insertions(+), 14 deletions(-)

Please avoid operating on input labels directly when possible, in this case you
can use ‘search-input-file’.

Thanks

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.