From unknown Tue Aug 19 10:01:40 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#74637 <74637@debbugs.gnu.org> To: bug#74637 <74637@debbugs.gnu.org> Subject: Status: [PATCH] Make view-read-only behave like view-file Reply-To: bug#74637 <74637@debbugs.gnu.org> Date: Tue, 19 Aug 2025 17:01:40 +0000 retitle 74637 [PATCH] Make view-read-only behave like view-file reassign 74637 emacs submitter 74637 Bj=C3=B6rn Bidar severity 74637 normal tag 74637 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 01 15:40:44 2024 Received: (at submit) by debbugs.gnu.org; 1 Dec 2024 20:40:44 +0000 Received: from localhost ([127.0.0.1]:53202 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHqkF-0007NV-JU for submit@debbugs.gnu.org; Sun, 01 Dec 2024 15:40:44 -0500 Received: from lists.gnu.org ([209.51.188.17]:56178) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHqkA-0007NH-Kw for submit@debbugs.gnu.org; Sun, 01 Dec 2024 15:40:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tHqk9-0006ns-HT for bug-gnu-emacs@gnu.org; Sun, 01 Dec 2024 15:40:38 -0500 Received: from thaodan.de ([2a03:4000:4f:f15::1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tHqk7-0007Ys-A6 for bug-gnu-emacs@gnu.org; Sun, 01 Dec 2024 15:40:37 -0500 Received: from odin (dsl-trebng12-50dc7b-49.dhcp.inet.fi [80.220.123.49]) by thaodan.de (Postfix) with ESMTPSA id 144DBD00043 for ; Sun, 1 Dec 2024 22:40:18 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thaodan.de; s=mail; t=1733085618; bh=kN6Y8bXzm4HKR6wvt2EXr1dj194rGHcGAMURPCIoIO4=; h=From:To:Subject:Date; b=o93K5qAKkySFWdcfGB7+rgWsy2QQ8CwN9uvp+ixPn8ii/szYPEUllOeM9Ki/kxzON +ZXa2hnPrdh5gmBt8k7/V/5y4UGs/XQdb5Ve2EVLLnEwOnFmJbDnmMQrGvnPLNZpDg yL1F+Q53XBwu5cdQ0p5aH2y15FpXMNsFTSI92sXve9uvA9k4ncyr3u540oe08pPRuX d2IVNUwlH3H+mHh1BId7H25KyVIaYVdGJ6O+7e0n+/t+u/wnMdsiKXllXF5elrCfNL g00L/oq8Q2xz04vofbLyKwD9JWFMCoSslF0HF5OC6jjWk+b1mzZbulfvJyLmKh+tiM EBhZjbO9nI4vIMyVyyM1E6s2ZmT2qEJVdObcjhOIY0FsLa6Tp++PIvlLtFoZ7l3CaT VxKIYwt/JV7BOQCMj5OwISggudOQagnif1H5iVNIPyTXckqNdMLGCrd1rFvHLPrqvE p5rTx3bDLbPmVcrETqzCTLL34XVcAgq6xi801lAhtl4M6aC8B1XMmpz0u8gEbLx8CG o1wYZM3aRColm2vbfIMLK5PM2YZGayExs+gBun5dZVZtxiz198uTVNtEmOeJedvwIu OyONqwEOzebND/ZIoV1An2/IqSO43ePMokuGefRDulf9F68IHujsfb+2yim7Jbq4KN 0zAbtj3ZDfgeVh0Chvv5NJQE= From: =?utf-8?Q?Bj=C3=B6rn?= Bidar To: bug-gnu-emacs@gnu.org Subject: [PATCH] Make view-read-only behave like view-file X-Debbugs-Cc: Autocrypt: addr=bjorn.bidar@thaodan.de; prefer-encrypt=nopreference; keydata= mDMEZNfpPhYJKwYBBAHaRw8BAQdACBEmr+0xwIIHZfIDlZmm7sa+lHHSb0g9FZrN6qE6ru60JUJq w7ZybiBCaWRhciA8Ympvcm4uYmlkYXJAdGhhb2Rhbi5kZT6IlgQTFgoAPgIbAwULCQgHAgIiAgYV CgkICwIEFgIDAQIeBwIXgBYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1/YmAhkBAAoJEFwbdKFl HF9oB9cBAJoIIGQKXm4cpap+Flxc/EGnYl0123lcEyzuduqvlDT0AQC3OlFKm/OiqJ8IMTrzJRZ8 phFssTkSrrFXnM2jm5PYDoiTBBMWCgA7FiEEUfF263VHMB6nKairXBt0oWUcX2gFAmTX6T4CGwMF CwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQXBt0oWUcX2hbCQEAtru7kvM8hi8zo6z9ux2h K+B5xViKuo7Z8K3IXuK5ugwA+wUfKzomzdBPhfxDsqLcEziGRxoyx0Q3ld9aermBUccHtBxCasO2 cm4gQmlkYXIgPG1lQHRoYW9kYW4uZGU+iJMEExYKADsCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwEC HgcCF4AWIQRR8XbrdUcwHqcpqKtcG3ShZRxfaAUCZNf2FQAKCRBcG3ShZRxfaCzSAP4hZ7cSp0YN XYpcjHdsySh2MuBhhoPeLGXs+2kSiqBiOwD/TP8AgPEg/R+SI9GI9on7fBJJ0mp2IT8kZ2rhDOjg gA6IkwQTFgoAOxYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1+ntAhsDBQsJCAcCAiICBhUKCQgL AgQWAgMBAh4HAheAAAoJEFwbdKFlHF9oBgwA/iQHwe0VL4Df4GGTYlNjMSHFlIkBmN4UfYGLYj3E TrOUAQC51M+M3cjsL8WHdpBz6VAo6df9d+rVwhQ9vQuFHqevArg4BGTX6T4SCisGAQQBl1UBBQEB B0Cbohc3JEfn005/cm0AOGjSsW1ZxAkgaoVNjbpqk4MgNAMBCAeIeAQYFgoAIBYhBFHxdut1RzAe pymoq1wbdKFlHF9oBQJk1+k+AhsMAAoJEFwbdKFlHF9ooHABAKGmrGBic/Vys3BBrOQiRB3Z7izO HwhqTRpAqFZtXS2nAQDZhp/5aYw1TZjTzkm1KVt9QiYnjd/MvxRE9iaY6x4mDbgzBGTX6T4WCSsG AQQB2kcPAQEHQAgRJq/tMcCCB2XyA5WZpu7GvpRx0m9IPRWazeqhOq7uiO8EGBYKACAWIQRR8Xbr dUcwHqcpqKtcG3ShZRxfaAUCZNf71AIbIgCBCRBcG3ShZRxfaHYgBBkWCgAdFiEEUfF263VHMB6n KairXBt0oWUcX2gFAmTX+9QACgkQXBt0oWUcX2jeSwD6AtWn0cuo8IF35YRo4o3cDRJnUfJnbvJy GxyCDThR+zYBAKG6/jdwmZkBQZKslnDAbMMd2WfiZZT5JW3IWC4EaKMO7HkBAKYPGZ3UbfkRvfFK S+pQ9CgtNfkSJQBtT1Ob7Y6nsacgAQCpyXN7yppmhW/oBgivITPy9Lkg+V4NK9WZYZCU9Q7LBA== Date: Sun, 01 Dec 2024 22:40:16 +0200 Message-ID: <87ldwzm91r.fsf@> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a03:4000:4f:f15::1; envelope-from=bjorn.bidar@thaodan.de; helo=thaodan.de X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, INVALID_MSGID=0.568, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.2 (-) --=-=-= Content-Type: text/plain Tags: patch Make view-mode behave like when called in view-file when entered because `view-read-only' is true on a file which is not writable. The change makes the view-read-only behave better on files which are not writable. Now it makes Emacs behave more like less on these files. In GNU Emacs 31.0.50 (build 1, x86_64-suse-linux-gnu, GTK+ Version 3.24.43, cairo version 1.18.2) Repository revision: eee0ed8442aa78320a3e578ab290df145fb49624 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101014 System Description: openSUSE Tumbleweed Configured using: 'configure --disable-build-details --without-pop --with-mailutils --without-hesiod --with-gameuser=:games --with-kerberos --with-kerberos5 --with-file-notification=inotify --with-modules --enable-autodepend --enable-link-time-optimization --prefix=/usr --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --localstatedir=/var --sharedstatedir=/var/lib --libexecdir=/usr/libexec --with-file-notification=yes --libdir=/usr/lib64 --with-native-compilation=aot --enable-locallisppath=/usr/share/emacs/31.0.50/site-lisp:/usr/share/emacs/site-lisp --with-x --with-xim --with-sound --with-xpm --with-jpeg --with-tiff --with-gif --with-png --with-rsvg --with-dbus --with-xft --without-gpm --with-tree-sitter --with-x-toolkit=gtk --without-pgtk --with-toolkit-scroll-bars --x-includes=/usr/include --x-libraries=/usr/lib64 --with-libotf --with-m17n-flt --with-cairo --build=x86_64-suse-linux --with-dumping=pdumper build_alias=x86_64-suse-linux 'CC=sccache cc' 'CFLAGS=-O2 -Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -march=znver3 -mmmx -mpopcnt -msse -msse2 -msse3 -mssse3 -msse4.1 -msse4.2 -mavx -mavx2 -msse4a -mno-fma4 -mno-xop -mfma -mbmi -mbmi2 -maes -mpclmul -mno-gfni -mvpclmulqdq -mno-3dnow -madx -mabm -mno-cldemote -mclflushopt -mclwb -mclzero -mcx16 -mno-enqcmd -mf16c -mfsgsbase -mfxsr -mno-hle -msahf -mno-lwp -mlzcnt -mmovbe -mno-movdir64b -mno-movdiri -mmwaitx -mno-pconfig -mpku -mprfchw -mno-ptwrite -mrdpid -mrdrnd -mrdseed -mno-rtm -mno-serialize -mno-sgx -msha -mshstk -mno-tbm -mno-tsxldtrk -mvaes -mno-waitpkg -mwbnoinvd -mxsave -mxsavec -mxsaveopt -mxsaves -mno-amx-tile -mno-amx-int8 -mno-amx-bf16 -mno-uintr -mno-hreset -mno-kl -mno-widekl -mno-avxvnni -mno-avxifma -mno-avxvnniint8 -mno-avxneconvert -mno-cmpccxadd -mno-amx-fp16 -mno-prefetchi -mno-raoint -mno-amx-complex --param l1-cache-size=32 --param l1-cache-line-size=64 --param l2-cache-size=512 -mtune=znver3 -fno-optimize-sibling-calls -O2 -Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -g -D_GNU_SOURCE -DGDK_DISABLE_DEPRECATION_WARNINGS -DGLIB_DISABLE_DEPRECATION_WARNINGS -pipe -Wno-pointer-sign -Wno-unused-variable -Wno-unused-label -DPDMP_BASE='\''"emacs-gtk"'\''' LDFLAGS=-Wl,-O2 'CXX=sccache c++' PKG_CONFIG_PATH=:/usr/lib64/pkgconfig:/usr/share/pkgconfig' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Make-view-read-only-behave-like-view-file.patch >From d77d0880871061820b1cdf61f1d74f2a7e5224aa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rn=20Bidar?= Date: Sun, 1 Dec 2024 22:22:24 +0200 Subject: [PATCH] Make view-read-only behave like view-file Make view-mode also behave like less when entered through the view-read-only option similarly as done in in '1997-06-14 "Make view mode more similar to `less'' (ab7782fc244). * lisp/files.el (after-find-file): When opening a file which is read only and `view-read-only' is true leave view-mode with `kill-buffer-if-not-modified'. * lisp/view.el (view-mode): Document new behavior. --- lisp/files.el | 2 +- lisp/view.el | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lisp/files.el b/lisp/files.el index a65bc4a4ea2..2f062b45daf 100644 --- a/lisp/files.el +++ b/lisp/files.el @@ -2874,7 +2874,7 @@ after-find-file (when (and buffer-read-only view-read-only (not (eq (get major-mode 'mode-class) 'special))) - (view-mode-enter)) + (view-mode-enter nil 'kill-buffer-if-not-modified)) (run-hooks 'find-file-hook))) (define-obsolete-function-alias 'report-errors 'with-demoted-errors "25.1") diff --git a/lisp/view.el b/lisp/view.el index 2ac7479739f..422d8a1f537 100644 --- a/lisp/view.el +++ b/lisp/view.el @@ -416,7 +416,7 @@ view-mode The effect of \\[View-leave], \\[View-quit] and \\[View-kill-and-leave] depends on how view-mode was entered. If it was entered by view-file, view-file-other-window, view-file-other-frame, or \\[dired-view-file] \(\\[view-file], \\[view-file-other-window], -\\[view-file-other-frame], or the Dired mode v command), +\\[view-file-other-frame], `view-read-only', or the Dired mode v command), then \\[View-quit] will try to kill the current buffer. If view-mode was entered from another buffer, by \\[view-buffer], \\[view-buffer-other-window], \\[view-buffer-other frame], \\[view-file], -- 2.45.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 02 07:29:36 2024 Received: (at 74637) by debbugs.gnu.org; 2 Dec 2024 12:29:36 +0000 Received: from localhost ([127.0.0.1]:54575 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tI5YV-0005E6-RR for submit@debbugs.gnu.org; Mon, 02 Dec 2024 07:29:36 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46438) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tI5YU-0005Do-8v for 74637@debbugs.gnu.org; Mon, 02 Dec 2024 07:29:34 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tI5YN-0005Gk-8J; Mon, 02 Dec 2024 07:29:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=WoOUbUI5/HKIEQsB3bpIyvNto8VWPhdpK5oaK77I070=; b=q2p98fr4XOkmWd0PH4GN IMm0w7MvuXm1M9D1Olrdjjj+3jFT6X8+PUpLm174wTg35p2GaU2qRrGZtQGPuArhASNbVJG8n7gQ/ fzLWKQWnaY6eaNEPQjtBm1MAdt1gwDro42k1z5OPFBxKqMdJFIlasDTp4JBuHdMCHx3L2AktQg7OO HiDsr+W/nSofqnlBWiN2xNGk5Yn8p0qZAx/H/xrRmAccxfP4jIlsxw6QkXDLhHl2Jyb2XJh++OtN2 fm6rrGgq3o/BZN1E0t2iLAN2a+kFuFTvP0bTU5vQRnUUrYueEUeTFDtGeaV/NELhSqM9JhLIlSBjI BK4z7jMW6hb2Ng==; Date: Mon, 02 Dec 2024 14:29:22 +0200 Message-Id: <86ldwy46al.fsf@gnu.org> From: Eli Zaretskii To: =?iso-8859-1?Q?Bj=F6rn?= Bidar In-Reply-To: <87ldwzm91r.fsf@> (bug-gnu-emacs@gnu.org) Subject: Re: bug#74637: [PATCH] Make view-read-only behave like view-file References: <87ldwzm91r.fsf@> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74637 Cc: 74637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 01 Dec 2024 22:40:16 +0200 > From: Bjrn Bidar via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > Make view-mode behave like when called in view-file when entered because > `view-read-only' is true on a file which is not writable. > The change makes the view-read-only behave better on files which are > not writable. > Now it makes Emacs behave more like less on these files. That's an incompatible behavior change. Is that justified? How can we be sure that everyone agrees with your interpretation of this mode? From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 02 13:08:54 2024 Received: (at 74637) by debbugs.gnu.org; 2 Dec 2024 18:08:54 +0000 Received: from localhost ([127.0.0.1]:56486 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tIAqr-00079w-SP for submit@debbugs.gnu.org; Mon, 02 Dec 2024 13:08:54 -0500 Received: from thaodan.de ([185.216.177.71]:40814) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tIAqo-00079l-Rx for 74637@debbugs.gnu.org; Mon, 02 Dec 2024 13:08:52 -0500 Received: from odin (dsl-trebng12-50dc7b-49.dhcp.inet.fi [80.220.123.49]) by thaodan.de (Postfix) with ESMTPSA id 1E44DD00045; Mon, 2 Dec 2024 20:08:48 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thaodan.de; s=mail; t=1733162928; bh=lp+SD5DNGVOZb++cjTSzAdGIsmTgz+wJ72OnA89sFgs=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=tC3QcCyFVqWWwU4JWTO0lqL+6Jlp/ScIyHFWO+LlZtw9v1saICPVQgHFJmZK4OZ0v RdXnCzc4hHKW1snwiD/LzkwH04khi1yptOsxW1DbfzjjlW06ypekA7Khio/Y5q36CX AkCBX0YP5vMIN4OBXonY8qbmY+hiwbvPs8nF+FsgAWIHuTGpSWCwFKioY4mZBDtIoC YxWQufjpPryQ0s/BTCSFHQWf9R6iU55A30JT01elK8ZSObk/N5SAl9rzxH+F5JjatO H8xrTwECXs3TIQ+2TVBMHg6UAl3GG8e1aq6V9SZwGwYPMcDhH08pa/FydB9XQvk73r AJ4q7klEiQ/kzHSYoQtNrl5H7UhS6HKbyUq0cjgrv8+v0NmoTbJfQqDVFBIt8qtMQT jrq4KfyphFMNzMD25EEtZcYcves3KG14/Xl2S/wK0VSO08AD2S1aY71YMKhZj9yWuP S8S7n72mSzcquWTHrB6OOOPaTyr1HkXHsGIeqGM7/K2z2fxfDJhiOMriO3pCbM9Z36 /OIJug2olKEvtMq2XOZwT02X+38fsbLW6pnhAZ0q/t0Vj60nYAb1ZCRpSA7wao0nZ5 +Q03fgvAxhxdLXXRy3xV1X9e7yfXqMdFiCs4FUMgY3UvxHQfIUJHx+DofPmFPlHoEY ckKQMOgLHiIElZjKWN6caMug= From: =?utf-8?Q?Bj=C3=B6rn?= Bidar To: Eli Zaretskii Subject: Re: bug#74637: [PATCH] Make view-read-only behave like view-file In-Reply-To: <86ldwy46al.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 02 Dec 2024 14:29:22 +0200") References: <86ldwy46al.fsf@gnu.org> Autocrypt: addr=bjorn.bidar@thaodan.de; prefer-encrypt=nopreference; keydata= mDMEZNfpPhYJKwYBBAHaRw8BAQdACBEmr+0xwIIHZfIDlZmm7sa+lHHSb0g9FZrN6qE6ru60JUJq w7ZybiBCaWRhciA8Ympvcm4uYmlkYXJAdGhhb2Rhbi5kZT6IlgQTFgoAPgIbAwULCQgHAgIiAgYV CgkICwIEFgIDAQIeBwIXgBYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1/YmAhkBAAoJEFwbdKFl HF9oB9cBAJoIIGQKXm4cpap+Flxc/EGnYl0123lcEyzuduqvlDT0AQC3OlFKm/OiqJ8IMTrzJRZ8 phFssTkSrrFXnM2jm5PYDoiTBBMWCgA7FiEEUfF263VHMB6nKairXBt0oWUcX2gFAmTX6T4CGwMF CwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQXBt0oWUcX2hbCQEAtru7kvM8hi8zo6z9ux2h K+B5xViKuo7Z8K3IXuK5ugwA+wUfKzomzdBPhfxDsqLcEziGRxoyx0Q3ld9aermBUccHtBxCasO2 cm4gQmlkYXIgPG1lQHRoYW9kYW4uZGU+iJMEExYKADsCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwEC HgcCF4AWIQRR8XbrdUcwHqcpqKtcG3ShZRxfaAUCZNf2FQAKCRBcG3ShZRxfaCzSAP4hZ7cSp0YN XYpcjHdsySh2MuBhhoPeLGXs+2kSiqBiOwD/TP8AgPEg/R+SI9GI9on7fBJJ0mp2IT8kZ2rhDOjg gA6IkwQTFgoAOxYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1+ntAhsDBQsJCAcCAiICBhUKCQgL AgQWAgMBAh4HAheAAAoJEFwbdKFlHF9oBgwA/iQHwe0VL4Df4GGTYlNjMSHFlIkBmN4UfYGLYj3E TrOUAQC51M+M3cjsL8WHdpBz6VAo6df9d+rVwhQ9vQuFHqevArg4BGTX6T4SCisGAQQBl1UBBQEB B0Cbohc3JEfn005/cm0AOGjSsW1ZxAkgaoVNjbpqk4MgNAMBCAeIeAQYFgoAIBYhBFHxdut1RzAe pymoq1wbdKFlHF9oBQJk1+k+AhsMAAoJEFwbdKFlHF9ooHABAKGmrGBic/Vys3BBrOQiRB3Z7izO HwhqTRpAqFZtXS2nAQDZhp/5aYw1TZjTzkm1KVt9QiYnjd/MvxRE9iaY6x4mDbgzBGTX6T4WCSsG AQQB2kcPAQEHQAgRJq/tMcCCB2XyA5WZpu7GvpRx0m9IPRWazeqhOq7uiO8EGBYKACAWIQRR8Xbr dUcwHqcpqKtcG3ShZRxfaAUCZNf71AIbIgCBCRBcG3ShZRxfaHYgBBkWCgAdFiEEUfF263VHMB6n KairXBt0oWUcX2gFAmTX+9QACgkQXBt0oWUcX2jeSwD6AtWn0cuo8IF35YRo4o3cDRJnUfJnbvJy GxyCDThR+zYBAKG6/jdwmZkBQZKslnDAbMMd2WfiZZT5JW3IWC4EaKMO7HkBAKYPGZ3UbfkRvfFK S+pQ9CgtNfkSJQBtT1Ob7Y6nsacgAQCpyXN7yppmhW/oBgivITPy9Lkg+V4NK9WZYZCU9Q7LBA== Date: Mon, 02 Dec 2024 20:08:46 +0200 Message-ID: <87ttbmj6tt.fsf@> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Eli Zaretskii writes: >> Date: Sun, 01 Dec 2024 22:40:16 +0200 >> From: Björn Bidar via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> Make view-mode behave like when ca [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [185.216.177.71 listed in bl.score.senderscore.com] 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [185.216.177.71 listed in sa-trusted.bondedsender.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 1.2 INVALID_MSGID Message-Id is not valid, according to RFC 2822 X-Debbugs-Envelope-To: 74637 Cc: 74637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) Eli Zaretskii writes: >> Date: Sun, 01 Dec 2024 22:40:16 +0200 >> From: Bj=C3=B6rn Bidar via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >>=20 >> Make view-mode behave like when called in view-file when entered because >> `view-read-only' is true on a file which is not writable. >> The change makes the view-read-only behave better on files which are >> not writable.=20 >> Now it makes Emacs behave more like less on these files. > > That's an incompatible behavior change. Is that justified? How can > we be sure that everyone agrees with your interpretation of this mode? All other view-file like modes behave like this, you view the file and leave the file with q. But even going with that point: You open a file file which isn't writable. Once you hit q the window is quit and the buffer is buried. What do you do now next time you visit that file? The buffer was buried, view-mode isn't active anymore, you would have to activate view-mode again to go where you left off. If you would want to edit the file the you visited this way you would have not pressed q but e to exit view mode and the proceeded to exit read-only-mode and edit the file. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 02 14:33:22 2024 Received: (at 74637) by debbugs.gnu.org; 2 Dec 2024 19:33:22 +0000 Received: from localhost ([127.0.0.1]:56631 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tICAb-0003CQ-On for submit@debbugs.gnu.org; Mon, 02 Dec 2024 14:33:22 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43906) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tICAY-0003CA-MP for 74637@debbugs.gnu.org; Mon, 02 Dec 2024 14:33:20 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tICAT-0003h9-0F; Mon, 02 Dec 2024 14:33:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=2IbHhPWndtBOt6/3vw16wy+jh5WwD9fuj5Zje157yAI=; b=UqJahSh/fefbbeyebEfW GLtPmyXFQh+Ztk4L3MibndZDxQuNluTv6+QE+OYpLjFssOPjual9LNPY6mzbejtGDgsKoxeDEB5pp Z4nZHBDUXerIMDtemovaYdOLAJ3dFN34tfq9HhczB92OqPeqoag18F/xQ6BsjgAPE3pN6bDj3iGKz 4ou2wB5iM3ib9ji4G+A6z7lDIy3lQYzLLQdXR3dgrrUuHsDB7A1/wzLAJqzhfjIGv0dJ32RQ8QwU0 BFYAKYokT0Evij+PFn27XYnNc6VYzatzKD68JYSg3CRfBt/atdRua/XX/peob1dElReig3+b6b44n y8VqIZnRj76kuw==; Date: Mon, 02 Dec 2024 21:33:08 +0200 Message-Id: <86o71t3mob.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?Q?Bj=C3=B6rn?= Bidar In-Reply-To: <87ttbmj6tt.fsf@> (message from =?utf-8?Q?Bj=C3=B6rn?= Bidar on Mon, 02 Dec 2024 20:08:46 +0200) Subject: Re: bug#74637: [PATCH] Make view-read-only behave like view-file References: <86ldwy46al.fsf@gnu.org> <87ttbmj6tt.fsf@> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74637 Cc: 74637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Björn Bidar > Cc: 74637@debbugs.gnu.org > Date: Mon, 02 Dec 2024 20:08:46 +0200 > > Eli Zaretskii writes: > > >> Date: Sun, 01 Dec 2024 22:40:16 +0200 > >> From: Björn Bidar via "Bug reports for GNU Emacs, > >> the Swiss army knife of text editors" > >> > >> Make view-mode behave like when called in view-file when entered because > >> `view-read-only' is true on a file which is not writable. > >> The change makes the view-read-only behave better on files which are > >> not writable. > >> Now it makes Emacs behave more like less on these files. > > > > That's an incompatible behavior change. Is that justified? How can > > we be sure that everyone agrees with your interpretation of this mode? > > All other view-file like modes behave like this, you view the file and > leave the file with q. That doesn't change the fact that view-mode didn't behave like that, until now. > But even going with that point: You open a file file which isn't > writable. Once you hit q the window is quit and the buffer is buried. > What do you do now next time you visit that file? > The buffer was buried, view-mode isn't active anymore, you would have > to activate view-mode again to go where you left off. > > If you would want to edit the file the you visited this way you would > have not pressed q but e to exit view mode and the proceeded to exit > read-only-mode and edit the file. What about entering view-mode by typing "C-x C-q" in a buffer whose file is writable? Why should we kill the buffer when the user turns off view-mode in that file's buffer? From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 03 05:06:45 2024 Received: (at 74637) by debbugs.gnu.org; 3 Dec 2024 10:06:46 +0000 Received: from localhost ([127.0.0.1]:58355 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tIPnp-0004zt-Cu for submit@debbugs.gnu.org; Tue, 03 Dec 2024 05:06:45 -0500 Received: from thaodan.de ([185.216.177.71]:39968) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tIPnn-0004zf-SS for 74637@debbugs.gnu.org; Tue, 03 Dec 2024 05:06:44 -0500 Received: from odin (dsl-trebng12-50dc7b-49.dhcp.inet.fi [80.220.123.49]) by thaodan.de (Postfix) with ESMTPSA id C54E7D0002E; Tue, 3 Dec 2024 12:06:12 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thaodan.de; s=mail; t=1733220373; bh=jHH9W4vpwyiQuvJNMluPk4ca6cFnkHqTCvoejw9DHPE=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=bhYUTIJXvmXzrtDwssycQ4lRQ5Snbs0psbtGmR+9PO2TCVrrCw3yR5M9uFvY1+Lqi riKr155YA3qIB1uqdtOKwQ7pKSWcBl9wK3l/eR8C2Qigto2oNpDhODDcmXuXbACIVG p+axCRaGgp44Xj68I4uHt3x+7R/6tFZtZfrnF5piesmN3Gx2M+t/R8SBx41K5ZIkFH m2EqDfupV9lPGFmmBAiFjhVLwIUbBeawxOPf25psCEEk4EkO3YR6Us9pAr95qZhJXE 7l92qwdY0I9IaDjDTXgfNumWmvsz7+9R8hdVg1x6xVDkkjJTEf68U/bhiZisQlrz7n GwkyT9aOoRKxpHdi93Y7iYAmG8qBghniTQytqcPdOEdsOn7K20OINHNfQPRL27G0Vy ppQQ9CiLBPwj+3lyzYxjNHHEQsrgux+L4+7QmLC+riTVrOjCeT3+heehqKtzNBFiSq edb54NZKI+2wBagjJSXL3fnqn+FY2/8flKWlVIMHUEsUFBwbhGA2lD64yKOBdUktkC S7XuCg2m2Yn1wQsl8tqPy72JIfuyq+2RqCJIA4Vr/znlmQoCgOkHVb0qxpx+kc/l1l RLHSA2MKbKkNjyQ3ui5ygPECFT3XYIqlBA6By/JNNQ1tiF4asuzRck69bbUH6fYf1m naaM6LEVVra78s47aZaKHR5g= From: =?utf-8?Q?Bj=C3=B6rn?= Bidar To: Eli Zaretskii Subject: Re: bug#74637: [PATCH] Make view-read-only behave like view-file In-Reply-To: <86o71t3mob.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 02 Dec 2024 21:33:08 +0200") References: <86ldwy46al.fsf@gnu.org> <86o71t3mob.fsf@gnu.org> Autocrypt: addr=bjorn.bidar@thaodan.de; prefer-encrypt=nopreference; keydata= mDMEZNfpPhYJKwYBBAHaRw8BAQdACBEmr+0xwIIHZfIDlZmm7sa+lHHSb0g9FZrN6qE6ru60JUJq w7ZybiBCaWRhciA8Ympvcm4uYmlkYXJAdGhhb2Rhbi5kZT6IlgQTFgoAPgIbAwULCQgHAgIiAgYV CgkICwIEFgIDAQIeBwIXgBYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1/YmAhkBAAoJEFwbdKFl HF9oB9cBAJoIIGQKXm4cpap+Flxc/EGnYl0123lcEyzuduqvlDT0AQC3OlFKm/OiqJ8IMTrzJRZ8 phFssTkSrrFXnM2jm5PYDoiTBBMWCgA7FiEEUfF263VHMB6nKairXBt0oWUcX2gFAmTX6T4CGwMF CwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQXBt0oWUcX2hbCQEAtru7kvM8hi8zo6z9ux2h K+B5xViKuo7Z8K3IXuK5ugwA+wUfKzomzdBPhfxDsqLcEziGRxoyx0Q3ld9aermBUccHtBxCasO2 cm4gQmlkYXIgPG1lQHRoYW9kYW4uZGU+iJMEExYKADsCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwEC HgcCF4AWIQRR8XbrdUcwHqcpqKtcG3ShZRxfaAUCZNf2FQAKCRBcG3ShZRxfaCzSAP4hZ7cSp0YN XYpcjHdsySh2MuBhhoPeLGXs+2kSiqBiOwD/TP8AgPEg/R+SI9GI9on7fBJJ0mp2IT8kZ2rhDOjg gA6IkwQTFgoAOxYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1+ntAhsDBQsJCAcCAiICBhUKCQgL AgQWAgMBAh4HAheAAAoJEFwbdKFlHF9oBgwA/iQHwe0VL4Df4GGTYlNjMSHFlIkBmN4UfYGLYj3E TrOUAQC51M+M3cjsL8WHdpBz6VAo6df9d+rVwhQ9vQuFHqevArg4BGTX6T4SCisGAQQBl1UBBQEB B0Cbohc3JEfn005/cm0AOGjSsW1ZxAkgaoVNjbpqk4MgNAMBCAeIeAQYFgoAIBYhBFHxdut1RzAe pymoq1wbdKFlHF9oBQJk1+k+AhsMAAoJEFwbdKFlHF9ooHABAKGmrGBic/Vys3BBrOQiRB3Z7izO HwhqTRpAqFZtXS2nAQDZhp/5aYw1TZjTzkm1KVt9QiYnjd/MvxRE9iaY6x4mDbgzBGTX6T4WCSsG AQQB2kcPAQEHQAgRJq/tMcCCB2XyA5WZpu7GvpRx0m9IPRWazeqhOq7uiO8EGBYKACAWIQRR8Xbr dUcwHqcpqKtcG3ShZRxfaAUCZNf71AIbIgCBCRBcG3ShZRxfaHYgBBkWCgAdFiEEUfF263VHMB6n KairXBt0oWUcX2gFAmTX+9QACgkQXBt0oWUcX2jeSwD6AtWn0cuo8IF35YRo4o3cDRJnUfJnbvJy GxyCDThR+zYBAKG6/jdwmZkBQZKslnDAbMMd2WfiZZT5JW3IWC4EaKMO7HkBAKYPGZ3UbfkRvfFK S+pQ9CgtNfkSJQBtT1Ob7Y6nsacgAQCpyXN7yppmhW/oBgivITPy9Lkg+V4NK9WZYZCU9Q7LBA== Date: Tue, 03 Dec 2024 12:06:11 +0200 Message-ID: <87mshdjd2k.fsf@> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Eli Zaretskii writes: >> From: Björn Bidar >> Cc: 74637@debbugs.gnu.org >> Date: Mon, 02 Dec 2024 20:08:46 +0200 >> >> Eli Zaretskii writes: >> >> >> Date: Sun, 01 Dec 2024 22:40:16 [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [185.216.177.71 listed in bl.score.senderscore.com] 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [185.216.177.71 listed in sa-trusted.bondedsender.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 1.2 INVALID_MSGID Message-Id is not valid, according to RFC 2822 X-Debbugs-Envelope-To: 74637 Cc: 74637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Eli Zaretskii writes: >> From: Bj=C3=B6rn Bidar >> Cc: 74637@debbugs.gnu.org >> Date: Mon, 02 Dec 2024 20:08:46 +0200 >>=20 >> Eli Zaretskii writes: >>=20 >> >> Date: Sun, 01 Dec 2024 22:40:16 +0200 >> >> From: Bj=C3=B6rn Bidar via "Bug reports for GNU Emacs, >> >> the Swiss army knife of text editors" >> >>=20 >> >> Make view-mode behave like when called in view-file when entered beca= use >> >> `view-read-only' is true on a file which is not writable. >> >> The change makes the view-read-only behave better on files which are >> >> not writable.=20 >> >> Now it makes Emacs behave more like less on these files. >> > >> > That's an incompatible behavior change. Is that justified? How can >> > we be sure that everyone agrees with your interpretation of this mode? >>=20 >> All other view-file like modes behave like this, you view the file and >> leave the file with q. > > That doesn't change the fact that view-mode didn't behave like that, > until now. View-mode isn't change outside of the specific situation of opening a file which isn't writable. I worded it wrong in the doc string. Please check the updated docstring or different wording. >> But even going with that point: You open a file file which isn't >> writable. Once you hit q the window is quit and the buffer is buried. >> What do you do now next time you visit that file? >> The buffer was buried, view-mode isn't active anymore, you would have >> to activate view-mode again to go where you left off. >>=20 >> If you would want to edit the file the you visited this way you would >> have not pressed q but e to exit view mode and the proceeded to exit >> read-only-mode and edit the file. > > What about entering view-mode by typing "C-x C-q" in a buffer whose > file is writable? Why should we kill the buffer when the user turns > off view-mode in that file's buffer? The change doesn't affect those situations. If you exit view-mode this way after having it activated through "C-x C-q" you would exit view-mode burry the buffer but not kill it. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Make-view-read-only-behave-like-view-file.patch >From 7e9dc995e07ce19022baccd5f54b7e9fecc4cadd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rn=20Bidar?= Date: Sun, 1 Dec 2024 22:22:24 +0200 Subject: [PATCH] Make view-read-only behave like view-file Make view-mode also behave like less when entered through the view-read-only option similarly as done in in '1997-06-14 "Make view mode more similar to `less'' (ab7782fc244). * lisp/files.el (after-find-file): When opening a file which is read only and `view-read-only' is true leave view-mode with `kill-buffer-if-not-modified'. * lisp/view.el (view-mode): Document new behavior. --- lisp/files.el | 2 +- lisp/view.el | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lisp/files.el b/lisp/files.el index a65bc4a4ea2..2f062b45daf 100644 --- a/lisp/files.el +++ b/lisp/files.el @@ -2874,7 +2874,7 @@ after-find-file (when (and buffer-read-only view-read-only (not (eq (get major-mode 'mode-class) 'special))) - (view-mode-enter)) + (view-mode-enter nil 'kill-buffer-if-not-modified)) (run-hooks 'find-file-hook))) (define-obsolete-function-alias 'report-errors 'with-demoted-errors "25.1") diff --git a/lisp/view.el b/lisp/view.el index 2ac7479739f..e2d77a53695 100644 --- a/lisp/view.el +++ b/lisp/view.el @@ -416,7 +416,7 @@ view-mode The effect of \\[View-leave], \\[View-quit] and \\[View-kill-and-leave] depends on how view-mode was entered. If it was entered by view-file, view-file-other-window, view-file-other-frame, or \\[dired-view-file] \(\\[view-file], \\[view-file-other-window], -\\[view-file-other-frame], or the Dired mode v command), +\\[view-file-other-frame], `view-read-only' on a read-only file, or the Dired mode v command), then \\[View-quit] will try to kill the current buffer. If view-mode was entered from another buffer, by \\[view-buffer], \\[view-buffer-other-window], \\[view-buffer-other frame], \\[view-file], -- 2.45.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 03 09:03:58 2024 Received: (at 74637) by debbugs.gnu.org; 3 Dec 2024 14:03:58 +0000 Received: from localhost ([127.0.0.1]:58761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tITVN-00088g-W3 for submit@debbugs.gnu.org; Tue, 03 Dec 2024 09:03:58 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36690) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tITVI-00088J-LW for 74637@debbugs.gnu.org; Tue, 03 Dec 2024 09:03:55 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tITT4-0004H1-Pg; Tue, 03 Dec 2024 09:01:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=cgsji8Z48hrluzwOAQX2lAOMrkFRkvbJ1anDmB65pBk=; b=LhDVAC5rL3UQ9ewejOl8 hUyoKJ3RYNh2CEgcHk2KeLoDGM8i6T2fDs7gHgN+pujsucx4B6aJNeF9/HwloNE0msB2Ix7vuscsB BqsHITke1v19OjR96xIDtoMJFtrp7r7HYqELnoZuSpOXSxKrC9rt4zO3NbVVHO0Bvavf4YZUuSgsK NjNOvDdcXVL/TdYdkmQFW08sJEVAz5O20mJEyetUlbDIGoD3RZymOmOeBlUVH9+fxNP2wiRQbxWCK ODmGZHsXQBYrax12VkrsdS3n0zbKBFX36T7NJllQtr5O8GIPvNyDHYTKs1GSy9CmXKq/X8/f9KNzI HIYv08+kstna0w==; Date: Tue, 03 Dec 2024 16:01:10 +0200 Message-Id: <86zflc27dl.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?Q?Bj=C3=B6rn?= Bidar , Stefan Kangas , Andrea Corallo In-Reply-To: <87mshdjd2k.fsf@> (message from =?utf-8?Q?Bj=C3=B6rn?= Bidar on Tue, 03 Dec 2024 12:06:11 +0200) Subject: Re: bug#74637: [PATCH] Make view-read-only behave like view-file References: <86ldwy46al.fsf@gnu.org> <86o71t3mob.fsf@gnu.org> <87mshdjd2k.fsf@> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74637 Cc: 74637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Björn Bidar > Cc: 74637@debbugs.gnu.org > Date: Tue, 03 Dec 2024 12:06:11 +0200 > > >> > That's an incompatible behavior change. Is that justified? How can > >> > we be sure that everyone agrees with your interpretation of this mode? > >> > >> All other view-file like modes behave like this, you view the file and > >> leave the file with q. > > > > That doesn't change the fact that view-mode didn't behave like that, > > until now. > > View-mode isn't change outside of the specific situation of opening a > file which isn't writable. It's still a significant change. Killing a buffer is not a minor think, and restoring it is not always easy, or even possible (e.g., the file could have been deleted in the meantime). My opinion is that if we install this, we need to provide some way of getting the previous behavior back, for those who may want it. Stefan and Andrea, WDYT? From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 03 09:26:14 2024 Received: (at 74637) by debbugs.gnu.org; 3 Dec 2024 14:26:14 +0000 Received: from localhost ([127.0.0.1]:58822 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tITqv-0000zi-9T for submit@debbugs.gnu.org; Tue, 03 Dec 2024 09:26:13 -0500 Received: from mail-pg1-f196.google.com ([209.85.215.196]:54750) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tITqs-0000zY-Kd for 74637@debbugs.gnu.org; Tue, 03 Dec 2024 09:26:11 -0500 Received: by mail-pg1-f196.google.com with SMTP id 41be03b00d2f7-7ee11ff7210so3867260a12.1 for <74637@debbugs.gnu.org>; Tue, 03 Dec 2024 06:26:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733235910; x=1733840710; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=D0u7zXMhHg162xazOJc8QbFVZkbxO0yB+m9xhjTZQsg=; b=CpaOsdHA4RvWM54H4uGNFnlK42oc71EK7m7KXr7ilSRFG60uGfz7bU8XJfEfwWCWHn 9GlyKBB2SlyVPkocOKHSXZzX+ZUVrDWen1ZgvS5/j7JRauLIP9XxRHoAX3k0zSMdu4+A gvgBHn4vuxk4zpdKBe8w/51dH89PDYpXkiM+meuGhxQcCZVMWRzHzdetYxBsMMCQk3lN cr6mdhVxAKmVpwhNAHhv+j3Xm8oyxfNUHCuDG+tJawSV14Y2g7uQBtZxl5qndfdAttYI 8GeJl1NvVN2UqIvB5UBM/LwYgu662uu89+Kn3Y3Wf6kcZoQZ9caE8CvPX4BL6YiMmgE5 Mv9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733235910; x=1733840710; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=D0u7zXMhHg162xazOJc8QbFVZkbxO0yB+m9xhjTZQsg=; b=p4AH+AQXz6AbUFqH1Pju41AfaHtagzSy3/la4PvM22xfd1WQPKY6fAyN2bvWEsfK1S S9WSu43pLqe33rAG0KzKafWDP5TbXvAqGmgRfoUY4z40GuStKXpNluv7BvQf3l2w8HLG E0+HAAHhL4wAyUKQ+LqIHU81lPPTYBtwfbmsHRG/m4QSj4POWHekqojs3XL1ntY3cvvS usEHarbGPZgklIscbb1yvc0QA6o4QrX2YeTmfos5xxlwUEKK2iJkP58TqWK+G5y1woyC hbRyKYfBe6zEMzqXywR0W1XDXVqoePMcjxS+O/pffCr+KDL23FJCW4V4pZF5LUk76YUX kgMg== X-Forwarded-Encrypted: i=1; AJvYcCWjspnHvieA2kw4wJsziFAw0dwVx54pseb5v0DdHKP0mMNka7UqMgvm8SQIPQGBP8CQWWeRHg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyQcB0QY4tLrCl51rx1tlupErMXtt7Az5hy4sOOyMC06cLni096 5GsuuaNf19a4i8HfzDxXfu9Ol39SO4ewmMDZ7XL9l1YVJ7KQnsIM X-Gm-Gg: ASbGncsnn8FF1OXH2W/T3hh0bazgiylDxiuHVvw+Srw10VCAjTR6tI+zLru3wckSJdt hi40g+cjLMPLNN36QublqYIR1g55cfmfXdoTVA4tQYrbdTYx5iU7p9F9fTY/r0JSjY4blxKRV0T opxmUBE+4p68QYSXGn4uEefun5oq2gtk35qSe6F/xbvebmSAuH1KB6gCw+DFgKXRGYqu7fS5kpG uudGJ9Ay4aqviJQueJN10XY7SRFRweDunqTREfJSOv/20OZsBI= X-Google-Smtp-Source: AGHT+IER2YKJAv9Xdp/4yNO86Li6D2OzjSiPH5TgyKwrAf/ZqYKQzAXnnZvGqHJSuFMoX+ryh04vPQ== X-Received: by 2002:a05:6a20:3d81:b0:1e0:f05b:e72a with SMTP id adf61e73a8af0-1e1653d0dabmr3863060637.27.1733235909658; Tue, 03 Dec 2024 06:25:09 -0800 (PST) Received: from localhost ([1.7.159.70]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7254176fe28sm10489810b3a.72.2024.12.03.06.25.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Dec 2024 06:25:09 -0800 (PST) From: Visuwesh To: Eli Zaretskii Subject: Re: bug#74637: [PATCH] Make view-read-only behave like view-file In-Reply-To: <86zflc27dl.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 03 Dec 2024 16:01:10 +0200") References: <86ldwy46al.fsf@gnu.org> <86o71t3mob.fsf@gnu.org> <86zflc27dl.fsf@gnu.org> Date: Tue, 03 Dec 2024 19:55:04 +0530 Message-ID: <87ldwwoncv.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74637 Cc: =?utf-8?Q?Bj=C3=B6rn?= Bidar , Andrea Corallo , 74637@debbugs.gnu.org, Stefan Kangas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) [=E0=AE=9A=E0=AF=86=E0=AE=B5=E0=AF=8D=E0=AE=B5=E0=AE=BE=E0=AE=AF=E0=AF=8D = =E0=AE=9F=E0=AE=BF=E0=AE=9A=E0=AE=AE=E0=AF=8D=E0=AE=AA=E0=AE=B0=E0=AF=8D 03= , 2024] Eli Zaretskii wrote: >> From: Bj=C3=B6rn Bidar >> Cc: 74637@debbugs.gnu.org >> Date: Tue, 03 Dec 2024 12:06:11 +0200 >>=20 >> >> > That's an incompatible behavior change. Is that justified? How can >> >> > we be sure that everyone agrees with your interpretation of this mo= de? >> >>=20 >> >> All other view-file like modes behave like this, you view the file and >> >> leave the file with q. >> > >> > That doesn't change the fact that view-mode didn't behave like that, >> > until now. >>=20 >> View-mode isn't change outside of the specific situation of opening a >> file which isn't writable. > > It's still a significant change. Killing a buffer is not a minor > think, and restoring it is not always easy, or even possible (e.g., > the file could have been deleted in the meantime). > > My opinion is that if we install this, we need to provide some way of > getting the previous behavior back, for those who may want it. > > Stefan and Andrea, WDYT? I am neither Stefan nor Andrea: there have been a number of instances where Emacs not eagerly killing buffers has saved accidentally or prematurely deleted files on my end. I would be opposed to a change that kills the buffer on exiting view-mode entered due to view-read-only=3Dt to avoid potential data loss. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 03 14:33:36 2024 Received: (at 74637) by debbugs.gnu.org; 3 Dec 2024 19:33:36 +0000 Received: from localhost ([127.0.0.1]:32980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tIYeN-0007sZ-I9 for submit@debbugs.gnu.org; Tue, 03 Dec 2024 14:33:35 -0500 Received: from thaodan.de ([185.216.177.71]:55240) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tIYeK-0007sK-Ob for 74637@debbugs.gnu.org; Tue, 03 Dec 2024 14:33:33 -0500 Received: from odin (dsl-trebng12-50dc7b-49.dhcp.inet.fi [80.220.123.49]) by thaodan.de (Postfix) with ESMTPSA id EE878D0004F; Tue, 3 Dec 2024 21:33:30 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thaodan.de; s=mail; t=1733254411; bh=KRuXSUQUiOZC4HB2e9MxIqhZdCyVj8dNzKPbqXO3Vso=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=EeYFOlkV9g1nE9P57L/HXuiB97NSD/qMfvFfIf7aYsGqEl0Ex1fmVUbpGSqOd/xcm juxg9t1TrAQD6IGaZam2cV50+3GGRtfzuqvDf0gCv8aJEKw23NTYwQtFHvT3YgSo9l D8njnXzwnGPBqXGt26ppKe+bYLabQB76kfbqGdLhjgjAAEOL6L8eGKh1HxdkhZqSMN nQrQeoKnBAKzn57qJf93CsSR3jCw2quqHME4JhDclMvlczWanMCRO389RfmalnrpZh UPdvVhOu/0YKAeKALn0/NugYGOmk80hGI3Wc17YOq6kN1DEO+j4F0MjAVbLw9AZuQW oQ6XtX24l6ig1lBwrwxUxDhMUST/pd+an01n8qSbCPKYhofYGaWNVN9jDTvn2Nj84D pIq3BMu5DcgPFzrhoFqCUhUI64ImZbUhqKk0c2d4yMoLn2IqSR7Xs5AjytX9kP9Say DI3DtCKVG0EyaSOhOxEQPl0ZgPNk4xumLZzfPaw+gYYm5Z8dVPNt/pH7zn6rRFuuu6 im/Zst/NSKo8YHLwxMFuPfZl6ELcmtK1PM65PfPBq+nCPK7GYiQoxH/Zz2BVl9xGwr fDBQN6dwB46pp6Df1GnZrxoOTaeX2nGugEEutejInLTQ7IfcJomFlryAJGJygWt2vR f4yfnYkvNcXjmHck4TlRrRqU= From: =?utf-8?Q?Bj=C3=B6rn?= Bidar To: Visuwesh Subject: Re: bug#74637: [PATCH] Make view-read-only behave like view-file In-Reply-To: <87ldwwoncv.fsf@gmail.com> (Visuwesh's message of "Tue, 03 Dec 2024 19:55:04 +0530") References: <86ldwy46al.fsf@gnu.org> <86o71t3mob.fsf@gnu.org> <86zflc27dl.fsf@gnu.org> <87ldwwoncv.fsf@gmail.com> Autocrypt: addr=bjorn.bidar@thaodan.de; prefer-encrypt=nopreference; keydata= mDMEZNfpPhYJKwYBBAHaRw8BAQdACBEmr+0xwIIHZfIDlZmm7sa+lHHSb0g9FZrN6qE6ru60JUJq w7ZybiBCaWRhciA8Ympvcm4uYmlkYXJAdGhhb2Rhbi5kZT6IlgQTFgoAPgIbAwULCQgHAgIiAgYV CgkICwIEFgIDAQIeBwIXgBYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1/YmAhkBAAoJEFwbdKFl HF9oB9cBAJoIIGQKXm4cpap+Flxc/EGnYl0123lcEyzuduqvlDT0AQC3OlFKm/OiqJ8IMTrzJRZ8 phFssTkSrrFXnM2jm5PYDoiTBBMWCgA7FiEEUfF263VHMB6nKairXBt0oWUcX2gFAmTX6T4CGwMF CwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQXBt0oWUcX2hbCQEAtru7kvM8hi8zo6z9ux2h K+B5xViKuo7Z8K3IXuK5ugwA+wUfKzomzdBPhfxDsqLcEziGRxoyx0Q3ld9aermBUccHtBxCasO2 cm4gQmlkYXIgPG1lQHRoYW9kYW4uZGU+iJMEExYKADsCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwEC HgcCF4AWIQRR8XbrdUcwHqcpqKtcG3ShZRxfaAUCZNf2FQAKCRBcG3ShZRxfaCzSAP4hZ7cSp0YN XYpcjHdsySh2MuBhhoPeLGXs+2kSiqBiOwD/TP8AgPEg/R+SI9GI9on7fBJJ0mp2IT8kZ2rhDOjg gA6IkwQTFgoAOxYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1+ntAhsDBQsJCAcCAiICBhUKCQgL AgQWAgMBAh4HAheAAAoJEFwbdKFlHF9oBgwA/iQHwe0VL4Df4GGTYlNjMSHFlIkBmN4UfYGLYj3E TrOUAQC51M+M3cjsL8WHdpBz6VAo6df9d+rVwhQ9vQuFHqevArg4BGTX6T4SCisGAQQBl1UBBQEB B0Cbohc3JEfn005/cm0AOGjSsW1ZxAkgaoVNjbpqk4MgNAMBCAeIeAQYFgoAIBYhBFHxdut1RzAe pymoq1wbdKFlHF9oBQJk1+k+AhsMAAoJEFwbdKFlHF9ooHABAKGmrGBic/Vys3BBrOQiRB3Z7izO HwhqTRpAqFZtXS2nAQDZhp/5aYw1TZjTzkm1KVt9QiYnjd/MvxRE9iaY6x4mDbgzBGTX6T4WCSsG AQQB2kcPAQEHQAgRJq/tMcCCB2XyA5WZpu7GvpRx0m9IPRWazeqhOq7uiO8EGBYKACAWIQRR8Xbr dUcwHqcpqKtcG3ShZRxfaAUCZNf71AIbIgCBCRBcG3ShZRxfaHYgBBkWCgAdFiEEUfF263VHMB6n KairXBt0oWUcX2gFAmTX+9QACgkQXBt0oWUcX2jeSwD6AtWn0cuo8IF35YRo4o3cDRJnUfJnbvJy GxyCDThR+zYBAKG6/jdwmZkBQZKslnDAbMMd2WfiZZT5JW3IWC4EaKMO7HkBAKYPGZ3UbfkRvfFK S+pQ9CgtNfkSJQBtT1Ob7Y6nsacgAQCpyXN7yppmhW/oBgivITPy9Lkg+V4NK9WZYZCU9Q7LBA== Date: Tue, 03 Dec 2024 21:33:29 +0200 Message-ID: <878qswimt2.fsf@> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Visuwesh writes: > [செவ்வாய் டிசம்பர் 03, 2024] Eli Zaretskii wrote: > >>> From: Björn Bidar >>> Cc: 74637@debbugs.gnu.org >>> Date: Tue, 03 Dec 2024 12:06:11 [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [185.216.177.71 listed in sa-accredit.habeas.com] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [185.216.177.71 listed in bl.score.senderscore.com] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 1.2 INVALID_MSGID Message-Id is not valid, according to RFC 2822 X-Debbugs-Envelope-To: 74637 Cc: Eli Zaretskii , Andrea Corallo , 74637@debbugs.gnu.org, Stefan Kangas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) Visuwesh writes: > [=E0=AE=9A=E0=AF=86=E0=AE=B5=E0=AF=8D=E0=AE=B5=E0=AE=BE=E0=AE=AF=E0=AF=8D= =E0=AE=9F=E0=AE=BF=E0=AE=9A=E0=AE=AE=E0=AF=8D=E0=AE=AA=E0=AE=B0=E0=AF=8D 0= 3, 2024] Eli Zaretskii wrote: > >>> From: Bj=C3=B6rn Bidar >>> Cc: 74637@debbugs.gnu.org >>> Date: Tue, 03 Dec 2024 12:06:11 +0200 >>>=20 >>> >> > That's an incompatible behavior change. Is that justified? How c= an >>> >> > we be sure that everyone agrees with your interpretation of this m= ode? >>> >>=20 >>> >> All other view-file like modes behave like this, you view the file a= nd >>> >> leave the file with q. >>> > >>> > That doesn't change the fact that view-mode didn't behave like that, >>> > until now. >>>=20 >>> View-mode isn't change outside of the specific situation of opening a >>> file which isn't writable. >> >> It's still a significant change. Killing a buffer is not a minor >> think, and restoring it is not always easy, or even possible (e.g., >> the file could have been deleted in the meantime). >> >> My opinion is that if we install this, we need to provide some way of >> getting the previous behavior back, for those who may want it. >> >> Stefan and Andrea, WDYT? > > I am neither Stefan nor Andrea: there have been a number of instances > where Emacs not eagerly killing buffers has saved accidentally or > prematurely deleted files on my end. I would be opposed to a change > that kills the buffer on exiting view-mode entered due to > view-read-only=3Dt to avoid potential data loss. But does apply to instance of view-read-only? Again it only affects files which are not writable, i.e. those that could not be deleted by the user in the first place. The change is for not writable files plus view-read-only, NOT files which are visited and then view-mode activated through `view-mode` or view-read-only through read-only-mode. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 03 14:39:03 2024 Received: (at 74637) by debbugs.gnu.org; 3 Dec 2024 19:39:04 +0000 Received: from localhost ([127.0.0.1]:32992 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tIYjf-00088I-I3 for submit@debbugs.gnu.org; Tue, 03 Dec 2024 14:39:03 -0500 Received: from thaodan.de ([185.216.177.71]:60576) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tIYjd-00087t-Sm for 74637@debbugs.gnu.org; Tue, 03 Dec 2024 14:39:03 -0500 Received: from odin (dsl-trebng12-50dc7b-49.dhcp.inet.fi [80.220.123.49]) by thaodan.de (Postfix) with ESMTPSA id E6759D0004F; Tue, 3 Dec 2024 21:39:00 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thaodan.de; s=mail; t=1733254741; bh=rQUdwzaYzfj+0UQ+hbkioq55C8VtW+S1Ei33PPSAQws=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=22LHYD1FALVfcPaHT0fcfRpuS5jL8JuJ0tj9Vl0QVP54YN+8BzqCxL7zCv/H1in1b oIjdCGoQ72hDbhgYrCIYFUg4hoXtp2Advcq9VOD1wrTo+xZr2eZiGUdo/Z3KdldjOK h34WUY6N+2tgdmoKxpwAMCz0jsmDsYoav2oKP3OaJ2/7Oxhg2AH6pbH8l4pEHH0IdW fy+IA6Megjd9M+98FVOJdlN3ATlGf18Xok2p6Yb9z5nzkU++kv02PIO9aFUGJpQfwo Y5wuSuN38vdIFB5zDD9hNSp4/ujsPZU8N2tBUxPD6lLFgT87lOqO7KG9C+uN4l0e3l EBC8/N49IDsX6ZRY1hQc/6a34v5dx4e6kPlf5SiCvcuaibs5ur3iYeHN9Hlv33PmqN BZCvW68sNXhRXAr0JeaM27XQD5vBCISJ1Wi2NdpkA/9SaQuZ3XG+TO43RE4Ubr3HSw uPdnzzqZ035pRPQUheya+As/igeF9b6UisMg+Z71Ak+eFmlxe0pMn2GiS8diXoYvqI KevP97GcwMTu7ojfPzDNvg0HkYhVj6hI92Bjf7FfzY23RWgzhd2wsuwiyJaT1eg390 Mzu2RJaqtS/Kem6rTJbBDTM6X3osnUEE3lbrF/svM+QyXZYjWQhLkmmLbSaFlgfz3u i8b7ErTw3QnM3dQoiYiHn2ME= From: =?utf-8?Q?Bj=C3=B6rn?= Bidar To: Eli Zaretskii Subject: Re: bug#74637: [PATCH] Make view-read-only behave like view-file In-Reply-To: <86zflc27dl.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 03 Dec 2024 16:01:10 +0200") References: <86ldwy46al.fsf@gnu.org> <86o71t3mob.fsf@gnu.org> <86zflc27dl.fsf@gnu.org> Autocrypt: addr=bjorn.bidar@thaodan.de; prefer-encrypt=nopreference; keydata= mDMEZNfpPhYJKwYBBAHaRw8BAQdACBEmr+0xwIIHZfIDlZmm7sa+lHHSb0g9FZrN6qE6ru60JUJq w7ZybiBCaWRhciA8Ympvcm4uYmlkYXJAdGhhb2Rhbi5kZT6IlgQTFgoAPgIbAwULCQgHAgIiAgYV CgkICwIEFgIDAQIeBwIXgBYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1/YmAhkBAAoJEFwbdKFl HF9oB9cBAJoIIGQKXm4cpap+Flxc/EGnYl0123lcEyzuduqvlDT0AQC3OlFKm/OiqJ8IMTrzJRZ8 phFssTkSrrFXnM2jm5PYDoiTBBMWCgA7FiEEUfF263VHMB6nKairXBt0oWUcX2gFAmTX6T4CGwMF CwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQXBt0oWUcX2hbCQEAtru7kvM8hi8zo6z9ux2h K+B5xViKuo7Z8K3IXuK5ugwA+wUfKzomzdBPhfxDsqLcEziGRxoyx0Q3ld9aermBUccHtBxCasO2 cm4gQmlkYXIgPG1lQHRoYW9kYW4uZGU+iJMEExYKADsCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwEC HgcCF4AWIQRR8XbrdUcwHqcpqKtcG3ShZRxfaAUCZNf2FQAKCRBcG3ShZRxfaCzSAP4hZ7cSp0YN XYpcjHdsySh2MuBhhoPeLGXs+2kSiqBiOwD/TP8AgPEg/R+SI9GI9on7fBJJ0mp2IT8kZ2rhDOjg gA6IkwQTFgoAOxYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1+ntAhsDBQsJCAcCAiICBhUKCQgL AgQWAgMBAh4HAheAAAoJEFwbdKFlHF9oBgwA/iQHwe0VL4Df4GGTYlNjMSHFlIkBmN4UfYGLYj3E TrOUAQC51M+M3cjsL8WHdpBz6VAo6df9d+rVwhQ9vQuFHqevArg4BGTX6T4SCisGAQQBl1UBBQEB B0Cbohc3JEfn005/cm0AOGjSsW1ZxAkgaoVNjbpqk4MgNAMBCAeIeAQYFgoAIBYhBFHxdut1RzAe pymoq1wbdKFlHF9oBQJk1+k+AhsMAAoJEFwbdKFlHF9ooHABAKGmrGBic/Vys3BBrOQiRB3Z7izO HwhqTRpAqFZtXS2nAQDZhp/5aYw1TZjTzkm1KVt9QiYnjd/MvxRE9iaY6x4mDbgzBGTX6T4WCSsG AQQB2kcPAQEHQAgRJq/tMcCCB2XyA5WZpu7GvpRx0m9IPRWazeqhOq7uiO8EGBYKACAWIQRR8Xbr dUcwHqcpqKtcG3ShZRxfaAUCZNf71AIbIgCBCRBcG3ShZRxfaHYgBBkWCgAdFiEEUfF263VHMB6n KairXBt0oWUcX2gFAmTX+9QACgkQXBt0oWUcX2jeSwD6AtWn0cuo8IF35YRo4o3cDRJnUfJnbvJy GxyCDThR+zYBAKG6/jdwmZkBQZKslnDAbMMd2WfiZZT5JW3IWC4EaKMO7HkBAKYPGZ3UbfkRvfFK S+pQ9CgtNfkSJQBtT1Ob7Y6nsacgAQCpyXN7yppmhW/oBgivITPy9Lkg+V4NK9WZYZCU9Q7LBA== Date: Tue, 03 Dec 2024 21:39:00 +0200 Message-ID: <874j3kimjv.fsf@> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Eli Zaretskii writes: >> From: Björn Bidar >> Cc: 74637@debbugs.gnu.org >> Date: Tue, 03 Dec 2024 12:06:11 +0200 >> >> >> > That's an incompatible behavior change. Is that justified? How can >> >> [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [185.216.177.71 listed in sa-accredit.habeas.com] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [185.216.177.71 listed in bl.score.senderscore.com] 1.2 INVALID_MSGID Message-Id is not valid, according to RFC 2822 X-Debbugs-Envelope-To: 74637 Cc: Andrea Corallo , 74637@debbugs.gnu.org, Stefan Kangas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) Eli Zaretskii writes: >> From: Bj=C3=B6rn Bidar >> Cc: 74637@debbugs.gnu.org >> Date: Tue, 03 Dec 2024 12:06:11 +0200 >>=20 >> >> > That's an incompatible behavior change. Is that justified? How can >> >> > we be sure that everyone agrees with your interpretation of this mo= de? >> >>=20 >> >> All other view-file like modes behave like this, you view the file and >> >> leave the file with q. >> > >> > That doesn't change the fact that view-mode didn't behave like that, >> > until now. >>=20 >> View-mode isn't change outside of the specific situation of opening a >> file which isn't writable. > > It's still a significant change. Killing a buffer is not a minor > think, and restoring it is not always easy, or even possible (e.g., > the file could have been deleted in the meantime). In such instances the files are usually those which are shared by other users or installed by the system administrator if the file was deleted it could have been only by the owner or those with the power to delete them. Files which the user owns wouldn't be affected. > My opinion is that if we install this, we need to provide some way of > getting the previous behavior back, for those who may want it. > Should this also affected files through the other instances where view-mode kills the buffer if not modified? In the instances affected by the patch view-read-only is more implicit e.g. when following a reference w= ith xref to a read-only file but view-file is still similar. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 03 14:43:27 2024 Received: (at 74637) by debbugs.gnu.org; 3 Dec 2024 19:43:27 +0000 Received: from localhost ([127.0.0.1]:33006 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tIYnu-0008Lu-LU for submit@debbugs.gnu.org; Tue, 03 Dec 2024 14:43:26 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58450) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tIYnr-0008Lb-IU for 74637@debbugs.gnu.org; Tue, 03 Dec 2024 14:43:25 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tIYnl-0005Kb-TH; Tue, 03 Dec 2024 14:43:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=iiP+DA30Nv/UbH3pVJw7a5zTl4A8VFen8OqlqbetU5s=; b=DZPNWxo77g5IbimshpQj JHLL+oSbUDUd+D1pQmdfKHr6gsQuAKK7zimXdn5mjyfpVr8f1aGNLYw9/JjpkFDQmHCzRz6s1lRDm mqNyMDPMklxECRDTawDWV+oYPgw/uYiZ+5i8OIWkJJs4YFQIGZYU5HMQaraXlGL5pzXd4k94FjmER oa1rhzD1U7Mo77jWauOMSGAh+ZPnJofx1MbkTIdddC9/ovNW5VNvTCHsWNFgLrhH/PkfEhjC+3ymg OFaJg3R3iSi+NfJC4NX5xkMWsdseYRbyBbuqtcnAzJHYg+RwatYpkmTbqrlymg0foqGdxuH2lKE2J 9/OVX6INPV7BEg==; Date: Tue, 03 Dec 2024 21:43:11 +0200 Message-Id: <86ed2o1rjk.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?Q?Bj=C3=B6rn?= Bidar In-Reply-To: <874j3kimjv.fsf@> (message from =?utf-8?Q?Bj=C3=B6rn?= Bidar on Tue, 03 Dec 2024 21:39:00 +0200) Subject: Re: bug#74637: [PATCH] Make view-read-only behave like view-file References: <86ldwy46al.fsf@gnu.org> <86o71t3mob.fsf@gnu.org> <86zflc27dl.fsf@gnu.org> <874j3kimjv.fsf@> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74637 Cc: acorallo@gnu.org, 74637@debbugs.gnu.org, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Björn Bidar > Cc: Stefan Kangas , Andrea Corallo > , 74637@debbugs.gnu.org > Date: Tue, 03 Dec 2024 21:39:00 +0200 > > Eli Zaretskii writes: > > > My opinion is that if we install this, we need to provide some way of > > getting the previous behavior back, for those who may want it. > > > > Should this also affected files through the other instances where > view-mode kills the buffer if not modified? It should affect those cases where this change modifies existing behavior. From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 04 08:16:42 2024 Received: (at 74637) by debbugs.gnu.org; 4 Dec 2024 13:16:42 +0000 Received: from localhost ([127.0.0.1]:34636 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tIpFB-0000lL-Pi for submit@debbugs.gnu.org; Wed, 04 Dec 2024 08:16:42 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44064) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tIpF9-0000kt-5v for 74637@debbugs.gnu.org; Wed, 04 Dec 2024 08:16:39 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tIpF2-0000zt-Uk; Wed, 04 Dec 2024 08:16:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=u1Bockyw6fqupSBRGySuCtYW3EJPYR3Ee8TEJ0m1dEo=; b=JxvZpfbKD3vz067p6oY7 Fomu4tptmUo8epEHscfwLgjxYNySkyk15p6+mI0qhzdo9smXOpD6ExAt4LCiMMftSrtMwC8GZDq/k 8fbJbP3yQG2qHo4AR+8z3ZQQesZm0fxvz4gmjN+fFTGKSDbm3PTcO3YY5CZXXILklqqMnAwaG+4Ca nFdD+uowK7Qy+JTqniiEk8g7pp2zURQ6WFntwXrU9MNxzCqyl3IOWpvoYlZ37JBfrNKnrarktMM8v Vm98JxZViWz6PQe1QZOSKJECe9GqmNmlx3wlbEnaMOuz7smbphoRlRUyXoYZi0TYeIJNj/67On20H 4+ntAhKD6n3GVw==; Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1tIpF2-0006aM-Bi; Wed, 04 Dec 2024 08:16:32 -0500 From: Andrea Corallo To: Eli Zaretskii Subject: Re: bug#74637: [PATCH] Make view-read-only behave like view-file In-Reply-To: <86zflc27dl.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 03 Dec 2024 16:01:10 +0200") References: <86ldwy46al.fsf@gnu.org> <86o71t3mob.fsf@gnu.org> <86zflc27dl.fsf@gnu.org> Date: Wed, 04 Dec 2024 08:16:32 -0500 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74637 Cc: =?utf-8?Q?Bj=C3=B6rn?= Bidar , 74637@debbugs.gnu.org, Stefan Kangas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: >> From: Bj=C3=B6rn Bidar >> Cc: 74637@debbugs.gnu.org >> Date: Tue, 03 Dec 2024 12:06:11 +0200 >>=20 >> >> > That's an incompatible behavior change. Is that justified? How can >> >> > we be sure that everyone agrees with your interpretation of this mo= de? >> >>=20 >> >> All other view-file like modes behave like this, you view the file and >> >> leave the file with q. >> > >> > That doesn't change the fact that view-mode didn't behave like that, >> > until now. >>=20 >> View-mode isn't change outside of the specific situation of opening a >> file which isn't writable. > > It's still a significant change. Killing a buffer is not a minor > think, and restoring it is not always easy, or even possible (e.g., > the file could have been deleted in the meantime). > > My opinion is that if we install this, we need to provide some way of > getting the previous behavior back, for those who may want it. > > Stefan and Andrea, WDYT? Agree with your position. From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 04 21:15:38 2024 Received: (at 74637) by debbugs.gnu.org; 5 Dec 2024 02:15:38 +0000 Received: from localhost ([127.0.0.1]:37531 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJ1P0-0006NE-27 for submit@debbugs.gnu.org; Wed, 04 Dec 2024 21:15:38 -0500 Received: from sendmail.purelymail.com ([34.202.193.197]:38268) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJ1Os-0006Mm-Lg for 74637@debbugs.gnu.org; Wed, 04 Dec 2024 21:15:35 -0500 DKIM-Signature: a=rsa-sha256; b=VhqdlToty24aQ6i1YuuQ146s3xrv6lVg6k64VmxtA0Pq3CQl/MvUWFqnwcFNkdfveltYNjlh8NZPQf8TAOi+hTEV3UqKw7gNw1OWIJgwIESO8j8LKhsWTPqs5mpg93N/zDUUacHfZ+XYNdK3b/gnFQtufK3S9aYqNrJwrzXAtfPkQcXdvkruhdqOJWtC1skWIrJnYmmWO62yQ6ukkU980G8X+aIZuIo14HDMcqn8o69+6gcwQk94tmTjMblV+1WtlCYqa90G6JXHyxZQsIONNy/jyvuvcWso57ga5/Mmvs7zzfV6zPLlPosnj9VLJsziPMMJorFKNvRPnq4YnOuRDw==; s=purelymail2; d=spwhitton.name; v=1; bh=iDuHFU6BbBE7QPOX9TU8j5dVYJjiTPj2JDjMwYjoQz8=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=buMsPEGH0oAROYE5pTC5X7Kt2zleirCdmfUDF4dO/DdOa4b69w08jigXXgEq4F61e3bobOFTdyXXb/WOFrpADs2Jr8eSDQpC4WFXe5AJgIw79Qz89JABWqjy2rYWZSoUjmTzMWbYCmvCyxLPlgqUNangkKcQ9WGTx7QTjG0r6MhNK9bcxuMe6pCKJ9bkpfxQDlBWsQUGrJiZZaMK/uJVcR55aK3IISSnqNbq063QlDglzJ9XX0UcfkeCsOk5KPZUqWSXbvqlRN82yOJ0irZfF306KrtUhAszgpwwxti6hIMLyQnnYUoovfq6GkYm7kWmbzS3GcqQx71cLP6fA/UHrw==; s=purelymail2; d=purelymail.com; v=1; bh=iDuHFU6BbBE7QPOX9TU8j5dVYJjiTPj2JDjMwYjoQz8=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 74637@debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 613574594; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Thu, 05 Dec 2024 02:15:23 +0000 (UTC) Received: by melete.silentflame.com (Postfix, from userid 1000) id F04377E627C; Thu, 5 Dec 2024 10:15:19 +0800 (CST) From: Sean Whitton To: Eli Zaretskii Subject: Re: bug#74637: [PATCH] Make view-read-only behave like view-file In-Reply-To: <87mshdjd2k.fsf@> (=?utf-8?Q?=22Bj=C3=B6rn?= Bidar via \"Bug reports for GNU Emacs, the Swiss army knife of text editors\""'s message of "Tue, 03 Dec 2024 12:06:11 +0200") References: <86ldwy46al.fsf@gnu.org> <86o71t3mob.fsf@gnu.org> Date: Thu, 05 Dec 2024 10:15:19 +0800 Message-ID: <875xnyq3ig.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74637 Cc: =?utf-8?Q?Bj=C3=B6rn?= Bidar , 74637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, I don't think Emacs should start killing buffers that it didn't used to kill by default. I also think that 'q' shouldn't generally kill buffers, only close windows and bury buffers. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 06 19:39:56 2024 Received: (at 74637) by debbugs.gnu.org; 7 Dec 2024 00:39:56 +0000 Received: from localhost ([127.0.0.1]:44733 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJirT-0000MF-Jk for submit@debbugs.gnu.org; Fri, 06 Dec 2024 19:39:55 -0500 Received: from thaodan.de ([185.216.177.71]:55564) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJirR-0000M3-3h for 74637@debbugs.gnu.org; Fri, 06 Dec 2024 19:39:54 -0500 Received: from odin (dsl-trebng12-50dc7b-49.dhcp.inet.fi [80.220.123.49]) by thaodan.de (Postfix) with ESMTPSA id 91FD2D0004B; Sat, 7 Dec 2024 02:39:21 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thaodan.de; s=mail; t=1733531961; bh=lXNKOoLT961YAvjE+xl+AzMvrv0fDYqDig0cfz2RFwo=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=YHVaJ604DCPE2/ECiSfEZAAd+eRI9+MmwEi2QdX87C8WveLU5b4QEEv6L4zQxjYB7 OyRPTHFb3VgP8U5FJiX5gijM3yf2vfBZ0lIKKIaiXoCfA9aaiu8nkKAqIaMs6DraZo 3v+BpzfgXIcpvSTgdsO5Aqq158GxrfvzsNbIpW62jiH2ST0Ab9rufu45BYXxZr8Xaw JWGFyIqUqw9kjcXOr8xdPzHCvLRTddJI1QxaXInjHiOV4ERbXWPPChGGS2BCF9C+Yw 576Ef3yZsKVBLH9q6yXTpy17m5+fZKQdRJKCM3hPX+mEqLLxDsFovpIDZZgnlIKAbg NAiz3YZeLACEY1DhvADPVK3k1H2LL/njdoh4+is6Q4D0Gc4UHaGfC2PPTlhIIH6XSN Jp1bdNkyWh0Yl11dTEyZ8Vlptxs8ZsBK5qSXb5YtonD/9Rbgc9PBbKvBGEnA75s9/U VKepAahkvJAZrK0jVCF2E4DzmoE7eP1JCgzHDF+vcjc9PVhaqlNFb2gRctOX5SiZ2b R92teBkYJ6cyPGjT9oxzjbSGSYVEDckw2Q/4pfLe75YhJFJQq+VLXmKcWIc29mhL97 6A8piUiWOFTWGsWgNie2YEuKy7j3zMhmJBLh303gAu0BON44RJm4a6A3XW6edsax6t 3TgBxI1e0dpbcKADxjinZKcE= From: =?utf-8?Q?Bj=C3=B6rn?= Bidar To: Andrea Corallo Subject: Re: bug#74637: [PATCH] Make view-read-only behave like view-file In-Reply-To: (Andrea Corallo's message of "Wed, 04 Dec 2024 08:16:32 -0500") References: <86ldwy46al.fsf@gnu.org> <86o71t3mob.fsf@gnu.org> <86zflc27dl.fsf@gnu.org> Autocrypt: addr=bjorn.bidar@thaodan.de; prefer-encrypt=nopreference; keydata= mDMEZNfpPhYJKwYBBAHaRw8BAQdACBEmr+0xwIIHZfIDlZmm7sa+lHHSb0g9FZrN6qE6ru60JUJq w7ZybiBCaWRhciA8Ympvcm4uYmlkYXJAdGhhb2Rhbi5kZT6IlgQTFgoAPgIbAwULCQgHAgIiAgYV CgkICwIEFgIDAQIeBwIXgBYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1/YmAhkBAAoJEFwbdKFl HF9oB9cBAJoIIGQKXm4cpap+Flxc/EGnYl0123lcEyzuduqvlDT0AQC3OlFKm/OiqJ8IMTrzJRZ8 phFssTkSrrFXnM2jm5PYDoiTBBMWCgA7FiEEUfF263VHMB6nKairXBt0oWUcX2gFAmTX6T4CGwMF CwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQXBt0oWUcX2hbCQEAtru7kvM8hi8zo6z9ux2h K+B5xViKuo7Z8K3IXuK5ugwA+wUfKzomzdBPhfxDsqLcEziGRxoyx0Q3ld9aermBUccHtBxCasO2 cm4gQmlkYXIgPG1lQHRoYW9kYW4uZGU+iJMEExYKADsCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwEC HgcCF4AWIQRR8XbrdUcwHqcpqKtcG3ShZRxfaAUCZNf2FQAKCRBcG3ShZRxfaCzSAP4hZ7cSp0YN XYpcjHdsySh2MuBhhoPeLGXs+2kSiqBiOwD/TP8AgPEg/R+SI9GI9on7fBJJ0mp2IT8kZ2rhDOjg gA6IkwQTFgoAOxYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1+ntAhsDBQsJCAcCAiICBhUKCQgL AgQWAgMBAh4HAheAAAoJEFwbdKFlHF9oBgwA/iQHwe0VL4Df4GGTYlNjMSHFlIkBmN4UfYGLYj3E TrOUAQC51M+M3cjsL8WHdpBz6VAo6df9d+rVwhQ9vQuFHqevArg4BGTX6T4SCisGAQQBl1UBBQEB B0Cbohc3JEfn005/cm0AOGjSsW1ZxAkgaoVNjbpqk4MgNAMBCAeIeAQYFgoAIBYhBFHxdut1RzAe pymoq1wbdKFlHF9oBQJk1+k+AhsMAAoJEFwbdKFlHF9ooHABAKGmrGBic/Vys3BBrOQiRB3Z7izO HwhqTRpAqFZtXS2nAQDZhp/5aYw1TZjTzkm1KVt9QiYnjd/MvxRE9iaY6x4mDbgzBGTX6T4WCSsG AQQB2kcPAQEHQAgRJq/tMcCCB2XyA5WZpu7GvpRx0m9IPRWazeqhOq7uiO8EGBYKACAWIQRR8Xbr dUcwHqcpqKtcG3ShZRxfaAUCZNf71AIbIgCBCRBcG3ShZRxfaHYgBBkWCgAdFiEEUfF263VHMB6n KairXBt0oWUcX2gFAmTX+9QACgkQXBt0oWUcX2jeSwD6AtWn0cuo8IF35YRo4o3cDRJnUfJnbvJy GxyCDThR+zYBAKG6/jdwmZkBQZKslnDAbMMd2WfiZZT5JW3IWC4EaKMO7HkBAKYPGZ3UbfkRvfFK S+pQ9CgtNfkSJQBtT1Ob7Y6nsacgAQCpyXN7yppmhW/oBgivITPy9Lkg+V4NK9WZYZCU9Q7LBA== Date: Sat, 07 Dec 2024 02:39:20 +0200 Message-ID: <87ser0s4w7.fsf@> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Andrea Corallo writes: > Eli Zaretskii writes: > >>> From: Björn Bidar >>> Cc: 74637@debbugs.gnu.org >>> Date: Tue, 03 Dec 2024 12:06:11 +0200 >>> >>> >> > That's an incompatible beh [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [185.216.177.71 listed in sa-trusted.bondedsender.org] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [185.216.177.71 listed in bl.score.senderscore.com] 1.2 INVALID_MSGID Message-Id is not valid, according to RFC 2822 X-Debbugs-Envelope-To: 74637 Cc: Eli Zaretskii , 74637@debbugs.gnu.org, Stefan Kangas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) Andrea Corallo writes: > Eli Zaretskii writes: > >>> From: Bj=C3=B6rn Bidar >>> Cc: 74637@debbugs.gnu.org >>> Date: Tue, 03 Dec 2024 12:06:11 +0200 >>>=20 >>> >> > That's an incompatible behavior change. Is that justified? How c= an >>> >> > we be sure that everyone agrees with your interpretation of this m= ode? >>> >>=20 >>> >> All other view-file like modes behave like this, you view the file a= nd >>> >> leave the file with q. >>> > >>> > That doesn't change the fact that view-mode didn't behave like that, >>> > until now. >>>=20 >>> View-mode isn't change outside of the specific situation of opening a >>> file which isn't writable. >> >> It's still a significant change. Killing a buffer is not a minor >> think, and restoring it is not always easy, or even possible (e.g., >> the file could have been deleted in the meantime). >> >> My opinion is that if we install this, we need to provide some way of >> getting the previous behavior back, for those who may want it. >> >> Stefan and Andrea, WDYT? > > Agree with your position. If before killing the file there would be a check if it was deleted is that better? The check would also improve the view-file related functions. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 07 02:43:15 2024 Received: (at 74637) by debbugs.gnu.org; 7 Dec 2024 07:43:15 +0000 Received: from localhost ([127.0.0.1]:45232 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJpT9-0004dG-1N for submit@debbugs.gnu.org; Sat, 07 Dec 2024 02:43:15 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49986) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJpT4-0004cw-3i for 74637@debbugs.gnu.org; Sat, 07 Dec 2024 02:43:12 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tJpSy-0000KY-52; Sat, 07 Dec 2024 02:43:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=tJZKFfEjiwfH8hDOCROqUmTIi+nWMJOvKBBJle7oBT8=; b=CotSut5n7kAoHBnV61kp J7HfRfZRM0Bia6m+4X0mmQbsG8kdOVjU/dFfZCPjDhKErAAYrbibLPhR9NefjPQ8vuIdw0a4Lw8zP 9XHVG80e0lL02F6YNfzp68ZB1pZs6258wY0H5Rg2PwBXH6KhjZNG56gZjaVvgIFx6+LY3KL7X6NcQ ZRclvqw0duaivWx+LCOwLJ3y1w6SOLB0zVe1x1lM2psYC2nt+o6B9UK/BXL3CpzNfc7MDVtsh54Bq ahlhSflfq6wsW6kYY5hcrnqWrWjevoP2CkfZNBIkhdSEmo40tFfnnb1T87TK24P9gZVN8RaFZu8u+ e4+/SbTwJw/K+g==; Date: Sat, 07 Dec 2024 09:43:00 +0200 Message-Id: <86v7vwj5vf.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?Q?Bj=C3=B6rn?= Bidar In-Reply-To: <87ser0s4w7.fsf@> (message from =?utf-8?Q?Bj=C3=B6rn?= Bidar on Sat, 07 Dec 2024 02:39:20 +0200) Subject: Re: bug#74637: [PATCH] Make view-read-only behave like view-file References: <86ldwy46al.fsf@gnu.org> <86o71t3mob.fsf@gnu.org> <86zflc27dl.fsf@gnu.org> <87ser0s4w7.fsf@> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74637 Cc: acorallo@gnu.org, 74637@debbugs.gnu.org, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Björn Bidar > Cc: Eli Zaretskii , 74637@debbugs.gnu.org, Stefan Kangas > > Date: Sat, 07 Dec 2024 02:39:20 +0200 > > Andrea Corallo writes: > > >> Stefan and Andrea, WDYT? > > > > Agree with your position. > > If before killing the file there would be a check if it was deleted > is that better? The check would also improve the view-file related > functions. Personally, I'm not sure it is much better. First, the file might have been moved or renamed, not deleted. More generally, it strikes me as very un-Emacsy to kill a buffer when the user is done with it. We only do that with temporary buffers created for the purpose of performing some processing; otherwise we leave the buffers in the session, leaving it to the user to decide when to kill them. We also have optional features, like mindnight.el, which are capable of killing buffers that were not accessed for a long time, and the very fact that they are optional clearly shows the general attitude of Emacs: not to kill buffers unless explicitly told so by the user. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 07 13:06:28 2024 Received: (at 74637) by debbugs.gnu.org; 7 Dec 2024 18:06:28 +0000 Received: from localhost ([127.0.0.1]:48451 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJzCF-0002mC-KJ for submit@debbugs.gnu.org; Sat, 07 Dec 2024 13:06:27 -0500 Received: from thaodan.de ([185.216.177.71]:46176) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJzCD-0002m2-Po for 74637@debbugs.gnu.org; Sat, 07 Dec 2024 13:06:26 -0500 Received: from odin (dsl-trebng12-50dc7b-49.dhcp.inet.fi [80.220.123.49]) by thaodan.de (Postfix) with ESMTPSA id 79C12D00054; Sat, 7 Dec 2024 20:05:54 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thaodan.de; s=mail; t=1733594754; bh=i5YilsOLx9HLVdP8pl2Yglkziw/9bblnBlvOJPrSXSc=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=MhC95u/b/igPzbDvhJ478NYl2s4wyGrFUaJmaWSbsy71vYRqI5McWgXYc6FcVi0hl L8UsorVFySkpQ/Zm2SLUGSsuwp+2uJsZGlipm0s8XAwmikbBkd705df5OiuCuCSdnl AQlweTgFBjbbaAzbIC0km6w9tO8y8nuJhoxavGObvvGyJytOzz/shxNNwD9TD0jmLZ WfwEM+yNy23bfFBQgzIVjqCkBkzV6sM3n9pF78CZ8uoT4nB2X32PuD5iKLzieP8Wfw /oQqBMTAlzf6Dwd8KhTA8QZGe0kbJ2D+v7oi7MWkplB3UvJ0sbm1kbDr4Nyl7fObuc /hLxpnATleWSWEX9vql/109R3CsuI1kwHwBqTlXl2arv2NyVdPkkJTc2iAadp1neBD b1K7BMdCKhL9w3MgYul7Ry2OnZ6Z/zxGy/WD1on2NIaqLMqci/IOALMFc7eKfHujVL 6inIfrhl4Gzvzxn10mT1Zs/miNCWM6glNWOqJq9CPt5KOhD4V1p5vHjvoMGIv1dKOw tJ914ym0EXBRhk2w123L60X7nDmlLOa92D5d+tOcnlbJEOrojOUDOAxCLVOqpSh1gv Ps07AcV+RRAaIW0Kmypucx94Nsq9HL5dt3oqPPcNP8RtyReZt1KhktY87YuKmPmpjt 1LlFkADfPLMKGjDkU4S2Aue0= From: =?utf-8?Q?Bj=C3=B6rn?= Bidar To: Eli Zaretskii Subject: Re: bug#74637: [PATCH] Make view-read-only behave like view-file In-Reply-To: <86v7vwj5vf.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 07 Dec 2024 09:43:00 +0200") References: <86ldwy46al.fsf@gnu.org> <86o71t3mob.fsf@gnu.org> <86zflc27dl.fsf@gnu.org> <86v7vwj5vf.fsf@gnu.org> Autocrypt: addr=bjorn.bidar@thaodan.de; prefer-encrypt=nopreference; keydata= mDMEZNfpPhYJKwYBBAHaRw8BAQdACBEmr+0xwIIHZfIDlZmm7sa+lHHSb0g9FZrN6qE6ru60JUJq w7ZybiBCaWRhciA8Ympvcm4uYmlkYXJAdGhhb2Rhbi5kZT6IlgQTFgoAPgIbAwULCQgHAgIiAgYV CgkICwIEFgIDAQIeBwIXgBYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1/YmAhkBAAoJEFwbdKFl HF9oB9cBAJoIIGQKXm4cpap+Flxc/EGnYl0123lcEyzuduqvlDT0AQC3OlFKm/OiqJ8IMTrzJRZ8 phFssTkSrrFXnM2jm5PYDoiTBBMWCgA7FiEEUfF263VHMB6nKairXBt0oWUcX2gFAmTX6T4CGwMF CwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQXBt0oWUcX2hbCQEAtru7kvM8hi8zo6z9ux2h K+B5xViKuo7Z8K3IXuK5ugwA+wUfKzomzdBPhfxDsqLcEziGRxoyx0Q3ld9aermBUccHtBxCasO2 cm4gQmlkYXIgPG1lQHRoYW9kYW4uZGU+iJMEExYKADsCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwEC HgcCF4AWIQRR8XbrdUcwHqcpqKtcG3ShZRxfaAUCZNf2FQAKCRBcG3ShZRxfaCzSAP4hZ7cSp0YN XYpcjHdsySh2MuBhhoPeLGXs+2kSiqBiOwD/TP8AgPEg/R+SI9GI9on7fBJJ0mp2IT8kZ2rhDOjg gA6IkwQTFgoAOxYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1+ntAhsDBQsJCAcCAiICBhUKCQgL AgQWAgMBAh4HAheAAAoJEFwbdKFlHF9oBgwA/iQHwe0VL4Df4GGTYlNjMSHFlIkBmN4UfYGLYj3E TrOUAQC51M+M3cjsL8WHdpBz6VAo6df9d+rVwhQ9vQuFHqevArg4BGTX6T4SCisGAQQBl1UBBQEB B0Cbohc3JEfn005/cm0AOGjSsW1ZxAkgaoVNjbpqk4MgNAMBCAeIeAQYFgoAIBYhBFHxdut1RzAe pymoq1wbdKFlHF9oBQJk1+k+AhsMAAoJEFwbdKFlHF9ooHABAKGmrGBic/Vys3BBrOQiRB3Z7izO HwhqTRpAqFZtXS2nAQDZhp/5aYw1TZjTzkm1KVt9QiYnjd/MvxRE9iaY6x4mDbgzBGTX6T4WCSsG AQQB2kcPAQEHQAgRJq/tMcCCB2XyA5WZpu7GvpRx0m9IPRWazeqhOq7uiO8EGBYKACAWIQRR8Xbr dUcwHqcpqKtcG3ShZRxfaAUCZNf71AIbIgCBCRBcG3ShZRxfaHYgBBkWCgAdFiEEUfF263VHMB6n KairXBt0oWUcX2gFAmTX+9QACgkQXBt0oWUcX2jeSwD6AtWn0cuo8IF35YRo4o3cDRJnUfJnbvJy GxyCDThR+zYBAKG6/jdwmZkBQZKslnDAbMMd2WfiZZT5JW3IWC4EaKMO7HkBAKYPGZ3UbfkRvfFK S+pQ9CgtNfkSJQBtT1Ob7Y6nsacgAQCpyXN7yppmhW/oBgivITPy9Lkg+V4NK9WZYZCU9Q7LBA== Date: Sat, 07 Dec 2024 20:05:53 +0200 Message-ID: <878qsrpdvi.fsf@> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Eli Zaretskii writes: >> From: Björn Bidar >> Cc: Eli Zaretskii , 74637@debbugs.gnu.org, Stefan Kangas >> >> Date: Sat, 07 Dec 2024 02:39:20 +0200 >> >> Andr [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [185.216.177.71 listed in bl.score.senderscore.com] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [185.216.177.71 listed in sa-accredit.habeas.com] 1.2 INVALID_MSGID Message-Id is not valid, according to RFC 2822 X-Debbugs-Envelope-To: 74637 Cc: acorallo@gnu.org, 74637@debbugs.gnu.org, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) Eli Zaretskii writes: >> From: Bj=C3=B6rn Bidar >> Cc: Eli Zaretskii , 74637@debbugs.gnu.org, Stefan Kangas >> >> Date: Sat, 07 Dec 2024 02:39:20 +0200 >>=20 >> Andrea Corallo writes: >>=20 >> >> Stefan and Andrea, WDYT? >> > >> > Agree with your position. >>=20 >> If before killing the file there would be a check if it was deleted >> is that better? The check would also improve the view-file related >> functions. > > Personally, I'm not sure it is much better. First, the file might > have been moved or renamed, not deleted. More generally, it strikes > me as very un-Emacsy to kill a buffer when the user is done with it. Would a better approach be then that pressing q burries the buffer but doesn't exit view-mode if entered through view-read-only on a non writable aka read-only file? Doing so wouldn't remove the option to exit view-mode on such buffers but keep view-mode on in case the user visits the buffer again. Pressing q to bury or delete a read-only buffer is a common action across almost any mode. > We only do that with temporary buffers created for the purpose of > performing some processing; otherwise we leave the buffers in the > session, leaving it to the user to decide when to kill them. We also > have optional features, like mindnight.el, which are capable of > killing buffers that were not accessed for a long time, and the very > fact that they are optional clearly shows the general attitude of > Emacs: not to kill buffers unless explicitly told so by the user. Buffer which visit read only files such as system documentation could be considered temporary but I get the point. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 15 13:44:46 2024 Received: (at 74637) by debbugs.gnu.org; 15 Dec 2024 18:44:46 +0000 Received: from localhost ([127.0.0.1]:52065 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tMtbg-0004gW-NW for submit@debbugs.gnu.org; Sun, 15 Dec 2024 13:44:45 -0500 Received: from mail-ed1-f50.google.com ([209.85.208.50]:58706) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tMtbd-0004gN-Qm for 74637@debbugs.gnu.org; Sun, 15 Dec 2024 13:44:42 -0500 Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-5cecbddb574so5787077a12.1 for <74637@debbugs.gnu.org>; Sun, 15 Dec 2024 10:44:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734288221; x=1734893021; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=trJgt1clOUA7R4ou97DcUDxnaUq4EHnEChpSg+9VYxc=; b=ARGxoBbvmujXn5yCpXfINN3dIIfIb6BOku8WbJGlEeSPIHiqs2rPLvVSesoIJsXrb3 MQcxBGiz35q76M9GhMEcdOZGLGt9DcPkqJanOtdSumQUbbjb/YrGh0G31dNrtc97Cqgv RncyKjUTFksdU1wdj0bjTLI2IA8h7J8il6Q6bc9ViwWs0KX+Ik5iNaJqZbgswsVv3YsA ZI3yHIzRdqxde7T0pBDrmNYs5srBMcsEcLhoI6TR3ek+559Ytcqr/pT95TwAvIcxwXbk 2flGZ6f4PC/b/mKnrInXR+lQtRdxMNHFusk4acML/Hs6gTxSYhz3MhbJumVlaKHXKe4T XmUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734288221; x=1734893021; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=trJgt1clOUA7R4ou97DcUDxnaUq4EHnEChpSg+9VYxc=; b=EZCY5L/dplltTnMv03GuawU5ZEk9jBnsm9tRPisobMT0TLQHTBt7na8Pr+tjI7yjR1 0cA7o7xuPL7XJcNfvPm8WrH5oarPd4mGmQ89V3cY+f4fHe/KGgAtju7J5FCb1t8z0pTy +8qOF8E7uSNtP5X+SyDYUN5Zf20a88UpHlBsaWk5Hp+kjRuILnvCUUAg9XNG8KHGu0Ei lPngV9RUNmF6SaRgHA93AJ9QXbO3d+c0Dca610+OzhoCDulO0//acDYRwYkKVAcSsLFM nZ79Ajkrp1LFZLCK4XjT3eqfY0Vv4nkL2UxyEewibQ6tvSGKCp3PDeabB0vrldsvrOOT 0wqg== X-Forwarded-Encrypted: i=1; AJvYcCWqS00YvFNBCFlQsZ+xOJdA/0GJJ6wLulOOU8KjKOLKdzPElOWabreOtVw5V1vbu5fG6njmTQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxyQpgYCk4ZwAPNlY6uRi2uZbltXe++JNAoFRKBUyKVkOENfFC3 KI8KgV+JWZta3ANzm4aGl6Tc3htwaVUdGCVzYGZThHLRIbwyYdkBf2qX/k5JORzT7Ow0sNOJ9Nb ezUd6INnHp7YjMl/YbLJKT/ZUwpw= X-Gm-Gg: ASbGncvJof3gcwLT35PuTUvng/fmYqTqAtokYhen3x7E29JoEdj54WFuApB9pZOQrdp ncntV7ZTJc+8pK6+8CQ7ziDSijQzBoZW9bP9S0VU= X-Google-Smtp-Source: AGHT+IGZMDynWhghQQe8o4SVBWKmS3Gq7I/UZadVuldxEZ7OOayuECfyRvF1HtK1itgKGXVMMpt2lio4FjQK7C74FXs= X-Received: by 2002:a05:6402:354f:b0:5d0:e2c8:dc8d with SMTP id 4fb4d7f45d1cf-5d63c33bafamr10176756a12.20.1734288220601; Sun, 15 Dec 2024 10:43:40 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 15 Dec 2024 18:43:39 +0000 From: Stefan Kangas In-Reply-To: References: <86ldwy46al.fsf@gnu.org> <86o71t3mob.fsf@gnu.org> <86zflc27dl.fsf@gnu.org> MIME-Version: 1.0 Date: Sun, 15 Dec 2024 18:43:39 +0000 Message-ID: Subject: Re: bug#74637: [PATCH] Make view-read-only behave like view-file To: Andrea Corallo , Eli Zaretskii Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74637 Cc: =?UTF-8?B?QmrDtnJuIEJpZGFy?= , 74637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Andrea Corallo writes: > Eli Zaretskii writes: > >>> From: Bj=C3=B6rn Bidar >>> Cc: 74637@debbugs.gnu.org >>> Date: Tue, 03 Dec 2024 12:06:11 +0200 >>> >>> >> > That's an incompatible behavior change. Is that justified? How c= an >>> >> > we be sure that everyone agrees with your interpretation of this m= ode? >>> >> >>> >> All other view-file like modes behave like this, you view the file a= nd >>> >> leave the file with q. >>> > >>> > That doesn't change the fact that view-mode didn't behave like that, >>> > until now. >>> >>> View-mode isn't change outside of the specific situation of opening a >>> file which isn't writable. >> >> It's still a significant change. Killing a buffer is not a minor >> think, and restoring it is not always easy, or even possible (e.g., >> the file could have been deleted in the meantime). >> >> My opinion is that if we install this, we need to provide some way of >> getting the previous behavior back, for those who may want it. >> >> Stefan and Andrea, WDYT? > > Agree with your position. +1 From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 28 06:32:25 2024 Received: (at 74637-done) by debbugs.gnu.org; 28 Dec 2024 11:32:25 +0000 Received: from localhost ([127.0.0.1]:49466 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRV3Q-000887-P6 for submit@debbugs.gnu.org; Sat, 28 Dec 2024 06:32:25 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58418) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRV3O-00087u-IE for 74637-done@debbugs.gnu.org; Sat, 28 Dec 2024 06:32:23 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tRV3J-0007y9-BN; Sat, 28 Dec 2024 06:32:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=bUEIGqG8hXcRSIGt8A2uT2KULkaYmS8yxecspNrbfVQ=; b=dTHr6IyehZmN1L3uxLTc uUVkNYC2fXwoiQCRi3XIPQjMre8FWbMoOmvQyUjiqfVpwQp/VpoXaTU0u6cZ2/lOX4w8DGTPEOhzW 9AgArXL89HeMLO1GF+bKtTDT4R8q+qU7pcxt7V15SF0V6hsbzMtud3L/gfXkvyGCaFfWnhNpeabg9 Lk9bLDBx73GQtV4ktt0gM8WXvMGZiiVkFOBEVON6K3P5Ml9Ua3GomG2DjTa98zk+dlq2Y50gnV3p2 MCMsx8Jv+9BvtVR0Vv5xoQ8uEEe4Jz2o4emh62QMoU9pUvG7cpEXPqV0dtAHDbpz8jes8wrAq9Dpz heVldJrm9rEsJw==; Date: Sat, 28 Dec 2024 13:32:14 +0200 Message-Id: <86bjwwt54x.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-Reply-To: (message from Stefan Kangas on Sun, 15 Dec 2024 18:43:39 +0000) Subject: Re: bug#74637: [PATCH] Make view-read-only behave like view-file References: <86ldwy46al.fsf@gnu.org> <86o71t3mob.fsf@gnu.org> <86zflc27dl.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74637-done Cc: bjorn.bidar@thaodan.de, acorallo@gnu.org, 74637-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Sun, 15 Dec 2024 18:43:39 +0000 > Cc: Björn Bidar , > 74637@debbugs.gnu.org > > Andrea Corallo writes: > > > Eli Zaretskii writes: > > > >>> From: Björn Bidar > >>> Cc: 74637@debbugs.gnu.org > >>> Date: Tue, 03 Dec 2024 12:06:11 +0200 > >>> > >>> >> > That's an incompatible behavior change. Is that justified? How can > >>> >> > we be sure that everyone agrees with your interpretation of this mode? > >>> >> > >>> >> All other view-file like modes behave like this, you view the file and > >>> >> leave the file with q. > >>> > > >>> > That doesn't change the fact that view-mode didn't behave like that, > >>> > until now. > >>> > >>> View-mode isn't change outside of the specific situation of opening a > >>> file which isn't writable. > >> > >> It's still a significant change. Killing a buffer is not a minor > >> think, and restoring it is not always easy, or even possible (e.g., > >> the file could have been deleted in the meantime). > >> > >> My opinion is that if we install this, we need to provide some way of > >> getting the previous behavior back, for those who may want it. > >> > >> Stefan and Andrea, WDYT? > > > > Agree with your position. > > +1 It sounds like the consensus here is that we should not make this change, so I'm closing this bug. From unknown Tue Aug 19 10:01:40 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 25 Jan 2025 12:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator