GNU bug report logs - #74634
[PATCH shepherd website 0/5] Suggested style changes for 1.0.0 release

Previous Next

Package: guix-patches;

Reported by: sirgazil <at> zoho.com

Date: Sun, 1 Dec 2024 16:14:01 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


Message #8 received at 74634 <at> debbugs.gnu.org (full text, mbox):

From: sirgazil <at> zoho.com
To: 74634 <at> debbugs.gnu.org
Cc: Luis Felipe <sirgazil <at> zoho.com>
Subject: [PATCH shepherd website 1/5] logo: Remove adaptation to user's
 preferred color scheme.
Date: Sun,  1 Dec 2024 11:19:46 -0500
From: Luis Felipe <sirgazil <at> zoho.com>

The website's CSS doesn't adapt to user's preferred color scheme yet,
but the logo image did. This created an accessibility problem for
users who prefer a dark scheme: the whitish version of the logo was
displayed on the whitish pages of the website. This change solves that
problem.

* haunt.scm (page-layout): Always use the logo for light backgrounds.
---
 haunt.scm | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/haunt.scm b/haunt.scm
index 23a0efa..f561fc9 100644
--- a/haunt.scm
+++ b/haunt.scm
@@ -95,11 +95,8 @@
                      (a (@ (href ,(base-url "/"))
                            (class ,(if front-page?
                                        "logo" "logo small")))
-                        (picture
-                         (source (@ (media "(prefers-color-scheme: dark)")
-                                    (srcset ,(image-url "logo-dark.svg"))))
-                         (img (@ (src ,(image-url "logo-light.svg"))
-                                 (alt "Shepherd logo")))))
+                        (img (@ (src ,(image-url "logo-light.svg"))
+                                (alt "Shepherd logo"))))
 
                      ;; Add the large-font welcoming message on the
                      ;; front page.
-- 
2.46.0





This bug report was last modified 228 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.