GNU bug report logs - #74633
[PATCH] ui: Search channels for guix extensions

Previous Next

Full log

Message #31 received at 74633 <at> debbugs.gnu.org (full text, mbox):

From: Brian Kubisiak <brian <at> kubisiak.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 74633 <at> debbugs.gnu.org, Carlo Zancanaro <carlo <at> zancanaro.id.au>
Subject: Re: [bug#74633] [PATCH v2] ui: Search channels for guix extensions
Date: Tue, 7 Jan 2025 17:29:07 -0800

> Could you send a v3 along these lines, if you think that makes sense?

Sent. Note that during testing I noticed that guile-git (and
guile-json-4) needed to be added as dependencies to a g-expression
that imported guix/build/utils.scm due to the additional dependencies
introduced in this patch. I'm probably missing more places where this
is required and Carlo's lazy import may be a better option to avoid
issues like this. Let me know what you think, I can send another
version if you think that's better.

> > +++ b/gnu/packages.scm
> > @@ -148,15 +148,16 @@ (define %package-module-path
> >    (let* ((not-colon   (char-set-complement (char-set #\:)))
> >           (environment (string-tokenize (or (getenv "GUIX_PACKAGE_PATH") "")
> >                                         not-colon))
> > -         (channels-scm channels-go (package-path-entries)))
> > +         (channels-scm (package-path-entries)))
>
> This variable is now unused; I think it can be removed.

This is still used in the below make-parameter call (not shown in the
patch), so I've left it in.

Thanks,
Brian

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.