From unknown Sat Jun 14 19:16:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#74631: 30.0.92; [PATCH] autoload project-recompile and set default-directory Resent-From: Daniel Mendler Original-Sender: "Debbugs-submit" Resent-CC: dmitry@gutov.dev, bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Dec 2024 10:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 74631 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 74631@debbugs.gnu.org Cc: Dmitry Gutov X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: Dmitry Gutov Received: via spool by submit@debbugs.gnu.org id=B.17330501294682 (code B ref -1); Sun, 01 Dec 2024 10:49:02 +0000 Received: (at submit) by debbugs.gnu.org; 1 Dec 2024 10:48:49 +0000 Received: from localhost ([127.0.0.1]:50393 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHhVR-0001DS-5t for submit@debbugs.gnu.org; Sun, 01 Dec 2024 05:48:49 -0500 Received: from lists.gnu.org ([209.51.188.17]:37080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHhVP-0001DI-NN for submit@debbugs.gnu.org; Sun, 01 Dec 2024 05:48:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tHhTJ-0007bX-DV for bug-gnu-emacs@gnu.org; Sun, 01 Dec 2024 05:46:37 -0500 Received: from server.qxqx.de ([2a01:4f8:c012:9177::1] helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tHhTH-00076s-DE for bug-gnu-emacs@gnu.org; Sun, 01 Dec 2024 05:46:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date: Subject:To:From:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=+hMgZif1pQ4QFMfSjPzToDq5hRdFyuLyTiUSfzo/T/0=; b=y3Ce8psLNxxZMYPYb8XJbVCOez 1tKq0iGgEU3JWWwFqA9kf4z4iIzP3Mif09/xjuDlNEsTBqYe2GCqSbavZgEF1DoFt1nzRx4yMec8c ImVHx1itL+UQZaQ1p1FXQpEeHK74UPrlLuIiQOwlhSAQOSzDIuCrnnb43bW7iTFP7Dro=; From: Daniel Mendler Date: Sun, 01 Dec 2024 11:46:30 +0100 Message-ID: <87zflffzp5.fsf@daniel-mendler.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a01:4f8:c012:9177::1; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain In order to make `project-recompile' symmetric to `recompile' it should be autoloaded and it should run in the project root. This makes it possible to call `project-recompile' directly without calling `compile' first. ;;;###autoload (defun project-recompile (&optional edit-command) "Run `recompile' with appropriate buffer." (declare (interactive-only recompile)) (interactive "P") (let ((default-directory (project-root (project-current t))) (compilation-buffer-name-function (or project-compilation-buffer-name-function compilation-buffer-name-function))) (recompile edit-command))) This change also resolves the comment in project-recompile: ;; Should we error instead? When there's no ;; project-specific naming, there is no point in using ;; this command. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-project-recompile-Autoload-and-run-in-project-root.patch >From a330baaaf7a50f3bdf665b32efadb27283453f7f Mon Sep 17 00:00:00 2001 From: Daniel Mendler Date: Sun, 1 Dec 2024 11:43:48 +0100 Subject: [PATCH] project-recompile: Autoload and run in project root * lisp/progmodes/project.el (project-recompile): Autoload and use project root as `default-directory'. --- lisp/progmodes/project.el | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el index ba5a6b6f056..d47b732712f 100644 --- a/lisp/progmodes/project.el +++ b/lisp/progmodes/project.el @@ -1455,15 +1455,14 @@ project-compile compilation-buffer-name-function))) (call-interactively #'compile))) +;;;###autoload (defun project-recompile (&optional edit-command) "Run `recompile' with appropriate buffer." (declare (interactive-only recompile)) (interactive "P") - (let ((compilation-buffer-name-function + (let ((default-directory (project-root (project-current t))) + (compilation-buffer-name-function (or project-compilation-buffer-name-function - ;; Should we error instead? When there's no - ;; project-specific naming, there is no point in using - ;; this command. compilation-buffer-name-function))) (recompile edit-command))) -- 2.45.2 --=-=-=-- From unknown Sat Jun 14 19:16:04 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Daniel Mendler Subject: bug#74631: closed (Re: bug#74631: 30.0.92; [PATCH] autoload project-recompile and set default-directory) Message-ID: References: <02c71b77-433c-4dae-baa0-13376dee75f2@gutov.dev> <87zflffzp5.fsf@daniel-mendler.de> X-Gnu-PR-Message: they-closed 74631 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 74631@debbugs.gnu.org Date: Tue, 10 Dec 2024 02:11:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1733796663-18914-1" This is a multi-part message in MIME format... ------------=_1733796663-18914-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #74631: 30.0.92; [PATCH] autoload project-recompile and set default-directo= ry which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 74631@debbugs.gnu.org. --=20 74631: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D74631 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1733796663-18914-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 74631-done) by debbugs.gnu.org; 10 Dec 2024 02:10:20 +0000 Received: from localhost ([127.0.0.1]:56354 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tKphc-0004r6-DZ for submit@debbugs.gnu.org; Mon, 09 Dec 2024 21:10:20 -0500 Received: from fout-a8-smtp.messagingengine.com ([103.168.172.151]:45777) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tKphY-0004qN-Mz for 74631-done@debbugs.gnu.org; Mon, 09 Dec 2024 21:10:18 -0500 Received: from phl-compute-03.internal (phl-compute-03.phl.internal [10.202.2.43]) by mailfout.phl.internal (Postfix) with ESMTP id 4FAA41383EA1; Mon, 9 Dec 2024 21:10:11 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-03.internal (MEProxy); Mon, 09 Dec 2024 21:10:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1733796611; x=1733883011; bh=9r9m1OmPtwhwL8mD77iTE5ZBIojtchg+sSjPveWAfc8=; b= b4mAGZ5ZFzzSc7010o/sLrqBCCBizF5BEo1rxASQv6jm8WP/WeRlGsrLpS8RsENH 4ohUoWf81Ha8ZOGZgMhjv3NkGmDKw5BBfhuu8SQV7imUcvPYccruSqcC0DvLM3MI Vh4erLW5Yl6ZdvUtSxjAZla+RiHA4NW0szgt8B+shJYbimGh93W5kZ/Qkq39qirr fv3SzNmk1XPwaPIzfhAOC+jwiyWZkPX77eu5amlYaG07AjRCZaKoVKUj7p6ObkQ+ yEw9qNoKskevv+T3up8v40avItWHQezejFeFfNYqv3rXvwAQkAmjd4ZO/Hj28Kt/ 7JEFir7Le7uS2qrKILm3Rg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; t=1733796611; x=1733883011; bh=9 r9m1OmPtwhwL8mD77iTE5ZBIojtchg+sSjPveWAfc8=; b=CTEyjwB/zO3Vvxo1r xh1gBlxQDGpRh5sM+Ib5h7aGZxOKJffByZ573DCVLsxT1jiFbW4I5TxnODxSVkfq 2jgpOG6ERIiXK7Odl/SCG8Z/v3eMk/dMCt7U4EjsUCI0XYKbLo6CXikndn6lBR7K aVq1eDcwRPyI5xUOdlmn5BNpe4RVF2EKOMirLewLpM5/D3u0ZtIKuiXAMP1oqJAz wrAI/VfLrp1g4tF6KnEmIM7PcjLvEDXKe2LqxhWGwWom+ev1JMbV5a5CfZkYJGzA F8qEvp9xY/uC7L6LTmonu5FL5FHTFni6IGlzNL+EMej+8LacsGafspsBr4g9eJC/ OOndw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrjeejgdegfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnth hsucdlqddutddtmdenucfjughrpefkffggfgfuvfhfhfgjtgfgsehtjeertddtvdejnecu hfhrohhmpeffmhhithhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvh eqnecuggftrfgrthhtvghrnheptdfhuedvtdevleegueelvedvjeevheffveevhedvueff tdefhfdvueeggfetgfdtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrg hilhhfrhhomhepughmihhtrhihsehguhhtohhvrdguvghvpdhnsggprhgtphhtthhopeef pdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehmrghilhesuggrnhhivghlqdhmvg hnughlvghrrdguvgdprhgtphhtthhopeejgeeifeduqdguohhnvgesuggvsggsuhhgshdr ghhnuhdrohhrghdprhgtphhtthhopehjuhhriheslhhinhhkohhvrdhnvght X-ME-Proxy: Feedback-ID: i07de48aa:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 9 Dec 2024 21:10:09 -0500 (EST) Message-ID: <02c71b77-433c-4dae-baa0-13376dee75f2@gutov.dev> Date: Tue, 10 Dec 2024 04:10:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#74631: 30.0.92; [PATCH] autoload project-recompile and set default-directory To: Daniel Mendler , 74631-done@debbugs.gnu.org, Juri Linkov References: <87zflffzp5.fsf@daniel-mendler.de> Content-Language: en-US From: Dmitry Gutov In-Reply-To: <87zflffzp5.fsf@daniel-mendler.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74631-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Daniel, On 01/12/2024 12:46, Daniel Mendler wrote: > In order to make `project-recompile' symmetric to `recompile' it should > be autoloaded and it should run in the project root. This makes it > possible to call `project-recompile' directly without calling `compile' > first. > > ;;;###autoload > (defun project-recompile (&optional edit-command) > "Run `recompile' with appropriate buffer." > (declare (interactive-only recompile)) > (interactive "P") > (let ((default-directory (project-root (project-current t))) > (compilation-buffer-name-function > (or project-compilation-buffer-name-function > compilation-buffer-name-function))) > (recompile edit-command))) > > This change also resolves the comment in project-recompile: > > ;; Should we error instead? When there's no > ;; project-specific naming, there is no point in using > ;; this command. Thanks, I've pushed this to master. The comment is related to the previous thread (bug#68570), and it's still unresolved, but IIUC this doesn't make things worse, at least. Cc'ing Juri just in case. ------------=_1733796663-18914-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 1 Dec 2024 10:48:49 +0000 Received: from localhost ([127.0.0.1]:50393 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHhVR-0001DS-5t for submit@debbugs.gnu.org; Sun, 01 Dec 2024 05:48:49 -0500 Received: from lists.gnu.org ([209.51.188.17]:37080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHhVP-0001DI-NN for submit@debbugs.gnu.org; Sun, 01 Dec 2024 05:48:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tHhTJ-0007bX-DV for bug-gnu-emacs@gnu.org; Sun, 01 Dec 2024 05:46:37 -0500 Received: from server.qxqx.de ([2a01:4f8:c012:9177::1] helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tHhTH-00076s-DE for bug-gnu-emacs@gnu.org; Sun, 01 Dec 2024 05:46:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date: Subject:To:From:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=+hMgZif1pQ4QFMfSjPzToDq5hRdFyuLyTiUSfzo/T/0=; b=y3Ce8psLNxxZMYPYb8XJbVCOez 1tKq0iGgEU3JWWwFqA9kf4z4iIzP3Mif09/xjuDlNEsTBqYe2GCqSbavZgEF1DoFt1nzRx4yMec8c ImVHx1itL+UQZaQ1p1FXQpEeHK74UPrlLuIiQOwlhSAQOSzDIuCrnnb43bW7iTFP7Dro=; From: Daniel Mendler To: bug-gnu-emacs@gnu.org Subject: 30.0.92; [PATCH] autoload project-recompile and set default-directory X-Debbugs-Cc: Dmitry Gutov Date: Sun, 01 Dec 2024 11:46:30 +0100 Message-ID: <87zflffzp5.fsf@daniel-mendler.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a01:4f8:c012:9177::1; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain In order to make `project-recompile' symmetric to `recompile' it should be autoloaded and it should run in the project root. This makes it possible to call `project-recompile' directly without calling `compile' first. ;;;###autoload (defun project-recompile (&optional edit-command) "Run `recompile' with appropriate buffer." (declare (interactive-only recompile)) (interactive "P") (let ((default-directory (project-root (project-current t))) (compilation-buffer-name-function (or project-compilation-buffer-name-function compilation-buffer-name-function))) (recompile edit-command))) This change also resolves the comment in project-recompile: ;; Should we error instead? When there's no ;; project-specific naming, there is no point in using ;; this command. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-project-recompile-Autoload-and-run-in-project-root.patch >From a330baaaf7a50f3bdf665b32efadb27283453f7f Mon Sep 17 00:00:00 2001 From: Daniel Mendler Date: Sun, 1 Dec 2024 11:43:48 +0100 Subject: [PATCH] project-recompile: Autoload and run in project root * lisp/progmodes/project.el (project-recompile): Autoload and use project root as `default-directory'. --- lisp/progmodes/project.el | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el index ba5a6b6f056..d47b732712f 100644 --- a/lisp/progmodes/project.el +++ b/lisp/progmodes/project.el @@ -1455,15 +1455,14 @@ project-compile compilation-buffer-name-function))) (call-interactively #'compile))) +;;;###autoload (defun project-recompile (&optional edit-command) "Run `recompile' with appropriate buffer." (declare (interactive-only recompile)) (interactive "P") - (let ((compilation-buffer-name-function + (let ((default-directory (project-root (project-current t))) + (compilation-buffer-name-function (or project-compilation-buffer-name-function - ;; Should we error instead? When there's no - ;; project-specific naming, there is no point in using - ;; this command. compilation-buffer-name-function))) (recompile edit-command))) -- 2.45.2 --=-=-=-- ------------=_1733796663-18914-1-- From unknown Sat Jun 14 19:16:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#74631: 30.0.92; [PATCH] autoload project-recompile and set default-directory Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 10 Dec 2024 07:50:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74631 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Dmitry Gutov Cc: Daniel Mendler , 74631@debbugs.gnu.org Received: via spool by 74631-submit@debbugs.gnu.org id=B74631.17338169903010 (code B ref 74631); Tue, 10 Dec 2024 07:50:03 +0000 Received: (at 74631) by debbugs.gnu.org; 10 Dec 2024 07:49:50 +0000 Received: from localhost ([127.0.0.1]:56801 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tKv0A-0000mU-Bw for submit@debbugs.gnu.org; Tue, 10 Dec 2024 02:49:50 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:38889) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tKv08-0000m7-Dc for 74631@debbugs.gnu.org; Tue, 10 Dec 2024 02:49:49 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id 835F8E000E; Tue, 10 Dec 2024 07:49:38 +0000 (UTC) From: Juri Linkov In-Reply-To: <02c71b77-433c-4dae-baa0-13376dee75f2@gutov.dev> (Dmitry Gutov's message of "Tue, 10 Dec 2024 04:10:08 +0200") Organization: LINKOV.NET References: <87zflffzp5.fsf@daniel-mendler.de> <02c71b77-433c-4dae-baa0-13376dee75f2@gutov.dev> Date: Tue, 10 Dec 2024 09:40:33 +0200 Message-ID: <87cyi0rola.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> In order to make `project-recompile' symmetric to `recompile' it should >> be autoloaded and it should run in the project root. This makes it >> possible to call `project-recompile' directly without calling `compile' >> first. >> ;;;###autoload >> (defun project-recompile (&optional edit-command) >> "Run `recompile' with appropriate buffer." >> (declare (interactive-only recompile)) >> (interactive "P") >> (let ((default-directory (project-root (project-current t))) >> (compilation-buffer-name-function >> (or project-compilation-buffer-name-function >> compilation-buffer-name-function))) >> (recompile edit-command))) >> This change also resolves the comment in project-recompile: >> ;; Should we error instead? When there's no >> ;; project-specific naming, there is no point in using >> ;; this command. > > Thanks, I've pushed this to master. Agreed, this is the right thing to do. > The comment is related to the previous thread (bug#68570), and it's still > unresolved, but IIUC this doesn't make things worse, at least. Isn't bug#68570 solved by bug#70136? From unknown Sat Jun 14 19:16:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#74631: 30.0.92; [PATCH] autoload project-recompile and set default-directory Resent-From: Daniel Mendler Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 10 Dec 2024 15:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74631 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Dmitry Gutov Cc: 74631-done@debbugs.gnu.org, Juri Linkov Received: via spool by 74631-done@debbugs.gnu.org id=D74631.173384511129285 (code D ref 74631); Tue, 10 Dec 2024 15:39:02 +0000 Received: (at 74631-done) by debbugs.gnu.org; 10 Dec 2024 15:38:31 +0000 Received: from localhost ([127.0.0.1]:59133 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tL2Jj-0007cG-1z for submit@debbugs.gnu.org; Tue, 10 Dec 2024 10:38:31 -0500 Received: from server.qxqx.de ([49.12.34.165]:58173 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tL2Jh-0007bb-20 for 74631-done@debbugs.gnu.org; Tue, 10 Dec 2024 10:38:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=oRmYcwG3+Yh2Fc+tf/e9YojsgTaY+fYClq4kNx4zdDw=; b=METXdzy/uGYBfboz4i4Deo0LiT bFoEKKKWgR4CBhoVg21GNAwnRM1AiF9bznLJxBkE+eiPaboydyL3bl9RAmlqdd80bwUXUoXR/5fnR i4cYSJpBXNUaxuh9XgmPs0RdECLv64yCO4mr9M0ULKwHZAHalRh+Erj8L7EpjYzVbaic=; From: Daniel Mendler In-Reply-To: <02c71b77-433c-4dae-baa0-13376dee75f2@gutov.dev> (Dmitry Gutov's message of "Tue, 10 Dec 2024 04:10:08 +0200") References: <87zflffzp5.fsf@daniel-mendler.de> <02c71b77-433c-4dae-baa0-13376dee75f2@gutov.dev> Date: Tue, 10 Dec 2024 16:38:21 +0100 Message-ID: <87frmvh7ki.fsf@daniel-mendler.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: > Hi Daniel, > > On 01/12/2024 12:46, Daniel Mendler wrote: >> In order to make `project-recompile' symmetric to `recompile' it should >> be autoloaded and it should run in the project root. This makes it >> possible to call `project-recompile' directly without calling `compile' >> first. >> ;;;###autoload >> (defun project-recompile (&optional edit-command) >> "Run `recompile' with appropriate buffer." >> (declare (interactive-only recompile)) >> (interactive "P") >> (let ((default-directory (project-root (project-current t))) >> (compilation-buffer-name-function >> (or project-compilation-buffer-name-function >> compilation-buffer-name-function))) >> (recompile edit-command))) >> This change also resolves the comment in project-recompile: >> ;; Should we error instead? When there's no >> ;; project-specific naming, there is no point in using >> ;; this command. > > Thanks, I've pushed this to master. > > The comment is related to the previous thread (bug#68570), and it's still > unresolved, but IIUC this doesn't make things worse, at least. > > Cc'ing Juri just in case. Thanks for installing the patch! I just saw that the docstring should probably also updated accordingly. Maybe like this: "Run `recompile' in the project root with an appropriate buffer." Daniel From unknown Sat Jun 14 19:16:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#74631: 30.0.92; [PATCH] autoload project-recompile and set default-directory Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 10 Dec 2024 23:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74631 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Juri Linkov Cc: Daniel Mendler , 74631@debbugs.gnu.org Received: via spool by 74631-submit@debbugs.gnu.org id=B74631.173387324518437 (code B ref 74631); Tue, 10 Dec 2024 23:28:01 +0000 Received: (at 74631) by debbugs.gnu.org; 10 Dec 2024 23:27:25 +0000 Received: from localhost ([127.0.0.1]:60013 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tL9dU-0004nE-IB for submit@debbugs.gnu.org; Tue, 10 Dec 2024 18:27:24 -0500 Received: from fhigh-b2-smtp.messagingengine.com ([202.12.124.153]:40077) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tL9dR-0004ma-PH for 74631@debbugs.gnu.org; Tue, 10 Dec 2024 18:27:23 -0500 Received: from phl-compute-11.internal (phl-compute-11.phl.internal [10.202.2.51]) by mailfhigh.stl.internal (Postfix) with ESMTP id E54ED254009F; Tue, 10 Dec 2024 18:27:15 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-11.internal (MEProxy); Tue, 10 Dec 2024 18:27:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1733873235; x=1733959635; bh=Blj/HgtbbrQEDrU5GC3TNMIH+gOdRJsBULSOIRkIPlA=; b= IOkv+htIUH7baU9EYqGY2rCfBc4xpChNBZRvEPT6ars5z4zPY1vq29ckaPVl28Km aS+OxNNxckrxFVBOrqN7plmFeCydeeYmerMw3BLLcYA0C+A08tVLitFZyffgc1uc EBw6IM74tni/GFhV7sRRpx/gWGtW/bbVNLRP3RctlvZrAQYkCXUbg2yhrw8sXviB MFbxKBHG21rnttvkE5O1/Oc007d/BkDZfWTmdWBuJr8ArjzQNO+z7VTtaKjacby6 dxnvwE/usHdO+59hfMG1By3mM1LjJkDg9fbjQfdgKof3Z1wd6sbcox5HDTOVuhwk GkGARRIUNfyg75P051gkrA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1733873235; x= 1733959635; bh=Blj/HgtbbrQEDrU5GC3TNMIH+gOdRJsBULSOIRkIPlA=; b=N QE7lo3lEEGb3nk3uCN1H6XYo+l9rnP21flEcK5t7X///nYN9E5irPyC1c4O4U2mN ZznqXVEpLKeVy3xLdG9Yawyqqgnpfv8wtxcoXODbIhMJqCzbGkKEKcapw9IYZp8T fvqORiuO1nnyej7mvOnsJPhRuAkXwXSCkkrW9rUJzmokchaT22Dtn4lcEK7cFwHo iPcmHCIOScGrU5+8pMZjqC1wc4YkpVXo7oTZ685HTJnIW//afBESo/uwPddQYGF6 PrHemPJ0agZQnx7ChY2WSRZeWK+6EtIyS9nU8Ep1vyOAAzqFaRWcYUApXagJ2nFd 52dNBxEkvg94c3/yZZ5rw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrjeelgddtlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnth hsucdlqddutddtmdenucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttddvjeen ucfhrhhomhepffhmihhtrhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvg hvqeenucggtffrrghtthgvrhhnpeetudeljeegheetgfehgeejkeeuhedvveeikeeufedt vddtveefhfdvveegudejheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmh grihhlfhhrohhmpegumhhithhrhiesghhuthhovhdruggvvhdpnhgspghrtghpthhtohep fedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepjhhurhhisehlihhnkhhovhdrnh gvthdprhgtphhtthhopehmrghilhesuggrnhhivghlqdhmvghnughlvghrrdguvgdprhgt phhtthhopeejgeeifeduseguvggssghughhsrdhgnhhurdhorhhg X-ME-Proxy: Feedback-ID: i07de48aa:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 10 Dec 2024 18:27:14 -0500 (EST) Message-ID: <5ec1d7f1-64ca-4ca5-8d2f-97b1925f0bd6@gutov.dev> Date: Wed, 11 Dec 2024 01:27:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird References: <87zflffzp5.fsf@daniel-mendler.de> <02c71b77-433c-4dae-baa0-13376dee75f2@gutov.dev> <87cyi0rola.fsf@mail.linkov.net> Content-Language: en-US From: Dmitry Gutov In-Reply-To: <87cyi0rola.fsf@mail.linkov.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 10/12/2024 09:40, Juri Linkov wrote: >> The comment is related to the previous thread (bug#68570), and it's still >> unresolved, but IIUC this doesn't make things worse, at least. > Isn't bug#68570 solved by bug#70136? Now that you mention it, the solution proposed in bug#70136 does seem like the right direction. So we can hope for having it resolved there. From unknown Sat Jun 14 19:16:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#74631: 30.0.92; [PATCH] autoload project-recompile and set default-directory Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 10 Dec 2024 23:30:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74631 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Daniel Mendler Cc: 74631-done@debbugs.gnu.org, Juri Linkov Received: via spool by 74631-done@debbugs.gnu.org id=D74631.173387339919074 (code D ref 74631); Tue, 10 Dec 2024 23:30:03 +0000 Received: (at 74631-done) by debbugs.gnu.org; 10 Dec 2024 23:29:59 +0000 Received: from localhost ([127.0.0.1]:60021 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tL9fz-0004xY-B3 for submit@debbugs.gnu.org; Tue, 10 Dec 2024 18:29:59 -0500 Received: from fout-b1-smtp.messagingengine.com ([202.12.124.144]:53889) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tL9fw-0004xE-II for 74631-done@debbugs.gnu.org; Tue, 10 Dec 2024 18:29:57 -0500 Received: from phl-compute-03.internal (phl-compute-03.phl.internal [10.202.2.43]) by mailfout.stl.internal (Postfix) with ESMTP id 35F39114006E; Tue, 10 Dec 2024 18:29:51 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-03.internal (MEProxy); Tue, 10 Dec 2024 18:29:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1733873391; x=1733959791; bh=UjeILJd4dQdb4qufVq5y9iTdYaf8DwsGfH57yLeluqI=; b= N8j4POQLpbQKzGMFUGjE2LvG9NLcqzXHAHxQXkYLufoyZfC5P1CPckmnHDGGlrBx GLeqC8MmCd+PQsi++fDeLE/T3T6PmJxEEWyxl4Ksh1nF26u5+Xi9odkdJBnF0oLF OXQA3qtu10yqdAtQABrn7zkWRvil1gb+aeA/KBbOKw5znCTabPkFBjqZY4K1AJeT balElwjB6F+Dh627xHlOhBWG5fJHGt9gEIxPsMxgaXjRNs0vTlilRxJDGzXiXypE M0IWMvIu689kce7Bl/d3V8Hi4iVulB1m6ahfHap1LiLUbwjJfuCSExWqZIHpRby+ 10/K3dEiOI2l0IX1bjJfjg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1733873391; x= 1733959791; bh=UjeILJd4dQdb4qufVq5y9iTdYaf8DwsGfH57yLeluqI=; b=y 8F9gElF0dIOpZ4mBZgltJ7dPMFikaRu3dmEORqM49xXLl1RXRWumQIpKafi8ok6P 7FJ676Lpw+i10hzGz1w+qeeEGBEI3y+AmDyGUulhasstUive9CWGjT8Itlgmnqc1 vYLDOG8RrB2l7uwkDueHSWzLv8E4vGMNnwhT7s0VrRpV7npRzpyfy4x4YQXl7BaD NbIPaYmVbwbeyQlh2ABFS7gpULvMMLAE3blVQzdH6fgbbbBAgmbnpgZHmYFxVpGJ N9+zNfIBYy3Fk+ovKRQlKwyCNJIQAURe/AX09PVfxXO5vvq8rxi+EQ9T2ckrHevl 0n3KqHUkXBkPhyK8Gvhlw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrjeelgddtlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnth hsucdlqddutddtmdenucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttddvjeen ucfhrhhomhepffhmihhtrhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvg hvqeenucggtffrrghtthgvrhhnpeetudeljeegheetgfehgeejkeeuhedvveeikeeufedt vddtveefhfdvveegudejheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmh grihhlfhhrohhmpegumhhithhrhiesghhuthhovhdruggvvhdpnhgspghrtghpthhtohep fedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepmhgrihhlsegurghnihgvlhdqmh gvnhgulhgvrhdruggvpdhrtghpthhtohepjeegieefuddqughonhgvseguvggssghughhs rdhgnhhurdhorhhgpdhrtghpthhtohepjhhurhhisehlihhnkhhovhdrnhgvth X-ME-Proxy: Feedback-ID: i07de48aa:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 10 Dec 2024 18:29:49 -0500 (EST) Message-ID: <36dd7a32-5ec0-4544-87b9-715e08cca488@gutov.dev> Date: Wed, 11 Dec 2024 01:29:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird References: <87zflffzp5.fsf@daniel-mendler.de> <02c71b77-433c-4dae-baa0-13376dee75f2@gutov.dev> <87frmvh7ki.fsf@daniel-mendler.de> Content-Language: en-US From: Dmitry Gutov In-Reply-To: <87frmvh7ki.fsf@daniel-mendler.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 10/12/2024 17:38, Daniel Mendler wrote: > I just saw that the docstring should > probably also updated accordingly. Maybe like this: > > "Run `recompile' in the project root with an appropriate buffer." Thank you, pushed now too. From unknown Sat Jun 14 19:16:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#74631: 30.0.92; [PATCH] autoload project-recompile and set default-directory Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Dec 2024 17:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74631 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Dmitry Gutov Cc: 74631@debbugs.gnu.org Received: via spool by 74631-submit@debbugs.gnu.org id=B74631.173454231326438 (code B ref 74631); Wed, 18 Dec 2024 17:19:02 +0000 Received: (at 74631) by debbugs.gnu.org; 18 Dec 2024 17:18:33 +0000 Received: from localhost ([127.0.0.1]:35802 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNxgu-0006sK-RL for submit@debbugs.gnu.org; Wed, 18 Dec 2024 12:18:33 -0500 Received: from [217.70.183.200] (port=43811 helo=relay7-d.mail.gandi.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNxgt-0006s0-Hk for 74631@debbugs.gnu.org; Wed, 18 Dec 2024 12:18:32 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id BC4192000A; Wed, 18 Dec 2024 17:17:56 +0000 (UTC) From: Juri Linkov In-Reply-To: <5ec1d7f1-64ca-4ca5-8d2f-97b1925f0bd6@gutov.dev> (Dmitry Gutov's message of "Wed, 11 Dec 2024 01:27:11 +0200") Organization: LINKOV.NET References: <87zflffzp5.fsf@daniel-mendler.de> <02c71b77-433c-4dae-baa0-13376dee75f2@gutov.dev> <87cyi0rola.fsf@mail.linkov.net> <5ec1d7f1-64ca-4ca5-8d2f-97b1925f0bd6@gutov.dev> Date: Wed, 18 Dec 2024 19:12:12 +0200 Message-ID: <87ed25p237.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: 0.6 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) >>> The comment is related to the previous thread (bug#68570), and it's still >>> unresolved, but IIUC this doesn't make things worse, at least. >> Isn't bug#68570 solved by bug#70136? > > Now that you mention it, the solution proposed in bug#70136 does seem like > the right direction. So we can hope for having it resolved there. Indeed, bug#70136 solves many problems. Using dir-local variables in non-file buffers will for example fix such cases that when need to add the "-a" switch to ripgrep to find files that accidentally contain a null byte, then I see no other way than to do this on per-project basis by adding to .dir-locals.el: ((nil . ((xref-search-program-alist . ((ripgrep . "xargs -0 rg -a --null -nH -e ")))))) But currently it has no effect.