Subject: bug#74618: closed (Re: [bug#74618] [PATCH] gnu: lcov: disable parallel tests)

From: [email-masked] (GNU bug Tracking System)
Date: Sat, 07 Dec 2024 01:42:04 +0000

Your bug report

#74618: [PATCH] gnu: lcov: disable parallel tests

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
74618: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=74618
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#74618] [PATCH] gnu: lcov: disable parallel tests
From: Zheng Junjie <[email-masked]>
To: Ryan Sundberg via Guix-patches via <[email-masked]>
Cc: Ryan Sundberg <[email-masked]>, [email-masked]
Date: Sat, 07 Dec 2024 09:41:00 +0800
List-Id: <debbugs-submit.debbugs.gnu.org>

please use [PATCH v2] next.

Ryan Sundberg via Guix-patches via <[email-masked]> writes:

> `make check` is not reliable for lcov when run in parallel
> (e.g. `make -j 24 check`). Disable parallelism for the test suite.
>
> * gnu/packages/code (lcov): Set #:parallel-tests? #f
>
> Signed-off-by: Ryan Sundberg <[email-masked]>
> Change-Id: Ibb3618c4786dfbb50b90e725297947458115347c
> ---
>  gnu/packages/code.scm | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/gnu/packages/code.scm b/gnu/packages/code.scm
> index 04ca4dfd6b..2ad1d8616a 100644
> --- a/gnu/packages/code.scm
> +++ b/gnu/packages/code.scm
> @@ -556,6 +556,9 @@ (define-public lcov
>       '(#:test-target "test"
>         #:make-flags (list (string-append "PREFIX="
>                                           (assoc-ref %outputs "out")))
> +       ;; This test suite has race conditions in its scripts which make it
> +       ;; unreliable when run in parallel.
> +       #:parallel-tests? #f
>         #:phases
>         (modify-phases %standard-phases
>           (add-after 'unpack 'patch-references-to-commands
>
> base-commit: ce877a777e6ec089dc347e9883387d3080b471cf

pushed, closing.

Subject: [PATCH] gnu: lcov: disable parallel tests
From: Ryan Sundberg <[email-masked]>
To: [email-masked]
Cc: Ryan Sundberg <[email-masked]>
Date: Fri, 29 Nov 2024 23:33:30 -0800
List-Id: <debbugs-submit.debbugs.gnu.org>

`make check` is not reliable for lcov when run in parallel
(e.g. `make -j 24 check`). Disable parallelism for the test suite.

* gnu/packages/code (lcov): Set #:parallel-tests? #f

Signed-off-by: Ryan Sundberg <[email-masked]>
Change-Id: Ibb3618c4786dfbb50b90e725297947458115347c
---
 gnu/packages/code.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/code.scm b/gnu/packages/code.scm
index 04ca4dfd6b..6ac514a5b5 100644
--- a/gnu/packages/code.scm
+++ b/gnu/packages/code.scm
@@ -556,6 +556,7 @@ (define-public lcov
      '(#:test-target "test"
        #:make-flags (list (string-append "PREFIX="
                                          (assoc-ref %outputs "out")))
+       #:parallel-tests? #f
        #:phases
        (modify-phases %standard-phases
          (add-after 'unpack 'patch-references-to-commands

base-commit: ce877a777e6ec089dc347e9883387d3080b471cf
-- 
2.41.0