GNU bug report logs - #74616
30.0.92; tmm always displays the *Completions* buffer

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#74616: closed (30.0.92; tmm always displays the *Completions*
 buffer)
Date: Sat, 14 Dec 2024 12:42:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 14 Dec 2024 14:40:12 +0200
with message-id <8634iqv3o3.fsf <at> gnu.org>
and subject line Re: bug#74616: 30.0.92; tmm always displays the *Completions* buffer
has caused the debbugs.gnu.org bug report #74616,
regarding 30.0.92; tmm always displays the *Completions* buffer
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
74616: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=74616
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Daniel Mendler <mail <at> daniel-mendler.de>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.92; tmm always displays the *Completions* buffer
Date: Sat, 30 Nov 2024 07:42:33 +0100

The `tmm-add-prompt' function of tmm.el automatically displays the
*Completions* buffer by calling `minibuffer-completion-help'. If an
alternative minibuffer completion system like Icomplete or Vertico is
used, the *Completions* buffer is not needed since the candidates are
already displayed in the minibuffer. I propose to either detect these
alternative completion systems (e.g., by checking the value of the
completing-read-function and/or the mode variables) or to provide a new
customization variable `tmm-display-completions' which defaults to t but
can be set to nil to disable the call to `minibuffer-completion-help'. I
am happy to provide a patch for either of these approaches.

[Message part 3 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Daniel Mendler <mail <at> daniel-mendler.de>
Cc: monnier <at> iro.umontreal.ca, 74616-done <at> debbugs.gnu.org, juri <at> linkov.net
Subject: Re: bug#74616: 30.0.92; tmm always displays the *Completions* buffer
Date: Sat, 14 Dec 2024 14:40:12 +0200

> From: Daniel Mendler <mail <at> daniel-mendler.de>
> Cc: juri <at> linkov.net,  monnier <at> iro.umontreal.ca,  74616 <at> debbugs.gnu.org
> Date: Sat, 14 Dec 2024 12:44:48 +0100
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> >> From: Daniel Mendler <mail <at> daniel-mendler.de>
> >> Cc: juri <at> linkov.net,  monnier <at> iro.umontreal.ca,  74616 <at> debbugs.gnu.org
> >> Date: Wed, 11 Dec 2024 16:37:18 +0100
> >> 
> >> > Thanks.  This LGTM (but let's leave some time for others to chime in),
> >> > with the following nit:
> >> >
> >> >> ++++
> >> >> +*** New user option 'completion-eager-display'.
> >> >> +This option configures whether completion commands should display
> >> >> +the *Completions* buffer immediately.  When the variable is set to t all
> >> >> +completion commands show *Completions* immediately, respectively nil
> >> >> +disables the eager display for all commands. The default setting auto
> >> >                                               ^^
> >> > Two spaces there, please.
> >> 
> >> Thanks. Updated patch attached.
> >
> > Thanks.  I was about to install this, but it turns out it breaks
> > minibuffer-tests:
> 
> Thanks for finding this. The problem was that `initial-input' was passed
> directly to `completion-metadata'. I replaced `initial-input' with `(or
> initial-input "")'. See the updated patch attached to this mail.

Thanks, now installed on the master branch, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.