From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 30 01:37:37 2024 Received: (at submit) by debbugs.gnu.org; 30 Nov 2024 06:37:37 +0000 Received: from localhost ([127.0.0.1]:45174 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHH6n-0004wA-DZ for submit@debbugs.gnu.org; Sat, 30 Nov 2024 01:37:37 -0500 Received: from lists.gnu.org ([209.51.188.17]:54990) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHH6k-0004w2-P3 for submit@debbugs.gnu.org; Sat, 30 Nov 2024 01:37:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tHH6k-0006ut-3z for bug-gnu-emacs@gnu.org; Sat, 30 Nov 2024 01:37:34 -0500 Received: from server.qxqx.de ([2a01:4f8:c012:9177::1] helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tHH6i-0001OP-96 for bug-gnu-emacs@gnu.org; Sat, 30 Nov 2024 01:37:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date: Subject:To:From:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=zVaCv/6dNeuGI72W+UJDy1XJTQI4aurT+3AIh1NhRWY=; b=U91ujnQ2U2m0Bx7bGMx14hv22C iWKc6/jY6zAzXdbY2O+9gY7Owat0zAytP9tgW8sAU2H9UaBzExB4nyaz1aeES8+8VWF9t7O+foxOS qepsx+0wcQzzVcMVqrL7Sox/QG1HyjzpIFvL+yHQOmk6fSyatwlmeJmj3uKvzF/l7hxc=; From: Daniel Mendler To: bug-gnu-emacs@gnu.org Subject: 30.0.92; js-find-symbol automatically activates ido-mode X-Debbugs-Cc: Stefan Monnier Date: Sat, 30 Nov 2024 07:37:27 +0100 Message-ID: <87bjxxw7ko.fsf@daniel-mendler.de> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a01:4f8:c012:9177::1; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain js-find-symbol/js--read-symbol reads a symbol via ido-completing-read and automatically activates ido-mode. For users of other completion systems (default completion, Icomplete/Fido, Vertico, Helm, ...) this is not desired. Icomplete/Fido/Vertico/etc. replace Ido and provide similar behavior for general completing-read. Patch attached. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-progmodes-js-Use-completing-read-instead-of-ido-comp.patch >From 3b4ccb677a16fc4934d62fed7e1f01b52399e633 Mon Sep 17 00:00:00 2001 From: Daniel Mendler Date: Wed, 1 Mar 2023 19:27:38 +0100 Subject: [PATCH] progmodes/js: Use completing-read instead of ido-completing-read --- lisp/progmodes/js.el | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/lisp/progmodes/js.el b/lisp/progmodes/js.el index f74b8ab1c46..29566d38109 100644 --- a/lisp/progmodes/js.el +++ b/lisp/progmodes/js.el @@ -58,11 +58,8 @@ (eval-when-compile (require 'cl-lib) - (require 'ido) (require 'rx)) -(defvar ido-cur-list) -(declare-function ido-mode "ido" (&optional arg)) (declare-function treesit-parser-create "treesit.c") (declare-function treesit-induce-sparse-tree "treesit.c") (declare-function treesit-search-subtree "treesit.c") @@ -3288,11 +3285,7 @@ js--read-symbol initial input INITIAL-INPUT. Return a cons of (SYMBOL-NAME . LOCATION), where SYMBOL-NAME is a string and LOCATION is a marker." - (unless ido-mode - (ido-mode 1) - (ido-mode -1)) - - (let ((choice (ido-completing-read + (let ((choice (completing-read prompt (cl-loop for key being the hash-keys of symbols-table collect key) -- 2.45.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 30 03:03:08 2024 Received: (at 74615) by debbugs.gnu.org; 30 Nov 2024 08:03:09 +0000 Received: from localhost ([127.0.0.1]:45287 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHIRY-00011z-HB for submit@debbugs.gnu.org; Sat, 30 Nov 2024 03:03:08 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48852) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHIRV-00011N-BJ for 74615@debbugs.gnu.org; Sat, 30 Nov 2024 03:03:06 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tHIRN-0002Oa-QF; Sat, 30 Nov 2024 03:02:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=maw49P2bI7kWR/+Q2tVI/wUU/ALKB10k3ZGKKvqTfOI=; b=g/oO3EF4kaNk RnJPL0EPKJMtU26NnjbrhuU3rmptrz1ldp7mK9bCBGdt2NFRLtWTC80caNT+CKYXTZQOi9VftpTMm yeYLrIwEVTA6jP7fzEIluHHUr7VDxvqFWxme8OElko+JZNzNmK14mbOVGtW88UwMLZ1cM7zB1np9s LzGISoqJV5NxGa/QPryDGA4lHyfQAy75PPp8M2T9tvlnxRCWhicG1+lgsvrg3sZ5l2WmjM2yHJLeD Lwyrfut8gIGpBTOrFHhYl90pwlh49Z4otqVW+GWqaJc9VQxVJmfazy6IxJ1xNzVV/C+8W91kTbYz5 W3w3/oE/hCDnkLx3HBf2yQ==; Date: Sat, 30 Nov 2024 10:02:55 +0200 Message-Id: <86y1119mj4.fsf@gnu.org> From: Eli Zaretskii To: Daniel Mendler , Daniel Colascione In-Reply-To: <87bjxxw7ko.fsf@daniel-mendler.de> (bug-gnu-emacs@gnu.org) Subject: Re: bug#74615: 30.0.92; js-find-symbol automatically activates ido-mode References: <87bjxxw7ko.fsf@daniel-mendler.de> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74615 Cc: 74615@debbugs.gnu.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: Stefan Monnier > Date: Sat, 30 Nov 2024 07:37:27 +0100 > From: Daniel Mendler via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > js-find-symbol/js--read-symbol reads a symbol via ido-completing-read > and automatically activates ido-mode. For users of other completion > systems (default completion, Icomplete/Fido, Vertico, Helm, ...) this is > not desired. Icomplete/Fido/Vertico/etc. replace Ido and provide similar > behavior for general completing-read. This code is there since the day js.el was added, so I don't think removing the activation of ido-mode is something we can do, because users might expect that by now. Maybe we could make that optional or something. I've added Daniel Colascione to the discussion, in case he has an opinion or comments about this. From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 30 11:21:09 2024 Received: (at 74615) by debbugs.gnu.org; 30 Nov 2024 16:21:10 +0000 Received: from localhost ([127.0.0.1]:48393 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHQDV-0002UZ-Em for submit@debbugs.gnu.org; Sat, 30 Nov 2024 11:21:09 -0500 Received: from dancol.org ([96.126.100.184]:52584) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHQDT-0002UQ-F2 for 74615@debbugs.gnu.org; Sat, 30 Nov 2024 11:21:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: References:In-Reply-To:Subject:CC:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=3a9mbPV3oE3diR1EPh5ZBELjUBmRFslk2SvYki5yAzU=; b=HqA8uNYAf5mlZPMRgM/aavEHCQ IyZneSQL60oFfmMo/C/uPDH9ZG3AYMy5mwSo+0HNuY1qkj2n48WAjiWESz+aaalAXtqytXiOtBa0y BszmHNAmy4/vMBsa3ejlMpl8SJ8JvZohBppL24PaIrlleghY3belEqLddsXfs3P/yYPgihocsatXD /jY10lVUNnzQx5dv6DzzK7amS3RYUtS/nvimb8xBMZVFBytjS63oaCmeJ5lM4pRMHStjPvKkoIlvN Dhx1miubUmZMSN8HxWmINJKd+i+RNxPFYnCRzhCl0osPa5ajKRwF+DFlkKkfDppnn4jceBWleuaLJ D+wHCJLA==; Received: from 2603-9001-4203-1ab2-35f3-78ed-e43f-c0ba.inf6.spectrum.com ([2603:9001:4203:1ab2:35f3:78ed:e43f:c0ba]:60910 helo=[IPv6:::1]) by dancol.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1tHQBC-0001TW-1S; Sat, 30 Nov 2024 11:18:46 -0500 Date: Sat, 30 Nov 2024 11:18:44 -0500 From: Daniel Colascione To: Eli Zaretskii , Daniel Mendler Subject: =?US-ASCII?Q?Re=3A_bug=2374615=3A_30=2E0=2E92=3B_js-find-sym?= =?US-ASCII?Q?bol_automatically_activates_ido-mode?= User-Agent: K-9 Mail for Android In-Reply-To: <86y1119mj4.fsf@gnu.org> References: <87bjxxw7ko.fsf@daniel-mendler.de> <86y1119mj4.fsf@gnu.org> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74615 Cc: 74615@debbugs.gnu.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On November 30, 2024 3:02:55 AM EST, Eli Zaretskii wrote: >> Cc: Stefan Monnier >> Date: Sat, 30 Nov 2024 07:37:27 +0100 >> From: Daniel Mendler via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >>=20 >> js-find-symbol/js--read-symbol reads a symbol via ido-completing-read >> and automatically activates ido-mode=2E For users of other completion >> systems (default completion, Icomplete/Fido, Vertico, Helm, =2E=2E=2E) = this is >> not desired=2E Icomplete/Fido/Vertico/etc=2E replace Ido and provide si= milar >> behavior for general completing-read=2E > >This code is there since the day js=2Eel was added, so I don't think >removing the activation of ido-mode is something we can do, because >users might expect that by now=2E Maybe we could make that optional or >something=2E > >I've added Daniel Colascione to the discussion, in case he has an >opinion or comments about this=2E I think we can safely regard the hard coding of ido here as a bug and swit= ch it to regular conpleting-read without breaking user workflows=2E Not eve= ry behavior users expect is one we should keep=2E I'm supportive of UX chan= ges in the interest of making the system more regular and orthogonal=2E From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 30 12:06:23 2024 Received: (at 74615) by debbugs.gnu.org; 30 Nov 2024 17:06:23 +0000 Received: from localhost ([127.0.0.1]:48854 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHQvG-000573-RX for submit@debbugs.gnu.org; Sat, 30 Nov 2024 12:06:23 -0500 Received: from fhigh-b3-smtp.messagingengine.com ([202.12.124.154]:37207) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHQum-00055h-KE for 74615@debbugs.gnu.org; Sat, 30 Nov 2024 12:05:53 -0500 Received: from phl-compute-11.internal (phl-compute-11.phl.internal [10.202.2.51]) by mailfhigh.stl.internal (Postfix) with ESMTP id 18FEC2540171; Sat, 30 Nov 2024 12:05:47 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-11.internal (MEProxy); Sat, 30 Nov 2024 12:05:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1732986346; x=1733072746; bh=z1AhtHNdvNxfpA0Hvvv23FL417iObJdwFxzVvnCov2g=; b= U7Van5en3wOGJSj7DzezKYlDA8iD8ZHBK550D9F0cTBFziCWismnkaFJAoxQ5zPx GA3Ioxc8dBdccoRjoG6t4tlD0O+5WE6wawxPR/um1U8+crLfGVNFALzLRfBc5JKX zDwQk5UXoUZx8tQnP/rSaVQz26T2/RQDPwJJhthL7diA6gBt32sqrZ6DA6HBsRIi IOzt0t83nei6wSvNH24irVkCfgVQGDDTz0Yl6KXgrjTwEsOB4SST+4HrcTEz14GC On7fgrkR9CRdnAuogq/Ip1EUNQLk1Yqd+x9b/ic826YQQTzbQynNso7Ln74rmc53 PtdT8iZeQJq5mO6+eAhgYw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1732986346; x= 1733072746; bh=z1AhtHNdvNxfpA0Hvvv23FL417iObJdwFxzVvnCov2g=; b=E rhwiU//AP+h6m4qlOKNCu/9CfJZOX1b1xL58c0mXfbfigaGj8ohlImX7rvQkmAjh +FkMs5+WRWQgxVzJ14h6PdJS14FmWbQcXR4eme1LOrJK1uE3aysH0wxoCuU60lYH aNHwxXTPJLDXBMF/9KLsZ+8atiJSntDbaqCabzFSR/Y02Hn0ACR2IxBFcx0fi9z0 fOLCVvelv1jxMawo7hQKKec2uzlfhBEacdQfMg4jUtLmv+DD8j34Mk9pGTwf+Sjv WWXB7HdytFtGlHFgORn9w6fjtOX2xsbwXkjC8GZ3G1IL06NWTXiagl9dDD8/fDS1 uT24Xie4tfMkEbgduYggg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrheehgdelfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnth hsucdlqddutddtmdenucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttddvjeen ucfhrhhomhepffhmihhtrhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvg hvqeenucggtffrrghtthgvrhhnpeetudeljeegheetgfehgeejkeeuhedvveeikeeufedt vddtveefhfdvveegudejheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmh grihhlfhhrohhmpegumhhithhrhiesghhuthhovhdruggvvhdpnhgspghrtghpthhtohep hedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepvghlihiisehgnhhurdhorhhgpd hrtghpthhtohepmhgrihhlsegurghnihgvlhdqmhgvnhgulhgvrhdruggvpdhrtghpthht ohepuggrnhgtohhlsegurghntgholhdrohhrghdprhgtphhtthhopeejgeeiudehseguvg gssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepmhhonhhnihgvrhesihhrohdruhhm ohhnthhrvggrlhdrtggr X-ME-Proxy: Feedback-ID: i07de48aa:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 30 Nov 2024 12:05:44 -0500 (EST) Message-ID: <87dfab4e-d2cf-4e58-8c56-c3a7770e42cc@gutov.dev> Date: Sat, 30 Nov 2024 19:05:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#74615: 30.0.92; js-find-symbol automatically activates ido-mode To: Eli Zaretskii , Daniel Mendler , Daniel Colascione References: <87bjxxw7ko.fsf@daniel-mendler.de> <86y1119mj4.fsf@gnu.org> Content-Language: en-US From: Dmitry Gutov In-Reply-To: <86y1119mj4.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74615 Cc: 74615@debbugs.gnu.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 30/11/2024 10:02, Eli Zaretskii wrote: >> js-find-symbol/js--read-symbol reads a symbol via ido-completing-read >> and automatically activates ido-mode. For users of other completion >> systems (default completion, Icomplete/Fido, Vertico, Helm, ...) this is >> not desired. Icomplete/Fido/Vertico/etc. replace Ido and provide similar >> behavior for general completing-read. > This code is there since the day js.el was added, so I don't think > removing the activation of ido-mode is something we can do FWIW we've removed this command from the default js-mode bindings last year (9cbf0bb3ee88) and haven't heard any complaints, so it might not have too many users these days. Cleaning it up sounds reasonable. From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 30 14:05:30 2024 Received: (at 74615) by debbugs.gnu.org; 30 Nov 2024 19:05:30 +0000 Received: from localhost ([127.0.0.1]:49092 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHSmX-00034w-TI for submit@debbugs.gnu.org; Sat, 30 Nov 2024 14:05:30 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:13234) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHSmV-00034W-Ub for 74615@debbugs.gnu.org; Sat, 30 Nov 2024 14:05:28 -0500 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id E3942442816; Sat, 30 Nov 2024 14:05:21 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1732993520; bh=00o0vnsLLL6hzr4l5QcZYiM/k3wrP7TQaYqg1uSEAVA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=E7qvsR60fzWhMz0N0nYlJTIlervtgsUbAL0mgZItazgko9VwFcZTiprr+Dy+IMkl5 HUqMR+ib4cDnlLHcRnY4ie4PZ4uJ7jnT73VgIUBiJHW4UecOh/BP2KM510QPOjFTIq P3qPVXvRRLDxSNkABRnFlxLWXJcWScT5FWbhQtzBfXGuq/NHVgmcsanm1sDSwp22uv P7YhnlbRWmcrAS+Tn8Zt+XBUjsrT2CclHQ4y9R68GdGpEsjUlTyf5Gv51R3cR5WXny Dn9AZn7zRc6Ql93YWNzLgSAWuoOcadAQai8+RbzbPJjMBLUoYZSktL5IC9Fy0k+wT6 AgcuOkHEJHLsg== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 96AE4442811; Sat, 30 Nov 2024 14:05:20 -0500 (EST) Received: from pastel (104-195-225-43.cpe.teksavvy.com [104.195.225.43]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 6289A1204C5; Sat, 30 Nov 2024 14:05:20 -0500 (EST) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#74615: 30.0.92; js-find-symbol automatically activates ido-mode In-Reply-To: <86y1119mj4.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 30 Nov 2024 10:02:55 +0200") Message-ID: References: <87bjxxw7ko.fsf@daniel-mendler.de> <86y1119mj4.fsf@gnu.org> Date: Sat, 30 Nov 2024 14:05:14 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.002 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74615 Cc: 74615@debbugs.gnu.org, Daniel Mendler , Daniel Colascione X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > This code is there since the day js.el was added, so I don't think > removing the activation of ido-mode is something we can do, because > users might expect that by now. User backward-compatibility is nice but not important enough to imply "cannot do". I think in this case, IDO has lost enough popularity by now that more users will be happy rather than annoyed by the change. > Maybe we could make that optional or something. Users can enable IDO already, and if really some users like IDO for this command but not elsewhere (which seems highly unlikely to me), we can add a small ELisp snippet in NEWS using `advice-add`, for them to copy to their init file. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 07 07:54:22 2024 Received: (at 74615-done) by debbugs.gnu.org; 7 Dec 2024 12:54:22 +0000 Received: from localhost ([127.0.0.1]:45861 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJuKD-0003Ol-U8 for submit@debbugs.gnu.org; Sat, 07 Dec 2024 07:54:22 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35506) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJuKA-0003OR-Fw for 74615-done@debbugs.gnu.org; Sat, 07 Dec 2024 07:54:20 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tJuK4-0005oA-9V; Sat, 07 Dec 2024 07:54:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=YJJAJ724bnnWoczi4RvJfooI+H3VS+mtloSyiahip/o=; b=UaebhyHvTUoj 1f1G/OxOtKCp4K1o81246+LzrhFtD51NsbuNW60IBC0eDOJoza2JijpY+P3YMBuX8d0SrrAOTz7zW iuRi+Tou7854U+Dxru08zMMXiuQGtnU5i6oIaE9iaZRSwgIygAAd3dJ0Eyyj/f0/NItLB2+J0njfg R3GRPKDBrktsEbdoklVOI9Mcepg+gRaBLdgPbNsTesvskUT4KURKgHRoiYRLZJMzG5E8u5R8ZTH/d Hpo1+PAZ2hAdq8jjBQ8uoOs/NRXQvR+qFonhMxlrdQgrISP0pU5WEb4JWdNxmotllD7SuvE0rjgsp Qx3JW2X797XVHMZNf6texA==; Date: Sat, 07 Dec 2024 14:54:09 +0200 Message-Id: <86msh7irgu.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-Reply-To: (message from Stefan Monnier on Sat, 30 Nov 2024 14:05:14 -0500) Subject: Re: bug#74615: 30.0.92; js-find-symbol automatically activates ido-mode References: <87bjxxw7ko.fsf@daniel-mendler.de> <86y1119mj4.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74615-done Cc: 74615-done@debbugs.gnu.org, mail@daniel-mendler.de, dancol@dancol.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: Daniel Mendler , Daniel Colascione > , 74615@debbugs.gnu.org > Date: Sat, 30 Nov 2024 14:05:14 -0500 > > > This code is there since the day js.el was added, so I don't think > > removing the activation of ido-mode is something we can do, because > > users might expect that by now. > > User backward-compatibility is nice but not important enough to imply > "cannot do". I think in this case, IDO has lost enough popularity by > now that more users will be happy rather than annoyed by the change. > > > Maybe we could make that optional or something. > > Users can enable IDO already, and if really some users like IDO for this > command but not elsewhere (which seems highly unlikely to me), we can > add a small ELisp snippet in NEWS using `advice-add`, for them to copy > to their init file. Sounds like there's consensus to make this change, so I've now installed it on the master branch, and I'm therefore closing this bug. From unknown Tue Jun 24 01:40:30 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 05 Jan 2025 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator