GNU bug report logs - #74612
30.0.90; [PATCH] Allow passing nil to treesit-node-match-p

Previous Next

Full log

Message #8 received at 74612 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Yuan Fu <casouri <at> gmail.com>
Cc: 74612 <at> debbugs.gnu.org
Subject: Re: bug#74612: 30.0.90;
 [PATCH] Allow passing nil to treesit-node-match-p
Date: Sat, 30 Nov 2024 09:22:28 +0200

> From: Yuan Fu <casouri <at> gmail.com>
> Date: Fri, 29 Nov 2024 16:38:22 -0800
> 
> Eli, are you ok with this patch on emacs-30? Almost all tree-sitter node functions allows user to pass nil for NODE, so treesit-node-match-p should too.

Does this solve an actual problem you've seen somewhere (and if so,
which problem), or does it solve a potential problem that didn't
actually happen yet?

Also, does CHECK_TS_NODE allow nil or does it currently signal an
error?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.