GNU bug report logs - #74610
31.0.50; Submitting mhtml-ts-mode, treesitter alternative to mhtml-mode

Previous Next

Full log

Message #50 received at 74610 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Vincenzo Pupillo <v.pupillo <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 74610 <at> debbugs.gnu.org
Subject: Re: bug#74610: 31.0.50; Submitting mhtml-ts-mode, treesitter
 alternative to mhtml-mode
Date: Tue, 24 Dec 2024 14:18:39 -0800

> On Dec 24, 2024, at 12:37 AM, Yuan Fu <casouri <at> gmail.com> wrote:
> 
> 
> 
>> On Dec 14, 2024, at 2:37 AM, Vincenzo Pupillo <v.pupillo <at> gmail.com> wrote:
>> 
>> In data mercoledì 11 dicembre 2024 05:54:09 Ora standard dell’Europa centrale, 
>> Yuan Fu ha scritto:
>>>> On Dec 3, 2024, at 6:29 AM, Vincenzo Pupillo <v.pupillo <at> gmail.com> wrote:
>>>> 
>>>> In data domenica 1 dicembre 2024 07:01:21 Ora standard dell’Europa
>>>> centrale,> 
>>>> Yuan Fu ha scritto:
>>>>> It's not uncommon to see different indent offset for CSS and
>>>>> Javascript, so it's a good idea to have separate control for them.
>>>> 
>>>> Is the behavior the same as mhtml-mode, or would you like something like
>>>> this?> 
>>>>  <style>
>>>> 
>>>>                                z {
>>>> 
>>>>                                    color: red;
>>>> 
>>>>                                }
>>>> 
>>>>  </style>
>>>>  <script>
>>>> 
>>>>      function myFunction(p1, p2) {
>>>> 
>>>>          return p1 * p2;
>>>> 
>>>>      }
>>>> 
>>>>  </script>
>>>> 
>>>> The mhtml-ts-mode-js-css-indent-offset variable controls only the
>>>> indentation relative to the <style> and <script> tags.
>>> 
>>> Ah, I see, it’s the offset from the enclosing tag. In that case it should be
>>> fine to use a common variable.
>>> 
>>> Yuan
>> Thank you Yuan.
>> Attached is the revised patch following your previous comments.
>> As I already wrote to Dmitry, I am doing some tests to see if html-ts-mode can 
>> be extended and if there is a way to integrate one multi-language mode into 
>> another multi-language mode.
>> 
>> Vincenzo
>> <0001-Add-mhtml-ts-mode.patch>
> 
> Btw, mhtml-ts-mode--defun-name seems to contain some debugging code? And also I think you should use treesit-node-language.
> 
> Yuan

I just added treesit-aggregated-simple-imenu-settings to master. This variable will allow you to setup Imenu for multiple languages. Please give it a try. I tested locally with mhtml-ts-mode and works well.

Yuan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.