Subject: Re: bug#74606: 31.0.50; Another rsvg API change

From: Eli Zaretskii <[email-masked]>
Date: Sun, 01 Dec 2024 16:55:01 +0200

> From: Manuel Giraud <[email-masked]>
> Cc: [email-masked]
> Date: Sun, 01 Dec 2024 14:09:26 +0100
> 
> Eli Zaretskii <[email-masked]> writes:
> 
> >> Date: Fri, 29 Nov 2024 17:42:19 +0100
> >> From:  Manuel Giraud via "Bug reports for GNU Emacs,
> >>  the Swiss army knife of text editors" <[email-masked]>
> >> 
> >> This is not a bug (yet) per se but here is a new warning I get from
> >> compiling Emacs with librsvg version 2.59.2:
> >> 
> >>   CC       image.o
> >> image.c: In function 'svg_load_image':
> >> image.c:12360:3: warning: 'rsvg_handle_get_pixbuf' is deprecated: Use 'rsvg_handle_get_pixbuf_and_error' instead [-Wdeprecated-declarations]
> >> 12360 |   pixbuf = rsvg_handle_get_pixbuf (rsvg_handle);
> >>       |   ^~~~~~
> >> In file included from /usr/local/include/librsvg-2.0/librsvg/rsvg.h:1332,
> >>                  from image.c:11652:
> >> /usr/local/include/librsvg-2.0/librsvg/rsvg-pixbuf.h:55:12: note: declared here
> >>    55 | GdkPixbuf *rsvg_handle_get_pixbuf (RsvgHandle *handle);
> >>       |            ^~~~~~~~~~~~~~~~~~~~~~
> >
> > The way to fix this is to add code conditioned on librsvg version that
> > uses rsvg_handle_get_pixbuf_and_error when available.
> 
> Ok.  According to this:
> https://gitlab.gnome.org/GNOME/librsvg/-/blob/main/include/librsvg/rsvg-pixbuf.h?ref_type=heads#L52
> 
> this API is deprecated since 2.58 so here is the patch for this change.

Thanks, installed on the emacs-30 branch, and closing the bug.