From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 29 11:42:30 2024 Received: (at submit) by debbugs.gnu.org; 29 Nov 2024 16:42:31 +0000 Received: from localhost ([127.0.0.1]:44194 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tH44c-0002AO-7v for submit@debbugs.gnu.org; Fri, 29 Nov 2024 11:42:30 -0500 Received: from lists.gnu.org ([209.51.188.17]:47510) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tH44Z-0002AF-EH for submit@debbugs.gnu.org; Fri, 29 Nov 2024 11:42:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tH44Y-000690-BQ for bug-gnu-emacs@gnu.org; Fri, 29 Nov 2024 11:42:26 -0500 Received: from ledu-giraud.fr ([51.159.28.247]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tH44W-00077o-4o for bug-gnu-emacs@gnu.org; Fri, 29 Nov 2024 11:42:26 -0500 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=sBWKfi4s GGoity3LmoFdY/GABIciPpdjtB3JJvYzbUU=; h=date:subject:to:from; d=ledu-giraud.fr; b=FFedGHQXH3iv1DrQhW+2GlomwbvvV0GAVWwmJFol4TOoATglIw nTGPpr5+8ZQ/gUQMBCovEq9GeT2OJh1ImMCg== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=sBWKfi4sGGoity3L moFdY/GABIciPpdjtB3JJvYzbUU=; h=date:subject:to:from; d=ledu-giraud.fr; b=lAyrJpjSVN90hrdP+fN+gzs80An1pB24lFPo/l8/G3VhpsQ9bt o7TtFtykoOJUF5HsqNtqyE7OOAoKyvfE23F517EFMSyeLPEx4lkSxEPfs4RTCZsCuTwpgA jFVbjaLiHM7TfR1IWEUo/on7gt/Z6YJLKJY/34SE7F2wRMLdoN2Huy//aqdISJ6uocAhq2 WvdECBtkcdkDmsfapuNHszw1RqMLvDWxuV66ATEWMaWgZDmChAnqgbBWBh5iDyW+NZScp7 2+xMOowZSQ5X44Sk/D2eG81kcQsNFwHL92EpcgOSWZK27hr9dP5guR7SNCqZbYlIPaQ1t2 NkRCBpqh0AKA== Received: from computer (2630.fr [82.65.148.221]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 4e8e570a (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Fri, 29 Nov 2024 17:42:20 +0100 (CET) From: Manuel Giraud To: bug-gnu-emacs@gnu.org Subject: 31.0.50; Another rsvg API change X-Debbugs-Cc: Date: Fri, 29 Nov 2024 17:42:19 +0100 Message-ID: <877c8m9el0.fsf@ledu-giraud.fr> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=51.159.28.247; envelope-from=manuel@ledu-giraud.fr; helo=ledu-giraud.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Hi, This is not a bug (yet) per se but here is a new warning I get from compiling Emacs with librsvg version 2.59.2: CC image.o image.c: In function 'svg_load_image': image.c:12360:3: warning: 'rsvg_handle_get_pixbuf' is deprecated: Use 'rsvg_handle_get_pixbuf_and_error' instead [-Wdeprecated-declarations] 12360 | pixbuf = rsvg_handle_get_pixbuf (rsvg_handle); | ^~~~~~ In file included from /usr/local/include/librsvg-2.0/librsvg/rsvg.h:1332, from image.c:11652: /usr/local/include/librsvg-2.0/librsvg/rsvg-pixbuf.h:55:12: note: declared here 55 | GdkPixbuf *rsvg_handle_get_pixbuf (RsvgHandle *handle); | ^~~~~~~~~~~~~~~~~~~~~~ In GNU Emacs 31.0.50 (build 4, x86_64-unknown-openbsd7.6, X toolkit) of 2024-11-29 built on computer Repository revision: a52ad71cc5d036f1973ff2e504e45992fec3fc04 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101014 System Description: OpenBSD computer 7.6 GENERIC.MP#458 amd64 Configured using: 'configure CC=egcc CPPFLAGS=-I/usr/local/include LDFLAGS=-L/usr/local/lib MAKEINFO=gmakeinfo --prefix=/home/manuel/emacs --bindir=/home/manuel/bin --with-x-toolkit=lucid --with-toolkit-scroll-bars=no --without-cairo --without-compress-install' Configured features: DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG LCMS2 LIBOTF LIBXML2 M17N_FLT MODULES NOTIFY KQUEUE PDUMPER PNG RSVG SQLITE3 THREADS TIFF TREE_SITTER WEBP X11 XAW3D XDBE XFT XIM XINPUT2 XPM LUCID ZLIB Important settings: value of $LC_CTYPE: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Fundamental Minor modes in effect: display-time-mode: t display-battery-mode: t desktop-save-mode: t exwm-randr-mode: t server-mode: t electric-pair-mode: t override-global-mode: t repeat-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t minibuffer-regexp-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: /home/manuel/prog/elisp/exwm/exwm hides /home/manuel/.emacs.d/elpa/exwm-0.32/exwm /home/manuel/prog/elisp/exwm/exwm-xsettings hides /home/manuel/.emacs.d/elpa/exwm-0.32/exwm-xsettings /home/manuel/prog/elisp/exwm/exwm-xim hides /home/manuel/.emacs.d/elpa/exwm-0.32/exwm-xim /home/manuel/prog/elisp/exwm/exwm-workspace hides /home/manuel/.emacs.d/elpa/exwm-0.32/exwm-workspace /home/manuel/prog/elisp/exwm/exwm-randr hides /home/manuel/.emacs.d/elpa/exwm-0.32/exwm-randr /home/manuel/prog/elisp/exwm/exwm-manage hides /home/manuel/.emacs.d/elpa/exwm-0.32/exwm-manage /home/manuel/prog/elisp/exwm/exwm-layout hides /home/manuel/.emacs.d/elpa/exwm-0.32/exwm-layout /home/manuel/prog/elisp/exwm/exwm-input hides /home/manuel/.emacs.d/elpa/exwm-0.32/exwm-input /home/manuel/prog/elisp/exwm/exwm-floating hides /home/manuel/.emacs.d/elpa/exwm-0.32/exwm-floating /home/manuel/prog/elisp/exwm/exwm-systemtray hides /home/manuel/.emacs.d/elpa/exwm-0.32/exwm-systemtray /home/manuel/prog/elisp/exwm/exwm-core hides /home/manuel/.emacs.d/elpa/exwm-0.32/exwm-core /home/manuel/prog/elisp/exwm/exwm-background hides /home/manuel/.emacs.d/elpa/exwm-0.32/exwm-background /home/manuel/.emacs.d/elpa/ada-mode-8.1.0/prj hides /home/manuel/.emacs.d/elpa/gpr-query-1.0.4/prj /home/manuel/.emacs.d/elpa/ef-themes-1.9.0/theme-loaddefs hides /home/manuel/emacs/share/emacs/31.0.50/lisp/theme-loaddefs Features: (shadow sort mail-extr emacsbug org-agenda cus-start on-screen org-indent autoconf autoconf-mode oc-basic org-element org-persist org-id org-element-ast inline avl-tree ol-eww ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect ol-docview doc-view filenotify image-mode exif ol-bibtex bibtex ol-bbdb ol-w3m ol-doi org-link-doi gnus-icalendar org-capture org-refile org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-src ob-comint org-pcomplete org-list org-footnote org-faces org-entities org-version ob-emacs-lisp ob-core ob-eval org-cycle org-table ol org-fold org-fold-core org-keys oc org-loaddefs org-compat org-macs reveal jka-compr tar-mode view conf-mode css-mode sgml-mode facemenu imenu eww vtable mule-util url-queue mm-url sh-script smie treesit executable vc-hg vc-bzr vc-src vc-sccs vc-svn erlang tempo align vc-dir ewoc whitespace macrostep-c cmacexp vc-git diff-mode track-changes gnus-dired vc-cvs vc-rcs log-view log-edit add-log pcvs-util vc vc-dispatcher debbugs-browse bug-reference make-mode time battery desktop frameset exwm-randr xcb-randr exwm exwm-input xcb-keysyms xcb-xkb exwm-manage exwm-floating xcb-cursor xcb-render exwm-layout exwm-workspace exwm-core xcb-ewmh xcb-icccm xcb xcb-xproto xcb-types xcb-debug server ef-kassio-theme ef-themes modus-operandi-theme modus-themes zone speed-type url-http url-auth url-gw nsm ytdious mpdired transmission color calc-bin calc-ext calc calc-loaddefs rect calc-macs supercite regi ebdb-gnus gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime gnutls dig gnus-sum shr pixel-fill kinsoku url-file svg dom gnus-group gnus-undo gnus-start gnus-dbus dbus xml gnus-cloud nnimap nnmail mail-source utf7 nnoo gnus-spec gnus-int gnus-range gnus-win ebdb-message message yank-media puny rfc822 mml mml-sec epa epg rfc6068 epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 gmm-utils mailheader ebdb-mua ebdb-com crm ebdb-format ebdb mailabbrev eieio-opt speedbar ezimage dframe find-func eieio-base timezone icalendar gnus nnheader gnus-util range sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils web-mode derived disp-table erlang-start skeleton cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs slime-asdf grep slime-tramp tramp rx trampver tramp-integration files-x tramp-message tramp-compat xdg shell pcomplete parse-time iso8601 time-date format-spec tramp-loaddefs slime-fancy slime-indentation slime-cl-indent cl-indent slime-trace-dialog slime-fontifying-fu slime-package-fu slime-references slime-compiler-notes-tree advice slime-scratch slime-presentations bridge slime-macrostep macrostep compat slime-mdot-fu slime-enclosing-context slime-fuzzy slime-fancy-trace slime-fancy-inspector slime-c-p-c slime-editing-commands slime-autodoc slime-repl slime-parse slime apropos compile text-property-search etags fileloop generator xref project arc-mode archive-mode noutline outline comint ansi-osc ansi-color ring hyperspec thingatpt elec-pair edmacro kmacro use-package-bind-key bind-key appt diary-lib diary-loaddefs cal-menu calendar cal-loaddefs pcase dired-x dired-aux dired dired-loaddefs use-package-core repeat easy-mmode cus-edit pp cus-load wid-edit ada-mode-autoloads debbugs-autoloads ebdb-autoloads cl-extra help-mode ef-themes-autoloads exwm-autoloads gpr-query-autoloads gnat-compiler-autoloads guru-mode-autoloads hyperbole-autoloads kotl-autoloads hact set hhist on-screen-autoloads osm-autoloads pdf-tools-autoloads rust-mode-autoloads slime-autoloads macrostep-autoloads speed-type-autoloads svg-clock-autoloads tablist-autoloads transmission-autoloads uniquify-files-autoloads info wisi-autoloads xelb-autoloads ytdious-autoloads package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs icons password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd touch-screen tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind kqueue lcms2 dynamic-setting system-font-setting font-render-setting x-toolkit xinput2 x multi-tty move-toolbar make-network-process emacs) Memory information: ((conses 16 964347 636120) (symbols 48 54773 7) (strings 32 259457 38112) (string-bytes 1 6534665) (vectors 16 155489) (vector-slots 8 2164039 45468) (floats 8 604 125) (intervals 56 24628 204) (buffers 992 167)) -- Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 30 06:06:49 2024 Received: (at 74606) by debbugs.gnu.org; 30 Nov 2024 11:06:50 +0000 Received: from localhost ([127.0.0.1]:45698 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHLJJ-0002G0-GT for submit@debbugs.gnu.org; Sat, 30 Nov 2024 06:06:49 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59624) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHLJH-0002Fc-I5 for 74606@debbugs.gnu.org; Sat, 30 Nov 2024 06:06:48 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tHLJC-0005jm-5b; Sat, 30 Nov 2024 06:06:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=U0PMyjWl6dubgkw5IEXpPK738pjji53nb3H9OYSHnuU=; b=pP+qBgM250F3 lODmkLeObKifyXlvfm+6kdmkVhhKCyUo8tqvFg3YzeM620EmH2cArh6t+gT6+xIDdotLCp2iTeUEw j74/yZm3L0U1izNIc9NvJI5Kc1bzJJlIbKLZtM7BoRV2FbAlrwjJ5iZqe4U7ISwhofHdBGWI+9C8g xk+UF1yMvJfZk2XHHd99MW7e0f33o0oHCTn2qCsn/BYgK6OjrFFydvSY2D675VSRyfSJmYa6iueNe k10LyISb+p8kwdfYOes3JcU7HTxD/MENXpwnOYnOsa6Qoi3ngLdjZDdQuaF2Ag+UQCEZR1D6f3OnL XoiKKBIsBkgAefV6iRqUyQ==; Date: Sat, 30 Nov 2024 13:06:39 +0200 Message-Id: <86zflh6kw0.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <877c8m9el0.fsf@ledu-giraud.fr> (bug-gnu-emacs@gnu.org) Subject: Re: bug#74606: 31.0.50; Another rsvg API change References: <877c8m9el0.fsf@ledu-giraud.fr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74606 Cc: 74606@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Fri, 29 Nov 2024 17:42:19 +0100 > From: Manuel Giraud via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > This is not a bug (yet) per se but here is a new warning I get from > compiling Emacs with librsvg version 2.59.2: > > CC image.o > image.c: In function 'svg_load_image': > image.c:12360:3: warning: 'rsvg_handle_get_pixbuf' is deprecated: Use 'rsvg_handle_get_pixbuf_and_error' instead [-Wdeprecated-declarations] > 12360 | pixbuf = rsvg_handle_get_pixbuf (rsvg_handle); > | ^~~~~~ > In file included from /usr/local/include/librsvg-2.0/librsvg/rsvg.h:1332, > from image.c:11652: > /usr/local/include/librsvg-2.0/librsvg/rsvg-pixbuf.h:55:12: note: declared here > 55 | GdkPixbuf *rsvg_handle_get_pixbuf (RsvgHandle *handle); > | ^~~~~~~~~~~~~~~~~~~~~~ The way to fix this is to add code conditioned on librsvg version that uses rsvg_handle_get_pixbuf_and_error when available. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 01 08:09:33 2024 Received: (at 74606) by debbugs.gnu.org; 1 Dec 2024 13:09:33 +0000 Received: from localhost ([127.0.0.1]:50675 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHjhc-0008Nc-UY for submit@debbugs.gnu.org; Sun, 01 Dec 2024 08:09:33 -0500 Received: from ledu-giraud.fr ([51.159.28.247]:13094) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHjhZ-0008NS-HL for 74606@debbugs.gnu.org; Sun, 01 Dec 2024 08:09:31 -0500 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=HJoR+Jdg 0NRLlHu3icWDzSjQDH+g+iylMsmOabB/dQU=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=/lxMs66yM+IDHvKi4CtoGgunhHN4AB Ci9DKkhdcE5Phd50QZ30rAx1uPBNp7isu6ogEeXr/epetojKFBctRNBg== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=HJoR+Jdg0NRLlHu3 icWDzSjQDH+g+iylMsmOabB/dQU=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=DqjTQPKx62U8JLbIPQLQr4WaEU05mH8CelUms3 mzYqYOoFjWSBlGO8JYCqcudr25GQOwl8FigJpRD3wFN89Tw3IPLicmS8h2nEUoQHg/eK5k k+riQPca7RDCcbAqCiH41bCBoLBzMo0Vqyd2tI1YFjxIBbV0djGCtQs453V/vMC6iP1VPX 0UVeayz2UXI+V0qh0SpGDvUPrNki7TeW83GHRF9oaDDmcfqViWhbFovQyl95dB6UV+JH4S yS6u9H250RY73NTTRD62an1WHaE307rVy+fZFyQicw2KzxEpeif1lqS4ine0WYi+vI5Xn0 7fQXzWj3WPWRtIBjMrcrWjNw== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id cc6ddbb7 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sun, 1 Dec 2024 14:09:27 +0100 (CET) From: Manuel Giraud To: Eli Zaretskii Subject: Re: bug#74606: 31.0.50; Another rsvg API change In-Reply-To: <86zflh6kw0.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 30 Nov 2024 13:06:39 +0200") References: <877c8m9el0.fsf@ledu-giraud.fr> <86zflh6kw0.fsf@gnu.org> Date: Sun, 01 Dec 2024 14:09:26 +0100 Message-ID: <87plmbsg6x.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74606 Cc: 74606@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> Date: Fri, 29 Nov 2024 17:42:19 +0100 >> From: Manuel Giraud via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> This is not a bug (yet) per se but here is a new warning I get from >> compiling Emacs with librsvg version 2.59.2: >> >> CC image.o >> image.c: In function 'svg_load_image': >> image.c:12360:3: warning: 'rsvg_handle_get_pixbuf' is deprecated: Use 'rsvg_handle_get_pixbuf_and_error' instead [-Wdeprecated-declarations] >> 12360 | pixbuf = rsvg_handle_get_pixbuf (rsvg_handle); >> | ^~~~~~ >> In file included from /usr/local/include/librsvg-2.0/librsvg/rsvg.h:1332, >> from image.c:11652: >> /usr/local/include/librsvg-2.0/librsvg/rsvg-pixbuf.h:55:12: note: declared here >> 55 | GdkPixbuf *rsvg_handle_get_pixbuf (RsvgHandle *handle); >> | ^~~~~~~~~~~~~~~~~~~~~~ > > The way to fix this is to add code conditioned on librsvg version that > uses rsvg_handle_get_pixbuf_and_error when available. Ok. According to this: https://gitlab.gnome.org/GNOME/librsvg/-/blob/main/include/librsvg/rsvg-pixbuf.h?ref_type=heads#L52 this API is deprecated since 2.58 so here is the patch for this change. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Update-to-version-2.58-of-librsvg-API-bug-74606.patch >From 767bef2e8355c1e3ac514fa1f3a342a36f643316 Mon Sep 17 00:00:00 2001 From: Manuel Giraud Date: Sun, 1 Dec 2024 13:50:05 +0100 Subject: [PATCH] Update to version 2.58 of librsvg API (bug#74606) * src/image.c (init_svg_functions): Declare new function. (svg_load_image): Use it. --- src/image.c | 26 +++++++++++++++++++++++--- 1 file changed, 23 insertions(+), 3 deletions(-) diff --git a/src/image.c b/src/image.c index db7f6acd171..88b0f91413e 100644 --- a/src/image.c +++ b/src/image.c @@ -11706,7 +11706,11 @@ DEF_DLL_FN (void, rsvg_handle_get_dimensions, DEF_DLL_FN (gboolean, rsvg_handle_set_stylesheet, (RsvgHandle *, const guint8 *, gsize, GError **)); # endif +# if LIBRSVG_CHECK_VERSION (2, 58, 0) +DEF_DLL_FN (GdkPixbuf *, rsvg_handle_get_pixbuf_and_error, (RsvgHandle *, GError **)); +# else DEF_DLL_FN (GdkPixbuf *, rsvg_handle_get_pixbuf, (RsvgHandle *)); +# endif DEF_DLL_FN (int, gdk_pixbuf_get_width, (const GdkPixbuf *)); DEF_DLL_FN (int, gdk_pixbuf_get_height, (const GdkPixbuf *)); DEF_DLL_FN (guchar *, gdk_pixbuf_get_pixels, (const GdkPixbuf *)); @@ -11765,8 +11769,11 @@ init_svg_functions (void) #if LIBRSVG_CHECK_VERSION (2, 48, 0) LOAD_DLL_FN (library, rsvg_handle_set_stylesheet); #endif +#if LIBRSVG_CHECK_VERSION (2, 58, 0) + LOAD_DLL_FN (library, rsvg_handle_get_pixbuf_and_error); +#else LOAD_DLL_FN (library, rsvg_handle_get_pixbuf); - +#endif LOAD_DLL_FN (gdklib, gdk_pixbuf_get_width); LOAD_DLL_FN (gdklib, gdk_pixbuf_get_height); LOAD_DLL_FN (gdklib, gdk_pixbuf_get_pixels); @@ -11811,7 +11818,11 @@ init_svg_functions (void) # if LIBRSVG_CHECK_VERSION (2, 48, 0) # undef rsvg_handle_set_stylesheet # endif -# undef rsvg_handle_get_pixbuf +# if LIBRSVG_CHECK_VERSION (2, 58, 0) +# undef rsvg_handle_get_pixbuf_and_error +# else +# undef rsvg_handle_get_pixbuf +# endif # if LIBRSVG_CHECK_VERSION (2, 32, 0) # undef g_file_new_for_path # undef g_memory_input_stream_new_from_data @@ -11852,7 +11863,11 @@ init_svg_functions (void) # if LIBRSVG_CHECK_VERSION (2, 48, 0) # define rsvg_handle_set_stylesheet fn_rsvg_handle_set_stylesheet # endif -# define rsvg_handle_get_pixbuf fn_rsvg_handle_get_pixbuf +# if LIBRSVG_CHECK_VERSION (2, 58, 0) +# define rsvg_handle_get_pixbuf_and_error fn_rsvg_handle_get_pixbuf_and_error +# else +# define rsvg_handle_get_pixbuf fn_rsvg_handle_get_pixbuf +# endif # if LIBRSVG_CHECK_VERSION (2, 32, 0) # define g_file_new_for_path fn_g_file_new_for_path # define g_memory_input_stream_new_from_data \ @@ -12357,8 +12372,13 @@ svg_load_image (struct frame *f, struct image *img, char *contents, /* We can now get a valid pixel buffer from the svg file, if all went ok. */ +#if LIBRSVG_CHECK_VERSION (2, 58, 0) + pixbuf = rsvg_handle_get_pixbuf_and_error (rsvg_handle, &err); + if (err) goto rsvg_error; +#else pixbuf = rsvg_handle_get_pixbuf (rsvg_handle); if (!pixbuf) goto rsvg_error; +#endif g_object_unref (rsvg_handle); xfree (wrapped_contents); -- 2.47.0 --=-=-= Content-Type: text/plain -- Manuel Giraud --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 01 09:55:14 2024 Received: (at 74606-done) by debbugs.gnu.org; 1 Dec 2024 14:55:14 +0000 Received: from localhost ([127.0.0.1]:50902 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHlLu-0005Xx-AY for submit@debbugs.gnu.org; Sun, 01 Dec 2024 09:55:14 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45010) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHlLr-0005UM-IO for 74606-done@debbugs.gnu.org; Sun, 01 Dec 2024 09:55:12 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tHlLm-0000mM-72; Sun, 01 Dec 2024 09:55:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=EY6i+m3ZbGJN9JJESj5aD9tvqZhOqYx5473vcv6Isik=; b=LqfJGGHR5gO9 WYuluwrrf0ZSJ2De4mx5rW7mgQbuFmGTg1Q9+2lDOcL2592uY3GKiBa0nlhijBLRLfJyNaB1P6cNb k+NwYunJaaHrZtt1S6yYTsqYvQ3xF1Sc/ysUCaML0l+hmtnwFYICFfl7B85i4xKoe0bsJhkOyVdj6 Cc6UHLvK54qZTlN/Dqa2z7SSNXWxVTk4WnioFL+PCV19J1kCEHoeNMx34YOlc4Yk1r1BV1mPntBf6 sLEVk9ersdtEHGqgwS04uMUH2J/S94PocwULXTeEOO0+dwgMjBxon9UW4rc+NvsGCvIScRoRe6jah tO87f5lWqlf2Wu3I94Y4QA==; Date: Sun, 01 Dec 2024 16:55:01 +0200 Message-Id: <864j3n5u7u.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <87plmbsg6x.fsf@ledu-giraud.fr> (message from Manuel Giraud on Sun, 01 Dec 2024 14:09:26 +0100) Subject: Re: bug#74606: 31.0.50; Another rsvg API change References: <877c8m9el0.fsf@ledu-giraud.fr> <86zflh6kw0.fsf@gnu.org> <87plmbsg6x.fsf@ledu-giraud.fr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74606-done Cc: 74606-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Manuel Giraud > Cc: 74606@debbugs.gnu.org > Date: Sun, 01 Dec 2024 14:09:26 +0100 > > Eli Zaretskii writes: > > >> Date: Fri, 29 Nov 2024 17:42:19 +0100 > >> From: Manuel Giraud via "Bug reports for GNU Emacs, > >> the Swiss army knife of text editors" > >> > >> This is not a bug (yet) per se but here is a new warning I get from > >> compiling Emacs with librsvg version 2.59.2: > >> > >> CC image.o > >> image.c: In function 'svg_load_image': > >> image.c:12360:3: warning: 'rsvg_handle_get_pixbuf' is deprecated: Use 'rsvg_handle_get_pixbuf_and_error' instead [-Wdeprecated-declarations] > >> 12360 | pixbuf = rsvg_handle_get_pixbuf (rsvg_handle); > >> | ^~~~~~ > >> In file included from /usr/local/include/librsvg-2.0/librsvg/rsvg.h:1332, > >> from image.c:11652: > >> /usr/local/include/librsvg-2.0/librsvg/rsvg-pixbuf.h:55:12: note: declared here > >> 55 | GdkPixbuf *rsvg_handle_get_pixbuf (RsvgHandle *handle); > >> | ^~~~~~~~~~~~~~~~~~~~~~ > > > > The way to fix this is to add code conditioned on librsvg version that > > uses rsvg_handle_get_pixbuf_and_error when available. > > Ok. According to this: > https://gitlab.gnome.org/GNOME/librsvg/-/blob/main/include/librsvg/rsvg-pixbuf.h?ref_type=heads#L52 > > this API is deprecated since 2.58 so here is the patch for this change. Thanks, installed on the emacs-30 branch, and closing the bug. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 02 06:59:07 2024 Received: (at 74606-done) by debbugs.gnu.org; 2 Dec 2024 11:59:07 +0000 Received: from localhost ([127.0.0.1]:54485 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tI551-0003bQ-Af for submit@debbugs.gnu.org; Mon, 02 Dec 2024 06:59:07 -0500 Received: from mail-wm1-f42.google.com ([209.85.128.42]:60657) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tI54z-0003bH-55 for 74606-done@debbugs.gnu.org; Mon, 02 Dec 2024 06:59:05 -0500 Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4349e4e252dso39010045e9.0 for <74606-done@debbugs.gnu.org>; Mon, 02 Dec 2024 03:59:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733140684; x=1733745484; darn=debbugs.gnu.org; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=ohozqM3x+0ncfEnKMFj1+bgFeL1L9anXi9jE3ke8c2A=; b=fvVVVlbJbCcQdbyEiiz8wTj9CHrxXtwmRB7N+PsuOTVvl9kn7VOVO+GG8UcQjVQK0c Vb0jvK2cZqSBcPaLaXcOIfq3kBmNzYSR+v/BJiAexwlbpu9KjmRpXm128WsDn1jCtICK dgwHpZUYLIsaeMKKRc//aOJqf8KsSsMp3LdDJu82dkvn1F3Nh6XAilstBpf8ssz0vk/M Km8fAWkxcdF8Ivnlnd2v20JhkqxrhKvAtuNui+MgfOBnchM3KVNi+0CiYIEij1w/Sdyb ZQQvvhKP5WQePeIkddKljkGJmjA9RdV8i4Y8U40g1Gi5ME0METKxmc5xZpkYRQkIXQ7/ UBcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733140684; x=1733745484; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ohozqM3x+0ncfEnKMFj1+bgFeL1L9anXi9jE3ke8c2A=; b=FIYTP5jxqfpHpor8yJodJ/YcKYJ3HMNt+KWg/hkLa3wGfFil7Y4Em5/j0gwEE5z2DO ZisVmrYSe8EX3/zVSD5ZK4b4iSXsZgWlMe4VviGP0gLiDjDcfWOv6+KZibJ3w0AJ7YVi Nz+ZM71AxguOHp/m9yrrs1O3uArWXKawyfOVR/zTrKT6bpHSmACUc2033RWLx50TZGF4 rOU61clC6UHHoL0JeKpD/VmhJkbHuu+5FO5fXLz5tCcfBeJ83LhSaG1CIYWiyBka95gr Mq5U/Ua7VP8KZ4A/x1nhHmR7ls7FVDN0qGrgJUwy9D72xYdk9NMoAcaRbBCXIGUt+pCG eIaA== X-Forwarded-Encrypted: i=1; AJvYcCWiGirIfptHTU9MqpDlcNVbI/WEBC6pBeaXMMCXklGjLnSW7p1pi3pR8vxuZ7GXwHkWjoPExfb2Rpav@debbugs.gnu.org X-Gm-Message-State: AOJu0Yyswfs9DcPnMwaOozFiOgG55j7LiPy6BsHPAQtNyyRMzJK+zuGz nylgjnqNck5nzzTlimsdABt2wERdWE3Z6O6eRNudleXw4o3pYQ/qv+/Rgasb7wg= X-Gm-Gg: ASbGncu4HrneggGR5vOXwSDhNwfQDeA3Kfq9xW9UTfDLzlQRhMvaWJiIl5l3sfiyMup aFw2/xvagqAUam1IWxHrnHz1cwhAHYnB+dop3vs43rwCPsZ0ItbUym/WS1eXrsy0TYhC6KHK8n6 8ScdA8E1BdxWsvfSnvA440OWfxw7yzxQ5kOCHuRdChFR1q5vDOB3kV1+/n5lmOmbnp64l0+neLQ Mo7e0vsM8EP6y1Jr7XVyvB67JdQEbQo+VH7rM1m6aBt+88lBg== X-Google-Smtp-Source: AGHT+IGY5feEObBbcFfpyc+JoFdTmu+z9YjliN7qbhsK8SaLtbtqQJFVH8exrax8vlMBvrtJyMYi+Q== X-Received: by 2002:a05:600c:4f8f:b0:434:9fb5:fe04 with SMTP id 5b1f17b1804b1-434a9df0803mr164466065e9.28.1733140684333; Mon, 02 Dec 2024 03:58:04 -0800 (PST) Received: from localhost ([105.105.10.178]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-434aa74ea95sm181422605e9.5.2024.12.02.03.58.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Dec 2024 03:58:03 -0800 (PST) From: Osama Rebach To: Eli Zaretskii Subject: Re: bug#74606: 31.0.50; Another rsvg API change In-Reply-To: <864j3n5u7u.fsf@gnu.org> (message from Eli Zaretskii on Sun, 01 Dec 2024 16:55:01 +0200) Date: Mon, 02 Dec 2024 12:58:01 +0100 Message-ID: <87ttbmi9fa.fsf@olaptop-dell.mail-host-address-is-not-set> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74606-done Cc: 74606-done@debbugs.gnu.org, manuel@ledu-giraud.fr X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) rsvg_handle_get_pixbuf_and_error is defined in librsvg 2.59, so the patch should guard against 2.59 instead of 2.58 I have libsrvg 2.58.3 and get this error: image.c: In function 'svg_load_image': image.c:12376:12: warning: implicit declaration of function 'rsvg_handle_get_pixbuf_and_error'; did you mean 'rsvg_handle_get_pixbuf_sub'? [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wimplicit-function-declaration-Wimplicit-function-declaration8;;] 12376 | pixbuf = rsvg_handle_get_pixbuf_and_error (rsvg_handle, &err); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | rsvg_handle_get_pixbuf_sub image.c:12376:10: warning: assignment to 'GdkPixbuf *' {aka 'struct _GdkPixbuf *'} from 'int' makes pointer from integer without a cast [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wint-conversion-Wint-conversion8;;] 12376 | pixbuf = rsvg_handle_get_pixbuf_and_error (rsvg_handle, &err); | ^ CC lastfile.o CCLD temacs GEN ../etc/DOC /nix/store/va7kw1i822h95im4jacci19v0cqajfyf-binutils-2.43.1/bin/ld: image.o: in function `svg_load_image': image.c:(.text+0x7a89): undefined reference to `rsvg_handle_get_pixbuf_and_error' collect2: error: ld returned 1 exit status make[2]: *** [Makefile:745: temacs] Error 1 make[2]: Leaving directory '/build/source/src' make[1]: *** [Makefile:554: src] Error 2 make[1]: Leaving directory '/build/source' make[1]: Entering directory '/build/source' *** *** "make all" failed with exit status 2. *** *** You could try to: *** - run "make bootstrap", which might fix the problem *** - run "make V=1", which displays the full commands invoked by make, *** to further investigate the problem *** make[1]: *** [Makefile:418: advice-on-failure] Error 2 make[1]: Leaving directory '/build/source' make: *** [Makefile:374: all] Error 2 From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 02 08:45:54 2024 Received: (at 74606-done) by debbugs.gnu.org; 2 Dec 2024 13:45:54 +0000 Received: from localhost ([127.0.0.1]:54742 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tI6kL-0000wp-LI for submit@debbugs.gnu.org; Mon, 02 Dec 2024 08:45:53 -0500 Received: from ledu-giraud.fr ([51.159.28.247]:32464) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tI6kJ-0000wf-1q for 74606-done@debbugs.gnu.org; Mon, 02 Dec 2024 08:45:52 -0500 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=Hr4JuvwH sILaJFpvjKiU65G/IV/1Tx+lJBvSOSk+V6Q=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=zUUgBhVCp/Hct5bU/PiTbYDKgSit7Q BbuBEcaQ6fna+YcexB515MSOSZ1GSxHadQH9+guR5QgurMBmLJRQZtAw== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=Hr4JuvwHsILaJFpv jKiU65G/IV/1Tx+lJBvSOSk+V6Q=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=eWBd3D9RW7X8GQg9vJFbZKVNDKyMmMIaE3pk2w PT91mtepqUM0XL93wJYRu5SailWCgfMpu7niGABalh0sMNSNT4oSX+MveRXaVTGGbtVktw tq3b9XPX8o7sS8zemHyWjcnrsyjhUFJTKvDbURF4bfPGRwHLmAU+pODg2uY2bbhW9KwxEM G67W5nY3zKyhXyEa8dNMe8wypRXz5/W/0q3EK71N1CcjCIY92ED3zZ6Bu2Rx2mkdeHYc+l D2bwsbXLa2Fn3l7PvRtbZA3l9A3uUP5h1rMHKfUuYwMQcvqqd6TFea0R9FIDIWzIey/EyM ETCn0dD/owbrKaShvR2fm5uQ== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 13de47ad (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 2 Dec 2024 14:45:50 +0100 (CET) From: Manuel Giraud To: Osama Rebach Subject: Re: bug#74606: 31.0.50; Another rsvg API change In-Reply-To: <87ttbmi9fa.fsf@olaptop-dell.mail-host-address-is-not-set> (Osama Rebach's message of "Mon, 02 Dec 2024 12:58:01 +0100") References: <87ttbmi9fa.fsf@olaptop-dell.mail-host-address-is-not-set> Date: Mon, 02 Dec 2024 14:45:49 +0100 Message-ID: <8734j6fbaq.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74606-done Cc: Eli Zaretskii , 74606-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Osama Rebach writes: > rsvg_handle_get_pixbuf_and_error is defined in librsvg 2.59, so the patch > should guard against 2.59 instead of 2.58 Thanks. I have based my patch on this comment: https://gitlab.gnome.org/GNOME/librsvg/-/blob/main/include/librsvg/rsvg-pixbuf.h?ref_type=heads#L52 Now, I'm looking on the librsvg repo for a more valid source of information. -- Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 02 09:06:36 2024 Received: (at 74606-done) by debbugs.gnu.org; 2 Dec 2024 14:06:36 +0000 Received: from localhost ([127.0.0.1]:54775 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tI74N-00021D-KF for submit@debbugs.gnu.org; Mon, 02 Dec 2024 09:06:35 -0500 Received: from ledu-giraud.fr ([51.159.28.247]:48997) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tI74K-000210-Qw for 74606-done@debbugs.gnu.org; Mon, 02 Dec 2024 09:06:34 -0500 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=fuqy13EH h0fjBArHJJO0G7PnTGuT80uGXM9oHoEGKZU=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=mStxHFDjxPjfUzk2+BVxXB10sfzgjs y2BlNY2uB0vREWJm4tuh/1EEGoq/bNmQ+euGPCLo1d2RgEtW1jgxWpAg== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=fuqy13EHh0fjBArH JJO0G7PnTGuT80uGXM9oHoEGKZU=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=omBpKGiikIW8SphnRy+tM0X6iBOq/Aj+sOK3MV hCgD91PdJTZCgcyGPeR22WKeSRYpjSOMcBZkJhbBH8rcIP4gWKX7W0s1ALUBmWLFUM6y5K 0Vt438c7qbur6hgKYzf2ED7WEaIaBLUJzqA32cPECpKxDlkbw/CA0CcDF7hH3g9Ybdr6fS KIuJNjhFCaskNdN7G9x26QCqq25n3zu+/jpPnKWWItFJnBWEf0nzNJsuvyYw7/p7QIkupu XqlPE1kpnGgKvxFgCE/k9obPgRUJqyumJy71LE3/khDH3ZHczS7L13PXXILYGXfziJxWjr thU+qtlYlnAOu9b4TJYlsl5A== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 777dea91 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 2 Dec 2024 15:06:29 +0100 (CET) From: Manuel Giraud To: Osama Rebach Subject: Re: bug#74606: 31.0.50; Another rsvg API change In-Reply-To: <8734j6fbaq.fsf@ledu-giraud.fr> (Manuel Giraud's message of "Mon, 02 Dec 2024 14:45:49 +0100") References: <87ttbmi9fa.fsf@olaptop-dell.mail-host-address-is-not-set> <8734j6fbaq.fsf@ledu-giraud.fr> Date: Mon, 02 Dec 2024 15:06:28 +0100 Message-ID: <87y10ydvrv.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74606-done Cc: Eli Zaretskii , 74606-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Manuel Giraud writes: > Osama Rebach writes: > >> rsvg_handle_get_pixbuf_and_error is defined in librsvg 2.59, so the patch >> should guard against 2.59 instead of 2.58 > > Thanks. I have based my patch on this comment: > https://gitlab.gnome.org/GNOME/librsvg/-/blob/main/include/librsvg/rsvg-pixbuf.h?ref_type=heads#L52 > > Now, I'm looking on the librsvg repo for a more valid source of > information. Ok, so if I'm not mistaken the patch that introduces the rsvg_handle_get_pixbuf_and_error API (and deprecated the other) is this one: https://gitlab.gnome.org/GNOME/librsvg/-/commit/85cdba02a3e126c1099a62b3d6421ac0cb2d790b On this page, when you unfold the link "Tags containing commit", you can see that 2.58.90 is the first one. So maybe, I should use this version instead. WDYT? The "Deprecated: 2.58" from the header looks like a copy/paste mistake. -- Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 02 09:14:59 2024 Received: (at 74606-done) by debbugs.gnu.org; 2 Dec 2024 14:14:59 +0000 Received: from localhost ([127.0.0.1]:54788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tI7CV-0002Nt-6M for submit@debbugs.gnu.org; Mon, 02 Dec 2024 09:14:59 -0500 Received: from ledu-giraud.fr ([51.159.28.247]:8256) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tI7CS-0002Ng-Fi for 74606-done@debbugs.gnu.org; Mon, 02 Dec 2024 09:14:58 -0500 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=xhACRhWD gteUywJZPS9grMEoJhchGdBWZ25ryz2iHfE=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=zozibxfppJ0VXRM5xejjPCHpXsbpQg ToAKvtR4zrHpfthMgH+r2xulCQKNeF01XJqB8XkHHCbCzu1xPr6aQVBw== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=xhACRhWDgteUywJZ PS9grMEoJhchGdBWZ25ryz2iHfE=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=2Ip+N6dWK9OdvgqWshp1qqobReYzQolwSWGg1Q swgt16xcyrZmByOpJh3+EBeD+dfkYwfeF7RAaNVyPx8et3TzBPIykrvUMXfAuYbitEaaAh R/pcBTAEo5Qh1U2JCZEOLH2/6W16vmzc5+IqYbIqqmPJFYDhBhDOayowXeBz1sBpfdhsvO KXD3aBAtuqhT01ubmliRQNGWu9dslWR8hP7YWn8oQwzfZtB7XzemEEwOfunzuYJgJhkgLM 5PbiSkHUWEM6WYO8FgbVdqvhSpM4s1V1AqSjO1vtk3N+lQgpMbxGWlkhou31whxbIKe1Ct KbFcgEC92xSNPuymasEiDKpA== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id ec64112f (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 2 Dec 2024 15:14:55 +0100 (CET) From: Manuel Giraud To: Osama Rebach Subject: Re: bug#74606: 31.0.50; Another rsvg API change In-Reply-To: <87y10ydvrv.fsf@ledu-giraud.fr> (Manuel Giraud's message of "Mon, 02 Dec 2024 15:06:28 +0100") References: <87ttbmi9fa.fsf@olaptop-dell.mail-host-address-is-not-set> <8734j6fbaq.fsf@ledu-giraud.fr> <87y10ydvrv.fsf@ledu-giraud.fr> Date: Mon, 02 Dec 2024 15:14:54 +0100 Message-ID: <87ttbmdvdt.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74606-done Cc: Eli Zaretskii , 74606-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Manuel Giraud writes: > Manuel Giraud writes: > >> Osama Rebach writes: >> >>> rsvg_handle_get_pixbuf_and_error is defined in librsvg 2.59, so the patch >>> should guard against 2.59 instead of 2.58 >> >> Thanks. I have based my patch on this comment: >> https://gitlab.gnome.org/GNOME/librsvg/-/blob/main/include/librsvg/rsvg-pixbuf.h?ref_type=heads#L52 >> >> Now, I'm looking on the librsvg repo for a more valid source of >> information. > > Ok, so if I'm not mistaken the patch that introduces the > rsvg_handle_get_pixbuf_and_error API (and deprecated the other) is this > one: > https://gitlab.gnome.org/GNOME/librsvg/-/commit/85cdba02a3e126c1099a62b3d6421ac0cb2d790b > > On this page, when you unfold the link "Tags containing commit", you can > see that 2.58.90 is the first one. So maybe, I should use this version > instead. WDYT? > > The "Deprecated: 2.58" from the header looks like a copy/paste > mistake. Here is a patch to be applied on emacs-30. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fix-the-version-of-librsvg-API-change.patch >From 5ffc64b52427309a9e171d54520ecab2e408d62e Mon Sep 17 00:00:00 2001 From: Manuel Giraud Date: Mon, 2 Dec 2024 15:11:52 +0100 Subject: [PATCH] Fix the version of librsvg API change * src/image.c (init_svg_functions, svg_load_image): The version introducing 'rsvg_handle_get_pixbuf_and_error' is 2.58.90 not 2.58.0. --- src/image.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/image.c b/src/image.c index 43220758324..46e8b48aced 100644 --- a/src/image.c +++ b/src/image.c @@ -11688,7 +11688,7 @@ DEF_DLL_FN (void, rsvg_handle_get_dimensions, DEF_DLL_FN (gboolean, rsvg_handle_set_stylesheet, (RsvgHandle *, const guint8 *, gsize, GError **)); # endif -# if LIBRSVG_CHECK_VERSION (2, 58, 0) +# if LIBRSVG_CHECK_VERSION (2, 58, 90) DEF_DLL_FN (GdkPixbuf *, rsvg_handle_get_pixbuf_and_error, (RsvgHandle *, GError **)); # else DEF_DLL_FN (GdkPixbuf *, rsvg_handle_get_pixbuf, (RsvgHandle *)); @@ -11751,7 +11751,7 @@ init_svg_functions (void) #if LIBRSVG_CHECK_VERSION (2, 48, 0) LOAD_DLL_FN (library, rsvg_handle_set_stylesheet); #endif -#if LIBRSVG_CHECK_VERSION (2, 58, 0) +#if LIBRSVG_CHECK_VERSION (2, 58, 90) LOAD_DLL_FN (library, rsvg_handle_get_pixbuf_and_error); #else LOAD_DLL_FN (library, rsvg_handle_get_pixbuf); @@ -11800,7 +11800,7 @@ init_svg_functions (void) # if LIBRSVG_CHECK_VERSION (2, 48, 0) # undef rsvg_handle_set_stylesheet # endif -# if LIBRSVG_CHECK_VERSION (2, 58, 0) +# if LIBRSVG_CHECK_VERSION (2, 58, 90) # undef rsvg_handle_get_pixbuf_and_error # else # undef rsvg_handle_get_pixbuf @@ -11845,7 +11845,7 @@ init_svg_functions (void) # if LIBRSVG_CHECK_VERSION (2, 48, 0) # define rsvg_handle_set_stylesheet fn_rsvg_handle_set_stylesheet # endif -# if LIBRSVG_CHECK_VERSION (2, 58, 0) +# if LIBRSVG_CHECK_VERSION (2, 58, 90) # define rsvg_handle_get_pixbuf_and_error fn_rsvg_handle_get_pixbuf_and_error # else # define rsvg_handle_get_pixbuf fn_rsvg_handle_get_pixbuf @@ -12354,7 +12354,7 @@ svg_load_image (struct frame *f, struct image *img, char *contents, /* We can now get a valid pixel buffer from the svg file, if all went ok. */ -#if LIBRSVG_CHECK_VERSION (2, 58, 0) +#if LIBRSVG_CHECK_VERSION (2, 58, 90) pixbuf = rsvg_handle_get_pixbuf_and_error (rsvg_handle, &err); if (err) goto rsvg_error; #else -- 2.47.0 --=-=-= Content-Type: text/plain -- Manuel Giraud --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 02 09:25:10 2024 Received: (at control) by debbugs.gnu.org; 2 Dec 2024 14:25:10 +0000 Received: from localhost ([127.0.0.1]:54815 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tI7ML-0002yw-Tf for submit@debbugs.gnu.org; Mon, 02 Dec 2024 09:25:10 -0500 Received: from ledu-giraud.fr ([51.159.28.247]:22948) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tI7MK-0002xp-8z for control@debbugs.gnu.org; Mon, 02 Dec 2024 09:25:08 -0500 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=4CdvYha0 Zi/IhPcs3mGM+Zfe6MFEIGUKeOKdCh0rv7A=; h=date:subject:to:from; d=ledu-giraud.fr; b=zCMm9BYTW7GT0f0aVw/lNQr3moCK70InM7vv4wMAA3b8OIbiEF cr1WE7Pm0NbXBblSa2uMBaoAX2ILsu67mZBQ== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=4CdvYha0Zi/IhPcs 3mGM+Zfe6MFEIGUKeOKdCh0rv7A=; h=date:subject:to:from; d=ledu-giraud.fr; b=VlFVvZpXhmbvsxWl5nq6N4HY0rvnJCCcf1dRQ0H1G9AiARb14k ixQd06311tR+nIZIqA7ADo7h+dJUTVyLWbDv4jO9Bgmnf/0VvtrmG6k3+C+53ub3z47Qlg N0do2vChZWRK1+IYOH88oDo1H5A4UmLC7Q2FdEDxxGzhFKYCuGcBNh7y5vGUomfDk52MB4 1UynKY7RUJ3ge3344pRDmgdo8hlNxppj/bEy4zsqntbsXylqidC6ej1F1qU2r+FnBqDA/l mH4FnC53wAzBmZ6XRGELkdj2KZPF2Zo4XE2Rr2SLwyCCdMNTT2BLXFtS2ywlKkdG+YRC6b qjdF1EN6lSLw== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id da6284c1 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Mon, 2 Dec 2024 15:25:07 +0100 (CET) From: Manuel Giraud To: control@debbugs.gnu.org Subject: forcemerge 74647 74606 Date: Mon, 02 Dec 2024 15:25:06 +0100 Message-ID: <87iks2duwt.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) forcemerge 74647 74606 -- Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 02 09:42:08 2024 Received: (at 74606) by debbugs.gnu.org; 2 Dec 2024 14:42:08 +0000 Received: from localhost ([127.0.0.1]:54850 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tI7cl-00040e-DQ for submit@debbugs.gnu.org; Mon, 02 Dec 2024 09:42:07 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46270) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tI7cj-000406-Tx for 74606@debbugs.gnu.org; Mon, 02 Dec 2024 09:42:06 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tI7ce-0000Kt-IB; Mon, 02 Dec 2024 09:42:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=jtW3iw5eJxtFKdKFQO72JxSQjvbDytaBnB2dYMAJoH0=; b=HYVetofzUkSY vusBRSxbg6/LZx30JVnjzE/f0rWrvnbYkGetgRtym1nHdsjPu6kiM27ygtNDmBDKh6SmAEO5jswv+ 7vUahYF3Ub1pnJlrvMXO6dOzCVBqfNI9QKcc9oXF1yaYDTI0durwNyqNjrWDJ5VoF+AiPVPgJhdug NNd3VBP/8qThQp/1PKu9ag8MwAHAHW/X/feGHyFb5V//0TwfddbEcnGq0Qhexi3HO3uP4pZA9N/kE K69UxkF4+YPnSIT6mEX1WryfWi6ApqsoKMTq+t51OV6qNFG8E8cc2HmdLBaJzIYERNT3w8mRwnqcM Z/TwrOeKd3F2N6X/ThNtag==; Date: Mon, 02 Dec 2024 16:41:57 +0200 Message-Id: <86zfle2ll6.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <87ttbmdvdt.fsf@ledu-giraud.fr> (message from Manuel Giraud on Mon, 02 Dec 2024 15:14:54 +0100) Subject: Re: bug#74606: 31.0.50; Another rsvg API change References: <87ttbmi9fa.fsf@olaptop-dell.mail-host-address-is-not-set> <8734j6fbaq.fsf@ledu-giraud.fr> <87y10ydvrv.fsf@ledu-giraud.fr> <87ttbmdvdt.fsf@ledu-giraud.fr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74606 Cc: 74606@debbugs.gnu.org, osamarebach@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Manuel Giraud > Cc: Eli Zaretskii , 74606-done@debbugs.gnu.org > Date: Mon, 02 Dec 2024 15:14:54 +0100 > > > On this page, when you unfold the link "Tags containing commit", you can > > see that 2.58.90 is the first one. So maybe, I should use this version > > instead. WDYT? > > > > The "Deprecated: 2.58" from the header looks like a copy/paste > > mistake. > > Here is a patch to be applied on emacs-30. Thanks, but did you verify that 2.58.90 actually has this function? Is the tarball of that version's sources available somewhere we could check? Alternatively, we could use 2.59, since 2.58.90 is a pretest, so I see no catastrophe if someone sees warnings while using it. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 02 10:02:46 2024 Received: (at 74606) by debbugs.gnu.org; 2 Dec 2024 15:02:46 +0000 Received: from localhost ([127.0.0.1]:56141 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tI7wj-0005NO-OX for submit@debbugs.gnu.org; Mon, 02 Dec 2024 10:02:46 -0500 Received: from ledu-giraud.fr ([51.159.28.247]:18163) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tI7wh-0005N9-6L for 74606@debbugs.gnu.org; Mon, 02 Dec 2024 10:02:44 -0500 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=NaNMj41r OW2r3lrSM+1aLgkrldeLbzltJ0MkMg/pppE=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=OghfX/dxugXqVNv78vhj9NqXiiUlKc 9yV3cIj/m16jlo4P4RWwk4aSqw0Aj1sIigRAubsV/zlN4FM/HAWuBWBw== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=NaNMj41rOW2r3lrS M+1aLgkrldeLbzltJ0MkMg/pppE=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=VI4nPidEs3kDa6V/GvdHB3Wf1hEHpz+878fIbH 0EP8uOsUhIi5nt2LPIpCuBDH+nFJtsJ7P8DOfELWQ+TAjAJ+7bYV/3J6aFcKXse1TdC+Ci S7gmY2YdswFuAXM3RCis1ZV5szPbyzmLMxHoovQj98Hfek3LWuKc0IMWI+xIoII0CwvV3s gMOfyzis42UFdnww+Vogt/EHqowlBBrHWmTIWSvRT96lWpjFhQHvFX2bHVOFwcdo1cVgxk iDQ7xdMEr5q40Z5JS86hP5iz5LIdQPwW2iuFpLGSL1+6aLN5VpyXTtflt2BbrV1DiEUUxz pXr/TqUx8flslk4IhAGir63A== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id d2720f52 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 2 Dec 2024 16:02:41 +0100 (CET) From: Manuel Giraud To: Eli Zaretskii Subject: Re: bug#74606: 31.0.50; Another rsvg API change In-Reply-To: <86zfle2ll6.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 02 Dec 2024 16:41:57 +0200") References: <87ttbmi9fa.fsf@olaptop-dell.mail-host-address-is-not-set> <8734j6fbaq.fsf@ledu-giraud.fr> <87y10ydvrv.fsf@ledu-giraud.fr> <87ttbmdvdt.fsf@ledu-giraud.fr> <86zfle2ll6.fsf@gnu.org> Date: Mon, 02 Dec 2024 16:02:40 +0100 Message-ID: <871pyqjffz.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74606 Cc: 74606@debbugs.gnu.org, osamarebach@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Manuel Giraud >> Cc: Eli Zaretskii , 74606-done@debbugs.gnu.org >> Date: Mon, 02 Dec 2024 15:14:54 +0100 >> >> > On this page, when you unfold the link "Tags containing commit", you can >> > see that 2.58.90 is the first one. So maybe, I should use this version >> > instead. WDYT? >> > >> > The "Deprecated: 2.58" from the header looks like a copy/paste >> > mistake. >> >> Here is a patch to be applied on emacs-30. > > Thanks, but did you verify that 2.58.90 actually has this function? > Is the tarball of that version's sources available somewhere we could > check? No I didn't. I've only used the commit log. > Alternatively, we could use 2.59, since 2.58.90 is a pretest, so I see > no catastrophe if someone sees warnings while using it. I agree: no catastrophe and low probability too. Do you want me to modify the patch to check for 2.59? -- Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 02 10:11:23 2024 Received: (at 74606) by debbugs.gnu.org; 2 Dec 2024 15:11:23 +0000 Received: from localhost ([127.0.0.1]:56154 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tI854-0005q5-Rr for submit@debbugs.gnu.org; Mon, 02 Dec 2024 10:11:23 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36892) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tI851-0005pl-Cx for 74606@debbugs.gnu.org; Mon, 02 Dec 2024 10:11:20 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tI84v-0002e8-Kg; Mon, 02 Dec 2024 10:11:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=36uoIfpKPWQKavsfLFAv9u9+qGmEVCQRwPyXDWHIuZ0=; b=S1bnHg0TCZN5 myHm45sYy+8GaC64mLfv86RADxE6SN7Srn6x4xPNCZQW4RQQk0b5p3QnU2W/LeLNxRLLxCO+Yb75T 5KKKSTmQO2nWPc25nxdPGf0kMA99YO2hrjCEIppI3CfU9qE3Ozk3h/wF0PvR0SBEE0Ejn9PqHQiXo Ts+2fKQ1zeyKdehacgTret03QOlbbXmHKTxT+Mp8QO7tZ3sOqRcZai9aaIR+zuHkJucKkhhS8iLwC iZ6U73JV3r0Z16fRIygrlzebBmSQuG/8d83/Mv/qOhESiiqS6ojYR4map+eRpQuqbK5iWuV0HRoGx mr31BB37iJVDdnsPTwMXDQ==; Date: Mon, 02 Dec 2024 17:11:10 +0200 Message-Id: <86wmgi2k8h.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <871pyqjffz.fsf@ledu-giraud.fr> (message from Manuel Giraud on Mon, 02 Dec 2024 16:02:40 +0100) Subject: Re: bug#74606: 31.0.50; Another rsvg API change References: <87ttbmi9fa.fsf@olaptop-dell.mail-host-address-is-not-set> <8734j6fbaq.fsf@ledu-giraud.fr> <87y10ydvrv.fsf@ledu-giraud.fr> <87ttbmdvdt.fsf@ledu-giraud.fr> <86zfle2ll6.fsf@gnu.org> <871pyqjffz.fsf@ledu-giraud.fr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74606 Cc: 74606@debbugs.gnu.org, osamarebach@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Manuel Giraud > Cc: osamarebach@gmail.com, 74606@debbugs.gnu.org > Date: Mon, 02 Dec 2024 16:02:40 +0100 > > Eli Zaretskii writes: > > >> From: Manuel Giraud > >> Cc: Eli Zaretskii , 74606-done@debbugs.gnu.org > >> Date: Mon, 02 Dec 2024 15:14:54 +0100 > >> > >> > On this page, when you unfold the link "Tags containing commit", you can > >> > see that 2.58.90 is the first one. So maybe, I should use this version > >> > instead. WDYT? > >> > > >> > The "Deprecated: 2.58" from the header looks like a copy/paste > >> > mistake. > >> > >> Here is a patch to be applied on emacs-30. > > > > Thanks, but did you verify that 2.58.90 actually has this function? > > Is the tarball of that version's sources available somewhere we could > > check? > > No I didn't. I've only used the commit log. > > > Alternatively, we could use 2.59, since 2.58.90 is a pretest, so I see > > no catastrophe if someone sees warnings while using it. > > I agree: no catastrophe and low probability too. Do you want me to > modify the patch to check for 2.59? Yes, please. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 02 11:03:41 2024 Received: (at 74606) by debbugs.gnu.org; 2 Dec 2024 16:03:41 +0000 Received: from localhost ([127.0.0.1]:56233 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tI8tg-0000Bj-Gq for submit@debbugs.gnu.org; Mon, 02 Dec 2024 11:03:41 -0500 Received: from ledu-giraud.fr ([51.159.28.247]:10337) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tI8td-0000BQ-HU for 74606@debbugs.gnu.org; Mon, 02 Dec 2024 11:03:38 -0500 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=3u1Nl7QP rH71ZBVg9zHmdqZdotvdiiGQoXF5xWdVuqY=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=wxx+hQToZAoXq23mNVM1g7jUyev1Co Ed/6dX3R55CC1LkZgOwJo1pTsDZoTRdsmxkHMWVdHCTu0QFXksrEVCAA== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=3u1Nl7QPrH71ZBVg 9zHmdqZdotvdiiGQoXF5xWdVuqY=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=zTHSFv/VwFcnTMobD5ovdGQzmqq5+TZd52rt1z gmUTYvzewwWZHC2LzjJ4Ka5xCDU2cXO0eZu+wp6wLtN7hJ9gCcXoGDBaCnGXrg6MAg9XD1 bqKe+pQggeqgFFGeGoxhH0nijiM/lhhiURT5KkB3i0aMbGCUyyms6xvOwEemOSTHq5SezX TjcGofeSrwKzm2Idv859fffn342qNOTyQ4+2JbpCdSPDxOwtbzGts3XjKoYnnPrOD22lY2 +bsMVbKyzx//Rw8pAFPYSY7ZpaqxDfHaXRo6UzAQSEszCIJegLm/jPASYoK7dJEX9K2guX bXgPRGFe1D+Gb26px4J45d9A== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id c7eb2777 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 2 Dec 2024 17:03:35 +0100 (CET) From: Manuel Giraud To: Eli Zaretskii Subject: Re: bug#74606: 31.0.50; Another rsvg API change In-Reply-To: <86wmgi2k8h.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 02 Dec 2024 17:11:10 +0200") References: <87ttbmi9fa.fsf@olaptop-dell.mail-host-address-is-not-set> <8734j6fbaq.fsf@ledu-giraud.fr> <87y10ydvrv.fsf@ledu-giraud.fr> <87ttbmdvdt.fsf@ledu-giraud.fr> <86zfle2ll6.fsf@gnu.org> <871pyqjffz.fsf@ledu-giraud.fr> <86wmgi2k8h.fsf@gnu.org> Date: Mon, 02 Dec 2024 17:03:34 +0100 Message-ID: <87o71uhy21.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74606 Cc: 74606@debbugs.gnu.org, osamarebach@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> From: Manuel Giraud >> Cc: osamarebach@gmail.com, 74606@debbugs.gnu.org >> Date: Mon, 02 Dec 2024 16:02:40 +0100 >> >> Eli Zaretskii writes: >> >> >> From: Manuel Giraud >> >> Cc: Eli Zaretskii , 74606-done@debbugs.gnu.org >> >> Date: Mon, 02 Dec 2024 15:14:54 +0100 >> >> >> >> > On this page, when you unfold the link "Tags containing commit", you can >> >> > see that 2.58.90 is the first one. So maybe, I should use this version >> >> > instead. WDYT? >> >> > >> >> > The "Deprecated: 2.58" from the header looks like a copy/paste >> >> > mistake. >> >> >> >> Here is a patch to be applied on emacs-30. >> > >> > Thanks, but did you verify that 2.58.90 actually has this function? >> > Is the tarball of that version's sources available somewhere we could >> > check? >> >> No I didn't. I've only used the commit log. >> >> > Alternatively, we could use 2.59, since 2.58.90 is a pretest, so I see >> > no catastrophe if someone sees warnings while using it. >> >> I agree: no catastrophe and low probability too. Do you want me to >> modify the patch to check for 2.59? > > Yes, please. Here it is. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fix-the-version-of-librsvg-API-change.patch >From 5f9f676dce22afbc477b555b610dd0adeefa37f2 Mon Sep 17 00:00:00 2001 From: Manuel Giraud Date: Mon, 2 Dec 2024 15:11:52 +0100 Subject: [PATCH] Fix the version of librsvg API change * src/image.c (init_svg_functions, svg_load_image): The first official version that introduces 'rsvg_handle_get_pixbuf_and_error' is 2.59.0 not 2.58.0. --- src/image.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/image.c b/src/image.c index 43220758324..0012abcb451 100644 --- a/src/image.c +++ b/src/image.c @@ -11688,7 +11688,7 @@ DEF_DLL_FN (void, rsvg_handle_get_dimensions, DEF_DLL_FN (gboolean, rsvg_handle_set_stylesheet, (RsvgHandle *, const guint8 *, gsize, GError **)); # endif -# if LIBRSVG_CHECK_VERSION (2, 58, 0) +# if LIBRSVG_CHECK_VERSION (2, 59, 0) DEF_DLL_FN (GdkPixbuf *, rsvg_handle_get_pixbuf_and_error, (RsvgHandle *, GError **)); # else DEF_DLL_FN (GdkPixbuf *, rsvg_handle_get_pixbuf, (RsvgHandle *)); @@ -11751,7 +11751,7 @@ init_svg_functions (void) #if LIBRSVG_CHECK_VERSION (2, 48, 0) LOAD_DLL_FN (library, rsvg_handle_set_stylesheet); #endif -#if LIBRSVG_CHECK_VERSION (2, 58, 0) +#if LIBRSVG_CHECK_VERSION (2, 59, 0) LOAD_DLL_FN (library, rsvg_handle_get_pixbuf_and_error); #else LOAD_DLL_FN (library, rsvg_handle_get_pixbuf); @@ -11800,7 +11800,7 @@ init_svg_functions (void) # if LIBRSVG_CHECK_VERSION (2, 48, 0) # undef rsvg_handle_set_stylesheet # endif -# if LIBRSVG_CHECK_VERSION (2, 58, 0) +# if LIBRSVG_CHECK_VERSION (2, 59, 0) # undef rsvg_handle_get_pixbuf_and_error # else # undef rsvg_handle_get_pixbuf @@ -11845,7 +11845,7 @@ init_svg_functions (void) # if LIBRSVG_CHECK_VERSION (2, 48, 0) # define rsvg_handle_set_stylesheet fn_rsvg_handle_set_stylesheet # endif -# if LIBRSVG_CHECK_VERSION (2, 58, 0) +# if LIBRSVG_CHECK_VERSION (2, 59, 0) # define rsvg_handle_get_pixbuf_and_error fn_rsvg_handle_get_pixbuf_and_error # else # define rsvg_handle_get_pixbuf fn_rsvg_handle_get_pixbuf @@ -12354,7 +12354,7 @@ svg_load_image (struct frame *f, struct image *img, char *contents, /* We can now get a valid pixel buffer from the svg file, if all went ok. */ -#if LIBRSVG_CHECK_VERSION (2, 58, 0) +#if LIBRSVG_CHECK_VERSION (2, 59, 0) pixbuf = rsvg_handle_get_pixbuf_and_error (rsvg_handle, &err); if (err) goto rsvg_error; #else -- 2.47.0 --=-=-= Content-Type: text/plain -- Manuel Giraud --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 02 11:25:17 2024 Received: (at 74606) by debbugs.gnu.org; 2 Dec 2024 16:25:17 +0000 Received: from localhost ([127.0.0.1]:56275 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tI9Eb-0001Wc-2B for submit@debbugs.gnu.org; Mon, 02 Dec 2024 11:25:17 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55040) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tI9EZ-0001WH-NZ for 74606@debbugs.gnu.org; Mon, 02 Dec 2024 11:25:16 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tI9ET-0007Nn-6G; Mon, 02 Dec 2024 11:25:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=VKZj1edWyamnvh5gmK/hBXsoGEoXZuEVD4LR9Bik3UA=; b=qhpqmhlT1pqJ x36EEhLUiVlEA2cSRV/sXj5p33LXHGLTbD/En9/Jhupe5xGOd7XbPz9ESn+2s0B7QdWS1NdaqJuLS ikkofKR6k2+t2qKiOLW8pes6GzaMPRKp2Q4LqX0IknJXSPBjmW7omBZvjiTahxCK/Od+vZbcCCJ2o YefhPXgZUbzp7ipnYdXGdjZyrFISIxqFprE7ikv8IfoAD/k/739uk4CJNKVsWTID+C4V6WiSfHds6 M4XiKgXibwzM36qI4zOh0NqOcouH3bfKXgq6ELhTgOiEjK/ZBfwFSeQSPIBV1y0KfNig4RXScelHd x8yl66grnuDfkIlt5zl0iA==; Date: Mon, 02 Dec 2024 18:24:34 +0200 Message-Id: <86ttbm2gu5.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <87o71uhy21.fsf@ledu-giraud.fr> (message from Manuel Giraud on Mon, 02 Dec 2024 17:03:34 +0100) Subject: Re: bug#74606: 31.0.50; Another rsvg API change References: <87ttbmi9fa.fsf@olaptop-dell.mail-host-address-is-not-set> <8734j6fbaq.fsf@ledu-giraud.fr> <87y10ydvrv.fsf@ledu-giraud.fr> <87ttbmdvdt.fsf@ledu-giraud.fr> <86zfle2ll6.fsf@gnu.org> <871pyqjffz.fsf@ledu-giraud.fr> <86wmgi2k8h.fsf@gnu.org> <87o71uhy21.fsf@ledu-giraud.fr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74606 Cc: 74606@debbugs.gnu.org, osamarebach@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Manuel Giraud > Cc: osamarebach@gmail.com, 74606@debbugs.gnu.org > Date: Mon, 02 Dec 2024 17:03:34 +0100 > > Eli Zaretskii writes: > > >> > Alternatively, we could use 2.59, since 2.58.90 is a pretest, so I see > >> > no catastrophe if someone sees warnings while using it. > >> > >> I agree: no catastrophe and low probability too. Do you want me to > >> modify the patch to check for 2.59? > > > > Yes, please. > > Here it is. Thanks, installed. From unknown Mon Jun 23 07:52:18 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 31 Dec 2024 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator