GNU bug report logs - #74601
[PATCH 0/3] Update clinguin to 2.1.1

Previous Next

Package: guix-patches;

Reported by: Liliana Marie Prikler <liliana.prikler <at> gmail.com>

Date: Fri, 29 Nov 2024 09:46:02 UTC

Severity: normal

Tags: patch

Done: Liliana Marie Prikler <liliana.prikler <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 74601 in the body.
You can then email your comments to 74601 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#74601; Package guix-patches. (Fri, 29 Nov 2024 09:46:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Liliana Marie Prikler <liliana.prikler <at> gmail.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Fri, 29 Nov 2024 09:46:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/3] Update clinguin to 2.1.1
Date: Fri, 29 Nov 2024 10:44:01 +0100
Time flies in Python.
When I initially packaged clinguin, it used to be a prerelease, now we
have 2.1.1.  I tested this on one of their examples, and it works™.

Liliana Marie Prikler (3):
  gnu: Add python-clingexplaid.
  gnu: python-clinguin: Fix homepage.
  gnu: python-clinguin: Update to 2.1.1.

 gnu/packages/potassco.scm | 44 +++++++++++++++++++++++++++++++++++----
 1 file changed, 40 insertions(+), 4 deletions(-)


base-commit: f8979b4bcc8772d02640f6f665b4195380d57df9
-- 
2.46.0





Information forwarded to guix-patches <at> gnu.org:
bug#74601; Package guix-patches. (Fri, 29 Nov 2024 10:34:01 GMT) Full text and rfc822 format available.

Message #8 received at 74601 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: 74601 <at> debbugs.gnu.org
Subject: [PATCH 2/3] gnu: python-clinguin: Fix homepage.
Date: Fri, 29 Nov 2024 09:51:24 +0100
* gnu/packages/potassco.scm (python-clinguin)[home-page]: Use
“https://github.com/potassco/clinguin”.
---
 gnu/packages/potassco.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/potassco.scm b/gnu/packages/potassco.scm
index 57caf6aabc..a421810067 100644
--- a/gnu/packages/potassco.scm
+++ b/gnu/packages/potassco.scm
@@ -726,7 +726,7 @@ (define-public python-clinguin
           python-sphinx-rtd-theme
           python-traitlets
           python-uvicorn))
-   (home-page "https://github.com/potassco/clingraph")
+   (home-page "https://github.com/potassco/clinguin")
    (synopsis "Clingo-based interactive UI")
    (description "Clinguin is a graphical user interface toolkit for clingo,
 which allows user interfaces to be specified entirely as a logic program.")
-- 
2.46.0





Information forwarded to guix-patches <at> gnu.org:
bug#74601; Package guix-patches. (Fri, 29 Nov 2024 10:34:02 GMT) Full text and rfc822 format available.

Message #11 received at 74601 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: 74601 <at> debbugs.gnu.org
Subject: [PATCH 3/3] gnu: python-clinguin: Update to 2.1.1.
Date: Fri, 29 Nov 2024 09:52:13 +0100
* gnu/packages/potassco.scm (python-clinguin): Update to 2.1.1.
[source]: Adjust snippet accordingly.
[inputs]: Add python-clingo-dl and python-clingexplaid.
---
 gnu/packages/potassco.scm | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/potassco.scm b/gnu/packages/potassco.scm
index a421810067..c5d00c9b1c 100644
--- a/gnu/packages/potassco.scm
+++ b/gnu/packages/potassco.scm
@@ -690,7 +690,7 @@ (define-public python-clingraph
 (define-public python-clinguin
   (package
    (name "python-clinguin")
-   (version "1.0.0-beta")
+   (version "2.1.1")
    (source (origin
             (method git-fetch)
             (uri (git-reference
@@ -699,7 +699,7 @@ (define-public python-clinguin
             (file-name (git-file-name name version))
             (sha256
              (base32
-              "032fnzxv6wl01sdq7n2k0ikajpmkg8ihjh5mck1mwjvmis8z16d4"))
+              "0wfgrs8h5i5mmd5sbzca2xw57f3d3ni75775wjkaq6sg0zm9sqjs"))
             (modules '((guix build utils)))
             (snippet
              #~(begin
@@ -708,11 +708,14 @@ (define-public python-clinguin
                    ;; some typo squatter hosted
                    ;; a package named tk
                    (("tk") "")
-                   (("typing") "typing;python_version<\"3.5\""))))))
+                   ;; XXX: python-clingo-dl installs clingodl instead…
+                   (("clingo-dl") "clingodl"))))))
    (build-system pyproject-build-system)
    (propagated-inputs
     (list python-clingo
+          python-clingo-dl
           python-clorm
+          python-clingexplaid
           python-clingraph
           python-fastapi
           python-httpx
-- 
2.46.0





Information forwarded to guix-patches <at> gnu.org:
bug#74601; Package guix-patches. (Fri, 29 Nov 2024 10:34:03 GMT) Full text and rfc822 format available.

Message #14 received at 74601 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: 74601 <at> debbugs.gnu.org
Subject: [PATCH 1/3] gnu: Add python-clingexplaid.
Date: Fri, 29 Nov 2024 08:31:31 +0100
* gnu/packages/potassco.scm (python-clingexplaid): New variable.
---
 gnu/packages/potassco.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/potassco.scm b/gnu/packages/potassco.scm
index ec990f1382..57caf6aabc 100644
--- a/gnu/packages/potassco.scm
+++ b/gnu/packages/potassco.scm
@@ -756,3 +756,36 @@ (define-public python-clintest
 outcome while solving to abort the search for solutions once the outcome is
 certain.")
     (license license:expat)))
+
+(define-public python-clingexplaid
+  (package
+    (name "python-clingexplaid")
+    (version "1.1.0")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/potassco/clingo-explaid")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32 "1s80cs3clvz26r7cvjprlk6zip7yqswwhzzwmmrv5mf5p89ymrgm"))))
+    (build-system pyproject-build-system)
+    (arguments
+     (list #:test-flags #~(list "-k" "not test_main")
+           #:phases #~(modify-phases %standard-phases
+                        (add-after 'unpack 'fix-pyproject-toml
+                          (lambda _
+                            (substitute* "pyproject.toml"
+                              (("dynamic = .*" all)
+                               (string-append "version = \""
+                                              #$version
+                                              "\"\n"))
+                              (("\"autoflake\",") "")))))))
+    (propagated-inputs (list python-clingo))
+    (native-inputs (list python-pytest))
+    (home-page "https://github.com/potassco/clingo-explaid")
+    (synopsis "Develop explanation systems with Clingo")
+    (description "This package provides tools to develop explanation systems
+with clingo.  It allows extracting minimal unsatisfiable subsets and
+unsatisfiable constraints.")
+    (license license:expat)))
-- 
2.46.0





Information forwarded to guix-patches <at> gnu.org:
bug#74601; Package guix-patches. (Sat, 30 Nov 2024 20:10:02 GMT) Full text and rfc822 format available.

Message #17 received at 74601 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 74601 <at> debbugs.gnu.org
Subject: [PATCH 0/3] Update clinguin to 2.1.1
Date: Sat, 30 Nov 2024 20:08:08 +0000
[Message part 1 (text/plain, inline)]
Hi,

The series looks nice and LGFM for me

One pick on this:
--8<---------------cut here---------------start------------->8---
+     (list #:test-flags #~(list "-k" "not test_main")
--8<---------------cut here---------------end--------------->8---
May you provide a comment why it's deselected?

By the way PiPI https://pypi.org/project/clingexplaid/#files contains
tests and set version, so you may reduce package complexity if you pull
from there, no need to adjust version in pyproject.toml.

--
Thanks,
Oleg
[signature.asc (application/pgp-signature, inline)]

Reply sent to Liliana Marie Prikler <liliana.prikler <at> gmail.com>:
You have taken responsibility. (Sun, 08 Dec 2024 13:33:02 GMT) Full text and rfc822 format available.

Notification sent to Liliana Marie Prikler <liliana.prikler <at> gmail.com>:
bug acknowledged by developer. (Sun, 08 Dec 2024 13:33:03 GMT) Full text and rfc822 format available.

Message #22 received at 74601-done <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: 74601-done <at> debbugs.gnu.org
Subject: Re: [PATCH 3/3] gnu: python-clinguin: Update to 2.1.1.
Date: Sun, 08 Dec 2024 14:32:03 +0100
Am Freitag, dem 29.11.2024 um 09:52 +0100 schrieb Liliana Marie
Prikler:
> * gnu/packages/potassco.scm (python-clinguin): Update to 2.1.1.
> [source]: Adjust snippet accordingly.
> [inputs]: Add python-clingo-dl and python-clingexplaid.
> ---
Pushed as a4bdae0f4787a0b7247f7f83d3e73aaae429604a.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 06 Jan 2025 12:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 165 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.