GNU bug report logs - #74597
[PATCH] gnu: bluez: Update to 5.79.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 74597 in the body.
You can then email your comments to 74597 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Julian Flake <flake <at> uni-koblenz.de>
To: guix-patches <at> gnu.org
Cc: Julian Flake <flake <at> uni-koblenz.de>
Subject: [PATCH] gnu: bluez: Update to 5.79.
Date: Thu, 28 Nov 2024 22:11:51 +0100

* gnu/packages/linux.scm (bluez): Update to 5.79.

Change-Id: I5928664f929d1bda6e8c8c5e37cb9020a9889881
---
 gnu/packages/linux.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index f7e7126c3d..a7c2678540 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -6203,7 +6203,7 @@ (define-public sbc
 (define-public bluez
   (package
     (name "bluez")
-    (version "5.72")
+    (version "5.79")
     (source (origin
               (method url-fetch)
               (uri (string-append
@@ -6211,7 +6211,7 @@ (define-public bluez
                     version ".tar.xz"))
               (sha256
                (base32
-                "0vjk4ihywzv8k07bxq7clqgi2afrw54nfp0gcnxw35m98nipz7a9"))))
+                "12pal1m4xlr8k7kxb6isv5lbaca2wc5zcgy0907wfwcz78qaar21"))))
     (build-system gnu-build-system)
     (arguments
      (list

base-commit: 294386674c417355a24586fab5528c643d495b86
-- 
2.46.0

Message #8 received at 74597 <at> debbugs.gnu.org (full text, mbox):

From: Julian Flake <flake <at> uni-koblenz.de>
To: 74597 <at> debbugs.gnu.org
Subject: Reason for why I'm interested
Date: Tue, 03 Dec 2024 14:28:04 +0100

The reason, why I'm interested in this update is that I hope it 
fixes an issue I have with my headset:

https://github.com/bluez/bluez/issues/973

Best Regards,
nutcase

Message #11 received at 74597 <at> debbugs.gnu.org (full text, mbox):

From: Dakota Logan <dklogan <at> riseup.net>
To: 74597 <at> debbugs.gnu.org
Date: Tue, 17 Dec 2024 03:48:08 +0000

I'm having the same issue so would love to see it fixed!

Message #14 received at 74597 <at> debbugs.gnu.org (full text, mbox):

From: "Danny Milosavljevic" <dannym <at> scratchpost.org>
To: 74597 <at> debbugs.gnu.org
Cc: w <at> wmeyer.eu, leo <at> famulari.name
Subject: Confirming problem
Date: Sat, 21 Dec 2024 17:45:45 +0100 (CET)

Hi,

I have the same problem with Linux 6.11.11 and bluez 5.72.

I would like the fix to be in guix, but unfortunately it would cause
2455 packages (including erlang, gtk, gnome, gdm, qemu, qt, kde,
mate and enlightenment) that depend on bluez to rebuild (WTF!).

And I don't think there are a lot of Guix users using bluetooth.

So I should not just apply it to master as it is.

We could make a graft with just the patch[1]--even though it's not a
security patch. What do you all think? Make an exception here?

The cause was that the kernel reverted a bugfix. The bugfix would have
done a link type fixup (see below). But it was a userspace-visible change
(broke the interface guarantee between kernel and user space) and so
that's a no-no, and hence was reverted. So now someone else has to do
the bugfix in userspace--in this case bluez[1].

Reverted bugfix was[2]:

    If two Bluetooth devices both support BR/EDR and BLE, and also
    support Secure Connections, then they only need to pair once.
    The LTK generated during the LE pairing process may be converted
    into a BR/EDR link key for BR/EDR transport, and conversely, a
    link key generated during the BR/EDR SSP pairing process can be
    converted into an LTK for LE transport. Hence, the link type of
    the link key and LTK is not fixed, they can be either an LE LINK
    or an ACL LINK.

Because the keys are (and were) stored on disk, userspace will always
have to do this kind of sanity check anyway--so this patch[1] will
likely stay in bluez releases forever.

[1] <https://github.com/bluez/bluez/commit/366a8c522b648f47147de4852c5c030d69b916b3.patch>
[2] <https://www.kernel.org/pub/linux/kernel/v5.x/ChangeLog-5.10.206>, search for "59b047bc98084f8af2c41483e4d68a5adf2fa7f7"

Message #17 received at 74597 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Z572 <z572 <at> z572.online>
Cc: 74597 <at> debbugs.gnu.org, 76311 <at> debbugs.gnu.org,
 Julian Flake <flake <at> uni-koblenz.de>
Subject: Re: [bug#76311] Request for merging "kernel-team" branch
Date: Thu, 8 May 2025 20:40:44 -0400

On Thu, May 08, 2025 at 08:28:39PM +0800, Z572 wrote:
> i think bluez update should go to kernel-team branch
> https://issues.guix.gnu.org/74597 

I've added the bluez update to the kernel-team branch:

https://git.savannah.gnu.org/cgit/guix.git/log/?h=kernel-team

We can check it's progress here:

https://qa.guix.gnu.org/branch/kernel-team

Hopefully the QA service will pick up the changes on the branch and
build them for us. This is my first time participating in the team
branch QA process so I'm unfamiliar with the details.

Message #20 received at 74597 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Julian Flake <flake <at> uni-koblenz.de>
Cc: 74597 <at> debbugs.gnu.org, Z572 <z572 <at> z572.online>, Wilko Meyer <w <at> wmeyer.eu>
Subject: Re: [bug#74597] [PATCH] gnu: bluez: Update to 5.79.
Date: Sun, 11 May 2025 11:14:27 -0400

On Thu, Nov 28, 2024 at 10:11:51PM +0100, Julian Flake wrote:
> * gnu/packages/linux.scm (bluez): Update to 5.79.

Thanks for this patch!

I added it to the 'kernel-team' Git branch where it is being built now
on the build farm:

https://qa.guix.gnu.org/branch/kernel-team

However, with this patch, the bluez package fails to build, because the
installation procedure tries to write to /etc/bluetooth and fails:

------
[...]
 /gnu/store/7h0mnlwalw23j9jmvz5n1i5mqkgb4d06-coreutils-9.1/bin/mkdir -p '/etc/bluetooth'
/gnu/store/7h0mnlwalw23j9jmvz5n1i5mqkgb4d06-coreutils-9.1/bin/mkdir: cannot create directory ‘/etc/bluetooth’: Permission denied
make[2]: *** [Makefile:11515: install-confDATA] Error 1
make[1]: *** [Makefile:12389: install-am] Error 2
make: *** [Makefile:12382: install] Error 2
error: in phase 'install': uncaught exception:
%exception #<&invoke-error program: "make" arguments: ("install") exit-status: 2 term-signal: #f stop-signal: #f> 
phase `install' failed after 0.6 seconds
------

I worked around this by changing the value of sysconfdir:

------
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index eff6f7978a9..7d8eba34c66 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -6633,7 +6633,7 @@ (define-public bluez
     (arguments
      (list
       #:configure-flags
-      #~(list "--sysconfdir=/etc"
+      #~(list (string-append "--sysconfdir=" #$output "/etc")
               "--localstatedir=/var"
               "--enable-library"
               "--enable-wiimote"
------

... would that work correctly, or will bluez then look for run-time
configuration in the wrong location? I think that bluez should look for
configuration files in the well-known location /etc/bluetooth. Do you
agree?

Also, with that change, the installation procedure then fails to write
to /var:

------
[...]
install -dm555 /gnu/store/q084wf1nvq0zjs9bym5wj3l5f11nw41h-bluez-5.79/etc/bluetooth
install -dm700 /var/lib/bluetooth
install: cannot create directory ‘/var’: Permission denied
make[3]: *** [Makefile:13927: bluetoothd-fix-permissions] Error 1
make[2]: *** [Makefile:13172: install-data-am] Error 2
make[1]: *** [Makefile:12389: install-am] Error 2
make: *** [Makefile:12382: install] Error 2
error: in phase 'install': uncaught exception:
%exception #<&invoke-error program: "make" arguments: ("install") exit-status: 2 term-signal: #f stop-signal: #f> 
phase `install' failed after 0.9 seconds
------

What do you think?

Do you remember if you saw these problems when you made this patch, and
they are caused by a changed in the build tools, or is this the first
test of the patch?

Message #23 received at 74597 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Christopher Baines <mail <at> cbaines.net>
Cc: Dariqq <dariqq <at> posteo.net>, 74597 <at> debbugs.gnu.org, Z572 <z572 <at> z572.online>,
 Julian Flake <flake <at> uni-koblenz.de>, 76311 <at> debbugs.gnu.org
Subject: Re: [bug#76311] Request for merging "kernel-team" branch
Date: Sun, 11 May 2025 12:29:39 -0400

[Message part 1 (text/plain, inline)]

On Sun, May 11, 2025 at 10:49:42AM +0100, Christopher Baines wrote:
> Note that bluez looks to fail to build
> https://data.qa.guix.gnu.org/gnu/store/8j5qlh703367i6lwmnfggsh2s7s5cwf8-bluez-5.79.drv

With the help of several people on #guix IRC, I pushed an amended bluez
patch co-authored by Dariqq:

https://git.savannah.gnu.org/cgit/guix.git/commit/?h=kernel-team&id=cf4f234f215355ad8b34bfd7e4551221838b0ed4

This bluez package now builds successfully. Bluetoothers, please test!

[signature.asc (application/pgp-signature, inline)]

Message #26 received at 74597 <at> debbugs.gnu.org (full text, mbox):

From: Julian Flake <flake <at> uni-koblenz.de>
To: Leo Famulari <leo <at> famulari.name>
Cc: 74597 <at> debbugs.gnu.org, Z572 <z572 <at> z572.online>, Wilko Meyer <w <at> wmeyer.eu>
Subject: Re: [bug#74597] [PATCH] gnu: bluez: Update to 5.79.
Date: Sun, 11 May 2025 19:43:57 +0200

[Message part 1 (text/plain, inline)]

Hi Leo,

On Sun, May 11 2025, Leo Famulari wrote:

> Do you remember if you saw these problems when you made this 
> patch, and
> they are caused by a changed in the build tools, or is this the 
> first
> test of the patch?

no, actually I don't remember that, but I get the same now with 
5.79, also if rebased on current master. I get another problem 
with a newer bluez version of 5.82.

Best Regards,
Julian Flake (nutcase)

[signature.asc (application/pgp-signature, inline)]

Message #29 received at 74597 <at> debbugs.gnu.org (full text, mbox):

From: Greg Hogan <code <at> greghogan.com>
To: Leo Famulari <leo <at> famulari.name>
Cc: 76311 <at> debbugs.gnu.org, Christopher Baines <mail <at> cbaines.net>,
 Z572 <z572 <at> z572.online>, Dariqq <dariqq <at> posteo.net>, 74597 <at> debbugs.gnu.org,
 Julian Flake <flake <at> uni-koblenz.de>
Subject: Re: [bug#76311] Request for merging "kernel-team" branch
Date: Sun, 11 May 2025 15:00:31 -0400

Are we ungrafting eudev on the kernel-team branch? The replacement was
only added recently.

Message #32 received at 74597 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Julian Flake <flake <at> uni-koblenz.de>
Cc: 74597 <at> debbugs.gnu.org, Z572 <z572 <at> z572.online>, Wilko Meyer <w <at> wmeyer.eu>
Subject: Re: [bug#74597] [PATCH] gnu: bluez: Update to 5.79.
Date: Sun, 11 May 2025 16:26:04 -0400

On Sun, May 11, 2025 at 07:43:57PM +0200, Julian Flake wrote:
> no, actually I don't remember that, but I get the same now with 5.79, also
> if rebased on current master. I get another problem with a newer bluez
> version of 5.82.

Yeah, I saw that other problem with 5.82.

If 5.79 addresses the bug that you originally set out to fix, I think
it's okay to stay with 5.79 for now, assuming it works for you and any
other Bluetooth testers.

Given the ubiquity of Bluetooth, maybe there are enough users in Guix to
create a Bluetooth team or something like that, since it is low enough
in the package graph that we can't change it on the master branch. But
it's okay in the kernel-team for now.

Message #35 received at 74597 <at> debbugs.gnu.org (full text, mbox):

From: Julian Flake <flake <at> uni-koblenz.de>
To: Leo Famulari <leo <at> famulari.name>
Cc: Dariqq <dariqq <at> posteo.net>, Z572 <z572 <at> z572.online>,
 Christopher Baines <mail <at> cbaines.net>, 76311 <at> debbugs.gnu.org,
 74597 <at> debbugs.gnu.org
Subject: Re: [bug#76311] Request for merging "kernel-team" branch
Date: Sat, 17 May 2025 09:06:29 +0200

[Message part 1 (text/plain, inline)]

Dear Leo,

On Sun, May 11 2025, Leo Famulari wrote:

> This bluez package now builds successfully. Bluetoothers, please 
> test!

Thanks for merging this already into master. Everything that 
worked before, still works, but my issue remains. However, the 
error message seems to have changed (now it's "Connection Failed: 
Operation already in progress bluez").

I couldn't find any other related upstream issue, yet. I probably 
will investigate further, when I find the time.

Since this issue's original subject was to update bluez to 5.79 , 
it can be closed now? Or should we leave it open, until my (and 
others') issue is resolved?

Best Regards,
nutcase

[signature.asc (application/pgp-signature, inline)]

Message #40 received at 74597-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Julian Flake <flake <at> uni-koblenz.de>
Cc: 74597-done <at> debbugs.gnu.org
Subject: Re: [bug#76311] Request for merging "kernel-team" branch
Date: Tue, 20 May 2025 20:45:02 -0400

On Sat, May 17, 2025 at 09:06:29AM +0200, Julian Flake wrote:
> Thanks for merging this already into master. Everything that worked before,
> still works, but my issue remains. However, the error message seems to have
> changed (now it's "Connection Failed: Operation already in progress bluez").

That's too bad. Unfortunatley I don't use Bluetooth on Linux so I don't
know how to help.

> Since this issue's original subject was to update bluez to 5.79 , it can be
> closed now? Or should we leave it open, until my (and others') issue is
> resolved?

Yes, since this ticket was about updating the package, we can close it.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.