Package: guix-patches;
Reported by: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Date: Thu, 28 Nov 2024 06:25:01 UTC
Severity: normal
Tags: patch
Done: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Bug is archived. No further changes may be made.
Message #20 received at 74572 <at> debbugs.gnu.org (full text, mbox):
From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com> To: 74572 <at> debbugs.gnu.org Cc: Maxim Cournoyer <maxim.cournoyer <at> gmail.com> Subject: [PATCH 5/6] gnu: openmpi-5: Reformat. Date: Thu, 28 Nov 2024 16:47:56 +0900
Better comply to our 80 characters maximum width guideline. * gnu/packages/mpi.scm (openmpi-5): Reformat. Change-Id: Ib164c4d7dae7bece60738787fd950003fb75e057 --- gnu/packages/mpi.scm | 103 ++++++++++++++++++++++--------------------- 1 file changed, 53 insertions(+), 50 deletions(-) diff --git a/gnu/packages/mpi.scm b/gnu/packages/mpi.scm index 41e57c3012..67e12657db 100644 --- a/gnu/packages/mpi.scm +++ b/gnu/packages/mpi.scm @@ -328,59 +328,62 @@ (define-public openmpi-5 (sha256 (base32 "0mw1z4ppnlvxngwd58kl5q26qmvf3bgjkd4r8wjpqis3pky86hdx")))) - (inputs (modify-inputs (package-inputs openmpi) - ;; As of Open MPI 5.0.X, PMIx is used to communicate - ;; with SLURM, so SLURM'S PMI is no longer needed. - (delete "slurm") - (append ucx) ;for Infiniband support - (append openpmix) ;for PMI support (launching via "srun") - (append prrte))) ;for PMI support (launching via "srun") - (native-inputs (modify-inputs (package-native-inputs openmpi) - (append python))) + (inputs + (modify-inputs (package-inputs openmpi) + ;; As of Open MPI 5.0.X, PMIx is used to communicate with SLURM, so + ;; SLURM'S PMI is no longer needed. + (delete "slurm") + (append ucx) ;for Infiniband support + (append openpmix) ;for PMI support (launching via "srun") + (append prrte))) ;for PMI support (launching via "srun") + (native-inputs + (modify-inputs (package-native-inputs openmpi) + (append python))) (outputs '("out" "debug")) (arguments - (list #:configure-flags - #~(list "--enable-mpi-ext=affinity" ;cr doesn't work - "--with-sge" - "--disable-static" - - #$@(if (package? (this-package-input "valgrind")) - #~("--enable-memchecker" - "--with-valgrind") - #~("--without-valgrind")) - - "--with-hwloc=external" - "--with-libevent" - - ;; This replaces --enable-mpirun-prefix-by-default wich is deprecated - ;; since 5.x. - "--enable-prte-prefix-by-default" - - ;; Enable support for the 'Process Management Interface for Exascale' - ;; (PMIx) used e.g. by Slurm for the management communication and - ;; coordination of MPI processes. - (string-append "--with-pmix=" #$(this-package-input "openpmix")) - (string-append "--with-prrte=" #$(this-package-input "prrte")) - - ;; Since 5.x, Infiniband support is provided by ucx. - ;; See https://docs.open-mpi.org/en/main/release-notes/networks.html#miscellaneous-network-notes - (string-append "--with-ucx=" #$(this-package-input "ucx"))) - - #:phases - #~(modify-phases %standard-phases - (add-before 'build 'remove-absolute - (lambda _ - ;; Remove compiler absolute file names (OPAL_FC_ABSOLUTE - ;; etc.) to reduce the closure size. See - ;; <https://lists.gnu.org/archive/html/guix-devel/2017-07/msg00388.html> - ;; and - ;; <https://www.mail-archive.com/users <at> lists.open-mpi.org//msg31397.html>. - (substitute* '("oshmem/tools/oshmem_info/param.c" - "ompi/tools/ompi_info/param.c") - (("_ABSOLUTE") ""))))) - - #:disallowed-references (list (canonical-package gcc)))))) + (list + #:configure-flags + #~(list "--enable-mpi-ext=affinity" ;cr doesn't work + "--with-sge" + "--disable-static" + + #$@(if (package? (this-package-input "valgrind")) + #~("--enable-memchecker" + "--with-valgrind") + #~("--without-valgrind")) + + "--with-hwloc=external" + "--with-libevent" + + ;; This replaces --enable-mpirun-prefix-by-default wich is + ;; deprecated since 5.x. + "--enable-prte-prefix-by-default" + + ;; Enable support for the 'Process Management Interface for + ;; Exascale' (PMIx) used e.g. by Slurm for the management + ;; communication and coordination of MPI processes. + (string-append "--with-pmix=" #$(this-package-input "openpmix")) + (string-append "--with-prrte=" #$(this-package-input "prrte")) + + ;; Since 5.x, Infiniband support is provided by ucx. See + ;; https://docs.open-mpi.org/en/main/release-notes/networks.html#miscellaneous-network-notes + (string-append "--with-ucx=" #$(this-package-input "ucx"))) + + #:phases + #~(modify-phases %standard-phases + (add-before 'build 'remove-absolute + (lambda _ + ;; Remove compiler absolute file names (OPAL_FC_ABSOLUTE etc.) + ;; to reduce the closure size. See + ;; <https://lists.gnu.org/archive/html/guix-devel/2017-07/msg00388.html> + ;; and + ;; <https://www.mail-archive.com/users <at> lists.open-mpi.org//msg31397.html>. + (substitute* '("oshmem/tools/oshmem_info/param.c" + "ompi/tools/ompi_info/param.c") + (("_ABSOLUTE") ""))))) + + #:disallowed-references (list (canonical-package gcc)))))) (define-public openmpi-c++ (package/inherit openmpi -- 2.46.0
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.