GNU bug report logs - #74565
[PATCH] import: egg: Fix recursive imports.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 74565 in the body.
You can then email your comments to 74565 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: lobo <at> quiltro.org
To: bug-guix <at> gnu.org
Cc: ekaitz <at> elenq.tech
Subject: `guix import egg' fails to import packages recursively
Date: Wed, 27 Nov 2024 22:05:04 -0300

Hello Guix,

While testing the CHICKEN Scheme egg importer, I noticed it currently errors when importing recursively, as such:

```
lobo <at> drimys ~$ guix import egg spiffy -r
Backtrace:
           7 (primitive-load "/home/lobo/.config/guix/current/bin/gu…")
In guix/ui.scm:
   2330:7  6 (run-guix . _)
  2293:10  5 (run-guix-command _ . _)
In guix/scripts/import.scm:
     82:6  4 (guix-import . _)
In guix/scripts/import/egg.scm:
    96:19  3 (guix-import-egg . _)
In guix/import/utils.scm:
   667:27  2 (recursive-import "spiffy" #:repo->guix-package _ # _ . #)
   659:33  1 (lookup-node "spiffy" #f)
In guix/import/egg.scm:
   325:41  0 (_ _ #:version _ #:repo _)

guix/import/egg.scm:325:41: Unrecognized keyword: #:repo->guix-package
```

This is running on a foreign distro (Debian), if it happens to be relevant. Below is the output of `guix describe' and `guix --version' in my machine, I pulled just before sending this bug report to make sure that it's still valid as of now (my installation was a couple weeks old):

```
lobo <at> drimys ~$ guix describe
Generation 4    Nov 27 2024 22:03:33    (current)
  guix 8a28ba7
    repository URL: https://git.savannah.gnu.org/git/guix.git
    branch: master
    commit: 8a28ba76126cbbd2a6d61e864f576e7a7bd7a763
lobo <at> drimys ~$ guix --version
guix (GNU Guix) 8a28ba76126cbbd2a6d61e864f576e7a7bd7a763
Copyright (C) 2024 the Guix authors
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
```

---
Lobo Torres
https://quiltro.org

Message #8 received at 74565 <at> debbugs.gnu.org (full text, mbox):

From: Ekaitz Zarraga <ekaitz <at> elenq.tech>
To: 74565 <at> debbugs.gnu.org
Cc: Ekaitz Zarraga <ekaitz <at> elenq.tech>
Subject: [PATCH] import: egg: Fix recursive imports.
Date: Thu, 28 Nov 2024 10:34:42 +0100

Fixes #74565.

* guix/import/egg.scm (egg-recursive-import) <#:repo->guix-package>: Add
`#:allow-other-keys`.

Change-Id: I97ad2d1aaf664c8dc18965eb2a497aa0a76062d7
---
 guix/import/egg.scm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/guix/import/egg.scm b/guix/import/egg.scm
index e3bc158475..9691f8c5ff 100644
--- a/guix/import/egg.scm
+++ b/guix/import/egg.scm
@@ -3,6 +3,7 @@
 ;;; Copyright © 2021 Tobias Geerinckx-Rice <me <at> tobias.gr>
 ;;; Copyright © 2021 Sarah Morgensen <iskarian <at> mgsn.dev>
 ;;; Copyright © 2022 Hartmut Goebel <h.goebel <at> crazy-compilers.com>
+;;; Copyright © 2024 Ekaitz Zarraga <ekaitz <at> elenq.tech>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -322,8 +323,9 @@ (define egg->guix-package/m                   ;memoized variant
 (define* (egg-recursive-import package-name #:optional version)
   (recursive-import package-name
                     #:version version
-                    #:repo->guix-package (lambda* (name #:key version repo)
-                                           (egg->guix-package/m name version))
+                    #:repo->guix-package
+                    (lambda* (name #:key version repo #:allow-other-keys)
+                             (egg->guix-package/m name version))
                     #:guix-name egg-name->guix-name))
 
 

base-commit: faf8ba9b43323dc61988a368690b20008611fc87
-- 
2.46.0

Message #15 received at 74565-done <at> debbugs.gnu.org (full text, mbox):

From: Ekaitz Zarraga <ekaitz <at> elenq.tech>
To: 74565-done <at> debbugs.gnu.org
Cc: lobo <at> quiltro.org, Ekaitz Zarraga <ekaitz <at> elenq.tech>
Subject: Re: [PATCH] import: egg: Fix recursive imports.
Date: Thu, 28 Nov 2024 19:50:22 +0100

Fixed by 294386674c417355a24586fab5528c643d495b86

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.