GNU bug report logs - #74561
[PATCH] Allow limiting the size of *Completions*

Previous Next

Full log

View this message in rfc822 format

From: Juri Linkov <juri <at> linkov.net>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Spencer Baugh <sbaugh <at> janestreet.com>, Spencer Baugh <sbaugh <at> catern.com>, dmitry <at> gutov.dev, joaotavora <at> gmail.com, Eli Zaretskii <eliz <at> gnu.org>, 74561 <at> debbugs.gnu.org, Stefan Kangas <stefankangas <at> gmail.com>
Subject: bug#74561: [PATCH] Allow limiting the size of *Completions*
Date: Sun, 16 Feb 2025 19:38:58 +0200

>>> 1. partition the list of completions (e.g. by `seq-partition`)
>>>    into N groups corresponding to columns;
>>> 2. then take the first elements from each sublist
>>>    while laying them out line-by-line.
>>
>> I can do this, but just to warn you, this will require essentiallya
>> complete rewrite of completion--insert-vertical.  So the patch is going
>> to become a lot larger.  I suggest we should land the optimization for
>> completion--insert-horizontal and completion--insert-one-column first,
>> since those require smaller changes.
>
> +1
>
>         Stefan "not convinced such a rewrite is even worth the trouble,
>                 because of the increase of the costs that are
>                 proportional to the total completions"

Maybe indeed not worth the trouble, this needs more measurements
that could be postponed to later after landing the optimization
for horizontal/one-column.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.