GNU bug report logs - #74561
[PATCH] Allow limiting the size of *Completions*

Previous Next

Full log

View this message in rfc822 format

From: Spencer Baugh <sbaugh <at> catern.com>
To: Juri Linkov <juri <at> linkov.net>, Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Spencer Baugh <sbaugh <at> janestreet.com>, dmitry <at> gutov.dev, joaotavora <at> gmail.com, Eli Zaretskii <eliz <at> gnu.org>, 74561 <at> debbugs.gnu.org, Stefan Kangas <stefankangas <at> gmail.com>
Subject: bug#74561: [PATCH] Allow limiting the size of *Completions*
Date: Sun, 16 Feb 2025 16:35:21 +0000 (UTC)

Juri Linkov <juri <at> linkov.net> writes:
>>> In the process, I realized that this optimization doesn't help
>>> completions-format=vertical without a lot of effort, since that fills
>>> the entire first column before continuing to the second column.
>>
>> FWIW, maybe we should change this behavior so instead of filling
>> column-by-column we fill line-by-line.
>
> I think this is exactly how we should improve completion--insert-vertical.
> Instead of filling the first column before continuing to the second column
> the algorithm could be changed to:
>
> 1. partition the list of completions (e.g. by `seq-partition`)
>    into N groups corresponding to columns;
> 2. then take the first elements from each sublist
>    while laying them out line-by-line.

I can do this, but just to warn you, this will require essentiallya
complete rewrite of completion--insert-vertical.  So the patch is going
to become a lot larger.  I suggest we should land the optimization for
completion--insert-horizontal and completion--insert-one-column first,
since those require smaller changes.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.