GNU bug report logs - #74554
31.0.50; [PATCH] gnus: fix logo color customization

Previous Next

Full log

Message #13 received at 74554 <at> debbugs.gnu.org (full text, mbox):

From: Andrew Cohen <acohen <at> ust.hk>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: Eric Abrahamsen <eric <at> ericabrahamsen.net>,
 Trevor Arjeski <tmarjeski <at> gmail.com>, 74554 <at> debbugs.gnu.org
Subject: Re: bug#74554: 31.0.50; [PATCH] gnus: fix logo color customization
Date: Wed, 12 Feb 2025 08:16:39 +0800

>>>>> "SK" == Stefan Kangas <stefankangas <at> gmail.com> writes:

    SK> Trevor Arjeski <tmarjeski <at> gmail.com> writes:
    >> 1. Add the following code to an init.el:
    >> 
    >> (use-package gnus :ensure nil :custom (gnus-logo-color-style
    >> 'neutral))
    >> 
    >> 2. Start emacs, M-x gnus, and notice that the logo does not
    >> change to the neutral gray colors.
    >> 
    >> This does not seem to happen when using the Customization
    >> interface which puts `custom-set-variables' in your init.el:
    >> 
    >> (custom-set-variables '(gnus-logo-color-style 'neutral))
    >> 
    >> 
    >> I'm not sure if this is related to use-package's :custom keyword,
    >> but I have not come across this issue while using any other
    >> built-in emacs packages.
    >> 
    >> Please see the attached patch file for a possible fix and minor
    >> improvement.
    >> 
    >> Thanks, Trevor

    SK> Andrew, Eric, could you please help review this patch?

Looks OK to me. 
-- 
Andrew Cohen

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.