GNU bug report logs - #74552
[PATCH 0/3] Small changes for running qa-frontpage locally

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Christopher Baines <mail <at> cbaines.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#74552: closed ([PATCH 0/3] Small changes for running
 qa-frontpage locally)
Date: Thu, 27 Feb 2025 15:18:03 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 27 Feb 2025 15:17:01 +0000
with message-id <87plj3zac2.fsf <at> cbaines.net>
and subject line Re: [bug#74552] [PATCH 0/3] Small changes for running qa-frontpage locally
has caused the debbugs.gnu.org bug report #74552,
regarding [PATCH 0/3] Small changes for running qa-frontpage locally
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
74552: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=74552
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Noé Lopez <noe <at> xn--no-cja.eu>
To: guix-patches <at> gnu.org
Cc: Noé Lopez <noelopez <at> free.fr>
Subject: [PATCH 0/3] Small changes for running qa-frontpage locally
Date: Tue, 26 Nov 2024 23:54:49 +0100

From: Noé Lopez <noelopez <at> free.fr>

Hi,

While trying out qa-frontpage locally, I had the occasion to make some
trivial changes:

– Changed references for guix environment to guix shell
– Changed the remote url for guix-patches to not require authentication
– Abstracted git fetch invocations into a function.  This was
  originally intended for further changes but I suppose it can’t hurt.

Have a good day,
Noé Lopez

Noé Lopez (3):
  Update references to guix environment
  Abstract git fetch invocations into fetch-remote! function
  Use https protocol for the guix-patches remote

 README.org                                  |  2 +-
 guix-dev.scm                                |  2 +-
 guix-qa-frontpage/git-repository.scm        | 14 ++++++++++----
 guix-qa-frontpage/manage-patch-branches.scm |  6 +++---
 4 files changed, 15 insertions(+), 9 deletions(-)


base-commit: d3e526bf8a8b2723fdfd26d14c9959a060ba523b
-- 
2.46.0

[Message part 3 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: Noé Lopez <noe <at> xn--no-cja.eu>
Cc: 74552-done <at> debbugs.gnu.org, Noé Lopez <noelopez <at> free.fr>
Subject: Re: [bug#74552] [PATCH 0/3] Small changes for running qa-frontpage
 locally
Date: Thu, 27 Feb 2025 15:17:01 +0000

[Message part 4 (text/plain, inline)]

Noé Lopez <noe <at> noé.eu> writes:

> From: Noé Lopez <noelopez <at> free.fr>
>
> Hi,
>
> While trying out qa-frontpage locally, I had the occasion to make some
> trivial changes:

Hi,

Sorry I missed these emails, not sure how that happened.

> – Changed references for guix environment to guix shell

I've pushed this change now, note that I've switched to trunk as the
master branch since you sent these patches.

> – Changed the remote url for guix-patches to not require authentication

The solution here needed to be slightly more complicated, as QA on
bayfront still needs to use the git <at> git.qa.guix.gnu.org:guix-patches URL
so that it can modify the repository. I've pushed a patch that achieves
that now, and will use the https url by default, providing you don't
tell QA you want to manage the patch branches.

> – Abstracted git fetch invocations into a function.  This was
>   originally intended for further changes but I suppose it can’t hurt.

I wasn't so sure about this refactoring as to me it makes it less
obvious what's going on, and (for better or for worse) that we're
calling out to Git on the command line.

Feel free to resend it if you're still interested in making that change.

Thanks for the patches,

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.