From unknown Mon Jun 23 02:22:16 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#74542 <74542@debbugs.gnu.org> To: bug#74542 <74542@debbugs.gnu.org> Subject: Status: [PATCH 00/11] Improved tooling for package updates Reply-To: bug#74542 <74542@debbugs.gnu.org> Date: Mon, 23 Jun 2025 09:22:16 +0000 retitle 74542 [PATCH 00/11] Improved tooling for package updates reassign 74542 guix-patches submitter 74542 Ludovic Court=C3=A8s severity 74542 normal tag 74542 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 05:32:55 2024 Received: (at submit) by debbugs.gnu.org; 26 Nov 2024 10:32:55 +0000 Received: from localhost ([127.0.0.1]:46104 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFssI-0002NB-Nn for submit@debbugs.gnu.org; Tue, 26 Nov 2024 05:32:55 -0500 Received: from lists.gnu.org ([209.51.188.17]:49518) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFssH-0002N4-7N for submit@debbugs.gnu.org; Tue, 26 Nov 2024 05:32:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tFssG-0004oy-RE for guix-patches@gnu.org; Tue, 26 Nov 2024 05:32:53 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tFssF-0008FV-S6; Tue, 26 Nov 2024 05:32:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to: references; bh=Xpr18fwQvEh6KrKugQjgSeJkJSXBd6d27W+wBIjzuUQ=; b=A3SVJqFVJHY6bA hPQVaqBOxgEM6Doic5HZQJoStCLMuPqgpUlRtNSKWVenBiFzrZGAY9TaD54VUVIKnbFCw0CB2FlrO nfQsB7YvoJNxbpO1IBuybDub5danJVU0MAZtEdS16yOHY8y7fy8ATnswzY+3/auWDHWTTSx+eb7XJ roy+mkYydye132MQmkIOusw0ckSgtPPkv30xpDynK0UJxYj2QXuGxMz1qCUJ5dMC9FvWfisQY2IMK YLtCerkLarQ8gdMtAvI6HtavFYUm1dmSQWvulJrrHH3dz07bNzkoGoESw0PhPsYDa3BoY70JWWo+3 L3CoS72rqJ876cS3c1Hg==; From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: guix-patches@gnu.org Subject: [PATCH 00/11] Improved tooling for package updates Date: Tue, 26 Nov 2024 11:32:17 +0100 Message-ID: X-Mailer: git-send-email 2.46.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Debbugs-Cc: Christopher Baines , Josselin Poiret , Ludovic Court?s , Mathieu Othacehe , Simon Tournier , Tobias Geerinckx-Rice Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello Guix! This patch series aims to improve tooling for package upgrades: • By adding a ‘--dependents’ option to ‘guix build’ to build dependent packages (those returned by ‘guix refresh -l’). This was suggested by my colleague Romain Garbage, who also prototyped a variant of this. • By improving individual updaters and updating metadata for some packages. • By adding an “upgrade manifest”, to automatically build the latest version (using the ‘with-latest’ package transformation) of a few security-critical packages along with their dependents at distance 2, as well as some of the leaf packages. The goal is to use this upgrade manifest for a new jobset on ci.guix. The idea is that when someone tries to upgrade one of these things, chances are it will have been built already. I already toyed with this idea here: https://guix.bordeaux.inria.fr/jobset/guix-hpc-cutting-edge https://gitlab.inria.fr/guix-hpc/guix-hpc/-/blob/master/cutting-edge.manifest?ref_type=heads It’s experimental; surely we’ll find that the manifest needs to be tweaked, or that some of the updaters abort to early. But I think it can help, and it’s a good way to use available x86_64 CPU power at ci.guix. According to a recent discussion with Nix hackers on Mastodon¹, mere substitute availability is not perceived as a key factor in what enables them to keep Nixpkgs up-to-date; the primary factor appears to be the bot that sends patches updating packages. Food for thought! Ludo’. ¹ https://toot.aquilenet.fr/@civodul/113527656544893427 Ludovic Courtès (11): transformations: Export ‘package-with-upstream-version’. gnu-maintenance: ‘import-html-release’ doesn’t abort upon HTTP 404. gnu-maintenance: Savannah/Xorg updaters no longer abort on network errors. build: Add ‘--development’ option. packages: Factorize ‘all-packages’. guix build: Add ‘--dependents’. import: gnome: Keep going upon HTTP errors. gnu-maintenance: ‘gnu-ftp’ updater excludes GnuPG-hosted packages. gnu: Update updater properties for GnuPG-related packages. guix build: Validate that the file passed to ‘-m’ returns a manifest. etc: Add upgrade manifest. Makefile.am | 1 + doc/contributing.texi | 4 +- doc/guix.texi | 52 +++++++++++ etc/source-manifest.scm | 13 +-- etc/upgrade-manifest.scm | 98 +++++++++++++++++++++ gnu/packages.scm | 20 ++++- gnu/packages/gnupg.scm | 40 +++------ guix/download.scm | 3 +- guix/gnu-maintenance.scm | 49 +++++++---- guix/import/gnome.scm | 13 ++- guix/scripts/build.scm | 185 ++++++++++++++++++++++++++++++--------- guix/scripts/graph.scm | 10 --- guix/scripts/refresh.scm | 10 --- guix/scripts/weather.scm | 15 ---- guix/transformations.scm | 2 + tests/guix-build.sh | 11 +++ 16 files changed, 386 insertions(+), 140 deletions(-) create mode 100644 etc/upgrade-manifest.scm base-commit: 827ec92f44d1b1daedc5446146801183560e861b -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 05:36:29 2024 Received: (at 74542) by debbugs.gnu.org; 26 Nov 2024 10:36:29 +0000 Received: from localhost ([127.0.0.1]:46177 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFsvk-0002au-GE for submit@debbugs.gnu.org; Tue, 26 Nov 2024 05:36:28 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44404) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFsvj-0002aP-32 for 74542@debbugs.gnu.org; Tue, 26 Nov 2024 05:36:27 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tFstW-0008WP-HX; Tue, 26 Nov 2024 05:34:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=7skomakDrjVvD2DjZQrnab6W+vi82mi4d1yEkNRwGt8=; b=INYKZbUbTW3cWg3KCEzl KhIzrM2xYMXA5qOWAk9kE+oKMGlsTZKEgSL5/B37WV9J8LQclPel+Ye8d58uGcvl2MBX0bO/aBySd Q4/fN4cy8dMPj1o8iGZrVZ9M5hhnepcD+N1IF4dWMcJJt0SNUk8U1ccPtuBnxnh3S7aOqlyASMQim cHbyriTaeCU5kRsYbLE+kIXT3KUrzlU6ljSe3OpYqqCnaYlMtrRn/v+Tqh0CsPiMjqIx0+ZQhjEhD hyy1XDbZc2VdS33cM7RQAstZc55z8GcbHE3nB4eQ8EsjRSMAltV23mkNVkMldTYCAQ6XLM68ec6bM oIcYUhuJJ4ClUw==; From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 74542@debbugs.gnu.org Subject: [PATCH 01/11] =?UTF-8?q?transformations:=20Export=20=E2=80=98pack?= =?UTF-8?q?age-with-upstream-version=E2=80=99.?= Date: Tue, 26 Nov 2024 11:33:40 +0100 Message-ID: <7758b6e93f83b69a2c5a402447df65c563d6ace0.1732615193.git.ludo@gnu.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Debbugs-Cc: Christopher Baines , Josselin Poiret , Ludovic Court?s , Mathieu Othacehe , Simon Tournier , Tobias Geerinckx-Rice Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74542 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * guix/transformations.scm (package-with-upstream-version): Export. Change-Id: I8e09e69e9c32bffc329c97ef1c0258f750181b11 --- guix/transformations.scm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/guix/transformations.scm b/guix/transformations.scm index ea8b7a0844..9dfc4402c5 100644 --- a/guix/transformations.scm +++ b/guix/transformations.scm @@ -61,6 +61,8 @@ (define-module (guix transformations) tunable-package? tuned-package + package-with-upstream-version + show-transformation-options-help transformation-option-key? cacheable-transformation-option-key? -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 05:36:33 2024 Received: (at 74542) by debbugs.gnu.org; 26 Nov 2024 10:36:33 +0000 Received: from localhost ([127.0.0.1]:46188 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFsvp-0002bS-0r for submit@debbugs.gnu.org; Tue, 26 Nov 2024 05:36:33 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44410) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFsvj-0002aS-4s for 74542@debbugs.gnu.org; Tue, 26 Nov 2024 05:36:28 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tFstX-00004u-Fy; Tue, 26 Nov 2024 05:34:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=gUsH8apnherpQShGuu1InrWaP5q5OLB8UdwDPUoWXik=; b=APGgY+MM1KX4NwTN5iDa 5RvtVLSsxL4cojmXVBpQgEakF5S7dT19F3c0wxUVZNXDk4CT7NgpSkFDqSG5kLAK0PJUN6gitRhad LRiExovN37DX9X/sRkTQqXcOTRIj93Hd6WNbltsBSBf7hUh4O7sKccGlLjLKb23iBjqZYS0gZTieT jZSZevj0CL7iZPK4/9ahHSnJvTTtPsz6GC2Te9raJiqg/5Ro5xWqrLDKtpIiNv4V16UP9AZGaYP7K 4QDbl7gkCT6dISKqxUyacO1qmooUdmIpLBtyaB1cRnCkS8cG2XfxML3D2nMAyiN2JXnlGCS8lqKRh zvBwx33lUNdqNA==; From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 74542@debbugs.gnu.org Subject: [PATCH 02/11] =?UTF-8?q?gnu-maintenance:=20=E2=80=98import-html-r?= =?UTF-8?q?elease=E2=80=99=20doesn=E2=80=99t=20abort=20upon=20HTTP=20404.?= Date: Tue, 26 Nov 2024 11:33:41 +0100 Message-ID: <92c108d975939b5dece3fb86ac7bce1edaf619a4.1732615193.git.ludo@gnu.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Debbugs-Cc: Christopher Baines , Josselin Poiret , Ludovic Court?s , Mathieu Othacehe , Simon Tournier , Tobias Geerinckx-Rice Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74542 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Previously, updaters using ‘import-html-release’ would throw to 'quit when the HTML page isn’t found, aborting the whole process: $ guix refresh coreutils libchop guix refresh: error: https://de.freedif.org/savannah//libchop/: HTTP download failed: 404 ("Not Found") * guix/gnu-maintenance.scm (url->links): Guard against ‘http-get-error?’ and return the empty list when it is raised. Change-Id: I419ff96ddb424aa8c74d6bab3d66a5e85355c3dc --- guix/gnu-maintenance.scm | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/guix/gnu-maintenance.scm b/guix/gnu-maintenance.scm index 881e941fbf..f34dcfc13f 100644 --- a/guix/gnu-maintenance.scm +++ b/guix/gnu-maintenance.scm @@ -1,5 +1,5 @@ ;;; GNU Guix --- Functional package management for GNU -;;; Copyright © 2010-2023 Ludovic Courtès +;;; Copyright © 2010-2024 Ludovic Courtès ;;; Copyright © 2012, 2013 Nikita Karetnikov ;;; Copyright © 2021 Simon Tournier ;;; Copyright © 2022 Maxime Devos @@ -30,6 +30,7 @@ (define-module (guix gnu-maintenance) #:use-module (srfi srfi-2) #:use-module (srfi srfi-11) #:use-module (srfi srfi-26) + #:use-module (srfi srfi-34) #:use-module (rnrs io ports) #:use-module ((guix http-client) #:hide (open-socket-for-uri)) ;; not required in many cases, so autoloaded to reduce start-up costs. @@ -496,11 +497,16 @@ (define (html-links sxml) (define (url->links url) "Return the unique links on the HTML page accessible at URL." - (let* ((uri (string->uri url)) - (port (http-fetch/cached uri #:ttl 3600)) - (sxml (html->sxml port))) - (close-port port) - (delete-duplicates (html-links sxml)))) + (guard (c ((http-get-error? c) + (warning (G_ "failed to download '~a': ~a (~a)~%") + url (http-get-error-code c) + (http-get-error-reason c)) + '())) + (let* ((uri (string->uri url)) + (port (http-fetch/cached uri #:ttl 3600)) + (sxml (html->sxml port))) + (close-port port) + (delete-duplicates (html-links sxml))))) (define (canonicalize-url url base-url) "Make relative URL absolute, by appending URL to BASE-URL as required. If -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 05:36:34 2024 Received: (at 74542) by debbugs.gnu.org; 26 Nov 2024 10:36:35 +0000 Received: from localhost ([127.0.0.1]:46196 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFsvp-0002bd-KM for submit@debbugs.gnu.org; Tue, 26 Nov 2024 05:36:34 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44416) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFsvj-0002aT-4o for 74542@debbugs.gnu.org; Tue, 26 Nov 2024 05:36:28 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tFstY-00005O-Ln; Tue, 26 Nov 2024 05:34:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=kl+o3JDOVclar88DBNdgoen9lS8pCWyJIdQt9A5uZV8=; b=hUXg78eqqEb0caSIy3z2 Us1K7+gJhuLuq4k+Zeg7s/XWBukYOXCHGvoc5jJvNZbSQ/RwkIQORnFU3gzg7Munw6q8H+89yDX/l EIbnzrT7xjCneXdFrPAYpR+9qkpVdLFoeIA5s7k0Anw37MML/KiHLlbglQcc+NJ8iqmop5Q9v7kUQ lygiPaIKeQafIVMvyUiIZzqNapdr78BZsfVIILPb/HHUGJJ8xI1YUkGiZ3Ynt/4jL4lydTdSvhtKW P/O81SZMIx4Ms8NA/VDAd2Q7SnTkO26APP5O5eWKVca5qbqxwLIBiNRDQTqzI8Frj6FHcVOQH5kvn cTNGiZDYIVUViw==; From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 74542@debbugs.gnu.org Subject: [PATCH 03/11] gnu-maintenance: Savannah/Xorg updaters no longer abort on network errors. Date: Tue, 26 Nov 2024 11:33:42 +0100 Message-ID: X-Mailer: git-send-email 2.46.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Debbugs-Cc: Christopher Baines , Josselin Poiret , Ludovic Court?s , Mathieu Othacehe , Simon Tournier , Tobias Geerinckx-Rice Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74542 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Previously these updaters would fail upon networking error, causing the whole process to abort: $ guix refresh coreutils libgcrypt guix refresh: error: connect*: Connection refused * guix/gnu-maintenance.scm (import-release*, import-xorg-release): Wrap in ‘false-if-networking-error’. Change-Id: I8d309bf8662e2d46460585b4a1b7da0a4f2e8907 --- guix/gnu-maintenance.scm | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/guix/gnu-maintenance.scm b/guix/gnu-maintenance.scm index f34dcfc13f..866b960a4a 100644 --- a/guix/gnu-maintenance.scm +++ b/guix/gnu-maintenance.scm @@ -469,10 +469,12 @@ (define* (import-release* package #:key (version #f)) \"emacs-auctex\", for instance.)" (let-values (((server directory) (ftp-server/directory package))) - (false-if-ftp-error (import-release (package-upstream-name package) - #:version version - #:server server - #:directory directory)))) + (false-if-networking-error + (false-if-ftp-error + (import-release (package-upstream-name package) + #:version version + #:server server + #:directory directory))))) ;;; @@ -913,13 +915,14 @@ (define* (import-xorg-release package #:key (version #f)) "Return the latest release of PACKAGE. Optionally include a VERSION string to fetch a specific version." (let ((uri (string->uri (origin-uri (package-source package))))) - (false-if-ftp-error - (import-ftp-release - (package-name package) - #:version version - #:server "ftp.freedesktop.org" - #:directory - (string-append "/pub/xorg/" (dirname (uri-path uri))))))) + (false-if-networking-error + (false-if-ftp-error + (import-ftp-release + (package-name package) + #:version version + #:server "ftp.freedesktop.org" + #:directory + (string-append "/pub/xorg/" (dirname (uri-path uri)))))))) (define* (import-kernel.org-release package #:key (version #f)) "Return the latest release of PACKAGE, a Linux kernel package. -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 05:36:35 2024 Received: (at 74542) by debbugs.gnu.org; 26 Nov 2024 10:36:36 +0000 Received: from localhost ([127.0.0.1]:46198 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFsvq-0002bl-PM for submit@debbugs.gnu.org; Tue, 26 Nov 2024 05:36:35 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44426) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFsvm-0002ac-Mz for 74542@debbugs.gnu.org; Tue, 26 Nov 2024 05:36:31 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tFstZ-000062-Qm; Tue, 26 Nov 2024 05:34:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=fqh6EUI8OTpBwB00eruwI0TwIUEw3M7Z/G3uk+D4mMs=; b=ZfxMnSfcxZaI+wxRGzr9 3UhlZgkuRHvoqsfN/7x5lTaw82MkhTHK5jURnJVU3honlMdRv6PWbCEnhzA7iGoKqHXW40IEwRCac /oMQWI/VwOEt3y8a0tAR9d2Y8zflPutJTJ9UvdJbcyZlrpOGVoiMTTADuOy32dMDlXEb2m1LHhF74 K3Q31uRA32qranETxEmIWdjpfIjYq+noCbnjcD6dPzkTcb0BePwgwDmKBZfnZh1mTIuSZkwybTiz/ MqPCLaXzuc/A8O+noi9/aI0vT20ABQZqku6V1HmUlYiAOhWid3SzkHX/xPEqXyTauzHxJd0dCxVpV jandyQTRFnBIsQ==; From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 74542@debbugs.gnu.org Subject: [PATCH 04/11] =?UTF-8?q?build:=20Add=20=E2=80=98--development?= =?UTF-8?q?=E2=80=99=20option.?= Date: Tue, 26 Nov 2024 11:33:43 +0100 Message-ID: <7c530a62370853828f181db011cb2f12fdc78847.1732615193.git.ludo@gnu.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Debbugs-Cc: Christopher Baines , Josselin Poiret , Ludovic Court?s , Mathieu Othacehe , Maxim Cournoyer , Simon Tournier , Tobias Geerinckx-Rice Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74542 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * guix/scripts/build.scm (show-help, %options): Add ‘-D’. (options->things-to-build): Change ‘append-map’ to a loop. Honor ‘-D’. * tests/guix-build.sh: Add test. * doc/guix.texi (Additional Build Options): Document it. Change-Id: I99227aadfe861e43c001a4872292bd687b37f5d4 --- doc/guix.texi | 25 +++++++++ guix/scripts/build.scm | 119 ++++++++++++++++++++++++++++------------- tests/guix-build.sh | 5 ++ 3 files changed, 112 insertions(+), 37 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index 26488b41c8..a9d0d044ae 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -13614,6 +13614,31 @@ Additional Build Options (@pxref{The Store Monad}). The procedure must return a derivation as a monadic value, which is then passed through @code{run-with-store}. +@item --development +@itemx -D +Build the ``development environment'' (build dependencies) of the +following package. + +For example, the following command builds the inputs of @code{hello}, +but @emph{not} @code{hello} itself, and also builds @code{guile}: + +@example +guix build -D hello guile +@end example + +Notice that @option{-D} (or @option{--development}) only applies to the +immediately following package on the command line. Under the hood, it +uses @code{package->development-manifest} +(@pxref{package-development-manifest, +@code{package->development-manifest}}). + +@quotation Note +The effect of combining @option{--development} with @option{--target} +(for cross-compilation) may not be what you expect: it will +cross-compile all the dependencies of the given package when it is built +natively. +@end quotation + @item --source @itemx -S Build the source derivations of the packages, rather than the packages diff --git a/guix/scripts/build.scm b/guix/scripts/build.scm index 9e05bb532b..326d04f1f8 100644 --- a/guix/scripts/build.scm +++ b/guix/scripts/build.scm @@ -438,6 +438,8 @@ (define (show-help) -m, --manifest=FILE build the packages that the manifest given in FILE evaluates to")) (display (G_ " + -D, --development build the inputs of the following package")) + (display (G_ " -S, --source build the packages' source derivations")) (display (G_ " --sources[=TYPE] build source derivations; TYPE may optionally be one @@ -522,6 +524,9 @@ (define %options (option '(#\m "manifest") #t #f (lambda (opt name arg result) (alist-cons 'manifest arg result))) + (option '(#\D "development") #f #f + (lambda (opt name arg result) + (alist-cons 'development? #t result))) (option '(#\n "dry-run") #f #f (lambda (opt name arg result) (alist-cons 'dry-run? #t result))) @@ -581,43 +586,83 @@ (define-public my-package (for-each validate-type lst) lst)) - (append-map (match-lambda - (('argument . (? string? spec)) - (cond ((derivation-path? spec) - (catch 'system-error - (lambda () - ;; Ask for absolute file names so that .drv file - ;; names passed from the user to 'read-derivation' - ;; are absolute when it returns. - (let ((spec (canonicalize-path spec))) - (list (read-derivation-from-file spec)))) - (lambda args - ;; Non-existent .drv files can be substituted down - ;; the road, so don't error out. - (if (= ENOENT (system-error-errno args)) - '() - (apply throw args))))) - ((store-path? spec) - ;; Nothing to do; maybe for --log-file. - '()) - (else - (list (specification->package spec))))) - (('file . file) - (let ((file (or (and (string-suffix? ".json" file) - (json->scheme-file file)) - file))) - (ensure-list (load* file (make-user-module '()))))) - (('manifest . manifest) - (map manifest-entry-item - (manifest-entries - (load* manifest - (make-user-module '((guix profiles) (gnu))))))) - (('expression . str) - (ensure-list (read/eval str))) - (('argument . (? derivation? drv)) - drv) - (_ '())) - opts)) + (define system + (or (assoc-ref opts 'system) (%current-system))) + + ;; Process OPTS in "the right order", meaning that if the user typed + ;; "-D hello", arrange to see the 'development? option before the "hello" + ;; spec. + (let loop ((opts (reverse opts)) + (type 'regular) + (result '())) + (define (for-type obj) + ;; Return a list of objects corresponding to OBJ adjusted for TYPE. + (match type + ('regular + (list obj)) + ('development + (if (package? obj) + (map manifest-entry-item + (manifest-entries + (package->development-manifest obj system))) + obj)))) + + (match opts + (() + (reverse result)) + ((head . tail) + (match head + (('argument . (? string? spec)) + (cond ((derivation-path? spec) + (catch 'system-error + (lambda () + ;; Ask for absolute file names so that .drv file + ;; names passed from the user to 'read-derivation' + ;; are absolute when it returns. + (let ((spec (canonicalize-path spec))) + (loop tail 'regular + (cons (read-derivation-from-file spec) + result)))) + (lambda args + ;; Non-existent .drv files can be substituted down + ;; the road, so don't error out. + (if (= ENOENT (system-error-errno args)) + (loop tail 'regular result) + (apply throw args))))) + ((store-path? spec) + ;; Nothing to do; maybe for --log-file. + (loop tail type result)) + (else + (loop tail 'regular + (append (for-type (specification->package spec)) + result))))) + (('file . file) + (let ((file (or (and (string-suffix? ".json" file) + (json->scheme-file file)) + file))) + (loop tail 'regular + (append (append-map + for-type + (ensure-list (load* file (make-user-module '())))) + result)))) + (('manifest . manifest) + (loop tail 'regular + (append (map manifest-entry-item + (manifest-entries + (load* manifest + (make-user-module '((guix profiles) + (gnu)))))) + result))) + (('expression . str) + (loop tail 'regular + (append (append-map for-type (ensure-list (read/eval str))) + result))) + (('argument . (? derivation? drv)) + (loop tail 'regular (cons drv result))) + (('development? . #t) + (loop tail 'development result)) + (_ + (loop tail type result))))))) (define (options->derivations store opts) "Given OPTS, the result of 'args-fold', return a list of derivations to diff --git a/tests/guix-build.sh b/tests/guix-build.sh index 36eac2b7e0..3637bcdeb3 100644 --- a/tests/guix-build.sh +++ b/tests/guix-build.sh @@ -190,6 +190,11 @@ test `guix build -d --sources=transitive foo \ | grep -e 'foo\.tar\.gz' -e 'bar\.tar\.gz' -e 'bar\.dat' \ | wc -l` -eq 3 +# Building the inputs. +guix build -D hello -n +test `guix build -D hello -d \ + | grep -e 'glibc.*\.drv$' -e 'gcc.*\.drv$' -e 'binutils.*\.drv$' \ + | wc -l` -ge 3 # Unbound variable in thunked field. cat > "$module_dir/foo.scm" <) id 1tFsw0-0002cV-Vv for submit@debbugs.gnu.org; Tue, 26 Nov 2024 05:36:45 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44440) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFsvo-0002ae-5V for 74542@debbugs.gnu.org; Tue, 26 Nov 2024 05:36:32 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tFsta-00006Y-U0; Tue, 26 Nov 2024 05:34:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=fVG6zE1g5+COgLKTSq6q72yUelSVfBfqbZ9R64BW7Zw=; b=P8Ia4mWfmBwTQczy4ko6 D5yj8KuzmqjgxwB5l8GlEyivMrwR4m9mVGg4lvvs44RLYvyywC9CRv/RbC87hGRS6bjfNeHg+dtOX kiS5D3dTyIzE8N+75nH8twjcEPq20yjis65O2kesFgezMwVzSiNYpZE69nR6Yboknal0Bsl56fPNb T90LwQEPp6h/eSbKTziv35XS9iijyPnqdwWs8vTBSNEKlYPPVXU6qhdFcC0P7NVlk8Uzbp7UB88g6 eORR1IVXWxz3TvvpCFCQL49EK3kvC3JsFJiJcNNnbBApVeCCKPDXh4nbP1yRntNLqujyeclStwfaF X+Df8ePaHR2+rQ==; From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 74542@debbugs.gnu.org Subject: [PATCH 05/11] =?UTF-8?q?packages:=20Factorize=20=E2=80=98all-pack?= =?UTF-8?q?ages=E2=80=99.?= Date: Tue, 26 Nov 2024 11:33:44 +0100 Message-ID: <21b5368441ff34f5a54b78550b87d97ca765785e.1732615193.git.ludo@gnu.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Debbugs-Cc: Christopher Baines , Josselin Poiret , Ludovic Court?s , Mathieu Othacehe , Simon Tournier , Tobias Geerinckx-Rice Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74542 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages.scm (all-packages): New procedure. * etc/source-manifest.scm (all-packages): Remove. * guix/scripts/graph.scm (all-packages): Remove. * guix/scripts/refresh.scm (all-packages): Remove. * guix/scripts/weather.scm (all-packages): Remove. Change-Id: I6072952c4b877b541037ce86402cfb7744eeb0a0 --- etc/source-manifest.scm | 13 +------------ gnu/packages.scm | 20 +++++++++++++++++++- guix/scripts/graph.scm | 10 ---------- guix/scripts/refresh.scm | 10 ---------- guix/scripts/weather.scm | 15 --------------- 5 files changed, 20 insertions(+), 48 deletions(-) diff --git a/etc/source-manifest.scm b/etc/source-manifest.scm index f96a5da6f7..3e1ae07959 100644 --- a/etc/source-manifest.scm +++ b/etc/source-manifest.scm @@ -1,5 +1,5 @@ ;;; GNU Guix --- Functional package management for GNU -;;; Copyright © 2021 Ludovic Courtès +;;; Copyright © 2021, 2024 Ludovic Courtès ;;; ;;; This file is part of GNU Guix. ;;; @@ -25,17 +25,6 @@ (guix packages) (guix profiles) (gnu packages)) -(define (all-packages) - "Return the list of all the packages, public or private, omitting only -superseded packages." - (fold-packages (lambda (package lst) - (match (package-replacement package) - (#f (cons package lst)) - (replacement - (append (list replacement package) lst)))) - '() - #:select? (negate package-superseded))) - (define (upstream-origin source) "Return SOURCE without any patches or snippet." (origin (inherit source) diff --git a/gnu/packages.scm b/gnu/packages.scm index 80c22d1d7f..1af3b8d440 100644 --- a/gnu/packages.scm +++ b/gnu/packages.scm @@ -1,5 +1,5 @@ ;;; GNU Guix --- Functional package management for GNU -;;; Copyright © 2012-2020, 2022-2023 Ludovic Courtès +;;; Copyright © 2012-2020, 2022-2024 Ludovic Courtès ;;; Copyright © 2013 Mark H Weaver ;;; Copyright © 2014 Eric Bavier ;;; Copyright © 2016, 2017 Alex Kost @@ -56,6 +56,7 @@ (define-module (gnu packages) cache-is-authoritative? fold-packages + all-packages fold-available-packages find-newest-available-packages @@ -253,6 +254,23 @@ (define* (fold-packages proc init init modules)) +(define all-packages + (mlambda () + "Return the list of all public packages, including replacements and hidden +packages, excluding superseded packages." + (delete-duplicates + (fold-packages (lambda (package result) + (match (package-replacement package) + ((? package? replacement) + (cons* replacement package result)) + (#f + (cons package result)))) + '() + + ;; Dismiss deprecated packages but keep hidden packages. + #:select? (negate package-superseded)) + eq?))) + (define %package-cache-file ;; Location of the package cache. "/lib/guix/package.cache") diff --git a/guix/scripts/graph.scm b/guix/scripts/graph.scm index 6740858d8b..935721edea 100644 --- a/guix/scripts/graph.scm +++ b/guix/scripts/graph.scm @@ -119,16 +119,6 @@ (define %package-node-type ;;; Reverse package DAG. ;;; -(define (all-packages) ;XXX: duplicated from (guix scripts refresh) - "Return the list of all the distro's packages." - (fold-packages (lambda (package result) - ;; Ignore deprecated packages. - (if (package-superseded package) - result - (cons package result))) - '() - #:select? (const #t))) ;include hidden packages - (define %reverse-package-node-type ;; For this node type we first need to compute the list of packages and the ;; list of back-edges. Since we want to do it only once, we use the diff --git a/guix/scripts/refresh.scm b/guix/scripts/refresh.scm index ec7d38c22a..8c72d0c545 100644 --- a/guix/scripts/refresh.scm +++ b/guix/scripts/refresh.scm @@ -455,16 +455,6 @@ (define* (check-for-package-update update-spec updaters #:key warn?) ;;; Dependents. ;;; -(define (all-packages) - "Return the list of all the distro's packages." - (fold-packages (lambda (package result) - ;; Ignore deprecated packages. - (if (package-superseded package) - result - (cons package result))) - '() - #:select? (const #t))) ;include hidden packages - (define (list-dependents packages) "List all the things that would need to be rebuilt if PACKAGES are changed." ;; Using %BAG-NODE-TYPE is more accurate than using %PACKAGE-NODE-TYPE diff --git a/guix/scripts/weather.scm b/guix/scripts/weather.scm index 08a1b22a74..29432fd923 100644 --- a/guix/scripts/weather.scm +++ b/guix/scripts/weather.scm @@ -55,21 +55,6 @@ (define-module (guix scripts weather) #:use-module (ice-9 vlist) #:export (guix-weather)) -(define (all-packages) - "Return the list of public packages we are going to query." - (delete-duplicates - (fold-packages (lambda (package result) - (match (package-replacement package) - ((? package? replacement) - (cons* replacement package result)) - (#f - (cons package result)))) - '() - - ;; Dismiss deprecated packages but keep hidden packages. - #:select? (negate package-superseded)) - eq?)) - (define (call-with-progress-reporter reporter proc) "This is a variant of 'call-with-progress-reporter' that works with monadic scope." -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 05:36:46 2024 Received: (at 74542) by debbugs.gnu.org; 26 Nov 2024 10:36:46 +0000 Received: from localhost ([127.0.0.1]:46204 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFsw1-0002cY-PR for submit@debbugs.gnu.org; Tue, 26 Nov 2024 05:36:46 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44442) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFsvo-0002af-5U for 74542@debbugs.gnu.org; Tue, 26 Nov 2024 05:36:32 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tFstc-00006m-AL; Tue, 26 Nov 2024 05:34:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=k3k/sg0/wgle55A25LQqmWpOUX+fPsiNJz/UedSG5CU=; b=DlOjfn24XgIyfLJWx6ac HrRsYWG9mWedyNOuDuFJ8PMaWheLketKnPOtaQSxjBD+GuDXXqGgUCm/ywxdG6H4C9C6ja4kl4i/R bIr0x7U7kq8U6FnNDfByIodYT5oueGADRp8iqO5BJaJhd4mKWYB0GR2GNjvgMvJIo1uEWHLgaf5y2 UcoEmIQQnLYCzED0KxinjKuI3wEo9VBZwVAfgBBkkCm9AdXELxMUhRYPaOkBqdj0B5je/vgymblFP pVSqDd7PDEZ/7fOP061U1iOynwqnSG+0ZRO5qepfn95ZR7UsreKt1UAMZCtHsrGCrpBsnKz9lwdm/ j6bP+/nYaQKGnA==; From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 74542@debbugs.gnu.org Subject: [PATCH 06/11] =?UTF-8?q?guix=20build:=20Add=20=E2=80=98--dependen?= =?UTF-8?q?ts=E2=80=99.?= Date: Tue, 26 Nov 2024 11:33:45 +0100 Message-ID: X-Mailer: git-send-email 2.46.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Debbugs-Cc: Christopher Baines , Josselin Poiret , Ludovic Court?s , Mathieu Othacehe , Maxim Cournoyer , Simon Tournier , Tobias Geerinckx-Rice Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74542 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * guix/scripts/build.scm (show-help, %options): Add ‘--dependents’. (dependents): New procedure. (options->things-to-build): Add ‘store’ parameter; honor ‘dependents’ option. [for-type]: Handle ‘dependents’ type. (options->derivations): Update call to ‘options->things-to-build’. * tests/guix-build.sh: Add test. * doc/guix.texi (Additional Build Options): Document ‘--dependents’. (Invoking guix refresh): Cross-reference it. * doc/contributing.texi (Submitting Patches): Mention it. Change-Id: I00b6d5831e1f1d35dc8b84a82605391d5a8f417c --- doc/contributing.texi | 4 ++- doc/guix.texi | 27 ++++++++++++++++++++ guix/scripts/build.scm | 56 ++++++++++++++++++++++++++++++++++++++++-- tests/guix-build.sh | 6 +++++ 4 files changed, 90 insertions(+), 3 deletions(-) diff --git a/doc/contributing.texi b/doc/contributing.texi index b063169189..5a778466d7 100644 --- a/doc/contributing.texi +++ b/doc/contributing.texi @@ -1914,7 +1914,9 @@ Submitting Patches @item Make sure the package builds on your platform, using @command{guix build -@var{package}}. +@var{package}}. Also build at least its direct dependents with +@command{guix build --dependents=1 @var{package}} +(@pxref{build-dependents, @command{guix build}}). @item We recommend you also try building the package on other supported diff --git a/doc/guix.texi b/doc/guix.texi index a9d0d044ae..5734cf306b 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -13639,6 +13639,31 @@ Additional Build Options natively. @end quotation +@cindex dependents of a package, building them +@cindex building the dependents of a package +@anchor{build-dependents} +@item --dependents[=@var{depth}] +@itemx -T [@var{depth}] +Build the dependents of the following package. By default, build all +the direct and indirect dependents; when @var{depth} is provided, limit +to dependents at that distance: 1 for direct dependents, 2 for +dependents of dependents, and so on. + +For example, the command below builds @emph{all} the dependents of libgit2: + +@example +guix build --dependents libgit2 +@end example + +To build all the packages that directly depend on NumPy, run: + +@example +guix build -T1 python-numpy +@end example + +The list of dependents is computed in the same way as with @command{guix +refresh --list-dependent} (@pxref{Invoking guix refresh}). + @item --source @itemx -S Build the source derivations of the packages, rather than the packages @@ -15142,6 +15167,8 @@ Invoking guix refresh @command{guix graph}}, for information on how to visualize the list of dependents of a package. +@xref{build-dependents, @command{guix build --dependents}}, for a +convenient way to build all the dependents of a package. @end table Be aware that the @option{--list-dependent} option only diff --git a/guix/scripts/build.scm b/guix/scripts/build.scm index 326d04f1f8..565bfd48e9 100644 --- a/guix/scripts/build.scm +++ b/guix/scripts/build.scm @@ -33,6 +33,9 @@ (define-module (guix scripts build) #:use-module (guix profiles) #:use-module (guix diagnostics) #:autoload (guix http-client) (http-fetch http-get-error?) + #:autoload (guix scripts graph) (%bag-node-type) + #:autoload (guix graph) (node-back-edges) + #:autoload (guix sets) (setq set-contains? set-insert) #:use-module (ice-9 format) #:use-module (ice-9 match) #:use-module (srfi srfi-1) @@ -440,6 +443,9 @@ (define (show-help) (display (G_ " -D, --development build the inputs of the following package")) (display (G_ " + -T, --dependents[=N] build dependents of the following package, up to + depth N")) + (display (G_ " -S, --source build the packages' source derivations")) (display (G_ " --sources[=TYPE] build source derivations; TYPE may optionally be one @@ -527,6 +533,11 @@ (define %options (option '(#\D "development") #f #f (lambda (opt name arg result) (alist-cons 'development? #t result))) + (option '(#\T "dependents") #f #t + (lambda (opt name arg result) + (alist-cons 'dependents + (or (and=> arg string->number*) +inf.0) + result))) (option '(#\n "dry-run") #f #f (lambda (opt name arg result) (alist-cons 'dry-run? #t result))) @@ -551,7 +562,39 @@ (define %options %standard-cross-build-options %standard-native-build-options))) -(define (options->things-to-build opts) +(define (dependents store packages max-depth) + "List all the things that would need to be rebuilt if PACKAGES are changed." + ;; Using %BAG-NODE-TYPE is more accurate than using %PACKAGE-NODE-TYPE + ;; because it includes implicit dependencies. + (define (get-dependents packages edges) + (let loop ((packages packages) + (result '()) + (depth 0) + (visited (setq))) + (if (> depth max-depth) + (values result visited) + (match packages + (() + (values result visited)) + ((head . tail) + (if (set-contains? visited head) + (loop tail result depth visited) + (let ((next (edges head))) + (call-with-values + (lambda () + (loop next + (cons head result) + (+ depth 1) + (set-insert head visited))) + (lambda (result visited) + (loop tail result depth visited)))))))))) + + (with-store store + (run-with-store store + (mlet %store-monad ((edges (node-back-edges %bag-node-type (all-packages)))) + (return (get-dependents packages edges)))))) + +(define (options->things-to-build store opts) "Read the arguments from OPTS and return a list of high-level objects to build---packages, gexps, derivations, and so on." (define (validate-type x) @@ -600,6 +643,13 @@ (define-public my-package (match type ('regular (list obj)) + (('dependents . depth) + (if (package? obj) + (begin + (info (G_ "computing dependents of package ~a...~%") + (package-full-name obj)) + (dependents store (list obj) depth)) + (list obj))) ('development (if (package? obj) (map manifest-entry-item @@ -661,6 +711,8 @@ (define-public my-package (loop tail 'regular (cons drv result))) (('development? . #t) (loop tail 'development result)) + (('dependents . depth) + (loop tail `(dependents . ,depth) result)) (_ (loop tail type result))))))) @@ -687,7 +739,7 @@ (define (options->derivations store opts) (systems systems))) (define things-to-build - (map transform (options->things-to-build opts))) + (map transform (options->things-to-build store opts))) (define warn-if-unsupported (let ((target (assoc-ref opts 'target))) diff --git a/tests/guix-build.sh b/tests/guix-build.sh index 3637bcdeb3..42e2ecafb1 100644 --- a/tests/guix-build.sh +++ b/tests/guix-build.sh @@ -196,6 +196,12 @@ test `guix build -D hello -d \ | grep -e 'glibc.*\.drv$' -e 'gcc.*\.drv$' -e 'binutils.*\.drv$' \ | wc -l` -ge 3 +# Building the dependents. +test `guix build -T1 libgit2 -T1 libssh -d \ + | grep -e 'guile-git.*\.drv$' -e 'guile-ssh.*\.drv$' \ + -e 'libgit2.*\.drv$' -e 'libssh.*\.drv$' \ + | wc -l` -eq 4 + # Unbound variable in thunked field. cat > "$module_dir/foo.scm" <) id 1tFsw2-0002cf-Ex for submit@debbugs.gnu.org; Tue, 26 Nov 2024 05:36:46 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44460) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFsvp-0002ar-9C for 74542@debbugs.gnu.org; Tue, 26 Nov 2024 05:36:34 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tFstd-00006z-D1; Tue, 26 Nov 2024 05:34:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=acgj0glEt7hanHQUf4oPk2R5nSiXvs7JtfKGwt4jdQ8=; b=VFMYY1xckA/1cY68C6n+ u0RkJahBdj6TniBcDBJB+QEcKqNjXwxz0SDObgS805f54PYn3Wube72/q67EdbTP7rLn7c+T+tOfo KdSTPl8tA5EqLllpYAQdJtcr/CFjaWzLtRMqnOcvgfN9DcmN1KItfjf9rbKKEeYHMBeJkrK9ozV8V 9mewSfX5KE/dhH9Bw4E2IxXLm4dxXiGdoOQe8CKR7YNVadWqJ+UmsEW7IURUT9BM833/Aprst8Edg xF3JLTs2r5Ng0do7gSUZWU072ilmCQbfBR6ESsXVM+FzkDCWrpIrrN5vnTg+QR872/QInt+gQ/oa1 H3DcnZvoRgO6hg==; From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 74542@debbugs.gnu.org Subject: [PATCH 07/11] import: gnome: Keep going upon HTTP errors. Date: Tue, 26 Nov 2024 11:33:46 +0100 Message-ID: X-Mailer: git-send-email 2.46.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74542 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * guix/import/gnome.scm (import-gnome-release): Do not re-raise condition C, emit a warning instead. Change-Id: I9a7c337a17d1f7ed4677398e7b0f383befca7d74 --- guix/import/gnome.scm | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/guix/import/gnome.scm b/guix/import/gnome.scm index 054ae44f7a..3ba8ae02e5 100644 --- a/guix/import/gnome.scm +++ b/guix/import/gnome.scm @@ -1,5 +1,5 @@ ;;; GNU Guix --- Functional package management for GNU -;;; Copyright © 2017, 2019, 2021 Ludovic Courtès +;;; Copyright © 2017, 2019, 2021, 2024 Ludovic Courtès ;;; Copyright © 2022 Maxim Cournoyer ;;; Copyright © 2022 Hartmut Goebel ;;; @@ -23,6 +23,8 @@ (define-module (guix import gnome) #:use-module (guix utils) #:use-module (guix packages) #:use-module (guix http-client) + #:use-module (guix diagnostics) + #:use-module (guix i18n) #:use-module (json) #:use-module (srfi srfi-1) #:use-module (srfi srfi-34) @@ -111,9 +113,12 @@ (define* (import-gnome-release package #:key (version #f)) releases)) (guard (c ((http-get-error? c) - (if (= 404 (http-get-error-code c)) - #f - (raise c)))) + (unless (= 404 (http-get-error-code c)) + (warning (G_ "failed to download from '~a': ~a (~s)~%") + (uri->string (http-get-error-uri c)) + (http-get-error-code c) + (http-get-error-reason c))) + #f)) (let* ((port (http-fetch/cached (string->uri (string-append "https://ftp.gnome.org/pub/gnome/sources/" -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 05:36:47 2024 Received: (at 74542) by debbugs.gnu.org; 26 Nov 2024 10:36:47 +0000 Received: from localhost ([127.0.0.1]:46208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFsw3-0002cn-1R for submit@debbugs.gnu.org; Tue, 26 Nov 2024 05:36:47 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44472) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFsvp-0002as-9B for 74542@debbugs.gnu.org; Tue, 26 Nov 2024 05:36:35 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tFste-00007E-Km; Tue, 26 Nov 2024 05:34:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=s3NlCK5g4EoLnXqtNocOLhHNwSIxIbo8INXA2YVICF4=; b=X89Gu1MjG/saIzuIZUf9 DdfF2susgi0GDgiRaOuoukxIkn8GRA/03wpLasld/2DGpqFkqv7ZdB8FKlCDtEKQ6MLnmv+HtXlws ALg1cgZ6Hk1rCda0Wpbr5iB/NqQp3+EooyG4vFVKDdq6b+kRUawpZOpgW3Sm0eMtAVkzzvyn0ZbNB CABGoWUumtluSNma4wqcCJbkGoS4WFGnNjlf+fY3S+Nri05JglzUNzFQspmbnekC450wmXkY5iwHh bWFCDf19tP5Y1Ufe8H3HrDdDo8LW2gmLLrMNnhaB8VoONeyCjkg71Y0rOZewPKcuIO0cMmUjgjpxY GenRwFXTJ/sqLw==; From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 74542@debbugs.gnu.org Subject: [PATCH 08/11] =?UTF-8?q?gnu-maintenance:=20=E2=80=98gnu-ftp?= =?UTF-8?q?=E2=80=99=20updater=20excludes=20GnuPG-hosted=20packages.?= Date: Tue, 26 Nov 2024 11:33:47 +0100 Message-ID: <3459c668f8e6ee0b195f4e1ec8eb437dd3c1ec6c.1732615193.git.ludo@gnu.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Debbugs-Cc: Christopher Baines , Josselin Poiret , Ludovic Court?s , Mathieu Othacehe , Simon Tournier , Tobias Geerinckx-Rice Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74542 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Since ftp://ftp.gnupg.org no longer exists, another updater should be used for packages with code fetched from mirror://gnupg. * guix/gnu-maintenance.scm (gnupg-hosted?): New procedure. (%gnu-ftp-updater): Exclude packages that match ‘gnupg-hosted?’. * guix/download.scm (%mirrors): Remove ftp://ftp.gnupg.org. Change-Id: I653877ad843da60281d3a234acc85743bee64856 --- guix/download.scm | 3 +-- guix/gnu-maintenance.scm | 6 +++++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/guix/download.scm b/guix/download.scm index e37c2195ee..d88ad0ee44 100644 --- a/guix/download.scm +++ b/guix/download.scm @@ -78,8 +78,7 @@ (define %mirrors "ftp://mirrors.dotsrc.org/gcrypt/" "ftp://ftp.heanet.ie/mirrors/ftp.gnupg.org/gcrypt/" "ftp://ftp.mirrorservice.org/sites/ftp.gnupg.org/gcrypt/" - "ftp://ftp.ring.gr.jp/pub/net/gnupg/" - "ftp://ftp.gnupg.org/gcrypt/") + "ftp://ftp.ring.gr.jp/pub/net/gnupg/") (gnome "https://download.gnome.org/" "http://ftp.gnome.org/pub/GNOME/") diff --git a/guix/gnu-maintenance.scm b/guix/gnu-maintenance.scm index 866b960a4a..b612b11c00 100644 --- a/guix/gnu-maintenance.scm +++ b/guix/gnu-maintenance.scm @@ -1025,15 +1025,19 @@ (define %gnu-updater (false-if-networking-error (gnu-hosted? package)))) (import import-gnu-release))) +(define gnupg-hosted? + (url-prefix-predicate "mirror://gnupg/")) + (define %gnu-ftp-updater ;; This is for GNU packages taken from alternate locations, such as - ;; alpha.gnu.org, ftp.gnupg.org, etc. It is obsolescent. + ;; alpha.gnu.org (ftp.gnupg.org is no longer available). It is obsolescent. (upstream-updater (name 'gnu-ftp) (description "Updater for GNU packages only available via FTP") (pred (lambda (package) (false-if-networking-error (and (not (gnu-hosted? package)) + (not (gnupg-hosted? package)) (pure-gnu-package? package))))) (import import-release*))) -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 05:37:22 2024 Received: (at 74542) by debbugs.gnu.org; 26 Nov 2024 10:37:22 +0000 Received: from localhost ([127.0.0.1]:46264 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFswb-0002fm-MP for submit@debbugs.gnu.org; Tue, 26 Nov 2024 05:37:22 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60950) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFswa-0002fU-Ce for 74542@debbugs.gnu.org; Tue, 26 Nov 2024 05:37:20 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tFsuO-0000Sb-2h; Tue, 26 Nov 2024 05:35:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=CoGqDz0fxhwpk2Eg8ySDIRaRYGrkmNVQjcD8SsCnGXY=; b=nvsuCe7PDLUBiV2D+pS7 iVfKwwL3hwsUKIGOBDSdBaWu1fJVfQFyRvWcByBMh2feqnthEDgXdS/YA+Y64s03x+YIPd6YaDiSk gY6ynlsgWupQAPGmvj6RvuUTSOuRA8eBl1K620ljv6EHc8VCDbSk9z6wjTmbAOJNB61GMrNGPa0GU vo0mdxGGAnRHWTs6Liej5djHcQrIcnUgDP91xYZgKwBzz4aps5JdyuLibLYVx6NEo0RshC6BhT6A7 kBwYGlKL3bUBoLj9ZDT5IsFWP1i353tmlxPLY3cIA81jjqMgMGEym48eaaqNtB115/U6a0Q6pxnQR QV7OydSiuL6DaQ==; From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 74542@debbugs.gnu.org Subject: [PATCH 10/11] =?UTF-8?q?guix=20build:=20Validate=20that=20the=20f?= =?UTF-8?q?ile=20passed=20to=20=E2=80=98-m=E2=80=99=20returns=20a=20manife?= =?UTF-8?q?st.?= Date: Tue, 26 Nov 2024 11:33:49 +0100 Message-ID: <5f26bd9db3ae03117474be2ec678d8dc72695102.1732615193.git.ludo@gnu.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Debbugs-Cc: Christopher Baines , Josselin Poiret , Ludovic Court?s , Mathieu Othacehe , Simon Tournier , Tobias Geerinckx-Rice Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74542 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * guix/scripts/build.scm (options->things-to-build)[ensure-manifest]: New procedure. Use it. Change-Id: If64c483d7079f441a296d5bd4e06e67f44cbb7bf --- guix/scripts/build.scm | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/guix/scripts/build.scm b/guix/scripts/build.scm index 565bfd48e9..1b0b006ad5 100644 --- a/guix/scripts/build.scm +++ b/guix/scripts/build.scm @@ -629,6 +629,12 @@ (define-public my-package (for-each validate-type lst) lst)) + (define (ensure-manifest x file) + (unless (manifest? x) + (raise (formatted-message (G_ "file '~a' does not return a manifest") + file))) + x) + (define system (or (assoc-ref opts 'system) (%current-system))) @@ -699,9 +705,11 @@ (define-public my-package (loop tail 'regular (append (map manifest-entry-item (manifest-entries - (load* manifest - (make-user-module '((guix profiles) - (gnu)))))) + (ensure-manifest + (load* manifest + (make-user-module '((guix profiles) + (gnu)))) + manifest))) result))) (('expression . str) (loop tail 'regular -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 05:37:25 2024 Received: (at 74542) by debbugs.gnu.org; 26 Nov 2024 10:37:25 +0000 Received: from localhost ([127.0.0.1]:46266 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFswf-0002g6-5z for submit@debbugs.gnu.org; Tue, 26 Nov 2024 05:37:25 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60920) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFswZ-0002fS-HS for 74542@debbugs.gnu.org; Tue, 26 Nov 2024 05:37:21 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tFsuM-0000HR-Gq; Tue, 26 Nov 2024 05:35:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=IvFL757UmbVE9HTsId8rEfePRLq4bgwscx0vxswRNgs=; b=IGCGDH8EW36d4en854L0 j0QFdMau805i4RRnzqygRhEqeTiA6ZdxYAbe5ltZbLFrpsDxIDOj7ZTAFxU3T/nZIFrkbkNKRJVOA 2mH7zok9iPr0dH1Cwh2CvNNzKQXvrZc57HcaV4Tji7nMcnFx7I/PDEFUf3DZ/rGJvNoXPr9yZKOEB THzUQcDX8vRylJuXaJxIwjEDM64CwwAS0olMZoSIEA5irRBSm1r7F4EOBLOmIN6i2V2IQlxAIVBnB E9FhSauDhn840f8CRJVV+bnY9kxuldnXWnkX8UpoV65WgkmGy3Gar/CDo/R4uf315aiBNTC4PA/ut tAEXUKe/889shw==; From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 74542@debbugs.gnu.org Subject: [PATCH 09/11] gnu: Update updater properties for GnuPG-related packages. Date: Tue, 26 Nov 2024 11:33:48 +0100 Message-ID: X-Mailer: git-send-email 2.46.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74542 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/gnupg.scm (libgpg-error)[properties]: Remove. (libgcrypt)[properties]: Remove. (libassuan)[properties]: Remove. (libksba)[properties]: Remove. (npth)[properties]: Remove. (gnupg)[properties]: Remove. (gpgme)[properties]: Remove. (pinentry-tty)[properties]: Change for ‘generic-html’. (gpa)[properties]: Remove. Change-Id: I1eb9d6ad5bb3ecbfbef3d44dbae281a3de7ebac7 --- gnu/packages/gnupg.scm | 40 ++++++++++++---------------------------- 1 file changed, 12 insertions(+), 28 deletions(-) diff --git a/gnu/packages/gnupg.scm b/gnu/packages/gnupg.scm index 2e97c2244a..3f55ccaf5b 100644 --- a/gnu/packages/gnupg.scm +++ b/gnu/packages/gnupg.scm @@ -1,5 +1,5 @@ ;;; GNU Guix --- Functional package management for GNU -;;; Copyright © 2012-2021, 2023 Ludovic Courtès +;;; Copyright © 2012-2021, 2023, 2024 Ludovic Courtès ;;; Copyright © 2013, 2015, 2018 Andreas Enge ;;; Copyright © 2014, 2018 Eric Bavier ;;; Copyright © 2014, 2015, 2016, 2020 Mark H Weaver @@ -160,9 +160,7 @@ (define-public libgpg-error for all GnuPG components. Among these are GPG, GPGSM, GPGME, GPG-Agent, libgcrypt, Libksba, DirMngr, Pinentry, SmartCard Daemon and possibly more in the future.") - (license license:lgpl2.0+) - (properties '((ftp-server . "ftp.gnupg.org") - (ftp-directory . "/gcrypt/libgpg-error"))))) + (license license:lgpl2.0+))) (define-public libgcrypt (package @@ -217,9 +215,7 @@ (define-public libgcrypt standard cryptographic building blocks such as symmetric ciphers, hash algorithms, public key algorithms, large integer functions and random number generation.") - (license license:lgpl2.0+) - (properties '((ftp-server . "ftp.gnupg.org") - (ftp-directory . "/gcrypt/libgcrypt"))))) + (license license:lgpl2.0+))) (define-public libassuan (package @@ -250,9 +246,7 @@ (define-public libassuan protocol. This protocol is used for IPC between most newer GnuPG components. Both, server and client side functions are provided.") - (license license:lgpl2.0+) - (properties '((ftp-server . "ftp.gnupg.org") - (ftp-directory . "/gcrypt/libassuan"))))) + (license license:lgpl2.0+))) (define-public libksba (package @@ -283,9 +277,7 @@ (define-public libksba "KSBA (pronounced Kasbah) is a library to make X.509 certificates as well as the CMS easily accessible by other applications. Both specifications are building blocks of S/MIME and TLS.") - (license license:gpl3+) - (properties '((ftp-server . "ftp.gnupg.org") - (ftp-directory . "/gcrypt/libksba"))))) + (license license:gpl3+))) (define-public npth (package @@ -307,9 +299,7 @@ (define-public npth In contrast to GNU Pth is is based on the system's standard threads implementation. This allows the use of libraries which are not compatible to GNU Pth.") - (license (list license:lgpl3+ license:gpl2+)) ; dual license - (properties '((ftp-server . "ftp.gnupg.org") - (ftp-directory . "/gcrypt/npth"))))) + (license (list license:lgpl3+ license:gpl2+)))) ;dual license (define-public gnupg (package @@ -404,9 +394,7 @@ (define-public gnupg servers. It includes several libraries: libassuan (IPC between GnuPG components), libgpg-error (centralized GnuPG error values), and libskba (working with X.509 certificates and CMS data).") - (license license:gpl3+) - (properties '((ftp-server . "ftp.gnupg.org") - (ftp-directory . "/gcrypt/gnupg"))))) + (license license:gpl3+))) (define-public gnupg-1 (package (inherit gnupg) @@ -463,9 +451,7 @@ (define-public gpgme programming task, it is suggested that all software should try to use GPGME instead. This way bug fixes or improvements can be done at a central place and every application benefits from this.") - (license license:lgpl2.1+) - (properties '((ftp-server . "ftp.gnupg.org") - (ftp-directory . "/gcrypt/gpgme"))))) + (license license:lgpl2.1+))) (define-public gpgme-1.23 (hidden-package @@ -886,9 +872,9 @@ (define-public pinentry-tty "Pinentry provides a console that allows users to enter a passphrase when @code{gpg} is run and needs it.") (license license:gpl2+) - (properties '((ftp-server . "ftp.gnupg.org") - (ftp-directory . "/gcrypt/pinentry") - (upstream-name . "pinentry"))))) + (properties + '((release-monitoring-url . "https://gnupg.org/ftp/gcrypt/pinentry/") + (upstream-name . "pinentry"))))) (define-public pinentry-emacs (package @@ -1134,9 +1120,7 @@ (define-public gpa "GPA, the GNU Privacy Assistant, is a graphical user interface for @uref{https://gnupg.org, GnuPG}. It can be used to encrypt, decrypt, and sign files, to verify signatures, and to manage the private and public keys.") - (license license:gpl3+) - (properties '((ftp-server . "ftp.gnupg.org") - (ftp-directory . "/gcrypt/gpa"))))) + (license license:gpl3+))) (define-public parcimonie (package -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 05:37:26 2024 Received: (at 74542) by debbugs.gnu.org; 26 Nov 2024 10:37:26 +0000 Received: from localhost ([127.0.0.1]:46268 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFswf-0002gA-QL for submit@debbugs.gnu.org; Tue, 26 Nov 2024 05:37:26 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60934) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFswa-0002fT-Cj for 74542@debbugs.gnu.org; Tue, 26 Nov 2024 05:37:21 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tFsuO-0000T1-UX; Tue, 26 Nov 2024 05:35:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=yrwyfajQUwJrMTFkU5RfFAhrmVeKfBlbsu7ncWd18mg=; b=LAwWxWginKDqJiGf/Z1x cqZChG+xLhIFWcDgPxi7/kpiR8CSXnL+ayBcykUlvbdaHMJaRcDNZ1Ja0v15sIeECMIkd5CyM3PZC XczeVxQTgC4smlbLDwyZvqWNvNk+Zx/JXZvMlbeGfGvpn+BsBl9tNnremu+PRtfID2OIkUsIFwVsg BEdvLvXlMPdH3CU6qEKxYm5z9SX6jrX943HElZVE/tKXj1mUWQhdNQgtWfQJon5tS8KoXO8/I7nsk W1HwTmdHKQwd8B3wXQ+bdhHe1a2ECDDSQGjvQmwTMJUZaI0odKHI6alao5bqj8a4XkYCg80GBAwTK pShqp4dPyWesIA==; From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 74542@debbugs.gnu.org Subject: [PATCH 11/11] etc: Add upgrade manifest. Date: Tue, 26 Nov 2024 11:33:50 +0100 Message-ID: X-Mailer: git-send-email 2.46.0 In-Reply-To: References: MIME-Version: 1.0 X-Debbugs-Cc: Christopher Baines , Josselin Poiret , Ludovic Court?s , Mathieu Othacehe , Simon Tournier , Tobias Geerinckx-Rice Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74542 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * guix/scripts/build.scm (dependents): Export. * etc/upgrade-manifest.scm: New file. * Makefile.am (EXTRA_DIST): Add it. Change-Id: I1b2a2ebd09e559c68da9f25772bf33caacb4c031 --- Makefile.am | 1 + etc/upgrade-manifest.scm | 98 ++++++++++++++++++++++++++++++++++++++++ guix/scripts/build.scm | 2 + 3 files changed, 101 insertions(+) create mode 100644 etc/upgrade-manifest.scm diff --git a/Makefile.am b/Makefile.am index e94ba87797..0cff32c607 100644 --- a/Makefile.am +++ b/Makefile.am @@ -743,6 +743,7 @@ EXTRA_DIST += \ etc/source-manifest.scm \ etc/system-tests.scm \ etc/time-travel-manifest.scm \ + etc/upgrade-manifest.scm \ scripts/guix.in \ tests/cve-sample.json \ tests/keys/civodul.pub \ diff --git a/etc/upgrade-manifest.scm b/etc/upgrade-manifest.scm new file mode 100644 index 0000000000..6dd605ef03 --- /dev/null +++ b/etc/upgrade-manifest.scm @@ -0,0 +1,98 @@ +;;; GNU Guix --- Functional package management for GNU +;;; Copyright © 2024 Ludovic Courtès +;;; +;;; This file is part of GNU Guix. +;;; +;;; GNU Guix is free software; you can redistribute it and/or modify it +;;; under the terms of the GNU General Public License as published by +;;; the Free Software Foundation; either version 3 of the License, or (at +;;; your option) any later version. +;;; +;;; GNU Guix is distributed in the hope that it will be useful, but +;;; WITHOUT ANY WARRANTY; without even the implied warranty of +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;;; GNU General Public License for more details. +;;; +;;; You should have received a copy of the GNU General Public License +;;; along with GNU Guix. If not, see . + +;; This manifest computes upgrades of key packages using the 'with-latest' +;; package transformation. + +(use-modules (guix monads) + (guix graph) + (guix packages) + (guix profiles) + (guix store) + (guix transformations) + ((guix scripts build) #:select (dependents)) + ((guix scripts graph) #:select (%bag-node-type)) + ((guix import github) #:select (%github-api)) + (guix build-system gnu) + (guix build-system cmake) + ((gnu packages) #:select (all-packages)) + (ice-9 match) + (srfi srfi-1)) + +;; Bypass the GitHub updater: we'd need an API token or we would hit the rate +;; limit. +(%github-api "http://example.org") + +(define (leaf-packages) + (with-store store + (run-with-store store + (mlet %store-monad ((edges (node-back-edges %bag-node-type (all-packages)))) + (return (filter (lambda (package) + (null? (edges package))) + (all-packages))))))) + +(define security-packages + '("git" "git-minimal" + "xorg-server" + "elogind" + "openssl" + "gnutls" + "libarchive" + "libgit2" + "libssh" + + ;; GnuPG. + "libassuan" + "libgpg-error" + "libgcrypt" + "libksba" + "npth" + "gnupg" + "gpgme" + "pinentry")) + +(define security-upgrades + ;; Upgrades of individual packages with their dependents built against that + ;; upgrade. + (manifest + (with-store store + (append-map (match-lambda + ((package . output) + (let* ((name (package-name package)) + (latest (options->transformation + `((with-latest . ,name))))) + (map (lambda (package) + (manifest-entry + (inherit (package->manifest-entry + (latest (pk 'latest package)))) + (name (string-append (package-name package) + "-with-latest-" name)))) + (dependents store (list package) 2))))) + (specifications->packages security-packages))))) + +(define leaf-package-updates + ;; Select a subset (~22%) of all the leaf packages, typically small C/C++ + ;; packages not part of a bigger "collection" or repo (CRAN, PyPI, etc.). + (manifest + (filter-map (lambda (package) + (and (memq (package-build-system package) + (list gnu-build-system cmake-build-system)) + (package-with-upstream-version (pk 'up package)))) + (leaf-packages)))) + +(concatenate-manifest (list leaf-package-updates security-upgrades)) diff --git a/guix/scripts/build.scm b/guix/scripts/build.scm index 1b0b006ad5..ddebcaf743 100644 --- a/guix/scripts/build.scm +++ b/guix/scripts/build.scm @@ -63,6 +63,8 @@ (define-module (guix scripts build) show-cross-build-options-help show-native-build-options-help + dependents + guix-build register-root register-root*)) -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 09:43:07 2024 Received: (at 74542) by debbugs.gnu.org; 26 Nov 2024 14:43:07 +0000 Received: from localhost ([127.0.0.1]:48328 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFwmQ-0005fj-M1 for submit@debbugs.gnu.org; Tue, 26 Nov 2024 09:43:07 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46520) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFwmO-0005fB-El for 74542@debbugs.gnu.org; Tue, 26 Nov 2024 09:43:05 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tFwmG-0005i9-K7; Tue, 26 Nov 2024 09:42:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=HtfNtRqHmUcNQeHkV9Inpr7ToGgkYeRl+JN3jkhaflo=; b=gX9CoKPBpzb05Y56dSVd LhkKg3MCbmcGppglHUmkgwikHYqD3inqIB3F2ce3CqLZ6qF0NHQZGniN8CJihTw6SMX47YBIYc97h KLmgrJJdM16iCiAnuufJrHiiOyhW+6FIeYDqTOhPQVoEhjBPyq9F6jZuh4bCNgD5MbYG2pqAxX92Q dOYActdFeIc1McG+UFMuASsBkBdI0RDc1k4lczOIl50JLvTx6e/REs1/riF5xT5xQLQIKJn9Styiu d/83Y30VmAvn6TEg81KklYDFhyskEAnUAqwYZp1qqAPxzMEh58WhrZJ/jJpXJu7ThH/TbW+TpjKGH LsNlQ/ll3amb+Q==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: 74542@debbugs.gnu.org Subject: Re: [bug#74542] [PATCH 00/11] Improved tooling for package updates In-Reply-To: ("Ludovic =?utf-8?Q?Court?= =?utf-8?Q?=C3=A8s=22's?= message of "Tue, 26 Nov 2024 11:32:17 +0100") References: Date: Tue, 26 Nov 2024 15:42:51 +0100 Message-ID: <87h67ucaz8.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74542 Cc: Tobias Geerinckx-Rice , Christopher Baines , Josselin Poiret , Simon Tournier , Mathieu Othacehe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Ludovic Court=C3=A8s skribis: > I already toyed with this idea here: > > https://guix.bordeaux.inria.fr/jobset/guix-hpc-cutting-edge > https://gitlab.inria.fr/guix-hpc/guix-hpc/-/blob/master/cutting-edge.ma= nifest?ref_type=3Dheads > > It=E2=80=99s experimental; surely we=E2=80=99ll find that the manifest ne= eds to be > tweaked, or that some of the updaters abort to early. But I think > it can help, and it=E2=80=99s a good way to use available x86_64 CPU power > at ci.guix. Another point: having a single =E2=80=9Cupgrade manifest=E2=80=9D probably = won=E2=80=99t scale, first because it takes time to evaluate it (looking for the latest upstream version of all these packages), second because the jobset will be messy if it contains tons of unrelated upgrades. So I=E2=80=99m thinking that probably we=E2=80=99ll want focused upgrade ma= nifests: one for selected security-critical packages, one for the astronomy packages so Sharlatan can save a bit on energy at home ;-), one for R packages, and so on. Another one I=E2=80=99d like to have: automatic ungrafting so that we could apply ungrafting packages =E2=80=9Canytime=E2=80=9D (ideally!). The sky=E2=80=99s the limit! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 10:50:29 2024 Received: (at 74542) by debbugs.gnu.org; 26 Nov 2024 15:50:29 +0000 Received: from localhost ([127.0.0.1]:50138 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFxpd-0000pm-B6 for submit@debbugs.gnu.org; Tue, 26 Nov 2024 10:50:29 -0500 Received: from mail-wm1-f48.google.com ([209.85.128.48]:48494) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFxpb-0000pX-PZ for 74542@debbugs.gnu.org; Tue, 26 Nov 2024 10:50:28 -0500 Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-434a8640763so4701025e9.1 for <74542@debbugs.gnu.org>; Tue, 26 Nov 2024 07:50:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732636167; x=1733240967; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=MqftykJoMWmB/Lt0ERzHcGZW43g8EHiDX+0kOOsUFck=; b=DbFa3dvbo1rvv8D7qgqW++1kg9zlBUS+QMI4IE88oNptluLLuHopPv3s/JD0+8DNDQ c460RHV9YrRIwWQ4DRUJmq0ZUhgF9Qbx2k++x0DFlYJy0/8bVn75brWB+Z2CqJ9pEXqV 8nTj1bQDzOivQLpa2Q8LnkOM6xoJDXkM4XcvK4NVSgUOBv9/Q65Dbs/47GAkMzi1x/Lq nHPjWZeoEWoAFjbtXYgrJFhQyQwt0m1B+IlLNDF5NnETyh4M/i5NePacyvER0EG829uf hwJGrDdax1e6nATzb4nhMST/ph2NKnVk26DNP1I/0UO458WtHRM6wTXwSkXbKJ/LeMSC 3GEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732636167; x=1733240967; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MqftykJoMWmB/Lt0ERzHcGZW43g8EHiDX+0kOOsUFck=; b=pr52ZLhwYw+rTW4B52hWXkqqz2nDhbm7/14teg4hqkcZoSMQCNyKQwbJUdR9oU9kje LlZjL99XkvsbLWlBLnkFFdoSYT9NAXwQ1qMtyJqt8dDseX33Bk67uaWHO+NNTzPazgy2 g4RMHZOndbL3HcrlvsN7aAes2a5c0sNwQWWOVJjC20FvN94TJNG8w/OVMp46heBDWGX5 HefbUrmaD5romUM7uUH1PnZ6iRTSyZBbaVse4GGbUxKH1AGbaWeyazGuu7hs4hQlUwtR gmbby2w8KFYF1eHh/I95vB/t1r8OvxiorILVi6TG2zoBD0tQR3cplCg1RWYuFYc9eWhQ 5+Lg== X-Forwarded-Encrypted: i=1; AJvYcCVAQ+3eYB7mIx3BZI0TTvJiI4TvNaCbcU5M8pZ2sbvNPYKJh2+WS1OJQGKC205GJNsj/PndmA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YweEds4JQdCDa7uBIaG2o4/m/put/OUqnxyM9qqmGWMgPhCYicJ hhlmKf3WAwhnfPDgCTW65IUEz0c1SP/AQCjNX1vg1Jn8n8ukCfuu X-Gm-Gg: ASbGnctvM7tWO3HkhtoT/HLioeMJzD8KHIw6WCBu7stBnWCG7GN5gyAnQjAtcVsBoNp Tscgh4Lbs/Zvg501r4/EDyxTeWXkV9ZGgjZnMDp6+GCzeXvx/ANza3/NQRgiqXyasRAU8lg+L+E iRYhvpWT1xPBtGJsQuVnKgXuvdclVdtb8Y4ZASZy5+Z/swJ/TpxZZ8JW83mM+mvjscttCd2NmeV HF5+PtRXBs+og3BHdjdVtpKg1eFH/a3ADwwdEdLsfO33WQ= X-Google-Smtp-Source: AGHT+IGcV2+zGK7E/ISu0eC1VKNaMJUiRF8G2lX/AArsV9+lLT0OGdIQe7Mg90X3Z4lF+etS4fQVXw== X-Received: by 2002:a05:600c:c0d:b0:434:a7b6:10e9 with SMTP id 5b1f17b1804b1-434a7b613femr23236025e9.17.1732636165053; Tue, 26 Nov 2024 07:49:25 -0800 (PST) Received: from lili ([2a01:e0a:59b:9120:5ac:5c58:da2a:61ba]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-433b01e115asm238460735e9.6.2024.11.26.07.49.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Nov 2024 07:49:24 -0800 (PST) From: Simon Tournier To: Ludovic =?utf-8?Q?Court=C3=A8s?= , 74542@debbugs.gnu.org Subject: Re: [bug#74542] [PATCH 00/11] Improved tooling for package updates In-Reply-To: References: Date: Tue, 26 Nov 2024 15:59:53 +0100 Message-ID: <8734je3us6.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74542 Cc: Christopher Baines , Ludovic Court?s , Tobias Geerinckx-Rice , Josselin Poiret , Mathieu Othacehe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, On Tue, 26 Nov 2024 at 11:32, Ludovic Court=C3=A8s wrote: > This patch series aims to improve tooling for package upgrades: > > =E2=80=A2 By adding a =E2=80=98--dependents=E2=80=99 option to =E2=80= =98guix build=E2=80=99 to build > dependent packages (those returned by =E2=80=98guix refresh -l=E2=80= =99). This > was suggested by my colleague Romain Garbage, who also prototyped > a variant of this. > > =E2=80=A2 By improving individual updaters and updating metadata for > some packages. Cool! > > =E2=80=A2 By adding an =E2=80=9Cupgrade manifest=E2=80=9D, to automatic= ally build the latest > version (using the =E2=80=98with-latest=E2=80=99 package transformati= on) of a few > security-critical packages along with their dependents at distance 2, > as well as some of the leaf packages. I am more reserved here. --8<---------------cut here---------------start------------->8--- scheme@(guix-user)> (define all-leafs (leaf-packages)) scheme@(guix-user)> (length all-leafs) $2 =3D 13680 scheme@(guix-user)> (define leaf-to-updates (filter-map (lambda (package) (and (memq (package-build-system package) (list gnu-build-system cmake-build-system)) package)) all-leafs)) scheme@(guix-user)> (length leaf-to-updates) $3 =3D 2843 --8<---------------cut here---------------end--------------->8--- This list contains multiversion packages, for instance: "clang" "clang" "clang" "gccgo" "gccgo" "gccgo" "gccgo" "gccgo" "glibc" "glibc" "glibc" "glibc" "glibc" "glibc-locales" "glibc-locales-2.29" "glibc-locales-2.30" "glibc-locales-2.31" "glibc-locales-2.32" "glibc-locales-2.33" "glibc-locales-2.35" "linux-libre" "linux-libre" "linux-libre" "linux-libre" "linux-libre" "linux-libre-arm-generic" "linux-libre-arm-generic" "linux-libre-arm-generic" "linux-libre-arm-generic" "linux-libre-arm-omap2plus" "linux-libre-arm-omap2plus" "linux-libre-arm64-generic" "linux-libre-arm64-generic" "linux-libre-arm64-generic" "linux-libre-arm64-generic" "linux-libre-arm64-honeycomb" "linux-libre-documentation" "linux-libre-headers" "linux-libre-headers" "linux-libre-headers" "linux-libre-headers" "linux-libre-headers" "linux-libre-headers" =20 And this list also contains PyPI, for instance: "pyconfigure" "pypy" "python-cffi-documentation" "python-clingo-dl" "python-debug" "python-graph-tool" "python-libfreenect" "python-libmpsse" "python-libsvm" "python-next" "python-on-guile" "python-openturns" "python-sepolgen" "python2-dbus" "python2-minimal" Maybe, we could be a bit more stringent on the list and filter out more packages than only the ones based on build-systems. Well, it could be helpful to avoid to burn resources for nothing. For example, it could be better to exclude the GitHub importer instead of bypassing it with a wrong URL. > Ludovic Court=C3=A8s (11): > transformations: Export =E2=80=98package-with-upstream-version=E2=80=99. > gnu-maintenance: =E2=80=98import-html-release=E2=80=99 doesn=E2=80=99t = abort upon HTTP 404. > gnu-maintenance: Savannah/Xorg updaters no longer abort on network > errors. > build: Add =E2=80=98--development=E2=80=99 option. > packages: Factorize =E2=80=98all-packages=E2=80=99. > guix build: Add =E2=80=98--dependents=E2=80=99. > import: gnome: Keep going upon HTTP errors. > gnu-maintenance: =E2=80=98gnu-ftp=E2=80=99 updater excludes GnuPG-hoste= d packages. > gnu: Update updater properties for GnuPG-related packages. > guix build: Validate that the file passed to =E2=80=98-m=E2=80=99 retur= ns a manifest. > etc: Add upgrade manifest. Let review patch by patch. :-) Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 10:50:34 2024 Received: (at 74542) by debbugs.gnu.org; 26 Nov 2024 15:50:34 +0000 Received: from localhost ([127.0.0.1]:50142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFxph-0000q9-Sr for submit@debbugs.gnu.org; Tue, 26 Nov 2024 10:50:34 -0500 Received: from mail-wm1-f44.google.com ([209.85.128.44]:54461) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFxpd-0000pl-BD for 74542@debbugs.gnu.org; Tue, 26 Nov 2024 10:50:31 -0500 Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-43155abaf0bso53316585e9.0 for <74542@debbugs.gnu.org>; Tue, 26 Nov 2024 07:50:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732636168; x=1733240968; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=eiTCxSVU1TAiqLWXRFkq8dDmzSN1cYJeAI8x4s7y9bc=; b=OX3OQv0FOK0ciXfRFFSA/y7sDuflCSPADgrr6RQ8mBhF7ecADDx5Fk+9WL8+l+CT4p lPNjpHGh3PY8aFeCRKivMhvM0JgwT+155db2RzC4MTAL2MZXvh3jjvt87yJA3JAgtJAr dJTBdAC4kgVGoFCosGVqrVAOH+1058S6EH3W34G9A41OJDKaGEL8vqDxjZo2E5FcakWm d9EUCYiilxhRz6EUHib2TOuWhmqPWG0m95GrKqgVecqGDxLlpDzcOlY4cvxs+bYisnK4 wOBIgn4Ic5ZWsEfdslfBCjwRcPOAjRi4nqTO4mPKhLIr2nePbZwQX9DqrZva37V5WxEE PW0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732636168; x=1733240968; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eiTCxSVU1TAiqLWXRFkq8dDmzSN1cYJeAI8x4s7y9bc=; b=eqE8asYp2gChXtGEEaVfMRMx72sFpZVxGuEUOnHYXb6MwM643jtrrZZltE0MvIztmx gaiyzs/WEr4kyighBACuz4Dw4TjMV6urm9CfRWI8STBVTii06aXVekKq/OX2jKhB7816 uv/hapiLF5i2RqtLuegT9Q0Lv1UYdRlqEby8i/P06MNeEMsgerVgveO5n00NnpM5Bmyi MSDM2dUiNpowf9aIge8ctgfrWyVkUXgncBPqL58klh5xnHVG/mh3ZF76ZzY2xzGoZ8wy AD1meDp90dY2S8xj3mDj5pBnwTvktj31Iqqo/+lAOpFCn0ZgBXVFXbs8Gc6bA8IOnEsh MbIQ== X-Forwarded-Encrypted: i=1; AJvYcCXoZsuYyYOhTKOp1980YTZYFhTb8ZP4xXoTdkxO/r16X5xEGJYp3D26wZDi5+TvHdnrkYHUlg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwolYH+kUZSbbmJglplCrcWnBnIY2e9Q8BdYksvkCeK27Inr8SE USUhMYZ16fX9MqcEoq6AzbcSNjLho337i9XMHU4fz1YnFuMnZyst X-Gm-Gg: ASbGnctLt1hkMtaX6bon13Qn5JV10KVgJdL/6qu72yv48VkI9odCA/IfMUVTkXrSDn5 Ja5YZazhN0/PrmAvIzRiQLMRVL8uYmIsXqJOmFsTjJc8Ga9Ayfr78p9x9Shof3FsCzErtquHwZh hDGQilB813KUiskjkZwr4cTPG0ytZMDz5ix/d0y8veSHtu85oWxhSjfdZWsI/mx3ImZX7tnD1O5 XJP1H5IbfDEvO1c99KpFM3gWNfQ8h01cqXynEtlMjO4G1Q= X-Google-Smtp-Source: AGHT+IGQ2v0yq/r0Lqo7DbHnIeCG6oVzS3JjaxEA2zvUUswwKJiZhiiHfsPhR0EsLQHMzW+2hhBRkg== X-Received: by 2002:a05:600c:cc8:b0:434:9e46:5bc with SMTP id 5b1f17b1804b1-4349e460761mr94924955e9.10.1732636168480; Tue, 26 Nov 2024 07:49:28 -0800 (PST) Received: from lili ([2a01:e0a:59b:9120:5ac:5c58:da2a:61ba]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-434a36b83d5sm40694295e9.44.2024.11.26.07.49.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Nov 2024 07:49:28 -0800 (PST) From: Simon Tournier To: Ludovic =?utf-8?Q?Court=C3=A8s?= , 74542@debbugs.gnu.org Subject: Re: [bug#74542] [PATCH 02/11] gnu-maintenance: =?utf-8?Q?=E2=80=98import-html-release=E2=80=99_doesn=E2=80=99t?= abort upon HTTP 404. In-Reply-To: <92c108d975939b5dece3fb86ac7bce1edaf619a4.1732615193.git.ludo@gnu.org> References: <92c108d975939b5dece3fb86ac7bce1edaf619a4.1732615193.git.ludo@gnu.org> Date: Tue, 26 Nov 2024 16:09:50 +0100 Message-ID: <87v7wa2fr5.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74542 Cc: Christopher Baines , Ludovic Court?s , Tobias Geerinckx-Rice , Josselin Poiret , Mathieu Othacehe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, On Tue, 26 Nov 2024 at 11:33, Ludovic Court=C3=A8s wrote: > + #:use-module (srfi srfi-34) [...] > + (guard (c ((http-get-error? c) > + (warning (G_ "failed to download '~a': ~a (~a)~%") > + url (http-get-error-code c) > + (http-get-error-reason c)) > + '())) > + (let* ((uri (string->uri url)) > + (port (http-fetch/cached uri #:ttl 3600)) > + (sxml (html->sxml port))) > + (close-port port) > + (delete-duplicates (html-links sxml))))) I=E2=80=99m always confused by which framework for exception does the proje= ct rely on? There is old =E2=80=99catch=E2=80=99 and =E2=80=99throw=E2=80=99 = then sometimes new =E2=80=99with-exception-handler=E2=80=99 and =E2=80=99raise=E2=80=99. And = also SRFI 34. What=E2=80=99s the preferred convention? Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 10:50:38 2024 Received: (at 74542) by debbugs.gnu.org; 26 Nov 2024 15:50:38 +0000 Received: from localhost ([127.0.0.1]:50147 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFxpm-0000qc-7V for submit@debbugs.gnu.org; Tue, 26 Nov 2024 10:50:38 -0500 Received: from mail-wm1-f45.google.com ([209.85.128.45]:59684) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFxph-0000pY-14 for 74542@debbugs.gnu.org; Tue, 26 Nov 2024 10:50:33 -0500 Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-434a742481aso6279215e9.3 for <74542@debbugs.gnu.org>; Tue, 26 Nov 2024 07:50:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732636167; x=1733240967; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=IwuXal/GbQKf5W6rL71UMUu26vNVtZ6lIoT5MjCM4oM=; b=UmlYtfJo7yAeSdQohy7u/8eM7t1W05dLZkw4aAgHTSkPW6YhXhG1gUPPeCSLseu147 QBU5X52ZNBYdcmBr4TPqoerYLl/bhjpR5LXLuli6k0vQjp9NXP8NxTewROzVr32S26VW e9Ppu0T4dT4abiFrEzpJ0lU1QAcgeV3CFHtT6INxNmqlyyryualuAThKOuZO88eu8Xdo oFzxkJ5TZ1iE5zx1NHBYKgPo66UUa1U+GUmOizXawwL32N18Zuby9VCBVJbGpGu/Demd /3yyTDfnEsQED2t0F8szooLUwjD6WMIqBM/t3G0u44QeI1ClfxkN6K12gTd5J4d2d+yi jfNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732636167; x=1733240967; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IwuXal/GbQKf5W6rL71UMUu26vNVtZ6lIoT5MjCM4oM=; b=OvnMjnCP3ubRz9ALsC8r9+K5QN/zMXGqshKa3bwJR605H2wCIYw5zZpU824SYvzJmf +Xh1TP/NLypqfme3IVXQ4yNFZrLo6UaDMHj8Btzz+hPaUHilCzEMstrVcYPcURHyAwjw u2ICVgOufKlkw1yMe23tfcfcfWLCZJ3Kp9+cJ22Fzq+AqxGBHnnP6uufNdmVzdC4q+x5 oMVqnOC7NfFzovaIiqhqZnctbjheHNtlBV1vkGfy7tVX9MSSiseVKv+lzOR7qsNoEFsd LbBZbSb744wqXZWUloIEXMUgTYIXLXrqRr5CVrZhe8c3dNP6oqZzUT3YqrUD9XKAyLo3 gNZw== X-Forwarded-Encrypted: i=1; AJvYcCX1CZjFcga3ne1/Mc7QcC1e9j5qyLK4jS3XO/QO13PjvksFqcHR4V1dRzlhENTzyXSuTjHq4A==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyyAYzV5oLBpmli0duyhV8zmDHcGIZH2Uamoi6KVGYM5RtadAQI LHZaZ1mNAyt+9920mVZBw/RINMkFn9ZDBVkmPrfycBuMIX5okEKS X-Gm-Gg: ASbGnctc0tdg3ttL5SLu5+alZqY6Y6WNq0KCfGPdK2xlIUovisaiK2lBEhIcsyLeTNZ Sdx249WSvTEnfVd6JV58FZ3HUqqigYT6rrq8+W5jFc8lBpNM9vrDSvLEsf1YSzrVKaNLSrr8bpH xnA2/ZV0DSbXqJekFWYqEOEaDdsQ1u0OxgnleNl/xpEiG/PTCwE1F5mLrGYkTfW35NeOhEEwMi6 K/cbv7sdjr1AHKfGh5MmlRr06l2/wcse0eyvRhWxftYLVA= X-Google-Smtp-Source: AGHT+IH9NAVzInmHFEztmtZzAxbtz5XA62JJGld8pRJ9cyk0ZkeosQipR9HEndPvKE/KcU7gcCJ+Sw== X-Received: by 2002:a05:600c:21d3:b0:434:9936:c828 with SMTP id 5b1f17b1804b1-4349936c93fmr111645815e9.12.1732636167129; Tue, 26 Nov 2024 07:49:27 -0800 (PST) Received: from lili ([2a01:e0a:59b:9120:5ac:5c58:da2a:61ba]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3825fb2760asm13588198f8f.52.2024.11.26.07.49.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Nov 2024 07:49:26 -0800 (PST) From: Simon Tournier To: Ludovic =?utf-8?Q?Court=C3=A8s?= , 74542@debbugs.gnu.org Subject: Re: [bug#74542] [PATCH 01/11] transformations: Export =?utf-8?Q?=E2=80=98package-with-upstream-version=E2=80=99=2E?= In-Reply-To: <7758b6e93f83b69a2c5a402447df65c563d6ace0.1732615193.git.ludo@gnu.org> References: <7758b6e93f83b69a2c5a402447df65c563d6ace0.1732615193.git.ludo@gnu.org> Date: Tue, 26 Nov 2024 16:00:43 +0100 Message-ID: <87zflm2g6c.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74542 Cc: Christopher Baines , Ludovic Court?s , Tobias Geerinckx-Rice , Josselin Poiret , Mathieu Othacehe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Tue, 26 Nov 2024 at 11:33, Ludovic Court=C3=A8s wrote: > * guix/transformations.scm (package-with-upstream-version): Export. > > Change-Id: I8e09e69e9c32bffc329c97ef1c0258f750181b11 > --- > guix/transformations.scm | 2 ++ > 1 file changed, 2 insertions(+) LGTM! Good to start with the simplest. :-) From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 10:50:39 2024 Received: (at 74542) by debbugs.gnu.org; 26 Nov 2024 15:50:39 +0000 Received: from localhost ([127.0.0.1]:50149 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFxpm-0000qe-Hr for submit@debbugs.gnu.org; Tue, 26 Nov 2024 10:50:38 -0500 Received: from mail-wm1-f45.google.com ([209.85.128.45]:48146) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFxpi-0000qG-JJ for 74542@debbugs.gnu.org; Tue, 26 Nov 2024 10:50:35 -0500 Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4315e9e9642so53363495e9.0 for <74542@debbugs.gnu.org>; Tue, 26 Nov 2024 07:50:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732636174; x=1733240974; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=9LUMkWi/vXUXfH/gGX2uBl9/XMPulNlym9aDol7qtjk=; b=O4QtdgTkpNXAa43m6hdnCGnU8IEWjmxRPXqXkqgcHxMdLEvCHSlKmh71sF+Y9pcr2s OJK8H2wgona1B3IBhiyvoF1T7qZTHwKUqIY+dZM/fDSdxftHQH7bxMUfMWty0o5+hkNe HCBy9nP+Wo91GNczq7n4pLS39I90Sl2Rvx+sIhcTYFJncyQx4R3odwuI1MvIZv9b4AJb lo5CqZy6vIiYaPenfFA27w3HW/jtMfuNsdQiiEHJLzAyVKigzqh8rgWO3y+eRwRshVSr ohdqAJ+FMDbGJLc6tJHr8rj/dnOO7a5YNtVw7S4zDvn/a+t/NbG1+I9iYCeHtngmuYl4 SFDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732636174; x=1733240974; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9LUMkWi/vXUXfH/gGX2uBl9/XMPulNlym9aDol7qtjk=; b=Ed5HBmDRZ1oHaLetBD7njYSqJxNTk/+4B78DtWBGjcRLMF5K6abQWHV0IxW2xxvuXI ZdtEfeKcWe1VX0kShRgoLB1QymWbvqGfZH/Qr5EFLP0je1bXMLBvzA+pA2TAUaYUHUwS SPBataQyHG1E2w+pS1FCZcYse6nPQ1AI2rpj8/3bnUlq5VS5IqahPDSyaaGhsrv2UBWh 8+Bwx3hUCvVjL3OAa2a2qGNgT+nfIff9RYz3a+QSR/+bAvDC3+SgalMFbh1KUAV8C2xg 3WU1Vc2Y0hEHv5xVcieetlNOKG4kURXQxR0t+gntT4ovZJC8ctpdg9BHAql42Au+jkfd GDxw== X-Forwarded-Encrypted: i=1; AJvYcCUVaPWbp3ey1r7wvASud+zbpMXbHtXzPk9ktrUYqvqo4GInAXRRAOUFK5PYSGrpvvRXUU1gHw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxcxYKG6CQFQsSnvpZ6kiPM8WdQXUiPV4Rx35r94PIcc/EwvhlR eGwLGr0uebPtOxtuebbeRSDtknNbyzg7nifsLYUrL91EpdKwsMj+ X-Gm-Gg: ASbGncv/O1tOQ1MTkGiMZvmGkeL1hsbq0QM0ohvd3MLJZhQ79Oz/++o58W+7W8bTEAl XJWoEHgFFRbhMc90Awzx+ZKUqn2fPjKe76R0vNAodqJ8Z7hP7YiGtHfimfrjEC4/J7zJwMZjius BIYlZENJrnHSsUSKfCtw4xrOL+nUr7Kkv/rVJNJ/oheZ15ZuDU+Gmw0BfNeldtQwcYJCmEgTk46 5Hnsnlbfl3VAWckBbPtFzxuJgnmyEmTfyWcvUErgk3ad/k= X-Google-Smtp-Source: AGHT+IEaIwcPVoTG7e/A9wXWuGn3ufNJ/xLW5pKLBsujMj1T7agdjDxmMdBuzMbBE+/w1QCl/pTwrQ== X-Received: by 2002:a05:600c:348f:b0:434:9da3:602f with SMTP id 5b1f17b1804b1-4349da36119mr91988705e9.16.1732636173812; Tue, 26 Nov 2024 07:49:33 -0800 (PST) Received: from lili ([2a01:e0a:59b:9120:5ac:5c58:da2a:61ba]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4349f2e1b3bsm80935495e9.25.2024.11.26.07.49.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Nov 2024 07:49:33 -0800 (PST) From: Simon Tournier To: Ludovic =?utf-8?Q?Court=C3=A8s?= , 74542@debbugs.gnu.org Subject: Re: [bug#74542] [PATCH 04/11] build: Add =?utf-8?Q?=E2=80=98--dev?= =?utf-8?Q?elopment=E2=80=99?= option. In-Reply-To: <7c530a62370853828f181db011cb2f12fdc78847.1732615193.git.ludo@gnu.org> References: <7c530a62370853828f181db011cb2f12fdc78847.1732615193.git.ludo@gnu.org> Date: Tue, 26 Nov 2024 16:26:25 +0100 Message-ID: <87o7222ezi.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74542 Cc: Josselin Poiret , Maxim Cournoyer , Mathieu Othacehe , Ludovic Court?s , Tobias Geerinckx-Rice , Christopher Baines X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Here the oneline commit message is: build: Add =E2=80=98--development=E2=80=99 option. when elsewhere in the same series, it reads: guix build: Add =E2=80=98--dependents=E2=80=99. I suggest consistency; =E2=80=99build:=E2=80=99 or =E2=80=99guix build:=E2= =80=99 for both. On Tue, 26 Nov 2024 at 11:33, Ludovic Court=C3=A8s wrote: > + ;; Process OPTS in "the right order", meaning that if the user typed > + ;; "-D hello", arrange to see the 'development? option before the "hel= lo" > + ;; spec. > + (let loop ((opts (reverse opts)) > + (type 'regular) > + (result '())) > + (define (for-type obj) > + ;; Return a list of objects corresponding to OBJ adjusted for TYPE. > + (match type > + ('regular > + (list obj)) > + ('development > + (if (package? obj) > + (map manifest-entry-item > + (manifest-entries > + (package->development-manifest obj system))) > + obj)))) Well, the loop seems overcomplicated but nothing better to propose. ;-) > + (match opts > + (() > + (reverse result)) > + ((head . tail) > + (match head > + (('argument . (? string? spec)) > + (cond ((derivation-path? spec) > + (catch 'system-error > + (lambda () > + ;; Ask for absolute file names so that .drv file > + ;; names passed from the user to 'read-derivation' > + ;; are absolute when it returns. > + (let ((spec (canonicalize-path spec))) > + (loop tail 'regular > + (cons (read-derivation-from-file spec) > + result)))) > + (lambda args > + ;; Non-existent .drv files can be substituted down > + ;; the road, so don't error out. > + (if (=3D ENOENT (system-error-errno args)) > + (loop tail 'regular result) > + (apply throw args))))) > + ((store-path? spec) > + ;; Nothing to do; maybe for --log-file. > + (loop tail type result)) > + (else > + (loop tail 'regular > + (append (for-type (specification->package spec)) > + result))))) > + (('file . file) > + (let ((file (or (and (string-suffix? ".json" file) > + (json->scheme-file file)) > + file))) > + (loop tail 'regular > + (append (append-map > + for-type > + (ensure-list (load* file (make-user-module '(= ))))) > + result)))) > + (('manifest . manifest) > + (loop tail 'regular > + (append (map manifest-entry-item > + (manifest-entries > + (load* manifest > + (make-user-module '((guix profiles) > + (gnu)))))) > + result))) > + (('expression . str) > + (loop tail 'regular > + (append (append-map for-type (ensure-list (read/eval str= ))) > + result))) > + (('argument . (? derivation? drv)) > + (loop tail 'regular (cons drv result))) Since you are at it, why not move this pattern close to the other pattern matching =E2=80=99argument=E2=80=99 too? Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 10:50:39 2024 Received: (at 74542) by debbugs.gnu.org; 26 Nov 2024 15:50:39 +0000 Received: from localhost ([127.0.0.1]:50152 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFxpn-0000qm-0S for submit@debbugs.gnu.org; Tue, 26 Nov 2024 10:50:39 -0500 Received: from mail-wm1-f45.google.com ([209.85.128.45]:51345) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFxpj-0000qN-QJ for 74542@debbugs.gnu.org; Tue, 26 Nov 2024 10:50:36 -0500 Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4315abed18aso51375285e9.2 for <74542@debbugs.gnu.org>; Tue, 26 Nov 2024 07:50:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732636175; x=1733240975; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=Dkk9Iz7aztDCOZYKivLLItrQfJcrUY3fHmwFnEqsEg8=; b=LRHTzusXjFJHWtCayl8CEro69x/331gmrg2RuSilbuhjezZGAUFzG8eAMNFusLTjHR uBGEEk8X15Mo6VDmjy1f3sAcG6LM/1pYLcEuLBRMADcxiOMGCpc/HSOSBhN/1R/Xq8Kg NxGzl9yaaI1ZO6oTcuqncyjcqykqZOo0TY9w3NUgRq4hkEKKjWv9fw9ib8KbrkWBrC2S KBZ5VRXvVpDPsuLvrOOr5dZUIgm0ONKosVjUya2PxLRsW8ClBpDOBk1hYrNlE5931ajB Veqh1gzflMu8vSZNWIYXXE6JqRguVG1QnEgkef2kTBqDbuSRdlW5Dox5MgqTZ20DxfO4 VPFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732636175; x=1733240975; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Dkk9Iz7aztDCOZYKivLLItrQfJcrUY3fHmwFnEqsEg8=; b=YlyqPeHJ+cD+NZAW1na64B71FDfyzfWnbDLlguuGnSlcuvdYzNHxRrKu/W7h4KKWjS 1KA7F8ObJrF3O4gMkyqOlZ96f/3CtKzHB/wt5gZff9yBchaVMbUmMbmlgjec9bV46fNw K10J0qrZgQm7shfl0d1yG0UdXEVa5vqxGCojy5822E0PfKW9OrieBnHSrBu2IKNSN6T2 /OU3Wm8KwPNvjI8fQR7wHh3HoUmXatb8j3jvPVKU/C5Yrk1eDzM/kk7PVealqv3fBrDH gqsVuWRARB9Prpek68pv+SGpA+ohYtcI25bUtrgc2A46Vzjd8aXTIuWWnXBYjPHyeO4e oIfw== X-Forwarded-Encrypted: i=1; AJvYcCWTYGjHIoOjrkfu7SqtfMiuhgVPrli0IV1zdWb2QaA4b2iTaKhNPtucna8dfgHsQVE1j3KfLQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yw/80TRzP56Kxv6xtSHDEY2esl6+xinLeiyoooOsJFsPHpXHzdq 3s2Ud5D64xoxSAbQ8Yt6xQ8Gz71Aut6+yg8zxVllc/CnDOBIROprLC5I0A== X-Gm-Gg: ASbGncuvIKzOtBRuYXBs9ddPKvdC4nTnyxK2PUJguhG1iXNl/rgH9FG8vXlDLA3Ir86 1Na9YfEMKmrcGHlPMAg5/0TKNizrTZPhiWgItmtnsMNJ9MWf1iofztlOUiTphwgrULj6aZAKafX j4HqlL9nCfOZsd5IZUK+F5m5oQaoVnoTfULBqyRAIi/EfVqIiqjMRGQfXAnTY3vJlZ64HxQFBJb 9nRKkcT4D+AHJjIq77tlDq7yw9nD4MPruHuhEzYZ4Az/Ww= X-Google-Smtp-Source: AGHT+IGN06eIjbPE+lOHk4LW4z3PlAs8bsvmwEcAtyrYo5cSuZvWauUqHQHnq/l/UKawv4VPrkhvYA== X-Received: by 2002:a05:600c:4f4e:b0:430:563a:b20a with SMTP id 5b1f17b1804b1-433ce4264cemr144041555e9.11.1732636175074; Tue, 26 Nov 2024 07:49:35 -0800 (PST) Received: from lili ([2a01:e0a:59b:9120:5ac:5c58:da2a:61ba]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-433b45bdb13sm230172685e9.15.2024.11.26.07.49.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Nov 2024 07:49:34 -0800 (PST) From: Simon Tournier To: Ludovic =?utf-8?Q?Court=C3=A8s?= , 74542@debbugs.gnu.org Subject: Re: [bug#74542] [PATCH 07/11] import: gnome: Keep going upon HTTP errors. In-Reply-To: References: Date: Tue, 26 Nov 2024 16:26:56 +0100 Message-ID: <87jzcq2eyn.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74542 Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, On Tue, 26 Nov 2024 at 11:33, Ludovic Court=C3=A8s wrote: > * guix/import/gnome.scm (import-gnome-release): Do not re-raise > condition C, emit a warning instead. > > Change-Id: I9a7c337a17d1f7ed4677398e7b0f383befca7d74 > --- > guix/import/gnome.scm | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) LGTM. Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 10:50:39 2024 Received: (at 74542) by debbugs.gnu.org; 26 Nov 2024 15:50:39 +0000 Received: from localhost ([127.0.0.1]:50154 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFxpn-0000r5-FJ for submit@debbugs.gnu.org; Tue, 26 Nov 2024 10:50:39 -0500 Received: from mail-wm1-f54.google.com ([209.85.128.54]:50500) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFxpl-0000q0-6o for 74542@debbugs.gnu.org; Tue, 26 Nov 2024 10:50:37 -0500 Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4349e1467fbso21335195e9.1 for <74542@debbugs.gnu.org>; Tue, 26 Nov 2024 07:50:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732636171; x=1733240971; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=XlukfBIfR+esfz+m3G5Dw3xAhfFuZkA7njDuevsYze0=; b=m8A1Ze5WluERDOwcMhLcqorIwovE2p5nhzDf7lBRwRx0XIQBwjvviARotDK2lbdLG8 sYyC72beD8WUSuprOeWeeS1P5nkVDSulxeCJ1Ke4P3/5fol3c99GXhTndB0BsJcATr9L EisoTahhKyqdc8s/ls9evGObnIIsdAVIvhNh3mdRplnTZu/xY0T/+JKlskg50gigBFt3 /JgInTvdf40Bdo1vSYKY2WUXaO7seYgOalBlLeSB4U10mh3tMtOBqHEW6Aovc+L0y1v2 4ljhXqrBiiSYHING/UwERa1RfXDZ7FEi/4g8rgq9LWkKLd5CcakMF7osy24CLk3FkS7D eTUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732636171; x=1733240971; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XlukfBIfR+esfz+m3G5Dw3xAhfFuZkA7njDuevsYze0=; b=kg3uLKREr96i5taY5Jj78i7yuKsLgDrJFIqi3CIe+wy99x6x+kQHBx3dyGql+WI1ja q+2rWlAHDRBSu3JNYeFFhjjWehSIaJyCtV6usbWLG2k8hAlWu3+4i54jlpQilumC+Vx3 0zzYG08YvmNEKq+niWJFJWAYKQrOlZSZXmFQ5jpVqGomyEllSBKFZ/deLZ9K06//9PX1 uH4ETzKcVx8FGvA8HZUCAS9YmmoVSaKCZX1Kp6XA9mdJpFJt5iBG5fyQtbrqITpQVuH4 KvUZzkJg3tyvhvOM+VlHdtFhn+zt+0btSpLa2OfW7Uxv+PNozpaZWMY8gcihE2K2ocbA JPBg== X-Forwarded-Encrypted: i=1; AJvYcCUSpI7m4QvgrGIgYbKLfarpaSS3xhxUDwWqJFu3tnCObDB41tkQyfDa7URyPTJfKlzhBP2G/w==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyiA/fCD8NJQP350iZ12dZexciPr4PKiBkIRjREo+KzYQ4q6sxX pGw1jWFgc6GfpONET2quY8lopyPOv7RS2WNCIDNeHj/9woLohLPs X-Gm-Gg: ASbGncvqNlH6AJgGM2veu4+R/F1L5A5w+Cz7IJHrHaq79ShFM70vizxTrUDQbV1nJ6C 8NGk91zWb6fna3k+PWpJMNnZ44EQRgsGXBLf9Y6E+AMg0diLLhO1T20XFV/dYAAhNwDdwIUvTlh tSP/+gprjDG4F/wmpfxRyWa19tEXI2BIqsMPp3/S2XH5nTlmfFSMMS6fqVUpsdT31Ux7DT8BrT2 l40XAFxhFjOLNuqq5oVhb3JOupO5b4LN/bj+CRgpjPgbD0= X-Google-Smtp-Source: AGHT+IES5Q9QkgVfpiLbzk2MCVqiMLj66bmNFJyirUnD7ExZ9z8mwa/RSZbrIH5Ol960yJ8OVz0NRQ== X-Received: by 2002:a5d:6c6c:0:b0:382:4b5c:4199 with SMTP id ffacd0b85a97d-38260b73edcmr13714083f8f.23.1732636170956; Tue, 26 Nov 2024 07:49:30 -0800 (PST) Received: from lili ([2a01:e0a:59b:9120:5ac:5c58:da2a:61ba]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3825fb3134bsm13578491f8f.58.2024.11.26.07.49.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Nov 2024 07:49:30 -0800 (PST) From: Simon Tournier To: Ludovic =?utf-8?Q?Court=C3=A8s?= , 74542@debbugs.gnu.org Subject: Re: [bug#74542] [PATCH 03/11] gnu-maintenance: Savannah/Xorg updaters no longer abort on network errors. In-Reply-To: References: Date: Tue, 26 Nov 2024 16:12:07 +0100 Message-ID: <87sere2fnc.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74542 Cc: Christopher Baines , Ludovic Court?s , Tobias Geerinckx-Rice , Josselin Poiret , Mathieu Othacehe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, On Tue, 26 Nov 2024 at 11:33, Ludovic Court=C3=A8s wrote: > guix/gnu-maintenance.scm | 25 ++++++++++++++----------- > 1 file changed, 14 insertions(+), 11 deletions(-) LGTM. Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 10:50:41 2024 Received: (at 74542) by debbugs.gnu.org; 26 Nov 2024 15:50:41 +0000 Received: from localhost ([127.0.0.1]:50156 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFxpo-0000rE-QP for submit@debbugs.gnu.org; Tue, 26 Nov 2024 10:50:41 -0500 Received: from mail-wm1-f48.google.com ([209.85.128.48]:51541) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFxpm-0000qj-PM for 74542@debbugs.gnu.org; Tue, 26 Nov 2024 10:50:39 -0500 Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4349fb56260so19563175e9.3 for <74542@debbugs.gnu.org>; Tue, 26 Nov 2024 07:50:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732636178; x=1733240978; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=xYqCtJX+fqyWugElNHQNErkR7uH/Zv0ZMPvebt6a2S0=; b=X8nF6iXvXr9F6HITttl+k8fikLwwZrhUDZkBvr9F4bedMNAx8gBBkWRR1GHGRCY2+l QGnfS2POTvs/HZCydrnJkwJLj8QiNRMA9xWe5akAciVkjBF/BVFp3zbkgEABfcCQhWmf nQHgQ/H7RBd8SfoFqITVcGJYwpWpjImsL02tryGr8M9qi0v1thYxn9HVFw/bYAiPqNUw xIFlreeuWI5yiluX8lWSCMC4qsMQomhRE1VScE5u6d4aWkC60Frk3YEMpe4QjPdfOwET ZcNnweWKTFhYEoonmAeLlP5TVSx0jhs8rJCyC2GLMSxLYFiKoTMr5nwhgcP5R5ENYGwN HSug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732636178; x=1733240978; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xYqCtJX+fqyWugElNHQNErkR7uH/Zv0ZMPvebt6a2S0=; b=wjTW+WPSxAAzZecybZDt3A0ru/1Qubt/284QZhKNYZhX7e754POSFP3lLrqBzL2WfT 1lYzaFtQtr4tmpkixbhaWEFM2VDHRo5Xx92namuoVRQzwRqSvt4OppmXmw1jTdKxRfAM ejpqxcirFMMqed446UfSQC9EFCOaNPon50yv6ZU4/RCHIOH5Z4tp8CrsxT26o+bMo+IN 86X/Sh0tzOnS+Pt7qtpXvU6efpuLqv2ioJLRfW2TMHRL8BoVjqIbD89CoqIOsBSpUbFQ NrgBdpUhvhWKIWXHbDZafcDJ1aSkv+RRd44TRGVOYT0M1nxO7jL0/6PfWJiniUlvk8vN 0bnA== X-Forwarded-Encrypted: i=1; AJvYcCVeuYwJ8kh0eYI9kwioCo5647LrTjDk31eDjYaBSVw9eH+BO2Bef5adD5apcs73hzLPb33LEA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyWRWEk/hFEQeiyKOm5scvm/fr3Z48a8TceeD/A9ai17WV0MGr3 TKZaRVyXtdQpFnRqsBcjhFmwRuIjcrQZ/iqWA43M8dYJvgj4LEiE X-Gm-Gg: ASbGncsCsWoRgzoYoNK+DLvh3MaOXCgZKM1KcpKUoOWtOL/2ngxunruWt9/KCVOmDVw wYXbfkSt3l7pCKhxvsPOB8FtPPTxmCEPxzQJYp2efyyXcXLRe5rppdwRpcdZTxuDTp749sPM+Jz LG8wMp/a7CdlKYdR+EXsYCNB/4tpCnLEMn+DsjQlFl+MyhBo3zlHiU1J+/z+m7JoeMeDK0L24T5 rbx5r9mYXYxPyX5e+B68ZGnEPwC832G7D02aaThbqQvzn0= X-Google-Smtp-Source: AGHT+IG5w0HlvexyhALTUrQFlx9e+wmoPud4k/6T2Rsr7+IJN+voWPSHMCLLmu3ch1qBI28O/bSqQg== X-Received: by 2002:a05:600c:3d0c:b0:434:a781:f5d2 with SMTP id 5b1f17b1804b1-434a781f76fmr20721745e9.5.1732636178115; Tue, 26 Nov 2024 07:49:38 -0800 (PST) Received: from lili ([2a01:e0a:59b:9120:5ac:5c58:da2a:61ba]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4349cc29406sm102078215e9.0.2024.11.26.07.49.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Nov 2024 07:49:37 -0800 (PST) From: Simon Tournier To: Ludovic =?utf-8?Q?Court=C3=A8s?= , 74542@debbugs.gnu.org Subject: Re: [bug#74542] [PATCH 09/11] gnu: Update updater properties for GnuPG-related packages. In-Reply-To: References: Date: Tue, 26 Nov 2024 16:28:40 +0100 Message-ID: <87cyii2evr.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74542 Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, On Tue, 26 Nov 2024 at 11:33, Ludovic Court=C3=A8s wrote: > * gnu/packages/gnupg.scm (libgpg-error)[properties]: Remove. > (libgcrypt)[properties]: Remove. > (libassuan)[properties]: Remove. > (libksba)[properties]: Remove. > (npth)[properties]: Remove. > (gnupg)[properties]: Remove. > (gpgme)[properties]: Remove. > (pinentry-tty)[properties]: Change for =E2=80=98generic-html=E2=80=99. > (gpa)[properties]: Remove. > > Change-Id: I1eb9d6ad5bb3ecbfbef3d44dbae281a3de7ebac7 > --- > gnu/packages/gnupg.scm | 40 ++++++++++++---------------------------- > 1 file changed, 12 insertions(+), 28 deletions(-) LGTM. Cool! Nice clean up! Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 10:50:56 2024 Received: (at 74542) by debbugs.gnu.org; 26 Nov 2024 15:50:57 +0000 Received: from localhost ([127.0.0.1]:50161 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFxq4-0000rs-7N for submit@debbugs.gnu.org; Tue, 26 Nov 2024 10:50:56 -0500 Received: from mail-wm1-f43.google.com ([209.85.128.43]:53683) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFxpq-0000qV-Mh for 74542@debbugs.gnu.org; Tue, 26 Nov 2024 10:50:43 -0500 Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-434a45f05feso14721085e9.3 for <74542@debbugs.gnu.org>; Tue, 26 Nov 2024 07:50:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732636177; x=1733240977; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=0lBWZ3+lskp6hZNiUVabdL+64TBnxnls9wg1mGR5+Z8=; b=ZDPWQNS1cRH1T1zFisLmQ3n1KU4kkEZgDUeHzhQ90i6Bgdjpxpnki3x58hLN9oQRB1 VMoz+oO0UWHOucKCHg4iDX/Ud9LgVg/BbHWTNmEvWLew3zT6RDZVNJVWF+bogBuQHS0E LXsfHCmj3LO+evNzQGL9k8sk14a6WCiQJ7APirj196x0hr4QR+iLpGNPaRY3wwWr04PL KsFmc4g/y7tjtCSzOBH35UNfcipoZCYu5iqF+et4f+XSXg1UC097NwUATBMk+d0q1K8E 6eXuxzNf8lAV/B9egKYoRkGaox2EBaQdGP3iKmTCRIL18cAMrNZKpeF5qhSUaarbL3Zo FbZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732636177; x=1733240977; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0lBWZ3+lskp6hZNiUVabdL+64TBnxnls9wg1mGR5+Z8=; b=JoYYAuB7ae8jXuxtZ5eNijbb9y9uBMdCrPKhBPh+f8757Itv9sNqLGeXQxNO5HksRs k8kaMUibPFh4ldg0KsLK+k01Q5mR2Op78D08rTgWd+5d838IcQIWtV0Lw8/g/ryuoxMI n/d64XM+HSzJWi7xUEYkKrGLyjSKCjNsn+jhdK8Hf3EU+1fgjC6b3jgBe5RJyWlQriwY HJxMc1DEmERe2A4k5a0MYKHtNI42GeixPvj0R16PzsZTnP8ZmXtX6BSlYVH7zuD+u5AN 8yOtdYn2olEUEfAPhBA9qIzfjByNhRsK5MYZuJXh3rnmQ5qXnH1V/xA13QBkubCXWLqj dprw== X-Forwarded-Encrypted: i=1; AJvYcCWINbFTLxpyGCnOwXw53LIX4z6o/BY3w0XytylJsOXzJB3hWyq2Ua2B3lt+TmfAwfEs4xFPAw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzIl4+Fya6YAuJvT9gzv3XygdSBAHc3MwXyUldoZQONoRRCpzU4 LNwWDcdizX2vK7/pbGCqvgweC9nhDK4AOyMCiVj7hmBTWqSWcjAd X-Gm-Gg: ASbGncsn66ycyFF6ry5WaNM9xXuJG681RXD7YC5q5lmU0cUFMRrvCFJ82hW4uNIXlHp 4+mLO0a439tAD4tEXsArzvkQreSJCWLVbTTrFm5KbQXz2KyAqX4AXnTfwZ7VKki/77AUZiRDDoQ KII2wqiNXmhq9znWvcY2fbPa2VvpalAamUj9Md2Mhdq3gCkgUrDG6DyMFL+Dnsot7MCImhmNVbI LKIa6bkuCEnpt1nzrnk/FXYn42BKIUAlatpgUvYgZ/MGSM= X-Google-Smtp-Source: AGHT+IHBRre9a2A/giKzxsyEPSXkVotrc8khQDxotmmBpzoQeb5HelBotxqOtmICEqny5A+BouJQXw== X-Received: by 2002:a05:600c:1c90:b0:434:a1d3:a321 with SMTP id 5b1f17b1804b1-434a1d3a466mr65207445e9.3.1732636176921; Tue, 26 Nov 2024 07:49:36 -0800 (PST) Received: from lili ([2a01:e0a:59b:9120:5ac:5c58:da2a:61ba]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-433cde059a6sm173014235e9.4.2024.11.26.07.49.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Nov 2024 07:49:36 -0800 (PST) From: Simon Tournier To: Ludovic =?utf-8?Q?Court=C3=A8s?= , 74542@debbugs.gnu.org Subject: Re: [bug#74542] [PATCH 08/11] gnu-maintenance: =?utf-8?B?4oCYZ251?= =?utf-8?B?LWZ0cOKAmQ==?= updater excludes GnuPG-hosted packages. In-Reply-To: <3459c668f8e6ee0b195f4e1ec8eb437dd3c1ec6c.1732615193.git.ludo@gnu.org> References: <3459c668f8e6ee0b195f4e1ec8eb437dd3c1ec6c.1732615193.git.ludo@gnu.org> Date: Tue, 26 Nov 2024 16:28:03 +0100 Message-ID: <87h67u2ews.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74542 Cc: Christopher Baines , Ludovic Court?s , Tobias Geerinckx-Rice , Josselin Poiret , Mathieu Othacehe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, On Tue, 26 Nov 2024 at 11:33, Ludovic Court=C3=A8s wrote: > Since ftp://ftp.gnupg.org no longer exists, another updater should be > used for packages with code fetched from mirror://gnupg. > > * guix/gnu-maintenance.scm (gnupg-hosted?): New procedure. > (%gnu-ftp-updater): Exclude packages that match =E2=80=98gnupg-hosted?=E2= =80=99. > * guix/download.scm (%mirrors): Remove ftp://ftp.gnupg.org. > > Change-Id: I653877ad843da60281d3a234acc85743bee64856 > --- > guix/download.scm | 3 +-- > guix/gnu-maintenance.scm | 6 +++++- > 2 files changed, 6 insertions(+), 3 deletions(-) LGTM. Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 10:50:57 2024 Received: (at 74542) by debbugs.gnu.org; 26 Nov 2024 15:50:57 +0000 Received: from localhost ([127.0.0.1]:50163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFxq4-0000ru-SB for submit@debbugs.gnu.org; Tue, 26 Nov 2024 10:50:57 -0500 Received: from mail-wm1-f41.google.com ([209.85.128.41]:42478) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFxpr-0000rN-8J for 74542@debbugs.gnu.org; Tue, 26 Nov 2024 10:50:43 -0500 Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-434a1833367so11505705e9.1 for <74542@debbugs.gnu.org>; Tue, 26 Nov 2024 07:50:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732636182; x=1733240982; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=qS8E+hgpJck/+CUzztEOwYeLw0DFGX6lYCiHO2sCUbo=; b=KtGw63qaK9OZwyn8NoCCcFuq/yATzSF35fyrenrccb4p/jjoIq9wo7SdNA4caGBI/D jYANvBcUyNWcPVIqvFYJjCALwop9QtayqDaJmNSpB+BfKqSU05TEDjv3G5S5baApVBBV QmahPXfF3vD9DO7bJgzWygKbZ3fXbY05vpk0G+845I3H4Uxt6We/Y4x3uxIEZkgPCGnL YAizdu1v0VFcUwJAdPu+p8ZfqNiAtXzjvJT0+2rucj2hzda2fXRi6/hVV5F2J1+e5NJf 4mdCMqzr7jXpHkBdI7Thx50S57Af0RIs/4xkhScT0v3LDLSit6dKF7rpeu9Z9nXrnNAP jDNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732636182; x=1733240982; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qS8E+hgpJck/+CUzztEOwYeLw0DFGX6lYCiHO2sCUbo=; b=q15EVcnJ/62pqET9sySjQi3dVcm9T/bnkAUAgAGOFLp8NTuFfW9L6HbvGPL0PibViC QVdVMZJQvnLeBtiKdvju75CnNNpH7wO+jjpYGPqJOCjf1orF3hJxm6h3fsL24wLkTIpB NADOfP4WN2sz/MQEJoqb4wdx7ji5eQmw+NYmpnBWBjnkgditdZ9A/qT16fVNvxtRukMw y94l5qlnnQptKXMJWlNbbTm/7dMo3yPHU7q4MopkkUxrM6RjUWLNLv7HRx65Dtd2MYcW mxi39dmwR1JQOvviWDlbuzcOdDV3zdBILIJmC4GF3g17bupaxlL/Fi7BvUFC2du40vue GxJg== X-Forwarded-Encrypted: i=1; AJvYcCVAQucrdJFYl/dst54415QqJ5eb38GsVO4YXPyys9j9AFvL/seMap1/J4th7fAE+HyFpZbvUw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyaSHRzJT2xF43wlGPHqgqsX8ePNcG0GITn5TkZ1xhYGU7Zb8qM m+1RcY5NLx0BihG9f6E2Anua197b8Izz3JrxCOzFMqvI1eckt4Dq X-Gm-Gg: ASbGncvv1/yxtGyxJ4PY+XPz35INd1LVjrV6Y350O14m5q6PG3NF4s5ePYNB+GEvkaZ gsjoJ0VSsUTDJjZn53x8/a4TQVoBOK6iTGKNW76s7RnfGgpXNgV19tufFOrqsaU+gKJEhqPBG4Q eaJ3YcDyhcH+5ZCuhgepMxlVYJcx6d6BXvaO1eY4WDdCQeMpyOADUiQowT6W05JcwvnExsSUA4E aefnwSqZ5fyyD6w8ABeEm2NqcFVaPd4OuItbjisCifBvN8= X-Google-Smtp-Source: AGHT+IH++UWzqnlzRzokDDh5CGcF7Ta5tUg+sZ8CAtovNSGJRcshJ66Lm7udJ+mvlHfpAR9VRNr/Eg== X-Received: by 2002:a05:600c:5106:b0:431:5226:1633 with SMTP id 5b1f17b1804b1-434a4e7222fmr32057475e9.6.1732636182324; Tue, 26 Nov 2024 07:49:42 -0800 (PST) Received: from lili ([2a01:e0a:59b:9120:5ac:5c58:da2a:61ba]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-433b463abbfsm239600575e9.32.2024.11.26.07.49.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Nov 2024 07:49:41 -0800 (PST) From: Simon Tournier To: Ludovic =?utf-8?Q?Court=C3=A8s?= , 74542@debbugs.gnu.org Subject: Re: [bug#74542] [PATCH 11/11] etc: Add upgrade manifest. In-Reply-To: References: Date: Tue, 26 Nov 2024 16:49:11 +0100 Message-ID: <874j3u2dxk.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74542 Cc: Christopher Baines , Ludovic Court?s , Tobias Geerinckx-Rice , Josselin Poiret , Mathieu Othacehe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, On Tue, 26 Nov 2024 at 11:33, Ludovic Court=C3=A8s wrote: > +(define leaf-package-updates > + ;; Select a subset (~22%) of all the leaf packages, typically small C/= C++ > + ;; packages not part of a bigger "collection" or repo (CRAN, PyPI, etc= .). > + (manifest > + (filter-map (lambda (package) > + (and (memq (package-build-system package) > + (list gnu-build-system cmake-build-system)) > + (package-with-upstream-version (pk 'up package)))) > + (leaf-packages)))) I would be finer here. For instance, the manifest contains the same package at several versions, i.e., =E2=80=99package-with-upstream-version= =E2=80=99 applies to the same package at different version. Slurm is one example among many others: --8<---------------cut here---------------start------------->8--- scheme@(guix-user)> ,pp (sort (map (lambda (p) `(,(package-name p) . ,(package-versi= on p))) (filter-map (lambda (package) (and (memq (package-build-system package) (list gnu-build-system cmake-bui= ld-system)) package)) (leaf-packages))) (lambda (p1 p2) (match p1 ((n1 . _) (match p2 ((n2 . _) (string<= n1 n2))))))) [...] ("slurm" . "20.11.9") ("slurm" . "20.02.6-1") ("slurm" . "23.02.6") ("slurm" . "21.08.8") ("slurm" . "22.05.1") ("slurm" . "19.05.8") ("slurm" . "18.08.9") ("slurm-drmaa" . "1.1.3") ("slurm-minimal" . "20.02.6-1") ("slurm-minimal" . "22.05.1") ("slurm-minimal" . "23.02.6") ("slurm-minimal" . "21.08.8") ("slurm-minimal" . "18.08.9") ("slurm-minimal" . "20.11.9") ("slurm-minimal" . "23.11.10") ("slurm-minimal" . "19.05.8") [...] --8<---------------cut here---------------end--------------->8--- Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 10:50:57 2024 Received: (at 74542) by debbugs.gnu.org; 26 Nov 2024 15:50:57 +0000 Received: from localhost ([127.0.0.1]:50165 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFxq5-0000s3-8A for submit@debbugs.gnu.org; Tue, 26 Nov 2024 10:50:57 -0500 Received: from mail-wr1-f44.google.com ([209.85.221.44]:57501) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFxpt-0000rD-S8 for 74542@debbugs.gnu.org; Tue, 26 Nov 2024 10:50:46 -0500 Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-382456c6597so4054207f8f.2 for <74542@debbugs.gnu.org>; Tue, 26 Nov 2024 07:50:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732636180; x=1733240980; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=CCXYW6RAcn7KombXlZh+iLEh8142ouLxr9pO0nC+MPU=; b=WBWbWrLTPbZD7NJS2ZJlbD6sduZlsplN9nB7qqKxugjhIkiGczQncqSvusZcZuyKHb Q0a4GHnhn+C612F4XvxdbpVCMud/RRPxbE1aqFZCefuLHg5ACh3cHjjqrV+kufJEBN3W 6wTGJ1jQkHTVUTQmX8GazcZReo53DvDuRXa9mOR0IyKk+/YrpmIno3MThdE7SoCIRHAn kppGhmLjQq5pCc6oEliE8dZbp2qO8qYJ5j1lS7dKoZKOviqC2zYcBauMiNU1zO/V9nMN zzzl8GVLvASc0Z6/QMdqDKIl6uJpz+zRnfMfT7ecBWKDAE1ZSSum5kNCBr6xOnqmv58n LAgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732636180; x=1733240980; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CCXYW6RAcn7KombXlZh+iLEh8142ouLxr9pO0nC+MPU=; b=UTQi5xMJNRSs2mK6mkyr8LiGnF77PR2SRyg/IaGfZljdPb1TWWd6lcLFahmSbKyOk6 nCrqeXf3cJWAG8D67q3wcN8U84KN4bBSDw6zT2zKozmQtOTc5WpHTCm5qH9g61BdJdqC a0duQdLdaaKeciPgfnS3V56pHzMajnYUoL5Z68kSUxfmbMlD168oRuSsP3MkEOI8L0Vj KaoItc6j7KxPGDjz866NN3Tlq5e7HyUvi7ESBtwXgqkCexqRW+p4PKeFOwsZnZOu9Hy5 Yjvn49RP80+2MWl7BMC7mkiXMR0vN8Ds3aiakdyhyYYYMEMLtFwq1CNkgAByULO8J2SP SOZA== X-Forwarded-Encrypted: i=1; AJvYcCUe/cRQ/q3/g7aaVHaSHc19iaUvzHyfBmFPAe8CYmcH8h223tvvlIW9UUJ3iDfIsqz+ulgIaw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxuNmJWiLdro3kf+dezdm1UgokLS+0Mh22sHKalML0CNfMoM4UB E/wIue0BXbbBP6tMDNaku7ROFYrbwL4w5FvqA5B3KdKSfdEIwVWu X-Gm-Gg: ASbGncs5b2Ao8DIh3Y/3rlqL/xP+ljhS1ordTzzJzCRqVzUVwKzN/u6PRXjpjXyUtek EImap5Is71yygAOFZsyqllD5snzRz3HMEFemxz58KcWAj0J1SdfpdOsGzk8VChoe8i+16JUSpyl TiyaQ/BfRLhQxMQvyPInA8N8LRQ/Q5EIwYmI7sOS1aVBf/UJPxUPayR7PIHBL8SUI9JvkkUOPWt RoCUPyaTU5T+UUuz8f+/Lx5eeMVeSlMWxcQuH+N1sz2NqQ= X-Google-Smtp-Source: AGHT+IFCLCk0A8I8BziFMPuCNyOF+fAlBgnt+ww+9wXsw+rvquZ8jrCfG2yj89JXPAM5Vsq7OljHzw== X-Received: by 2002:a05:6000:790:b0:385:bc42:52e4 with SMTP id ffacd0b85a97d-385bc42535amr6839691f8f.24.1732636179869; Tue, 26 Nov 2024 07:49:39 -0800 (PST) Received: from lili ([2a01:e0a:59b:9120:5ac:5c58:da2a:61ba]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3825fad62fasm13583083f8f.15.2024.11.26.07.49.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Nov 2024 07:49:39 -0800 (PST) From: Simon Tournier To: Ludovic =?utf-8?Q?Court=C3=A8s?= , 74542@debbugs.gnu.org Subject: Re: [bug#74542] [PATCH 10/11] guix build: Validate that the file passed to =?utf-8?B?4oCYLW3igJk=?= returns a manifest. In-Reply-To: <5f26bd9db3ae03117474be2ec678d8dc72695102.1732615193.git.ludo@gnu.org> References: <5f26bd9db3ae03117474be2ec678d8dc72695102.1732615193.git.ludo@gnu.org> Date: Tue, 26 Nov 2024 16:36:05 +0100 Message-ID: <877c8q2eje.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74542 Cc: Christopher Baines , Ludovic Court?s , Tobias Geerinckx-Rice , Josselin Poiret , Mathieu Othacehe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, On Tue, 26 Nov 2024 at 11:33, Ludovic Court=C3=A8s wrote: > * guix/scripts/build.scm (options->things-to-build)[ensure-manifest]: > New procedure. > Use it. > > Change-Id: If64c483d7079f441a296d5bd4e06e67f44cbb7bf > --- > guix/scripts/build.scm | 14 +++++++++++--- > 1 file changed, 11 insertions(+), 3 deletions(-) LGTM. Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 11:06:28 2024 Received: (at 74542) by debbugs.gnu.org; 26 Nov 2024 16:06:28 +0000 Received: from localhost ([127.0.0.1]:50200 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFy55-0001aa-MQ for submit@debbugs.gnu.org; Tue, 26 Nov 2024 11:06:27 -0500 Received: from mail-wm1-f44.google.com ([209.85.128.44]:61781) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFy53-0001aG-24 for 74542@debbugs.gnu.org; Tue, 26 Nov 2024 11:06:25 -0500 Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-434a2f3bae4so14199365e9.3 for <74542@debbugs.gnu.org>; Tue, 26 Nov 2024 08:06:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732637119; x=1733241919; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=khxTyPzZfNiyAx1hlh/vNV/2lj7huVNfWDDuIisttT8=; b=IswiXauGZVjicRScrav2D4UM2Z7c8JRPked9Tc9MLCOuZgDCyUQqyIKp0EmIb+cRzw amemBLMuPEem3QQweS7Q1+BSIHf/dN6KZz8m7wtUBerMQ9wJ2ppogYM/qo7eYS0s9jCd EZjj/z0N8GGN/rPrNqlbmVOa+xJWkSs/2plGHhR13oYwivnC5AIPJwpvump8GhHniiP8 JckG0PD+IMev1ix5WXfXROjMKh8Uc2lJ87XF/hIe6NaN6iUQPLLzjQtdR0ALMh6nHB24 daM5hQwr3AmjcqD6f4iiCPy0BbNNw6DECzUamH5QG8Z81DHuIQr6kDLqPpItljBSngA0 o8tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732637119; x=1733241919; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=khxTyPzZfNiyAx1hlh/vNV/2lj7huVNfWDDuIisttT8=; b=Q1pqgkPwtmB5RyriSqIzgWKnbVubun5nkqZqa9ss0YJb3CiJlw2VC7s60mCXiOCrSG UhqHMgJK8upZfkQ/ew5k3N1H+QksBZIoFV231kUEZkAjcQ++gR5F4WEzFpTj0IDr2G2S M3rYIx6oDf4JEnBqsW17hXQEdsCgM5J18U//3M9j4mvh0KpOW3or/G6OkOO2+B7hDaXo 0oT7XEQcjvIUn9L7JZ7LOK2ZPC7cL/vnX1RLj+ZXehDctiJmeWATPx8sdAf+2ZsD/hSY 1LrbER6z61S1kIA2paKFgH0r2PdeJiaioLEr9xfJA8DHkjnDumGQZBLD14Ft2TU8RrZ0 9iUw== X-Forwarded-Encrypted: i=1; AJvYcCWjDYTMAh47Da/7yd67ypYgAtNWcKVLDxfFWaeNpVd2RlqnoHdWzt37CQYdAzg26HX4ZqiEUA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwCdXwy/Z00U5/Bbl7oVMkuTYRs8eqVxXGycxa/74DTZWLkxVlU 5IKhvWlG5v1pBRSgAB6stnPAM+AGCs11uUIHPxZbB/KWAvvWh+PH X-Gm-Gg: ASbGncsH8n9N0/RQGUttxhNTUw3p2FunOn8RG4gJRkcP17WIbmdss3l8676eTazg4/5 w0NQm7AK2wNZ1m3Jp51s0Wqo33QY83QNzcNVG69sozt+r0eR6+zPliKdbAXO4Tttr0Y3gSy1vo7 Qm/F+L8AhXQm4z3jakAnlmtXzysAEt3uK3ehbGSjdRwnmoyaNpX9PqhRu0ggNQ6eTizdNQzFRf9 kAs54iu6FtMXB+fFww1tudLCGmP7/1sBGplzXmdsn2bJL4= X-Google-Smtp-Source: AGHT+IH13veQbV1hlrcKadBS2UgeEEwC71uy6lWdENarQFQjhfrM6bKtJQs1MV+9C2VOa0p7kcxUkA== X-Received: by 2002:a05:6000:178e:b0:37d:4cef:538e with SMTP id ffacd0b85a97d-38260be1e4bmr12019864f8f.55.1732637103152; Tue, 26 Nov 2024 08:05:03 -0800 (PST) Received: from lili ([2a01:e0a:59b:9120:5ac:5c58:da2a:61ba]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3825fbc3ba2sm13959101f8f.74.2024.11.26.08.05.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Nov 2024 08:05:02 -0800 (PST) From: Simon Tournier To: Ludovic =?utf-8?Q?Court=C3=A8s?= , 74542@debbugs.gnu.org Subject: Re: [bug#74542] [PATCH 00/11] Improved tooling for package updates In-Reply-To: <87h67ucaz8.fsf@gnu.org> References: <87h67ucaz8.fsf@gnu.org> Date: Tue, 26 Nov 2024 17:04:57 +0100 Message-ID: <871pyy2d7a.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74542 Cc: Christopher Baines , Josselin Poiret , Tobias Geerinckx-Rice , Mathieu Othacehe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, On Tue, 26 Nov 2024 at 15:42, Ludovic Court=C3=A8s wrote: > Another point: having a single =E2=80=9Cupgrade manifest=E2=80=9D probabl= y won=E2=80=99t scale, > first because it takes time to evaluate it (looking for the latest > upstream version of all these packages), second because the jobset will > be messy if it contains tons of unrelated upgrades. Yes, that=E2=80=99d be my suggestion: having a better filtering strategy for =E2=80=99leaf-packages=E2=80=99=E2=80=A6 > So I=E2=80=99m thinking that probably we=E2=80=99ll want focused upgrade = manifests: one > for selected security-critical packages, one for the astronomy packages > so Sharlatan can save a bit on energy at home ;-), one for R packages, > and so on. =E2=80=A6so yes, it appears to me better to have security for one, then may= be one per team? Or per updater? > Another one I=E2=80=99d like to have: automatic ungrafting so that we cou= ld > apply ungrafting packages =E2=80=9Canytime=E2=80=9D (ideally!). You read in my dreams! ;-) > The sky=E2=80=99s the limit! Let touch the void=E2=80=A6 Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 11:33:27 2024 Received: (at 74542) by debbugs.gnu.org; 26 Nov 2024 16:33:28 +0000 Received: from localhost ([127.0.0.1]:50390 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFyVD-0002vT-Eq for submit@debbugs.gnu.org; Tue, 26 Nov 2024 11:33:27 -0500 Received: from mail-qk1-f193.google.com ([209.85.222.193]:43303) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFyVA-0002vF-V3 for 74542@debbugs.gnu.org; Tue, 26 Nov 2024 11:33:26 -0500 Received: by mail-qk1-f193.google.com with SMTP id af79cd13be357-7b676152a86so75268385a.1 for <74542@debbugs.gnu.org>; Tue, 26 Nov 2024 08:33:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732638744; x=1733243544; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mB4wlTs8716iyR3E5/0cEh2ADoSbdhRvIQYeYXwEBGM=; b=bBiyUEkZVVnHOVBoDcvFIU0wQzHh5mFaNh/0L/io7gXT8Z4RzR0Ud1DA7eL55K1Lc4 mX2+/pv+6SrdTyKYPvCvIOIZQQvoBED8gkZ7mWsgn+NR1fu3ZYQYllh2gPtUh2O1Oro6 KPmx3Ts5MJZ8+3MBgFw20GADCQVciXULwRcl2s2/88QxLNdnorc7uZd1hTniSuPBBIad 9u7XEisFXg9zhvNvyBmRwezh7qfbrT7swtLdWRMadw7nJqlD8dmKKzAh8NpP3HbJ2BiE cGAVGmeiJt8gNaieAQEjgFip5nwLpESoYqqE+EdVW4NeiVdXdssWGSjzk6XhJVPTxkQt 0fgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732638744; x=1733243544; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=mB4wlTs8716iyR3E5/0cEh2ADoSbdhRvIQYeYXwEBGM=; b=KyvvDCoVzGIHQgnd9WW+o8X7CpaPUJvsVKsh2dcO5DtEB85XhM0xQbSRkQHJ6p0yfU iHT1gOl3e6+M+P5QhW46WnxKGlNFaC7sDdhECtkne0uPMVRXjRXrQbc/1+tYNXrjdzj8 w8vmewgdWUbjgVHKxab7Y/+2uWNAwN+2QqOzp4EPoQyBaw3XBj2jtNoXMNwyL5zkbp05 pNL1byBmxoEm6HrMfeIwjNFVxGoNqWbMp/6qT+KjTiFog+OnJVekQDYmj4XqVJFYWXia gR56v1O4RzlJzduMXTE3UOpSRmRP9nmkcrdQoruVsqVU+mcN7mMgHSt76IWuy87O+CV7 MZ9g== X-Gm-Message-State: AOJu0YyBpFROmSzGehkG7kjVmAg96UeUjdzB2utVkFcQ0X+oXrDOOItS +jp+3jAz9L4kW4s/Be3q3AHC0gy22eUzwHXZwyLII9JB7MiX7Rfg X-Gm-Gg: ASbGnct6EV49lI0y60RPyS6qxuvxZHY6+XSxPFUD3+vDARgZDN6Ca3xS1tZyDp46rx4 dIo6n2A6i++IrMDyqxFJQlI/cJbo3T4uH2VgqoWzOcnS3or+YjT+uFcV7+5DtRZ2jvS456StmRE fXJSezmfW1nzpK4LLheX1W9HeApg4y+Alh4ReZ1JBG7sj13uwPdUtkzBxun4ndc8vlhGjC3p8ou D4jUQFvyvmSXIKoI76XYK6xwzaThhVhBktOz4xD7CphyQ== X-Google-Smtp-Source: AGHT+IFI1RfVK81MTRbFk8K5RdkcXfBcGArhy/qEplsTO3nRHFShQuxRXDXiAhQTCi7fMi+NbVgmBQ== X-Received: by 2002:a05:620a:2985:b0:7b1:3c0e:3289 with SMTP id af79cd13be357-7b6745557aamr530680685a.22.1732638744200; Tue, 26 Nov 2024 08:32:24 -0800 (PST) Received: from gnus ([70.26.179.129]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7b67ae4322bsm17704585a.111.2024.11.26.08.32.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Nov 2024 08:32:23 -0800 (PST) From: Suhail Singh To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#74542] [PATCH 00/11] Improved tooling for package updates In-Reply-To: ("Ludovic =?utf-8?Q?Court?= =?utf-8?Q?=C3=A8s=22's?= message of "Tue, 26 Nov 2024 11:32:17 +0100") References: Date: Tue, 26 Nov 2024 11:32:12 -0500 Message-ID: <87ed2yufar.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 74542 Cc: Josselin Poiret , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , 74542@debbugs.gnu.org, Christopher Baines X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Ludovic Court=C3=A8s writes: > The goal is to use this upgrade manifest for a new jobset on ci.guix. > The idea is that when someone tries to upgrade one of these things, > chances are it will have been built already. > > ... > > According to a recent discussion with Nix hackers on Mastodon=C2=B9, mere > substitute availability is not perceived as a key factor in what > enables them to keep Nixpkgs up-to-date; the primary factor appears > to be the bot that sends patches updating packages. > > Food for thought! > > Ludo=E2=80=99. > > =C2=B9 https://toot.aquilenet.fr/@civodul/113527656544893427 If the goal is to improve how up-to-date a distro Guix is, then the below would help. In no particular order (the numbers are only to provide named references): 1. Ensure a periodic process (let's say alice-bot) that runs on the CI server that submits patches for updates. 2. alice-bot could, in fact, be part of the "new jobset on ci.guix" that would be updating the substitutes. If the substitute building is deemed successful it could result in the corresponding upgrade patch being submitted. 3. Having a trusted (i.e., trusted by guix authenticate), review bot (let's say bob-bot), whose job is to review alice-bot submissions and determine whether desirable invariants are being upheld. If they are, bob-bot merges the patch. If not, it requests human intervention. It would help for bob-bot to add/remove usertags on the debbugs issue (and for those state-changes to be visible on ) to ensure the attention of human reviewers is not wasted. Having bob-bot be distinct from alice-bot would help keep the process transparent and reduce bob-bot's code size (thus aiding auditability). Additionally, it would also allow for bob-bot to be used to provide automated lint/style checks for patch submissions by people. The patch series in #74542 provides some necessary tooling to help keep the distro up-to-date. However, we still need alice-bot and bob-bot as described above to get to sufficiency. -- Suhail From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 12:16:51 2024 Received: (at 74542) by debbugs.gnu.org; 26 Nov 2024 17:16:51 +0000 Received: from localhost ([127.0.0.1]:51009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFzBC-00059O-NR for submit@debbugs.gnu.org; Tue, 26 Nov 2024 12:16:51 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48598) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFzBB-000598-Ie for 74542@debbugs.gnu.org; Tue, 26 Nov 2024 12:16:49 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tFzB4-0004su-A8; Tue, 26 Nov 2024 12:16:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=gzHv5GpFGEPnWGb7VsInE9weZjm4ZM/N7Bpb4G3ZQxU=; b=djtxEEzKbNemz+WMADjK Qv5mRBoZ6HKK9QxNCb6BOFfKzcjbKg/uBLKmWQi9M+o2/NbIM14IlXAKzGhW6p3YzoVSJh+RKyiQ4 27AbN7MDW/wb2UtBuAVmNRgCUnFuFu684al/nH+paxqZP8D3gmozZSBvuG/+P1te3K5DPscybDNsz zacs4kyHbfAXwnzEoNw3oJGJyS1XBl8+iiHkxxykW8W87MvcNINLJ+s9O7k3U2jGkXiEvYV+33r+U L0K2/F06/3SRCF9lhgixOmoXaCkyAY7Sx2EaCK4cs/g1Ti3nmZPnK1JNkP5pfb26sLgBDaH/qckP6 J01huV6sBk/jyg==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Simon Tournier Subject: Re: [bug#74542] [PATCH 02/11] gnu-maintenance: =?utf-8?Q?=E2=80=98import-html-release=E2=80=99_doesn=E2=80=99t?= abort upon HTTP 404. In-Reply-To: <87v7wa2fr5.fsf@gmail.com> (Simon Tournier's message of "Tue, 26 Nov 2024 16:09:50 +0100") References: <92c108d975939b5dece3fb86ac7bce1edaf619a4.1732615193.git.ludo@gnu.org> <87v7wa2fr5.fsf@gmail.com> Date: Tue, 26 Nov 2024 18:16:38 +0100 Message-ID: <87frndapah.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74542 Cc: Christopher Baines , Josselin Poiret , Tobias Geerinckx-Rice , Mathieu Othacehe , 74542@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Simon Tournier skribis: > On Tue, 26 Nov 2024 at 11:33, Ludovic Court=C3=A8s wrote: > >> + #:use-module (srfi srfi-34) > > [...] > >> + (guard (c ((http-get-error? c) >> + (warning (G_ "failed to download '~a': ~a (~a)~%") >> + url (http-get-error-code c) >> + (http-get-error-reason c)) >> + '())) >> + (let* ((uri (string->uri url)) >> + (port (http-fetch/cached uri #:ttl 3600)) >> + (sxml (html->sxml port))) >> + (close-port port) >> + (delete-duplicates (html-links sxml))))) > > I=E2=80=99m always confused by which framework for exception does the pro= ject > rely on? There is old =E2=80=99catch=E2=80=99 and =E2=80=99throw=E2=80= =99 then sometimes new > =E2=80=99with-exception-handler=E2=80=99 and =E2=80=99raise=E2=80=99. An= d also SRFI 34. > > What=E2=80=99s the preferred convention? My take: SRFI-34. Before 3.0 we had to use =E2=80=98catch=E2=80=99 for key= +args exceptions, which is why it=E2=80=99s still used a lot. Hopefully it=E2=80=99ll get more homogeneous over time. :-) Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 12:19:01 2024 Received: (at 74542) by debbugs.gnu.org; 26 Nov 2024 17:19:01 +0000 Received: from localhost ([127.0.0.1]:51046 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFzDJ-0005EC-C5 for submit@debbugs.gnu.org; Tue, 26 Nov 2024 12:19:01 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36876) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFzDH-0005Do-L7 for 74542@debbugs.gnu.org; Tue, 26 Nov 2024 12:19:00 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tFzDC-00059G-E0; Tue, 26 Nov 2024 12:18:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=/+DvUbm8qQ129fXoSAXsE2Q+m2khDtFxKqJgY34LV1o=; b=RCJuESNzUud6RjmZ32Rp 9TcZW/Mkcfm5puSBkGj+FKU3fhvsMh1okk1BWLe6NIXL7xxi+VusPBNtnoDCHwuFE+9EyZv6GgC4V LV1tptc/ZX6Q41c732TsmSVVJq5+OUYsjNQxCuWjQPvJsxsT9hpMFJD/m36203UfLkSTw0CItazbh k44XRck3XhEaaP+tVDrsr8K1Qe51EYrayInYzjg3P2yybzw85JyxpmXndZbrjP70YNUTuf4tzBC54 lbm1vNqMOPjQaKz8PjYikexEKJW27baby2xUC0dr3ln5K5w84Bjs4v1DdxdJICtBjdN62jpl2TKN/ Mf8WDVYM5mrlvA==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Simon Tournier Subject: Re: [bug#74542] [PATCH 11/11] etc: Add upgrade manifest. In-Reply-To: <874j3u2dxk.fsf@gmail.com> (Simon Tournier's message of "Tue, 26 Nov 2024 16:49:11 +0100") References: <874j3u2dxk.fsf@gmail.com> Date: Tue, 26 Nov 2024 18:18:52 +0100 Message-ID: <87bjy1ap6r.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74542 Cc: Christopher Baines , Josselin Poiret , Tobias Geerinckx-Rice , Mathieu Othacehe , 74542@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Simon Tournier skribis: > On Tue, 26 Nov 2024 at 11:33, Ludovic Court=C3=A8s wrote: > >> +(define leaf-package-updates >> + ;; Select a subset (~22%) of all the leaf packages, typically small C= /C++ >> + ;; packages not part of a bigger "collection" or repo (CRAN, PyPI, et= c.). >> + (manifest >> + (filter-map (lambda (package) >> + (and (memq (package-build-system package) >> + (list gnu-build-system cmake-build-system)) >> + (package-with-upstream-version (pk 'up package)))) >> + (leaf-packages)))) > > I would be finer here. For instance, the manifest contains the same > package at several versions, i.e., =E2=80=99package-with-upstream-version= =E2=80=99 > applies to the same package at different version. Slurm is one example > among many others: Right, so there will be duplicates. Is that what you mean? (I think it=E2=80=99s okay to have duplicates at this stage, no big deal.) Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 12:21:35 2024 Received: (at 74542) by debbugs.gnu.org; 26 Nov 2024 17:21:35 +0000 Received: from localhost ([127.0.0.1]:51117 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFzFm-0005QK-Ve for submit@debbugs.gnu.org; Tue, 26 Nov 2024 12:21:35 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33372) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFzFm-0005Q0-8h for 74542@debbugs.gnu.org; Tue, 26 Nov 2024 12:21:34 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tFzFh-0005io-1P; Tue, 26 Nov 2024 12:21:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=ozoql1N7RFSDlIXw9YnMV9fsHIjLzn83UPUJ3J+grHI=; b=QFxLOMwoUhMfBk4W6W1n Jf2Y/jFaWWieq6kU1XxAqHewqVUGOo9lrK0f1yptXgdGoLvHOkUEA/oyR5yUF9ZwETeXOiQckv3ax VNg89HQZY5+rWM7DDS5IcEjCcjhWL8Wcc8R9WWnuHGK/qW+0WjI1r+b2hv05DHOJwB7ebG5q1Xu6I GZZnjKhe9bw0zDxpAovSEZ1E4TK1zVsWtlUKdtMCXcWnhBzoRFZBO8RaTqBIY3hj1cc0JPUT4f0dx AZqZZh/phJD1jLvOYBb9OgFX4+6+MomXYsvz5QyDfuvRZGkO/y8EWne+b6wGES8cz35HigZifcGJl 7AmVr+9ZjOiBIQ==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Simon Tournier Subject: Re: [bug#74542] [PATCH 00/11] Improved tooling for package updates In-Reply-To: <8734je3us6.fsf@gmail.com> (Simon Tournier's message of "Tue, 26 Nov 2024 15:59:53 +0100") References: <8734je3us6.fsf@gmail.com> Date: Tue, 26 Nov 2024 18:21:26 +0100 Message-ID: <877c8pap2h.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74542 Cc: Christopher Baines , Josselin Poiret , Tobias Geerinckx-Rice , Mathieu Othacehe , 74542@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Simon Tournier skribis: > Maybe, we could be a bit more stringent on the list and filter out more > packages than only the ones based on build-systems. Yes, I agree. I=E2=80=99m not too concerned about multi-versioned package (clang, slurm, etc.): worst that can happen is that we=E2=80=99ll in fact b= uild just a single package, even though it appears several times in the resulting manifest. But things like PyPI, the kernel, etc., should probably be avoided. Not sure what filtering predicate to use. Thoughts? Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 12:24:12 2024 Received: (at 74542) by debbugs.gnu.org; 26 Nov 2024 17:24:12 +0000 Received: from localhost ([127.0.0.1]:51187 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFzIK-0005Wg-Fz for submit@debbugs.gnu.org; Tue, 26 Nov 2024 12:24:12 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58704) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFzII-0005WO-Rw for 74542@debbugs.gnu.org; Tue, 26 Nov 2024 12:24:11 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tFzIC-0006ET-Kb; Tue, 26 Nov 2024 12:24:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=HlK6b6yQwZpgbBw36crt8lvIKW1/fKQfyZ5xlcLjSa4=; b=J/Y0sZ6fAJ9e5Cpc0c9d 2G9uc7oS/xtOk1EZkikqadKldW324xcBfZMVMjBpdZdx4+a4pBLp0sQWT/0MaYPZwWamS6YKN7mug gVLQZN3lraVEAtPyE5O+jbcp4Udyc1USCBAYaRJqGUxX49zqUwxto8BodPkvPZmq4/VYBlNCZZ/yY OeyNyyzshsmd8SX2nJPrWL/hE/E9xYPooCgTGkNrBC80LeGE0Xwpbuc/iYyhyEoadRAdGFZ8BbL3+ nu9vMD7VpMTOEwxdI9BqvRfpEh4mXGHng65Cb6Z3vFIKT5XEXykW9kX+xqEgZW/d4nubF0MLogwni n5GfNqnB25QYgA==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Suhail Singh Subject: Re: [bug#74542] [PATCH 00/11] Improved tooling for package updates In-Reply-To: <87ed2yufar.fsf@gmail.com> (Suhail Singh's message of "Tue, 26 Nov 2024 11:32:12 -0500") References: <87ed2yufar.fsf@gmail.com> Date: Tue, 26 Nov 2024 18:23:45 +0100 Message-ID: <8734jdaoym.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74542 Cc: Josselin Poiret , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , 74542@debbugs.gnu.org, Christopher Baines X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Suhail Singh skribis: > If the goal is to improve how up-to-date a distro Guix is, then the > below would help. In no particular order (the numbers are only to > provide named references): That=E2=80=99s the goal, and what you propose makes a lot of sense to me. = This patch series is just first steps in that direction, I hope. Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 27 14:28:31 2024 Received: (at 74542) by debbugs.gnu.org; 27 Nov 2024 19:28:31 +0000 Received: from localhost ([127.0.0.1]:34591 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGNiA-0005wl-Uo for submit@debbugs.gnu.org; Wed, 27 Nov 2024 14:28:31 -0500 Received: from mail-wm1-f45.google.com ([209.85.128.45]:43028) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGNi9-0005wb-3q for 74542@debbugs.gnu.org; Wed, 27 Nov 2024 14:28:29 -0500 Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-434a95095efso7402445e9.0 for <74542@debbugs.gnu.org>; Wed, 27 Nov 2024 11:28:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732735648; x=1733340448; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=HX1iAvcCaWUpyfYAbr9TbyMJ2krUGAXoqu7pSz5s3fM=; b=e3EX9xFovv+ac85XayoKxMhQv8oXkSWacENfZAasl10/D08uYUKtrcUXAgy13clM7f jS4HUU7tFJTtPJ1NMMaKv3sgM54H1DVV9Qx40Cqt0HwTu+c/LseifzaRlZPK+jXUvlSl Q4gMUCimT+5Lh57LCbqzh3XJ4xUvGP3qoRiVKXMNVsmHeiGNKNDoQTlneAaf+E4uu6T1 aSMx7vPLRbroNIa+yUMEj9nF6yCkyPr7/iGQd+EdgwY9sYb+35/CrHWnn8785tYqWo9j kOEdrtNJZGerneXkCGSTHhm9ua+KN6DBoRY482xCA4MQk1eK9yzp7KM50k5ykY7emazQ kwJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732735648; x=1733340448; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HX1iAvcCaWUpyfYAbr9TbyMJ2krUGAXoqu7pSz5s3fM=; b=MBbG8pzxhujG/20YgdmwS85lPPtIvgrGhEnvYcLwjhb0s52pmq6oPpjLjzGLXJ33kt vNXscblUaYJBv1zc2iJMpGEToMWYqaFUBHFJcXOwFGY/uJBchC8dzUl6bvN8n0ii49hR GQx22Fu+5X9mzDp5pcXzSUw8eI3Ivam2zTW0D8ZUEm9WkDeP+KKFjBIKbuhGFIWeJsWH BBUd/1hy2jlYHnpx/kP35ccSBAHMWzVDWbPgCeDmx7ec+Yk5JcFbXD3zBMAhT1lQE56f zSYRyL6S87mzOLGuCqCUj38BbmCtj1vuLxnwOVchfDzgTlnWxpxzw/h7dQ2VlAKR+oys Slsw== X-Forwarded-Encrypted: i=1; AJvYcCW/X6JK9Vu5upe79+rvK3YRrwzX5r4UHXuQCDa/+Gf90nNTJAUXD4DgJSmZt5LzhTtUsoRZKQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwySa8jOgyexc2+yPoAMvUaLUz4Y6+i3RVf76TxBqYR4my/nWH2 qse/IED+R4949tVdidvYampOr7dBFBYu6b5UWEHR4VOhaaT0j71b X-Gm-Gg: ASbGnct7l52NsBegDAzBg8B6iguZdFuWjsjd0BxRnLOUiUW6B+2LFgz+knHBkqn8EGQ 0JT96O5nuO8fpPYHBa4EGvmXa+7cJEERMAvC+sP8Yej2qqg0tkV3mOqeJMzWA8P4DeS3/d8Frnn ogoXUMwEIkxzoua2qKj2xUJoFlExR7mlvvJYxY4Db6k4MRK7asoA7Os4LbL/YvPeIEWnfYNum+k xbEHhq5LtPw2BXqIuaSsmmI2vKk6q2dPfFGem5P2CzPwpHT8ZK5WkeKI1YleL/CKXa1uaHt4Iaf mNLfc/DPMKccu5st2noY8/XfC28xWiaTtb4= X-Google-Smtp-Source: AGHT+IEQ5dyU7qOzwdPWSUfIT522aouDR5tOjZwJ5Acfg4ijhgQspGV63zWozyKwE7N0bqRbH9i4lw== X-Received: by 2002:a05:6000:1884:b0:382:47d0:64b0 with SMTP id ffacd0b85a97d-385cbd5e8f0mr547096f8f.2.1732735648286; Wed, 27 Nov 2024 11:27:28 -0800 (PST) Received: from lili (roam-nat-fw-prg-194-254-61-41.net.univ-paris-diderot.fr. [194.254.61.41]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3825fad6292sm17038380f8f.19.2024.11.27.11.27.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Nov 2024 11:27:27 -0800 (PST) From: Simon Tournier To: Ludovic =?utf-8?Q?Court=C3=A8s?= , 74542@debbugs.gnu.org Subject: Re: [bug#74542] [PATCH 05/11] packages: Factorize =?utf-8?Q?=E2=80=98all-packages=E2=80=99=2E?= In-Reply-To: <21b5368441ff34f5a54b78550b87d97ca765785e.1732615193.git.ludo@gnu.org> References: <21b5368441ff34f5a54b78550b87d97ca765785e.1732615193.git.ludo@gnu.org> Date: Wed, 27 Nov 2024 19:45:52 +0100 Message-ID: <87plmg4isf.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74542 Cc: Christopher Baines , Ludovic Court?s , Tobias Geerinckx-Rice , Josselin Poiret , Mathieu Othacehe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, On Tue, 26 Nov 2024 at 11:33, Ludovic Court=C3=A8s wrote: > Change-Id: I6072952c4b877b541037ce86402cfb7744eeb0a0 > --- > etc/source-manifest.scm | 13 +------------ > gnu/packages.scm | 20 +++++++++++++++++++- > guix/scripts/graph.scm | 10 ---------- > guix/scripts/refresh.scm | 10 ---------- > guix/scripts/weather.scm | 15 --------------- > 5 files changed, 20 insertions(+), 48 deletions(-) LGTM. Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 27 14:28:37 2024 Received: (at 74542) by debbugs.gnu.org; 27 Nov 2024 19:28:37 +0000 Received: from localhost ([127.0.0.1]:34595 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGNiH-0005xF-9w for submit@debbugs.gnu.org; Wed, 27 Nov 2024 14:28:37 -0500 Received: from mail-wm1-f49.google.com ([209.85.128.49]:55375) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGNiC-0005wY-5x for 74542@debbugs.gnu.org; Wed, 27 Nov 2024 14:28:32 -0500 Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-432d86a3085so72975e9.2 for <74542@debbugs.gnu.org>; Wed, 27 Nov 2024 11:28:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732735646; x=1733340446; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=1NeJYnTYtpl1rbeGtWjmDaQAe7Zr17GgMbTynUX3+Ig=; b=SIF+YmWT8CnVbtExY4LRM3B0wj1OU80weA1YhTmCuJHwk+xJkLf/htD3apE4diDRf8 5a1QJ0wKSLr6wQcK5aK8utcHoPyYyj6J4Ns/2qgT7bjnr4lvLVSj2UWo9pLU9dY/4bAz wQMshZQ8W1ubPbreSbmJMe7Iu+MJrJYjm+lDSIDoelndQxYh/ymapBPb/lDW6JcXgHjj +KZTNGtCrBns+TXvG5q7qW6hwNjH8pKcd8hQAbwykLW2Myc4Mn0Sjvl9trJiYtMp7Jb4 MsbWEdqARkPmqHuzUGExVg234fTUSae/d8PMCF6oFSZoHpwkxs2amJNHEreebWBXYaB1 IagA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732735646; x=1733340446; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1NeJYnTYtpl1rbeGtWjmDaQAe7Zr17GgMbTynUX3+Ig=; b=NGT7C28sypIS8xyt3upzv6T9UJKkFpcDmS4ftBgtLV/BdKqpHIYtg7XWQ3XWuFEFrM 8lP5brEQrscRWu9ERLcW5umEzLwmC/IQbbe5WLKzYkEOxALoyDKDzWekmXr48ypGevqB QciwWkivJcuTh4mNw+OBgvIJyE3YN5hl0CpHA/FCM1FaJ0z5MxZn3rzJ+MTEopyvRG1W dNzYxPNl2wM2TbZYXjX4jQEgAg7ZVCF5MFTSMS7m94RgWknNPeawYyCjAvGw8g4Pf8N6 kuk9LgM5rEd2vS3p/aXLezw3XnV5eo1bzKB4iWN6BT8XZYXQdDGM/c2Ip6NM7vPfwllR oDdQ== X-Forwarded-Encrypted: i=1; AJvYcCWsRSngEQHDrz+k76/OhZ/VsavukMqrQ28PIYTIhINGL3KH2rI8M4qs0qb4rzcwzgYySg6tfA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyEQG31nGixFtjwUgprUM6dpeK+KIHWGwPPgD0JLVQOuIOQAoIo ebh1tYWgcHJA11Z7m9O57WPL86xupOV1T7tXDU/s7H3mn8o5tJpN5mSP5A== X-Gm-Gg: ASbGnctXSbrEBXWe4VVBu4klHIYZ2M9a6yVz8fIa8Kq+D55QPMl+FPtRsAu3UwaPva9 dwA24KxgNRhxcHrZcQCJ6VYgHkQwUO+oYh5+gm42VHa/YhoesTIO3GLlqqG3w5G2IKUMHkz73SQ i7bcZLing3Gg8dHMqijFeSoYpmMAwylk1EYWY8Y1VXpXNqQw0wZ+wjlgwqN255dsV3FFntKhSDH ebHQoAoNYn/31Yfl1yF9P1hU3YFE5ZagSYQow/niH250I6tQidEijVaHAk8jXd4VznvWwVMxIgT VKaTNwwDF9sxOnqt21cV0ADhV/+EhMV+Xlk= X-Google-Smtp-Source: AGHT+IE31JGbTR3T6zZadIPYy099d21F03Oz2YEo4L5mKj1LRaa+fBRoJ2r9jO/OLfrG3vt4IjGyLg== X-Received: by 2002:a05:6000:1f83:b0:382:4851:46d2 with SMTP id ffacd0b85a97d-385c6cca8bamr3898004f8f.1.1732735646177; Wed, 27 Nov 2024 11:27:26 -0800 (PST) Received: from lili (roam-nat-fw-prg-194-254-61-46.net.univ-paris-diderot.fr. [194.254.61.46]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3825fbc38afsm16999602f8f.67.2024.11.27.11.27.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Nov 2024 11:27:25 -0800 (PST) From: Simon Tournier To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#74542] [PATCH 02/11] gnu-maintenance: =?utf-8?Q?=E2=80=98import-html-release=E2=80=99_doesn=E2=80=99t?= abort upon HTTP 404. In-Reply-To: <87frndapah.fsf@gnu.org> References: <92c108d975939b5dece3fb86ac7bce1edaf619a4.1732615193.git.ludo@gnu.org> <87v7wa2fr5.fsf@gmail.com> <87frndapah.fsf@gnu.org> Date: Wed, 27 Nov 2024 18:05:54 +0100 Message-ID: <87ttbs4nf1.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74542 Cc: Christopher Baines , Josselin Poiret , Tobias Geerinckx-Rice , 74542@debbugs.gnu.org, Mathieu Othacehe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Ludo, On Tue, 26 Nov 2024 at 18:16, Ludovic Court=C3=A8s wrote: > My take: SRFI-34. Before 3.0 we had to use =E2=80=98catch=E2=80=99 for k= ey+args > exceptions, which is why it=E2=80=99s still used a lot. Thanks for explaining. > Hopefully it=E2=80=99ll get more homogeneous over time. :-) I recently introduced catch/throw to stay uniform with the rest of the file. From my point of view, it makes easier to read weeks or months later. That=E2=80=99s said, someone=E2=84=A2 will homogenize the files, on= e day=E2=80=A6 eventually. :-) Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 27 14:28:38 2024 Received: (at 74542) by debbugs.gnu.org; 27 Nov 2024 19:28:38 +0000 Received: from localhost ([127.0.0.1]:34597 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGNiH-0005xI-NN for submit@debbugs.gnu.org; Wed, 27 Nov 2024 14:28:38 -0500 Received: from mail-wm1-f47.google.com ([209.85.128.47]:56825) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGNiC-0005wv-67 for 74542@debbugs.gnu.org; Wed, 27 Nov 2024 14:28:32 -0500 Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-434a14d6bf4so160105e9.1 for <74542@debbugs.gnu.org>; Wed, 27 Nov 2024 11:28:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732735651; x=1733340451; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=gawhJ4UWRFnxq9RrdJD5Ps+UQWRm5ZINsjsINaN63rM=; b=AJt1oSF47SssnE1iGVGJ/N2b+Yjz7v6OtAS43Y7bN4X/3n/ZPcyJ4WGU0UPgSlQPAI LNzjFhU0knEPDrHSsGOVlrbPiZ+x+zGssGHLUBhUr/gfYQeqYc3/LT3Ec9quuaeurgaK TP3H/JNtq+CirUUewh9cZG+F1Zt1C+tLzcIyMGmuVXaZyzDA+QvYcS3p5u/et/PmVhJl gBvIgRkeNraQ7OI/uLjezx43Aosh8yDfzJIwxL5bpH07VJiAt3HiZJBB2/8dIT5E3qqP pYqm1NEcy4f1ME9l24BVe9OF9MHhe4+p+bC6qa+2v8sFf4LqMX/nCFmfg74t0zxsL6f6 Y3Bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732735651; x=1733340451; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gawhJ4UWRFnxq9RrdJD5Ps+UQWRm5ZINsjsINaN63rM=; b=mCQYsNAISZdh/BwIKAUE0e5l7sA0JcmxEOreCgAXT7drm7rb5UCXIes1z9PqKANsTn LAKL+S+nMq6asLl9m6b1vyk/y930QIocGciZ/8I1KgHC5Bb3HLVXlSgfzkwLR9gliWtB IbnepZ6BCAQOGRXDCZUGqdZjbDxFHurOSgsGLdK8KRjEpEKJLffoLF+WqaH8ZjvuiLOF ftcwzgjFiz+TrGM4Fx6qTv6so/OjhoH9CYYYk2aUsWqRAtAwCdLQ9W/W6qBIhEsyyWl5 okGVNaU66t4hoUOQy4TgKIjeEO8/kVAFiBVPmO3KdUHzLq07xUveZ7eUTzY787v2ig99 gTXg== X-Forwarded-Encrypted: i=1; AJvYcCVj8jJ1Ltf7Ik73qOujNKprop1mTmwvWzj63hOhXLhnZ0GCn6Iv/135gsbamRP352m2AvLeqA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzWMm+WZCT6QL3Do/7uM2b8yCaJnWufke/RSuQK7NwNBfORQYYN PbJtdFSAWOzSNMKsuzDS6+kkZpt8+k30dssSy1khUEGK1Ihhoy8i/7qsiQ== X-Gm-Gg: ASbGncsdE0sX45FxT2dSP46TVVBCyA6TPy5pASBsp2nm1y7ehqnBln7/jQhCxAsCDaK s1LM90xNzgrYJ5xFvBZ6THVEPm615W+dGg6rMqr1p2EKVm7hYhCWVpP0N/TXBYEO1+t4IimncHX BsvWXH09n082na71pl3TXX+b2XLVGz8wvrVPL6f+hQWfFz9d444u2faBJn5C3Oi779RvcFhDvvT vBoMW+HP0wTxiuvLA9g+bWbNjpFopHyEXj8MoyV2pY5DjNVdIWx9zIMOr4CTE4nNymH7P6tSeXn McadSZ15j9wUQTNyYmrdBIyGJ5qgpqXKzhY= X-Google-Smtp-Source: AGHT+IH4XuVQJAGRViI3yw5ZuXgxbv/X5bc1UqL/B0wWvJJo9hEiEaSYsqr9zi4zoYXWmFCWoLkKkw== X-Received: by 2002:a05:600c:54ed:b0:434:9c60:95a3 with SMTP id 5b1f17b1804b1-434a9dc14b1mr39257475e9.11.1732735651239; Wed, 27 Nov 2024 11:27:31 -0800 (PST) Received: from lili (roam-nat-fw-prg-194-254-61-40.net.univ-paris-diderot.fr. [194.254.61.40]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-434aa6e929csm31675505e9.0.2024.11.27.11.27.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Nov 2024 11:27:30 -0800 (PST) From: Simon Tournier To: Ludovic =?utf-8?Q?Court=C3=A8s?= , 74542@debbugs.gnu.org Subject: Re: [bug#74542] [PATCH 06/11] guix build: Add =?utf-8?Q?=E2=80=98?= =?utf-8?Q?--dependents=E2=80=99=2E?= In-Reply-To: References: Date: Wed, 27 Nov 2024 20:12:27 +0100 Message-ID: <87jzco4hk4.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74542 Cc: Josselin Poiret , Maxim Cournoyer , Mathieu Othacehe , Ludovic Court?s , Tobias Geerinckx-Rice , Christopher Baines X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, On Tue, 26 Nov 2024 at 11:33, Ludovic Court=C3=A8s wrote: > +@item --dependents[=3D@var{depth}] > +@itemx -T [@var{depth}] Cosmetic: argh, =E2=80=99-M=E2=80=99 is already taken under =E2=80=9Cguix b= uild=E2=80=9D! Because it would be nice to have something similar as with =E2=80=9Cguix graph --max-depth=E2=80=9D. Yes, both depths does not have the same meaning but that=E2=80=99s still a =E2=80=99max depth=E2=80=99 for both cases. ;-) Well=E2=80=A6 > +The list of dependents is computed in the same way as with @command{guix > +refresh --list-dependent} (@pxref{Invoking guix refresh}). =E2=80=A6 =E2=80=9Cguix refresh=E2=80=9D already uses =E2=80=99-T=E2=80=99 = but for another meaning (--list-transitive). Therefore, I think something other than =E2=80=99-T= =E2=80=99 should be better. Maybe =E2=80=99-D=E2=80=99 since it cannot conflict with= =E2=80=9Cguix shell=E2=80=9D.. > + -T, --dependents[=3DN] build dependents of the following package, up= to > + depth N")) As said, =E2=80=99-T=E2=80=99 might be confusing with =E2=80=9Cguix refresh= -T=E2=80=9D especially when =E2=80=99dependents=E2=80=99 is more or less connected with =E2=80=9Cguix r= efresh -l=E2=80=9D. > + (option '(#\T "dependents") #f #t > + (lambda (opt name arg result) > + (alist-cons 'dependents > + (or (and=3D> arg string->number*) +inf.0) > + result))) Idem. > +(define (options->things-to-build store opts) [...] > - (map transform (options->things-to-build opts))) > + (map transform (options->things-to-build store opts))) I thought =E2=80=99store=E2=80=99 could have been hidden, but not. Since i= t=E2=80=99s already passed to =E2=80=99options->derivations=E2=80=99. :-) Well, aside the cosmetic, LGTM. Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 27 14:28:46 2024 Received: (at 74542) by debbugs.gnu.org; 27 Nov 2024 19:28:46 +0000 Received: from localhost ([127.0.0.1]:34601 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGNiQ-0005xy-4L for submit@debbugs.gnu.org; Wed, 27 Nov 2024 14:28:46 -0500 Received: from mail-wr1-f51.google.com ([209.85.221.51]:47255) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGNiI-0005x7-DR for 74542@debbugs.gnu.org; Wed, 27 Nov 2024 14:28:38 -0500 Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-382423e1f7aso48190f8f.2 for <74542@debbugs.gnu.org>; Wed, 27 Nov 2024 11:28:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732735652; x=1733340452; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=1yvce6tD6mq7Bc/62yxKN8NDrtgzUIqKHODYZQM3zus=; b=gvMYomW0G4ZIeMJE534ZzFffj8zp2rsj87CdVRFV7FBFYUhzo4orJ9nrF0EzpZgeMG qMv6FqK+i1cN+w+J1AoFGj4cbMVYUMjZLixpljUMj3YDkDQhDImEKNRcwRhiU9Fw8V3u lxk4LZaceYPGejOozuRNyw1wXKTgdeLB0fwWL9w+/qs5IijYzLCzn6H6sr4eWvMDsJVO sthzDDQy82YUqNIccxuUD68KG1kPQxm/oNv9HEftucq8gqZZF7S0V6kd49NQ4t05FHo6 GYsk9Mv6I+hrFjNq0WcsqwwwF9a5scAPrhnOyqlMd7r/1mOA+CCY0ALz5IbHsSSpa4Vo UlbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732735652; x=1733340452; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1yvce6tD6mq7Bc/62yxKN8NDrtgzUIqKHODYZQM3zus=; b=QN6UYOCaNnqWIIbICT3s4sufDvA+b1peS+r6rlXX+QhXJBvPTLPWhBuPwTOOwELMRR qxUNzmc4lr6ctHuAe8uAIWYPBLuELeDzQRUbYjv3eFi/NdantvGZC4Mh4xeVZSulp320 Ufv2KP7aOclMylMTQ6KZWZ/DBJ7GpePs9PZYvJpO097MV+m86FybSe/MehV72W/+RQND /dgPDa881RCcFWEhL5rSSO38N2S5IWrH3kmDvJzI7RKz1KQr3J3NtR7eutFuQDxYOD1Z C6eBTA6BmReZFbZBegUs+broAKiqsdzLpU/n+XEsdMHuqIBtHGcSMmC9aPllEylEFIA6 Vmyg== X-Forwarded-Encrypted: i=1; AJvYcCVEvRVL0gtwr0ZqzDcFxVVjsOVsVzqmuX1sUXmABKhL+5TratGJa0armzUcOywCYxSYVrQsSw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyM22EX3IwD5lEvd1b54dJ0iY3qkBFIXA6aklpmWEW/oO3hcQbm 4lau2BJi7FD6rx+9oe6Z7E4Try6Z++TK4L5AFCKgHNDn9KlHFH9pibK5AA== X-Gm-Gg: ASbGncsyJ7+fUkDWAkVgfX4sj66tEBedyPInH9WkM1cjmvjTwLWIv3DqAvxG0AOn7Bz rMPkswuB4sjCq4Jz3CGMGd3oAUbVk9pRuNPbsEAwpS7udnsuTg+Ym46y9wxQQbc2Umjb3mwUK7P 0MMHcapDLiyPhNIXu8RF6rwPw+1tvzU5fOUtSaxqDS4A3SiVMBd1qD8+qWErGlnys8HrbMe1JxM CEIvNN6y1Vo1Wwbx3cW6bUwy6wIwj9+fKBaeHPhIv5F8zfxIqnc5PP47lvJ/qeBA3c83pxojS9v 4bRna3JTDvY9bPW+g+sdJvOW7QME+CYiqOY= X-Google-Smtp-Source: AGHT+IElPfwpdrvfe0QSu0MnHLF7kB6lcpCEAVBQVlljchCzrhnjPQ6aPWv0EYtHrvgVjn/ANWGV4Q== X-Received: by 2002:a05:6000:1541:b0:37e:f8a1:596e with SMTP id ffacd0b85a97d-385c6eb6aeemr3149480f8f.11.1732735652395; Wed, 27 Nov 2024 11:27:32 -0800 (PST) Received: from lili (roam-nat-fw-prg-194-254-61-40.net.univ-paris-diderot.fr. [194.254.61.40]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3825faff9cdsm17141313f8f.28.2024.11.27.11.27.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Nov 2024 11:27:32 -0800 (PST) From: Simon Tournier To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#74542] [PATCH 11/11] etc: Add upgrade manifest. In-Reply-To: <87bjy1ap6r.fsf@gnu.org> References: <874j3u2dxk.fsf@gmail.com> <87bjy1ap6r.fsf@gnu.org> Date: Wed, 27 Nov 2024 20:23:00 +0100 Message-ID: <87frnc4h2j.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74542 Cc: Christopher Baines , Josselin Poiret , Tobias Geerinckx-Rice , 74542@debbugs.gnu.org, Mathieu Othacehe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, On Tue, 26 Nov 2024 at 18:18, Ludovic Court=C3=A8s wrote: >>> +(define leaf-package-updates >>> + ;; Select a subset (~22%) of all the leaf packages, typically small = C/C++ >>> + ;; packages not part of a bigger "collection" or repo (CRAN, PyPI, e= tc.). >>> + (manifest >>> + (filter-map (lambda (package) >>> + (and (memq (package-build-system package) >>> + (list gnu-build-system cmake-build-system)) >>> + (package-with-upstream-version (pk 'up package))= )) >>> + (leaf-packages)))) >> >> I would be finer here. For instance, the manifest contains the same >> package at several versions, i.e., =E2=80=99package-with-upstream-versio= n=E2=80=99 >> applies to the same package at different version. Slurm is one example >> among many others: > > Right, so there will be duplicates. Is that what you mean? Yes, duplicates. And also Emacs or Python packages. As discussed elsewhere [1] in the thread, when looking more closely to the 2843 packages, the list could be shortened a bit. In other words, I would be fine here in the way to filter out. :-) > (I think it=E2=80=99s okay to have duplicates at this stage, no big deal.) It will trigger updaters for nothing because we know beforehand either the updater will fail for whatever reasons, either the updater will return the same package and thus the duplicates will be removed when building the manifest. Well, maybe it=E2=80=99s useless indeed because it saves nothing compared to watching a online videos or else, but still it hurts me to waste resource when it could be done a bit differently to avoid such waste. Cheers, simon 1: [bug#74542] [PATCH 00/11] Improved tooling for package updates Simon Tournier Tue, 26 Nov 2024 15:59:53 +0100 id:8734je3us6.fsf@gmail.com https://issues.guix.gnu.org/74542 https://issues.guix.gnu.org/msgid/8734je3us6.fsf@gmail.com https://yhetil.org/guix/8734je3us6.fsf@gmail.com From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 27 14:28:47 2024 Received: (at 74542) by debbugs.gnu.org; 27 Nov 2024 19:28:47 +0000 Received: from localhost ([127.0.0.1]:34603 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGNiQ-0005y2-Ke for submit@debbugs.gnu.org; Wed, 27 Nov 2024 14:28:46 -0500 Received: from mail-wr1-f54.google.com ([209.85.221.54]:50291) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGNiJ-0005xA-Lu for 74542@debbugs.gnu.org; Wed, 27 Nov 2024 14:28:40 -0500 Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-382610c7116so72125f8f.0 for <74542@debbugs.gnu.org>; Wed, 27 Nov 2024 11:28:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732735654; x=1733340454; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=G1N9iwgJB4SBUFtBgFDUgWcnWt8zwM2768uKn30ILDw=; b=e7rANizTnWTSy/9On5TzsI1fXAsPRH9NHOWbH8/zyS1ol+mStqg1JtkUYEM5Tq1y3z nMuADnFWl4b0TFpI/AikQiRUvB9WqLmsS/ZfEA15XyKS0hKONqaldmNOaJJq53BvFjtF 93kYsXLiLK0RLRyVD6GQ2KfFatoDN6+2TiFiwawvKnK/I4m0ZvSRdaGgmNq4EFwZKcHB GnD3aPbKzqEKZ6mSAllgPIITfettnI60JAgT662gUPj8nNhHzx14GvOsmNeueEnrDOQY tz8lkRj1MG4xaz6x4jW8D5lFNJlIOYLJiUKidDl1ag3YH/tQ47NkdQSECHCAKNySpvHa O6nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732735654; x=1733340454; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=G1N9iwgJB4SBUFtBgFDUgWcnWt8zwM2768uKn30ILDw=; b=KoMk12F0ED2UYhhSK2N+8MO913fYs7D76w5CsC1EJ0b4arrPfUsemVREVgesOZDWVz V0vHv8PvcgZI1nFuLiYqS210fFJdr8ha1p/c3EbKu9BSYbUWdlvygccYeg9v+NIWuYLp A9pdDb75o/76zH5BQpeDUwF76CZnduJdqD0gCxZCCinlsz6GCdlKpLsWIQPi9I0R0i95 JhcF8Df40NoIFIW82F0XS+4o45iw23/tsdv32Pg/TD/7DXKodiSsRVpvuISYqWijuZml 9+6oNutYXvX5yAQKxsg43F5bgsVXrbr/wAIxtODDCq+4NHxh758CXTUIW0OaX0ABc9dn tklQ== X-Forwarded-Encrypted: i=1; AJvYcCWoeBoBpp/3vN6jIUobcCOTRVxx5k/ZLY7ruw/BOJoPa9NKeLqAtAzTAonpur77busfs8D8iA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyP0FFkG2eDClj2lvDttwlzRTxizuqkNTpHwr+1SrV3XprSMRRk dW/OplhI6vuhvZ/gx1u5/Z0IrQhhFikPmBPzJOkMppY7UsCcAcJqis0sXQ== X-Gm-Gg: ASbGncu9Nxkbw9HBM7CbNWI4d0JOXzIdEtfPY6KxpJpx+sgE3BZj0YotWTR1Ux5wbwz zG1gzV+Tv00doeLkYAJRhe6TH4VfIU5HUIRoiQz0X2HXxmwDA1l4YIZf3BFHzCzcygi+NkAkycA bFD+SzOjXz2TcB2aSbwGoz6sattbPfaypWBfkg+oVptXO+5YgBdAO6NbOxR6g3Yj1qT2ri4CBsV KfsWBvjjj8tRPJ9vi5arGKSiMds0jmlGSG2EnrvXCl05LDorh/CA55OR0q8+MhK4TtmJZOvArQa 66QXnRri1junvCM1IFONdo14L5pMRhtXu9w= X-Google-Smtp-Source: AGHT+IF6B2EznuLoDcYMPY8w4NllhI1T7Cmt+PxG74aatPt0QWI//VCHhvcq4wbMvN094DdlD7auvQ== X-Received: by 2002:a5d:6482:0:b0:382:38e6:1ed8 with SMTP id ffacd0b85a97d-385c6edc3a7mr3320425f8f.49.1732735653947; Wed, 27 Nov 2024 11:27:33 -0800 (PST) Received: from lili (roam-nat-fw-prg-194-254-61-47.net.univ-paris-diderot.fr. [194.254.61.47]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-434aa7b7917sm30195605e9.13.2024.11.27.11.27.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Nov 2024 11:27:32 -0800 (PST) From: Simon Tournier To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#74542] [PATCH 00/11] Improved tooling for package updates In-Reply-To: <877c8pap2h.fsf@gnu.org> References: <8734je3us6.fsf@gmail.com> <877c8pap2h.fsf@gnu.org> Date: Wed, 27 Nov 2024 20:26:18 +0100 Message-ID: <87cyig4gx1.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74542 Cc: Christopher Baines , Josselin Poiret , Tobias Geerinckx-Rice , 74542@debbugs.gnu.org, Mathieu Othacehe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, On Tue, 26 Nov 2024 at 18:21, Ludovic Court=C3=A8s wrote: > But things like PyPI, the kernel, etc., should probably be avoided. > > Not sure what filtering predicate to use. Thoughts? For now, I have nothing better to propose other than filtering on package name. For instance, exclude =E2=80=9Cemacs-=E2=80=9D, =E2=80=9Cpyt= hon-=E2=80=9D, =E2=80=9Cr-=E2=80=9D (there is one ;-)), =E2=80=9Cghc-=E2=80=9D, =E2=80=9Cocaml-=E2=80=9D etc. Maybe =E2= =80=9Clinux-=E2=80=9D too. Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 28 05:50:25 2024 Received: (at 74542) by debbugs.gnu.org; 28 Nov 2024 10:50:25 +0000 Received: from localhost ([127.0.0.1]:36851 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGc6L-0001m0-FD for submit@debbugs.gnu.org; Thu, 28 Nov 2024 05:50:25 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45696) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGc6J-0001la-Rt for 74542@debbugs.gnu.org; Thu, 28 Nov 2024 05:50:24 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tGc65-0004YJ-Td; Thu, 28 Nov 2024 05:50:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=dZh7ccuyjKRNTopEauzg9l8J8tfelBKe2C59nmGbWFQ=; b=a3fQaFgbKzeSW/2o+FOu rzt8XYJlVVL4SfG9/8n1nX2AkAo8amXQhOhbge/P3SyUEFWHswoQjlS4/e36pVbaKwjNoO0vM0C1+ wJgx3fMrVeNZsNQM5s5vt1fOl/typC9/oN9g3SNRDCL2HzgHQpwbtPJ3jN0PmpNmK/LmoDsrYXA1Y goXHbpbuB9BVK+O2dZf4KDegLEvD45B6k7xenxVXX2xRl0OnGee4tnQnkXGupGmQg2otRBwAFmSmF fmW9E1o2zfXr6n1csoGZvciK0e2eb5A7Q5Qy0HhrnoDaVW758cYalHbXh5b2SvW3eCEbacC6Z9bzE nhy4d7YqoR7QQQ==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Simon Tournier Subject: Re: [bug#74542] [PATCH 04/11] build: Add =?utf-8?Q?=E2=80=98--dev?= =?utf-8?Q?elopment=E2=80=99?= option. In-Reply-To: <87o7222ezi.fsf@gmail.com> (Simon Tournier's message of "Tue, 26 Nov 2024 16:26:25 +0100") References: <7c530a62370853828f181db011cb2f12fdc78847.1732615193.git.ludo@gnu.org> <87o7222ezi.fsf@gmail.com> Date: Thu, 28 Nov 2024 11:49:36 +0100 Message-ID: <87ed2v63b3.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74542 Cc: Josselin Poiret , Maxim Cournoyer , Mathieu Othacehe , Tobias Geerinckx-Rice , 74542@debbugs.gnu.org, Christopher Baines X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Simon Tournier skribis: > Here the oneline commit message is: > > build: Add =E2=80=98--development=E2=80=99 option. > > when elsewhere in the same series, it reads: > > guix build: Add =E2=80=98--dependents=E2=80=99. > > I suggest consistency; =E2=80=99build:=E2=80=99 or =E2=80=99guix build:= =E2=80=99 for both. Oops, fixed (will send v2 later). From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 28 05:58:13 2024 Received: (at 74542) by debbugs.gnu.org; 28 Nov 2024 10:58:13 +0000 Received: from localhost ([127.0.0.1]:36893 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGcDs-000284-Lp for submit@debbugs.gnu.org; Thu, 28 Nov 2024 05:58:12 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48104) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGcDq-00027o-F5 for 74542@debbugs.gnu.org; Thu, 28 Nov 2024 05:58:10 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tGcDk-0000oi-W3; Thu, 28 Nov 2024 05:58:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=5U2NQRWOwbsOac6lcdwCBUcu/UymVtiZc9k4iRSMQaw=; b=KouALBdLiUVnIvmCeZ/8 CBmzv2qgw1ZoQLno55WyTpdyTIyQzz76VK3f6n8NmAMFDX0VUd2crTjbOw3d63n5NWZYz2z/94hxG LqB8jEX8UC1nDwJOAosYrk9Z9W8WlNf7VvMXdk5FGqFpLbIg5KZCcIXvRhwrhU6ek5NGjgaaDmL58 KEVLw9OySpfnW5KGBgYdqr3kEkm7YMpF3B2wnXXm6tr5MzMMxiESlleq/Jj6Bp+LMPibk2Wm/1lS+ Y3QI8mOUqTldGhZbOyWM7/ylBa1WkFqXqfvukp1k0/huSlDK1uvxuA9vekQbWwqKeZhQfVUajCa8i /Ac3rASderEt5A==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Simon Tournier Subject: Re: [bug#74542] [PATCH 06/11] guix build: Add =?utf-8?Q?=E2=80=98?= =?utf-8?Q?--dependents=E2=80=99=2E?= In-Reply-To: <87jzco4hk4.fsf@gmail.com> (Simon Tournier's message of "Wed, 27 Nov 2024 20:12:27 +0100") References: <87jzco4hk4.fsf@gmail.com> Date: Thu, 28 Nov 2024 11:57:38 +0100 Message-ID: <87a5dj62xp.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74542 Cc: Josselin Poiret , Maxim Cournoyer , Mathieu Othacehe , Tobias Geerinckx-Rice , 74542@debbugs.gnu.org, Christopher Baines X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Simon Tournier skribis: >> +@item --dependents[=3D@var{depth}] >> +@itemx -T [@var{depth}] > > Cosmetic: argh, =E2=80=99-M=E2=80=99 is already taken under =E2=80=9Cguix= build=E2=80=9D! Because it > would be nice to have something similar as with =E2=80=9Cguix graph > --max-depth=E2=80=9D. Yes, both depths does not have the same meaning but > that=E2=80=99s still a =E2=80=99max depth=E2=80=99 for both cases. ;-) > > Well=E2=80=A6 > >> +The list of dependents is computed in the same way as with @command{guix >> +refresh --list-dependent} (@pxref{Invoking guix refresh}). > > =E2=80=A6 =E2=80=9Cguix refresh=E2=80=9D already uses =E2=80=99-T=E2=80= =99 but for another meaning > (--list-transitive). Therefore, I think something other than =E2=80=99-T= =E2=80=99 > should be better. Maybe =E2=80=99-D=E2=80=99 since it cannot conflict wi= th =E2=80=9Cguix > shell=E2=80=9D.. The previous patch adds =E2=80=98-D=E2=80=99 with the same meaning as in = =E2=80=98guix shell=E2=80=99 so it=E2=80=99s not available either. I looked for other options and found =E2=80=98-P=E2=80=99, which is unused = in =E2=80=98guix build=E2=80=99 and =E2=80=98guix refresh=E2=80=99; it=E2=80=99s an alias fo= r =E2=80=98--link-profile=E2=80=99 in =E2=80=98guix shell=E2=80=99, an option that wouldn=E2=80=99t make sense in =E2=80=98guix= build=E2=80=99. Thoughts? Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 29 04:40:54 2024 Received: (at 74542) by debbugs.gnu.org; 29 Nov 2024 09:40:54 +0000 Received: from localhost ([127.0.0.1]:41008 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGxUb-0005pw-Hx for submit@debbugs.gnu.org; Fri, 29 Nov 2024 04:40:53 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGxUZ-0005pQ-Kr for 74542@debbugs.gnu.org; Fri, 29 Nov 2024 04:40:52 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tGxUQ-0003le-ON; Fri, 29 Nov 2024 04:40:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=7skomakDrjVvD2DjZQrnab6W+vi82mi4d1yEkNRwGt8=; b=UB+A2CDQtnyQ5fyOnAj4 5qQKs0cpIafWJw8YiEIQvLQ9srd5/UBs4G/Uy9vqfIhHrO2OwKPdlV6mGLu6mFZMMjdl9twGXpT6c /UsJOrnFxc4HCyzJOZFWryOFqCJ5kXkHH9mUbQRdur8Hp/svSg7SQCMteR0n925xbTdZ2ffuT/+R2 gfWFW8wZCrV7SXjtIF/eK19R16+joKId1xybZfDgJCyYqjqxNk1iWJycS7FfMBO7tQUl6uicoczaP v33LPLdHdjPIcTEeeXYWcJyHB+P6VNfEN5cRHrJSgcv/FXeETNOArXsZI1FreDdbO5EcPEO1O4Ima LuilUtmas6dhbQ==; From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 74542@debbugs.gnu.org Subject: [PATCH v2 01/16] =?UTF-8?q?transformations:=20Export=20=E2=80=98p?= =?UTF-8?q?ackage-with-upstream-version=E2=80=99.?= Date: Fri, 29 Nov 2024 10:40:04 +0100 Message-ID: <554a7bccd73b93f5b14af4695e900c1a94dbb9be.1732872498.git.ludo@gnu.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Debbugs-Cc: Christopher Baines , Josselin Poiret , Ludovic Courtès , Mathieu Othacehe , Simon Tournier , Tobias Geerinckx-Rice Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74542 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * guix/transformations.scm (package-with-upstream-version): Export. Change-Id: I8e09e69e9c32bffc329c97ef1c0258f750181b11 --- guix/transformations.scm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/guix/transformations.scm b/guix/transformations.scm index ea8b7a0844..9dfc4402c5 100644 --- a/guix/transformations.scm +++ b/guix/transformations.scm @@ -61,6 +61,8 @@ (define-module (guix transformations) tunable-package? tuned-package + package-with-upstream-version + show-transformation-options-help transformation-option-key? cacheable-transformation-option-key? -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 29 04:40:54 2024 Received: (at 74542) by debbugs.gnu.org; 29 Nov 2024 09:40:54 +0000 Received: from localhost ([127.0.0.1]:41010 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGxUc-0005pz-0H for submit@debbugs.gnu.org; Fri, 29 Nov 2024 04:40:54 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39624) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGxUZ-0005pP-Gb for 74542@debbugs.gnu.org; Fri, 29 Nov 2024 04:40:52 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tGxUP-0003jf-Hr; Fri, 29 Nov 2024 04:40:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=8jBWdTzMpoQSH2YggZH/sg4RaM5fUc156ugtZxBQDm0=; b=Ta1jbO/pQFibpSxnHEge b6V8c5OytEUh3JtQo0ls1Io8ra+PiE4yeSC4XDLs+E2+ExibGtZiBJzjF1lH42+kcKry127KuVrfy 50FTJ08a+RFngjBaNva1x0eoywTARYzp3PDeQBeKww51SVrfN5h+hGFUHbANn1rs9GMTXgG7Pcafd fi8dOaoNAed5u5hL9o3uKgn9vp2tUWXY0wvAaUL4NUQaeLC25D+s6MTtw/Yyc2fQKLNLPQWx+21yY 7fricGZ345TwuaEZH+ucIWzPRpMlIkuwL21WKKzJHoMNkB85b/xuXQv2OdXvsmK9KHOgXO8rBjRuq IwZn5jK/KzC6FA==; From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 74542@debbugs.gnu.org Subject: [PATCH v2 00/16] Improved tooling for package updates Date: Fri, 29 Nov 2024 10:40:03 +0100 Message-ID: X-Mailer: git-send-email 2.46.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Debbugs-Cc: Christopher Baines , Josselin Poiret , Ludovic Courtès , Mathieu Othacehe , Simon Tournier , Tobias Geerinckx-Rice Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74542 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello! This version aims to address comments by Simon and additional issues I stumbled upon: • Short option for ‘--dependents’ is now ‘-P’ (instead of ‘-T’). • More package refresher metadata updates (GnuTLS, Git). • ‘generic-html’ updater correctly computes URLs for ‘curl’ and any other package that uses in its release monitoring page. • ‘package-with-upstream-version’ can preserve patches. This turns out to be a hard requirement if we want to make this useful. While ‘guix build openssl --with-latest=openssl’ dismisses patches, what we want here instead is to preserve patches, such that what’s being built is exactly the same as what we’d get with ‘guix refresh -u openssl’. • ‘package-with-upstream-version’ can disable authentication: it’s essentially required if we are to run this in a non-interactive way, given the fact that we cannot reliably fetch keys from OpenPGP key servers. • Manifest is now limited to a dozen security-critical packages (I left out leaf packages entirely; we can work on it separately later). • Manifest is more precise: it refers to the packages to update by their variable (rather than by package specs), which again makes sure we’re upgrading the exact variant we want to upgrade. Thoughts? I’d like to have the manifest built by CI soon so we can assess its usefulness and tweak it as needed. Ludo’. Ludovic Courtès (16): transformations: Export ‘package-with-upstream-version’. gnu-maintenance: ‘import-html-release’ doesn’t abort upon HTTP 404. gnu-maintenance: Savannah/Xorg updaters no longer abort on network errors. guix build: Add ‘--development’ option. packages: Factorize ‘all-packages’. guix build: Add ‘--dependents’. import: gnome: Keep going upon HTTP errors. gnu-maintenance: ‘gnu-ftp’ updater excludes GnuPG-hosted packages. gnu: Update updater properties for GnuPG-related packages. gnu: gnutls: Change release monitoring URL. gnu: git-minimal: Add ‘upstream-name’ property. gnu-maintenance: ‘generic-html’ update honors . guix build: Validate that the file passed to ‘-m’ returns a manifest. transformations: ‘package-with-upstream-version’ can preserve patches. transformations: Add #:authenticate? to ‘package-with-upstream-version’. etc: Add upgrade manifest. Makefile.am | 1 + doc/contributing.texi | 4 +- doc/guix.texi | 52 +++++++++ etc/source-manifest.scm | 13 +-- etc/upgrade-manifest.scm | 128 +++++++++++++++++++++ gnu/packages.scm | 20 +++- gnu/packages/gnupg.scm | 40 ++----- gnu/packages/tls.scm | 6 +- gnu/packages/version-control.scm | 3 +- guix/download.scm | 3 +- guix/gnu-maintenance.scm | 90 +++++++++------ guix/import/gnome.scm | 13 ++- guix/scripts/build.scm | 185 ++++++++++++++++++++++++------- guix/scripts/graph.scm | 10 -- guix/scripts/refresh.scm | 10 -- guix/scripts/weather.scm | 15 --- guix/transformations.scm | 43 ++++++- tests/guix-build.sh | 11 ++ tests/transformations.scm | 31 +++++- 19 files changed, 517 insertions(+), 161 deletions(-) create mode 100644 etc/upgrade-manifest.scm base-commit: f8979b4bcc8772d02640f6f665b4195380d57df9 -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 29 04:41:06 2024 Received: (at 74542) by debbugs.gnu.org; 29 Nov 2024 09:41:07 +0000 Received: from localhost ([127.0.0.1]:41035 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGxUm-0005rr-RL for submit@debbugs.gnu.org; Fri, 29 Nov 2024 04:41:06 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39582) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGxUd-0005pc-6x for 74542@debbugs.gnu.org; Fri, 29 Nov 2024 04:40:56 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tGxUW-0003nb-1B; Fri, 29 Nov 2024 04:40:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=dULSCUZc1r+OkxdLxcmQkLYesS85XPTzlxIrCobO7+A=; b=KVu5mgcOmjQ4kNK9vSHB t+hhTFgjNRQ4lQSaJBgC8ntNlBndajbmP1IBeKMHBE0XGHkt0jNGe12nkh23MCdfHaBsDsuBPE7o5 9owdLlDLCtWI0CDX38CCd4NbJkpxmjJ8eoMwvamDzaf2yOiBSPPlVgX/MDleyOCtQScpjeNfD7l1/ 0N5b97RZ4uM6IdOnlAedTaDFk2CBw1cVJg8dpR3XGvbnJbXtVfxFFAbCd8zRapW0NrN9LbsQX4VZm M0J2fDob27FEgMGMtFbsG6Ta5rtCM5wmksLqMAYnAlMrzjWIZX3YPp5nFjlPFxWXhEYeCJup5XrtV 7VSo6oQodwKsUA==; From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 74542@debbugs.gnu.org Subject: [PATCH v2 04/16] =?UTF-8?q?guix=20build:=20Add=20=E2=80=98--devel?= =?UTF-8?q?opment=E2=80=99=20option.?= Date: Fri, 29 Nov 2024 10:40:07 +0100 Message-ID: <298ce743d6908424e59c348444fa4d904935646d.1732872498.git.ludo@gnu.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Debbugs-Cc: Christopher Baines , Josselin Poiret , Ludovic Courtès , Mathieu Othacehe , Maxim Cournoyer , Simon Tournier , Tobias Geerinckx-Rice Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74542 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * guix/scripts/build.scm (show-help, %options): Add ‘-D’. (options->things-to-build): Change ‘append-map’ to a loop. Honor ‘-D’. * tests/guix-build.sh: Add test. * doc/guix.texi (Additional Build Options): Document it. Change-Id: I99227aadfe861e43c001a4872292bd687b37f5d4 --- doc/guix.texi | 25 +++++++++ guix/scripts/build.scm | 119 ++++++++++++++++++++++++++++------------- tests/guix-build.sh | 5 ++ 3 files changed, 112 insertions(+), 37 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index 26488b41c8..a9d0d044ae 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -13614,6 +13614,31 @@ Additional Build Options (@pxref{The Store Monad}). The procedure must return a derivation as a monadic value, which is then passed through @code{run-with-store}. +@item --development +@itemx -D +Build the ``development environment'' (build dependencies) of the +following package. + +For example, the following command builds the inputs of @code{hello}, +but @emph{not} @code{hello} itself, and also builds @code{guile}: + +@example +guix build -D hello guile +@end example + +Notice that @option{-D} (or @option{--development}) only applies to the +immediately following package on the command line. Under the hood, it +uses @code{package->development-manifest} +(@pxref{package-development-manifest, +@code{package->development-manifest}}). + +@quotation Note +The effect of combining @option{--development} with @option{--target} +(for cross-compilation) may not be what you expect: it will +cross-compile all the dependencies of the given package when it is built +natively. +@end quotation + @item --source @itemx -S Build the source derivations of the packages, rather than the packages diff --git a/guix/scripts/build.scm b/guix/scripts/build.scm index 9e05bb532b..e8384c8d2d 100644 --- a/guix/scripts/build.scm +++ b/guix/scripts/build.scm @@ -438,6 +438,8 @@ (define (show-help) -m, --manifest=FILE build the packages that the manifest given in FILE evaluates to")) (display (G_ " + -D, --development build the inputs of the following package")) + (display (G_ " -S, --source build the packages' source derivations")) (display (G_ " --sources[=TYPE] build source derivations; TYPE may optionally be one @@ -522,6 +524,9 @@ (define %options (option '(#\m "manifest") #t #f (lambda (opt name arg result) (alist-cons 'manifest arg result))) + (option '(#\D "development") #f #f + (lambda (opt name arg result) + (alist-cons 'development? #t result))) (option '(#\n "dry-run") #f #f (lambda (opt name arg result) (alist-cons 'dry-run? #t result))) @@ -581,43 +586,83 @@ (define-public my-package (for-each validate-type lst) lst)) - (append-map (match-lambda - (('argument . (? string? spec)) - (cond ((derivation-path? spec) - (catch 'system-error - (lambda () - ;; Ask for absolute file names so that .drv file - ;; names passed from the user to 'read-derivation' - ;; are absolute when it returns. - (let ((spec (canonicalize-path spec))) - (list (read-derivation-from-file spec)))) - (lambda args - ;; Non-existent .drv files can be substituted down - ;; the road, so don't error out. - (if (= ENOENT (system-error-errno args)) - '() - (apply throw args))))) - ((store-path? spec) - ;; Nothing to do; maybe for --log-file. - '()) - (else - (list (specification->package spec))))) - (('file . file) - (let ((file (or (and (string-suffix? ".json" file) - (json->scheme-file file)) - file))) - (ensure-list (load* file (make-user-module '()))))) - (('manifest . manifest) - (map manifest-entry-item - (manifest-entries - (load* manifest - (make-user-module '((guix profiles) (gnu))))))) - (('expression . str) - (ensure-list (read/eval str))) - (('argument . (? derivation? drv)) - drv) - (_ '())) - opts)) + (define system + (or (assoc-ref opts 'system) (%current-system))) + + ;; Process OPTS in "the right order", meaning that if the user typed + ;; "-D hello", arrange to see the 'development? option before the "hello" + ;; spec. + (let loop ((opts (reverse opts)) + (type 'regular) + (result '())) + (define (for-type obj) + ;; Return a list of objects corresponding to OBJ adjusted for TYPE. + (match type + ('regular + (list obj)) + ('development + (if (package? obj) + (map manifest-entry-item + (manifest-entries + (package->development-manifest obj system))) + obj)))) + + (match opts + (() + (reverse result)) + ((head . tail) + (match head + (('argument . (? string? spec)) + (cond ((derivation-path? spec) + (catch 'system-error + (lambda () + ;; Ask for absolute file names so that .drv file + ;; names passed from the user to 'read-derivation' + ;; are absolute when it returns. + (let ((spec (canonicalize-path spec))) + (loop tail 'regular + (cons (read-derivation-from-file spec) + result)))) + (lambda args + ;; Non-existent .drv files can be substituted down + ;; the road, so don't error out. + (if (= ENOENT (system-error-errno args)) + (loop tail 'regular result) + (apply throw args))))) + ((store-path? spec) + ;; Nothing to do; maybe for --log-file. + (loop tail type result)) + (else + (loop tail 'regular + (append (for-type (specification->package spec)) + result))))) + (('argument . (? derivation? drv)) + (loop tail 'regular (cons drv result))) + (('file . file) + (let ((file (or (and (string-suffix? ".json" file) + (json->scheme-file file)) + file))) + (loop tail 'regular + (append (append-map + for-type + (ensure-list (load* file (make-user-module '())))) + result)))) + (('manifest . manifest) + (loop tail 'regular + (append (map manifest-entry-item + (manifest-entries + (load* manifest + (make-user-module '((guix profiles) + (gnu)))))) + result))) + (('expression . str) + (loop tail 'regular + (append (append-map for-type (ensure-list (read/eval str))) + result))) + (('development? . #t) + (loop tail 'development result)) + (_ + (loop tail type result))))))) (define (options->derivations store opts) "Given OPTS, the result of 'args-fold', return a list of derivations to diff --git a/tests/guix-build.sh b/tests/guix-build.sh index 36eac2b7e0..3637bcdeb3 100644 --- a/tests/guix-build.sh +++ b/tests/guix-build.sh @@ -190,6 +190,11 @@ test `guix build -d --sources=transitive foo \ | grep -e 'foo\.tar\.gz' -e 'bar\.tar\.gz' -e 'bar\.dat' \ | wc -l` -eq 3 +# Building the inputs. +guix build -D hello -n +test `guix build -D hello -d \ + | grep -e 'glibc.*\.drv$' -e 'gcc.*\.drv$' -e 'binutils.*\.drv$' \ + | wc -l` -ge 3 # Unbound variable in thunked field. cat > "$module_dir/foo.scm" <) id 1tGxUo-0005sC-OW for submit@debbugs.gnu.org; Fri, 29 Nov 2024 04:41:07 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39596) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGxUd-0005pd-7U for 74542@debbugs.gnu.org; Fri, 29 Nov 2024 04:40:56 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tGxUW-0003nf-TG; Fri, 29 Nov 2024 04:40:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=fVG6zE1g5+COgLKTSq6q72yUelSVfBfqbZ9R64BW7Zw=; b=VIeO0P2m7ruh6p1JsrC8 qnX3Yn0GRbQ7s6Rz5K4wpFDtgIBGTB3LGZDGK6vf8RktneDSptSnBkLpO87fhMQOC+Nn8SQ4Dpgm/ UBLt8rxBjY03VVj+2DV1iTrWbX5PevVBoZjaqh0hzeRyEjwkVYvuwg4vB2dFhgBj+ExYUoqsdL0yq IT+r3bXbOeK6aKl1dc5RFSA3/ao8unJzoU9D/2sGgM6AVf8iucE5yGjxyIrTiSDnUQzgS2wlccPUV tWYpBsGoZ72ugeyrwGanGKy+gfh3DZrdmfnD4foP3WMBQA7bwl4ULEid6WvgUv36xMg5hd0YfTWnX Z+LUvQIPAPfugg==; From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 74542@debbugs.gnu.org Subject: [PATCH v2 05/16] =?UTF-8?q?packages:=20Factorize=20=E2=80=98all-p?= =?UTF-8?q?ackages=E2=80=99.?= Date: Fri, 29 Nov 2024 10:40:08 +0100 Message-ID: <8bcbbc485aa264424b29ea873fee3e2b6aa30008.1732872498.git.ludo@gnu.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Debbugs-Cc: Christopher Baines , Josselin Poiret , Ludovic Courtès , Mathieu Othacehe , Simon Tournier , Tobias Geerinckx-Rice Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74542 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages.scm (all-packages): New procedure. * etc/source-manifest.scm (all-packages): Remove. * guix/scripts/graph.scm (all-packages): Remove. * guix/scripts/refresh.scm (all-packages): Remove. * guix/scripts/weather.scm (all-packages): Remove. Change-Id: I6072952c4b877b541037ce86402cfb7744eeb0a0 --- etc/source-manifest.scm | 13 +------------ gnu/packages.scm | 20 +++++++++++++++++++- guix/scripts/graph.scm | 10 ---------- guix/scripts/refresh.scm | 10 ---------- guix/scripts/weather.scm | 15 --------------- 5 files changed, 20 insertions(+), 48 deletions(-) diff --git a/etc/source-manifest.scm b/etc/source-manifest.scm index f96a5da6f7..3e1ae07959 100644 --- a/etc/source-manifest.scm +++ b/etc/source-manifest.scm @@ -1,5 +1,5 @@ ;;; GNU Guix --- Functional package management for GNU -;;; Copyright © 2021 Ludovic Courtès +;;; Copyright © 2021, 2024 Ludovic Courtès ;;; ;;; This file is part of GNU Guix. ;;; @@ -25,17 +25,6 @@ (guix packages) (guix profiles) (gnu packages)) -(define (all-packages) - "Return the list of all the packages, public or private, omitting only -superseded packages." - (fold-packages (lambda (package lst) - (match (package-replacement package) - (#f (cons package lst)) - (replacement - (append (list replacement package) lst)))) - '() - #:select? (negate package-superseded))) - (define (upstream-origin source) "Return SOURCE without any patches or snippet." (origin (inherit source) diff --git a/gnu/packages.scm b/gnu/packages.scm index 80c22d1d7f..1af3b8d440 100644 --- a/gnu/packages.scm +++ b/gnu/packages.scm @@ -1,5 +1,5 @@ ;;; GNU Guix --- Functional package management for GNU -;;; Copyright © 2012-2020, 2022-2023 Ludovic Courtès +;;; Copyright © 2012-2020, 2022-2024 Ludovic Courtès ;;; Copyright © 2013 Mark H Weaver ;;; Copyright © 2014 Eric Bavier ;;; Copyright © 2016, 2017 Alex Kost @@ -56,6 +56,7 @@ (define-module (gnu packages) cache-is-authoritative? fold-packages + all-packages fold-available-packages find-newest-available-packages @@ -253,6 +254,23 @@ (define* (fold-packages proc init init modules)) +(define all-packages + (mlambda () + "Return the list of all public packages, including replacements and hidden +packages, excluding superseded packages." + (delete-duplicates + (fold-packages (lambda (package result) + (match (package-replacement package) + ((? package? replacement) + (cons* replacement package result)) + (#f + (cons package result)))) + '() + + ;; Dismiss deprecated packages but keep hidden packages. + #:select? (negate package-superseded)) + eq?))) + (define %package-cache-file ;; Location of the package cache. "/lib/guix/package.cache") diff --git a/guix/scripts/graph.scm b/guix/scripts/graph.scm index 6740858d8b..935721edea 100644 --- a/guix/scripts/graph.scm +++ b/guix/scripts/graph.scm @@ -119,16 +119,6 @@ (define %package-node-type ;;; Reverse package DAG. ;;; -(define (all-packages) ;XXX: duplicated from (guix scripts refresh) - "Return the list of all the distro's packages." - (fold-packages (lambda (package result) - ;; Ignore deprecated packages. - (if (package-superseded package) - result - (cons package result))) - '() - #:select? (const #t))) ;include hidden packages - (define %reverse-package-node-type ;; For this node type we first need to compute the list of packages and the ;; list of back-edges. Since we want to do it only once, we use the diff --git a/guix/scripts/refresh.scm b/guix/scripts/refresh.scm index ec7d38c22a..8c72d0c545 100644 --- a/guix/scripts/refresh.scm +++ b/guix/scripts/refresh.scm @@ -455,16 +455,6 @@ (define* (check-for-package-update update-spec updaters #:key warn?) ;;; Dependents. ;;; -(define (all-packages) - "Return the list of all the distro's packages." - (fold-packages (lambda (package result) - ;; Ignore deprecated packages. - (if (package-superseded package) - result - (cons package result))) - '() - #:select? (const #t))) ;include hidden packages - (define (list-dependents packages) "List all the things that would need to be rebuilt if PACKAGES are changed." ;; Using %BAG-NODE-TYPE is more accurate than using %PACKAGE-NODE-TYPE diff --git a/guix/scripts/weather.scm b/guix/scripts/weather.scm index 08a1b22a74..29432fd923 100644 --- a/guix/scripts/weather.scm +++ b/guix/scripts/weather.scm @@ -55,21 +55,6 @@ (define-module (guix scripts weather) #:use-module (ice-9 vlist) #:export (guix-weather)) -(define (all-packages) - "Return the list of public packages we are going to query." - (delete-duplicates - (fold-packages (lambda (package result) - (match (package-replacement package) - ((? package? replacement) - (cons* replacement package result)) - (#f - (cons package result)))) - '() - - ;; Dismiss deprecated packages but keep hidden packages. - #:select? (negate package-superseded)) - eq?)) - (define (call-with-progress-reporter reporter proc) "This is a variant of 'call-with-progress-reporter' that works with monadic scope." -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 29 04:41:09 2024 Received: (at 74542) by debbugs.gnu.org; 29 Nov 2024 09:41:09 +0000 Received: from localhost ([127.0.0.1]:41049 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGxUq-0005sV-1K for submit@debbugs.gnu.org; Fri, 29 Nov 2024 04:41:08 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39614) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGxUd-0005pf-C2 for 74542@debbugs.gnu.org; Fri, 29 Nov 2024 04:40:57 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tGxUU-0003mL-Dj; Fri, 29 Nov 2024 04:40:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=gUsH8apnherpQShGuu1InrWaP5q5OLB8UdwDPUoWXik=; b=IfasRkxqORU2gJgZQVA3 OkPnqfE3lh240KeBTru5nZD1Frs/G2Ofy6Ihx5fzlpBbsGGYqCq2xLcK/FSd9m5og5qOsG5wNJDUG 3jeRRAfU0SUL9Zjylhu0E7HJzE+9rks97wAYC27v8pqkIW2fFNnf/0lRt937/1mg4EUrK9Yw3MxKI YxOyN6yS58NY54iuzUovmClOlt0RAQf32UxWmmMpZ2cVQjYMiyMI2R6JgNap8ETU7Jc/qydQnYnpg dyhZ87g4VBWdceEgwQ6mPcUjUEXn2RL8gY7lxOB8bznSnxrx3l92gt6hadMDnhPsy88SuZcXvbCyb LaKKdMfDiWiD6g==; From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 74542@debbugs.gnu.org Subject: [PATCH v2 02/16] =?UTF-8?q?gnu-maintenance:=20=E2=80=98import-htm?= =?UTF-8?q?l-release=E2=80=99=20doesn=E2=80=99t=20abort=20upon=20HTTP=2040?= =?UTF-8?q?4.?= Date: Fri, 29 Nov 2024 10:40:05 +0100 Message-ID: X-Mailer: git-send-email 2.46.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Debbugs-Cc: Christopher Baines , Josselin Poiret , Ludovic Courtès , Mathieu Othacehe , Simon Tournier , Tobias Geerinckx-Rice Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74542 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Previously, updaters using ‘import-html-release’ would throw to 'quit when the HTML page isn’t found, aborting the whole process: $ guix refresh coreutils libchop guix refresh: error: https://de.freedif.org/savannah//libchop/: HTTP download failed: 404 ("Not Found") * guix/gnu-maintenance.scm (url->links): Guard against ‘http-get-error?’ and return the empty list when it is raised. Change-Id: I419ff96ddb424aa8c74d6bab3d66a5e85355c3dc --- guix/gnu-maintenance.scm | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/guix/gnu-maintenance.scm b/guix/gnu-maintenance.scm index 881e941fbf..f34dcfc13f 100644 --- a/guix/gnu-maintenance.scm +++ b/guix/gnu-maintenance.scm @@ -1,5 +1,5 @@ ;;; GNU Guix --- Functional package management for GNU -;;; Copyright © 2010-2023 Ludovic Courtès +;;; Copyright © 2010-2024 Ludovic Courtès ;;; Copyright © 2012, 2013 Nikita Karetnikov ;;; Copyright © 2021 Simon Tournier ;;; Copyright © 2022 Maxime Devos @@ -30,6 +30,7 @@ (define-module (guix gnu-maintenance) #:use-module (srfi srfi-2) #:use-module (srfi srfi-11) #:use-module (srfi srfi-26) + #:use-module (srfi srfi-34) #:use-module (rnrs io ports) #:use-module ((guix http-client) #:hide (open-socket-for-uri)) ;; not required in many cases, so autoloaded to reduce start-up costs. @@ -496,11 +497,16 @@ (define (html-links sxml) (define (url->links url) "Return the unique links on the HTML page accessible at URL." - (let* ((uri (string->uri url)) - (port (http-fetch/cached uri #:ttl 3600)) - (sxml (html->sxml port))) - (close-port port) - (delete-duplicates (html-links sxml)))) + (guard (c ((http-get-error? c) + (warning (G_ "failed to download '~a': ~a (~a)~%") + url (http-get-error-code c) + (http-get-error-reason c)) + '())) + (let* ((uri (string->uri url)) + (port (http-fetch/cached uri #:ttl 3600)) + (sxml (html->sxml port))) + (close-port port) + (delete-duplicates (html-links sxml))))) (define (canonicalize-url url base-url) "Make relative URL absolute, by appending URL to BASE-URL as required. If -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 29 04:41:22 2024 Received: (at 74542) by debbugs.gnu.org; 29 Nov 2024 09:41:23 +0000 Received: from localhost ([127.0.0.1]:41059 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGxV4-0005tU-3L for submit@debbugs.gnu.org; Fri, 29 Nov 2024 04:41:22 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39598) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGxUd-0005pe-CN for 74542@debbugs.gnu.org; Fri, 29 Nov 2024 04:40:57 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tGxUV-0003nW-6S; Fri, 29 Nov 2024 04:40:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=kl+o3JDOVclar88DBNdgoen9lS8pCWyJIdQt9A5uZV8=; b=B4HEUDS2OjWeEVhJEQpe KUyTaWVSKSao2OwBJ/bu3DmfCPlLj0ardSrG9DezS627+erUFphvEzs/9lFBUrgWTDR2RIDa7hwID HekNRzAncJdvzJ6Qwhp/DNVJS5k95E75XvNUWNu67VtfvAWGY6xN3m4lE2ePjZOJd7zysCVCN2L1I v4OziR5+tvpkK7f2VyV+AIQqPvEOBXXj9P5h92QBh+tNJyQce/746CfLky3casWxm3E2fGdWojdM/ 6ntHAQ7UIfNwtjR3Jx2QcUu97etVf385qd0W0q4jXF2RSmbBgMPunahQsM5TH8qszlzopZXhun4MA 1JwHMZtlIs4lCQ==; From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 74542@debbugs.gnu.org Subject: [PATCH v2 03/16] gnu-maintenance: Savannah/Xorg updaters no longer abort on network errors. Date: Fri, 29 Nov 2024 10:40:06 +0100 Message-ID: <1914331d67523535127655bb69cc9bb281a776a6.1732872498.git.ludo@gnu.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Debbugs-Cc: Christopher Baines , Josselin Poiret , Ludovic Courtès , Mathieu Othacehe , Simon Tournier , Tobias Geerinckx-Rice Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74542 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Previously these updaters would fail upon networking error, causing the whole process to abort: $ guix refresh coreutils libgcrypt guix refresh: error: connect*: Connection refused * guix/gnu-maintenance.scm (import-release*, import-xorg-release): Wrap in ‘false-if-networking-error’. Change-Id: I8d309bf8662e2d46460585b4a1b7da0a4f2e8907 --- guix/gnu-maintenance.scm | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/guix/gnu-maintenance.scm b/guix/gnu-maintenance.scm index f34dcfc13f..866b960a4a 100644 --- a/guix/gnu-maintenance.scm +++ b/guix/gnu-maintenance.scm @@ -469,10 +469,12 @@ (define* (import-release* package #:key (version #f)) \"emacs-auctex\", for instance.)" (let-values (((server directory) (ftp-server/directory package))) - (false-if-ftp-error (import-release (package-upstream-name package) - #:version version - #:server server - #:directory directory)))) + (false-if-networking-error + (false-if-ftp-error + (import-release (package-upstream-name package) + #:version version + #:server server + #:directory directory))))) ;;; @@ -913,13 +915,14 @@ (define* (import-xorg-release package #:key (version #f)) "Return the latest release of PACKAGE. Optionally include a VERSION string to fetch a specific version." (let ((uri (string->uri (origin-uri (package-source package))))) - (false-if-ftp-error - (import-ftp-release - (package-name package) - #:version version - #:server "ftp.freedesktop.org" - #:directory - (string-append "/pub/xorg/" (dirname (uri-path uri))))))) + (false-if-networking-error + (false-if-ftp-error + (import-ftp-release + (package-name package) + #:version version + #:server "ftp.freedesktop.org" + #:directory + (string-append "/pub/xorg/" (dirname (uri-path uri)))))))) (define* (import-kernel.org-release package #:key (version #f)) "Return the latest release of PACKAGE, a Linux kernel package. -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 29 04:41:23 2024 Received: (at 74542) by debbugs.gnu.org; 29 Nov 2024 09:41:23 +0000 Received: from localhost ([127.0.0.1]:41061 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGxV5-0005tb-0X for submit@debbugs.gnu.org; Fri, 29 Nov 2024 04:41:23 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39618) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGxUd-0005pg-CO for 74542@debbugs.gnu.org; Fri, 29 Nov 2024 04:40:59 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tGxUX-0003ng-O8; Fri, 29 Nov 2024 04:40:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=wpkNwIGCGGWoAeqRETs3oOnv5KSmbUnOmdNRr9ed9r0=; b=TAUZuPjB9+tyExbQoOp/ u1pxfuqEQMUDF8N89Cl9oTOcC/kvAr/VSlX7AwOjURrYCtnjV9Mw+KZ1wbm+6F6zqT33JzjNF5XUF 4GoYP26DgvQDuQVrVzmMqLs/1BhoGsS/j1W3QRhXgoqdpPg2EBVEQr2Tgpcy8WzS7Qe1erqjhCeI2 gaQNNLl7DixgapKNEXS36tdO+vfGn0NIlG5uUjaRbQ2awWPCdYM9HrbwrLJuDbMIau5ecAOWK2tpz kdm0DaXhHNqSnLObQ8aOe0AXsIVny1ifzF2e7No38+Jy1aEXxP5jUkIpxnFEy5wrHa8BJO3II2DBU bcDz2a4ffPcsKg==; From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 74542@debbugs.gnu.org Subject: [PATCH v2 06/16] =?UTF-8?q?guix=20build:=20Add=20=E2=80=98--depen?= =?UTF-8?q?dents=E2=80=99.?= Date: Fri, 29 Nov 2024 10:40:09 +0100 Message-ID: <24a98350fd3f836dae11621065fa4040cbd4b227.1732872498.git.ludo@gnu.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Debbugs-Cc: Christopher Baines , Josselin Poiret , Ludovic Courtès , Mathieu Othacehe , Maxim Cournoyer , Simon Tournier , Tobias Geerinckx-Rice Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74542 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * guix/scripts/build.scm (show-help, %options): Add ‘--dependents’. (dependents): New procedure. (options->things-to-build): Add ‘store’ parameter; honor ‘dependents’ option. [for-type]: Handle ‘dependents’ type. (options->derivations): Update call to ‘options->things-to-build’. * tests/guix-build.sh: Add test. * doc/guix.texi (Additional Build Options): Document ‘--dependents’. (Invoking guix refresh): Cross-reference it. * doc/contributing.texi (Submitting Patches): Mention it. Change-Id: I00b6d5831e1f1d35dc8b84a82605391d5a8f417c --- doc/contributing.texi | 4 ++- doc/guix.texi | 27 ++++++++++++++++++++ guix/scripts/build.scm | 56 ++++++++++++++++++++++++++++++++++++++++-- tests/guix-build.sh | 6 +++++ 4 files changed, 90 insertions(+), 3 deletions(-) diff --git a/doc/contributing.texi b/doc/contributing.texi index b063169189..5a778466d7 100644 --- a/doc/contributing.texi +++ b/doc/contributing.texi @@ -1914,7 +1914,9 @@ Submitting Patches @item Make sure the package builds on your platform, using @command{guix build -@var{package}}. +@var{package}}. Also build at least its direct dependents with +@command{guix build --dependents=1 @var{package}} +(@pxref{build-dependents, @command{guix build}}). @item We recommend you also try building the package on other supported diff --git a/doc/guix.texi b/doc/guix.texi index a9d0d044ae..219f19f2d6 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -13639,6 +13639,31 @@ Additional Build Options natively. @end quotation +@cindex dependents of a package, building them +@cindex building the dependents of a package +@anchor{build-dependents} +@item --dependents[=@var{depth}] +@itemx -P [@var{depth}] +Build the dependents of the following package. By default, build all +the direct and indirect dependents; when @var{depth} is provided, limit +to dependents at that distance: 1 for direct dependents, 2 for +dependents of dependents, and so on. + +For example, the command below builds @emph{all} the dependents of libgit2: + +@example +guix build --dependents libgit2 +@end example + +To build all the packages that directly depend on NumPy, run: + +@example +guix build -P1 python-numpy +@end example + +The list of dependents is computed in the same way as with @command{guix +refresh --list-dependent} (@pxref{Invoking guix refresh}). + @item --source @itemx -S Build the source derivations of the packages, rather than the packages @@ -15142,6 +15167,8 @@ Invoking guix refresh @command{guix graph}}, for information on how to visualize the list of dependents of a package. +@xref{build-dependents, @command{guix build --dependents}}, for a +convenient way to build all the dependents of a package. @end table Be aware that the @option{--list-dependent} option only diff --git a/guix/scripts/build.scm b/guix/scripts/build.scm index e8384c8d2d..5c93dc78f8 100644 --- a/guix/scripts/build.scm +++ b/guix/scripts/build.scm @@ -33,6 +33,9 @@ (define-module (guix scripts build) #:use-module (guix profiles) #:use-module (guix diagnostics) #:autoload (guix http-client) (http-fetch http-get-error?) + #:autoload (guix scripts graph) (%bag-node-type) + #:autoload (guix graph) (node-back-edges) + #:autoload (guix sets) (setq set-contains? set-insert) #:use-module (ice-9 format) #:use-module (ice-9 match) #:use-module (srfi srfi-1) @@ -440,6 +443,9 @@ (define (show-help) (display (G_ " -D, --development build the inputs of the following package")) (display (G_ " + -P, --dependents[=N] build dependents of the following package, up to + depth N")) + (display (G_ " -S, --source build the packages' source derivations")) (display (G_ " --sources[=TYPE] build source derivations; TYPE may optionally be one @@ -527,6 +533,11 @@ (define %options (option '(#\D "development") #f #f (lambda (opt name arg result) (alist-cons 'development? #t result))) + (option '(#\P "dependents") #f #t + (lambda (opt name arg result) + (alist-cons 'dependents + (or (and=> arg string->number*) +inf.0) + result))) (option '(#\n "dry-run") #f #f (lambda (opt name arg result) (alist-cons 'dry-run? #t result))) @@ -551,7 +562,39 @@ (define %options %standard-cross-build-options %standard-native-build-options))) -(define (options->things-to-build opts) +(define (dependents store packages max-depth) + "List all the things that would need to be rebuilt if PACKAGES are changed." + ;; Using %BAG-NODE-TYPE is more accurate than using %PACKAGE-NODE-TYPE + ;; because it includes implicit dependencies. + (define (get-dependents packages edges) + (let loop ((packages packages) + (result '()) + (depth 0) + (visited (setq))) + (if (> depth max-depth) + (values result visited) + (match packages + (() + (values result visited)) + ((head . tail) + (if (set-contains? visited head) + (loop tail result depth visited) + (let ((next (edges head))) + (call-with-values + (lambda () + (loop next + (cons head result) + (+ depth 1) + (set-insert head visited))) + (lambda (result visited) + (loop tail result depth visited)))))))))) + + (with-store store + (run-with-store store + (mlet %store-monad ((edges (node-back-edges %bag-node-type (all-packages)))) + (return (get-dependents packages edges)))))) + +(define (options->things-to-build store opts) "Read the arguments from OPTS and return a list of high-level objects to build---packages, gexps, derivations, and so on." (define (validate-type x) @@ -600,6 +643,13 @@ (define-public my-package (match type ('regular (list obj)) + (('dependents . depth) + (if (package? obj) + (begin + (info (G_ "computing dependents of package ~a...~%") + (package-full-name obj)) + (dependents store (list obj) depth)) + (list obj))) ('development (if (package? obj) (map manifest-entry-item @@ -661,6 +711,8 @@ (define-public my-package result))) (('development? . #t) (loop tail 'development result)) + (('dependents . depth) + (loop tail `(dependents . ,depth) result)) (_ (loop tail type result))))))) @@ -687,7 +739,7 @@ (define (options->derivations store opts) (systems systems))) (define things-to-build - (map transform (options->things-to-build opts))) + (map transform (options->things-to-build store opts))) (define warn-if-unsupported (let ((target (assoc-ref opts 'target))) diff --git a/tests/guix-build.sh b/tests/guix-build.sh index 3637bcdeb3..8707ed32c0 100644 --- a/tests/guix-build.sh +++ b/tests/guix-build.sh @@ -196,6 +196,12 @@ test `guix build -D hello -d \ | grep -e 'glibc.*\.drv$' -e 'gcc.*\.drv$' -e 'binutils.*\.drv$' \ | wc -l` -ge 3 +# Building the dependents. +test `guix build -P1 libgit2 -P1 libssh -d \ + | grep -e 'guile-git.*\.drv$' -e 'guile-ssh.*\.drv$' \ + -e 'libgit2.*\.drv$' -e 'libssh.*\.drv$' \ + | wc -l` -eq 4 + # Unbound variable in thunked field. cat > "$module_dir/foo.scm" <) id 1tGxV5-0005tf-LF for submit@debbugs.gnu.org; Fri, 29 Nov 2024 04:41:23 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39624) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGxUi-0005qC-M3 for 74542@debbugs.gnu.org; Fri, 29 Nov 2024 04:41:01 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tGxUd-0003oy-6T; Fri, 29 Nov 2024 04:40:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=acgj0glEt7hanHQUf4oPk2R5nSiXvs7JtfKGwt4jdQ8=; b=ruJNEYJ3zom1vLOBfyvO k+PPTSRwaMjluKC+ZR3U0yqBAl9qFcqkJ47DUWt9dHX8K8pskPGS49dqtCcXJkkWLZp6onPcX1peX XoyHU38GkFEi568HZapb4dER6CEqa+q2HS5usaU903mqnThkPX+A87A2j3gvyuZtJxB2TYK/4Ba59 ESQAouBnZGT5kFNzGfJRnbj7F+hCEEfqpYIm8lAcr7tUtPkcfEd7//SSl2rU4SoBKdtjMsJ9vb9v0 OCu009Tp8BXw40+q9yIVwUhEi8uVqcf+/dgTZUnttoOqICGRUTJuQRBFQ5ltqhoE90/rLeAf16WNR TYQR34ixbutVwQ==; From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 74542@debbugs.gnu.org Subject: [PATCH v2 07/16] import: gnome: Keep going upon HTTP errors. Date: Fri, 29 Nov 2024 10:40:10 +0100 Message-ID: <0871a73df814857b3af173a154cbfbc30ba40aef.1732872499.git.ludo@gnu.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74542 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * guix/import/gnome.scm (import-gnome-release): Do not re-raise condition C, emit a warning instead. Change-Id: I9a7c337a17d1f7ed4677398e7b0f383befca7d74 --- guix/import/gnome.scm | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/guix/import/gnome.scm b/guix/import/gnome.scm index 054ae44f7a..3ba8ae02e5 100644 --- a/guix/import/gnome.scm +++ b/guix/import/gnome.scm @@ -1,5 +1,5 @@ ;;; GNU Guix --- Functional package management for GNU -;;; Copyright © 2017, 2019, 2021 Ludovic Courtès +;;; Copyright © 2017, 2019, 2021, 2024 Ludovic Courtès ;;; Copyright © 2022 Maxim Cournoyer ;;; Copyright © 2022 Hartmut Goebel ;;; @@ -23,6 +23,8 @@ (define-module (guix import gnome) #:use-module (guix utils) #:use-module (guix packages) #:use-module (guix http-client) + #:use-module (guix diagnostics) + #:use-module (guix i18n) #:use-module (json) #:use-module (srfi srfi-1) #:use-module (srfi srfi-34) @@ -111,9 +113,12 @@ (define* (import-gnome-release package #:key (version #f)) releases)) (guard (c ((http-get-error? c) - (if (= 404 (http-get-error-code c)) - #f - (raise c)))) + (unless (= 404 (http-get-error-code c)) + (warning (G_ "failed to download from '~a': ~a (~s)~%") + (uri->string (http-get-error-uri c)) + (http-get-error-code c) + (http-get-error-reason c))) + #f)) (let* ((port (http-fetch/cached (string->uri (string-append "https://ftp.gnome.org/pub/gnome/sources/" -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 29 04:41:25 2024 Received: (at 74542) by debbugs.gnu.org; 29 Nov 2024 09:41:25 +0000 Received: from localhost ([127.0.0.1]:41067 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGxV6-0005tt-Fr for submit@debbugs.gnu.org; Fri, 29 Nov 2024 04:41:24 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39630) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGxUk-0005qb-Kh for 74542@debbugs.gnu.org; Fri, 29 Nov 2024 04:41:04 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tGxUe-0003p9-Lm; Fri, 29 Nov 2024 04:40:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=s3NlCK5g4EoLnXqtNocOLhHNwSIxIbo8INXA2YVICF4=; b=ZECs73Tm8qSsSWgbqG3Q HBDbf0lVe+yFXbs21kpHEI8YH790I/+CAPFdHgnhhzIJPHkAV6YGdyPzu+dbNsA8kxbiKlfWT1LQr ivVtWZVkiXXLwW4MPEnVNY+WqLzq5Lp0wXvZSRAh6vlTqa8D5lthNizsWump4acynJF5jZJyv8cJH mum4P6PK7nW0xuFfGmdb+QnpObJmnxNnrGFGDIElibgTWexB/I9zyxOguUuL3aDh5ZV2ZkRMoeFPE vJp3dhnY9b6NmddfPsuT3MN9/RJmDLmGTFF16RIcfFOQyHq50IYAd5ThqGV8zUr9WbQ3WKYuR+ScV UQiSfctbhRDtPQ==; From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 74542@debbugs.gnu.org Subject: [PATCH v2 08/16] =?UTF-8?q?gnu-maintenance:=20=E2=80=98gnu-ftp?= =?UTF-8?q?=E2=80=99=20updater=20excludes=20GnuPG-hosted=20packages.?= Date: Fri, 29 Nov 2024 10:40:11 +0100 Message-ID: <226f0e915e1aab981ca6ffabe0216a564531fba0.1732872499.git.ludo@gnu.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Debbugs-Cc: Christopher Baines , Josselin Poiret , Ludovic Courtès , Mathieu Othacehe , Simon Tournier , Tobias Geerinckx-Rice Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74542 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Since ftp://ftp.gnupg.org no longer exists, another updater should be used for packages with code fetched from mirror://gnupg. * guix/gnu-maintenance.scm (gnupg-hosted?): New procedure. (%gnu-ftp-updater): Exclude packages that match ‘gnupg-hosted?’. * guix/download.scm (%mirrors): Remove ftp://ftp.gnupg.org. Change-Id: I653877ad843da60281d3a234acc85743bee64856 --- guix/download.scm | 3 +-- guix/gnu-maintenance.scm | 6 +++++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/guix/download.scm b/guix/download.scm index e37c2195ee..d88ad0ee44 100644 --- a/guix/download.scm +++ b/guix/download.scm @@ -78,8 +78,7 @@ (define %mirrors "ftp://mirrors.dotsrc.org/gcrypt/" "ftp://ftp.heanet.ie/mirrors/ftp.gnupg.org/gcrypt/" "ftp://ftp.mirrorservice.org/sites/ftp.gnupg.org/gcrypt/" - "ftp://ftp.ring.gr.jp/pub/net/gnupg/" - "ftp://ftp.gnupg.org/gcrypt/") + "ftp://ftp.ring.gr.jp/pub/net/gnupg/") (gnome "https://download.gnome.org/" "http://ftp.gnome.org/pub/GNOME/") diff --git a/guix/gnu-maintenance.scm b/guix/gnu-maintenance.scm index 866b960a4a..b612b11c00 100644 --- a/guix/gnu-maintenance.scm +++ b/guix/gnu-maintenance.scm @@ -1025,15 +1025,19 @@ (define %gnu-updater (false-if-networking-error (gnu-hosted? package)))) (import import-gnu-release))) +(define gnupg-hosted? + (url-prefix-predicate "mirror://gnupg/")) + (define %gnu-ftp-updater ;; This is for GNU packages taken from alternate locations, such as - ;; alpha.gnu.org, ftp.gnupg.org, etc. It is obsolescent. + ;; alpha.gnu.org (ftp.gnupg.org is no longer available). It is obsolescent. (upstream-updater (name 'gnu-ftp) (description "Updater for GNU packages only available via FTP") (pred (lambda (package) (false-if-networking-error (and (not (gnu-hosted? package)) + (not (gnupg-hosted? package)) (pure-gnu-package? package))))) (import import-release*))) -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 29 04:41:25 2024 Received: (at 74542) by debbugs.gnu.org; 29 Nov 2024 09:41:25 +0000 Received: from localhost ([127.0.0.1]:41069 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGxV7-0005u1-1I for submit@debbugs.gnu.org; Fri, 29 Nov 2024 04:41:25 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39634) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGxUl-0005qd-QO for 74542@debbugs.gnu.org; Fri, 29 Nov 2024 04:41:05 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tGxUg-0003pO-DP; Fri, 29 Nov 2024 04:40:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=IvFL757UmbVE9HTsId8rEfePRLq4bgwscx0vxswRNgs=; b=dKPGSFdPQgCYxegoHkVM WGsOmFwvH3i+urXo0CpdriI3bNDkppGDMvmcgiLSrimv07ffSXgjxybZ7mNn2mf31nGxyMrD4q/ke TzGm1+s2fo5sx44Y7EdcG2E7IneqOCdIgT+ZJs1J8I3wZL5XeN/lC/9CLTkKgBBWiIDaa1exRpp3J IrXj2ec8RCNKjt5dYfzJnINdblgXcivNG0K5NjaXDtJtqcunQ091Xl0blcmccSzRwl+4aNh5xmSaz Txkecn5G3/qdQ9JMepb8jMnMtBYPozzN+MgkBMtdss3biH+EHeI96TgE2Fc6ULNrk6ORXiVBIhcB9 /xygGsJjb25S5g==; From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 74542@debbugs.gnu.org Subject: [PATCH v2 09/16] gnu: Update updater properties for GnuPG-related packages. Date: Fri, 29 Nov 2024 10:40:12 +0100 Message-ID: <6aa0b39d916ffe88b9ed4139c9a344079afe37f1.1732872499.git.ludo@gnu.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74542 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/gnupg.scm (libgpg-error)[properties]: Remove. (libgcrypt)[properties]: Remove. (libassuan)[properties]: Remove. (libksba)[properties]: Remove. (npth)[properties]: Remove. (gnupg)[properties]: Remove. (gpgme)[properties]: Remove. (pinentry-tty)[properties]: Change for ‘generic-html’. (gpa)[properties]: Remove. Change-Id: I1eb9d6ad5bb3ecbfbef3d44dbae281a3de7ebac7 --- gnu/packages/gnupg.scm | 40 ++++++++++++---------------------------- 1 file changed, 12 insertions(+), 28 deletions(-) diff --git a/gnu/packages/gnupg.scm b/gnu/packages/gnupg.scm index 2e97c2244a..3f55ccaf5b 100644 --- a/gnu/packages/gnupg.scm +++ b/gnu/packages/gnupg.scm @@ -1,5 +1,5 @@ ;;; GNU Guix --- Functional package management for GNU -;;; Copyright © 2012-2021, 2023 Ludovic Courtès +;;; Copyright © 2012-2021, 2023, 2024 Ludovic Courtès ;;; Copyright © 2013, 2015, 2018 Andreas Enge ;;; Copyright © 2014, 2018 Eric Bavier ;;; Copyright © 2014, 2015, 2016, 2020 Mark H Weaver @@ -160,9 +160,7 @@ (define-public libgpg-error for all GnuPG components. Among these are GPG, GPGSM, GPGME, GPG-Agent, libgcrypt, Libksba, DirMngr, Pinentry, SmartCard Daemon and possibly more in the future.") - (license license:lgpl2.0+) - (properties '((ftp-server . "ftp.gnupg.org") - (ftp-directory . "/gcrypt/libgpg-error"))))) + (license license:lgpl2.0+))) (define-public libgcrypt (package @@ -217,9 +215,7 @@ (define-public libgcrypt standard cryptographic building blocks such as symmetric ciphers, hash algorithms, public key algorithms, large integer functions and random number generation.") - (license license:lgpl2.0+) - (properties '((ftp-server . "ftp.gnupg.org") - (ftp-directory . "/gcrypt/libgcrypt"))))) + (license license:lgpl2.0+))) (define-public libassuan (package @@ -250,9 +246,7 @@ (define-public libassuan protocol. This protocol is used for IPC between most newer GnuPG components. Both, server and client side functions are provided.") - (license license:lgpl2.0+) - (properties '((ftp-server . "ftp.gnupg.org") - (ftp-directory . "/gcrypt/libassuan"))))) + (license license:lgpl2.0+))) (define-public libksba (package @@ -283,9 +277,7 @@ (define-public libksba "KSBA (pronounced Kasbah) is a library to make X.509 certificates as well as the CMS easily accessible by other applications. Both specifications are building blocks of S/MIME and TLS.") - (license license:gpl3+) - (properties '((ftp-server . "ftp.gnupg.org") - (ftp-directory . "/gcrypt/libksba"))))) + (license license:gpl3+))) (define-public npth (package @@ -307,9 +299,7 @@ (define-public npth In contrast to GNU Pth is is based on the system's standard threads implementation. This allows the use of libraries which are not compatible to GNU Pth.") - (license (list license:lgpl3+ license:gpl2+)) ; dual license - (properties '((ftp-server . "ftp.gnupg.org") - (ftp-directory . "/gcrypt/npth"))))) + (license (list license:lgpl3+ license:gpl2+)))) ;dual license (define-public gnupg (package @@ -404,9 +394,7 @@ (define-public gnupg servers. It includes several libraries: libassuan (IPC between GnuPG components), libgpg-error (centralized GnuPG error values), and libskba (working with X.509 certificates and CMS data).") - (license license:gpl3+) - (properties '((ftp-server . "ftp.gnupg.org") - (ftp-directory . "/gcrypt/gnupg"))))) + (license license:gpl3+))) (define-public gnupg-1 (package (inherit gnupg) @@ -463,9 +451,7 @@ (define-public gpgme programming task, it is suggested that all software should try to use GPGME instead. This way bug fixes or improvements can be done at a central place and every application benefits from this.") - (license license:lgpl2.1+) - (properties '((ftp-server . "ftp.gnupg.org") - (ftp-directory . "/gcrypt/gpgme"))))) + (license license:lgpl2.1+))) (define-public gpgme-1.23 (hidden-package @@ -886,9 +872,9 @@ (define-public pinentry-tty "Pinentry provides a console that allows users to enter a passphrase when @code{gpg} is run and needs it.") (license license:gpl2+) - (properties '((ftp-server . "ftp.gnupg.org") - (ftp-directory . "/gcrypt/pinentry") - (upstream-name . "pinentry"))))) + (properties + '((release-monitoring-url . "https://gnupg.org/ftp/gcrypt/pinentry/") + (upstream-name . "pinentry"))))) (define-public pinentry-emacs (package @@ -1134,9 +1120,7 @@ (define-public gpa "GPA, the GNU Privacy Assistant, is a graphical user interface for @uref{https://gnupg.org, GnuPG}. It can be used to encrypt, decrypt, and sign files, to verify signatures, and to manage the private and public keys.") - (license license:gpl3+) - (properties '((ftp-server . "ftp.gnupg.org") - (ftp-directory . "/gcrypt/gpa"))))) + (license license:gpl3+))) (define-public parcimonie (package -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 29 04:41:26 2024 Received: (at 74542) by debbugs.gnu.org; 29 Nov 2024 09:41:27 +0000 Received: from localhost ([127.0.0.1]:41071 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGxV7-0005u9-L2 for submit@debbugs.gnu.org; Fri, 29 Nov 2024 04:41:26 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39646) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGxUm-0005qg-Nj for 74542@debbugs.gnu.org; Fri, 29 Nov 2024 04:41:05 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tGxUh-0003pb-HK; Fri, 29 Nov 2024 04:40:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=4TAzAAZq0x4/0qBRuvoa5j7K7bF3OVaHBtZaUjJI/o0=; b=OKiAUfj/amRne2ZXn9Si xIublre/AiMIXdaDCeIRJFjhnub4BwmUyrsVzigkw75UuWeELMCmPIfj0g+z7/ucY0B+Gjxs5oQI5 qq0IHi9Wh6rqPqo1jfSgzddZdn+Z+QzW2gv5Oh6Ml9gfG+rg2Wp9PlgiHzILPuuDgMNYLiXWdzuCx yfE414KBI8+TtON7mWlfKxLqnIDawtE1r/7i6gSgoTUID6e3maf8uucfzgrpTYjlM12qldpaJ423i hxdbTOVlfh+a/zpyMRypByFKiTBaeVBRUpia+I1iB2cICfGxrau/RQ4mVJYarkQ6GRTOZZY21oR6y 6yLUV2feBqopqQ==; From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 74542@debbugs.gnu.org Subject: [PATCH v2 10/16] gnu: gnutls: Change release monitoring URL. Date: Fri, 29 Nov 2024 10:40:13 +0100 Message-ID: X-Mailer: git-send-email 2.46.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74542 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/tls.scm (gnutls)[properties]: Change release monitoring URL. Add ‘upstream-name’. Change-Id: If6ee941246b130914ddf7ca11c074a9547b9d739 --- gnu/packages/tls.scm | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/gnu/packages/tls.scm b/gnu/packages/tls.scm index 43806e24da..06f4098f5a 100644 --- a/gnu/packages/tls.scm +++ b/gnu/packages/tls.scm @@ -300,7 +300,11 @@ (define-public gnutls required structures.") (license license:lgpl2.1+) (properties - '((release-monitoring-url . "https://gnutls.org/download.html"))))) + ;; Since gnutls.org doesn't have a page with a direct link to the + ;; tarball, defer to fellow LFS hackers. + '((release-monitoring-url + . "https://www.linuxfromscratch.org/blfs/view/svn/postlfs/gnutls.html") + (upstream-name . "gnutls"))))) (define-deprecated/public-alias gnutls-latest gnutls) -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 29 04:41:27 2024 Received: (at 74542) by debbugs.gnu.org; 29 Nov 2024 09:41:27 +0000 Received: from localhost ([127.0.0.1]:41073 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGxV8-0005uJ-Ub for submit@debbugs.gnu.org; Fri, 29 Nov 2024 04:41:27 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57462) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGxUo-0005qq-0a for 74542@debbugs.gnu.org; Fri, 29 Nov 2024 04:41:06 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tGxUi-0003qN-QH; Fri, 29 Nov 2024 04:41:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=e4xQsubbF6EDTYPjiV9X5Yrd6s8LKe17+AnxTm9OLp4=; b=K5GDm1nKiCJPWsgSK1ul 7odh5XadkdKo6V4Mam63eUVyqlsvlp9ZPSPVfQGxCBf54TWQaIjIBQMr+T3aRc6ww+gWASfcOQDE3 FTKmemHMDD47i4TsM4NrR9PxvH/3JtABr3ZMX289yTsby6zetUQW2ZUE44uxKu+kOnBzt6PyweVDB bhiw1c8iimCzeC8xyKx4zQD1LmBsAANctJKn1R85WxLt1V1UbOJgKZG+Pabj3idpFYfGEG0UP8zR0 ovMoLo5eOmJ44vbt7M0Ulvolxs7NtPZnF7TzjogyV6wIS+EG0S0ZCDKyiti8d+/puDzR75+K3+ZZv eCaJgFqHP5FNqQ==; From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 74542@debbugs.gnu.org Subject: [PATCH v2 11/16] =?UTF-8?q?gnu:=20git-minimal:=20Add=20=E2=80=98u?= =?UTF-8?q?pstream-name=E2=80=99=20property.?= Date: Fri, 29 Nov 2024 10:40:14 +0100 Message-ID: <91fedb088247c7f336e6e65fa7e9d9c114a09f52.1732872499.git.ludo@gnu.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74542 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/version-control.scm (git-minimal)[properties]: Add ‘upstream-name’. Change-Id: I2d2516003b7f686852a3531859d06ca7f4e4820d --- gnu/packages/version-control.scm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm index c892a83a98..936d511cb3 100644 --- a/gnu/packages/version-control.scm +++ b/gnu/packages/version-control.scm @@ -518,7 +518,8 @@ (define-public git-minimal "CVE-2022-30949" "CVE-2022-36882" "CVE-2022-36883" - "CVE-2022-36884")))) + "CVE-2022-36884")) + (upstream-name . "git"))) (license license:gpl2) (home-page "https://git-scm.com/"))) -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 29 04:41:27 2024 Received: (at 74542) by debbugs.gnu.org; 29 Nov 2024 09:41:27 +0000 Received: from localhost ([127.0.0.1]:41075 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGxV9-0005uQ-Am for submit@debbugs.gnu.org; Fri, 29 Nov 2024 04:41:27 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57474) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGxUp-0005r9-3x for 74542@debbugs.gnu.org; Fri, 29 Nov 2024 04:41:07 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tGxUj-0003rH-Tb; Fri, 29 Nov 2024 04:41:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=daye11wnh0O2WBRGlTnRr0RWCL+zd3LG/X6f+lWkhIo=; b=dRMqrzHFyi2MCv8s97lO 0KmUJsi9G/9tyJFIfdXCWxue0AW37qDO8s8vmOdAlNAaf+FEBUvJ9F14rc4BnBWDyvDHhEw+1rjMV AbFZyW3+UBnBuwwc6bnPDgFTW7ETPJDzb8ZFJfoFRQmYzOXRrb00Pv8nhw9MQV2kB+Fp2SmZnbz4U MftlurQ91tFW1Y2BuZilB7UNl110kS58bxO28QTHD0LN1xYL6TNagjmPv+D2qUWgZTDD6TL3C6Gyn 9i2Dpl0bfqEHK0EuzJtQTXeJy5uQRsf9TppfAF4z8wzDp9mrhi8/XKNwI2i7aJhjDdfxnmYpfGInw 0bY1Q5oj8Q4l1g==; From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 74542@debbugs.gnu.org Subject: [PATCH v2 12/16] =?UTF-8?q?gnu-maintenance:=20=E2=80=98generic-ht?= =?UTF-8?q?ml=E2=80=99=20update=20honors=20.?= Date: Fri, 29 Nov 2024 10:40:15 +0100 Message-ID: <112b57b3d8cf1208f3390602dfab6932fac7c505.1732872499.git.ludo@gnu.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Debbugs-Cc: Christopher Baines , Josselin Poiret , Ludovic Courtès , Mathieu Othacehe , Simon Tournier , Tobias Geerinckx-Rice Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74542 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This fixes updates of ‘curl’: includes in its head and ignoring it would lead to incorrect download URLs. * guix/gnu-maintenance.scm (html-links): Keep track of in ‘loop’. Rewrite relative links at the end. Change-Id: I989da78df3431034c9a584f8e10cad87ae6dc920 --- guix/gnu-maintenance.scm | 41 +++++++++++++++++++++++++++------------- 1 file changed, 28 insertions(+), 13 deletions(-) diff --git a/guix/gnu-maintenance.scm b/guix/gnu-maintenance.scm index b612b11c00..ee4882326f 100644 --- a/guix/gnu-maintenance.scm +++ b/guix/gnu-maintenance.scm @@ -39,6 +39,7 @@ (define-module (guix gnu-maintenance) #:use-module (guix utils) #:use-module (guix diagnostics) #:use-module (guix i18n) + #:autoload (guix combinators) (fold2) #:use-module (guix memoization) #:use-module (guix records) #:use-module (guix upstream) @@ -483,19 +484,33 @@ (define* (import-release* package #:key (version #f)) (define (html-links sxml) "Return the list of links found in SXML, the SXML tree of an HTML page." - (let loop ((sxml sxml) - (links '())) - (match sxml - (('a ('@ attributes ...) body ...) - (match (assq 'href attributes) - (#f (fold loop links body)) - (('href url) (fold loop (cons url links) body)))) - ((tag ('@ _ ...) body ...) - (fold loop links body)) - ((tag body ...) - (fold loop links body)) - (_ - links)))) + (define-values (links base) + (let loop ((sxml sxml) + (links '()) + (base #f)) + (match sxml + (('a ('@ attributes ...) body ...) + (match (assq 'href attributes) + (#f (fold2 loop links base body)) + (('href url) (fold2 loop (cons url links) base body)))) + (('base ('@ ('href new-base))) + ;; The base against which relative URL paths must be resolved. + (values links new-base)) + ((tag ('@ _ ...) body ...) + (fold2 loop links base body)) + ((tag body ...) + (fold2 loop links base body)) + (_ + (values links base))))) + + (if base + (map (lambda (link) + (let ((uri (string->uri link))) + (if (or uri (string-prefix? "/" link)) + link + (in-vicinity base link)))) + links) + links)) (define (url->links url) "Return the unique links on the HTML page accessible at URL." -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 29 04:41:28 2024 Received: (at 74542) by debbugs.gnu.org; 29 Nov 2024 09:41:28 +0000 Received: from localhost ([127.0.0.1]:41077 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGxV9-0005uY-Pw for submit@debbugs.gnu.org; Fri, 29 Nov 2024 04:41:28 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57476) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGxUq-0005rN-3O for 74542@debbugs.gnu.org; Fri, 29 Nov 2024 04:41:08 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tGxUk-0003tg-N8; Fri, 29 Nov 2024 04:41:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=HB1jDZjF+USzml5XD8PWIalZQ2+ZvjbRkFumUMAyKv4=; b=U/huP6mwtHN+zB3VJ+P8 k33a9OvUE1B426y6uJEOloyYaHDLPpt/LyYrpGWZyyUxAzbIOZ0gFuBKdu1l/bh0xRHjYDw5ZkknV 2pEAxudoSL1j8gjXZ0F3VuMPY+4apTV9VrZ8GAjN02ABWOwHEd974hTPGusJFh5GjPELyD3sCxGxf GWzAIdrSDDgs58BoD68fN3u0+GKhGTb5XQh89w27ElTppqnDFOTjmT8aAUeWfzSDPsq+v3kC9GgSI xzX8y8oXApGMEi7e7n3Y+rdmTyKcIccvkRwJhFZmD5smTtspSh7GYhm9GjmJIKwpCfFXxIhVcCrT6 1sOsM7chFCHrzw==; From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 74542@debbugs.gnu.org Subject: [PATCH v2 13/16] =?UTF-8?q?guix=20build:=20Validate=20that=20the?= =?UTF-8?q?=20file=20passed=20to=20=E2=80=98-m=E2=80=99=20returns=20a=20ma?= =?UTF-8?q?nifest.?= Date: Fri, 29 Nov 2024 10:40:16 +0100 Message-ID: <3226de68aaff509d5e38e2344cf428cf27e68aab.1732872499.git.ludo@gnu.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Debbugs-Cc: Christopher Baines , Josselin Poiret , Ludovic Courtès , Mathieu Othacehe , Simon Tournier , Tobias Geerinckx-Rice Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74542 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * guix/scripts/build.scm (options->things-to-build)[ensure-manifest]: New procedure. Use it. Change-Id: If64c483d7079f441a296d5bd4e06e67f44cbb7bf --- guix/scripts/build.scm | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/guix/scripts/build.scm b/guix/scripts/build.scm index 5c93dc78f8..d1368f7e48 100644 --- a/guix/scripts/build.scm +++ b/guix/scripts/build.scm @@ -629,6 +629,12 @@ (define-public my-package (for-each validate-type lst) lst)) + (define (ensure-manifest x file) + (unless (manifest? x) + (raise (formatted-message (G_ "file '~a' does not return a manifest") + file))) + x) + (define system (or (assoc-ref opts 'system) (%current-system))) @@ -701,9 +707,11 @@ (define-public my-package (loop tail 'regular (append (map manifest-entry-item (manifest-entries - (load* manifest - (make-user-module '((guix profiles) - (gnu)))))) + (ensure-manifest + (load* manifest + (make-user-module '((guix profiles) + (gnu)))) + manifest))) result))) (('expression . str) (loop tail 'regular -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 29 04:41:28 2024 Received: (at 74542) by debbugs.gnu.org; 29 Nov 2024 09:41:28 +0000 Received: from localhost ([127.0.0.1]:41079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGxVA-0005uf-9u for submit@debbugs.gnu.org; Fri, 29 Nov 2024 04:41:28 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57492) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGxUq-0005rR-Nf for 74542@debbugs.gnu.org; Fri, 29 Nov 2024 04:41:09 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tGxUl-0003ve-HH; Fri, 29 Nov 2024 04:41:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=8mPyDNRRzYPXx/ZHBp28evdnsI7YwlIPsD3iNYPaD7c=; b=XwJMEH3PZJ3SgRPumqDq KCdG5Pd0aq5E0AEbvffT/Kmfc/0Of29kKIEqkORxKkbtaMPTHmJLxi0ic44QT+GJtzUBjLNQwh8st j4bR5hzeDZrRagu2kf03gbIKpGoq4Dt6j2CQ3e8RF80SkRxZFEINg7JUJN8eGtW/NjzAH6P8pg1u2 N7UPfEXQlf5oIf1bS2DNhxZ4qYDStyEdDppd0iw7vLzA3L9suYf0NlOmDv8Du7tpRqs4kv5b/gNAy d5XGsEc6jCmLkcQJaIx0YalttKoqDQ6x7RPdbUclo1MvLHG/WIms3hWAsjLtPoAk7VjsdH01LpybY Y51CZvcVtBVOCQ==; From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 74542@debbugs.gnu.org Subject: [PATCH v2 14/16] =?UTF-8?q?transformations:=20=E2=80=98package-wi?= =?UTF-8?q?th-upstream-version=E2=80=99=20can=20preserve=20patches.?= Date: Fri, 29 Nov 2024 10:40:17 +0100 Message-ID: <16a63273fb59de165d2908bd370e9314b757d13f.1732872499.git.ludo@gnu.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Debbugs-Cc: Christopher Baines , Josselin Poiret , Ludovic Courtès , Mathieu Othacehe , Simon Tournier , Tobias Geerinckx-Rice Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74542 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * guix/transformations.scm (upstream-fetch): New procedure. (package-with-upstream-version): Add #:preserve-patches? and honor it. Change-Id: Ib56b84957d8bdad2eebe2551e2a6e477506fc55e --- guix/transformations.scm | 25 ++++++++++++++++++++++--- tests/transformations.scm | 31 ++++++++++++++++++++++++++++++- 2 files changed, 52 insertions(+), 4 deletions(-) diff --git a/guix/transformations.scm b/guix/transformations.scm index 9dfc4402c5..a32aad39f2 100644 --- a/guix/transformations.scm +++ b/guix/transformations.scm @@ -848,9 +848,20 @@ (define (transform-package-patches specs) (rewrite obj) obj))) -(define* (package-with-upstream-version p #:optional version) +(define* (upstream-fetch source hash-algo hash + #:optional name + #:key (system (%current-system)) + (guile (default-guile)) + executable?) + "This origin method simply downloads SOURCE, an record." + (lower-object source system)) + +(define* (package-with-upstream-version p #:optional version + #:key (preserve-patches? #f)) "Return package P changed to use the given upstream VERSION or, if VERSION -is #f, the latest known upstream version." +is #f, the latest known upstream version. When PRESERVE-PATCHES? is true, +preserve patches and snippets found in the source of P, provided it's an +origin." (let ((source (package-latest-release p #:version version))) (cond ((not source) (if version @@ -885,7 +896,15 @@ (define* (package-with-upstream-version p #:optional version) (package (inherit p) (version (upstream-source-version source)) - (source source)))))) + (source (if (and preserve-patches? + (origin? (package-source p))) + ;; Inherit P's origin so snippets and patches are + ;; applied as if we had run 'guix refresh -u'. + (origin + (inherit (package-source p)) + (method upstream-fetch) + (uri source)) + source))))))) (define (transform-package-latest specs) "Return a procedure that rewrites package graphs such that those in SPECS diff --git a/tests/transformations.scm b/tests/transformations.scm index 755211d65d..5285d98f17 100644 --- a/tests/transformations.scm +++ b/tests/transformations.scm @@ -1,5 +1,5 @@ ;;; GNU Guix --- Functional package management for GNU -;;; Copyright © 2016-2017, 2019-2023 Ludovic Courtès +;;; Copyright © 2016-2017, 2019-2024 Ludovic Courtès ;;; Copyright © 2021 Marius Bakke ;;; ;;; This file is part of GNU Guix. @@ -497,6 +497,35 @@ (define* (depends-on-toolchain? p #:optional (toolchain "gcc-toolchain")) (let ((new (t coreutils))) (assq-ref (package-properties new) 'transformations)))) +(test-equal "package-with-upstream-version" + '("42.0" "42.0" + ("http://example.org") + ("a" "b") (do something)) + (mock ((guix upstream) %updaters + (delay (list (upstream-updater + (name 'dummy) + (pred (const #t)) + (description "") + (import (const (upstream-source + (package "foo") + (version "42.0") + (urls '("http://example.org"))))))))) + (let* ((old (dummy-package "foo" (version "1.0") + (source (dummy-origin + (patches '("a" "b")) + (snippet '(do something)))))) + (new (package-with-upstream-version old)) + (new+patches (package-with-upstream-version + old #:preserve-patches? #t))) + (list (package-version new) (package-version new+patches) + + ;; Source of NEW is directly an . + (upstream-source-urls (package-source new)) + + ;; Check that #:preserve-patches? #t gave us an origin. + (origin-patches (package-source new+patches)) + (origin-snippet (package-source new+patches)))))) + (test-equal "options->transformation, with-latest" "42.0" (mock ((guix upstream) %updaters -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 29 04:41:29 2024 Received: (at 74542) by debbugs.gnu.org; 29 Nov 2024 09:41:29 +0000 Received: from localhost ([127.0.0.1]:41081 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGxVA-0005ur-TB for submit@debbugs.gnu.org; Fri, 29 Nov 2024 04:41:29 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57500) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGxUr-0005rq-IE for 74542@debbugs.gnu.org; Fri, 29 Nov 2024 04:41:10 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tGxUm-0003w8-Bm; Fri, 29 Nov 2024 04:41:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=exqb2JyVM9pf15rsNsmXF+soeRzoQH8Jd+LNl81XjUA=; b=JXepLYV7O5i14nOeK4Jk sTklviNvk5T4T0vekEDkwwgzHv9s9MjjrAjP2iZKUthI4Mb+Whjeptl4SACI4PjYczcwvsIuS8Pa6 r1y5XnmBuitPcQl7aOSmcPVN8G53iXwU2ATM0XLRqRY8CIoRgAWanBpbw+0GJnzL4fDOgW2/i/y70 22RJujkcFh/FMGH6fZAxXCzLjt2x1i1Bkde8qYoWwcDAe9qOhKz5hCwQQwfUpjJTNcxEC909NJzJM zmhcZEnt8O7RTksQPNKP4EipoN++vJbIMcBywPFK0PQltqBt5+c5S175EkfOrxfrVT5Ds1rB7Z9RX JcsGSV7vwTL2oQ==; From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 74542@debbugs.gnu.org Subject: [PATCH v2 15/16] =?UTF-8?q?transformations:=20Add=20#:authenticat?= =?UTF-8?q?e=3F=20to=20=E2=80=98package-with-upstream-version=E2=80=99.?= Date: Fri, 29 Nov 2024 10:40:18 +0100 Message-ID: <59a90dbf5692b02d31b8bbc4ee86b93880475cfc.1732872499.git.ludo@gnu.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Debbugs-Cc: Christopher Baines , Josselin Poiret , Ludovic Courtès , Mathieu Othacehe , Simon Tournier , Tobias Geerinckx-Rice Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74542 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * guix/transformations.scm (upstream-source-without-signatures): New procedures. (package-with-upstream-version): Add #:authenticate? and honor it. Change-Id: Ib86feb765f57bc1b129e813780abc605c43ed97b --- guix/transformations.scm | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/guix/transformations.scm b/guix/transformations.scm index a32aad39f2..3f7d20beaa 100644 --- a/guix/transformations.scm +++ b/guix/transformations.scm @@ -31,7 +31,8 @@ (define-module (guix transformations) #:autoload (guix download) (download-to-store) #:autoload (guix git-download) (git-reference? git-reference-url) #:autoload (guix git) (git-checkout git-checkout? git-checkout-url) - #:autoload (guix upstream) (package-latest-release + #:autoload (guix upstream) (upstream-source + package-latest-release upstream-source-version upstream-source-signature-urls) #:autoload (guix cpu) (current-cpu @@ -856,13 +857,24 @@ (define* (upstream-fetch source hash-algo hash "This origin method simply downloads SOURCE, an record." (lower-object source system)) +(define (upstream-source-without-signatures source) + "Return SOURCE with #f as its 'signature-urls' field." + (upstream-source (inherit source) + (signature-urls #f))) + (define* (package-with-upstream-version p #:optional version - #:key (preserve-patches? #f)) + #:key + (preserve-patches? #f) + (authenticate? #t)) "Return package P changed to use the given upstream VERSION or, if VERSION is #f, the latest known upstream version. When PRESERVE-PATCHES? is true, preserve patches and snippets found in the source of P, provided it's an -origin." - (let ((source (package-latest-release p #:version version))) +origin. When AUTHENTICATE? is false, disable OpenPGP signature verification +of upstream source code." + (let ((source (and=> (package-latest-release p #:version version) + (if authenticate? + identity + upstream-source-without-signatures)))) (cond ((not source) (if version (warning -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 29 04:41:29 2024 Received: (at 74542) by debbugs.gnu.org; 29 Nov 2024 09:41:30 +0000 Received: from localhost ([127.0.0.1]:41083 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGxVB-0005uu-9Z for submit@debbugs.gnu.org; Fri, 29 Nov 2024 04:41:29 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57502) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGxUs-0005ry-AV for 74542@debbugs.gnu.org; Fri, 29 Nov 2024 04:41:11 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tGxUn-0003wG-4C; Fri, 29 Nov 2024 04:41:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=BLU0AjlNhxfzkeV9f0SFoNZYGxXI16nFBD9qccLJFTM=; b=Po0NIcftSm/U1dBzhdr6 AkaRdNpGjBVEs93WA8qMXF6Ay+FMFtqxyKc/LTmpJ4pQYA4brKaQ0ZTguNbKq852ozguYNaBi49ZW fADz3GjgHvcdcOevUlY7egfEKMqnCDQn92BBYd+KQ/ALJHOXeXMQ6Z2F73cZZMLbFJlnvga8hNg9t 9JdnBxuXLcJ3BBmZU5dW4BFQb4SdOboAqzw2EzMVtMTZQBeiRr3nqKZXbachbtiGCwz0aGUnvRls9 EPsSmNinhAADJQyNORlBKJhiCutlbW+SU3uJnGNeSV9PAKL+PeAEVqaHdGBg9C16f96+Eu7vOW56i Z/18fUCNhc1NTw==; From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 74542@debbugs.gnu.org Subject: [PATCH v2 16/16] etc: Add upgrade manifest. Date: Fri, 29 Nov 2024 10:40:19 +0100 Message-ID: <11eaf63e70243255682cb325b8781dcb28841b7c.1732872499.git.ludo@gnu.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: References: MIME-Version: 1.0 X-Debbugs-Cc: Christopher Baines , Josselin Poiret , Ludovic Courtès , Mathieu Othacehe , Simon Tournier , Tobias Geerinckx-Rice Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74542 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * guix/scripts/build.scm (dependents): Export. * etc/upgrade-manifest.scm: New file. * Makefile.am (EXTRA_DIST): Add it. Change-Id: I1b2a2ebd09e559c68da9f25772bf33caacb4c031 --- Makefile.am | 1 + etc/upgrade-manifest.scm | 128 +++++++++++++++++++++++++++++++++++++++ guix/scripts/build.scm | 2 + 3 files changed, 131 insertions(+) create mode 100644 etc/upgrade-manifest.scm diff --git a/Makefile.am b/Makefile.am index e94ba87797..0cff32c607 100644 --- a/Makefile.am +++ b/Makefile.am @@ -743,6 +743,7 @@ EXTRA_DIST += \ etc/source-manifest.scm \ etc/system-tests.scm \ etc/time-travel-manifest.scm \ + etc/upgrade-manifest.scm \ scripts/guix.in \ tests/cve-sample.json \ tests/keys/civodul.pub \ diff --git a/etc/upgrade-manifest.scm b/etc/upgrade-manifest.scm new file mode 100644 index 0000000000..5e6d7d85e4 --- /dev/null +++ b/etc/upgrade-manifest.scm @@ -0,0 +1,128 @@ +;;; GNU Guix --- Functional package management for GNU +;;; Copyright © 2024 Ludovic Courtès +;;; +;;; This file is part of GNU Guix. +;;; +;;; GNU Guix is free software; you can redistribute it and/or modify it +;;; under the terms of the GNU General Public License as published by +;;; the Free Software Foundation; either version 3 of the License, or (at +;;; your option) any later version. +;;; +;;; GNU Guix is distributed in the hope that it will be useful, but +;;; WITHOUT ANY WARRANTY; without even the implied warranty of +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;;; GNU General Public License for more details. +;;; +;;; You should have received a copy of the GNU General Public License +;;; along with GNU Guix. If not, see . + +;; This manifest computes upgrades of key packages using updaters from (guix +;; upstream) and supporting code for the 'with-latest' transformation. + +(use-modules (guix memoization) + (guix monads) + (guix graph) + (guix packages) + (guix profiles) + (guix store) + (guix transformations) + (guix upstream) + ((guix scripts build) #:select (dependents)) + ((guix scripts graph) #:select (%bag-node-type)) + ((guix import github) #:select (%github-api)) + (guix build-system gnu) + (guix build-system cmake) + ((gnu packages) #:select (all-packages)) + + (gnu packages backup) + (gnu packages curl) + (gnu packages freedesktop) + (gnu packages gnupg) + (gnu packages ssh) + (gnu packages tls) + (gnu packages version-control) + (gnu packages xorg) + + (ice-9 match) + (srfi srfi-1)) + +;; Bypass the GitHub updater: we'd need an API token or we would hit the rate +;; limit. +(%github-api "http://example.org") + +(define security-packages + (list xorg-server + elogind + + openssl + gnutls + curl + curl-ssh + + libarchive + libgit2 + libssh + + ;; GnuPG. + libassuan + libgpg-error + libgcrypt + libksba + npth + gnupg + gpgme + pinentry)) + +(define latest-version + (mlambdaq (package) + (package-with-upstream-version package + ;; Preserve patches and snippets to get + ;; exactly the same as what we'd have with + ;; 'guix refresh -u PACKAGE'. + #:preserve-patches? #t + + ;; XXX: Disable source code authentication: + ;; this requires a local keyring, populated + ;; from key servers, but key servers may be + ;; unreliable or may lack the upstream + ;; keys. Leave it up to packagers to + ;; actually authenticate code and make sure + ;; it matches what this manifest computed. + #:authenticate? #f))) + +(define individual-security-upgrades + ;; Upgrades of individual packages with their direct dependents built + ;; against that upgrade. + (manifest + (with-store store + (append-map (lambda (package) + (let* ((name (package-name package)) + (newest (latest-version package)) + (update (package-input-rewriting + `((,package . ,newest))))) + (map (lambda (package) + (manifest-entry + (inherit (package->manifest-entry + (update package))) + (name (string-append (package-name package) + "-with-latest-" name)))) + (dependents store (list package) 1)))) + security-packages)))) + +(define joint-security-upgrades + ;; All of SECURITY-PACKAGES updated at once, together with their dependents. + (manifest + (with-store store + (let ((update-all (package-input-rewriting + (map (lambda (package) + `(,package . ,(latest-version package))) + security-packages)))) + (map (lambda (package) + (manifest-entry + (inherit (package->manifest-entry + (update-all package))) + (name (string-append (package-name package) "-full-upgrade")))) + (dependents store security-packages 2)))))) + +(concatenate-manifests + (list individual-security-upgrades joint-security-upgrades)) diff --git a/guix/scripts/build.scm b/guix/scripts/build.scm index d1368f7e48..0080f1fe58 100644 --- a/guix/scripts/build.scm +++ b/guix/scripts/build.scm @@ -63,6 +63,8 @@ (define-module (guix scripts build) show-cross-build-options-help show-native-build-options-help + dependents + guix-build register-root register-root*)) -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 29 09:43:30 2024 Received: (at 74542) by debbugs.gnu.org; 29 Nov 2024 14:43:30 +0000 Received: from localhost ([127.0.0.1]:41651 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tH2DS-0003w2-9v for submit@debbugs.gnu.org; Fri, 29 Nov 2024 09:43:30 -0500 Received: from mail-pg1-f181.google.com ([209.85.215.181]:54544) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tH2DQ-0003vk-9C for 74542@debbugs.gnu.org; Fri, 29 Nov 2024 09:43:29 -0500 Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-7ee11ff7210so1390596a12.1 for <74542@debbugs.gnu.org>; Fri, 29 Nov 2024 06:43:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732891342; x=1733496142; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=g7trmUtYeIVIupR3s+g6OQQpks8s6laZmAYhi+OMIV0=; b=XkAaapy5vbTz0blH5nMVFVhDKdA9avRDLDwcICWF3Voy5uS821WQ00sisA3flXwzi3 GEg76Qa55QyMxY0HUXEwNg1wJhed8PPIh/iVc9FSZIE446bmowKfg+bvg+p4lJEVOCqM dbVsJdmNVnTxDPd6c7DR3v3YJlzKOtuVfEipXDk1E8Ls5BPhp0aqCZLZqI7mihbDgUe+ K7jIkleJkWB8GJnz4OF5II57ZpRv6/LQ3BgAj8WYHP+041jte/D8t1bZwrsnONokEiuO FYpvBkm0qBJy7Qi1mpb+qpGgKv3skILjZ1s4bgfpdwa8ZsLPf99JJbKtPZokrZ425gFZ m/xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732891342; x=1733496142; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=g7trmUtYeIVIupR3s+g6OQQpks8s6laZmAYhi+OMIV0=; b=sUFyV0DOYwIdzf8SuNA/g8RnhkOSR+6sOV7AyWJ5Uwla9UuUd/25tYwzIgmP6SfaYI hjZa9YtwZ8QbPrPOlpWA0d0pOtX92n1g08SeIj6otmz9Kf+GDgOvSfvSNPDo4QMopFaX +7cyj83oLDY2Vp1fl0NVWDBUssNhgoObjOMevuF+0VOXt+0TSPLgh1UuvGgnLtYwoWza B2u3meS5QHy0XQXcvdzWWBoKkzKWrVvBNiOWMDk6czzDlLuAz14Hd8FDS+2yS7nT9c9q ci3a2IAW6PzKCiZq1A5mN7lImQWaKNLXjvcZowsGO8iC+xjiEnYjf505I4zO9XNF1vzp xmwg== X-Gm-Message-State: AOJu0Yx+0klbCOkC95bwfFASCVsrv2MNbBFd2fAetcTaw/zKCP9fh9ZE W+k7BfDHZhRq9H/5fvioGIfVhjV1xwOhD6X9CwC7nwlyGdMfDwCn X-Gm-Gg: ASbGnctgD9IJ28rsg8l0iMikG/8nqbxreFJ1tMpJkFuODbvMSM/0kzgENbiag68D34u Ji+L5vJpN8z17zhnF+fkkNlXIepA7+AKKYoW4sNkXUGfwI0hkAckyBnb8OTz8stPhANS6UnUM1x pjjoOQoGkNgOTKEft7Zuv8KVYdRC7zEt3wsrhn8q5oWFhJyAAQ/n9JFAGzBxHh7UqQ7zZuPwYLA 0BDN8Sd1URt6tXpeMhvo21arJmmXovTILRZHDt9WAZi0nQ= X-Google-Smtp-Source: AGHT+IEHop8e1yf/zais+hWPmTW2QNIrIdgxx+UH5kkhBgbRWw27OAU4Eu1V21xqukFWjid+PoOZbA== X-Received: by 2002:a05:6a20:729e:b0:1db:ee29:4f4c with SMTP id adf61e73a8af0-1e0e0b14d7emr17822393637.23.1732891342237; Fri, 29 Nov 2024 06:42:22 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7254181473csm3538469b3a.136.2024.11.29.06.42.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Nov 2024 06:42:21 -0800 (PST) From: Maxim Cournoyer To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#74542] [PATCH v2 02/16] gnu-maintenance: =?utf-8?Q?=E2=80=98import-html-release=E2=80=99_doesn=E2=80=99t?= abort upon HTTP 404. In-Reply-To: ("Ludovic =?utf-8?Q?Court=C3=A8s=22's?= message of "Fri, 29 Nov 2024 10:40:05 +0100") References: Date: Fri, 29 Nov 2024 23:42:11 +0900 Message-ID: <87wmgmhzjw.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74542 Cc: Josselin Poiret , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , 74542@debbugs.gnu.org, Christopher Baines X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Ludovic Court=C3=A8s writes: > Previously, updaters using =E2=80=98import-html-release=E2=80=99 would th= row to 'quit > when the HTML page isn=E2=80=99t found, aborting the whole process: > > $ guix refresh coreutils libchop > guix refresh: error: https://de.freedif.org/savannah//libchop/: HTTP do= wnload failed: 404 ("Not Found") > > * guix/gnu-maintenance.scm (url->links): Guard against =E2=80=98http-get-= error?=E2=80=99 > and return the empty list when it is raised. > > Change-Id: I419ff96ddb424aa8c74d6bab3d66a5e85355c3dc Reviewed-by: Maxim Cournoyer --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 29 09:48:00 2024 Received: (at 74542) by debbugs.gnu.org; 29 Nov 2024 14:48:00 +0000 Received: from localhost ([127.0.0.1]:41772 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tH2Hn-0004HP-Qy for submit@debbugs.gnu.org; Fri, 29 Nov 2024 09:48:00 -0500 Received: from mail-pf1-f169.google.com ([209.85.210.169]:48552) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tH2Hd-0004Go-Fs for 74542@debbugs.gnu.org; Fri, 29 Nov 2024 09:47:50 -0500 Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-7250c199602so1643354b3a.1 for <74542@debbugs.gnu.org>; Fri, 29 Nov 2024 06:47:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732891609; x=1733496409; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PVb0yKI6thbsI5KLvpWv8eXEeg8BpjB4K5Pbxq94m3k=; b=aVMLGUFz63K4bNMgbx8EsKz4SwMQDRVh+iN0lIXJY/d5LyXiytxsqY4wCd9gjnEsUL u6fOTf9ukf55w+3jz3PS9vMp2PABX4QLMMwXEBCWz4WMOgamy/3wqWqqVAUHt8kSxetK pF+tfa2SL09NtTFXO426AbeKiOBYphb2zxiKgtWeKVK6KsvTZAek4T0m1viiMnUAgljw l9vDyS5oe6ZR8wEDPuAPFwBYym2y1OrLBpOgZgG/99YIkzPndIFozjiqFfBPmEks3/Vf 1GM8g68ixwaI1m6Ln11Teycxsel+pZr+ZZ5n1GggI+t4kdHjAAGplo92mR3YA1KTlAU3 P8xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732891609; x=1733496409; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=PVb0yKI6thbsI5KLvpWv8eXEeg8BpjB4K5Pbxq94m3k=; b=mRPU+WMZvJUf6G3fyIgKtyiPQ/tqDPLcVr5IWXShJicxgcM99j7X1DfsgEs1s8PYz0 gp47Ge1MzhLGJdcmcIjc+H8+F6f7x+W5ftxlJ8J8kBvlWJkYzdQPrK23dhH3KmyJawC6 PbL4qHBaE5MXb01i7UFVjNTwtEUjYFAvUPzSNDeUe7MCb8Km5f93iqRaDZ4TEsf5ikK5 v9lPqA2ulOkL6JBgjBt05rtKyWznX8/ADRMMCnZsSkLbxJ0xKwODQmhNaPsZVFHhuAci VTdONTtwlz0E8ze2UriTrok343tCnx5DJAQT/uQv+jIgz3nhGY2BOvICBrrepYngIkVH hy6w== X-Gm-Message-State: AOJu0YzsJM/p/OsR07nXyN+FaWvSNPg4Kin8yU37A1qMusE/c0O1uF7Z hc7AU5nVRRsi2WGZ81lKJHJYqADdlHe6jgSEXvUaW9pmLX1cZNUO X-Gm-Gg: ASbGncvCaad84ithTMr9PlOzxOhXX/NiOhAy7ddB+mukWlNJttzvKKhsASsSkVyNI9+ a2JULgwTc9uvDLiZ1vfanlGMEoDtKJGt1U52lXGg2NOKrsiRdJCNfJo4U0cWZ/0ZsnCEHIdtPwl Y0U22S59JWL+YOSdaQ35902rS14FZLgd1TyIKA1a2D/kzBoYAngDmU6ukx3SZwAnCvNeUrfFpMd R/LUAjJ0w+uZKL/mepTIbPVPr4bYPGNbk2uo1xgPsFnh+M= X-Google-Smtp-Source: AGHT+IGVnvpHlpp1cOz8SD9xUzqur3bT1JtYdRnJ+A+amnJUa0EIai5+srS39LRPTd04DhF5TSEKlQ== X-Received: by 2002:a05:6a00:1396:b0:71e:67e7:1a4c with SMTP id d2e1a72fcca58-72530037d93mr15225219b3a.12.1732891608744; Fri, 29 Nov 2024 06:46:48 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7fc9c3a063dsm3149309a12.73.2024.11.29.06.46.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Nov 2024 06:46:48 -0800 (PST) From: Maxim Cournoyer To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#74542] [PATCH v2 00/16] Improved tooling for package updates In-Reply-To: ("Ludovic =?utf-8?Q?Court?= =?utf-8?Q?=C3=A8s=22's?= message of "Fri, 29 Nov 2024 10:40:03 +0100") References: Date: Fri, 29 Nov 2024 23:46:38 +0900 Message-ID: <87serahzch.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74542 Cc: Josselin Poiret , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , 74542@debbugs.gnu.org, Christopher Baines X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Ludovic! Ludovic Court=C3=A8s writes: [...] > While =E2=80=98guix build openssl --with-latest=3Dopenssl=E2=80=99 di= smisses patches, > what we want here instead is to preserve patches, such that what=E2= =80=99s > being built is exactly the same as what we=E2=80=99d get with =E2=80= =98guix > refresh -u openssl=E2=80=99. Could 'guix build openssl --with-latest' also have an option to preserve patches? This has often tripped me. --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 29 09:50:25 2024 Received: (at 74542) by debbugs.gnu.org; 29 Nov 2024 14:50:25 +0000 Received: from localhost ([127.0.0.1]:41802 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tH2K8-0004TH-S1 for submit@debbugs.gnu.org; Fri, 29 Nov 2024 09:50:25 -0500 Received: from mail-pf1-f169.google.com ([209.85.210.169]:53625) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tH2K6-0004T8-R1 for 74542@debbugs.gnu.org; Fri, 29 Nov 2024 09:50:23 -0500 Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-724e5fb3f9dso1763780b3a.3 for <74542@debbugs.gnu.org>; Fri, 29 Nov 2024 06:50:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732891762; x=1733496562; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FgkobZinYBSeHB+RpRxEVCDBX/vE03T/C+O1JGhtJKg=; b=cJe5GwbcXCYo36TADa3BMCwm1tw4XMJ+NOFtrHzjJQJzuSIRp+HnnQMP63CStcvSx5 M/DOAn09omlHNITG/76KvyUqdo6nD84dhmfX/iTBhSsQc0z6Wm4loVMrepA2nZxWDl8p hiIEO/yQvKHy74ixfQnmwcdA073MhUz2By+br6VXb5g4bs6bftxoYmsaOH3fYogpk8J6 +DG/qbuBJVo7dZdBxfpghDt5bIPQ55fYNyqI6xW0T/QLeIEFQGuw/q+agzbvKfUIPVWb l0c171RDZNntcAkyqsuqjv8bI8KL+K1SuNDoxLwxLZHNUDrRTD3DBs4yqHIIFhnQlN3O HINw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732891762; x=1733496562; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=FgkobZinYBSeHB+RpRxEVCDBX/vE03T/C+O1JGhtJKg=; b=l02CNa8T5AEpf4oFBSBFwjBd+UA0g/gotgUWdmLa9Eg27jh3WtUUiskDyxRLGi3rLS 8Rdgsim04O1cZaDiZBgbFDLAmj9N9MMHHZMBnjOpl6jHOmjpbu1aCulUFILt84QOKR2r VkNhezk+7yGTU+LNS3yWhPqArCOE1If0X6zjxaFYWPTmpFTSabp3tmuID0y3BK5n0zKk bnDacEZ1HEHXh1CieJDw4zLrAp22EDnT1R9XqEn6HcgS/uGMHjjNIYzf+uimnyCDxJ29 c0/x6Qv96YLsuOtfJwoaaD4iYaL63KiDCKzZ66GdZZ8d33ZkwlMdXodnyz/zY4XhJnHK E6xQ== X-Gm-Message-State: AOJu0YwDP5cj8w3voPtDNGLvp4y2GbkEwzZuNRWyqTavij0+mAvyydsW cyomti5TKOVqYztuMLdlVl/Ehqsid+t2Cai1s1cvIR9zYNkXDdIH X-Gm-Gg: ASbGncttcREFNfRiTfx6vkteHjzaPNRhfPUrFELTc8B9OmKoR7FUch1HYpYwic1d1Yh ob30iDA0rGVI2XBWAoL9xcPbRTtqRt1/PldBE6nBEhCf93sX3ZGip8irWaWc4D+7c0MXnWwyk5/ tSVBw+jlXK0Sb7cYID+sJb56/tJVnUYjm0s5mjysC+nF7iBAr+Q7nXPwAqB3yhkRArj00b3Wf/g Sitoz/fNq9XnLUvgbnvawDbPejUenA46VlBTDKmf+Sq+lo= X-Google-Smtp-Source: AGHT+IEemeWk25oszvKGfcNcuS34XRc9Px2SqSn5nt8B4yKce768YBiccg86hbKenBiUg1quvZYfwA== X-Received: by 2002:a05:6a00:3cc5:b0:724:d758:f35 with SMTP id d2e1a72fcca58-7252fffe134mr15062822b3a.2.1732891762211; Fri, 29 Nov 2024 06:49:22 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7254176fd6fsm3677959b3a.62.2024.11.29.06.49.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Nov 2024 06:49:21 -0800 (PST) From: Maxim Cournoyer To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#74542] [PATCH v2 04/16] guix build: Add =?utf-8?Q?=E2=80=98--development=E2=80=99?= option. In-Reply-To: <298ce743d6908424e59c348444fa4d904935646d.1732872498.git.ludo@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22's?= message of "Fri, 29 Nov 2024 10:40:07 +0100") References: <298ce743d6908424e59c348444fa4d904935646d.1732872498.git.ludo@gnu.org> Date: Fri, 29 Nov 2024 23:49:11 +0900 Message-ID: <87o71yhz88.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74542 Cc: Josselin Poiret , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , 74542@debbugs.gnu.org, Christopher Baines X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Ludovic Court=C3=A8s writes: > * guix/scripts/build.scm (show-help, %options): Add =E2=80=98-D=E2=80=99. > (options->things-to-build): Change =E2=80=98append-map=E2=80=99 to a loop= . Honor =E2=80=98-D=E2=80=99. > * tests/guix-build.sh: Add test. > * doc/guix.texi (Additional Build Options): Document it. > > Change-Id: I99227aadfe861e43c001a4872292bd687b37f5d4 Reviewed-by: Maxim Cournoyer --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 29 09:54:59 2024 Received: (at 74542) by debbugs.gnu.org; 29 Nov 2024 14:54:59 +0000 Received: from localhost ([127.0.0.1]:41812 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tH2OY-0004bf-SZ for submit@debbugs.gnu.org; Fri, 29 Nov 2024 09:54:59 -0500 Received: from mail-pg1-f170.google.com ([209.85.215.170]:56387) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tH2OW-0004bS-9h for 74542@debbugs.gnu.org; Fri, 29 Nov 2024 09:54:56 -0500 Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-7fc340eb006so1517769a12.0 for <74542@debbugs.gnu.org>; Fri, 29 Nov 2024 06:54:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732892035; x=1733496835; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SxoqlFJMNBbrXgSEXwurNdouG2TmBL24YmmtnhGeGh0=; b=VICx1SfwNiEEVUep/+2JPItEd2Qry57xS5ZcozMFWk7TKXq8AXzsHoPSZ+5jGzSHpI 4bNUQFcBv/bOKXnuXMpcsOeESFPXL1/WI2CsdtMPrc+HAVq94f0JgBY5+eO5/L5tPjLT hVMDWwe/UpZ8GwvnvtpXavD/7KWHprlEkwRDg/fagnsiZ7AbWyTOebLT9aPU2B2eGxyJ GJZNHLABmLr1Qhoe1yL9vNbpEQ6XwaV6h8+j3HYnNnQKiaaslqs1VPycisuGEuPzhPro Me3jR1oARPACnB2OPu5IQ5OZ8LMUlUfrcMAVLbjUs3E5rTZOLynXZkyOw4MN0kw1TL4s kazg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732892035; x=1733496835; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=SxoqlFJMNBbrXgSEXwurNdouG2TmBL24YmmtnhGeGh0=; b=IudkjSwrs2FzOGPUoY9u5b6PNk7xu/rBwqt2O4V2zMt0STwxsB8TmKBO7bL8C8YEhm QTf1ohL3AWpF+78+rCU+jFxEmbcfwALA/eSU6giqlF34X5PwwZscr3ne46dM40RHco55 +oT/sB5bVGwrN0lZ8TLCShsaSB53XbenKLUDdDMPC/3WAu2W8pUUBtQ+iY1byERSnZfZ lhvT+hEavlP2z8+oSOjzNIQG6hBTNhidFwzI99+fPDtE9W3gGtWERLbUgiaX5dv4h2hX cBJly9LtFAQQ58tJOkxOMOBch5c1B7AtvC8dZx++IBtBoyyU3VJ3DtXzJZa2sNZTW+DB e7rg== X-Gm-Message-State: AOJu0YxzmcGNndQzMrgQKI8BYDyQN0NMgEvcUC6mH3SkhcuD81e4Yt94 xzaIligdfmE73GPAFWfKP0OAbRNDZq1F0lc1RBSpNGlGOorSIGZY X-Gm-Gg: ASbGncsFeFn9cgj+CtOgsk2N117gszQoJ9YzWIobAh/kO3tChXZAOchOp85KhZ6uhTx OUcDQ57NeEbnXl5+RgAbzAGN5SQTbMSMPcJOCEoL2Ca3G29dJZICJv2B69eeOEbj/Mm9ApRKsHV cdpypoOhslK3zoyybavQ6CNW4FLFQLWW83ayqLz2vRPdkTKec65Vrr6Yn8BlG5SpFLCnUsMAyGw Bl+nmOUMXeq3RZOWOsjKcIf3T0/iHeVnB9OvKLlVWZsdTE= X-Google-Smtp-Source: AGHT+IFeJOEtbvbj6XJ1Z8kPinINI/TOOrC51TFOKMw6hWSHf0Kj5T4W6un+7FhgWYT47QP+7MjcDQ== X-Received: by 2002:a17:90b:1843:b0:2ee:44ec:e524 with SMTP id 98e67ed59e1d1-2ee44ece861mr7007409a91.35.1732892035552; Fri, 29 Nov 2024 06:53:55 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2ee0fad02fasm5372764a91.37.2024.11.29.06.53.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Nov 2024 06:53:55 -0800 (PST) From: Maxim Cournoyer To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#74542] [PATCH v2 05/16] packages: Factorize =?utf-8?Q?=E2=80=98all-packages=E2=80=99=2E?= In-Reply-To: <8bcbbc485aa264424b29ea873fee3e2b6aa30008.1732872498.git.ludo@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22's?= message of "Fri, 29 Nov 2024 10:40:08 +0100") References: <8bcbbc485aa264424b29ea873fee3e2b6aa30008.1732872498.git.ludo@gnu.org> Date: Fri, 29 Nov 2024 23:53:45 +0900 Message-ID: <87jzcmhz0m.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74542 Cc: Josselin Poiret , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , 74542@debbugs.gnu.org, Christopher Baines X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Ludovic, Ludovic Court=C3=A8s writes: > * gnu/packages.scm (all-packages): New procedure. > * etc/source-manifest.scm (all-packages): Remove. > * guix/scripts/graph.scm (all-packages): Remove. > * guix/scripts/refresh.scm (all-packages): Remove. > * guix/scripts/weather.scm (all-packages): Remove. LGTM. [...] > @@ -253,6 +254,23 @@ (define* (fold-packages proc init > init > modules)) >=20=20 > +(define all-packages > + (mlambda () > + "Return the list of all public packages, including replacements and = hidden > +packages, excluding superseded packages." Reading the above doc made me question; are replacements always supposed to be made public? I typically would leave them private to avoid cluttering the CLI with duplicate packages. --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 29 10:18:25 2024 Received: (at 74542) by debbugs.gnu.org; 29 Nov 2024 15:18:25 +0000 Received: from localhost ([127.0.0.1]:44029 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tH2lF-0006H4-0p for submit@debbugs.gnu.org; Fri, 29 Nov 2024 10:18:25 -0500 Received: from mail-qv1-f66.google.com ([209.85.219.66]:55787) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tH2lC-0006Go-9X for 74542@debbugs.gnu.org; Fri, 29 Nov 2024 10:18:23 -0500 Received: by mail-qv1-f66.google.com with SMTP id 6a1803df08f44-6d88282980bso9194956d6.3 for <74542@debbugs.gnu.org>; Fri, 29 Nov 2024 07:18:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732893437; x=1733498237; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8Iz8Wx0A0GlWRjoCzr3gxTdEHEOWwfnO70Roep5kbP0=; b=EVc5/ArnaVWYoswAAZvDAbebmOtDjJ8kQeLvexjc9VhVMXekPVlxGM3D8r+yJ5/cnt OOYvQez6Iy/ObaLDO6iqyt/hUyaa/qdL1kLXzErmw/D69a4Lu34qsGDyUJit6SvKc7J5 QHieZdmwFSNUZdrFltB6NI8fX4rEZ7WXRhytVfg6FvTBR0XHD0kDmVeuQn7l/mBkAcwd CJBlPJD5yYPs3aXKVC1N7a9bxWt4o5+QI1dgICd76e1K89Fltw2mD4rtHP+XsH2HQ/fA p/8ZeGqkbPqJQaegZGEhFzXiYKOnR+Rl+J7Ffi5RfkkWqlbo++5Us9fJfbBm+JOdvoaq /ybQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732893437; x=1733498237; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=8Iz8Wx0A0GlWRjoCzr3gxTdEHEOWwfnO70Roep5kbP0=; b=rKHY5f2sUyJgk7m1TP0jRP2iPv7Xe+7Xfin1JuHyK1ugbKWOmuiA9kYKaWiSBFCOLL 3vvdWDvBvuxjojMtGcZxkiXO7Zn+3UbgPp6y0gjwCPV3LGgtQyv92shyCpW66FmVEcH/ lk8vQEj0d6L8896j053+UZjQlglYA/26Loiu84N45IFFvLpnQMfpuKFeWGRcpNWbf3E+ 2KjvKV8SXpSDumqbLhl9Bvzuo0tULKVndsRd0m5Ua7Z23TqzsXS+LUJpfSvgqpMkF6xV RlTDQdmHTwOBIVmnJOevHn2GzzbE2lrPzKu7PNHIwajgb1uHVX5iNZtGe4JgQr8YpXAy MhNw== X-Gm-Message-State: AOJu0Yw6Zl0+kbhnWEYwJfQD9z//9L/aG5v8UGJ5VUVNSz7L98pWULLY Oo5Zv4tKveia2eQ4B/XbmanCYQsYXYHJOYulIIr+brmlhfUHnlLDftUp4YB4 X-Gm-Gg: ASbGncvyRFELSjqABFzWi7bmBko6LwJs+ynGv0lwnGMZBHhmYsEKOqwd54hiCe1SwzF CU3VcM1McRvVZmhqjt72mq/29Uy6y4AtL7EnU2bvHk64f91BRiMgL0iQjmpEjO9Fb1QKq3eww5K YEKMqXmWAidmDzVaIjkg2SjYbSKY39vWxplDMT1fNhSDtdhujJPtz9CNSpykg1QiZLfhAoneX08 JX+Nx9IKf5r0DFzOOIcwhlhog9FQsIc3egbbG8RhiXE1EKNi4QWtJSMkSpqBwnUalUSFK83OdnQ gTMmD0KR9AJ5bmkx9jW0msuMDbw7EGe2Mg== X-Google-Smtp-Source: AGHT+IEp9PcSZcUZiXfjsnCgZOcapMig88HX45L/yI5TGefRBRqAsA0zaHAsjRWqhyA3mnjf6BkaZw== X-Received: by 2002:a05:6214:4018:b0:6d1:848b:a8ce with SMTP id 6a1803df08f44-6d864d51940mr172975086d6.28.1732893436514; Fri, 29 Nov 2024 07:17:16 -0800 (PST) Received: from gnus (bras-base-mtrlpq4385w-grc-01-76-65-175-237.dsl.bell.ca. [76.65.175.237]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6d88805ee2csm5175876d6.25.2024.11.29.07.17.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Nov 2024 07:17:16 -0800 (PST) From: Suhail Singh To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#74542] [PATCH v2 00/16] Improved tooling for package updates In-Reply-To: ("Ludovic =?utf-8?Q?Court?= =?utf-8?Q?=C3=A8s=22's?= message of "Fri, 29 Nov 2024 10:40:03 +0100") References: Date: Fri, 29 Nov 2024 10:17:15 -0500 Message-ID: <87ldx2rrwk.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 74542 Cc: Josselin Poiret , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , 74542@debbugs.gnu.org, Christopher Baines X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Ludovic Court=C3=A8s writes: > =E2=80=A2 Short option for =E2=80=98--dependents=E2=80=99 is now =E2=80= =98-P=E2=80=99 (instead of =E2=80=98-T=E2=80=99). Thank you to both Simon and yourself for prioritizing some kind of consistency between the various guix sub-commands. > =E2=80=A2 =E2=80=98package-with-upstream-version=E2=80=99 can preserve = patches. This turns > out to be a hard requirement if we want to make this useful. I agree that this is essential. At times, updates, can break existing patches. I am assuming it would be easy enough to spot such build failures? I.e., I am assuming that we will be preserving sufficient details from the build log so core developers may be informed. > =E2=80=A2 Manifest is now limited to a dozen security-critical packages= (I > left out leaf packages entirely; we can work on it separately > later). Prioritizing the security-critical packages makes sense. Especially since we lack an automated "integration" QA system at the moment, leaving the leaf packages for later is prudent. The learnings from trying this on the security-critical packages may also help inform the approach we take for the other packages. > =E2=80=A2 Manifest is more precise: it refers to the packages to update= by > their variable (rather than by package specs), which again makes > sure we=E2=80=99re upgrading the exact variant we want to upgrade. I think this is an essential change as well. > Thoughts? Thank you for devoting time to this. We need to improve our automation. > I=E2=80=99d like to have the manifest built by CI soon so we can assess > its usefulness and tweak it as needed. Could we please add some minimal code to submit-patch-if-build-succeeds to this series? That would provide a working example of a CI job that interacts with debbugs/sends-emails and would allow for greater eyeballs on the working state of this jobset. --=20 Suhail From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 29 11:54:00 2024 Received: (at 74542) by debbugs.gnu.org; 29 Nov 2024 16:54:00 +0000 Received: from localhost ([127.0.0.1]:44210 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tH4Fj-0002iG-TA for submit@debbugs.gnu.org; Fri, 29 Nov 2024 11:54:00 -0500 Received: from mail-wm1-f54.google.com ([209.85.128.54]:59447) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tH4Fh-0002i5-GV for 74542@debbugs.gnu.org; Fri, 29 Nov 2024 11:53:58 -0500 Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4349fd77b33so18790725e9.2 for <74542@debbugs.gnu.org>; Fri, 29 Nov 2024 08:53:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732899176; x=1733503976; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=ooQ37IRWjkupKJC737PpRWSy4VEITZa5SsZaXq9gHDw=; b=Seti38I0W/083MxW6hYC2RPBCpW3fPu1wTD9K6hY1hiT+UJv9VKNjZ7cNxlHsqwVYb IbrHo4dL7nJK2IOQWjFILuRoztxPFFDNVZIr/swIpfsDv5kIW4SM2+rKzib+9usNA3mc vBQsZXa2DMbKJklDpa5AGjDM/zuGH/YsRu/MvTJWgTF3jowoISTVtcWB4BLuE9hHP/KV aGXvPk2ha+G2A47MosKroCy5igq9qssihwmjYDgsc03lCG1zZsPQajzfCPFfWxNd3QNQ 3DGwL4QSGsfcfelqN++cF567jfvcmlmpn1kAR6nRuC7FFHbuuzwDwWZLpuL0Ii4MU+kn dEww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732899176; x=1733503976; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ooQ37IRWjkupKJC737PpRWSy4VEITZa5SsZaXq9gHDw=; b=d3/XmTQf9R799TaRj+9VIlYHxeOHgOa1hbDQUwtBWREvjAk9gFVTEuadDSUrqxTPXH VOJFaaVS/EnDhveYmFABG1D//isbgOqKe9zhGgr0S3G7K4o/Rm7tLxUWD1Ki/rOcee9y Y8JK0p2pxGkSe3NZDkbefeNCTNIR+LvHTURw+e8T6uOB3w/jL60HunZUU7QFN8+PhIr5 VA7JY4WfJRIg6ua3UDsPemVSrsc9vCoeuzmXWrRIvz6AwzVbjcqeyWzrVOEicnhHykwx uL2FPbOTAWbN9D9mhhJ19oivLHR64NTE4WLNa0/HBfSZM3ViulWmslQft5rCVJjOKdBy Uihg== X-Forwarded-Encrypted: i=1; AJvYcCWpRkoXKqu/IdRzO3V/jOQ6ADhH4Ze7LBDkhmVa17+rPfWPODzALZq9eZMj6AkMqtOXujFcYg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyqB8S9N7KY6DP8Vk+beCVdv0jv1Vy6kr/2G4Jpp7r02ZsMGO7B Q/QllHkIiKhHPfhF8J2wJQ2TyD87Kd/Dw4sE1bev+UOjBB2MGkxa X-Gm-Gg: ASbGncv6c77FhWj9WvmazM9dhi8ngvy/le65F6I4Ltb+DVYeio/oe/qpUOwzNVDm6OU ts1qI4UJVgEUtb9qqeNwjvAILDc72itW9yZ5fr59ku4EXgdEnEkVY4ZPpihDkbpt2iIcp3IjHkk 2hXKqEgeNVqLARsmjGOq8MBr32mrkb1qmMCCXEh0rex4WHkvucQJZm3kmpqLd9iCRzhUgruNNiE tx2iZGb/vShUsh87Btm4eI7IR2C3pUH9FDFcybLV4TQXTh6UJYD7w7srHxWNno7pIDrykqMLEVE yQ1vtsOFrDvBMwvKUG6N1nPfRmTbQHhDiKI= X-Google-Smtp-Source: AGHT+IHbaUrto4ncHGLYD8gJv/QB6QkK44gfgN8kvtcmOTwa22gOFv2DyE5JQFrz1INP49h+/SCD4g== X-Received: by 2002:a05:600c:4fc9:b0:434:a71f:f804 with SMTP id 5b1f17b1804b1-434a9dbbd30mr134134165e9.3.1732899176290; Fri, 29 Nov 2024 08:52:56 -0800 (PST) Received: from lili (roam-nat-fw-prg-194-254-61-42.net.univ-paris-diderot.fr. [194.254.61.42]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-434aa78c202sm89178315e9.26.2024.11.29.08.52.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Nov 2024 08:52:55 -0800 (PST) From: Simon Tournier To: Ludovic =?utf-8?Q?Court=C3=A8s?= , 74542@debbugs.gnu.org Subject: Re: [bug#74542] [PATCH v2 00/16] Improved tooling for package updates In-Reply-To: References: Date: Fri, 29 Nov 2024 16:23:37 +0100 Message-ID: <87wmgmdpxi.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74542 Cc: Christopher Baines , Ludovic =?utf-8?Q?Court=C3=A8s?= , Tobias Geerinckx-Rice , Josselin Poiret , Mathieu Othacehe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Ludo, On Fri, 29 Nov 2024 at 10:40, Ludovic Court=C3=A8s wrote: > =E2=80=A2 =E2=80=98generic-html=E2=80=99 updater correctly computes URL= s for =E2=80=98curl=E2=80=99 and > any other package that uses in its release > monitoring page. Oh! :-) > =E2=80=A2 Manifest is now limited to a dozen security-critical packages= (I > left out leaf packages entirely; we can work on it separately > later). I agree. > I=E2=80=99d like to have the manifest built by CI soon so we can assess > its usefulness and tweak it as needed. I agree. > Ludovic Court=C3=A8s (16): > transformations: Export =E2=80=98package-with-upstream-version=E2=80=99. > gnu-maintenance: =E2=80=98import-html-release=E2=80=99 doesn=E2=80=99t = abort upon HTTP 404. > gnu-maintenance: Savannah/Xorg updaters no longer abort on network > errors. > guix build: Add =E2=80=98--development=E2=80=99 option. > packages: Factorize =E2=80=98all-packages=E2=80=99. > guix build: Add =E2=80=98--dependents=E2=80=99. > import: gnome: Keep going upon HTTP errors. > gnu-maintenance: =E2=80=98gnu-ftp=E2=80=99 updater excludes GnuPG-hoste= d packages. > gnu: Update updater properties for GnuPG-related packages. > gnu: gnutls: Change release monitoring URL. > gnu: git-minimal: Add =E2=80=98upstream-name=E2=80=99 property. > gnu-maintenance: =E2=80=98generic-html=E2=80=99 update honors . > guix build: Validate that the file passed to =E2=80=98-m=E2=80=99 retur= ns a manifest. > transformations: =E2=80=98package-with-upstream-version=E2=80=99 can pr= eserve patches. > transformations: Add #:authenticate? to > =E2=80=98package-with-upstream-version=E2=80=99. > etc: Add upgrade manifest. > > Makefile.am | 1 + > doc/contributing.texi | 4 +- > doc/guix.texi | 52 +++++++++ > etc/source-manifest.scm | 13 +-- > etc/upgrade-manifest.scm | 128 +++++++++++++++++++++ > gnu/packages.scm | 20 +++- > gnu/packages/gnupg.scm | 40 ++----- > gnu/packages/tls.scm | 6 +- > gnu/packages/version-control.scm | 3 +- > guix/download.scm | 3 +- > guix/gnu-maintenance.scm | 90 +++++++++------ > guix/import/gnome.scm | 13 ++- > guix/scripts/build.scm | 185 ++++++++++++++++++++++++------- > guix/scripts/graph.scm | 10 -- > guix/scripts/refresh.scm | 10 -- > guix/scripts/weather.scm | 15 --- > guix/transformations.scm | 43 ++++++- > tests/guix-build.sh | 11 ++ > tests/transformations.scm | 31 +++++- > 19 files changed, 517 insertions(+), 161 deletions(-) > create mode 100644 etc/upgrade-manifest.scm Well, I have not given another look to all this v2 patchset. But from I have checked, it=E2=80=99s LGTM. Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 01 11:30:55 2024 Received: (at 74542) by debbugs.gnu.org; 1 Dec 2024 16:30:55 +0000 Received: from localhost ([127.0.0.1]:52845 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHmqV-0002qm-GL for submit@debbugs.gnu.org; Sun, 01 Dec 2024 11:30:55 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51942) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHmqT-0002qS-5E for 74542@debbugs.gnu.org; Sun, 01 Dec 2024 11:30:54 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tHmqN-0007E7-G7; Sun, 01 Dec 2024 11:30:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=v8kIR6SDsZh1sk//IUqVOPJ1kOqcHkqCNI0ODSZFYZU=; b=Ff5e4q/Sv0Y5tG0gWTwI F4zsk2cYoocDxenQHt3Uq7AhSlbezawvKD+D5s1UHiRm3trAF/18ZE0K/rZ+5MiyfOlLw35dwSHDA RVRI+f+kHf5nohmoXExf2rimGY3deQrF/0Xpuah4KH1FlX2Xi/9OjGsgl72FtbzGw5HBCeNiOZDmN Ah3p5yEnbVJx/YFfA4ALnZd+Kq0X52clwzUankWew6aTs8jIA7tawXKuhq5d4qge44gtTUEaUBpk0 uI+Mne3CwtDvY0gfSf1C0TKukDHD1sXEorYmuJugzQA9niZE9EU7oPVGcAhLLYBGqB+68CJrQ61gw P93h/BWGw1Lcew==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Maxim Cournoyer Subject: Re: [bug#74542] [PATCH v2 00/16] Improved tooling for package updates In-Reply-To: <87serahzch.fsf@gmail.com> (Maxim Cournoyer's message of "Fri, 29 Nov 2024 23:46:38 +0900") References: <87serahzch.fsf@gmail.com> Date: Sun, 01 Dec 2024 17:30:41 +0100 Message-ID: <87h67ns6vi.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74542 Cc: Josselin Poiret , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , 74542@debbugs.gnu.org, Christopher Baines X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Maxim Cournoyer skribis: > Ludovic Court=C3=A8s writes: > > > [...] > >> While =E2=80=98guix build openssl --with-latest=3Dopenssl=E2=80=99 d= ismisses patches, >> what we want here instead is to preserve patches, such that what=E2= =80=99s >> being built is exactly the same as what we=E2=80=99d get with =E2=80= =98guix >> refresh -u openssl=E2=80=99. > > Could 'guix build openssl --with-latest' also have an option to preserve > patches? This has often tripped me. It would be nice, though it might need some rework in transformation option handle (currently one option maps to exactly one transformation). Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 01 11:34:44 2024 Received: (at 74542) by debbugs.gnu.org; 1 Dec 2024 16:34:44 +0000 Received: from localhost ([127.0.0.1]:52854 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHmuB-0002yT-Lh for submit@debbugs.gnu.org; Sun, 01 Dec 2024 11:34:43 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56964) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHmu9-0002yE-Lu for 74542@debbugs.gnu.org; Sun, 01 Dec 2024 11:34:42 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tHmu4-0008Kt-Ed; Sun, 01 Dec 2024 11:34:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=hjdbt3nWr6lq2AP1PxEUamUqVVPCAm+N/cN414TI46U=; b=Uojvc2dBl3NtRa0/YFpW ReD87KZVFdO/oXKk4o4WcrvZpAfIW+CH0I5bFoKkwZnsGTqMEcsuVJTYyCtXhTRZoxJZuHQdZ9tWB inPub9wQ6u77kEilXrWlMNAyHx16a5//brToAOAyHfK4VNV1ITwisECoGSItlCCOQav0aKnmoCIyw CjnSNIrS8lxx2qhVEvC/Up418Pko5xsAUKO/1AUAStREejIFnbws3zjxTVzfpstb0gO0zQrsuOvdh Vcf2sspyqO51FJzfgFeKj3I/b8KXtPP1xAGqny/wTeLfotwd2FDZe5xrf+SQXYgR6lxm1cwGIol49 merWDCdf0+aWkQ==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Suhail Singh Subject: Re: [bug#74542] [PATCH v2 00/16] Improved tooling for package updates In-Reply-To: <87ldx2rrwk.fsf@gmail.com> (Suhail Singh's message of "Fri, 29 Nov 2024 10:17:15 -0500") References: <87ldx2rrwk.fsf@gmail.com> Date: Sun, 01 Dec 2024 17:34:12 +0100 Message-ID: <87a5dfs6pn.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74542 Cc: Josselin Poiret , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , 74542@debbugs.gnu.org, Christopher Baines X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Suhail Singh skribis: >> =E2=80=A2 =E2=80=98package-with-upstream-version=E2=80=99 can preserve= patches. This turns >> out to be a hard requirement if we want to make this useful. > > I agree that this is essential. At times, updates, can break existing > patches. I am assuming it would be easy enough to spot such build > failures? I.e., I am assuming that we will be preserving sufficient > details from the build log so core developers may be informed. Yes, you=E2=80=99d see a build failure in Cuirass or whichever tool or serv= ice you=E2=80=99re using. > Could we please add some minimal code to submit-patch-if-build-succeeds > to this series? That would provide a working example of a CI job that > interacts with debbugs/sends-emails and would allow for greater eyeballs > on the working state of this jobset. Again I agree it=E2=80=99d be nice but it=E2=80=99s beyond the scope of thi= s patch series. Technically, it would require a separate service/program that would, say, poll ci.guix via its JSON API to check the status of the jobset that builds the manifest provided in this series. Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 01 11:37:16 2024 Received: (at 74542) by debbugs.gnu.org; 1 Dec 2024 16:37:17 +0000 Received: from localhost ([127.0.0.1]:52871 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHmwe-0003AP-JI for submit@debbugs.gnu.org; Sun, 01 Dec 2024 11:37:16 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53168) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHmwa-0003A6-PK for 74542@debbugs.gnu.org; Sun, 01 Dec 2024 11:37:14 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tHmwV-0000ks-A7; Sun, 01 Dec 2024 11:37:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=aIqQOVnt3skakVDIGh1r4X0N4v+Aae9248O6ITg86MA=; b=k43rSWZhlet1aVPxzQFT 16Ees//JINq0f5aw9uXz59DB1ydD6tVxm0DPY6wSioyALjNdrf7BIj5g6Z5DZJ94fyQlf50rOABiV LuahNtSbMd+4lXltrSQmi1wKzr6qG6Y+JSvlsGYsYkA0CU5fr2s3Orr3m7gxe63tUj8ZgpbbN4aPR DaKwgUR1/eOT7kTNsfjO9PGFeIjMnjTkQ2NfUDWAmKUmAipngwxG/kOZoh1FrwE43opvEo1xRhHtY QjZQLyHYGUFZUdemaG0IC22A9A2OY8ACGhtRC08ovKNbux9/6xUd7nWkuDK52ZWIjGKvMJ/P/6hDV KNqLePICsO+50g==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Maxim Cournoyer Subject: Re: [bug#74542] [PATCH v2 05/16] packages: Factorize =?utf-8?Q?=E2=80=98all-packages=E2=80=99=2E?= In-Reply-To: <87jzcmhz0m.fsf@gmail.com> (Maxim Cournoyer's message of "Fri, 29 Nov 2024 23:53:45 +0900") References: <8bcbbc485aa264424b29ea873fee3e2b6aa30008.1732872498.git.ludo@gnu.org> <87jzcmhz0m.fsf@gmail.com> Date: Sun, 01 Dec 2024 17:37:05 +0100 Message-ID: <874j3ns6ku.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74542 Cc: Josselin Poiret , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , 74542@debbugs.gnu.org, Christopher Baines X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Maxim Cournoyer skribis: >> @@ -253,6 +254,23 @@ (define* (fold-packages proc init >> init >> modules)) >>=20=20 >> +(define all-packages >> + (mlambda () >> + "Return the list of all public packages, including replacements and= hidden >> +packages, excluding superseded packages." > > Reading the above doc made me question; are replacements always supposed > to be made public? I typically would leave them private to avoid > cluttering the CLI with duplicate packages. Replacements are always reachable via the =E2=80=98replacement=E2=80=99 fie= ld, whether they=E2=80=99re public or not. If they=E2=80=99re public, they=E2=80=99re also visible from the user inter= face, which is probably nicer. Other than that, it doesn=E2=80=99t make a big differen= ce. Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 01 14:19:03 2024 Received: (at 74542-done) by debbugs.gnu.org; 1 Dec 2024 19:19:03 +0000 Received: from localhost ([127.0.0.1]:53109 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHpTD-0003Cy-9V for submit@debbugs.gnu.org; Sun, 01 Dec 2024 14:19:03 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50482) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHpTB-0003CP-3g for 74542-done@debbugs.gnu.org; Sun, 01 Dec 2024 14:19:02 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tHpQw-0008Qf-8u; Sun, 01 Dec 2024 14:16:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=y5f03gkbKZPtjgl3U28PQGpWaE7/svxMsXeRY9r9tXI=; b=kyC7GlR0Yc6kpk+7zQ73 gMToztCgiSCsHltuCIYisHjkPVsXM0vY0KYwQGRfyqkUgc7cZrZQcuB96PkqbsDf93sq1NgGJugAJ iKdvLwoSSE8sEHam3SLWx2mhkPoWYTGQnwqWbFTHXTrkyw0/rUds+AO+WZKskcxp2oOxb1xswU6KT 7eZKFcwWl3j8Q8rJY4PS0krW11+eSJuQG/s0nwrsriyGq2tL8Mt6/V4RzDgXfyly9cJDBh0C/xIgb Faavigchy/9VuJXk49R5xCd67vvP5+q+V0iXwW/RI2hRAKI1mq1zDxiaBABBrhsZKHjeMlDpjCQD4 Yqjl9iA9WWgphA==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: 74542-done@debbugs.gnu.org Subject: Re: [bug#74542] [PATCH v2 00/16] Improved tooling for package updates In-Reply-To: ("Ludovic =?utf-8?Q?Court?= =?utf-8?Q?=C3=A8s=22's?= message of "Fri, 29 Nov 2024 10:40:03 +0100") References: Date: Sun, 01 Dec 2024 20:16:36 +0100 Message-ID: <8734j7qkmj.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74542-done Cc: Josselin Poiret , Maxim Cournoyer , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , Christopher Baines , Suhail Singh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Ludovic Court=C3=A8s skribis: > transformations: Export =E2=80=98package-with-upstream-version=E2=80=99. > gnu-maintenance: =E2=80=98import-html-release=E2=80=99 doesn=E2=80=99t = abort upon HTTP 404. > gnu-maintenance: Savannah/Xorg updaters no longer abort on network > errors. > guix build: Add =E2=80=98--development=E2=80=99 option. > packages: Factorize =E2=80=98all-packages=E2=80=99. > guix build: Add =E2=80=98--dependents=E2=80=99. > import: gnome: Keep going upon HTTP errors. > gnu-maintenance: =E2=80=98gnu-ftp=E2=80=99 updater excludes GnuPG-hoste= d packages. > gnu: Update updater properties for GnuPG-related packages. > gnu: gnutls: Change release monitoring URL. > gnu: git-minimal: Add =E2=80=98upstream-name=E2=80=99 property. > gnu-maintenance: =E2=80=98generic-html=E2=80=99 update honors . > guix build: Validate that the file passed to =E2=80=98-m=E2=80=99 retur= ns a manifest. > transformations: =E2=80=98package-with-upstream-version=E2=80=99 can pr= eserve patches. > transformations: Add #:authenticate? to > =E2=80=98package-with-upstream-version=E2=80=99. > etc: Add upgrade manifest. Pushed as 858dd7e721d69a6087375395037a86640418f1fb. Thanks Simon, Suhail, and Maxim! Ludo'. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 01 19:11:14 2024 Received: (at 74542) by debbugs.gnu.org; 2 Dec 2024 00:11:14 +0000 Received: from localhost ([127.0.0.1]:53534 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHu1y-0001DV-Gy for submit@debbugs.gnu.org; Sun, 01 Dec 2024 19:11:14 -0500 Received: from mail-qv1-f66.google.com ([209.85.219.66]:61643) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHu1v-0001DK-Cz for 74542@debbugs.gnu.org; Sun, 01 Dec 2024 19:11:12 -0500 Received: by mail-qv1-f66.google.com with SMTP id 6a1803df08f44-6d88c6d0fa3so19263206d6.2 for <74542@debbugs.gnu.org>; Sun, 01 Dec 2024 16:11:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733098211; x=1733703011; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qgKOc336foNNwkWZrYGPEZFkRfZKCt789zg6EXvPOy0=; b=Ggyu+ulznZ8EijV2u+FyJX7hI2q23Rc8+kZxfZWmt8ZPkVQ+ZIU5cRJw0+dx2A7gPp IZoRtSX7ykuFLZ7umDMSgRxaVSdyyzuC29SoEDasKau9vQtIH/7zyolVtmVPjJrohVbR OR8vy7s+Lm8rNPQbtJc47dgr5HOA5ioD/g59z6bKKcQJrZ4RQ8ejlXMRT1S3L8YIJRNP 86DGJz2psiC1ASenwib1BHIc8u4Lw07VJO5VPw+arDDolgbZTzzWwLlvFBZ+Khd/Yc3Y moc5SnnLQQjA/yhmBQ0hGY7rV1PvvYxK31G0v2RqziQYLr1QdYrlMfrO6C2FU1hPvfTp IGow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733098211; x=1733703011; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=qgKOc336foNNwkWZrYGPEZFkRfZKCt789zg6EXvPOy0=; b=OvXil6G0jcBS7+6mVYyC9bPpo8Tx/dwMSyxdCLPicC2GI/rt7NWXCdNkF85Peh2N+z lgxpOjDuh1a1lYSwr8MWBmJrRz3lRFDCsiXmigfM6OgGJXkqtqd+9iPaeFSypUTCzG0O 5FBR1o9jMAJdp748/9q+DIePuPoXwcKsj3EfNYyXhfuP8noiKZCdIGVtRimYsmPljBIo jLDAAqLCeOQHAAcIcHn1vUwynHnco8v+0+sOqpQj+jWh6WLEPonvKwbwV8gAsY75fr9M xmmTKrKBP9T6gkXGPcJv7mCEn3yW/2SDlLUiurhGF9Bd4zKlE/Q6rcYYeZjKNoOR5pd7 bjsQ== X-Forwarded-Encrypted: i=1; AJvYcCVn32SlrvV1thq2Dg5TfM6QRtL45ikkI94cJ5teC/CtMZd3TdewkIbooAABfzktf8Q4pKNxog==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yzs/sVjoxv6Aq3g+TJTUhbHYTjy4EDMw5C36uCjakbn0ONHt9de D0fnBFHrUXeqBATFmnq4Xg3DqSEo3LmS24FUkW4WfOqlo0K1GK3+ X-Gm-Gg: ASbGncsmLNMU1y16VBOWgOTy5fsD4PCunZ/UapNbHN36RSAEpKA3ONzMuERHwc8pD7o HhqgDldje6VU0YjUAiOkqLKsiEtmZS98FNoPJ86qYqlsWwxO2pA76dn9E+CwbqYHm86/yBF07Ws TODDrEsyxw0IYrCnKlPH+0ADKdcxb1elb1FYB/CmCQLbLCj0jejpXV4Nszx5ntAjkY22vpDEpFh jD7rWLW3mGLM/piXgk9E3e9if0r3c44l75qU4Ka3fuKjg== X-Google-Smtp-Source: AGHT+IGpS9cPYjJyLplcwjtneDIq7THKDcAi474z9MK8UaFZ/GvmyleZlYqImRJ9gMO+YM38LAzePA== X-Received: by 2002:a05:6214:1307:b0:6d4:2fee:c27b with SMTP id 6a1803df08f44-6d864d926b0mr303169236d6.27.1733098210748; Sun, 01 Dec 2024 16:10:10 -0800 (PST) Received: from gnus ([70.26.179.129]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6d8a02c01ebsm11803346d6.42.2024.12.01.16.10.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Dec 2024 16:10:09 -0800 (PST) From: Suhail Singh To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#74542] [PATCH v2 00/16] Improved tooling for package updates In-Reply-To: <87a5dfs6pn.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Sun, 01 Dec 2024 17:34:12 +0100") References: <87ldx2rrwk.fsf@gmail.com> <87a5dfs6pn.fsf@gnu.org> Date: Sun, 01 Dec 2024 19:09:57 -0500 Message-ID: <87bjxv9c8a.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 74542 Cc: Josselin Poiret , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , 74542@debbugs.gnu.org, Christopher Baines , Suhail Singh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Ludovic Court=C3=A8s writes: >> Could we please add some minimal code to submit-patch-if-build-succeeds >> to this series? That would provide a working example of a CI job that >> interacts with debbugs/sends-emails and would allow for greater eyeballs >> on the working state of this jobset. > > Again I agree it=E2=80=99d be nice but it=E2=80=99s beyond the scope of t= his patch > series. Understandable. Hopefully, someone with commit access is able to dedicate time to it relatively soon (either by submitting the patch themselves and/or committing to reviewing and acting as a mentor to get such a change merged in a timely manner). Of course a commit access isn't necessary to work on the patch, however, given our current mean-time-to-merge for patches committer-attention is certainly a rate-limiting-step. Perhaps the related patch that provides automated build, lint, and style checks on all patch submissions may have even more value for the project. --=20 Suhail From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 06 09:01:00 2024 Received: (at 74542) by debbugs.gnu.org; 6 Dec 2024 14:01:00 +0000 Received: from localhost ([127.0.0.1]:42418 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJYt9-0002Og-3l for submit@debbugs.gnu.org; Fri, 06 Dec 2024 09:00:59 -0500 Received: from mail-qk1-f177.google.com ([209.85.222.177]:42187) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJYt0-0002OG-UG for 74542@debbugs.gnu.org; Fri, 06 Dec 2024 09:00:56 -0500 Received: by mail-qk1-f177.google.com with SMTP id af79cd13be357-7b66ea49407so185255785a.0 for <74542@debbugs.gnu.org>; Fri, 06 Dec 2024 06:00:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733493585; x=1734098385; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uib2yUPMpwZ7+8AjWLp+q9i1Gwppw3l+SPCZOKBNf2I=; b=VmSLqvES0gfmXHxBHF3if7s33Lpbr9rpizeQNLRgFbCLNtcX5JdG6FKqquneRAKvI2 +p52vYYNAjqPAnUG0wkA0F69nm1mpLx4j5ZCEBJ64e36DJvlb8Bmc/iJYt9+88m34o8d /OxsGuUp1LusMzo8NJn6GLURyt//KAnjZovrKuR5GPiJsgI6MXyKYW6KLfa76j1NlLHA YV/aFJrvVE9YD1qXWb1dzstph2oI/d3p+TgzIh+8E1Fl2xBxGoaiYig1ZLYQXm1rn7P4 OtNYx1GDClMTU30bs1ZWfvonO6YOEAkUUUPBlcpU+tq1S+azdjttzxyxN8XRjsFhH5vY gaLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733493585; x=1734098385; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=uib2yUPMpwZ7+8AjWLp+q9i1Gwppw3l+SPCZOKBNf2I=; b=XBBqp0cROnUi/AY+eke2Cd/Cs1iZJno8EGfWLAh47dbITGQ2rJSfvAHkqd77s8TM4M PBeXzCI/D7th8qL+R5JnlFU0JAwfd4dqBQZdxbJUOCq2M5f0nzA3xLJPJ8+0KIC/UFLH 2RQ6WKJ6LRyTQw/n/61mDwUzqZ0Of7sCjQiCW0cvOGq+3zXHVDQrhkijTySx9MC4L9XH nPcVTrdV9TJcENCt1ZFmdwgC2BdR0SswdscxZZKNiNMtEb30pnx+0cEWiMNCIxzIiuvD 0P6GNvHxG1B0q4cIciXzaiI/9jRzSVm/5w+Mb2MsMlBanHZIGuz8vCSRcNWvLsS+Jq2K P/vA== X-Forwarded-Encrypted: i=1; AJvYcCW04RXrALYfm+Q0dsNnnZ7747BnzAU/LmS8jXM6ECyHfO7g0KP8syIbHtzJ9hB3ze3HnVTeOA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyhrUXlxL2ZrS/H7PUbPfTbd01ozeSoS8G4i+6sA5KyBx/AhvuJ pT7rD4j6OWNjwsv5MdNQ17NxrF6r/FrxQ5e6z6E7LJwkDgr+tISV X-Gm-Gg: ASbGncvXlsOCths3v45n2q5QLFgNo+MwwlT0eAXQ2w5ZlqvawflAefiDqokTutsb3LN kaq2Eh91lMUoJViJW6jfCm8mB1Ap86v0r00kbXY0r7jCvzYEEWkP+A6+13lGkWxBSRzi7q2VeW4 z5t04p52/60n+YnqordMzPr8Xa5Y3Yy/gzA/fKNrdC2J7JOMbFM1tdINsn4UAuYSv3DaPLIGVJu gkTtqhWduUov7pbV7R4zX08YfhvGHDn8feMYE6T0Q3XwIo1ODdvi+ernfV/q/gWXcOsPJs= X-Google-Smtp-Source: AGHT+IHOsmutyijzBalNXDHdBKlY0p/UIfpO8RKuUiD1Agu8FEjJAuKet0ydhYQMlJOfSmFyrjn0cw== X-Received: by 2002:a05:620a:1a90:b0:7a9:b82e:723a with SMTP id af79cd13be357-7b6bc9a7a54mr365020085a.31.1733493585199; Fri, 06 Dec 2024 05:59:45 -0800 (PST) Received: from terra (vps-6234970c.vps.ovh.ca. [51.222.13.224]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7b6b5a51868sm174582785a.2.2024.12.06.05.59.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Dec 2024 05:59:44 -0800 (PST) From: Maxim Cournoyer To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#74542] [PATCH v2 05/16] packages: Factorize =?utf-8?Q?=E2=80=98all-packages=E2=80=99=2E?= In-Reply-To: <874j3ns6ku.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Sun, 01 Dec 2024 17:37:05 +0100") References: <8bcbbc485aa264424b29ea873fee3e2b6aa30008.1732872498.git.ludo@gnu.org> <87jzcmhz0m.fsf@gmail.com> <874j3ns6ku.fsf@gnu.org> Date: Fri, 06 Dec 2024 22:59:34 +0900 Message-ID: <874j3glxo9.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74542 Cc: Josselin Poiret , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , 74542@debbugs.gnu.org, Christopher Baines X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Ludovic, Ludovic Court=C3=A8s writes: > Maxim Cournoyer skribis: > >>> @@ -253,6 +254,23 @@ (define* (fold-packages proc init >>> init >>> modules)) >>>=20=20 >>> +(define all-packages >>> + (mlambda () >>> + "Return the list of all public packages, including replacements an= d hidden >>> +packages, excluding superseded packages." >> >> Reading the above doc made me question; are replacements always supposed >> to be made public? I typically would leave them private to avoid >> cluttering the CLI with duplicate packages. > > Replacements are always reachable via the =E2=80=98replacement=E2=80=99 f= ield, whether > they=E2=80=99re public or not. > > If they=E2=80=99re public, they=E2=80=99re also visible from the user int= erface, which > is probably nicer. Other than that, it doesn=E2=80=99t make a big differ= ence. I see, thanks for explaining. Assuming they have the same name, the interface for 'guix search $name' would now should two versions available, while in theory if you 'guix shell $name@older-version' you'd get the graft anyway, which is at the newer (fixed) version. And, 'guix build $name', although the CLI would say version is Y, would actually show version X in the store, which could be confusing in some cases. Both have good and bad points... I'm not too sure which one is preferable. Probably, as you said, seeing the newest version which is used on the CLI is preferable to seeing the same version match in the package store file name, so I think I'll make replacements public from now on... another thing to document some day! --=20 Thanks, Maxim From unknown Mon Jun 23 02:22:16 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 04 Jan 2025 12:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator