GNU bug report logs - #74539
[PATCH] tests: fix define for glibc-infloop

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 74539 in the body.
You can then email your comments to 74539 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Grisha Levit <grishalevit <at> gmail.com>
To: bug-grep <at> gnu.org
Cc: Grisha Levit <grishalevit <at> gmail.com>
Subject: [PATCH] tests: fix define for glibc-infloop
Date: Mon, 25 Nov 2024 17:02:38 -0500

This doesn't affect anything right now since the value is only examined
by an unconditionally skipped test.

* configure.ac (USE_INCLUDED_REGEX): fix condition for definition.
---
 configure.ac | 1 +
 1 file changed, 1 insertion(+)

diff --git a/configure.ac b/configure.ac
index 88b26c1..5e0a89c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -210,6 +210,7 @@ dnl then the installer should configure --with-included-regex.
 AM_CONDITIONAL([USE_INCLUDED_REGEX], [test "$ac_use_included_regex" = yes])
 if test "$ac_use_included_regex" = no; then
   AC_MSG_WARN([Included lib/regex.c not used])
+else
   AC_DEFINE([USE_INCLUDED_REGEX], 1, [building with included regex code])
 fi
 
-- 
2.47.0

Message #8 received at 74539 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Grisha Levit <grishalevit <at> gmail.com>
Cc: 74539 <at> debbugs.gnu.org
Subject: Re: bug#74539: [PATCH] tests: fix define for glibc-infloop
Date: Tue, 26 Nov 2024 16:19:20 -0800

On Mon, Nov 25, 2024 at 2:03 PM Grisha Levit <grishalevit <at> gmail.com> wrote:
> This doesn't affect anything right now since the value is only examined
> by an unconditionally skipped test.
>
> * configure.ac (USE_INCLUDED_REGEX): fix condition for definition.
> ---
>  configure.ac | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/configure.ac b/configure.ac
> index 88b26c1..5e0a89c 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -210,6 +210,7 @@ dnl then the installer should configure --with-included-regex.
>  AM_CONDITIONAL([USE_INCLUDED_REGEX], [test "$ac_use_included_regex" = yes])
>  if test "$ac_use_included_regex" = no; then
>    AC_MSG_WARN([Included lib/regex.c not used])
> +else
>    AC_DEFINE([USE_INCLUDED_REGEX], 1, [building with included regex code])
>  fi

Thank you. I've pushed that.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.