From unknown Thu Jun 19 14:03:53 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#74518 <74518@debbugs.gnu.org> To: bug#74518 <74518@debbugs.gnu.org> Subject: Status: 29.4; ERC 5.6: `undo' regression on Erc 5.6 Reply-To: bug#74518 <74518@debbugs.gnu.org> Date: Thu, 19 Jun 2025 21:03:53 +0000 retitle 74518 29.4; ERC 5.6: `undo' regression on Erc 5.6 reassign 74518 emacs submitter 74518 Alcor severity 74518 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 24 17:25:41 2024 Received: (at submit) by debbugs.gnu.org; 24 Nov 2024 22:25:41 +0000 Received: from localhost ([127.0.0.1]:36382 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFL2y-0007Bc-EI for submit@debbugs.gnu.org; Sun, 24 Nov 2024 17:25:41 -0500 Received: from lists.gnu.org ([209.51.188.17]:44792) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFL2v-0007BO-EN for submit@debbugs.gnu.org; Sun, 24 Nov 2024 17:25:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tFL2u-0003xP-04 for bug-gnu-emacs@gnu.org; Sun, 24 Nov 2024 17:25:36 -0500 Received: from tilde.club ([142.44.150.184]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tFL2r-0006LT-Ll for bug-gnu-emacs@gnu.org; Sun, 24 Nov 2024 17:25:35 -0500 Received: from osiris.tilde.club (unknown [IPv6:2001:9e8:7ff:6800:5430:5b9:886b:f557]) by tilde.club (Postfix) with ESMTPSA id 90F69220489A4 for ; Sun, 24 Nov 2024 22:25:30 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 tilde.club 90F69220489A4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tilde.club; s=mail; t=1732487130; bh=sqn7pUWkdPwpmQRy5ltuIkhaywKQQX7NDySK1Y9a/VA=; h=From:To:Subject:Date:From; b=GghF4whQyi1OmnPt8Vy97ilX0e8MRLEunMhbEdd47c4nH03a3wTreToBmILieQ5Qs 3IsuL8eTapezO8AOYE25c2blh7LRzYvvIRk3RqZheowezSozQ3qAui0yOcGmJ+RLs/ W+2RHMz/t2x6dX8AM8ADS48CXo+wRskSkEDcnE+Y= From: Alcor To: bug-gnu-emacs@gnu.org Subject: 29.4; ERC 5.6: `undo' regression on Erc 5.6 X-Debbugs-CC: emacs-erc@gnu.org Date: Sun, 24 Nov 2024 23:25:25 +0100 Message-ID: <87iksc46cq.fsf@tilde.club> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=142.44.150.184; envelope-from=alcor@tilde.club; helo=tilde.club X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_SBL_A=0.1 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) 1. Start from a clean Emacs installation (-Q or default config). 2. Install the latest stable version of Erc via C-u M-x package-install erc RET (At the time of writing, this is Erc 5.6). 3. Connect to Libera.Chat under any nick. 4. Once connected, type /QUERY fsbot and hit RET. 5. Interact with the bot in any way that forces a reply (e.g. type ,greet RET). 6. Wait for the bot to reply. 7. Trigger the undo function via M-x undo or C-x u. 8. Observe as the undo affects the reply text inserted by the bot. This is a regression from Erc 5.5, where `undo' only affected the text typed by the user within the input prompt. In GNU Emacs 29.4 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.20, cairo version 1.16.0) of 2024-06-24 built on lcy02-amd64-050 Repository revision: 176061eb965cf945e7627ce87bb16ec5a03f8a4d Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12302006 System Description: Ubuntu 24.04.1 LTS Configured using: 'configure --prefix=/snap/emacs/current/usr --with-x-toolkit=gtk3 --without-xaw3d --with-modules --with-cairo --with-native-compilation=aot --without-pgtk --with-xinput2 --with-tree-sitter --with-json 'CFLAGS=-isystem/build/emacs/parts/emacs/install/usr/include -isystem/build/emacs/parts/emacs/install/usr/include/x86_64-linux-gnu -isystem/build/emacs/stage/usr/include -O2' 'CPPFLAGS=-isystem/build/emacs/parts/emacs/install/usr/include -isystem/build/emacs/parts/emacs/install/usr/include/x86_64-linux-gnu -isystem/build/emacs/stage/usr/include' 'LDFLAGS=-L/build/emacs/parts/emacs/install/lib -L/build/emacs/parts/emacs/install/usr/lib -L/build/emacs/parts/emacs/install/lib/x86_64-linux-gnu -L/build/emacs/parts/emacs/install/usr/lib/x86_64-linux-gnu -L/build/emacs/stage/usr/lib'' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB Important settings: value of $LC_MONETARY: de_DE.UTF-8 value of $LC_NUMERIC: de_DE.UTF-8 value of $LC_TIME: de_DE.UTF-8 value of $LANG: de_DE.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: Org Minor modes in effect: erc-services-mode: t erc-ring-mode: t erc-notifications-mode: t erc-netsplit-mode: t erc-menu-mode: t erc-list-mode: t erc-irccontrols-mode: t erc-keep-place-mode: t erc-move-to-prompt-mode: t erc-readonly-mode: t erc-scrolltobottom-mode: t erc-imenu-mode: t erc-button-mode: t erc-fill-mode: t erc-stamp-mode: t erc-bufbar-mode: t erc-track-mode: t erc-match-mode: t erc-autojoin-mode: t erc-autoaway-mode: t erc-networks-mode: t whitespace-mode: t display-line-numbers-mode: t goto-address-mode: t which-key-mode: t winner-mode: t windmove-mode: t recentf-mode: t global-auto-revert-mode: t fido-vertical-mode: t icomplete-vertical-mode: t icomplete-mode: t fido-mode: t desktop-save-mode: t minibuffer-depth-indicate-mode: t pixel-scroll-precision-mode: t delete-selection-mode: t override-global-mode: t tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t prettify-symbols-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t column-number-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: /home/alcor/.emacs.d/elpa/transient-0.7.7/transient hides /snap/emacs/current/usr/share/emacs/29.4/lisp/transient /home/alcor/.emacs.d/elpa/erc-5.6/erc hides /snap/emacs/current/usr/share/emacs/29.4/lisp/erc/erc /home/alcor/.emacs.d/elpa/erc-5.6/erc-xdcc hides /snap/emacs/current/usr/share/emacs/29.4/lisp/erc/erc-xdcc /home/alcor/.emacs.d/elpa/erc-5.6/erc-truncate hides /snap/emacs/current/usr/share/emacs/29.4/lisp/erc/erc-truncate /home/alcor/.emacs.d/elpa/erc-5.6/erc-track hides /snap/emacs/current/usr/share/emacs/29.4/lisp/erc/erc-track /home/alcor/.emacs.d/elpa/erc-5.6/erc-status-sidebar hides /snap/emacs/current/usr/share/emacs/29.4/lisp/erc/erc-status-sidebar /home/alcor/.emacs.d/elpa/erc-5.6/erc-stamp hides /snap/emacs/current/usr/share/emacs/29.4/lisp/erc/erc-stamp /home/alcor/.emacs.d/elpa/erc-5.6/erc-spelling hides /snap/emacs/current/usr/share/emacs/29.4/lisp/erc/erc-spelling /home/alcor/.emacs.d/elpa/erc-5.6/erc-speedbar hides /snap/emacs/current/usr/share/emacs/29.4/lisp/erc/erc-speedbar /home/alcor/.emacs.d/elpa/erc-5.6/erc-sound hides /snap/emacs/current/usr/share/emacs/29.4/lisp/erc/erc-sound /home/alcor/.emacs.d/elpa/erc-5.6/erc-services hides /snap/emacs/current/usr/share/emacs/29.4/lisp/erc/erc-services /home/alcor/.emacs.d/elpa/erc-5.6/erc-sasl hides /snap/emacs/current/usr/share/emacs/29.4/lisp/erc/erc-sasl /home/alcor/.emacs.d/elpa/erc-5.6/erc-ring hides /snap/emacs/current/usr/share/emacs/29.4/lisp/erc/erc-ring /home/alcor/.emacs.d/elpa/erc-5.6/erc-replace hides /snap/emacs/current/usr/share/emacs/29.4/lisp/erc/erc-replace /home/alcor/.emacs.d/elpa/erc-5.6/erc-pcomplete hides /snap/emacs/current/usr/share/emacs/29.4/lisp/erc/erc-pcomplete /home/alcor/.emacs.d/elpa/erc-5.6/erc-page hides /snap/emacs/current/usr/share/emacs/29.4/lisp/erc/erc-page /home/alcor/.emacs.d/elpa/erc-5.6/erc-notify hides /snap/emacs/current/usr/share/emacs/29.4/lisp/erc/erc-notify /home/alcor/.emacs.d/elpa/erc-5.6/erc-networks hides /snap/emacs/current/usr/share/emacs/29.4/lisp/erc/erc-networks /home/alcor/.emacs.d/elpa/erc-5.6/erc-netsplit hides /snap/emacs/current/usr/share/emacs/29.4/lisp/erc/erc-netsplit /home/alcor/.emacs.d/elpa/erc-5.6/erc-menu hides /snap/emacs/current/usr/share/emacs/29.4/lisp/erc/erc-menu /home/alcor/.emacs.d/elpa/erc-5.6/erc-match hides /snap/emacs/current/usr/share/emacs/29.4/lisp/erc/erc-match /home/alcor/.emacs.d/elpa/erc-5.6/erc-log hides /snap/emacs/current/usr/share/emacs/29.4/lisp/erc/erc-log /home/alcor/.emacs.d/elpa/erc-5.6/erc-loaddefs hides /snap/emacs/current/usr/share/emacs/29.4/lisp/erc/erc-loaddefs /home/alcor/.emacs.d/elpa/erc-5.6/erc-list hides /snap/emacs/current/usr/share/emacs/29.4/lisp/erc/erc-list /home/alcor/.emacs.d/elpa/erc-5.6/erc-lang hides /snap/emacs/current/usr/share/emacs/29.4/lisp/erc/erc-lang /home/alcor/.emacs.d/elpa/erc-5.6/erc-join hides /snap/emacs/current/usr/share/emacs/29.4/lisp/erc/erc-join /home/alcor/.emacs.d/elpa/erc-5.6/erc-imenu hides /snap/emacs/current/usr/share/emacs/29.4/lisp/erc/erc-imenu /home/alcor/.emacs.d/elpa/erc-5.6/erc-identd hides /snap/emacs/current/usr/share/emacs/29.4/lisp/erc/erc-identd /home/alcor/.emacs.d/elpa/erc-5.6/erc-ibuffer hides /snap/emacs/current/usr/share/emacs/29.4/lisp/erc/erc-ibuffer /home/alcor/.emacs.d/elpa/erc-5.6/erc-goodies hides /snap/emacs/current/usr/share/emacs/29.4/lisp/erc/erc-goodies /home/alcor/.emacs.d/elpa/erc-5.6/erc-fill hides /snap/emacs/current/usr/share/emacs/29.4/lisp/erc/erc-fill /home/alcor/.emacs.d/elpa/erc-5.6/erc-ezbounce hides /snap/emacs/current/usr/share/emacs/29.4/lisp/erc/erc-ezbounce /home/alcor/.emacs.d/elpa/erc-5.6/erc-desktop-notifications hides /snap/emacs/current/usr/share/emacs/29.4/lisp/erc/erc-desktop-notifications /home/alcor/.emacs.d/elpa/erc-5.6/erc-dcc hides /snap/emacs/current/usr/share/emacs/29.4/lisp/erc/erc-dcc /home/alcor/.emacs.d/elpa/erc-5.6/erc-compat hides /snap/emacs/current/usr/share/emacs/29.4/lisp/erc/erc-compat /home/alcor/.emacs.d/elpa/erc-5.6/erc-common hides /snap/emacs/current/usr/share/emacs/29.4/lisp/erc/erc-common /home/alcor/.emacs.d/elpa/erc-5.6/erc-capab hides /snap/emacs/current/usr/share/emacs/29.4/lisp/erc/erc-capab /home/alcor/.emacs.d/elpa/erc-5.6/erc-button hides /snap/emacs/current/usr/share/emacs/29.4/lisp/erc/erc-button /home/alcor/.emacs.d/elpa/erc-5.6/erc-backend hides /snap/emacs/current/usr/share/emacs/29.4/lisp/erc/erc-backend /home/alcor/.emacs.d/elpa/erc-5.6/erc-autoaway hides /snap/emacs/current/usr/share/emacs/29.4/lisp/erc/erc-autoaway Features: (shadow sort mail-extr gnus-msg emacsbug erc-services erc-ring erc-desktop-notifications notifications erc-nicks color erc-netsplit erc-menu erc-list erc-goodies erc-imenu imenu erc-pcomplete erc-button erc-fill erc-stamp erc-status-sidebar erc-track erc-match erc-join erc-autoaway cus-start erc erc-backend erc-networks erc-common erc-compat compat compat-30 erc-loaddefs disp-table whitespace display-line-numbers goto-addr org-element org-persist org-id org-refile avl-tree generator oc-basic ol-eww eww url-queue thingatpt mm-url ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect gnus-art mm-uu mml2015 mm-view mml-smime smime gnutls dig gnus-sum shr pixel-fill kinsoku url-file svg dom gnus-group gnus-undo gnus-start gnus-dbus dbus xml gnus-cloud nnimap nnmail mail-source utf7 nnoo parse-time gnus-spec gnus-int gnus-range message yank-media puny rfc822 mml mml-sec epa derived epg rfc6068 epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader gnus-win ol-docview doc-view jka-compr image-mode exif dired dired-loaddefs ol-bibtex bibtex iso8601 ol-bbdb ol-w3m ol-doi org-link-doi org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-src ob-comint org-pcomplete pcomplete comint ansi-osc ansi-color org-list org-footnote org-faces org-entities noutline outline ob-emacs-lisp ob-core ob-eval org-cycle org-table ol org-fold org-fold-core org-keys oc org-loaddefs find-func cal-menu calendar cal-loaddefs org-version org-compat org-macs format-spec leuven-dark-theme sendmail rfc2047 rfc2045 ietf-drums gnus nnheader gnus-util text-property-search time-date mail-utils range mm-util mail-prsvr xdg which-key use-package-ensure cus-edit pp winner windmove recentf tree-widget wid-edit autorevert filenotify icomplete desktop frameset mb-depth pixel-scroll cua-base ring delsel cus-load edmacro kmacro use-package-bind-key bind-key easy-mmode use-package-core site-start comp comp-cstr warnings icons rx cl-extra help-mode erc-irc-format-autoloads erc-autoloads markdown-mode-autoloads rainbow-delimiters-autoloads transient-autoloads info compat-autoloads which-key-autoloads package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit xinput2 x multi-tty make-network-process native-compile emacs) Memory information: ((conses 16 357579 13732) (symbols 48 27860 0) (strings 32 95904 3730) (string-bytes 1 3061178) (vectors 16 50450) (vector-slots 8 881379 27615) (floats 8 532 363) (intervals 56 597 0) (buffers 984 11)) From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 24 18:43:52 2024 Received: (at 74518) by debbugs.gnu.org; 24 Nov 2024 23:43:52 +0000 Received: from localhost ([127.0.0.1]:36500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFMGe-0002RC-3l for submit@debbugs.gnu.org; Sun, 24 Nov 2024 18:43:52 -0500 Received: from mail-108-mta46.mxroute.com ([136.175.108.46]:46739) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFMGZ-0002Qz-FO for 74518@debbugs.gnu.org; Sun, 24 Nov 2024 18:43:50 -0500 Received: from filter006.mxroute.com ([136.175.111.3] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta46.mxroute.com (ZoneMTA) with ESMTPSA id 193608f4d9d0003e01.001 for <74518@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Sun, 24 Nov 2024 23:43:44 +0000 X-Zone-Loop: f1ac75a5164ab05527d64756ab937b040bf552db1e27 X-Originating-IP: [136.175.111.3] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=aP4I6WRgtW0Ds15bc6n6y3y96BG8fgYU2q7f7NuRVW0=; b=V0C31YqyxqT7BWUbzF/AOKLeKQ /da+NYxMb4yAgPRi71NVlUDoLEHYYT6fL+I7S1Su0fkN6I6eG60oJAq6UBTzYZl9Al3DJTfAQvd2x cc4xTOTbsGy45WCLXIMOZV1V1hrdGi16tnmRXrh+hQavF05zLYH+AOutKYnfWyPX2vcd5bLnw8+fo edE/ff2Woo8u0ljrnqi5eBr+bkwe5ls71vYMEwnH93WB68n3lgxyQ/zzmHit6mUDgd2b6Pcd+4jCX Gv4IkmnZ4NucvVv4PoG2Q16tnNaJWk07QVqt6kD+fNo3uIU5vi0TOTIHK1+bC6Hv+YiYWBlzRlkOD nNljC6kA==; From: "J.P." To: Alcor Subject: Re: bug#74518: 29.4; ERC 5.6: `undo' regression on Erc 5.6 In-Reply-To: <87iksc46cq.fsf@tilde.club> (Alcor via General discussion about's message of "Sun, 24 Nov 2024 23:25:25 +0100") References: <87iksc46cq.fsf@tilde.club> Date: Sun, 24 Nov 2024 15:43:41 -0800 Message-ID: <87o724jiz6.fsf@neverwas.me> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Authenticated-Id: masked@neverwas.me X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74518 Cc: emacs-erc@gnu.org, 74518@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Alcor via General discussion about ERC writes: > 1. Start from a clean Emacs installation (-Q or default config). > 2. Install the latest stable version of Erc via C-u M-x package-install > erc RET (At the time of writing, this is Erc 5.6). > 3. Connect to Libera.Chat under any nick. > 4. Once connected, type /QUERY fsbot and hit RET. > 5. Interact with the bot in any way that forces a reply (e.g. type > ,greet RET). > 6. Wait for the bot to reply. > 7. Trigger the undo function via M-x undo or C-x u. > 8. Observe as the undo affects the reply text inserted by the bot. > > This is a regression from Erc 5.5, where `undo' only affected the text > typed by the user within the input prompt. Thanks for reporting this. Hoping this patch will address the issue. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Clear-buffer-undo-list-after-sending-input-in-ERC.patch >From 45180df71fc636d086ff87d70d377263688a133f Mon Sep 17 00:00:00 2001 From: "F. Jason Park" Date: Sun, 24 Nov 2024 15:30:02 -0800 Subject: [PATCH] Clear buffer-undo-list after sending input in ERC * lisp/erc/erc.el (erc-send-current-line): Set `buffer-undo-list' to nil because it should only record editing changes in the prompt area, which has just been cleared. ERC did this via `erc-display-prompt' prior to 5.6, but it now leaves the prompt alone by default. (Bug#74518) --- lisp/erc/erc.el | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el index 7028d0a68cc..c6978728dd6 100644 --- a/lisp/erc/erc.el +++ b/lisp/erc/erc.el @@ -8200,10 +8200,9 @@ erc-send-current-line ;; Fix the buffer if the command didn't kill it (when (buffer-live-p old-buf) (with-current-buffer old-buf - (save-restriction - (widen) - (let ((buffer-modified (buffer-modified-p))) - (set-buffer-modified-p buffer-modified)))))) + (setq buffer-undo-list nil) + ;; `set-buffer-modified-p' used to do this here. + (force-mode-line-update)))) ;; Only when last hook has been run... (run-hook-with-args 'erc-send-completed-hook str))) -- 2.47.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 25 02:19:39 2024 Received: (at 74518) by debbugs.gnu.org; 25 Nov 2024 07:19:39 +0000 Received: from localhost ([127.0.0.1]:37656 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFTNj-0007fZ-8C for submit@debbugs.gnu.org; Mon, 25 Nov 2024 02:19:39 -0500 Received: from tilde.club ([142.44.150.184]:48124 ident=postfix) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFTNh-0007fM-Cb for 74518@debbugs.gnu.org; Mon, 25 Nov 2024 02:19:38 -0500 Received: from osiris.tilde.club (unknown [IPv6:2001:9e8:7c7:800:8c22:cb1e:2cfb:bc76]) by tilde.club (Postfix) with ESMTPSA id DC89F22048985; Mon, 25 Nov 2024 07:19:35 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 tilde.club DC89F22048985 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tilde.club; s=mail; t=1732519176; bh=DiRPdjJLZHSjaoeTnK/d30j4Xx609eHFnnzErQW9Ppg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=NQLYFjqvdEQjZIA7z8fBnRr+Z5oH+LsThpwB7oWnqIoCEH/9Bb87uYJzYB/QvaeQv 9Q+xm9yzHkzxtMr8GP83uQquI2IhRQU1LCWtvkznren2p7dYzGdFpbmuivUPxDKXOy OgNRI9iIdKHEOkjUL0hND043bH7BlNnHEiFPUm9g= From: Alcor To: "J.P." Subject: Re: bug#74518: 29.4; ERC 5.6: `undo' regression on Erc 5.6 In-Reply-To: <87o724jiz6.fsf@neverwas.me> (J. P.'s message of "Sun, 24 Nov 2024 15:43:41 -0800") References: <87iksc46cq.fsf@tilde.club> <87o724jiz6.fsf@neverwas.me> Date: Mon, 25 Nov 2024 08:19:29 +0100 Message-ID: <87frnfvkzi.fsf@tilde.club> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74518 Cc: emacs-erc@gnu.org, 74518@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) "J.P." writes: Hi J.P., > Hoping this patch will address the issue. After applying the patch to Erc 5.6 (as released on ELPA), I can confirm it does fix the issue. Thanks :) Cheers, -A. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 01 22:52:33 2024 Received: (at 74518-done) by debbugs.gnu.org; 2 Dec 2024 03:52:33 +0000 Received: from localhost ([127.0.0.1]:53789 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHxU9-0003w6-9i for submit@debbugs.gnu.org; Sun, 01 Dec 2024 22:52:33 -0500 Received: from mail-108-mta95.mxroute.com ([136.175.108.95]:38805) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHxU6-0003vr-Du for 74518-done@debbugs.gnu.org; Sun, 01 Dec 2024 22:52:31 -0500 Received: from filter006.mxroute.com ([136.175.111.3] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta95.mxroute.com (ZoneMTA) with ESMTPSA id 193857f8a080003e01.001 for <74518-done@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Mon, 02 Dec 2024 03:52:28 +0000 X-Zone-Loop: 15040ba3cd4b3cd0a47497a9315c3e1b4a544df8ba4a X-Originating-IP: [136.175.111.3] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=VymMnQ//BERVbi36imxevQVUcKQ/IYDlPRHgoZjXH0E=; b=UzrGovKCekgsUfnFEffw//bJay PhF8ZWB2k+Ta6noJDDW1NjDjfZ5tn8NXF2LbQvihsbrMY3dQogqFN7j90mt/KO/obMUjr9mhz5l4Q 1W6RqScpQ/DBISvAibBTzD0NJtwz04nyCmrnWMef8KD9I4AX3o1JLjSCohnXp5fRPC+omO/5IwNKV yr2wywt5EnFVpmzYQ1jPS3nSMjJ4W9I72WqS8hCFY958rEbYXNN++/4nOVQhZv3+gSHZk01NFmODM UxmWKtdjqb2T9+dGpD37c71FiyVUsUXDn5SD+XzM7+jpI+KPHMkkHuvdMF3goyeipHvhB1zuO7L3v eXdQXcOA==; From: "J.P." To: Alcor Subject: Re: bug#74518: 29.4; ERC 5.6: `undo' regression on Erc 5.6 In-Reply-To: <87frnfvkzi.fsf@tilde.club> (alcor@tilde.club's message of "Mon, 25 Nov 2024 08:19:29 +0100") References: <87iksc46cq.fsf@tilde.club> <87o724jiz6.fsf@neverwas.me> <87frnfvkzi.fsf@tilde.club> Date: Sun, 01 Dec 2024 19:52:25 -0800 Message-ID: <87y10ybv2e.fsf@neverwas.me> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Authenticated-Id: masked@neverwas.me X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74518-done Cc: emacs-erc@gnu.org, 74518-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Alcor writes: > "J.P." writes: > > Hi J.P., > >> Hoping this patch will address the issue. > > After applying the patch to Erc 5.6 (as released on ELPA), I can confirm > it does fix the issue. Thanks :) > > Cheers, > -A. Installed as https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=e0d2c6f2 Thanks and closing. From unknown Thu Jun 19 14:03:53 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 30 Dec 2024 12:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator