GNU bug report logs - #74508
[PATCH 0/2] Improvements for mingetty-service-type

Previous Next

Full log

View this message in rfc822 format

From: Tomas Volf <~@wolfsden.cz>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 74508 <at> debbugs.gnu.org, Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: [bug#74508] [PATCH v2 1/3] services: mingetty: Add additional configuration options.
Date: Tue, 03 Dec 2024 01:18:11 +0100

[Message part 1 (text/plain, inline)]

Ludovic Courtès <ludo <at> gnu.org> writes:

> Hi,
>
> Tomas Volf <~@wolfsden.cz> skribis:
>
>> +@item @code{chdir} (default: @code{#f})
>> +When set to a string, change into that directory before calling the
>> +login program.
>> +
>> +@item @code{chroot} (default: @code{#f})
>> +When set to a string, call @code{chroot} with that directory.
>
> How about ‘working-directory’ and ‘root-directory’ for these two, in
> line with widespread naming convention?
>
> And instead of “call chroot”, I’d write “use this directory as the
> process's root (``chroot'' into it).” (again in an effort to avoid
> jargon and abbreviations).
>
> Other than that LGTM!

I cannot say I particularly agree with that.  I would consider both
`chdir' and `chroot' being terms familiar to anyone who would actually
want to configure them, and the terms map cleanly to the mingetty(8).

In any case, I do appreciate the review and I have sent a v3 with the
requested changes.

Have a nice day,
Tomas

-- 
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.