GNU bug report logs - #74508
[PATCH 0/2] Improvements for mingetty-service-type

Previous Next

Package: guix-patches;

Reported by: Tomas Volf <~@wolfsden.cz>

Date: Sun, 24 Nov 2024 14:29:02 UTC

Severity: normal

Tags: patch

Done: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


Message #35 received at 74508 <at> debbugs.gnu.org (full text, mbox):

From: Tomas Volf <~@wolfsden.cz>
To: 74508 <at> debbugs.gnu.org
Cc: Tomas Volf <~@wolfsden.cz>
Subject: [PATCH v3 2/3] services: mingetty: Rename misnamed accessors.
Date: Tue,  3 Dec 2024 01:11:38 +0100
Rename the accessors to ensure all start with `mingetty-configuration-'
prefix.  Some were named just `mingetty-$FIELD', instead of
`mingetty-configuration-$FIELD'.

The renaming *is* backwards compatible, since in the define-module's #:export
argument the correct (`mingetty-configuration-$FIELD') were used already and
thus the accessors were not accessible.

* gnu/services/base.scm (<mingetty-configuration>): Rename accessors for
auto-login, login-program, login-pause?, clear-on-logout?.

Change-Id: I4557a82498805ade0b341feda9d33eccc305690f
---
v2: Now is a separate commit.

 gnu/services/base.scm | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/gnu/services/base.scm b/gnu/services/base.scm
index 798356ed84..f1995640f1 100644
--- a/gnu/services/base.scm
+++ b/gnu/services/base.scm
@@ -1248,14 +1248,14 @@ (define-record-type* <mingetty-configuration>
   mingetty-configuration?
   (mingetty          mingetty-configuration-mingetty ;file-like
                      (default mingetty))
-  (tty               mingetty-configuration-tty) ;string
-  (auto-login        mingetty-auto-login         ;string | #f
+  (tty               mingetty-configuration-tty)       ;string
+  (auto-login        mingetty-configuration-auto-login ;string | #f
                      (default #f))
-  (login-program     mingetty-login-program ;gexp
+  (login-program     mingetty-configuration-login-program ;gexp
                      (default #f))
-  (login-pause?      mingetty-login-pause? ;Boolean
+  (login-pause?      mingetty-configuration-login-pause? ;Boolean
                      (default #f))
-  (clear-on-logout?  mingetty-clear-on-logout? ;Boolean
+  (clear-on-logout?  mingetty-configuration-clear-on-logout? ;Boolean
                      (default #t))
   (delay             mingetty-configuration-delay ;Integer | #f
                      (default #f))
--
2.46.0




This bug report was last modified 218 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.