GNU bug report logs - #74508
[PATCH 0/2] Improvements for mingetty-service-type

Previous Next

Package: guix-patches;

Reported by: Tomas Volf <~@wolfsden.cz>

Date: Sun, 24 Nov 2024 14:29:02 UTC

Severity: normal

Tags: patch

Done: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Ludovic Courtès <ludo <at> gnu.org>
To: Tomas Volf <~@wolfsden.cz>
Cc: 74508 <at> debbugs.gnu.org, Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: [bug#74508] [PATCH v2 1/3] services: mingetty: Add additional configuration options.
Date: Mon, 02 Dec 2024 12:05:48 +0100
Hi,

Tomas Volf <~@wolfsden.cz> skribis:

> +@item @code{chdir} (default: @code{#f})
> +When set to a string, change into that directory before calling the
> +login program.
> +
> +@item @code{chroot} (default: @code{#f})
> +When set to a string, call @code{chroot} with that directory.

How about ‘working-directory’ and ‘root-directory’ for these two, in
line with widespread naming convention?

And instead of “call chroot”, I’d write “use this directory as the
process's root (``chroot'' into it).” (again in an effort to avoid
jargon and abbreviations).

Other than that LGTM!

Ludo’.




This bug report was last modified 219 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.