GNU bug report logs - #74506
[PATCH] gnu: fonts: Add font-dina

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 74506 in the body.
You can then email your comments to 74506 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: 8dcc <8dcc.git <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: fonts: Add font-dina
Date: Sat, 23 Nov 2024 23:33:11 +0100

* gnu/packages/fonts.scm (font-dina): New variable.
---
Not only is this my first patch to Guix, but also my first patch sent
via email. Excuse me if I made any mistakes.

 gnu/packages/fonts.scm | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
index 65232db3b8..25a15348be 100644
--- a/gnu/packages/fonts.scm
+++ b/gnu/packages/fonts.scm
@@ -3874,3 +3874,22 @@ (define-public font-teko
 full support for the conjuncts and ligatures required by languages
 written with the Devanagari script.")
       (license license:silofl1.1))))
+
+(define-public font-dina
+  (package
+    (name "font-dina")
+    (version "2.92")
+    (source (origin
+              (method url-fetch/zipbomb)
+              (uri "https://www.dcmembers.com/jibsen/download/61/?wpdmdl=61")
+              (file-name "Dina.zip")
+              (sha256
+               (base32
+                "1kq86lbxxgik82aywwhawmj80vsbz3hfhdyhicnlv9km7yjvnl8z"))))
+    (build-system font-build-system)
+    (home-page "https://www.dcmembers.com/jibsen/download/61/")
+    (synopsis "Dina programming font")
+    (description "Dina is a monospace bitmap font, primarily aimed at
+programmers. It is relatively compact to allow a lot of code on screen, while
+(hopefully) clear enough to remain readable even at high resolutions.")
+    (license license:expat)))
-- 
2.47.0

Message #8 received at 74506 <at> debbugs.gnu.org (full text, mbox):

From: Noé Lopez <noe <at> xn--no-cja.eu>
To: control <at> debbugs.gnu.org,74506 <at> debbugs.gnu.org
Subject: QA review for 74506
Date: Sun, 24 Nov 2024 15:49:10 +0100

user guix
usertag 74506 + reviewed-looks-good
thanks

Guix QA review form submission:
Hi, thanks for your patch!

Everything works well, it is just missing a dot in the commit message,
and a double space between sentences in the description.  I’m sending an
amended patch with these two changes.

Additionally, it is best to avoid adding your packages at the end of the
file to avoid merge conflicts, just put them where you feel like it or
near a related package.

Have a nice day,
Noé Lopez

Items marked as checked: Lint warnings, Package builds, Commit messages, New package licenses, New package synopsis and descriptions

Message #11 received at 74506 <at> debbugs.gnu.org (full text, mbox):

From: Noé Lopez <noe <at> xn--no-cja.eu>
To: 74506 <at> debbugs.gnu.org
Cc: Noé Lopez <noe <at> xn--no-cja.eu>
Subject: [PATCH v2] gnu: fonts: Add font-dina.
Date: Sun, 24 Nov 2024 15:53:23 +0100

From: 8dcc <8dcc.git <at> gmail.com>

* gnu/packages/fonts.scm (font-dina): New variable.

Change-Id: I10f63e17754227145d72b1fc3380a532d74cef55
---
 gnu/packages/fonts.scm | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
index 65232db3b8..69d7d039aa 100644
--- a/gnu/packages/fonts.scm
+++ b/gnu/packages/fonts.scm
@@ -3874,3 +3874,22 @@ (define-public font-teko
 full support for the conjuncts and ligatures required by languages
 written with the Devanagari script.")
       (license license:silofl1.1))))
+
+(define-public font-dina
+  (package
+    (name "font-dina")
+    (version "2.92")
+    (source (origin
+              (method url-fetch/zipbomb)
+              (uri "https://www.dcmembers.com/jibsen/download/61/?wpdmdl=61")
+              (file-name "Dina.zip")
+              (sha256
+               (base32
+                "1kq86lbxxgik82aywwhawmj80vsbz3hfhdyhicnlv9km7yjvnl8z"))))
+    (build-system font-build-system)
+    (home-page "https://www.dcmembers.com/jibsen/download/61/")
+    (synopsis "Dina programming font")
+    (description "Dina is a monospace bitmap font, primarily aimed at programmers.
+It is relatively compact to allow a lot of code on screen, while (hopefully) clear
+enough to remain readable even at high resolutions.")
+    (license license:expat)))

base-commit: 3feaac67a3426c7412e845f1ad9e6596235a3586
prerequisite-patch-id: d60665f9abfbc424d08418ccbc1ceaa14437e160
-- 
2.46.0

Message #16 received at 74506-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Noé Lopez <noe <at> xn--no-cja.eu>
Cc: 74506-done <at> debbugs.gnu.org, Zhu Zihao <all_but_last <at> 163.com>,
 宋文武 <iyzsong <at> envs.net>, 8dcc <8dcc.git <at> gmail.com>
Subject: Re: [bug#74506] [PATCH v2] gnu: fonts: Add font-dina.
Date: Fri, 29 Nov 2024 15:03:30 +0100

Noé Lopez <noe <at> noé.eu> skribis:

> From: 8dcc <8dcc.git <at> gmail.com>
>
> * gnu/packages/fonts.scm (font-dina): New variable.
>
> Change-Id: I10f63e17754227145d72b1fc3380a532d74cef55

Applied, thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.