GNU bug report logs - #745
pop-to-buffer, frames, and input focus

Previous Next

Full log

View this message in rfc822 format

From: David Reitter <david.reitter <at> gmail.com>
To: Helmut Eller <eller.helmut <at> gmail.com>, 745 <at> debbugs.gnu.org
Cc: martin rudalics <rudalics <at> gmx.at>
Subject: bug#745: pop-to-buffer, frames, and input focus
Date: Wed, 20 Aug 2008 16:42:17 -0400

[Message part 1 (text/plain, inline)]

On 20 Aug 2008, at 14:42, Helmut Eller wrote:
>  Are you saying, that pop-to-buffer can't be used to select the  
> window,
> the frame, and input focus at the same time?  If so, when should
> pop-to-buffer be used?  Aren't that unusual situations when
> pop-to-buffer should not also select the input focus?


I have long used the patch below in Aquamacs to create consistency  
between multi-frame and multi-window operations.  Most packages are  
designed to work with the multi-window setup, and it is my conviction  
that most Emacs developers work with the Emacs default (multi- 
window).  Perhaps that is why some packages do not play ball when  
buffers are set to pop up in new frames...


*** src/buffer.c	25 Feb 2006 23:33:57 +0000	1.501
--- src/buffer.c	07 May 2006 22:45:45 +0100	
***************
*** 175,180 ****
--- 175,182 ----
  Lisp_Object Qinsert_in_front_hooks;
  Lisp_Object Qinsert_behind_hooks;

+ Lisp_Object Qselect_frame_set_input_focus;
+
  static void alloc_buffer_text P_ ((struct buffer *, size_t));
  static void free_buffer_text P_ ((struct buffer *b));
  static struct Lisp_Overlay * copy_overlays P_ ((struct buffer *,  
struct Lisp_Overlay *));
***************
*** 1723,1729 ****
  	}
      }
    Fset_buffer (buf);
!   Fselect_window (Fdisplay_buffer (buf, other_window, Qnil),  
norecord);
    return buf;
  }

--- 1725,1734 ----
  	}
      }
    Fset_buffer (buf);
!   call1(Qselect_frame_set_input_focus,
! 	Fwindow_frame( Fselect_window (Fdisplay_buffer (buf,
! 							other_window, Qnil),
! 				       norecord)));
    return buf;
  }

***************
*** 5227,5232 ****
--- 5232,5239 ----
    Qafter_change_functions = intern ("after-change-functions");
    staticpro (&Qafter_change_functions);
    staticpro (&Qucs_set_table_for_input);
+   Qselect_frame_set_input_focus = intern ("select-frame-set-input- 
focus");
+   staticpro (&Qselect_frame_set_input_focus);

    Qkill_buffer_query_functions = intern ("kill-buffer-query- 
functions");
    staticpro (&Qkill_buffer_query_functions);

[smime.p7s (application/pkcs7-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.