Subject: bug#74499: [PATCH] Avoid loading 'rx' at runtime in 'lua-ts-mode'

From: john muhl <[email-masked]>
Date: Mon, 25 Nov 2024 20:04:09 -0600

Philip Kaludercic <[email-masked]> writes:

> john muhl <[email-masked]> writes:
>
>> From 309e80a336bce5c4a9191c87af636b8adfc04b97 Mon Sep 17 00:00:00 2001
>> From: john muhl <[email-masked]>
>> Date: Sat, 23 Nov 2024 14:08:21 -0600
>> Subject: [PATCH] Avoid loading 'rx' at runtime in 'lua-ts-mode'
>>
>> * lisp/progmodes/lua-ts-mode.el (lua-ts-inferior-lua):
>> Replace 'rx-to-string' and substitution with 'rx' and 'literal'.
>>
>> (Bug#74499)
>> ---
>>  lisp/progmodes/lua-ts-mode.el | 16 ++++++++--------
>>  1 file changed, 8 insertions(+), 8 deletions(-)
>>
>> diff --git a/lisp/progmodes/lua-ts-mode.el b/lisp/progmodes/lua-ts-mode.el
>> index f88fe0e49af..828636f359d 100644
>> --- a/lisp/progmodes/lua-ts-mode.el
>> +++ b/lisp/progmodes/lua-ts-mode.el
>> @@ -659,9 +659,9 @@ lua-ts-inferior-lua
>>          (setq-local comint-input-ignoredups t
>>                      comint-input-ring-file-name lua-ts-inferior-history
>>                      comint-prompt-read-only t
>> -                    comint-prompt-regexp (rx-to-string `(: bol
>> -                                                           ,lua-ts-inferior-prompt
>> -                                                           (1+ space))))
>> +                    comint-prompt-regexp (rx bol
>> +                                             (literal lua-ts-inferior-prompt)
>> +                                             (1+ space)))
>
> Strictly speaking this could have introduced a regression, since literal
> quotes the string, and it might be that someone has set
> `lua-ts-inferior-prompt' to a quoted regular expression that is now
> double-quoted, but I assume that this is an acceptable edge-case?

It doesn’t strike me as a significant issue but I don’t customize
prompts so maybe it’s in my blind spot. Feel free to revert it or
not as you see fit.